Re: [PATCH RFC 1/5] drm: Support post-blend color pipeline API

2025-09-26 Thread Sebastian Wick
(Sorry for re-sending; used a web mail client which send html) On Mon, Sep 15, 2025, at 2:31 PM, Daniel Stone wrote: > Hi Nícolas, > > On Wed, 3 Sept 2025 at 19:43, Nícolas F. R. A. Prado > wrote: > > On Tue, 2025-08-26 at 13:25 +0100, Daniel Stone wrote: > > Based on this discussion, this is my

Re: [PATCH RFC 1/5] drm: Support post-blend color pipeline API

2025-09-26 Thread Sebastian Wick
On Mon, Sep 15, 2025, at 2:31 PM, Daniel Stone wrote: > Hi Nícolas, > > On Wed, 3 Sept 2025 at 19:43, Nícolas F. R. A. Prado > wrote: > > On Tue, 2025-08-26 at 13:25 +0100, Daniel Stone wrote: > > Based on this discussion, this is my understanding for the changes > > desired on the series and t

Re: [PATCH] drm/panel: sitronix-st7789v: fix sync flags for t28cp45tn89

2025-09-25 Thread Sebastian Reichel
Hello Marek, On Thu, Sep 25, 2025 at 02:15:41AM +0200, Marek Vasut wrote: > On 9/24/25 11:46 PM, Sebastian Reichel wrote: > > From: Sebastian Reichel > > > > I planned to set the polarity of horizontal and vertical sync, but > > accidentally described vertical sync tw

[PATCH] drm/panel: sitronix-st7789v: fix sync flags for t28cp45tn89

2025-09-24 Thread Sebastian Reichel
From: Sebastian Reichel I planned to set the polarity of horizontal and vertical sync, but accidentally described vertical sync twice with different polarity instead. Note, that there is no functional change, because the driver only makes use of DRM_MODE_FLAG_P[HV]SYNC to divert from the

Re: [PATCH 7/9] drm/rcar-du: dsi: Clean up handling of DRM mode flags

2025-09-23 Thread Sebastian Reichel
and P > flags (drivers/gpu/drm/panel/panel-sitronix-st7789v.c, see > t28cp45tn89_mode, which I assume is a bug - Sebastian, could you check > that ?). Yeah, it was supposed to be static const struct drm_display_mode t28cp45tn89_mode = { ... .flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLA

Re: [PATCH v2 0/2] Add "pixel_encoding" to switch between RGB & YUV color modes

2025-09-01 Thread Sebastian Wick
On Wed Aug 27, 2025 at 1:08 PM CEST, Sebastian Wick wrote: > On Wed Aug 27, 2025 at 12:39 PM CEST, Daniel Stone wrote: >> Hey, >> >> On Wed, 27 Aug 2025 at 10:41, Maxime Ripard wrote: >>> On Wed, Aug 27, 2025 at 12:26:56AM +0800, Shengyu Qu wrote: >>> >

dri-devel@lists.freedesktop.org

2025-08-30 Thread Sebastian Reichel
ith extra checks. > > In addtion, DRM_DEV_ERROR() is replaced by dev_err_probe(). > > Signed-off-by: Damon Ding > > -- Reviewed-by: Sebastian Reichel -- Sebastian > > Changes in v2: > - Replace DRM_DEV_ERROR() with dev_err_probe(). > --- > drivers/gpu/

Re: [PATCH RFC 1/5] drm: Support post-blend color pipeline API

2025-08-27 Thread Sebastian Wick
On Fri Aug 22, 2025 at 8:36 PM CEST, Nícolas F. R. A. Prado wrote: > Introduce support for a post-blend color pipeline API analogous to the > pre-blend color pipeline API. While the pre-blend color pipeline was > configured through a COLOR_PIPELINE property attached to a drm_plane, > the post-blend

Re: [PATCH v2 0/2] Add "pixel_encoding" to switch between RGB & YUV color modes

2025-08-27 Thread Sebastian Wick
On Wed Aug 27, 2025 at 12:39 PM CEST, Daniel Stone wrote: > Hey, > > On Wed, 27 Aug 2025 at 10:41, Maxime Ripard wrote: >> On Wed, Aug 27, 2025 at 12:26:56AM +0800, Shengyu Qu wrote: >> > 1.Can you send patch with only i915/amdgpu first? It's a long-needed >> > feature >> > to deal with some moni

Re: [PATCH V11 00/47] Color Pipeline API w/ VKMS

2025-08-21 Thread Sebastian Wick
With the small improvements, the core drm parts are Reviewed-by: Sebastian Wick On Fri Aug 15, 2025 at 5:49 AM CEST, Alex Hung wrote: > This is an RFC set for a color pipeline API, along with implementations > in VKMS and amdgpu. It is tested with a set of IGT tests that can be > fo

Re: [PATCH V11 35/47] drm/colorop: Add 1D Curve Custom LUT type

2025-08-21 Thread Sebastian Wick
On Wed Aug 20, 2025 at 8:16 PM CEST, Alex Hung wrote: > > > On 8/19/25 09:31, Sebastian Wick wrote: >>> +/** >>> + * drm_plane_colorop_curve_1d_lut_init - Initialize a DRM_COLOROP_1D_LUT >>> + * >>> + * @dev: DRM device >>> + * @colorop: Th

Re: [PATCH V11 35/47] drm/colorop: Add 1D Curve Custom LUT type

2025-08-19 Thread Sebastian Wick
On Fri Aug 15, 2025 at 5:50 AM CEST, Alex Hung wrote: > We've previously introduced DRM_COLOROP_1D_CURVE for > pre-defined 1D curves. But we also have HW that supports > custom curves and userspace needs the ability to pass > custom curves, aka LUTs. > > This patch introduces a new colorop type, ca

Re: [PATCH V11 07/47] drm/colorop: Add BYPASS property

2025-08-19 Thread Sebastian Wick
On Fri Aug 15, 2025 at 5:49 AM CEST, Alex Hung wrote: > From: Harry Wentland > > We want to be able to bypass each colorop at all times. > Introduce a new BYPASS boolean property for this. > > Reviewed-by: Simon Ser > Reviewed-by: Louis Chauvet > Signed-off-by: Alex Hung > Signed-off-by: Harry

Re: [PATCH V11 06/47] drm/colorop: Add 1D Curve subtype

2025-08-19 Thread Sebastian Wick
On Fri Aug 15, 2025 at 5:49 AM CEST, Alex Hung wrote: > From: Harry Wentland > > Add a new drm_colorop with DRM_COLOROP_1D_CURVE with two subtypes: > DRM_COLOROP_1D_CURVE_SRGB_EOTF and DRM_COLOROP_1D_CURVE_SRGB_INV_EOTF. > > Reviewed-by: Simon Ser > Reviewed-by: Louis Chauvet > Signed-off-by: Ha

Re: [PATCH v6 09/10] arm64: dts: rockchip: Enable DisplayPort for rk3588s Cool Pi 4B

2025-08-15 Thread Sebastian Reichel
Hi, On Thu, Jul 31, 2025 at 10:52:49AM +0800, Andy Yan wrote: > > Hello Sebastian, > > 在 2025-07-30 20:15:44,"Andy Yan" 写道: > > > > > >Hello Sebastian, > > > >At 2025-07-30 01:09:41, "Sebastian Reichel" > > wrote: >

Re: [PATCH v6 02/10] drm/bridge: synopsys: Add DW DPTX Controller support library

2025-08-15 Thread Sebastian Reichel
o work (I'm still fighting with getting that part stable, but that issue is on the USB-PD side). Tested-by: Sebastian Reichel -- Sebastian > --- > > Changes in v6: > - Use drm_dp_vsc_sdp_supported > - Store bpc/bpp/color format in dw_dp_bridge_state > > Changes in v5:

Re: [PATCH v6 09/10] arm64: dts: rockchip: Enable DisplayPort for rk3588s Cool Pi 4B

2025-07-29 Thread Sebastian Reichel
o have the USBDP PHY described in the graph as a transparent bridge? Note, that the USBDP PHY DT binding is currently not ready for this (this also affects the next patch, but should be enough to discuss this once :)). Greetings, -- Sebastian > > (no changes since v2) > &g

Re: [PATCH v6 08/10] arm64: dts: rockchip: Add DP1 for rk3588

2025-07-29 Thread Sebastian Reichel
cription matches the TRM: Reviewed-by: Sebastian Reichel Greetings, -- Sebastian > > (no changes since v1) > > .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 30 +++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.

Re: [PATCH v6 07/10] arm64: dts: rockchip: Add DP0 for rk3588

2025-07-29 Thread Sebastian Reichel
cription matches the TRM: Reviewed-by: Sebastian Reichel Greetings, -- Sebastian > > (no changes since v1) > > arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 30 +++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.

Re: [PATCH v2 02/15] drm/panel: panel-samsung-s6e63m0: Include

2025-07-15 Thread Sebastian Reichel
Hi, On Tue, Jul 15, 2025 at 02:24:39PM +0200, Thomas Zimmermann wrote: > Include to declare device_property_read_u32(). Avoids > dependency on backlight header to include it. device_property_*() is from , which is already included in the following line... Greetings, -- Sebastian >

Re: [PATCH 2/2] drivers/panel: raydium-rm67200: Make reset-gpio optional

2025-06-19 Thread Sebastian Reichel
the reset. This > is the way it is done on our numerous development boards (such as > RK3568/RK3576 EVB). > > So make the reset-gpio optional. > > Signed-off-by: Andy Yan > --- Reviewed-by: Sebastian Reichel Greetings, -- Sebastian > > drivers/gpu/drm/panel/panel-ra

Re: [PATCH 1/2] dt-bindings: display: panel: Make reset-gpio as optional for Raydium RM67200

2025-06-19 Thread Sebastian Reichel
the reset. This > is the way it is done on our numerous development boards (such as RK3568, > RK3576 EVB). > So make the reset-gpio optional. > > Signed-off-by: Andy Yan > --- Reviewed-by: Sebastian Reichel Greetings, -- Sebastian > > .../devicetree/bindings/display/pane

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-10 Thread Sebastian Brzezinka
2 IOCTL, another reference to the > timeline is got, and only that last one is put on successful completion. > As a consequence, the legacy timeline, with its underlying engine status > page's VMA object, is still held and not released on driver unbind. > > Get the legacy timeline only after successful allocation of the context > engine's VMA. > > Fixes: 75d0a7f31eec ("drm/i915: Lift timeline into intel_context") > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061 > Cc: Chris Wilson > Cc: Matthew Auld > Signed-off-by: Janusz Krzysztofik Everything looks good to me overall. Reviewed-by: Sebastian Brzezinka -- Best regards, Sebastian

Re: [PATCH v2] drm/amd/display/dc/irq: Remove duplications of hpd_ack function from IRQ

2025-05-10 Thread Sebastian Aguilera Novoa
{ "emoji": "👍", "version": 1 }

[PATCH v2] drm/amd/display/dc/irq: Remove duplications of hpd_ack function from IRQ

2025-05-04 Thread Sebastian Aguilera Novoa
ction is replaced by hpd0_ack and hpd1_ack, the required constants are also added. The changes were not tested on actual hardware. I am only able to verify that the changes keep the code compileable and do my best to look repeatedly if I am not actually changing any code. Signed-off-by: Seba

[PATCH] drm/amd/display/dc/irq: Remove duplications of hpd_ack function from IRQ

2025-05-02 Thread Sebastian Aguilera Novoa
ction is replaced by hpd0_ack and hpd1_ack, the required constants are also added. The changes were not tested on actual hardware. I am only able to verify that the changes keep the code compileable and do my best to look repeatedly if I am not actually changing any code. Signed-off-by: Seba

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Sebastian Andrzej Siewior
f[intf_id].irq < 0) > return; > > - ret = generic_handle_irq(gt->gsc.intf[intf_id].irq); > + ret = generic_handle_irq_safe(gt->gsc.intf[intf_id].irq); > + that extra line looks odd, other than that Acked-by: Sebastian Andrzej Siewior > if (ret) >

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-25 Thread Sebastian Andrzej Siewior
1e3dc1d8622b ("drm/i915/gsc: add gsc as a mei auxiliary device") > Tested-by: Furong Zhou > Suggested-by: Sebastian Andrzej Siewior > Signed-off-by: Junxiao Chang > --- > drivers/gpu/drm/i915/gt/intel_gsc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) &g

Re: RE: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-24 Thread Sebastian Andrzej Siewior
as other parts of the kernel. Sebastian

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-04-24 Thread Sebastian Andrzej Siewior
!irq_disabled_flag) > + local_irq_disable(); > +#endif > ret = generic_handle_irq(gt->gsc.intf[intf_id].irq); What about generic_handle_irq_safe() instead the whole ifdef show? > +#ifdef CONFIG_PREEMPT_RT > + if (!irq_disabled_flag) > + local_irq_enable(); > +#endif > + > if (ret) > gt_err_ratelimited(gt, "error handling GSC irq: %d\n", ret); > } Sebastian

Re: [PATCH v2 4/4] arm64: dts: rockchip: Enable HDMI1 on rock-5b

2025-03-31 Thread Sebastian Reichel
all/Z+pFou7KOQZJ1iy4@vaman/ [1] https://web.git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/commit/?h=next&id=f08d1c08563846f9be79a4859e912c8795d690fd Greetings, -- Sebastian

Re: [PATCH] drm/rockchip: dw_hdmi_qp: Fix io init for dw_hdmi_qp_rockchip_resume

2025-03-17 Thread Sebastian Reichel
588_GRF_VO1_CON9, val); > + cfg = of_device_get_match_data(dev); > + cfg->ctrl_ops->io_init(hdmi); I think it would be better to store the ctrl_ops (or io_init) callback in struct rockchip_hdmi_qp during driver probe and avoid another lookup of the match_data, which involves string comparisons. Otherwise: Reviewed-by: Sebastian Reichel Greetings, -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 6/9] power: supply: pcf50633: Remove charger

2025-03-12 Thread Sebastian Reichel
.org/all/Z8z236h4B5A6Ki3D@gallifrey/ > > Remove it. > > [...] Applied, thanks! [6/9] power: supply: pcf50633: Remove charger commit: aae075a93f7705e29c599d101abc7e467125d871 Best regards, -- Sebastian Reichel

Re: [PATCH] drm/rockchip: vop2: add missing bitfield.h include

2025-03-03 Thread Sebastian Reichel
e used > FIELD_PREP macro. Add this missing include. > > Fixes: 328e6885996c ("drm/rockchip: vop2: Add platform specific callback") > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202503040135.fgoywdlb-...@intel.com/ > Signed-off

Re: [PATCH RFC] backlight: pwm_bl: Read back PWM period from provider

2025-02-26 Thread Sebastian Reichel
ably should at least get a MAINTAINERS entry to have you CC'd considering all the PWM bits in it). See the following discussion (I point you to my message in the middle of a thread, which has a summary and probably is a good starting point): https://lore.kernel.org/all/vc7irlp7nuy5yvkxwb5m7wy7

[PATCH v3 1/2] dt-bindings: display: panel: Add Raydium RM67200

2025-02-25 Thread Sebastian Reichel
The Rockchip W552793DBA-V10 display/touchscreen board contains a Wanchanglong W552793BAA panel, which in turn is using a Raydium RM67200 MIPI-DSI controller. Add a DT binding for the DSI panel. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- .../bindings/display/panel

[PATCH v3 2/2] drm/panel: add Raydium RM67200 panel driver

2025-02-25 Thread Sebastian Reichel
-by: Jessica Zhang Reviewed-by: Andy Yan Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-raydium-rm67200.c | 499 ++ 3 files changed, 510

[PATCH v3 0/2] Rockchip W552793DBA-V10 panel support

2025-02-25 Thread Sebastian Reichel
. Greetings, -- Sebastian --- Sebastian Reichel (2): dt-bindings: display: panel: Add Raydium RM67200 drm/panel: add Raydium RM67200 panel driver .../bindings/display/panel/raydium,rm67200.yaml| 72 +++ drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel

Re: [PATCH v2 0/2] Rockchip W552793DBA-V10 panel support

2025-02-24 Thread Sebastian Reichel
Hi, On Fri, Feb 07, 2025 at 05:21:46PM +0100, Sebastian Reichel wrote: > This has been tested in combination with the series from Heiko Stübner > enabling DSI support for the RK3588 [0] (DSI controller support has been > merged already, only the PHY support is missing) on the RK3588 EVB1

Re: [PATCH v2] drm/i915: Fix harmfull driver register/unregister assymetry

2025-02-20 Thread Sebastian Brzezinka
> - intel_pxp_fini(dev_priv); > - > for_each_gt(gt, dev_priv, i) > intel_gt_driver_unregister(gt); > > i915_hwmon_unregister(dev_priv); > > i915_perf_unregister(dev_priv); > - i915_pmu_unregister(dev_priv); > > i915_teardown_sysfs(dev_priv); > + > +not_registered: > + intel_pxp_fini(dev_priv); > + i915_pmu_unregister(dev_priv); > + > drm_dev_unplug(&dev_priv->drm); > > i915_gem_driver_unregister(dev_priv); > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index ffc346379cc2c..27a23b1eb9de0 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -347,6 +347,8 @@ struct drm_i915_private { > /* The TTM device structure. */ > struct ttm_device bdev; > > + bool registered; Isn't `struct·drm_device` already has a registered field that could be used, instead of introducing new variable. It's set in `int·drm_dev_register(struct·drm_device·*dev,·unsigned·long·flags)` -- Best regards, Sebastian

Re: [PATCH 3/4] arm64: dts: rockchip: Add HDMI1 PHY PLL clock source to VOP2 on RK3588

2025-02-18 Thread Sebastian Reichel
Hi, On Tue, Feb 18, 2025 at 03:53:06PM +0100, Heiko Stübner wrote: > Am Dienstag, 18. Februar 2025, 15:13:07 MEZ schrieb Sebastian Reichel: > > On Tue, Feb 18, 2025 at 08:17:46PM +0800, Jianfeng Liu wrote: > > > On Tue, 18 Feb 2025 11:00:57 +0100, Heiko Stübnerwrote: >

Re: [PATCH v5 3/3] drm/i915/display: Add i915 hook for format_mod_supported_async

2025-02-18 Thread Sebastian Brzezinka
t; > Signed-off-by: Arun R Murthy > Reviewed-by: Chaitanya Kumar Borah > Tested-by: Naveen Kumar LGTM Reviewed-by: Sebastian Brzezinka -- Best regards, Sebastian

Re: [PATCH 3/4] arm64: dts: rockchip: Add HDMI1 PHY PLL clock source to VOP2 on RK3588

2025-02-18 Thread Sebastian Reichel
uilt-in and the HDMI PHY is build as a module. But I also think it would be better to have the clocks defined in the SoC level DT. I suppose that means vop2_bind would have to check if the HDMI controller is enabled and only requests pll_hdmiphy based on that. Considering there is the OF graph

Re: [PATCH v6 00/14] Add eDP support for RK3588

2025-02-13 Thread Sebastian Reichel
s relevant, but while HDMI0 got enabled for quite a > few devices in 6.13, it did NOT get enabled for Rock 5 ITX. > I made a local patch (which does the same thing as was done for Rock 5B) > but I have no idea if it actually works (I don't have the board). I don't have the board either, but the schematics suggests that your patch is not correct. On the Rock 5 ITX the RK3588's first HDMI/eDP port should be enabled in eDP mode to be used with an eDP panel via connector J11. This series is needed for that. Greetings, -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v6 00/14] Add eDP support for RK3588

2025-02-13 Thread Sebastian Reichel
is not yet supported upstream and there is no pending patchset. As far as I know Rockchip plans to work on preparing upstream support for that soon. Note, that the two DisplayPort controllers are completely different. The HDMI/eDP controller is a design from Analogix and the TypeC/DP controller is a design from Synopsys. P.S.: Heiko merged support for HDMI1 (RK3588 SoC level) recently. So you should be able to get that running by some DT additions to the Rock 5 ITX board DT with the latest linux-next code :) Greetings, -- Sebastian signature.asc Description: PGP signature

[PATCH v1] drm/edp-panel: Add panel used by T14s Gen6 Snapdragon

2025-02-10 Thread Sebastian Reichel
From: Sebastian Reichel The Lenovo Thinkpad T14s Gen6 Snapdragon is currently sold with three different panel versions: OLED, Low Power IPS or IPS with Touchscreen. My Low Power IPS version had this panel and the kernel complained about not knowing any details. I don't have any

[PATCH v2 0/2] Rockchip W552793DBA-V10 panel support

2025-02-07 Thread Sebastian Reichel
having a look. Greetings, -- Sebastian --- Sebastian Reichel (2): dt-bindings: display: panel: Add Raydium RM67200 drm/panel: add Raydium RM67200 panel driver .../bindings/display/panel/raydium,rm67200.yaml| 72 +++ drivers/gpu/drm/panel/Kconfig | 10

[PATCH v2 2/2] drm/panel: add Raydium RM67200 panel driver

2025-02-07 Thread Sebastian Reichel
-by: Jessica Zhang Reviewed-by: Andy Yan Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-raydium-rm67200.c | 503 ++ 3 files changed, 514

[PATCH v2 1/2] dt-bindings: display: panel: Add Raydium RM67200

2025-02-07 Thread Sebastian Reichel
The Rockchip W552793DBA-V10 display/touchscreen board contains a Wanchanglong W552793BAA panel, which in turn is using a Raydium RM67200 MIPI-DSI controller. Add a DT binding for the DSI panel. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- .../bindings/display/panel

Re: [PATCH] drm/i915/selftests: avoid using uninitialized context

2025-01-27 Thread Sebastian Brzezinka
goto err_ppgtt_cleanup; + if (!ppgtt->vm.allocate_va_range) { + i915_vm_put(&ppgtt->vm); + return 0; + } -- Best regards, Sebastian

Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-01-27 Thread Sebastian Brzezinka
6872a2c ("drm/i915/pxp: Implement PXP irq handler") > Fixes: 3e7abf814193 ("drm/i915: Extract GT render power state management") > > Signed-off-by: Zhanjun Dong > Reviewed-by: Sebastian Brzezinka -- Best regards, Sebastian

Re: [PATCH] drm/rockchip: Fix Copyright description

2024-12-12 Thread Sebastian Reichel
ndy Yan > --- Reviewed-by: Sebastian Reichel -- Sebastian > > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- > drivers/gpu/drm/rockchip/cdn-dp-reg.c | 2 +- > drivers/gpu/drm/rockchip/cdn-dp

Re: [PATCH v1 2/2] drm/panel: add Raydium RM67200 panel driver

2024-12-10 Thread Sebastian Reichel
to the W552793BAA. I put the regulators into the panel specific section, because the datasheet for the RM67200 specifies slightly different ones than the w552793baa datasheet. Thus I expect that other displays might have slight differences. Greetings, -- Sebastian signature.asc Description: PGP signature

[PATCH v1 0/2] Rockchip W552793DBA-V10 panel support

2024-12-10 Thread Sebastian Reichel
...@sntech.de/ Thanks for having a look. Greetings, -- Sebastian Sebastian Reichel (2): dt-bindings: display: panel: Add Raydium RM67200 drm/panel: add Raydium RM67200 panel driver .../display/panel/raydium,rm67200.yaml| 72 +++ drivers/gpu/drm/panel/Kconfig | 8

[PATCH v1 2/2] drm/panel: add Raydium RM67200 panel driver

2024-12-10 Thread Sebastian Reichel
-by: Sebastian Reichel --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-raydium-rm67200.c | 503 ++ 3 files changed, 512 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel

[PATCH v1 1/2] dt-bindings: display: panel: Add Raydium RM67200

2024-12-10 Thread Sebastian Reichel
The Rockchip W552793DBA-V10 display/touchscreen board contains a Wanchanglong W552793BAA panel, which in turn is using a Raydium RM67200 MIPI-DSI controller. Add a DT binding for the DSI panel. Signed-off-by: Sebastian Reichel --- .../display/panel/raydium,rm67200.yaml| 72

Re: [PATCH v1 04/10] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode

2024-12-05 Thread Sebastian Reichel
plugging in and unplugging an HDMI or DP cable. I suppose you could fetch the PHY in power_on() and release it in power_off(). But using phy_set_mode() might indeed be better here. -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v1 04/10] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode

2024-12-02 Thread Sebastian Reichel
Hi, On Mon, Dec 02, 2024 at 11:28:13AM +0800, Damon Ding wrote: > Hi, > > On 2024/12/2 6:59, Sebastian Reichel wrote: > > Hi, > > > > On Sat, Nov 30, 2024 at 09:25:12PM +0100, Heiko Stübner wrote: > > > Am Freitag, 29. November 2024, 03:43:57 CET schrieb Dam

Re: [PATCH v1 04/10] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode

2024-12-01 Thread Sebastian Reichel
lly handled by the device core based on DT information, except for some drivers which have special needs. > > And other phys may want to support dynamic switching too, like the > > Rockchip USBDP combo phy. > > I guess USBDP is special in that in also does both modes dynamical > depending on its use (like type-c with option DP altmode) The USBDP PHY is indeed quite different from the PHYs in your list above, but for a different reason: All the combined PHYs you listed above only support one mode at the same time. E.g. you need to decide between PCIe, SATA and USB3 mode for the Naneng combophy. For the USBDP PHY the modes are not mutually exclusive. The USB controller can request the USBDP PHY in USB mode at the same time as the DP controller requests it in DP mode. Some additional registers configure how the lanes are being muxed. A typcial setup would be 2 lanes for USB3 and 2 lanes for DP. Greetings, -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2] drm/rockchip: vop2: fix rk3588 dp+dsi maxclk verification

2024-11-22 Thread Sebastian Reichel
too. > > Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588") > Signed-off-by: Heiko Stuebner > Reviewed-by: Quentin Schulz > Acked-by: Andy Yan > --- Reviewed-by: Sebastian Reichel Tested-by: Sebastian Reichel -- Sebastian > changes in v2: > - drop

Re: [PATCH v7 00/28] media: mediatek: add driver to support secure video decoder

2024-11-13 Thread Sebastian Fricke
, Sebastian Memory Definitions: secure memory - Memory allocated in the TEE (Trusted Execution Environment) which is inaccessible in the REE (Rich Execution Environment, i.e. linux kernel/user space). secure handle - Integer value which acts as reference to 'secure memory'. Used in communicati

Re: [PATCH 2/2] drm/rockchip: dsi: Don't log errors on deferred dphy

2024-11-08 Thread Sebastian Reichel
dev_err(). The recommended way to do this nowadays looks like this: return dev_err_probe(dev, PTR_ERR(dsi->phy), "Failed to get mipi dphy"); That will not print anything for -EPROBE_DEFER, but capture the reason and make it available through /sys/kernel/debug/devices_deferred if th

Re: [PATCH v4 01/27] power: supply: add undervoltage health status property

2024-09-14 Thread Sebastian Reichel
class-power and drivers/power/supply/power_supply_sysfs.c (POWER_SUPPLY_HEALTH_TEXT). Greetings, -- Sebastian > include/linux/power_supply.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h > index 910d407ebe6

Re: [PATCH 0/3] drm/omap: Minor fixes

2024-09-14 Thread Sebastian Reichel
Hi, On Tue, Aug 06, 2024 at 04:50:26PM GMT, Tomi Valkeinen wrote: > A few minor fixes to omapdrm, mostly to remove sparse or other checker > warnings. > > Tomi > > Signed-off-by: Tomi Valkeinen For the series: Reviewed-by: Sebastian Reichel Greetings, -- Sebastian >

[PATCH 2/2] Revert "drm/amd/display: add panel_power_savings sysfs entry to eDP connectors"

2024-08-06 Thread Sebastian Wick
From: Sebastian Wick This reverts commit 63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5. The panel_power_savings sysfs entry can be used to change the displayed colorimetry which breaks color managed setups. The "do not break userspace" rule which was violated here is enough reason to r

[PATCH 1/2] Revert "drm/amd/display: Don't register panel_power_savings on OLED panels"

2024-08-06 Thread Sebastian Wick
From: Sebastian Wick This reverts commit 76cb763e6ea62e838ccc8f7a1ea4246d690fccc9. Reverting the panel_power_savings sysfs. See next commit. Signed-off-by: Sebastian Wick --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +++ 1 file changed, 4 insertions(+), 25 deletions

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Sebastian Wick
On Fri, Aug 2, 2024 at 4:37 PM Harry Wentland wrote: > > On 2024-08-02 09:28, Sebastian Wick wrote: > > I'm very unhappy about how this has played out. > > > > We have a new sysfs property that controls a feature of the display > > path that has been set to a

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Sebastian Wick
I'm very unhappy about how this has played out. We have a new sysfs property that controls a feature of the display path that has been set to a default(!) which changes the color behavior! This broke color management for everyone who is on a device which supports this feature. What should have be

[PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-07-02 Thread Sebastian Wick
rt * Make it clear that drivers can choose between RGB and YCbCr on their own Signed-off-by: Sebastian Wick Reviewed-by: Pekka Paalanen --- drivers/gpu/drm/drm_connector.c | 79 + include/drm/drm_connector.h | 8 2 files changed, 61 insertions(+), 26

[PATCH REPOST^2] drm/ttm/tests: Let ttm_bo_test consider different ww_mutex implementation.

2024-06-19 Thread Sebastian Andrzej Siewior
nts to the correct function for PREEMPT_RT and non-PREEMPT_RT builds. Fixes: 995279d280d1e ("drm/ttm/tests: Add tests for ttm_bo functions") Signed-off-by: Sebastian Andrzej Siewior --- I posted this path https://lore.kernel.org/r/20240404102534.qta80...@linutronix.de Then

Re: [PATCH 4/9] arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588s

2024-06-13 Thread Sebastian Reichel
Tomeu Vizoso > --- Looking at the TRM I noticed, that this register is not mapped: RKNN_global_operation_enable Address: Operational Base + offset (0xF008) -- Sebastian > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 53 > +++ > 1 file changed, 53

Re: [PATCH 5/9] arm64: dts: rockchip: Enable the NPU on quartzpro64

2024-06-13 Thread Sebastian Reichel
in the DT file (so &rknn should not be added before &i2c). Greetings, -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 2/9] iommu/rockchip: Attach multiple power domains

2024-06-13 Thread Sebastian Reichel
Hi, On Thu, Jun 13, 2024 at 11:34:02AM GMT, Tomeu Vizoso wrote: > On Thu, Jun 13, 2024 at 11:24 AM Tomeu Vizoso wrote: > > On Thu, Jun 13, 2024 at 2:05 AM Sebastian Reichel > > wrote: > > > On Wed, Jun 12, 2024 at 03:52:55PM GMT, Tomeu Vizoso wrote: > > > >

Re: [PATCH REPOST] drm/ttm/tests: Let ttm_bo_test consider different ww_mutex implementation.

2024-06-13 Thread Sebastian Andrzej Siewior
rt_mutex … | #endif this is all in-tree. > So I don't feel well reviewing this. > > Regards, > Christian. Sebastian

[PATCH REPOST] drm/ttm/tests: Let ttm_bo_test consider different ww_mutex implementation.

2024-06-12 Thread Sebastian Andrzej Siewior
nts to the correct function for PREEMPT_RT and non-PREEMPT_RT builds. Fixes: 995279d280d1e ("drm/ttm/tests: Add tests for ttm_bo functions") Signed-off-by: Sebastian Andrzej Siewior --- Repost of https://lore.kernel.org/r/20240404102534.qta80...@linutronix.de drivers/gpu/drm/ttm/tests/

Re: [PATCH 2/9] iommu/rockchip: Attach multiple power domains

2024-06-12 Thread Sebastian Reichel
; pm_domain_count; i++) { > + err = > of_property_read_string_index(iommu->dev->of_node, "power-domain-names", i, > &pm_domains[i]); > + if (err) { > + kfree(pm_domains); > +

Re: [PATCH 1/9] iommu/rockchip: Add compatible for rockchip,rk3588-iommu

2024-06-12 Thread Sebastian Reichel
ust bind to the fallback compatible. Iff differences are found in the future, the kernel can start to make use of the more specific compatible. -- Sebastian > drivers/iommu/rockchip-iommu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iommu/rockchip-iommu.c b/driv

Re: [PATCH v12 12/13] media: imagination: Round to closest multiple for cropping region

2024-06-06 Thread Sebastian Fricke
el.org/doc/Documentation/userspace-api/media/v4l/vidioc-g-selection.rst [1] Signed-off-by: Devarsh Thakkar Acked-by: Sebastian Fricke Can, whoever picks up the math changes, pick up this change as well? I will send 1-6 via the media subsystem. Regards, Sebastian --- V12: No change V11: No change V10:

Re: [PATCH] drm/ttm/tests: Let ttm_bo_test consider different ww_mutex implementation.

2024-05-21 Thread Sebastian Andrzej Siewior
function for > > PREEMPT_RT and non-PREEMPT_RT builds. > > > > Fixes: 995279d280d1e ("drm/ttm/tests: Add tests for ttm_bo functions") > > Signed-off-by: Sebastian Andrzej Siewior > > --- > > > > For the record, testing led to > > | WARN

Re: [PATCH] drm/ttm/tests: Let ttm_bo_test consider different ww_mutex implementation.

2024-04-26 Thread Sebastian Andrzej Siewior
he test program since > their usefulness is limited outside of well known selftests. > > Provide ww_mutex_base_lock() which points to the correct function for > PREEMPT_RT and non-PREEMPT_RT builds. > > Fixes: 995279d280d1e ("drm/ttm/tests: Add tests for ttm_bo functions&q

[PATCH v2] drm: Document requirements for driver-specific KMS props in new drivers

2024-04-10 Thread Sebastian Wick
When extending support for a driver-specific KMS property to additional drivers, we should apply all the requirements for new properties and make sure the semantics are the same and documented. v2: devs of the driver which introduced property shall help and ack Signed-off-by: Sebastian Wick

Re: (subset) [PATCH 00/34] address all -Wunused-const warnings

2024-04-10 Thread Sebastian Reichel
nst' variables in header files > instead of using macros or enums. > > [...] Applied, thanks! [09/34] power: rt9455: hide unused rt9455_boost_voltage_values commit: 452d8950db3e839aba1bb13bc5378f4bac11fa04 Best regards, -- Sebastian Reichel

[PATCH] drm/ttm/tests: Let ttm_bo_test consider different ww_mutex implementation.

2024-04-04 Thread Sebastian Andrzej Siewior
nts to the correct function for PREEMPT_RT and non-PREEMPT_RT builds. Fixes: 995279d280d1e ("drm/ttm/tests: Add tests for ttm_bo functions") Signed-off-by: Sebastian Andrzej Siewior --- For the record, testing led to | WARNING: CPU: 5 PID: 2089 at include/drm/ttm/ttm_bo.h:247 ttm_bo_re

Re: [PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-11 Thread Sebastian Wick
On Thu, Mar 07, 2024 at 10:29:22AM +0200, Pekka Paalanen wrote: > On Wed, 6 Mar 2024 17:42:09 +0100 > Sebastian Wick wrote: > > > On Wed, Mar 06, 2024 at 10:27:21AM +0200, Pekka Paalanen wrote: > > > On Tue, 5 Mar 2024 14:51:49 +0100 > > > Sebastian Wick wr

[PATCH v2] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-11 Thread Sebastian Wick
When extending support for a driver-specific KMS property to additional drivers, we should apply all the requirements for new properties and make sure the semantics are the same and documented. v2: devs of the driver which introduced property shall help and ack Signed-off-by: Sebastian Wick

Re: [PATCH v2 1/2] dt-bindings: backlight: Add Texas Instruments LM3509

2024-03-09 Thread Sebastian Reichel
ither from the edge, like shown here: https://en.wikipedia.org/wiki/File:IPod_Touch_2G_Backlight.JPG or like this: https://de.wikipedia.org/wiki/Datei:DiodyTV.jpg Greetings, -- Sebastian

Re: [PATCH] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-06 Thread Sebastian Wick
On Wed, Mar 06, 2024 at 03:14:15PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Feb 29, 2024 at 09:28:31PM +0100, Sebastian Wick wrote: > > When extending support for a driver-specific KMS property to additional > > drivers, we should apply all the requirements for new pr

Re: [PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-06 Thread Sebastian Wick
On Wed, Mar 06, 2024 at 10:27:21AM +0200, Pekka Paalanen wrote: > On Tue, 5 Mar 2024 14:51:49 +0100 > Sebastian Wick wrote: > > > The initial idea of the Colorspace prop was that this maps 1:1 to > > InfoFrames/SDP but KMS does not give user space enough information nor

[PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-05 Thread Sebastian Wick
rt * Make it clear that drivers can choose between RGB and YCbCr on their own Signed-off-by: Sebastian Wick --- drivers/gpu/drm/drm_connector.c | 79 + include/drm/drm_connector.h | 8 2 files changed, 61 insertions(+), 26 deletions(-) diff --git a/d

[PATCH] drm/drm_connector: Document Colorspace property variants

2024-03-04 Thread Sebastian Wick
usable from user space and consistent with other KMS properties for those variants is left as an exercise for whoever wants to use them. Signed-off-by: Sebastian Wick --- drivers/gpu/drm/drm_connector.c | 67 - include/drm/drm_connector.h | 8 2 files changed

Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property

2024-03-01 Thread Sebastian Wick
On Fri, Mar 01, 2024 at 01:12:02PM +0100, Maxime Ripard wrote: > On Fri, Mar 01, 2024 at 12:29:41PM +0100, Sebastian Wick wrote: > > On Fri, Mar 01, 2024 at 11:30:56AM +0100, Maxime Ripard wrote: > > > On Thu, Feb 29, 2024 at 08:47:26PM +0100, Sebastian Wick wrote: > > &

Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property

2024-03-01 Thread Sebastian Wick
On Fri, Mar 01, 2024 at 11:30:56AM +0100, Maxime Ripard wrote: > On Thu, Feb 29, 2024 at 08:47:26PM +0100, Sebastian Wick wrote: > > > @@ -1708,6 +1731,39 @@ > > > EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property); > > > /** > >

Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property

2024-03-01 Thread Sebastian Wick
On Fri, Mar 01, 2024 at 09:29:17AM +0100, Hans Verkuil wrote: > On 29/02/2024 20:47, Sebastian Wick wrote: > > On Thu, Feb 22, 2024 at 07:14:07PM +0100, Maxime Ripard wrote: > >> The i915 driver has a property to force the RGB range of an HDMI output. > >> The vc4 drive

Colorspace "Default" and the CTA-861 spec

2024-02-29 Thread Sebastian Wick
property variant, but because the "defaultRGB" colorimetry is not supported at all right now, making "Default" undefined means we can't get predictable colors on almost all displays. Cheers, Sebastian

[PATCH] drm: Document requirements for driver-specific KMS props in new drivers

2024-02-29 Thread Sebastian Wick
When extending support for a driver-specific KMS property to additional drivers, we should apply all the requirements for new properties and make sure the semantics are the same and documented. Signed-off-by: Sebastian Wick --- Documentation/gpu/drm-kms.rst | 5 + 1 file changed, 5

Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property

2024-02-29 Thread Sebastian Wick
NULL; > + > + return broadcast_rgb_names[broadcast_rgb].name; > +} > +EXPORT_SYMBOL(drm_hdmi_connector_get_broadcast_rgb_name); > + > static const char * const output_format_str[] = { > [HDMI_COLORSPACE_RGB] = "RGB", > [HD

Re: [PATCH v2 0/7] Add YUV formats to VKMS

2024-02-29 Thread Sebastian Wick
On Wed, Feb 28, 2024 at 08:42:41PM -0300, Arthur Grillo wrote: > > > On 15/01/24 12:06, Sebastian Wick wrote: > > On Wed, Jan 10, 2024 at 02:44:00PM -0300, Arthur Grillo wrote: > >> This patchset aims to add support for additional buffer YUV formats. > >> More

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2024-02-27 Thread Sebastian Wick
he list is "in order of preference" > Add a a link to the mutter MR > > Cc: Simon Ser > Cc: Jonas Ådahl > Cc: Daniel Stone > Cc: Sameer Lattannavar > Cc: Sebastian Wick > Acked-by: Harry Wentland > Acked-by: Pekka Paalanen > Signed-of

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-22 Thread Sebastian Wick
On Thu, Feb 22, 2024 at 02:58:45PM +0200, Ville Syrjälä wrote: > On Thu, Feb 22, 2024 at 11:54:04AM +0100, Maxime Ripard wrote: > > On Mon, Feb 19, 2024 at 03:01:44PM +0100, Sebastian Wick wrote: > > > On Thu, Feb 15, 2024 at 12:00:01PM +0100, Maxime Ripard wrote: > > >

Re: Re: Re: Re: Re: Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-19 Thread Sebastian Wick
On Thu, Feb 15, 2024 at 12:00:01PM +0100, Maxime Ripard wrote: > On Mon, Feb 12, 2024 at 06:06:18PM +0100, Sebastian Wick wrote: > > On Mon, Feb 12, 2024 at 05:53:48PM +0100, Maxime Ripard wrote: > > > On Mon, Feb 12, 2024 at 05:49:33PM +0200, Ville Syrjälä wrote: > > >

  1   2   3   4   5   6   7   8   9   10   >