Add MAINTAINERS entries for the driver.
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 896a307fa065..a576324807f5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2228,6
different
from the Samsung-derived DWI block.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig| 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/apple_dwi_bl.c | 123 +
3 files changed, 136 insertions(+)
create mode 100644
Add backlight controllers attached via Apple DWI 2-wire interface.
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++
1 file changed, 57 insertions(+)
create mode 100644
Changes since v1:
- Fixed dt-bindings $id.
- Make power-domains an optional property in dt-bindings.
- Added missing error checking after devm_ioremap_resource() in
dwi_bl_probe().
v1: https://lore.kernel.org/asahi/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt
reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> + };
> +
[...]
With that in mind,
Reviewed-by: Nick Chan
different
from the Samsung-derived DWI block.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig| 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/apple_dwi_bl.c | 123 +
3 files changed, 136 insertions(+)
create mode 100644
Add backlight controllers attached via Apple DWI 2-wire interface.
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++
1 file changed, 57 insertions(+)
create mode 100644
.
- Make power-domains an optional property in dt-bindings.
- Added missing error checking after devm_ioremap_resource() in
dwi_bl_probe().
v1: https://lore.kernel.org/asahi/20241206172735.4310-1-towinche...@gmail.com/T
nick@nick-mbp:~/Documents/m1n1$ cat e.txt
Apple DWI backlight driver
Apple SoCs
Add MAINTAINERS entries for the driver.
Reviewed-by: Daniel Thompson (RISCstar)
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 910305c11e8a..67ad74f987c8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2196,6
Daniel Thompson 於 2025/1/8 下晝6:52 寫道:
> On Wed, Dec 11, 2024 at 07:34:38PM +0800, Nick Chan wrote:
>> Add driver for backlight controllers attached via Apple DWI 2-wire
>> interface, which is found on some Apple iPhones, iPads and iPod touches
>> with a LCD display.
>&
Add MAINTAINERS entries for the driver.
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 910305c11e8a..54a6c8ca7017 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2196,6 +2196,7 @@ F:
Documentation/devicetree
different
from the Samsung-derived DWI block.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig | 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/dwi_bl.c | 122 +++
3 files changed, 135 insertions(+)
create mode 100644 drivers/video
/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add Apple DWI backlight
backlight: dwi_bl: Add Apple DWI backlight driver
MAINTAINERS: Add entries for Apple DWI backlight controller
.../bindings/leds/backlight/apple,dwi
Add backlight controllers attached via Apple DWI 2-wire interface.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++
1 file changed, 57 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds
/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add Apple DWI backlight
backlight: dwi_bl: Add Apple DWI backlight driver
MAINTAINERS: Add entries for Apple DWI backlight controller
.../bindings/leds/backlight/apple,dwi
Add MAINTAINERS entries for the driver.
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 17daa9ee9384..3a7dec3f9a5a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2196,6 +2196,7 @@ F:
Documentation/devicetree
Add backlight controllers attached via Apple DWI 2-wire interface.
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++
1 file changed, 57 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml
diff
different
from the Samsung-derived DWI block.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig | 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/dwi_bl.c | 122 +++
3 files changed, 135 insertions(+)
create mode 100644 drivers/video
Krzysztof Kozlowski 於 2024/12/10 下午4:32 寫道:
> Nothing improved here.
This is sent before you left any review, v4 will have improvements
Nick Chan
On 9/12/2024 17:16, Krzysztof Kozlowski wrote:
> On Sat, Dec 07, 2024 at 09:03:14PM +0800, Nick Chan wrote:
>> Add the device tree bindings for backlight controllers attached via Apple
>> DWI 2-wire interface.
[...]
Ack all the changes, will be in v4.
Nick Chan
backlight/dwi_bl.c
>> @@ -0,0 +1,124 @@
[...]
>> +
>> +dwi_bl = devm_kzalloc(&dev->dev, sizeof(struct apple_dwi_bl),
>> GFP_KERNEL);
>
> sizeof(*)
Ack this change as well for v4.
>
>> +if (!dwi_bl)
>> +return -ENOMEM;
[...]
Nick Chan
Krzysztof Kozlowski 於 2024/12/9 下午5:22 寫道:
> On Sat, Dec 07, 2024 at 09:03:15PM +0800, Nick Chan wrote:
>> Add driver for backlight controllers attached via Apple DWI 2-wire
>> interface, which is found on some Apple iPhones, iPads and iPod touches
>> with a LCD display
://lore.kernel.org/asahi/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add bindings for Apple DWI
backlight
backlight: dwi_bl: Add Apple DWI backlight driver
MAINTAINERS: Add entries for Apple DWI backlight controller
Add MAINTAINERS entries for the driver.
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 17daa9ee9384..3a7dec3f9a5a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2196,6 +2196,7 @@ F:
Documentation/devicetree
Add driver for backlight controllers attached via Apple DWI 2-wire
interface, which is found on some Apple iPhones, iPads and iPod touches
with a LCD display.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig | 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video
Add the device tree bindings for backlight controllers attached via Apple
DWI 2-wire interface.
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 54 +++
1 file changed, 54 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds
Add driver for backlight controllers attached via Apple DWI 2-wire
interface, which is found on some Apple iPhones, iPads and iPod touches
with a LCD display.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig | 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video
Add MAINTAINERS entries for the driver.
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1e930c7a58b1..36de76bc6fd4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2204,6 +2204,7 @@ F:
Documentation/devicetree
Add the device tree bindings for backlight controllers attached via Apple
DWI 2-wire interface.
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 54 +++
1 file changed, 54 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds
optional property in dt-bindings.
- Added missing error checking after devm_ioremap_resource() in
dwi_bl_probe().
v1: https://lore.kernel.org/asahi/20241206172735.4310-1-towinche...@gmail.com/T
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add bindings for Apple DWI
Add driver for backlight controllers attached via Apple DWI 2-wire
interface, which is found on some Apple iPhones, iPads and iPod touches
with a LCD display.
Signed-off-by: Nick Chan
---
drivers/video/backlight/Kconfig | 12 +++
drivers/video/backlight/Makefile | 1 +
drivers/video
on all controllers at the same time. This series adds a backlight
driver for backlight controllers connected this way.
Nick Chan
---
Nick Chan (3):
dt-bindings: leds: backlight: apple,dwi-bl: Add bindings for Apple DWI
backlight
backlight: dwi_bl: Add Apple DWI backlight driver
Add the device tree bindings for backlight controllers attached via Apple
DWI 2-wire interface.
Signed-off-by: Nick Chan
---
.../bindings/leds/backlight/apple,dwi-bl.yaml | 55 +++
1 file changed, 55 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds
Add MAINTAINERS entries for the driver.
Signed-off-by: Nick Chan
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1e930c7a58b1..36de76bc6fd4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2204,6 +2204,7 @@ F:
Documentation/devicetree
+
Drop. Not needed as there is only one reg now.
[...]
Nick Chan
t; + interrupts = ,
> + ;
> + interrupt-names = "be", "fe";
> + status = "disabled";
Forgot to add, status should go after other properties here as well.
> + iommus = <&displaydfr_dart 0>;
> + };
[...]
Nick Chan
ings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> Best regards,
> Krzysztof
Nick Chan
;0x2 0x2860 0x0 0x10>;
> + power-domains = <&ps_dispdfr_fe>, <&ps_dispdfr_be>,
> <&ps_mipi_dsi>;
> + interrupt-parent = <&aic>;
> + interrupts = ,
> + ;
> + interrupt-names = "be", "fe";
> + status = "disabled";
> + iommus = <&displaydfr_dart 0>;
> + };
> +
> + displaydfr_dart: iommu@228304000 {
> + compatible = "apple,t8110-dart";
> + reg = <0x2 0x28304000 0x0 0x4000>;
> + interrupt-parent = <&aic>;
> + interrupts = ;
> + #iommu-cells = <1>;
> + power-domains = <&ps_dispdfr_fe>;
> + status = "disabled";
> + };
> +
> sio_dart: iommu@235004000 {
> compatible = "apple,t8110-dart";
> reg = <0x2 0x35004000 0x0 0x4000>;
>
Nick Chan
rivers/clk/clk-apple-nco.c
> F: drivers/cpufreq/apple-soc-cpufreq.c
> F: drivers/dma/apple-admac.c
> +F: drivers/gpu/drm/adp/
> F: drivers/pmdomain/apple/
> F: drivers/i2c/busses/i2c-pasemi-core.c
> F: drivers/i2c/busses/i2c-pasemi-platform.c
>
Nick Chan
On 2024-03-22 06:43, Javier Martinez Canillas wrote:
> Thomas Zimmermann writes:
>
>> Framebuffer I/O on the Sparc Sbus requires read/write helpers for
>> I/O memory. Select FB_IOMEM_FOPS accordingly.
>>
>> Reported-by: Nick Bowler
Applied on top of 6.8 and th
On Thu, Aug 31, 2023 at 3:16 PM Helge Deller wrote:
>
> * Nick Desaulniers :
> > On Thu, Aug 31, 2023 at 2:23 PM Helge Deller wrote:
> > >
> > > * Helge Deller :
> > > > On 8/29/23 18:45, Nick Desaulniers wrote:
> > > > > A recent ch
On Thu, Aug 31, 2023 at 2:23 PM Helge Deller wrote:
>
> * Helge Deller :
> > On 8/29/23 18:45, Nick Desaulniers wrote:
> > > A recent change in clang made it better about spotting snprintf that
> > > will result in truncation. Nathan reported the following instan
0e90454 ("neofb: avoid overwriting fb_info fields")
(Also, snprintf probably isn't necessary for string literals that
don't contain format strings)
--
Thanks,
~Nick Desaulniers
On Wed, Aug 2, 2023 at 1:44 AM Boris Brezillon
wrote:
>
> On Tue, 1 Aug 2023 13:35:13 -0700
> Nick Desaulniers wrote:
>
> > On Mon, Jul 31, 2023 at 5:36 AM Christian König
> > wrote:
> > >
> > > GCC forbids to jump to labels in loop conditions and
gt; Reported-by: Nathan Chancellor
> Reported-by: Naresh Kamboju
> CC: Boris Brezillon
> Signed-off-by: Christian König
Works for me; thanks for the patch!
Reviewed-by: Nick Desaulniers
I suspect it's possible to change the indirect goto into a direct goto
with
context for GEM buffers v7")
> Link: https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html
> Link: https://github.com/ClangBuiltLinux/linux/issues/1890
> Link:
> https://github.com/llvm/llvm-project/commit/20219106060208f0c2f5d096eb3aed7b712f5067
> Reported-by: Nathan Chancellor
> R
t; drivers/gpu/drm/v3d/v3d_drv.h:343:24: note: remove constant to silence this
> warning
> 1 warning generated.
>
> Turn this into an explicit comparison against zero to make the
> expression a boolean to make it clear this should be a logical check,
> not a bitwise one.
>
>
On Thu, May 25, 2023 at 1:30 PM Matthieu Baerts
wrote:
>
> Hi Nick,
>
> On 24/05/2023 20:56, Nick Desaulniers wrote:
> > On Wed, May 24, 2023 at 11:41 AM Nathan Chancellor
> > wrote:
> >>
> >> On Wed, May 24, 2023 at 11:32:32AM -0700, Nick Desaulni
On Wed, May 24, 2023 at 11:41 AM Nathan Chancellor wrote:
>
> On Wed, May 24, 2023 at 11:32:32AM -0700, Nick Desaulniers wrote:
> > On Wed, May 24, 2023 at 8:38 AM Nathan Chancellor wrote:
> > >
> > > Clang warns:
> > >
> > > drivers/gp
by: Naresh Kamboju
> Closes:
> https://lore.kernel.org/CA+G9fYv68V3ewK0Qj-syQj7qX-hQr0H1MFL=qfnudoe_j2z...@mail.gmail.com/
> Signed-off-by: Nathan Chancellor
Thanks for the patch! I've never seen the closes tag before, that's
new to me. Can you tell me more about it?
A few mo
On Tue, May 23, 2023 at 2:29 PM Nick Desaulniers
wrote:
>
> On Tue, May 23, 2023 at 2:20 PM Artur Weber wrote:
> >
> > Fixes compilation errors on older GCC versions (before 8.x) and Clang
> > after changes introduced in commit 6810bb390282 ("drm/panel: Add
> &g
t; + mode = drm_mode_duplicate(connector->dev, ctx->desc->drm_mode);
> if (!mode)
> return -ENOMEM;
>
>
> base-commit: 37cee4876a45a5c3da79a83d34ed4f3c68548aef
> --
> 2.40.1
>
--
Thanks,
~Nick Desaulniers
PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv,
> > txposdiv, digital_div);
> > - if (ret)
> > - return -EINVAL;
> > -
> > - return 0;
> > }
> >
> > static int mtk_hdmi_pll_drv_setting(struct clk_hw *hw)
> >
> > --
> > 2.40.0
> >
>
--
Thanks,
~Nick Desaulniers
truct drm_gem_object
> > *obj, struct vm_area_struc
> > struct qaic_bo *bo = to_qaic_bo(obj);
> > unsigned long offset = 0;
> > struct scatterlist *sg;
> > - int ret;
> > + int ret = 0;
> >
> > if (obj->import_attach)
> > return -EINVAL;
>
--
Thanks,
~Nick Desaulniers
emove it.
Thanks for the patch!
Fixes: 64122c1f6ad ("drm: add new QXL driver. (v1.4)")
Reviewed-by: Nick Desaulniers
>
> Signed-off-by: Tom Rix
> ---
> drivers/gpu/drm/qxl/qxl_cmd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/qxl/
On Fri, Apr 7, 2023 at 10:52 AM Nick Desaulniers
wrote:
>
> Jimmy, can you review?
>
> The change LGTM; but I'm not sure if there was something else intended here.
Nevermind, Jimmy's email address bounced.
Reviewed-by: Nick Desaulniers
>
> On Sat, Mar 25, 20
^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix
Ben, any idea if this was supposed to be used somewhere? If not:
Fixes: 4b569ded09fd ("drm/nouveau/acr/ga102: initial support")
Reviewed-by: Nick Desaulniers
> ---
> drivers/gpu/drm/nouvea
t; This variable is not used so remove it.
>
> Signed-off-by: Tom Rix
Thanks for the patch!
Fixes: 74d9a6335dce ("drm/qxl: Simplify cleaning qxl processing command")
Reviewed-by: Nick Desaulniers
That commit should also have removed the label out_free_bos IMO since
having two labels f
0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix
Thanks for the patch!
Fixes: commit 75145aab7a0d ("drm/amdgpu/swsmu: clean up a bunch of
stale interfaces")
Reviewed-by: Nick Desaulniers
> ---
> drivers/gpu/drm/amd/pm/swsmu/am
ther call sites have
comments like:
114 /*XXX: warn? */
134 /*XXX: warn? */
or other places where the return code isn't checked makes me think
that a better approach would be to
1. plumb error codes back up through nouveau_pfns_map() (and other
call sites of nvif_object_ioctl)
2. consider making nvif_object_ioctl __must_check
>
> mutex_unlock(&svmm->mutex);
> }
> --
> 2.27.0
>
--
Thanks,
~Nick Desaulniers
se
> + if (assignment.stream != state->streams[i])
> valid_stream_ptrs = false;
> }
> }
> --
> 2.27.0
>
--
Thanks,
~Nick Desaulniers
rcpy(pstrs, mksstat_kern_name_desc[stat_idx][0]);
> - strcpy(pstrd, mksstat_kern_name_desc[stat_idx][1]);
> -
> - pinfo[stat_idx].name.s = pstrs;
> - pinfo[stat_idx].description.s = pstrd;
> - pinfo[stat_idx].flags = MKS_GUEST_STAT_FLAG_NONE;
This was the
ay(struct drm_device *dev)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix
Thanks for the patch!
Reviewed-by: Nick Desaulniers
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/driv
ic functions are not used, so remove them.
>
> Signed-off-by: Tom Rix
Thanks for the patch!
Reviewed-by: Nick Desaulniers
> ---
> drivers/gpu/drm/kmb/kmb_dsi.c | 28
> 1 file changed, 28 deletions(-)
>
> diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c
n you actually build things:
>
> make ARCH=i386
>
> because the ARCH choice ends up being in the .config file, but the
> makefiles themselves always take it from the environment.
>
> There are good historical reasons for our behavior (and probably a
> number of extant practical reasons too), but it's a bit annoying, and
> it would be lovely if we could start moving away from this model.
>
> Linus
>
--
Thanks,
~Nick Desaulniers
(Sorry about this, MTA delivered a bunch of stuff very late.)
On 3 Mar 2023, Luis Chamberlain verbalised:
> Stupid question, if you're removing MODULE_LICENSE() than why keep the
> other stupid MODULE_*() crap too? If its of no use, be gone!
I wish, but when I tried it it broke stuff. At least s
le when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock
Suggested-by: Luis Chamberlain
Cc: Luis Chamberlain
Cc:
x-ker...@vger.kernel.org
Cc: linux-me...@vger.kernel.org
Cc: linux...@kvack.org
Cc: linux-modu...@vger.kernel.org
Cc: x...@kernel.org
Nick Alcock (17):
irqchip: remove MODULE_LICENSE in non-modules
bus: remove MODULE_LICENSE in non-modules
braille_console: remove MODULE_LICENSE in non-modules
arm-cci: r
le when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock
Suggested-by: Luis Chamberlain
Cc: Luis Chamberlain
Cc:
le when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock
Suggested-by: Luis Chamberlain
Cc: Luis Chamberlain
Cc:
le when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock
Suggested-by: Luis Chamberlain
Cc: Luis Chamberlain
Cc:
le when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock
Suggested-by: Luis Chamberlain
Cc: Luis Chamberlain
Cc:
le when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock
Suggested-by: Luis Chamberlain
Cc: Luis Chamberlain
Cc:
le when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock
Suggested-by: Luis Chamberlain
Cc: Luis Chamberlain
Cc:
e syncpoint interrupt handling")
> Signed-off-by: Arnd Bergmann
Thanks Arnd, I saw some reports from kernelci about this, too.
https://lore.kernel.org/linux-next/?q=warning%3A+variable+%27syncpt_irq%27+is+uninitialized+when+used+here
Reported-by: "kernelci.org bot"
Reviewed-by:
On Thu, Nov 10, 2022 at 02:47:52PM +0100, José Expósito wrote:
> Commit 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link on hotplug") introduced
> the vc4_hdmi_reset_link() function. This function dereferences the
> "connector" pointer before checking whether it is NULL or not.
>
> Rework variable assignm
do {\
> + typeof(t1) __t1h = type_max(t1);\
> + typeof(t1) __t1l = type_min(t1);\
> + typeof(t2) __t2h = type_max(t2);\
> + typeof(t2) __t2l = type_min(t2);\
Can we use __auto_type here rather than typeof(macro expansion)?
--
Thanks,
~Nick Desaulniers
From: Nick Hawkins
GXP is the name of the HPE SoC.
This SoC is used to implement BMC features of HPE servers
(all ProLiant, Synergy, and many Apollo, and Superdome machines)
It does support many features including:
ARMv7 architecture, and it is based on a Cortex A9 core
Use an
Macs
because the BIOS image provides by OF is only the used parts of the ROM,
not a power-of-two blocks read from PCI directly so PCs always have
empty bytes at the end that are never accesseed.
Signed-off-by: Nick Lopez
---
drivers/gpu/drm/nouveau/nvkm/subdev/bios/base.c | 2 +-
1 file changed, 1 inse
On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher wrote:
>
> Applied. Thanks!
>
> Alex
>
> On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor wrote:
> >
> > Clang warns:
Any chance AMDGPU folks can look into adding clang to the CI roster?
--
Thanks,
~Nick Desaulniers
.
> Enable it now that i915 is clean so that it stays that way.
>
> Signed-off-by: Nathan Chancellor
Thanks for the series!
Reviewed-by: Nick Desaulniers
> ---
> drivers/gpu/drm/i915/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Ma
2]: https://lore.kernel.org/r/20210824022640.2170859-1-nat...@kernel.org/
>
> Signed-off-by: Nathan Chancellor
Thanks for the patch! Do you need to re-ping, rebase, or resend that
other series?
Reviewed-by: Nick Desaulniers
> ---
>
> NOTE: This is based on my series to enable
;
> These are fine:
>
> struct foo ok1 = { };
> struct foo ok2 = { .flag = 7 };
> struct foo ok3 = { .ptr = NULL };
>
> This is not:
>
> struct foo bad = { .flag = 7, .ptr = NULL };
>
> (But, of course, it depends on padding size, compiler version, and
> architecture. i.e. things remain unreliable.)
>
> --
--
Thanks,
~Nick Desaulniers
n", name);
> diff --git a/lib/test_fortify/read_overflow2_field-memcpy.c
> b/lib/test_fortify/read_overflow2_field-memcpy.c
> new file mode 100644
> index ..de9569266223
> --- /dev/null
> +++ b/lib/test_fortify/read_overflow2_field-memcpy.c
> @@ -0,0 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +#define TEST \
> + memcpy(large, instance.buf, sizeof(instance.buf) + 1)
> +
> +#include "test_fortify.h"
> diff --git a/lib/test_fortify/write_overflow_field-memcpy.c
> b/lib/test_fortify/write_overflow_field-memcpy.c
> new file mode 100644
> index ..28cc81058dd3
> --- /dev/null
> +++ b/lib/test_fortify/write_overflow_field-memcpy.c
> @@ -0,0 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +#define TEST \
> + memcpy(instance.buf, large, sizeof(instance.buf) + 1)
> +
> +#include "test_fortify.h"
> --
I haven't read the whole series yet, but I assume test_fortify.h was
provided earlier in the series?
--
Thanks,
~Nick Desaulniers
Add devicetree schema for Arm Mali Valhall GPU
Define a compatible string for the Mali Valhall GPU
for Mediatek's SoC platform.
Signed-off-by: Nick Fan
---
.../bindings/gpu/arm,mali-valhall.yaml| 217 ++
1 file changed, 217 insertions(+)
create mode 1
Thanks for your review.
These are fixed in v5 as following link.
https://lore.kernel.org/patchwork/patch/1372271/
Nick Fan
On Thu, 2021-01-14 at 14:14 -0600, Rob Herring wrote:
> On Tue, Jan 12, 2021 at 02:49:32PM +0800, Nick Fan wrote:
> > Add devicetree schema for Arm Mali Va
Add a basic GPU node for mt8192.
Signed-off-by: Nick Fan
---
This patch depends on Mediatek power and regulator support.
Listed as following.
[1]https://lore.kernel.org/patchwork/patch/1336293/
[2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013
[3]https
On Fri, 2021-01-08 at 15:58 +, Steven Price wrote:
> On 05/01/2021 05:36, Nick Fan wrote:
> > Add a basic GPU node for mt8192.
> >
> > Signed-off-by: Nick Fan
> > ---
> > This patch depends on Mediatek power and regulator support.
> >
>
Add devicetree schema for Arm Mali Valhall GPU
Define a compatible string for the Mali Valhall GPU
for Mediatek's SoC platform.
Signed-off-by: Nick Fan
---
.../bindings/gpu/arm,mali-valhall.yaml| 252 ++
1 file changed, 252 insertions(+)
create mode 1
Add a basic GPU node for mt8192.
Signed-off-by: Nick Fan
---
This patch depends on Mediatek power and regulator support.
Listed as following.
[1]https://lore.kernel.org/patchwork/patch/1336293/
[2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013
[3]https
Add devicetree schema for Arm Mali Valhall GPU
Define a compatible string for the Mali Valhall GPU
for Mediatek's SoC platform.
Signed-off-by: Nick Fan
---
.../bindings/gpu/arm,mali-valhall.yaml| 252 ++
1 file changed, 252 insertions(+)
create mode 1
Add a basic GPU node for mt8192.
Signed-off-by: Nick Fan
---
This patch depends on Mediatek power and regulator support.
Listed as following.
[1]https://lore.kernel.org/patchwork/patch/1336293/
[2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013
[3]https
Add a basic GPU node for mt8192.
Signed-off-by: Nick Fan
---
This patch depends on Mediatek power and regulator support.
Listed as following.
[1]https://lore.kernel.org/patchwork/patch/1336293/
[2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013
[3]https
Add devicetree schema for Arm Mali Valhall GPU
Define a compatible string for the Mali Valhall GPU
for Mediatek's SoC platform.
Signed-off-by: Nick Fan
---
.../bindings/gpu/arm,mali-valhall.yaml| 252 ++
1 file changed, 252 insertions(+)
create mode 1
Convert the Arm Valhall GPU binding to DT schema format.
Define a compatible string for the Mali Valhall GPU
for Mediatek's SoC platform.
Signed-off-by: Nick Fan
---
.../bindings/gpu/arm,mali-valhall.yaml| 252 ++
1 file changed, 252 insertions(+)
create mode 1
Add a basic GPU node for mt8192.
Signed-off-by: Nick Fan
---
This patch depends on Mediatek power and regulator support.
Listed as following.
[1]https://lore.kernel.org/patchwork/patch/1336293/
[2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013
[3]https
Add a basic GPU node for mt8192.
Signed-off-by: Nick Fan
---
This patch depends on Mediatek power and regulator support.
Listed as following.
[1]https://lore.kernel.org/patchwork/patch/1336293/
[2]https://patchwork.kernel.org/project/linux-mediatek/list/?series=374013
[3]https
Convert the Arm Valhall GPU binding to DT schema format.
Define a compatible string for the Mali Valhall GPU
for Mediatek's SoC platform.
Signed-off-by: Nick Fan
---
.../bindings/gpu/arm,mali-valhall.yaml| 252 ++
1 file changed, 252 insertions(+)
create mode 1
On Tue, Dec 8, 2020 at 2:18 PM Arnd Bergmann wrote:
>
> On Tue, Dec 8, 2020 at 7:21 PM 'Nick Desaulniers' via Clang Built
> Linux wrote:
> >
> > On Tue, Dec 8, 2020 at 6:26 AM Arnd Bergmann wrote:
> > >
> > > On Mon, Dec 7, 2020 at 11:28 PM
On Tue, Dec 8, 2020 at 6:26 AM Arnd Bergmann wrote:
>
> On Mon, Dec 7, 2020 at 11:28 PM 'Nick Desaulniers' via Clang Built
> Linux wrote:
> >
> > On Mon, Dec 7, 2020 at 2:17 PM Arnd Bergmann wrote:
> > >
> > > On Mon, Dec 7, 2020 at 11:08 PM
1 - 100 of 253 matches
Mail list logo
