[PATCH] drm: panel: nt36523: use devm_mipi_dsi_* function to register and attach dsi

2024-09-04 Thread Jianhua Lu
Switch to devm_mipi_dsi_* function, we don't need to detach and unregister dsi manually any more. Signed-off-by: Jianhua Lu --- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-no

Re: [PATCH -next] backlight: ktz8866: fix module autoloading

2024-08-20 Thread Jianhua Lu
; @@ -190,6 +190,7 @@ static const struct of_device_id ktz8866_match_table[] = { > }, > {}, > }; > +MODULE_DEVICE_TABLE(of, ktz8866_match_table); > > static struct i2c_driver ktz8866_driver = { > .driver = { > -- > 2.34.1 > Reviewed-by: Jianhua Lu

[PATCH] backlight: ktz8866: Correct the check for of_property_read_u32

2024-01-29 Thread Jianhua Lu
of_property_read_u32 returns 0 when success, so reverse the return value to get the true value. Fixes: f8449c8f7355 ("backlight: ktz8866: Add support for Kinetic KTZ8866 backlight") Signed-off-by: Jianhua Lu --- drivers/video/backlight/ktz8866.c | 6 +++--- 1 file changed, 3 insert

[PATCH] drm/panel: nt36523: Set 120Hz fps for xiaomi,elish panels

2024-01-12 Thread Jianhua Lu
After commit e6c0de5f4450 ("drm/msm/dpu: try multirect based on mdp clock limits") merged, 120Hz is working on xiaomi,elish panels, so feature it. Signed-off-by: Jianhua Lu --- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

Re: [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: define ports

2023-05-02 Thread Jianhua Lu
On Tue, May 02, 2023 at 02:00:36PM +0200, Krzysztof Kozlowski wrote: > description: regulator that supplies the I/O voltage [..] > > + ports: > +$ref: /schemas/graph.yaml#/properties/ports > + > +required: > + - port@0 > + - port@1 Konrad has added a single DSI panel to th

[PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example

2023-04-28 Thread Jianhua Lu
The kinetic,ktz8866 is a I2C driver, so add the missing reg property. And update example to make it clear. Signed-off-by: Jianhua Lu --- .../leds/backlight/kinetic,ktz8866.yaml | 29 --- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/Documentation

[PATCH v2] dt-bindings: display/msm: dsi-controller-main: Document qcom, master-dsi and qcom, sync-dual-dsi

2023-04-27 Thread Jianhua Lu
This fixes warning: sm8250-xiaomi-elish-csot.dtb: dsi@ae94000: Unevaluated properties are not allowed ('qcom,master-dsi', 'qcom,sync-dual-dsi' were unexpected) Reviewed-by: Dmitry Baryshkov Acked-by: Rob Herring Signed-off-by: Jianhua Lu --- Changes in v2: - pick

Re: [PATCH 5/5] drm/panel: nt36523: Add Lenovo J606F panel

2023-04-12 Thread Jianhua Lu
o = { > + .type = "J606F BOE", > + .channel = 0, > + .node = NULL, > + }, The dsi_info just be used to register slave dsi, for single dsi case, can drop it. Otherwise looks great, thanks! Reviewed-by: Jianhua Lu > +

Re: [PATCH 4/5] drm/panel: nt36523: Get orientation from OF

2023-04-12 Thread Jianhua Lu
On Wed, Apr 12, 2023 at 09:46:01PM +0200, Konrad Dybcio wrote: > Some bright vendors mount their display panels upside down. Add the > required pieces to allow for accounting for that. > > Signed-off-by: Konrad Dybcio Reviewed-by: Jianhua Lu > --- > drivers/gpu/drm/panel/pan

Re: [PATCH 3/5] drm/panel: nt36523: Add DCS backlight support

2023-04-12 Thread Jianhua Lu
el/panel-novatek-nt36523.c > index d30dbbfb67b1..3c81ec014eef 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c > @@ -5,6 +5,7 @@ > * Copyright (c) 2022, 2023 Jianhua Lu > */ > > + [..] > +static struct

[PATCH] dt-bindings: display/msm: dsi-controller-main: Document qcom, master-dsi and qcom, sync-dual-dsi

2023-04-11 Thread Jianhua Lu
This fixes warning: sm8250-xiaomi-elish-csot.dtb: dsi@ae94000: Unevaluated properties are not allowed ('qcom,master-dsi', 'qcom,sync-dual-dsi' were unexpected) Signed-off-by: Jianhua Lu --- .../bindings/display/msm/dsi-controller-main.yaml| 12 1 file ch

Re: [PATCH] drm/panel: Fix panel mode type setting logic

2023-03-14 Thread Jianhua Lu
On Tue, Mar 14, 2023 at 10:12:02AM -0700, Doug Anderson wrote: > Hi, > > On Tue, Mar 14, 2023 at 4:45 AM Jianhua Lu wrote: > > > > Some panels set mode type to DRM_MODE_TYPE_PREFERRED by the number > > of modes. It isn't reasonable, so set the first mode type to &

[PATCH] drm/panel: Fix panel mode type setting logic

2023-03-14 Thread Jianhua Lu
Some panels set mode type to DRM_MODE_TYPE_PREFERRED by the number of modes. It isn't reasonable, so set the first mode type to DRM_MODE_TYPE_PREFERRED. This should be more reasonable. Signed-off-by: Jianhua Lu --- drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 2 +- drivers/gpu/drm/

Re: [PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-14 Thread Jianhua Lu
On Mon, Mar 13, 2023 at 07:53:30PM +0100, Sam Ravnborg wrote: > On Mon, Mar 13, 2023 at 09:06:50AM +0100, Neil Armstrong wrote: > > On 11/03/2023 13:46, Jianhua Lu wrote: > > > On Sat, Mar 11, 2023 at 01:38:52PM +0100, Konrad Dybcio wrote: > > > > > > > >

[PATCH v6 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-13 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v6: - Make the first mode to be DRM_MODE_TYPE_PREFERRED. Changes in v5: - use lowercase hex for init sequence - fix code style - enable DRM_MODE_TYPE_PREFERRED if where is only

[PATCH v6 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-03-13 Thread Jianhua Lu
Novatek NT36523 is a display driver IC used to drive DSI panels. Signed-off-by: Jianhua Lu Reviewed-by: Krzysztof Kozlowski --- No changes in v6 No changes in v5 No changes in v4 Changes in v3: - pick up Krzysztof's R-b - remove vddpos and vddneg supply Changes in v2: -

Re: [PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-13 Thread Jianhua Lu
On Mon, Mar 13, 2023 at 09:06:50AM +0100, Neil Armstrong wrote: > On 11/03/2023 13:46, Jianhua Lu wrote: > > On Sat, Mar 11, 2023 at 01:38:52PM +0100, Konrad Dybcio wrote: > >> > >> > >> On 11.03.2023 13:32, Jianhua Lu wrote: > >>> Add a driver for

Re: [PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-11 Thread Jianhua Lu
On Sat, Mar 11, 2023 at 01:38:52PM +0100, Konrad Dybcio wrote: > > > On 11.03.2023 13:32, Jianhua Lu wrote: > > Add a driver for panels using the Novatek NT36523 display driver IC. > > > > Signed-off-by: Jianhua Lu > > --- > [...] > > > + >

[PATCH v5 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-11 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v5: - use lowercase hex for init sequence - fix code style - enable DRM_MODE_TYPE_PREFERRED if where is only one mode. Changes in v4: - add multiple modes support - use

[PATCH v5 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-03-11 Thread Jianhua Lu
Novatek NT36523 is a display driver IC used to drive DSI panels. Signed-off-by: Jianhua Lu Reviewed-by: Krzysztof Kozlowski --- No changes in v5 No changes in v4 Changes in v3: - pick up Krzysztof's R-b - remove vddpos and vddneg supply Changes in v2: - Drop unnecessary descri

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
;is_dual_dsi; i++) { > > + pinfo->dsi[i]->lanes = pinfo->desc->lanes; > > + pinfo->dsi[i]->format = pinfo->desc->format; > > + pinfo->dsi[i]->mode_flags = pinfo->desc->mode_flags; > > + > > + ret = mipi_dsi_attach(pinfo->dsi[i]); > > + if (ret < 0) > > + return dev_err_probe(dev, ret, "cannot attach to DSI%d > > host.\n", i); > > + } > > + > > + return 0; > > +} > > + > > +static const struct of_device_id nt36523_of_match[] = { > > + { > > + .compatible = "xiaomi,elish-boe-nt36523", > > + .data = &elish_boe_desc, > > + }, > > + { > > + .compatible = "xiaomi,elish-csot-nt36523", > > + .data = &elish_csot_desc, > > + }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, nt36523_of_match); > > + > > +static struct mipi_dsi_driver nt36523_driver = { > > + .probe = nt36523_probe, > > + .remove = nt36523_remove, > > + .driver = { > > + .name = "panel-novatek-nt36523", > > + .of_match_table = nt36523_of_match, > > + }, > > +}; > > +module_mipi_dsi_driver(nt36523_driver); > > + > > +MODULE_AUTHOR("Jianhua Lu "); > > +MODULE_DESCRIPTION("DRM driver for Novatek NT36523 based MIPI DSI panels"); > > +MODULE_LICENSE("GPL");

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
On Fri, Mar 10, 2023 at 09:21:44PM +0800, Jianhua Lu wrote: > Add a driver for panels using the Novatek NT36523 display driver IC. ... > + > +static int nt36523_get_modes(struct drm_panel *panel, > +struct drm_connector *connector) > +{ > + struct

[PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v4: - add multiple modes support - use dev_err_probe helper - fix dsi_info type string - reimplement mipi_dsi_dual_dcs_write_seq() macro Changes in v3: - Refactor source code

[PATCH v4 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-03-10 Thread Jianhua Lu
Novatek NT36523 is a display driver IC used to drive DSI panels. Signed-off-by: Jianhua Lu Reviewed-by: Krzysztof Kozlowski --- No changes in v4 Changes in v3: - pick up Krzysztof's R-b - remove vddpos and vddneg supply Changes in v2: - Drop unnecessary description - dsi0 -

Re: [PATCH] drm/mipi-dsi: Add a mipi_dual_dsi_dcs_write_seq() macro

2023-03-10 Thread Jianhua Lu
On Fri, Mar 10, 2023 at 01:54:18PM +0200, Jani Nikula wrote: > On Fri, 10 Mar 2023, Jianhua Lu wrote: > > The panels with two dsi connected (sync dual dsi mode) need to transmit > > dcs command to the two dsi host simultaneously, let's add > > mipi_dual_dsi_dcs_write_se

[PATCH] drm/mipi-dsi: Add a mipi_dual_dsi_dcs_write_seq() macro

2023-03-10 Thread Jianhua Lu
The panels with two dsi connected (sync dual dsi mode) need to transmit dcs command to the two dsi host simultaneously, let's add mipi_dual_dsi_dcs_write_seq() macro for this kind of panels. Signed-off-by: Jianhua Lu --- include/drm/drm_mipi_dsi.h | 15 +++ 1 file change

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
On Thu, Mar 09, 2023 at 11:37:17PM +0100, Konrad Dybcio wrote: > > [...] > = of_graph_get_remote_node(dsi->dev.of_node, 1, -1); > > + if (!dsi1) { > > + dev_err(dev, "cannot get secondary DSI > > node.\n"); > > + return -EN

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Jianhua Lu
On Wed, Mar 08, 2023 at 01:33:39PM +0100, Konrad Dybcio wrote: > > phy-type: > description: D-PHY (default) or C-PHY mode > enum: [ 10, 11 ] > default: 10 > > try setting that to 11 under your DSI PHYs (or one? not sure). I already used phy-type = before, this equate to qcom,panel-c

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Jianhua Lu
On Wed, Mar 08, 2023 at 12:13:53PM +0100, Konrad Dybcio wrote: > > > On 8.03.2023 05:37, Jianhua Lu wrote: > > Add a driver for panels using the Novatek NT36523 display driver IC. > > > > Signed-off-by: Jianhua Lu > > --- > > Changes in v3: > >

[PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-07 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v3: - Refactor source code Changes in v2: - Refactor and clean up source code MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig

[PATCH v3 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-03-07 Thread Jianhua Lu
Novatek NT36523 is a display driver IC used to drive DSI panels. Signed-off-by: Jianhua Lu Reviewed-by: Krzysztof Kozlowski --- Changes in v3: - pick up Krzysztof's R-b Changes in v2: - Drop unnecessary description - dsi0 -> dsi - Correct indentation .../display/panel/novatek

Re: [PATCH v2 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-07 Thread Jianhua Lu
add Konrads Lenovo-panel with > a patch on top. > > On Mon, Feb 20, 2023 at 1:13 PM Jianhua Lu wrote: > > > Add a driver for panels using the Novatek NT36523 display driver IC. > > > > Signed-off-by: Jianhua Lu > > (...) > > I like how you abs

Re: [PATCH v2 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-07 Thread Jianhua Lu
add Konrads Lenovo-panel with > a patch on top. > > On Mon, Feb 20, 2023 at 1:13 PM Jianhua Lu wrote: > > > Add a driver for panels using the Novatek NT36523 display driver IC. > > > > Signed-off-by: Jianhua Lu > > (...) > > I like how you abs

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-03-07 Thread Jianhua Lu
On Tue, Mar 07, 2023 at 11:22:35PM +0100, Linus Walleij wrote: > On Mon, Feb 20, 2023 at 1:13 PM Jianhua Lu wrote: > > > Novatek NT36523 is a display driver IC used to drive DSI panels. > > > > Signed-off-by: Jianhua Lu > > --- > > Changes in v2:

[PATCH v2 2/2] drm/panel: Add driver for Novatek NT36523

2023-02-20 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v2: - Refactor and clean up source code MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile

[PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-02-20 Thread Jianhua Lu
Novatek NT36523 is a display driver IC used to drive DSI panels. Signed-off-by: Jianhua Lu --- Changes in v2: - Drop unnecessary description - dsi0 -> dsi - Correct indentation .../display/panel/novatek,nt36523.yaml| 95 +++ 1 file changed, 95 inserti

Re: [PATCH 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-02-13 Thread Jianhua Lu
On Mon, Feb 13, 2023 at 12:23:04PM +0100, Krzysztof Kozlowski wrote: > On 13/02/2023 12:20, Jianhua Lu wrote: > > On Mon, Feb 13, 2023 at 12:08:27PM +0100, Krzysztof Kozlowski wrote: > >> On 13/02/2023 12:04, Jianhua Lu wrote: > >>> On Mon, Feb 13, 2023 at 11:45:2

Re: [PATCH 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-02-13 Thread Jianhua Lu
On Mon, Feb 13, 2023 at 12:08:27PM +0100, Krzysztof Kozlowski wrote: > On 13/02/2023 12:04, Jianhua Lu wrote: > > On Mon, Feb 13, 2023 at 11:45:23AM +0100, Krzysztof Kozlowski wrote: > >> On 10/02/2023 17:19, Jianhua Lu wrote: > >>> Novatek NT36523 is a display driv

Re: [PATCH 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-02-13 Thread Jianhua Lu
On Mon, Feb 13, 2023 at 11:45:23AM +0100, Krzysztof Kozlowski wrote: > On 10/02/2023 17:19, Jianhua Lu wrote: > > Novatek NT36523 is a display driver IC that can drive DSI panel. It > > is also present in the csot and boe video mode panels. It is found > > in X

[PATCH 2/2] drm/panel: Add driver for Novatek NT36523

2023-02-10 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 Display Driver IC, including support for the csot and boe panels right now, found in Xiaomi Mi Pad 5 series. Signed-off-by: Jianhua Lu --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 9

[PATCH 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-02-10 Thread Jianhua Lu
Novatek NT36523 is a display driver IC that can drive DSI panel. It is also present in the csot and boe video mode panels. It is found in Xiaomi Mi Pad 5 series. Signed-off-by: Jianhua Lu --- .../display/panel/novatek,nt36523.yaml| 101 ++ 1 file changed, 101 insertions

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Jianhua Lu
On Sat, Jan 28, 2023 at 06:07:08PM +0100, Uwe Kleine-König wrote: > Hello, > > On Sun, Jan 29, 2023 at 12:44:30AM +0800, Jianhua Lu wrote: > > On Sat, Jan 28, 2023 at 05:16:13PM +0100, Uwe Kleine-König wrote: > > > I don't want to squash the changes to the ktz8866 dri

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Jianhua Lu
On Sat, Jan 28, 2023 at 05:16:13PM +0100, Uwe Kleine-König wrote: > Hello, > > On Sat, Jan 28, 2023 at 10:14:09PM +0800, Jianhua Lu wrote: > > On Sat, Jan 28, 2023 at 02:32:39PM +0100, Uwe Kleine-König wrote: > > > On Sat, Jan 28, 2023 at 08:36:28AM +0800, Jianhua Lu wrot

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Jianhua Lu
On Sat, Jan 28, 2023 at 02:32:39PM +0100, Uwe Kleine-König wrote: > Hello, > > On Sat, Jan 28, 2023 at 08:36:28AM +0800, Jianhua Lu wrote: > > On Fri, Jan 27, 2023 at 04:26:39PM +0100, Uwe Kleine-König wrote: > > > The probe function doesn't make use of the i2c_devi

Re: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-28 Thread Jianhua Lu
On Fri, Jan 27, 2023 at 04:26:39PM +0100, Uwe Kleine-König wrote: > The probe function doesn't make use of the i2c_device_id * parameter so > it can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > there is an ongoing effort to convert all drivers to .probe_new to >

[PATCH v8 2/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-20 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu --- Changes

Re: [PATCH v7 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-20 Thread Jianhua Lu
On Fri, Jan 20, 2023 at 03:22:09PM +, Daniel Thompson wrote: > On Fri, Jan 20, 2023 at 05:47:27PM +0800, Jianhua Lu wrote: > > Add Kinetic KTZ8866 backlight binding documentation. > > > > Signed-off-by: Jianhua Lu > > [...] > > > > diff --git >

Re: [PATCH v7 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-20 Thread Jianhua Lu
On Fri, Jan 20, 2023 at 11:18:56AM +0100, Krzysztof Kozlowski wrote: > On 20/01/2023 10:47, Jianhua Lu wrote: > > Add Kinetic KTZ8866 backlight binding documentation. > > > > Signed-off-by: Jianhua Lu > > --- > > Changes in v2: > > - Remove "ite

[PATCH v7 2/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-20 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu --- Changes

[PATCH v9 2/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-20 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu --- Changes

Re: [PATCH v7 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-20 Thread Jianhua Lu
On Fri, Jan 20, 2023 at 03:22:09PM +, Daniel Thompson wrote: > On Fri, Jan 20, 2023 at 05:47:27PM +0800, Jianhua Lu wrote: > > Add Kinetic KTZ8866 backlight binding documentation. > > > > Signed-off-by: Jianhua Lu > > [...] > > > > diff --git >

[PATCH v8 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-20 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866". - Change "additionalProperties" to "unevaluatedProperties". Changes in v3:

[PATCH v9 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-20 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866". - Change "additionalProperties" to "un

[PATCH v7 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-20 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866". - Change "additionalProperties" to "unevaluatedProperties". Changes in v3:

[PATCH v6 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-19 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866" - Change "additionalProperties" to "unevaluatedProperties" Changes in v3

Re: [PATCH v5 2/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-19 Thread Jianhua Lu
On Wed, Jan 18, 2023 at 12:08:01PM +, Daniel Thompson wrote: > On Tue, Jan 17, 2023 at 11:44:08PM +0800, Jianhua Lu wrote: > > Add support for Kinetic KTZ8866 backlight, which is used in > > Xiaomi tablet, Mi Pad 5 series. This driver lightly based on > > downstream imple

Re: [PATCH v6 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-19 Thread Jianhua Lu
On Wed, Jan 18, 2023 at 02:40:00PM +0100, Krzysztof Kozlowski wrote: > On 18/01/2023 14:10, Jianhua Lu wrote: > > Add Kinetic KTZ8866 backlight binding documentation. > > > > Signed-off-by: Jianhua Lu > > --- > > Changes in v2: > > - Remove "ite

[PATCH v6 2/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-19 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu --- Changes

Re: [PATCH v6 2/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-19 Thread Jianhua Lu
On Wed, Jan 18, 2023 at 02:39:15PM +0100, Krzysztof Kozlowski wrote: > On 18/01/2023 14:10, Jianhua Lu wrote: > > Add support for Kinetic KTZ8866 backlight, which is used in > > Xiaomi tablet, Mi Pad 5 series. This driver lightly based on > > downstream implementation [1

[PATCH v4 2/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-18 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866" - Change "additionalProperties" to "unevaluatedProperties" Changes in v3

[PATCH v5 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-18 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866" - Change "additionalProperties" to "unevaluatedProperties" Changes in v3

[PATCH v5 2/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-18 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu --- Changes

Re: [PATCH v4 2/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-18 Thread Jianhua Lu
On Tue, Jan 17, 2023 at 02:22:04PM +, Daniel Thompson wrote: > On Tue, Jan 17, 2023 at 09:47:42PM +0800, Jianhua Lu wrote: > > Add Kinetic KTZ8866 backlight binding documentation. > > > > Signed-off-by: Jianhua Lu > > Might be a good idea to take a look at this bi

Re: [PATCH v4 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-18 Thread Jianhua Lu
On Tue, Jan 17, 2023 at 02:37:07PM +, Daniel Thompson wrote: > On Tue, Jan 17, 2023 at 10:12:18PM +0800, Jianhua Lu wrote: > > On Tue, Jan 17, 2023 at 02:04:05PM +, Daniel Thompson wrote: > > > On Tue, Jan 17, 2023 at 09:47:41PM +0800, Jianhua Lu wrote: > > >

Re: [PATCH v4 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-18 Thread Jianhua Lu
On Tue, Jan 17, 2023 at 02:04:05PM +, Daniel Thompson wrote: > On Tue, Jan 17, 2023 at 09:47:41PM +0800, Jianhua Lu wrote: > > Add support for Kinetic KTZ8866 backlight, which is used in > > Xiaomi tablet, Mi Pad 5 series. This driver lightly based on > > downstream imple

[PATCH v4 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-18 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu --- Changes

[RESEND] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu

[PATCH v3 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu --- Changes

Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight

2022-12-23 Thread jianhua lu
Thanks for review, I will resend this path. Krzysztof Kozlowski 于 2022年12月21日周三 16:13写道: > On 21/12/2022 08:02, Jianhua Lu wrote: > > Add device tree bindings for the Kinetic KTZ8866 backlight driver. > > 1. Your patches are not properly threaded which makes it difficult to >

Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight

2022-12-23 Thread jianhua lu
Yes, I will Krzysztof Kozlowski 于 2022年12月21日周三 17:46写道: > On 21/12/2022 10:40, jianhua lu wrote: > > Thanks for review, I will resend this path. > > Are you going to test it, before sending? > > Best regards, > Krzysztof > >

[PATCH v2 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu

[PATCH v2 2/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866" - Change "additionalProperties" to "unevaluatedProperties"

Re: [RESEND] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
On Wed, Dec 21, 2022 at 04:03:44PM +0100, Krzysztof Kozlowski wrote: > On 21/12/2022 14:24, Jianhua Lu wrote: > > Add Kinetic KTZ8866 backlight binding documentation. > > > > Signed-off-by: Jianhua Lu > > Do not resend. You need to fix everything, test and send a n

Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
On Wed, Dec 21, 2022 at 07:45:59AM -0600, Rob Herring wrote: > > On Wed, 21 Dec 2022 15:02:16 +0800, Jianhua Lu wrote: > > Add device tree bindings for the Kinetic KTZ8866 backlight driver. > > > > Signed-off-by: Jianhua Lu > > --- > > .../leds/backl

[RESEND] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu --- .../leds/backlight/kinetic,ktz8866.yaml | 36 +++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml diff --git a

[PATCH v3 2/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866" - Change "additionalProperties" to "u

[PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight

2022-12-21 Thread Jianhua Lu
Add device tree bindings for the Kinetic KTZ8866 backlight driver. Signed-off-by: Jianhua Lu --- .../leds/backlight/kinetic,ktz8866.yaml | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml

[PATCH 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2022-12-21 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu