Thanks for review, I will resend this path. Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org> 于 2022年12月21日周三 16:13写道：
> On 21/12/2022 08:02, Jianhua Lu wrote: > > Add device tree bindings for the Kinetic KTZ8866 backlight driver. > > 1. Your patches are not properly threaded which makes it difficult to > review and handle them. Resend with proper threads. > > 2. Subject: drop second, redundant "binding for". > > > > > Signed-off-by: Jianhua Lu <lujianhua...@gmail.com> > > --- > > .../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > > > > diff --git > a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > > new file mode 100644 > > index 000000000000..7286c3fc7f5d > > --- /dev/null > > +++ > b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > > @@ -0,0 +1,37 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Kinetic Technologies KTZ8866 backlight > > + > > +maintainers: > > + - Jianhua Lu <lujianhua...@gmail.com> > > + > > +description: | > > + The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led > backlight > > + with dual lcd bias power. > > + https://www.kinet-ic.com/ktz8866/ > > + > > +allOf: > > + - $ref: common.yaml# > > + > > +properties: > > + compatible: > > + items: > > + const: kinetic,ktz8866 > > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > > > + > > +required: > > + - compatible > > + > > +additionalProperties: false > > This should be rather unevaluatedProperties: false, otherwise you do not > allow any other properties, except compatible. Was this the intention? > > Best regards, > Krzysztof > >
