Re: [PATCH -next] drm/fb-helper: Remove unused inline function drm_fb_helper_defio_init()

2023-07-24 Thread YueHaibing
On 2023/7/24 22:27, Thomas Zimmermann wrote: > Hi > > Am 21.07.23 um 14:09 schrieb YueHaibing: >> Since commit 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() >> and update docs") >> this inline helper not used anymore. >> >>

[PATCH v2 -next] drm/fb-helper: Remove unused inline function drm_fb_helper_defio_init()

2023-07-24 Thread YueHaibing
Since commit 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs") this inline helper not used anymore. Fixes: 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs") Signed-off-by: YueHaibing Reviewed-by: Thomas Zim

[PATCH -next] drm/fb-helper: Remove unused inline function drm_fb_helper_defio_init()

2023-07-21 Thread YueHaibing
Since commit 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs") this inline helper not used anymore. Signed-off-by: YueHaibing --- include/drm/drm_fb_helper.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/i

[PATCH -next] drm/vmwgfx/ttm: Fix build error without CONFIG_TRANSPARENT_HUGEPAGE

2021-06-11 Thread YueHaibing
gt;bdev, TTM_PL_VRAM, false, ^~ ttm_tt_mgr_init Add missing include to fix this. Fixes: 252f8d7b9174 ("drm/vmwgfx/ttm: convert vram mm init to new code paths") Signed-off-by: YueHaibing --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 + 1 file changed, 1 i

[PATCH -next] drm/amdgpu: use DEVICE_ATTR_*() macro

2021-05-28 Thread YueHaibing
Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 8 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 28 +++ drivers/gpu/drm/amd/amdgpu

[PATCH -next] drm/i915: use DEVICE_ATTR_RO macro

2021-05-28 Thread YueHaibing
Use DEVICE_ATTR_RO() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing --- drivers/gpu/drm/i915/i915_pmu.c | 8 +++- drivers/gpu/drm/i915/i915_sysfs.c | 30 +++--- 2 files changed, 18 insertions

[PATCH -next] drm/exynos-vidi: use DEVICE_ATTR_RW macro

2021-05-28 Thread YueHaibing
Use DEVICE_ATTR_RW() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH -next] drm/radeon/radeon_pm: use DEVICE_ATTR_RW macro

2021-05-28 Thread YueHaibing
Use DEVICE_ATTR_RW() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing --- drivers/gpu/drm/radeon/radeon_pm.c | 56 -- 1 file changed, 23 insertions(+), 33 deletions(-) diff --git a/drivers/gpu

[PATCH -next] drm/amdgpu: Fix Wunused-label warning

2021-05-26 Thread YueHaibing
If CONFIG_64BIT is n, build warns: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:333:1: warning: label ‘exit’ defined but not used [-Wunused-label] Fixes: f89f8c6bafd0 ("drm/amdgpu: Guard against write accesses after device removal") Signed-off-by: YueHaibing --- drivers/gpu/drm/

[PATCH v2] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-03 Thread YueHaibing
e83f ("drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter") Signed-off-by: YueHaibing --- v2: Add checking for >= 0 and update commit message --- drivers/gpu/drm/bridge/ti-tpd12s015.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/b

Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-02 Thread Yuehaibing
On 2020/11/2 14:57, Tomi Valkeinen wrote: > On 31/10/2020 09:19, Sam Ravnborg wrote: >> Hi YueHaibing >> >> Thanks for the fix. Appreciated but please update as per comments below. >> >> On Sat, Oct 31, 2020 at 11:16:48AM +0800, YueHaibing wrote: >>> gpiod

[PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-01 Thread YueHaibing
gpiod_to_irq() return negative value in case of error, the existing code handle negative error codes wrongly. Fixes: cff5e6f7e83f ("drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter") Signed-off-by: YueHaibing --- drivers/gpu/drm/bridge/ti-tpd12s015.c | 2 +- 1 file

Re: [PATCH -next] drm/rockchip: cdn-dp: Mark cdn_dp_core_suspend/resume __maybe_unused

2020-11-01 Thread Yuehaibing
ping... On 2020/8/11 10:12, YueHaibing wrote: > If CONFIG_PM is not set, gcc warns: > > drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: > warning: ‘cdn_dp_resume’ defined but not used [-Wunused-function] > > Mark them __maybe_unused to fix this. > > Reported-by: Hul

Re: [PATCH] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-01 Thread Yuehaibing
On 2020/10/31 15:19, Sam Ravnborg wrote: > Hi YueHaibing > > Thanks for the fix. Appreciated but please update as per comments below. > > On Sat, Oct 31, 2020 at 11:16:48AM +0800, YueHaibing wrote: >> gpiod_to_irq() return negative value in case of error, >> the ex

[PATCH v2 -next] drm/amdkfd: Fix -Wunused-const-variable warning

2020-09-11 Thread YueHaibing
= { ^ As Huang Rui suggested, Raven already has the fallback path, so it should be out of IOMMU v2 flag. Suggested-by: Huang Rui Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd

Re: [PATCH -next] drm/rockchip: cdn-dp: Mark cdn_dp_core_suspend/resume __maybe_unused

2020-09-11 Thread Yuehaibing
ping... On 2020/8/11 10:12, YueHaibing wrote: > If CONFIG_PM is not set, gcc warns: > > drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: > warning: ‘cdn_dp_resume’ defined but not used [-Wunused-function] > > Mark them __maybe_unused to fix this. > > Reported-by: Hul

[PATCH -next] drm/amd/display: Fix possible memleak in dp_trigger_hotplug()

2020-09-10 Thread YueHaibing
If parse_write_buffer_into_params() fails, we should free wr_buf before return. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 +++- 1 file changed, 3 insert

[PATCH -next] drm/ttm/agp: Fix Wunused-variable warning

2020-09-10 Thread YueHaibing
to ifdef block to fix this. Signed-off-by: YueHaibing --- drivers/gpu/drm/radeon/radeon_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 31c63d339629..449e77eb75f9 100644 --- a/drivers/gpu

[PATCH -next] drm/amd/display: Create trigger_hotplug entry

2020-09-10 Thread YueHaibing
Add trigger_hotplug debugfs entry. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display

[PATCH -next] drm/panel: s6e63m0: Add missing MODULE_LICENSE

2020-09-10 Thread YueHaibing
Kbuild warns when this file is built as a loadable module: WARNING: modpost: missing MODULE_LICENSE() in drivers/gpu/drm/panel/panel-samsung-s6e63m0.o Add the missing license/author/description tags. Fixes: b7b23e447687 ("drm/panel: s6e63m0: Break out SPI transport") Signed-off-by:

[PATCH -next] drm/amdkfd: Fix -Wunused-const-variable warning

2020-09-10 Thread YueHaibing
= { ^ Move it to ifdef block. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c index 0e71a0543f98..cae4df259e26 100644 --- a

[PATCH -next] drm/rockchip: cdn-dp: Mark cdn_dp_core_suspend/resume __maybe_unused

2020-08-11 Thread YueHaibing
If CONFIG_PM is not set, gcc warns: drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: warning: ‘cdn_dp_resume’ defined but not used [-Wunused-function] Mark them __maybe_unused to fix this. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 4

[PATCH -next] drm/amdgpu/vcn3.0: Remove set but not used variable 'direct_poll'

2020-07-22 Thread YueHaibing
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c: In function vcn_v3_0_start_sriov: drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:1235:3: warning: variable direct_poll set but not used [-Wunused-but-set-variable] It is never used, so can remove it. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu

[PATCH -next] drm/i915: Remove unused inline function drain_delayed_work()

2020-07-15 Thread YueHaibing
It is not used since commit 058179e72e09 ("drm/i915/gt: Replace hangcheck by heartbeats") Signed-off-by: YueHaibing --- drivers/gpu/drm/i915/i915_utils.h | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i9

[PATCH -next] drm/amdgpu: remove set but not used variable 'adev'

2020-07-02 Thread YueHaibing
] struct amdgpu_device *adev; ^ Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index bb95627ad2cc..8199702d3354 100644 --- a/drivers/g

[PATCH v3 -next] drm/mediatek: Fix Kconfig warning

2020-04-30 Thread YueHaibing
mp; COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] Make DRM_MEDIATEK depend on MTK_MMSYS to fix this. Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device") Signed-off-by: YueHaibing --- v3: make DRM_MEDIATEK

[PATCH v2 -next] soc: mediatek: Fix Kconfig warning

2020-04-28 Thread YueHaibing
mp; COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] Make MTK_MMSYS select COMMON_CLK_MT8173_MMSYS to fix this. Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device") Signed-off-by: YueHaibing --- v2: select COMMON_CLK

[PATCH] drm/v3d: Set pm_ops

2020-04-20 Thread YueHaibing
v3d_v3d_pm_ops is defined but forgot to set in v3d_platform_driver. Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Signed-off-by: YueHaibing --- drivers/gpu/drm/v3d/v3d_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/v3d/v

[PATCH -next] drm/mediatek: Fix Kconfig warning

2020-04-20 Thread YueHaibing
mp; COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] Add missing dependcy COMMON_CLK_MT8173_MMSYS to fix this. Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device") Signed-off-by: YueHaibing --- drivers/gpu/drm/me

[PATCH -next] drm/amdgpu: remove set but not used variable 'priority'

2020-04-20 Thread YueHaibing
remove it. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c index 35c381ec0423..47207188c569 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_j

[PATCH -next] drm/amdgpu/gfx10: remove unused variables

2020-04-20 Thread YueHaibing
-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index 0a03e2ad5d95..942842424ea1 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +++ b

[PATCH -next] drm/gma500: remove unused variable 'hdmi_ids'

2020-04-18 Thread YueHaibing
drivers/gpu/drm/gma500/oaktrail_hdmi.c:676:35: warning: ‘hdmi_ids’ defined but not used [-Wunused-const-variable=] static const struct pci_device_id hdmi_ids[] = { ^~~~ It is never used, remove it. Reported-by: Hulk Robot Signed-off-by: YueHaibing

[PATCH -next] drm/amd/dc: remove unused variable 'video_optimized_pixel_rates'

2020-04-18 Thread YueHaibing
[] = { ^~~ commit d8cd587d2bfd ("drm/amd/display: removing MODULO change for dcn2") left behind this unused vairable, remove it. Signed-off-by: YueHaibing --- .../drm/amd/display/dc/dce/dce_clock_source.c | 33 --- 1 file changed, 33 deletions(-) di

[PATCH -next] drm/panel: remove set but not used variable 'config'

2020-04-18 Thread YueHaibing
drivers/gpu/drm/panel/panel-truly-nt35597.c:493:31: warning: variable ‘config’ set but not used [-Wunused-but-set-variable] const struct nt35597_config *config; ^~ Signed-off-by: YueHaibing --- drivers/gpu/drm/panel/panel-truly-nt35597.c | 2 -- 1 file

[PATCH -next] omapfb/dss: remove unused varible 'venc_config_pal_bdghi'

2020-04-16 Thread YueHaibing
: YueHaibing --- drivers/video/fbdev/omap2/omapfb/dss/venc.c | 43 - 1 file changed, 43 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/venc.c b/drivers/video/fbdev/omap2/omapfb/dss/venc.c index f81e2a46366d..d5404d56c922 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss

[PATCH -next] drm/omap: venc: remove unused variable 'venc_config_pal_bdghi'

2020-04-16 Thread YueHaibing
Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/omapdrm/dss/venc.c | 43 -- 1 file changed, 43 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c index 766553bb2f87..9701843ccf09 100644 --- a/drivers/gpu/drm/o

[PATCH -next] drm/tidss: Drop pointless static qualifier in dispc_find_csc()

2020-02-27 Thread YueHaibing
There is no need to have the 'const struct dispc_csc_coef *coef' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/gpu/drm/tidss/tidss_dispc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH -next] drm/amd/display: remove set but not used variable 'mc_vm_apt_default'

2020-02-21 Thread YueHaibing
. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hubp.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hubp.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hubp.c index aa7b0e7..d285ba6 100644

[RFC PATCH -next] drm/amd/display: Remove set but not unused variable 'stream_status'

2020-02-10 Thread YueHaibing
("drm/amd/display: Split program front end part that occur outside lock") involved this unused variable. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH -next] drm/panfrost: Remove set but not used variable 'bo'

2020-02-04 Thread YueHaibing
2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept") involved this unused variable. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/panfrost/panfrost_job.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panfrost/pa

[PATCH -next] crypto: ccree - remove set but not used variable 'du_size'

2020-02-04 Thread YueHaibing
ccree - fix FDE descriptor sequence") involved this unused variable, so remove it. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/crypto/ccree/cc_cipher.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_c

[PATCH -next] drm/nouveau/kms/nv50: remove set but not unused variable 'nv_connector'

2020-01-17 Thread YueHaibing
tom") left behind this. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index 5fabe2b..a82b354 100644 --- a/

[PATCH -next] video: fbdev: pxa168fb: remove unnecessary platform_get_irq

2020-01-17 Thread YueHaibing
commit 640ba2444fa9 ("drivers/video/pxa168fb.c: use devm_ functions") left behind this, it can be removed. Signed-off-by: YueHaibing --- drivers/video/fbdev/pxa168fb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168

[PATCH -next] drm/nv04/disp: remove set but not used variable 'width'

2020-01-17 Thread YueHaibing
drivers/gpu/drm/nouveau/dispnv04/arb.c: In function nv04_calc_arb: drivers/gpu/drm/nouveau/dispnv04/arb.c:56:21: warning: variable width set but not used [-Wunused-but-set-variable] 'width' is never used, so remove it. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drive

[PATCH] drm/nouveau: Fix copy-paste error in nouveau_fence_wait_uevent_handler

2020-01-12 Thread YueHaibing
Like other cases, it should use rcu protected 'chan' rather than 'fence->channel' in nouveau_fence_wait_uevent_handler. Fixes: 0ec5f02f0e2c ("drm/nouveau: prevent stale fence->channel pointers, and protect with rcu") Signed-off-by: YueHaibing --- drivers

[PATCH -next] drm/ttm: Remove set but not used variable 'mem'

2020-01-12 Thread YueHaibing
/nouveau_ttm.c:106:22: warning: variable mem set but not used [-Wunused-but-set-variable] They are not used any more, so remove it. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau

[PATCH -next] drm/ch7006: Use match_string() helper to simplify the code

2020-01-12 Thread YueHaibing
match_string() returns the array index of a matching string. Use it instead of the open-coded implementation. Signed-off-by: YueHaibing --- drivers/gpu/drm/i2c/ch7006_drv.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b

[PATCH -next] drm/i915: Add missing include file

2020-01-08 Thread YueHaibing
upper_32_bits(mul_u32_u32(prandom_u32_state(state), ep_ro)); Reported-by: Hulk Robot Fixes: 7ce5b6850b47 ("drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result") Signed-off-by: YueHaibing --- drivers/gpu/drm/i915/selftests/i915_random.h | 1 + 1 file changed, 1 insertion(+

[PATCH -next] drm/nouveau/nv04: Use match_string() helper to simplify the code

2019-12-31 Thread YueHaibing
match_string() returns the array index of a matching string. Use it instead of the open-coded implementation. Signed-off-by: YueHaibing --- drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/nouveau

[PATCH -next] drm/tegra: sor: Fix unused function warnings

2019-12-06 Thread YueHaibing
_runtime_resume' defined but not used [-Wunused-function] drivers/gpu/drm/tegra/sor.c:3915:12: warning: 'tegra_sor_runtime_suspend' defined but not used [-Wunused-function] Mark these functions as __maybe_unused so gcc can drop them silently. Reported-by: Hulk Robot Signed-off-by

[PATCH -next] drm/amd/powerplay: remove set but not used variable 'stretch_amount2'

2019-11-26 Thread YueHaibing
removed. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c index 50896e9

[PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'

2019-11-26 Thread YueHaibing
/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption: drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable] It is never used, so remove it. Reported-by: Hulk Robot Signed-off-by: YueHaibing

[PATCH v2 -next] drm/amd/display: remove set but not used variable 'bpc'

2019-11-12 Thread YueHaibing
used since commit e49f69363adf ("drm/amd/display: use proper formula to calculate bandwidth from timing"), this also remove get_color_depth(), which is only used here. Signed-off-by: YueHaibing --- v2: also remove unused get_color_depth() --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 1

Re: [PATCH -next] drm/amd/display: Fix old-style declaration

2019-11-12 Thread Yuehaibing
On 2019/11/12 10:39, Joe Perches wrote: > On Mon, 2019-11-11 at 20:28 +0800, YueHaibing wrote: >> Fix a build warning: >> >> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: >> warning: 'static' is not at beginning of declaration >> [-Wold-styl

[PATCH -next] drm/amd/display: Fix old-style declaration

2019-11-12 Thread YueHaibing
Fix a build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH -next] drm/amd/display: remove set but not used variable 'bpc'

2019-11-10 Thread YueHaibing
used since commit e49f69363adf ("drm/amd/display: use proper formula to calculate bandwidth from timing") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers

[PATCH -next] drm/amd/display: remove set but not used variable 'ds_port'

2019-11-10 Thread YueHaibing
t is never used, so can be removed. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index 65de32f..b814b74 10

[PATCH -next] gpu: host1x: Remove dev_err() on platform_get_irq() failure

2019-11-03 Thread YueHaibing
platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/gpu/host1x/dev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/host1x/dev.c b

[PATCH -next] drm/vmwgfx: remove set but not used variable 'srf'

2019-11-01 Thread YueHaibing
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:339:22: warning: variable srf set but not used [-Wunused-but-set-variable] 'srf' is never used, so can be removed. Signed-off-by: YueHaibing --- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drive

Re: [PATCH -next] gpu: host1x: Fix compile test failure

2019-11-01 Thread Yuehaibing
On 2019/11/1 17:47, Thierry Reding wrote: > On Thu, Oct 31, 2019 at 09:33:38PM +0800, Yuehaibing wrote: >> On 2019/10/31 6:26, Dmitry Osipenko wrote: >>> 30.10.2019 16:54, YueHaibing пишет: >>>> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and >>

Re: [PATCH -next] gpu: host1x: Fix compile test failure

2019-11-01 Thread Yuehaibing
On 2019/10/31 6:26, Dmitry Osipenko wrote: > 30.10.2019 16:54, YueHaibing пишет: >> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and >> COMPILE_TEST is y, building fails: >> >> drivers/gpu/host1x/dev.o: In function `host1x_remove': >> dev.c

[PATCH -next] gpu: host1x: Fix compile test failure

2019-10-31 Thread YueHaibing
Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") Signed-off-by: YueHaibing --- drivers/gpu/host1x/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig index cf987a3..354232d 100644 --- a/drivers/gpu/host

Re: [PATCH 3/3] drm/amd/powerplay: Make two functions static

2019-10-28 Thread Yuehaibing
On 2019/10/28 22:06, Alex Deucher wrote: > On Mon, Oct 28, 2019 at 9:37 AM YueHaibing wrote: >> >> Fix sparse warnings: >> >> drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2050:5: >> warning: symbol 'arcturus_i2c_eeprom_control_init'

[PATCH -next] drm/amd/display: Make calculate_integer_scaling static

2019-10-28 Thread YueHaibing
Fix sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:963:6: warning: symbol 'calculate_integer_scaling' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2

[PATCH 3/3] drm/amd/powerplay: Make two functions static

2019-10-28 Thread YueHaibing
ntrol_fini' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/g

[PATCH -next] drm/amdgpu: remove set but not used variable 'adev'

2019-10-23 Thread YueHaibing
: variable adev set but not used [-Wunused-but-set-variable] It is never used, so can removed it. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu

[PATCH -next] drm/amd/display: Make dc_link_detect_helper static

2019-10-18 Thread YueHaibing
Fix sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:746:6: warning: symbol 'dc_link_detect_helper' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 ++- 1 file

[PATCH -next] drm/vkms: Remove duplicated include from vkms_drv.c

2019-10-10 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/gpu/drm/vkms/vkms_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 54703463d966..d1fe144aa289 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b

[PATCH -next] drm/qxl: Fix randbuild error

2019-10-07 Thread YueHaibing
If DEM_QXL is y and DRM_TTM_HELPER is m, building fails: drivers/gpu/drm/qxl/qxl_object.o: undefined reference to `drm_gem_ttm_print_info' Select DRM_TTM_HELPER to fix this. Fixes: 78d54f1f6a33 ("drm/qxl: use drm_gem_ttm_print_info") Signed-off-by: YueHaibing --- drivers/gpu/

[PATCH -next] drm/amdgpu: remove duplicated include from mmhub_v1_0.c

2019-10-07 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c index 4c7e8c64a94e..6965e1e6fa9e 100644 --- a/drivers/gpu/drm

[PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync'

2019-10-07 Thread YueHaibing
ed-but-set-variable] It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync module") Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers

[PATCH -next] fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify code

2019-09-05 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/video/fbdev/s3c-fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video

[PATCH -next] fbdev: wm8505fb: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/video/fbdev/wm8505fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/wm8505fb.c b/drivers

[PATCH -next] fbdev/sa1100fb: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/video/fbdev/sa1100fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers

[PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/video/fbdev/omap2/omapfb/vrfb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb

[PATCH -next] fbdev: da8xx-fb: use devm_platform_ioremap_resource() to simplify code

2019-09-04 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/video/fbdev/da8xx-fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers

[PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

2019-08-27 Thread YueHaibing
After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), there is no caller in tree. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- .../drm/amd/display/modules/info_packet/info_packet.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/g

[PATCH -next] drm/amdgpu/display: fix build error without CONFIG_DRM_AMD_DC_DSC_SUPPORT

2019-08-27 Thread YueHaibing
;drm/amd/display: Make init_hw and init_pipes generic for seamless boot") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/dis

[PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static

2019-07-31 Thread YueHaibing
Fix sparse warning: drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1151:5: warning: symbol 'analogix_dp_atomic_check' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- 1 fi

[PATCH] drm/bridge: tc358764: Fix build error

2019-07-29 Thread YueHaibing
S_HELPER to fix this, and change to select DRM_PANEL to avoid recursive dependency. Reported-by: Hulk Robot Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver") Signed-off-by: YueHaibing --- drivers/gpu/drm/bridge/Kconfig | 3 ++- 1 file changed, 2 insertions(+

[PATCH] drm/amdkfd: remove set but not used variable 'pdd'

2019-07-29 Thread YueHaibing
nce commit 5b87245faf57 ("drm/amdkfd: Simplify kfd2kgd interface") Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/

[PATCH v2] drm/bridge: lvds-encoder: Fix build error while CONFIG_DRM_KMS_HELPER=m

2019-07-29 Thread YueHaibing
ix lvds-encoder since the panel_bridge rework.") Signed-off-by: YueHaibing --- v2: remove tc358764 log in commit log, also fix Fixes tag --- drivers/gpu/drm/bridge/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig in

[PATCH] drm/bridge: lvds-encoder: Fix build error while CONFIG_DRM_KMS_HELPER=m

2019-07-28 Thread YueHaibing
7; drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x270): undefined reference to `drm_atomic_helper_connector_destroy_state' Reported-by: Hulk Robot Fixes: dbb58bfd9ae6 drm/bridge: ("Fix lvds-encoder since the panel_bridge rework.") Signed-off-by: YueHaibing --- drivers/gpu/drm/bridge/Kc

Re: [PATCH] drm/bridge: lvds-encoder: Fix build error

2019-07-28 Thread Yuehaibing
Pls drop this one, will resend new. On 2019/7/29 14:35, YueHaibing wrote: > If CONFIG_DRM_LVDS_ENCODER=y but CONFIG_DRM_KMS_HELPER=m, > build fails: > > drivers/gpu/drm/bridge/lvds-encoder.o: In function `lvds_encoder_probe': > lvds-encoder.c:(.text+0x155): un

[PATCH] drm/bridge: lvds-encoder: Fix build error

2019-07-28 Thread YueHaibing
("Fix lvds-encoder since the panel_bridge rework.") Signed-off-by: YueHaibing --- drivers/gpu/drm/bridge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index a6eec90..2926750 100644 --- a/drivers/gp

[PATCH] drm/amd/display: remove duplicated include from dc_link.c

2019-07-26 Thread YueHaibing
Remove duplicated include. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c index 193d6f1

[PATCH -next] drm/mga: remove set but not used variable 'buf_priv'

2019-07-23 Thread YueHaibing
eported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/mga/mga_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/mga/mga_state.c b/drivers/gpu/drm/mga/mga_state.c index 77a0b006f066..0dec4062e5a2 100644 --- a/drivers/gpu/drm/mga/mga_state.c +++ b/drivers/gpu

[PATCH -next] drm/mediatek: Remove duplicated include from mtk_drm_drv.c

2019-07-23 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 2ee809a6f3dc..e3b64a266dcf 100644 --- a/drivers/gpu/drm

[PATCH -next] drm/amd/display: Make pow_buffer_ptr static

2019-07-23 Thread YueHaibing
Fix sparse warning: drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:62:5: warning: symbol 'pow_buffer_ptr' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2

[PATCH v2 -next] drm/komeda: remove set but not used variable 'old'

2019-07-21 Thread YueHaibing
used since commit 990dee3aa456 ("drm/komeda: Computing image enhancer internally") Reported-by: Hulk Robot Signed-off-by: YueHaibing --- v2: fix compile err --- drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH -next] drm/komeda: remove set but not used variable 'old'

2019-07-21 Thread Yuehaibing
On 2019/7/19 21:04, Daniel Vetter wrote: > On Thu, Jul 18, 2019 at 08:51:50PM +0200, Daniel Vetter wrote: >> On Tue, Jul 09, 2019 at 09:58:08PM +0800, YueHaibing wrote: >>> Fixes gcc '-Wunused-but-set-variable' warning: >>> >>> drivers/gpu/drm/arm/d

[PATCH -next] drm/i915/icl: Remove set but not used variable 'src_y'

2019-07-18 Thread YueHaibing
-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/i915/display/intel_sprite.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c index 34586f29be60..9c3367491f04 100644 ---

[PATCH -next] drm/i915/dsi: remove set but not used variable 'hfront_porch'

2019-07-18 Thread YueHaibing
never used and can be removed. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/i915/display/icl_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c index 4d952accf

[PATCH -next] drm/nouveau/secboot: Make acr_r352_ls_gpccs_func static

2019-07-17 Thread YueHaibing
Fix sparse warning: drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c:1092:1: warning: symbol 'acr_r352_ls_gpccs_func' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 2

[PATCH] drm/amdgpu: Fix build without CONFIG_HMM_MIRROR

2019-07-10 Thread YueHaibing
mirror; Fixes: 7590f6d211ec ("drm/amdgpu: Prepare for hmm_range_register API change") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH -next] drm/amdgpu: remove duplicated include from gfx_v9_0.c

2019-07-10 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 5ba332376710..822f45161240 100644 --- a/drivers/gpu/drm/amd

[PATCH -next] drm/komeda: remove set but not used variable 'old'

2019-07-09 Thread YueHaibing
used since commit 990dee3aa456 ("drm/komeda: Computing image enhancer internally") Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pl

[PATCH -next] drm/i915: Remove set but not used variable 'encoder'

2019-07-05 Thread YueHaibing
used, so can be removed.Also remove related variable 'dig_port' Signed-off-by: YueHaibing --- drivers/gpu/drm/i915/display/intel_dp.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 8f7188

[PATCH -next] drm/i915: Remove set but not used variable 'intel_dig_port'

2019-07-05 Thread YueHaibing
e] struct intel_digital_port *intel_dig_port; It is never used, so can be removed. Signed-off-by: YueHaibing --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index a4172595c

[PATCH -next] drm/amdgpu: remove set but not used variable 'psp_enabled'

2019-06-27 Thread YueHaibing
uction in commit c6b6a42175f5 ("drm/amdgpu: add navi10 common ip block (v3)") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/nv.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index af20ffb55c54..8b9fa3d

  1   2   >