platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Signed-off-by: YueHaibing <yuehaib...@huawei.com>
---
 drivers/gpu/host1x/dev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
index a738ea5..388bcc2 100644
--- a/drivers/gpu/host1x/dev.c
+++ b/drivers/gpu/host1x/dev.c
@@ -339,10 +339,8 @@ static int host1x_probe(struct platform_device *pdev)
        }
 
        syncpt_irq = platform_get_irq(pdev, 0);
-       if (syncpt_irq < 0) {
-               dev_err(&pdev->dev, "failed to get IRQ: %d\n", syncpt_irq);
+       if (syncpt_irq < 0)
                return syncpt_irq;
-       }
 
        mutex_init(&host->devices_lock);
        INIT_LIST_HEAD(&host->devices);
-- 
2.7.4


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to