[PATCH v3 3/3] drm/bridge:anx7625: Enable DSC feature

2025-04-14 Thread Xin Ji
nformation between SOC and anx7625 v2: 1. Remove dsc_en flag v3: 1. Split timing refactoring code to a individual patch. 2. Add drm_dsi_host compression_supported flag check. If DSI host not supported compression, anx7625 bridge driver will limit maximum pixel clock to 250M. Signed-off-

[PATCH v3 2/3] drm/mipi-dsi: Add compression supported flag in drm_mipi_dsi

2025-04-14 Thread Xin Ji
Add compression_supported flag in struct drm_mipi_dsi to indicate whether DSI host supported DSC compression feature. Signed-off-by: Xin Ji --- include/drm/drm_mipi_dsi.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index

[PATCH v3 1/3] drm/bridge:anx7625: Refactoring timing programming

2025-04-14 Thread Xin Ji
Refactoring timing programming into two functions. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 124 ++ drivers/gpu/drm/bridge/analogix/anx7625.h | 4 + 2 files changed, 85 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/bridge

RE: [PATCH v2] drm/bridge:anx7625: Enable DSC feature

2025-04-05 Thread Xin Ji
; > Anx7625 is bridge IC, sink monitor only receive normal DP signal > > > > from anx7625, sink device didn't know DSC information between SOC > > > > and > > > > anx7625 > > > > > > > > v2: > > > > 1. Add more commit message

RE: [PATCH v2] drm/bridge:anx7625: Enable DSC feature

2025-04-05 Thread Xin Ji
gt; > > > > > > > > > v2: > > > > > 1. Add more commit message > > > > > 2. Remove unused code > > > > > 3. Add more comment > > > > > > > > This part is useless, it adds no information. It is as good as &

RE: [PATCH v2] drm/bridge:anx7625: Enable DSC feature

2025-03-30 Thread Xin Ji
t; > anx7625 > > > > v2: > > 1. Add more commit message > > 2. Remove unused code > > 3. Add more comment > > This part is useless, it adds no information. It is as good as 'changed it'. OK, I'll remove it > > > 4. Remove dsc_en flag &

RE: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-03-30 Thread Xin Ji
> > > > > > > > > > > > > > > > From: Dmitry Baryshkov > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Sent: Thursday, February 13, 20

[PATCH] drm/bridge: anx7625: Fix not display after S4/S5 resume back

2025-03-27 Thread Xin Ji
eeping the HPD_STATUS_CHANGE check. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 0b61e77c0398..1afa65756bd2 100644 --- a/drivers/gpu/

[PATCH v2] drm/bridge:anx7625: Enable DSC feature

2025-03-27 Thread Xin Ji
evice through DP link. Anx7625 is bridge IC, sink monitor only receive normal DP signal from anx7625, sink device didn't know DSC information between SOC and anx7625 v2: 1. Add more commit message 2. Remove unused code 3. Add more comment 4. Remove dsc_en flag Signed-off-by: Xin Ji --- drive

RE: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-03-27 Thread Xin Ji
> > > > > > > > > > > > > > From: Dmitry Baryshkov > > > > > > > > > > > > > > > > > > > > > > > > > > > > Sent: Thursday, February 13, 2025 9:04 PM > > > >

RE: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-02-27 Thread Xin Ji
> > > > > > > > > > > > From: Dmitry Baryshkov > > > > > > > > > > > > > > > > > > > > > > > > Sent: Thursday, February 13, 2025 9:04 PM > > > > >

RE: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-02-27 Thread Xin Ji
> > > > > > > > > > From: Dmitry Baryshkov > > > > > > > > > > Sent: Thursday, February 13, 2025 9:04 PM > > > > > > > > > > To: Xin Ji > > > > > > > > > > Cc: Andrzej Haj

RE: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-02-26 Thread Xin Ji
> > > > > > > > From: Dmitry Baryshkov > > > > > > > > Sent: Thursday, February 13, 2025 9:04 PM > > > > > > > > To: Xin Ji > > > > > > > > Cc: Andrzej Hajda ; Neil > > > > > > >

RE: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-02-17 Thread Xin Ji
> > > > > > > From: Dmitry Baryshkov > > > > > > > Sent: Thursday, February 13, 2025 9:04 PM > > > > > > > To: Xin Ji > > > > > > > Cc: Andrzej Hajda ; Neil Armstrong > > > > >

RE: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-02-14 Thread Xin Ji
> > > > > From: Dmitry Baryshkov > > > > > Sent: Thursday, February 13, 2025 9:04 PM > > > > > To: Xin Ji > > > > > Cc: Andrzej Hajda ; Neil Armstrong > > > > > ; Robert Foss ; > > > > > Laurent Pinchart ;

RE: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-02-14 Thread Xin Ji
> -Original Message- > From: Dmitry Baryshkov > Sent: Friday, February 14, 2025 7:47 PM > To: Xin Ji > Cc: Andrzej Hajda ; Neil Armstrong > ; Robert Foss ; Laurent Pinchart > ; Jonas Karlman ; > Jernej Skrabec ; Maarten Lankhorst > ; Maxime Ripard ; > Th

RE: [PATCH] drm/bridge:anx7625: Enable DSC feature

2025-02-14 Thread Xin Ji
> -Original Message- > From: Dmitry Baryshkov > Sent: Thursday, February 13, 2025 9:04 PM > To: Xin Ji > Cc: Andrzej Hajda ; Neil Armstrong > ; Robert Foss ; Laurent Pinchart > ; Jonas Karlman ; > Jernej Skrabec ; Maarten Lankhorst > ; Maxime Ripard ; > Th

[PATCH] drm/bridge:anx7625: Enable DSC feature

2025-02-13 Thread Xin Ji
As anx7625 MIPI RX bandwidth(maximum 1.5Gbps per lane) and internal pixel clock(maximum 300M) limitation. Anx7625 must enable DSC feature while MIPI source want to output 4K30 resolution. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 300 ++ drivers

[PATCH v4] drm/bridge:anx7625: Update HDCP content status

2024-12-18 Thread Xin Ji
: - Move hdcp content value checking from bridge interface .atomic_check() to .atomic_enable() v2: - Add more details in commit message Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 73 +-- 1 file changed, 29 insertions(+), 44 deletions(-) diff --git a

RE: [PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-18 Thread Xin Ji
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, December 18, 2024 6:32 PM > To: Xin Ji > Cc: Pin-yen Lin ; Andrzej Hajda > ; Neil Armstrong ; > Robert Foss ; Laurent Pinchart > ; Jonas Karlman ; > Jernej Skrabec ; Maarten Lankhorst > ; Maxim

RE: [PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-18 Thread Xin Ji
> -Original Message- > From: Dmitry Baryshkov > Sent: Tuesday, December 17, 2024 8:30 PM > To: Xin Ji > Cc: Pin-yen Lin ; Andrzej Hajda > ; Neil Armstrong ; > Robert Foss ; Laurent Pinchart > ; Jonas Karlman ; > Jernej Skrabec ; Maarten Lankhorst > ; Maxim

RE: [PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-16 Thread Xin Ji
> -Original Message- > From: Pin-yen Lin > Sent: Monday, December 16, 2024 8:05 PM > To: Dmitry Baryshkov > Cc: Xin Ji ; Andrzej Hajda ; > Neil Armstrong ; Robert Foss ; > Laurent Pinchart ; Jonas Karlman > ; Jernej Skrabec ; Maarten > Lankhorst ; Maxime R

RE: [PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-16 Thread Xin Ji
> -Original Message- > From: Dmitry Baryshkov > Sent: Friday, December 13, 2024 9:17 PM > To: Xin Ji > Cc: Andrzej Hajda ; Neil Armstrong > ; Robert Foss ; Laurent Pinchart > ; Jonas Karlman ; > Jernej Skrabec ; Maarten Lankhorst > ; Maxime Ripard ; > Th

RE: [PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-13 Thread Xin Ji
hange HDCP content too (mustn't keep to ENABLE), as DRM doc said, kernel cannot change from ENABLE to UNDESIRE, so next patch, I'll change it to DESIRE in .atomic_disable(). Thanks! Xin > -Original Message- > From: Dmitry Baryshkov > Sent: Friday, December 13, 20

RE: [PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-13 Thread Xin Ji
Hi Dmitry, thanks for the review, I made some changes which change ENABLE to DESIRE in .atomic_disable(), I'll upstream it after testing. Thanks! > -Original Message- > From: Dmitry Baryshkov > Sent: Thursday, December 12, 2024 5:18 PM > To: Xin Ji > Cc: Andrzej Ha

[PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-11 Thread Xin Ji
in bridge interface .atomic_disable(). Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 74 ++- 1 file changed, 46 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index

RE: [PATCH v2] drm/bridge:anx7625: Update HDCP status at atomic_disable()

2024-12-11 Thread Xin Ji
Hi Dmitry and Pin-yen Lin, thanks for the review. > -Original Message- > From: Dmitry Baryshkov > Sent: Thursday, December 12, 2024 7:20 AM > To: Pin-yen Lin > Cc: Xin Ji ; Andrzej Hajda ; > Neil Armstrong ; Robert Foss ; > Laurent Pinchart ; Jonas Karlman > ;

[PATCH v2] drm/bridge:anx7625: Update HDCP status at atomic_disable()

2024-12-08 Thread Xin Ji
interface .atomic_disable(). Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 25 ++- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index a2675b121fe4

RE: [PATCH] drm/bridge:anx7625: Update HDCP status at atomic_disable()

2024-12-08 Thread Xin Ji
> -Original Message- > From: Dmitry Baryshkov > Sent: Saturday, November 30, 2024 4:56 PM > To: Xin Ji > Cc: Andrzej Hajda ; Neil Armstrong > ; Robert Foss ; Laurent Pinchart > ; Jonas Karlman ; > Jernej Skrabec ; Maarten Lankhorst > ; Maxime Ripard ; > Th

[PATCH] drm/bridge:anx7625: Update HDCP status at atomic_disable()

2024-11-26 Thread Xin Ji
Update HDCP content_protection to DRM_MODE_CONTENT_PROTECTION_UNDESIRED in bridge .atomic_disable(). Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 25 ++- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix

[PATCH 2/2] drm/bridge: anx7625: Fix Set HPD irq detect window to 2ms

2023-11-20 Thread Xin Ji
Polling firmware HPD GPIO status, set HPD irq detect window to 2ms after firmware HPD GPIO initial done Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 51 --- drivers/gpu/drm/bridge/analogix/anx7625.h | 4 ++ 2 files changed, 40 insertions(+), 15

[PATCH 1/2] Revert "drm/bridge: Add 200ms delay to wait FW HPD status stable"

2023-11-20 Thread Xin Ji
This reverts commit 330140d7319fcc4ec68bd924ea212e476bf12275 200ms delay will cause panel display image later than backlight turn on, revert this patch. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-22 Thread Xin Ji
For the no-interrupt design (sink device is panel, polling HPD status when chip power on), anx7625 FW has more than 200ms HPD de-bounce time in FW, for the safety to get HPD status, driver better to wait 200ms before HPD detection after OS resume back. Signed-off-by: Xin Ji --- drivers/gpu/drm

RE: [PATCH] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-22 Thread Xin Ji
Hi Jani Nikula, thanks for reviewing, I'll use msleep instead, thanks! Xin > -Original Message- > From: Jani Nikula > Sent: Thursday, September 21, 2023 8:09 PM > To: Xin Ji ; Andrzej Hajda ; > Neil Armstrong ; Robert Foss ; > Laurent Pinchart ; Jonas Karlman >

RE: [PATCH] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-21 Thread Xin Ji
Hi Laurent Pinchart, thanks for reviewing, I'll update the new patch, thanks! Xin > -Original Message- > From: Laurent Pinchart > Sent: Thursday, September 21, 2023 8:13 PM > To: Jani Nikula > Cc: Xin Ji ; Andrzej Hajda ; > Neil Armstrong ; Robert Foss ; > Jona

[PATCH] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-21 Thread Xin Ji
For the none-interrupt design(sink device is panel, polling HPD status when chip power on), anx7625 FW has more than 200ms HPD de-bounce time in FW, for the safety to get HPD status, driver better to wait 200ms before HPD detection after OS resume back. Signed-off-by: Xin Ji --- drivers/gpu/drm

[PATCH] drm/bridge: anx7625: keep last configure timing

2022-12-08 Thread Xin Ji
Sometimes kernel may resume back quickly after suspend, and DRM not call .mode_set() to re-config display timing before calling .atomic_enable(), bridge driver with this patch to keep last configure timing. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - 1 file

Re: [PATCH] drm/bridge: anx7625: Set HPD irq detect window to 2ms

2022-09-05 Thread Xin Ji
On Mon, Sep 05, 2022 at 06:48:06PM +0200, Robert Foss wrote: > Hi Xin, > > On Sat, 3 Sept 2022 at 15:09, Xin Ji wrote: > > > > Some panels trigger HPD irq due to noise, the HPD debounce > > may be 1.8ms, exceeding the default irq detect window, ~1.4ms. > > This p

[PATCH] drm/bridge: anx7625: Set HPD irq detect window to 2ms

2022-09-03 Thread Xin Ji
Some panels trigger HPD irq due to noise, the HPD debounce may be 1.8ms, exceeding the default irq detect window, ~1.4ms. This patch set HPD irq detection window to 2ms to tolerate the HPD noise. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 14 ++ drivers

[PATCH] drm/bridge: anx7625: Support HDMI_I2S audio format

2022-07-25 Thread Xin Ji
1. Support HDMI_I2S audio format. 2. Return 0 if there is no sink connection in .hw_param callback. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix

Re: [PATCH 4/4] drm/bridge: anx7625: Add wait_hpd_asserted() callback

2022-07-05 Thread Xin Ji
Hi Hsin-Yi, thanks for your patch, it looks good to me. Reviewed-by: Xin Ji Thanks, Xin On Thu, Jun 30, 2022 at 12:05:50AM +0800, Hsin-Yi Wang wrote: > Move hpd polling check into wait_hpd_asserted() callback. For the cases > that aux transfer function wasn't used, do hpd polling

Re: [PATCH 3/4] drm/bridge: anx7625: Fix NULL pointer crash when using edp-panel

2022-07-05 Thread Xin Ji
Hi Hsin-Yi, thanks for your patch, it looks good to me. Reviewed-by: Xin Ji Thanks, Xin On Thu, Jun 30, 2022 at 12:05:49AM +0800, Hsin-Yi Wang wrote: > Move devm_of_dp_aux_populate_ep_devices() after pm runtime and i2c setup > to avoid NULL pointer crash. > > edp

Re: [PATCH 2/4] drm/bridge: anx7625: Use pm_runtime_force_suspend(resume)

2022-07-05 Thread Xin Ji
Hi Hsin-Yi, thanks for your patch, looks good to me. Reviewed-by: Xin Ji Thanks, Xin On Thu, Jun 30, 2022 at 12:05:48AM +0800, Hsin-Yi Wang wrote: > There's no need to check for IRQ or disable it in suspend. > > Use pm_runtime_force_suspend(resume) to make sure anx7625

Re: [PATCH 1/4] drm/bridge: anx7625: Convert to devm_i2c_new_dummy_device()

2022-07-05 Thread Xin Ji
Hi Hsin-Yi, thanks for your patch, looks good to me. Reviewed-by: Xin Ji On Thu, Jun 30, 2022 at 12:05:47AM +0800, Hsin-Yi Wang wrote: > Simplify the resource management. > > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 96 +++---

Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type

2022-05-22 Thread Xin Ji
On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote: > On Sat, 21 May 2022 at 18:07, Daniel Vetter wrote: > > > > On Tue, 17 May 2022 at 18:09, Robert Foss wrote: > > > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji wrote: > > > > > > &g

Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type

2022-04-25 Thread Xin Ji
On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss wrote: > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss wrote: > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji wrote: > > > > > >

[PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type

2022-04-22 Thread Xin Ji
As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 --

[PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property

2022-04-22 Thread Xin Ji
Add 'bus-type' and 'data-lanes' define, bus-type 7 for MIPI DPI input, others for DSI input. Signed-off-by: Xin Ji --- V1 -> V2: rebase on the latest code. --- .../display/bridge/analogix,anx7625.yaml | 19 ++- 1 file changed, 18 insertions(+), 1 del

Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI)

2022-04-22 Thread Xin Ji
On Mon, Apr 18, 2022 at 02:31:38PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Thu, Apr 14, 2022 at 10:27 AM Xin Ji wrote: > > > > On Wed, Apr 13, 2022 at 04:28:51PM +0200, Robert Foss wrote: > > > On Sat, 9 Apr 2022 at 06:47, Xin Ji wrote: > > > > > &

Re: [PATCH] drm/bridge: anx7625: Fill in empty ELD when no connector

2022-04-18 Thread Xin Ji
py eld\n"); > + memcpy(buf, ctx->connector->eld, > +min(sizeof(ctx->connector->eld), len)); > } > > - dev_dbg(dev, "audio copy eld\n"); > - memcpy(buf, ctx->connector->eld, > -

Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI)

2022-04-13 Thread Xin Ji
On Wed, Apr 13, 2022 at 04:28:51PM +0200, Robert Foss wrote: > On Sat, 9 Apr 2022 at 06:47, Xin Ji wrote: > > > > On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote: > > > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > > >

Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI)

2022-04-08 Thread Xin Ji
On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote: > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > > Change bus-type define for DPI. > > > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") > > > > Signed-

[PATCH 4/4] drm/bridge: anx7625: Use DPI bus type

2022-03-28 Thread Xin Ji
As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 --

[PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI)

2022-03-28 Thread Xin Ji
Change bus-type define for DPI. Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") Signed-off-by: Xin Ji --- .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/

Re: [PATCH v12 3/4] drm/bridge: anx7625: add MIPI DPI input feature

2022-03-28 Thread Xin Ji
On Mon, Mar 28, 2022 at 11:54:12AM +0200, Robert Foss wrote: > > > > > > > - DRM_DEV_DEBUG_DRIVER(dev, "found dsi host node.\n"); > > > > > > > + bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > > > > + mipi_lanes = MAX_LANES_SUPPORT; > > > > > > > + ep0 = of_graph_get_endpoint_by_regs(np,

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-24 Thread Xin Ji
On Thu, Mar 24, 2022 at 01:07:56PM +0100, Robert Foss wrote: > > > > > The driver uses DRM_DEV_* for logs. Can we use this? > > > > Hi Hsin-Yi, as comment in drm/drm_print.h: > > > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > > > > use DRM_DEV_* any more. I'll send a pa

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
On Tue, Mar 22, 2022 at 05:16:43PM +0800, Chen-Yu Tsai wrote: > On Tue, Mar 22, 2022 at 4:52 PM Xin Ji wrote: > > > > On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > > > > &

Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > As downstream sink was set into standby mode while bridge disabled, > > this patch used for setting downstream sink into normal status > > while enable

[PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
As downstream sink was set into standby mode while bridge disabled, this patch used for setting downstream sink into normal status while enable bridge. Signed-off-by: Xin Ji Reviewed-by: Pin-Yen Lin --- V1 -> V2: use dev_dbg replace of dev_info --- drivers/gpu/drm/bridge/analogix/anx762

Re: drm/bridge: anx7625: Set downstream sink into normal status

2022-03-22 Thread Xin Ji
this earlier. > > Best regards, > Pin-yen Hi Pin-yen, OK, I'll change it in next version. Thanks, Xin > > On Thu, Mar 3, 2022 at 3:52 PM Pin-yen Lin wrote: > > > > Reviewed-by: Pin-Yen Lin > > > > > > On Wed, Mar 2, 2022 at 8:09 PM Xin Ji wr

Re: [PATCH v12 3/4] drm/bridge: anx7625: add MIPI DPI input feature

2022-03-21 Thread Xin Ji
> Hello Xin, > > > > > > > > (Question for Rob below, and I'm afraid this is urgent as we need to > > > > merge a fix in v5.17). > > > > > > > > On Fri, Nov 05, 2021 at 11:19:03AM +0800, Xin Ji wrote: > > > > > The

Re: [PATCH v2] drm/bridge: anx7625: Fix not correct get property counts

2022-03-13 Thread Xin Ji
On Fri, Mar 11, 2022 at 12:36:09PM +0100, Sam Ravnborg wrote: > Hi Xin. > > On Fri, Mar 11, 2022 at 06:35:25PM +0800, Xin Ji wrote: > > The property length which returns from "of_get_property", it means array > > bytes count if the property has prefix as "/

[PATCH v2] drm/bridge: anx7625: Fix not correct get property counts

2022-03-11 Thread Xin Ji
MIPI DPI input feature") Signed-off-by: Xin Ji --- V1 -> V2: Fix Sam comment, use of_property_read_u8_array to get array value --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 drivers/gpu/drm/bridge/analogix/anx7625.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deleti

Re: [PATCH] drm/bridge: anx7625: Fix not correct get property counts

2022-03-10 Thread Xin Ji
On Thu, Mar 10, 2022 at 07:53:59PM +0100, Sam Ravnborg wrote: > Hi Xin, > > On Thu, Mar 10, 2022 at 05:16:53PM +0800, Xin Ji wrote: > > The property length which returns from "of_get_property", divided by > > sizeof(int) to get the total property counts. > >

[PATCH] drm/bridge: anx7625: Fix not correct get property counts

2022-03-10 Thread Xin Ji
The property length which returns from "of_get_property", divided by sizeof(int) to get the total property counts. Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 2 ++ 1 file c

Re: [PATCH v12 3/4] drm/bridge: anx7625: add MIPI DPI input feature

2022-03-06 Thread Xin Ji
On Mon, Mar 07, 2022 at 01:17:44PM +0800, Hsin-Yi Wang wrote: > On Mon, Mar 7, 2022 at 1:09 PM Xin Ji wrote: > > > > On Mon, Mar 07, 2022 at 06:47:44AM +0200, Laurent Pinchart wrote: > > > Hello Xin, > > > > > > On Mon, Mar 07, 2022 at 12:32:49PM +0800,

Re: [PATCH v12 3/4] drm/bridge: anx7625: add MIPI DPI input feature

2022-03-06 Thread Xin Ji
On Mon, Mar 07, 2022 at 06:47:44AM +0200, Laurent Pinchart wrote: > Hello Xin, > > On Mon, Mar 07, 2022 at 12:32:49PM +0800, Xin Ji wrote: > > On Mon, Mar 07, 2022 at 05:30:09AM +0200, Laurent Pinchart wrote: > > > On Mon, Mar 07, 2022 at 11:22:48AM +0800, Xin Ji wrote

Re: [PATCH v12 3/4] drm/bridge: anx7625: add MIPI DPI input feature

2022-03-06 Thread Xin Ji
On Mon, Mar 07, 2022 at 05:30:09AM +0200, Laurent Pinchart wrote: > Hello Xin, > > On Mon, Mar 07, 2022 at 11:22:48AM +0800, Xin Ji wrote: > > On Sun, Mar 06, 2022 at 07:13:30PM +0200, Laurent Pinchart wrote: > > > Hello Xin, > > > > > > (Question for R

Re: [PATCH v12 3/4] drm/bridge: anx7625: add MIPI DPI input feature

2022-03-06 Thread Xin Ji
On Sun, Mar 06, 2022 at 07:13:30PM +0200, Laurent Pinchart wrote: > Hello Xin, > > (Question for Rob below, and I'm afraid this is urgent as we need to > merge a fix in v5.17). > > On Fri, Nov 05, 2021 at 11:19:03AM +0800, Xin Ji wrote: > > The basic anx7625 dr

[PATCH] drm/bridge: anx7625: Set downstream sink into normal status

2022-03-02 Thread Xin Ji
As downstream sink was set into standby mode while bridge disabled, this patch used for setting downstream sink into normal status while enable bridge. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm

Re: [PATCH v2] drm/bridge: Clear the DP_AUX_I2C_MOT bit passed in aux read command.

2022-02-17 Thread Xin Ji
bit to fix this issue. Hi Hsin-Yi, thanks for the patch! Reviewed-by: Xin Ji Thanks, Xin > > Fixes: adca62ec370c ("drm/bridge: anx7625: Support reading edid through aux > channel") > Signed-off-by: Hsin-Yi Wang > --- > v1->v2: Offline discussed with Xin Ji, it&#

[PATCH] drm/bridge: anx7625: Fix release wrong workqueue

2022-02-16 Thread Xin Ji
From: Xin Ji If "hdcp_workqueue" exist, must release "hdcp_workqueue", not "workqueue". Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support") Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++-- 1 file changed, 2 ins

Re: [PATCH 2/3] drm/bridge: anx7625: Support reading edid through aux channel

2022-01-12 Thread Xin Ji
Hi Hsin-Yi, thanks for the patch! Please fix the follow comment, then add my id. Reviewed-by: Xin Ji On Tue, Jan 11, 2022 at 07:27:00PM +0800, Hsin-Yi Wang wrote: > Support reading edid through aux channel if panel is connected to aux > bus. Extend anx7625_aux_dpcd_trans() to impleme

Re: [PATCH 3/3] dt-bindings: drm/bridge: anx7625: Add aux-bus node

2022-01-12 Thread Xin Ji
Hi Hsin-Yi, thanks for the patch! It's OK for me! Reviewed-by: Xin Ji Thanks, Xin On Tue, Jan 11, 2022 at 07:27:01PM +0800, Hsin-Yi Wang wrote: > List panel under aux-bus node if it's connected to anx7625's aux bus. > > Signed-off-by: Hsin-Yi Wang > --- > .../d

Re: [PATCH 1/3] drm/bridge: anx7625: Convert to use devm_kzalloc

2022-01-12 Thread Xin Ji
Hi Hsin-Yi, thanks for the patch! Reviewed-by: Xin Ji Thanks, Xin On Tue, Jan 11, 2022 at 07:26:59PM +0800, Hsin-Yi Wang wrote: > Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory > handled by driver detach. > > Signed-off-by: Hsin-Yi Wang > --- > driv

[PATCH v3 1/1] drm/bridge: anx7625: send DPCD command to downstream

2022-01-11 Thread Xin Ji
Send DPCD command to downstream before anx7625 power down, let downstream monitor enter into standby mode. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 42 +++ 1 file changed, 35 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge

[PATCH v2 1/1] drm/bridge: anx7625: send DPCD command to downstream

2022-01-10 Thread Xin Ji
Send DPCD command to downstream before anx7625 power down, let downstream monitor enter into standby mode. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 40 --- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge

[PATCH v3 3/3] drm/bridge: anx7625: add audio codec .get_eld support

2022-01-06 Thread Xin Ji
Provide .get_eld interface in hdmi_codec_ops for hdmi-codec driver. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm

[PATCH v3 2/3] drm/bridge: anx7625: add HDCP support

2022-01-06 Thread Xin Ji
This patch provides HDCP setting interface for userspace to dynamic enable/disable HDCP function. Reported-by: kernel test robot Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 335 +- drivers/gpu/drm/bridge/analogix/anx7625.h

[PATCH v3 1/3] drm/bridge: anx7625: Add bridge helper atomic conversion

2022-01-06 Thread Xin Ji
Add bridge helper atomic conversion. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 46 +++ drivers/gpu/drm/bridge/analogix/anx7625.h | 1 + 2 files changed, 40 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 3/3] drm/bridge: anx7625: add audio codec .get_eld support

2022-01-05 Thread Xin Ji
Provide .get_eld interface in hdmi_codec_ops for hdmi-codec driver. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm

[PATCH v2 2/3] drm/bridge: anx7625: add HDCP support

2022-01-05 Thread Xin Ji
This patch provides HDCP setting interface for userspace to dynamic enable/disable HDCP function. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 335 +- drivers/gpu/drm/bridge/analogix/anx7625.h | 79 - 2 files changed

[PATCH v2 1/3] drm/bridge: anx7625: Add bridge helper atomic conversion

2022-01-05 Thread Xin Ji
Add bridge helper atomic conversion. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 46 +++ drivers/gpu/drm/bridge/analogix/anx7625.h | 1 + 2 files changed, 40 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH 1/2] drm/bridge: anx7625: add HDCP support

2022-01-05 Thread Xin Ji
Hi Andrzej Hajda, thanks for the comment, I'll change it in next serial patches. Thanks, Xin On Wed, Jan 05, 2022 at 10:31:15AM +0100, Andrzej Hajda wrote: > Hi Xin, > > On 09.11.2021 03:42, Xin Ji wrote: > > This patch provides HDCP setting interface for userspace to dynami

Re: [PATCH 1/2] drm/bridge: anx7625: add HDCP support

2022-01-05 Thread Xin Ji
On Wed, Jan 05, 2022 at 11:32:01AM +0100, Robert Foss wrote: > On Wed, 5 Jan 2022 at 08:17, Xin Ji wrote: > > > > On Tue, Jan 04, 2022 at 03:50:34PM +0100, Robert Foss wrote: > > > Hey Xin, > > Hi Robert Foss, thanks for the reply. > > As HDCP config interfa

Re: [PATCH 1/2] drm/bridge: anx7625: add HDCP support

2022-01-04 Thread Xin Ji
n > > On Tue, 9 Nov 2021 at 03:42, Xin Ji wrote: > > > > This patch provides HDCP setting interface for userspace to dynamic > > enable/disable HDCP function. > > > > Signed-off-by: Xin Ji > > --- > > drivers/gpu/drm/bridge/analogix/anx7625.c | 36

[PATCH v2] drm/bridge: anx7625: Check GPIO description to avoid crash

2021-11-18 Thread Xin Ji
As GPIO probe function "devm_gpiod_get_optional()" may return error code, driver should identify GPIO desc as NULL to avoid crash. Acked-by: Tzung-Bi Shih Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH v2] drm/bridge: anx7625: Fix edid_read break case in sp_tx_edid_read()

2021-11-18 Thread Xin Ji
ead bytes. Otherwise -EIO on failure cases. Update the g_edid_break > break condition accordingly. Hi Hsin-Yi, thanks for the patch! Reviewed-by: Xin Ji > > Fixes: 7f16d0f3b8e2("drm/bridge: anx7625: Propagate errors from > sp_tx_rst_aux()") > Signed-off-by: Hsin-Yi Wang

[PATCH v3] drm/bridge: anx7625: Check GPIO description to avoid crash

2021-11-17 Thread Xin Ji
As GPIO probe function "devm_gpiod_get_optional()" may return error code, driver should identify GPIO desc as NULL to avoid crash. Acked-by: Tzung-Bi Shih Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v2] drm/bridge: anx7625: Check GPIO description to avoid crash

2021-11-17 Thread Xin Ji
As GPIO probe function "devm_gpiod_get_optional()" may return error code, driver should identify GPIO desc as NULL to avoid crash. Acked-by: Tzung-Bi Shih Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH] drm/bridge: anx7625: Check GPIO description to avoid crash

2021-11-17 Thread Xin Ji
On Thu, Nov 18, 2021 at 12:52:14PM +0800, Tzung-Bi Shih wrote: > On Thu, Nov 18, 2021 at 11:11 AM Xin Ji wrote: > > @@ -1098,9 +1098,18 @@ static void anx7625_init_gpio(struct anx7625_data > > *platform) > > /* Gpio for chip power enable */ > >

[PATCH] drm/bridge: anx7625: Check GPIO description to avoid crash

2021-11-17 Thread Xin Ji
As GPIO probe function "devm_gpiod_get_optional()" may return error code, driver should identify GPIO desc as NULL to avoid crash. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/bridg

Re: [bug report] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2021-11-17 Thread Xin Ji
On Wed, Nov 17, 2021 at 04:47:20PM +0300, Dan Carpenter wrote: > Hello Xin Ji, > > The patch 8bdfc5dae4e3: "drm/bridge: anx7625: Add anx7625 MIPI > DSI/DPI to DP" from Sep 18, 2020, leads to the following Smatch > static checker warning: > > drivers/gpu/drm

[PATCH 2/2] drm/bridge: anx7625: add audio codec .get_eld support

2021-11-08 Thread Xin Ji
Provide .get_eld interface in hdmi_codec_ops for hdmi-codec driver. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c

[PATCH 1/2] drm/bridge: anx7625: add HDCP support

2021-11-08 Thread Xin Ji
This patch provides HDCP setting interface for userspace to dynamic enable/disable HDCP function. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 368 +- drivers/gpu/drm/bridge/analogix/anx7625.h | 69 +++- 2 files changed, 425 insertions(+), 12

[PATCH v12 4/4] drm/bridge: anx7625: add HDMI audio function

2021-11-04 Thread Xin Ji
Add audio HDMI codec function support, enable it through device true flag "analogix,audio-enable". Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 226 ++ drivers/gpu/drm/bridge/analogix/anx7625.h | 5 + 2 files ch

[PATCH v12 3/4] drm/bridge: anx7625: add MIPI DPI input feature

2021-11-04 Thread Xin Ji
The basic anx7625 driver only support MIPI DSI rx signal input. This patch add MIPI DPI rx input configuration support, after apply this patch, the driver can support DSI rx or DPI rx by adding 'bus-type' in DT. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridg

[PATCH v12 2/4] drm/bridge: anx7625: fix not correct return value

2021-11-04 Thread Xin Ji
At some time, the original code may return non zero value, force return 0 if operation finished. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix

[PATCH v12 1/4] dt-bindings:drm/bridge:anx7625:add vendor define

2021-11-04 Thread Xin Ji
ing type include Pre-emphasis, Vp-p, Rterm(Resistor Termination) and Rsel(Driven Strength). Each lane has maximum 20 registers for these settings. Signed-off-by: Xin Ji Reviewed-by: Rob Herring --- .../display/bridge/analogix,anx7625.yaml | 65 ++- 1 file changed, 63 insert

Re: [PATCH v12 0/4] Add MIPI rx DPI support

2021-11-04 Thread Xin Ji
On Thu, Nov 04, 2021 at 11:20:21AM +0100, Robert Foss wrote: > Hey Xin, > > Applied to drm-misc-next. > > The way this series was submitted to the mailing list is not correct > and is breaking a lot of tooling. It seems like you used git > send-email, but the individual patches of the series are

  1   2   3   4   >