Re: [PATCH 04/39] drm: renesas: shmobile: Fix ARGB32 overlay format typo

2023-06-22 Thread Sergei Shtylyov
Hello! On 6/22/23 12:21 PM, Geert Uytterhoeven wrote: > When configurating Configuring? My spellchecker trips. :-) > a CHn Source Image Format Register (LDBBSIFR), one > should use the corresponding LDBBSIFR_RPKF_* definition for overlay > planes, not the DDFR_PKF_* definition for the primar

Re: [PATCH 1/2] gpu: Move ASPEED vendor ID definition to pci_ids.h

2023-04-18 Thread Sergei Shtylyov
On 4/18/23 4:17 AM, Patrick McLean wrote: > Currently the ASPEED PCI vendor ID is defined in > drivers/gpu/drm/ast/ast_drv.c, > move that to include/linux/pci_ids.h with all the rest of the PCI vendor ID > definitions. Rename the definition to follow the format that the other > definitions follow

Re: [PATCH 2/2] ata: libata-core: Apply ATI NCQ horkage to ASPEED as well

2023-04-18 Thread Sergei Shtylyov
Hello! On 4/18/23 4:17 AM, Patrick McLean wrote: > We have some machines with ASPEED SATA controllers, and are seeing the same > NCQ > issues that ATI controllers (I am not sure if it's a rebranded ATI controller, > or they both have some faulty implementation). This NCQ breakage is consistent >

Re: [PATCH 01/41] video: fbdev: omapfb: lcd_ams_delta: fix unused variable warning

2022-04-20 Thread Sergei Shtylyov
Hello! On 4/19/22 4:36 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > A recent cleanup patch removed the only reference to a local variable > in some configurations. > > Move the variable into the one block it is still used in, inside > of an #ifdef, to avoid this warning. > > Fixes: 9d77

Re: [PATCH v4 16/24] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2022-03-04 Thread Sergei Shtylyov
On 3/4/22 10:06 AM, Byungchul Park wrote: > cb92173d1f0 (locking/lockdep, cpu/hotplug: Annotate AP thread) was You need to enclose the commit summary in (""), not just (). :-) > introduced to make lockdep_assert_cpus_held() work in AP thread. > > However, the annotation is too strong for tha

Re: [PATCH v10 1/4] MIPS: Loongson64: dts: update the display controller device node

2022-02-21 Thread Sergei Shtylyov
On 2/20/22 5:55 PM, Sui Jingfeng wrote: > From: suijingfeng > > The display controller is a pci device, its PCI vendor id is 0x0014 > its PCI device id is 0x7a06. > > 1) In order to let the driver to know which chip the DC is contained >in, the compatible string of the display controller is

Re: [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning

2021-07-31 Thread Sergei Shtylyov
Hello On 31.07.2021 4:39, Laurent Pinchart wrote: On 64-bit platforms, the compiler complains that casting a void pointer to an unsigned int loses data. Cast the pointer to a uintptr_t unsigned Is "unsigned" really needed here? to fix this. Signed-off-by: Laurent Pinchart --- drivers

Re: [PATCH] drm/shmobile: Convert to Linux IRQ interfaces

2021-07-13 Thread Sergei Shtylyov
On 7/6/21 10:49 AM, Thomas Zimmermann wrote: > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > don't benefit from using it. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/shmobile/shmob_drm_drv

Re: [PATCH 5/9] arm64: dts: renesas: r8a77961: Add VSP device nodes

2020-09-07 Thread Sergei Shtylyov
On 07.09.2020 5:59, Kuninori Morimoto wrote: From: Kuninori Morimoto This patch adds VSP device nodes for R-Car M3-W+ (r8a77961) SoC. This patch is test on R-Car M3-W+ Salvator-XS board. Was tested? Signed-off-by: Kuninori Morimoto [...] MBR, Sergei _

Re: [PATCH 8/9] arm64: dts: renesas: r8a77961-salvator-xs: add HDMI Display support

2020-09-07 Thread Sergei Shtylyov
Hello! On 07.09.2020 5:59, Kuninori Morimoto wrote: From: Kuninori Morimoto This patch enables HDMI Display on R-Car M3-W+ Salvator-XS board. This patch is test on R-Car M3-W+ Salvator-XS board. Was tested, perhaps? Signed-off-by: Kuninori Morimoto [...] MBR, Sergei ___

Re: [PATCH 4/9] arm64: dts: renesas: r8a77961: Add FCP device nodes

2020-09-07 Thread Sergei Shtylyov
On 07.09.2020 5:58, Kuninori Morimoto wrote: From: Kuninori Morimoto This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. This patch is test on R-Car M3-W+ Salvator-XS board. Was tested? Signed-off-by: Kuninori Morimoto [...] MBR, Sergei __

Re: [PATCH 5/9] arm64: dts: renesas: r8a77961: Add VSP device nodes

2020-09-07 Thread Sergei Shtylyov
On 07.09.2020 11:08, Sergei Shtylyov wrote: From: Kuninori Morimoto This patch adds VSP device nodes for R-Car M3-W+ (r8a77961) SoC. This patch is test on R-Car M3-W+ Salvator-XS board.    Was tested? The same comment to the patches 6 & 7. Signed-off-by: Kuninori Mori

Re: [PATCH 5/7] ARM: dts: r8a7742: Add DU support

2020-08-10 Thread Sergei Shtylyov
Hello! On 8/7/20 8:49 PM, Lad Prabhakar wrote: > Add du node to r8a7742 SoC DT. Boards that want to enable the DU Both "du" and "DU" on a single line? :-) > need to specify the output topology. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > [...] MBR, Sergei __

Re: [PATCH] newport_con: vc_color is now in state

2020-07-26 Thread Sergei Shtylyov
On 24.07.2020 9:27, Jiri Slaby wrote: Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should enclose the commit summary in (""), not just ()... vc->state.color. Somehow both me and 0-day bot misse

Re: [PATCH 2/8] dt-bindings: intc: Convert ingenic,intc.txt to YAML

2020-04-27 Thread Sergei Shtylyov
Hello! On 26.04.2020 21:58, Paul Cercueil wrote: Convert the ingenic,intc.txt doc file to ingenic,intc.yaml. Some compatible strings now require a fallback, as the controller generally works the same across the SoCs families. Signed-off-by: Paul Cercueil [...] diff --git a/Documentation/d

Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node

2020-04-15 Thread Sergei Shtylyov
Hello! On 15.04.2020 11:35, H. Nikolaus Schaller wrote: From: Jonathan Bakker to add support for SGX540 GPU. Signed-off-by: Jonathan Bakker Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/s5pv210.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/ar

Re: [PATCH 0/2] drm: bridge: simple-bridge: Enable usage with DRM bridge connector helper

2020-04-09 Thread Sergei Shtylyov
Hello! On 09.04.2020 3:36, Laurent Pinchart wrote: This small patch series enables usage of the simple-bridge driver with the DRM bridge connector helper (drm_bridge_connector.c). Patch 1/2 starts by simplifying the driver by delegating DDC handling to the next bridge in the chain, and patch 2/

Re: [PATCH] drm: rcar-du: Add r8a77980 support

2019-09-12 Thread Sergei Shtylyov
Hello! On 11.09.2019 22:25, Kieran Bingham wrote: Add direct support for the r8a77980 (V3H). The V3H shares a common, compatible configuration with the r8a77970 (V3M) so that device info structure is reused. Do we really need to add yet another compatible in this case? I just added r8a779

Re: [PATCH 01/20] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation

2019-06-06 Thread Sergei Shtylyov
On 06/06/2019 05:22 PM, Jacopo Mondi wrote: > Add device tree bindings documentation for the Renesas R-Car Display > Unit Color Management Module. > > CMM is the image enhancement module available on each R-Car DU video > channel on Gen2 and Gen3 SoCs (V3H and V3M excluded). > > Signed-off-by: J

Re: [PATCH v5 2/6] net: stmmac: sun8i: force select external PHY when no internal one

2019-05-21 Thread Sergei Shtylyov
Hello! On 21.05.2019 2:50, meg...@megous.com wrote: From: Icenowy Zheng The PHY selection bit also exists on SoCs without an internal PHY; if it's set to 1 (internal PHY, default value) then the MAC will not make use of any PHY such SoCs. ^ "on" or "with" missing? This problem app

Re: [PATCH] drm: rcar-du: writeback: include interface header

2019-05-18 Thread Sergei Shtylyov
Hello! On 18.05.2019 0:20, Kieran Bingham wrote: The new writeback feature is exports functions so that they can ^^ not needed? integrate into the rcar_du_kms module. The interface functions are defined in the rcar_du_writeback header, but it is not included in t

Re: [PATCH 06/12] net: stmmac: sun8i: force select external PHY when no internal one

2019-04-06 Thread Sergei Shtylyov
Hello! On 06.04.2019 2:45, meg...@megous.com wrote: From: Icenowy Zheng The PHY selection bit also exists on SoCs without an internal PHY; if it's set to 1 (internal PHY) then the MAC will not make use of any PHY. This problem appears when adapting for H6, which has no real internal PHY (the

Re: [PATCH 2/6] drm: rcar-du: lvds: Don't fail probe if output is not connected on D3/E3

2019-01-17 Thread Sergei Shtylyov
Hello! On 17.01.2019 4:49, Laurent Pinchart wrote: On the D3 and E3 SoCs the LVDS encoder has an extended internal PLL and supplies a clock to the DU. That clock is used not only for the LVDS outputs but also for the DPAD output. The LVDS encoder thus needs to be available to the DU even when i

Re: [PATCH v3 4/7] ata: ahci_sunxi: use xxxsetbitsi_le32 functions

2018-10-24 Thread Sergei Shtylyov
Hello! Typo in the subject: s/xxxsetbitsi/xxxsetbits/. On 24.10.2018 10:35, Corentin Labbe wrote: This patch converts ahci_sunxi to use xxxsetbits_le32 functions Signed-off-by: Corentin Labbe [...] MBR, Sergei ___ dri-devel mailing list dri-d

Re: [PATCH 0/2] Add R-Car V3H (R8A77980) support to the R-Car LVDS driver

2018-08-23 Thread Sergei Shtylyov
On 06/05/2018 11:25 PM, Sergei Shtylyov wrote: > Here's the set of 2 patches against the 'drm-next' branch of the 'drm.git' > repo. > The purpose of these patches is to add the R-Car V3H (R8A77980) support to the > R-Car LVDS driver. > > [1/2] dt

Re: [PATCH 2/3] drm: rcar-du: Rename var to a more precise name

2018-07-31 Thread Sergei Shtylyov
Hello! On 7/30/2018 8:20 PM, Jacopo Mondi wrote: Rename the 'value' variable, only used to for writing to DMSR register to a ^^ not needed more precise 'dmsr' name. Signed-off-by: Laurent Pinchart Signed-off-by: Jacopo Mondi [...] MBR, Sergei ___

Re: [RFT] i2c: algos: bit: prepare/unprepare before sending initial STOP

2018-06-15 Thread Sergei Shtylyov
On 6/15/2018 8:17 AM, Wolfram Sang wrote: Some adapters need to be prepared/unprepared before bitbanging the bus. Before/after? Do this for the initial STOP, too. Signed-off-by: Wolfram Sang [...] MBR, Sergei ___ dri-devel mailing list dri-d

[PATCH 2/2] drm: rcar-du: lvds: add R8A77980 support

2018-06-05 Thread Sergei Shtylyov
Add support for the R-Car V3H (R8A77980) SoC to the LVDS encoder driver. Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_lvds.c |1 + 1 file changed, 1 insertion(+) Index: drm/drivers/gpu/drm/rcar-du/rcar_lvds.c

[PATCH 1/2] dt-bindings: display: renesas: lvds: document R8A77980 bindings

2018-06-05 Thread Sergei Shtylyov
Document the R-Car V3H (R8A77980) SoC in the R-Car LVDS bindings. Signed-off-by: Sergei Shtylyov --- Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt |1 + 1 file changed, 1 insertion(+) Index: drm/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt

[PATCH 0/2] Add R-Car V3H (R8A77980) support to the R-Car LVDS driver

2018-06-05 Thread Sergei Shtylyov
Hello! Here's the set of 2 patches against the 'drm-next' branch of the 'drm.git' repo. The purpose of these patches is to add the R-Car V3H (R8A77980) support to the R-Car LVDS driver. [1/2] dt-bindings: display: renesas: lvds: document R8A77980 bindings [2/2] drm: rcar-du: lvds: add R8A77980 su

Re: [PATCH] dt-bindings: display: renesas: du: document R8A77980 bindings

2018-06-05 Thread Sergei Shtylyov
the R-Car V3M >>> (R8A77970)" ? "seems" sounds like we're very unsure :-) >> >>That's probably better, indeed. >> >>>> Signed-off-by: Sergei Shtylyov >>>> >>>> --- >>>> The patch is against the &#x

Re: [PATCH] dt-bindings: display: renesas: du: document R8A77980 bindings

2018-06-05 Thread Sergei Shtylyov
ot; ? "seems" sounds like we're very unsure :-) That's probably better, indeed. >> Signed-off-by: Sergei Shtylyov >> >> --- >> The patch is against the 'drm-next' branch of David Airlie's 'linux.git' >> repo.

[PATCH] dt-bindings: display: renesas: du: document R8A77980 bindings

2018-06-04 Thread Sergei Shtylyov
Document the R-Car V3H (R8A77980) SoC in the R-Car DU bindings; the DU hardware seems the same as in the R-Car V3M (R8A77970). Signed-off-by: Sergei Shtylyov --- The patch is against the 'drm-next' branch of David Airlie's 'linux.git' repo. Documentation/devicetree

Re: [PATCH 2/5] drm: rcar-du: lvds: Add R8A77995 support

2018-05-16 Thread Sergei Shtylyov
On 05/16/2018 04:06 PM, Ulrich Hecht wrote: Add support for the R-Car D3 (R8A77995) SoC to the LVDS encoder driver. Signed-off-by: Ulrich Hecht --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/d

Re: [PATCH 2/5] drm: rcar-du: lvds: Add R8A77995 support

2018-05-16 Thread Sergei Shtylyov
Hello! On 5/16/2018 10:54 AM, Simon Horman wrote: Add support for the R-Car D3 (R8A77995) SoC to the LVDS encoder driver. Signed-off-by: Ulrich Hecht --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/dri

Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-27 Thread Sergei Shtylyov
Hello! On 3/27/2018 10:33 AM, jacopo mondi wrote: [...] Document Thine THC63LVD1024 LVDS decoder device tree bindings. Signed-off-by: Jacopo Mondi Reviewed-by: Andrzej Hajda Reviewed-by: Niklas Söderlund --- .../bindings/display/bridge/thine,thc63lvd1024.txt | 66 +++ 1 fi

Re: [PATCH v3 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-14 Thread Sergei Shtylyov
On 03/14/2018 09:04 PM, jacopo mondi wrote: >>> Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel >>> output decoder. >>> >>> Signed-off-by: Jacopo Mondi >> [...] >>> diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c >>> b/drivers/gpu/drm/bridge/thc63lvd1024.c >>> new file m

Re: [PATCH v3 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-14 Thread Sergei Shtylyov
On 03/13/2018 05:30 PM, Jacopo Mondi wrote: > Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel > output decoder. > > Signed-off-by: Jacopo Mondi [...] > diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c > b/drivers/gpu/drm/bridge/thc63lvd1024.c > new file mode 100644 > ind

Re: [PATCH v2 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-09 Thread Sergei Shtylyov
On 03/09/2018 04:51 PM, Jacopo Mondi wrote: > The R-Car V3M Eagle board includes a transparent LVDS decoder, connected > to the on-chip LVDS encoder output on one side and to HDMI encoder > ADV7511w on the other one. > > As the decoder does not need any configuration it has been so-far > omitted

Re: [PATCH 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-09 Thread Sergei Shtylyov
Hello! On 3/8/2018 6:24 PM, Jacopo Mondi wrote: The R-Car V3M Eagle board includes a transparent LVDS decoder, connected to the on-chip LVDS encoder output on one side and to HDMI encoder ADV7511w on the other one. As the decoder does not need any configuration it has been so-far omitted from

[PATCH v2 2/2] drm: rcar-du: lvds: add R8A77970 support

2018-03-01 Thread Sergei Shtylyov
Add support for the R-Car V3M (R8A77970) SoC to the LVDS encoder driver. Note that there are some differences with the other R-Car gen3 SoCs, e.g. LVDPLLCR has the same layout as in the R-Car gen2 SoCs... Signed-off-by: Sergei Shtylyov --- Changes in version 2: - shortened the comment to

[PATCH v2 1/2] DT: display: renesas,lvds: document R8A77970 bindings

2018-03-01 Thread Sergei Shtylyov
Document the R-Car V3M (R8A77970) SoC in the R-Car LVDS bindings. Signed-off-by: Sergei Shtylyov Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart --- Changes in version 2: - added Rob's and Laurent's tags. Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt |

[PATCH v2 0/3] Add R-Car V3M (R8A77970) support to the R-Car LVDS driver

2018-03-01 Thread Sergei Shtylyov
Hello! Here's the set of 2 patches against the 'drm-next' branch of David Airlie's 'linux.git' repo plus Laurent Picnahrt's patches creating the R-Car LVDS bridge driver posted recently. The purpose of these patches is to add the R-Car V3M (R8A77970) support to the R-Car LVDS driver. [1/2] DT: di

Re: [PATCH 02/15] v4l: vsp1: Remove outdated comment

2018-02-27 Thread Sergei Shtylyov
Hello! On 2/27/2018 12:45 AM, Laurent Pinchart wrote: The entities in the pipeline are all started when the LIF is setup. Remove the outdated comment that state otherwise. States? Signed-off-by: Laurent Pinchart [...] MBR, Sergei ___ dri-dev

Re: [PATCH v4 11/16] ARM: dts: r8a7791: Convert to new LVDS DT bindings

2018-02-23 Thread Sergei Shtylyov
On 2/21/2018 2:10 AM, Laurent Pinchart wrote: The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart [...] diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi index 008a260f86a5

Re: [PATCH v4 11/16] ARM: dts: r8a7791: Convert to new LVDS DT bindings

2018-02-23 Thread Sergei Shtylyov
Hello! On 2/21/2018 2:10 AM, Laurent Pinchart wrote: The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart --- Changes since v3: - Added power-domains and resets properties to LVDS nodes Changes since

Re: [PATCH v4 01/16] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings

2018-02-21 Thread Sergei Shtylyov
On 2/21/2018 2:10 AM, Laurent Pinchart wrote: The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add corresponding device tree bindings. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v1: - Move the SoC name before the IP name in compatible strings

Re: [PATCH v4 14/16] ARM: dts: r8a7794: Convert to new DU DT bindings

2018-02-21 Thread Sergei Shtylyov
Hello! On 2/21/2018 2:10 AM, Laurent Pinchart wrote: The DU DT bindings have been updated to drop the reg-names property. Update the r8a7792 device tree accordingly. Apparently r8a7794. Signed-off-by: Laurent Pinchart [...] MBR, Sergei ___ d

Re: [PATCH v2 3/3] drm: rcar-du: lvds: Refactor LVDS startup

2018-02-14 Thread Sergei Shtylyov
On 02/14/2018 09:13 PM, Laurent Pinchart wrote: > From: Sergei Shtylyov > > After the recent corrections to the R-Car gen2/3 LVDS startup code, already > similar enough at their ends rcar_lvds_enable_gen{2|3}() started asking for > a merge and it's becoming actually necessa

Re: [PATCH] drm: rcar-du: lvds: Fix LVDS clock frequency range

2018-02-14 Thread Sergei Shtylyov
rt them yet anyway... > SoCs. Update the driver accordingly. > > Signed-off-by: Laurent Pinchart [...] Acked-by: Sergei Shtylyov MBR, Sergei ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 1/2] DT: display: renesas,du: document R8A77970 bindings

2018-01-29 Thread Sergei Shtylyov
On 01/29/2018 10:02 PM, Rob Herring wrote: >> Document the R-Car V3M (R8A77970) SoC in the R-Car DU bindings. >> >> Signed-off-by: Sergei Shtylyov >> >> --- >> Changes in version 2: >> - documented R8A77970 DU ports; >> - patch split from the main

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-21 Thread Sergei Shtylyov
Hello! On 1/13/2018 2:14 AM, Laurent Pinchart wrote: Here's my (superficial) comments... The internal LVDS encoders now have their own DT bindings. Before switching the driver infrastructure to those new bindings, implement backward-compatibility through live DT patching. Patching is disab

[PATCH 3/3] drm: rcar-du: lvds: add R8A77970 support

2018-01-19 Thread Sergei Shtylyov
Add support for the R-Car V3M (R8A77970) SoC to the LVDS encoder driver. Note that there are some differences with the other R-Car gen3 SoCs, e.g. LVDPLLCR has the same layout as in the R-Car gen2 SoCs... Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 21

[PATCH 2/3] DT: display: renesas,lvds: document R8A77970 bindings

2018-01-19 Thread Sergei Shtylyov
Document the R-Car V3M (R8A77970) SoC in the R-Car LVDS bindings. Signed-off-by: Sergei Shtylyov --- Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt |1 + 1 file changed, 1 insertion(+) Index: linux/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt

[PATCH 0/3] Add R-Car V3M (R8A77970) support to the R-Car LVDS driver

2018-01-19 Thread Sergei Shtylyov
Hello! Here's the set of 3 patches against the 'drm-next' branch of David Airlie's 'linux.git' repo plus the patch fixing LVDS startup for R-Car gen2/3 and Laurent Picnahrt's patches creating the R-Car LVDS bridge driver posted recently. The main purpose of these patches is to add the R-Car V3M (R

[PATCH 1/3] drm: rcar-du: lvds: refactor LVDS startup

2018-01-19 Thread Sergei Shtylyov
ayout. BTW, such a merge saves 64 bytes of the object code with AArch64 gcc 4.8.5. Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 137 +++- 1 file changed, 59 insertions(+), 78 deletions(-) Index: linux/drivers/gpu/drm/rcar-du/rcar_l

[PATCH v2 0/2] Add R-Car V3M (R8A77970) support to the DU driver

2018-01-18 Thread Sergei Shtylyov
Hello! Here's the set of 2 patches against the 'drm-next' branch of David Airlie's 'linux.git' repo. The purpose of these patches is to add the R-Car V3M (R8A77970) support to the DU driver; the LVDS driver patches will be posted separately... [1/2] DT: display: renesas,du: document R8A77970 bind

[PATCH v2 1/2] DT: display: renesas,du: document R8A77970 bindings

2018-01-18 Thread Sergei Shtylyov
Document the R-Car V3M (R8A77970) SoC in the R-Car DU bindings. Signed-off-by: Sergei Shtylyov --- Changes in version 2: - documented R8A77970 DU ports; - patch split from the main R8A77970 DU support patch. Documentation/devicetree/bindings/display/renesas,du.txt |2 ++ 1 file changed

[PATCH v2 2/2] drm: rcar-du: add R8A77970 support

2018-01-18 Thread Sergei Shtylyov
Add support for the R-Car V3M (R8A77970) SoC to the R-Car DU driver. Signed-off-by: Sergei Shtylyov --- Changes in version 2: - removed the 'model' and 'dpll_ch' field initializers; - fixed up the DU port numbers; - split the DU bindings and the LVDS driver updates int

Re: [PATCH v2 2/2] drm: rcar-du: lvds: Fix LVDS startup on R-Car gen2

2018-01-16 Thread Sergei Shtylyov
On 01/16/2018 06:46 PM, Laurent Pinchart wrote: From: Sergei Shtylyov According to the latest revision 2.00 of the R-Car gen2 manual, the LVDS must be enabled and the bias crcuit enabled after the LVDS I/O pins are Oops, this needs fixing (note the typo!). Could you please change this

Re: [PATCH v2 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-01-15 Thread Sergei Shtylyov
On 01/15/2018 11:32 PM, Laurent Pinchart wrote: The LVDS encoders used to be described in DT as part of the DU. They now have their own DT node, linked to the DU using the OF graph bindings. This allows moving internal LVDS encoder support to a separate driver modelled as a DRM bridge. Backward

Re: [PATCH v2 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-01-15 Thread Sergei Shtylyov
Hello! On 01/13/2018 02:14 AM, Laurent Pinchart wrote: The LVDS encoders used to be described in DT as part of the DU. They now have their own DT node, linked to the DU using the OF graph bindings. This allows moving internal LVDS encoder support to a separate driver modelled as a DRM bridge. B

Re: [PATCH v2 06/12] ARM: dts: r8a7790: Convert to new LVDS DT bindings

2018-01-15 Thread Sergei Shtylyov
Hello! On 01/13/2018 02:14 AM, Laurent Pinchart wrote: The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart [...] diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 62b

Re: [PATCH v2 07/12] ARM: dts: r8a7791: Convert to new LVDS DT bindings

2018-01-15 Thread Sergei Shtylyov
Hello! On 01/13/2018 02:14 AM, Laurent Pinchart wrote: The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart [...] diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi index 678

Re: [PATCH v2 2/2] drm: rcar-du: lvds: Fix LVDS startup on R-Car gen2

2018-01-13 Thread Sergei Shtylyov
On 1/13/2018 2:10 AM, Laurent Pinchart wrote: From: Sergei Shtylyov According to the latest revision 2.00 of the R-Car gen2 manual, the LVDS must be enabled and the bias crcuit enabled after the LVDS I/O pins are enabled, not before. Fix the gen2 LVDS startup sequence accordingly. While at

Re: [PATCH 1/2] drm: rcar-du: lvds: fix LVDS startup on R-Car gen3

2018-01-13 Thread Sergei Shtylyov
s: e947eccbeba4 ("drm: rcar-du: Add support for LVDS mode selection") Signed-off-by: Sergei Shtylyov Is this really needed ? Does it fix a problem you've experienced, or is it theoretical only ? The mode shouldn't matter before the LVDS internal logic is turned on. Unless t

Re: [PATCH 1/2] drm: rcar-du: lvds: fix LVDS startup on R-Car gen3

2018-01-13 Thread Sergei Shtylyov
Hello! On 1/13/2018 12:51 AM, Laurent Pinchart wrote: On Friday, 12 January 2018 22:12:04 EET Sergei Shtylyov wrote: According to the latest revisions of the R-Car gen3 manual, the LVDS mode must be set before the LVDS I/O pins are enabled, not after -- fix the gen3 LVDS startup sequence

Re: [PATCH 1/2] drm: rcar-du: lvds: fix LVDS startup on R-Car gen3

2018-01-12 Thread Sergei Shtylyov
On 01/12/2018 11:12 PM, Sergei Shtylyov wrote: According to the latest revisions of the R-Car gen3 manual, the LVDS mode must be set before the LVDS I/O pins are enabled, not after -- fix the gen3 LVDS startup sequence accordingly... While at it, also fix the comment preceding the first

[PATCH 2/2] drm: rcar-du: lvds: fix LVDS startup on R-Car gen2

2018-01-12 Thread Sergei Shtylyov
t;) Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) Index: linux/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c === --- linux.orig/drivers/gp

[PATCH 1/2] drm: rcar-du: lvds: fix LVDS startup on R-Car gen3

2018-01-12 Thread Sergei Shtylyov
still talks about hardcoding the LVDS mode 0... Fixes: e947eccbeba4 ("drm: rcar-du: Add support for LVDS mode selection") Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Index: linux/drive

[PATCH 0/2] Fix LVDS startup sequences in the R-Car DU driver...

2018-01-12 Thread Sergei Shtylyov
Hello! Here's the set of 2 patches against the 'drmf-ixes' branch of David Airlie's 'linux.git' repo plus the patch fixing LVDCR1 for R-Car gen3 posted recently. Documentation check against the recent manuals revealed that the LVDS startup sequences don't match those. I was able to test the gen3 p

Re: [PATCH 02/10] dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings

2018-01-12 Thread Sergei Shtylyov
Hello! On 01/12/2018 03:58 AM, Laurent Pinchart wrote: The internal LVDS encoders now have their own DT bindings, representing them as part of the DU is deprecated. Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/display/renesas,du.txt | 26 +- 1 file ch

Re: [PATCH 01/10] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings

2018-01-12 Thread Sergei Shtylyov
Hello! On 01/12/2018 03:58 AM, Laurent Pinchart wrote: The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add corresponding device tree bindings. Signed-off-by: Laurent Pinchart --- .../bindings/display/bridge/renesas,lvds.txt | 54 ++ MAINTAINERS

Re: [PATCH 02/10] dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings

2018-01-12 Thread Sergei Shtylyov
On 01/12/2018 01:43 PM, Laurent Pinchart wrote: The internal LVDS encoders now have their own DT bindings, representing them as part of the DU is deprecated. Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/display/renesas,du.txt | 26 +- 1 file changed,

Re: [PATCH 3/3] drm: rcar-du: add R8A77970 support

2018-01-12 Thread Sergei Shtylyov
gen2 SoCs... Signed-off-by: Sergei Shtylyov Could you please rebase this series on top of the LVDS rework posted as "[PATCH 00/10] R-Car DU: Convert LVDS code to bridge driver" (https:// www.spinics.net/lists/dri-devel/msg161931.html) ? It should make it easier to implement suppo

Re: [PATCH 3/3] drm: rcar-du: add R8A77970 support

2018-01-12 Thread Sergei Shtylyov
gen2 SoCs... Signed-off-by: Sergei Shtylyov Could you please rebase this series on top of the LVDS rework posted as "[PATCH 00/10] R-Car DU: Convert LVDS code to bridge driver" (https:// www.spinics.net/lists/dri-devel/msg161931.html) ? It should make it easier to implement suppo

Re: [PATCH 1/3] drm: rcar-du: lvds: refactor LVDS startup

2018-01-12 Thread Sergei Shtylyov
77970) support -- this gen3 SoC has gen2-like LVDPLLCR layout. BTW, such a merge saves 72 bytes of the object code with AArch64 gcc 4.8.5. Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 132 +++--- 1 file changed, 54 insertions(+), 78 dele

[PATCH 3/3] drm: rcar-du: add R8A77970 support

2018-01-11 Thread Sergei Shtylyov
Add support for the R-Car V3M (R8A77970) SoC to the DU driver (this SoC has only 1 display port). Note that there are some differences with the other R-Car gen3 SoCs in the LVDS encoder part, e.g. LVDPLLCR has the same layout as on the R-Car gen2 SoCs... Signed-off-by: Sergei Shtylyov

[PATCH 2/3] drm: rcar-du: add model field to struct rcar_du_device_info

2018-01-11 Thread Sergei Shtylyov
e it accordingly for the already supported SoCs. Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_du_drv.c |9 + drivers/gpu/drm/rcar-du/rcar_du_drv.h | 14 ++ 2 files changed, 23 insertions(+) Index: linux/drivers/gpu/

[PATCH 0/3] Add R-Car V3M (R8A77970) support to the DU driver

2018-01-11 Thread Sergei Shtylyov
Hello! Here's the set of 3 patches against the 'drm-next' branch of David Airlie's 'linux.git' repo plus the patch fixing LVDCR1 for R-Car gen3 posted recently. The main purpose of these patches is to add the R-Car V3M (R8A77970) support to the DU driver, we have to do some refactoring first to ac

[PATCH 1/3] drm: rcar-du: lvds: refactor LVDS startup

2018-01-11 Thread Sergei Shtylyov
ayout. BTW, such a merge saves 72 bytes of the object code with AArch64 gcc 4.8.5. Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 132 -- 1 file changed, 54 insertions(+), 78 deletions(-) Index: linux/drivers/gpu/drm/rcar-du/rcar_du_lvds

Re: [PATCH] drm: rcar-du: lvds: fix LVDCR1 for R-Car gen3

2017-12-23 Thread Sergei Shtylyov
Hello! On 12/23/2017 04:09 PM, Laurent Pinchart wrote: On Thursday, 21 December 2017 22:23:30 EET Sergei Shtylyov wrote: The LVDCR1 register for the R-Car gen3 SoCs was documented as having the layout different from the gen2 SoCs in the early R-Car gen3 manuals but since v0.52 the LVDCR1

[PATCH] drm: rcar-du: lvds: fix LVDCR1 for R-Car gen3

2017-12-21 Thread Sergei Shtylyov
seems to be no valid output signal when they are used). Fixes: 6bc2e15cf21c ("drm: rcar-du: lvds: Add R-Car Gen3 support") Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 10 -- drivers/gpu/drm/rcar-du/rcar_lvds_regs.h |6 ++ 2 files

Re: [PATCH 5/9] v4l: vsp1: Document the vsp1_du_atomic_config structure

2017-12-04 Thread Sergei Shtylyov
Hello! On 12/3/2017 1:57 PM, Laurent Pinchart wrote: The structure is used in the API that the VSP1 driver exposes to the DU driver. Documenting it is thus important. Signed-off-by: Laurent Pinchart --- include/media/vsp1.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/in

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

2017-09-19 Thread Sergei Shtylyov
Hello! On 9/19/2017 10:33 AM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentati

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

2017-09-19 Thread Sergei Shtylyov
On 9/19/2017 12:29 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/dev

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

2017-09-19 Thread Sergei Shtylyov
On 09/19/2017 01:59 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentat

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

2017-09-19 Thread Sergei Shtylyov
On 9/19/2017 1:35 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

2017-09-19 Thread Sergei Shtylyov
On 9/19/2017 1:07 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/de

Re: [PATCH v4 6/8] Documentation: Add device tree binding for Goldfish FB driver

2017-08-21 Thread Sergei Shtylyov
On 08/18/2017 04:08 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Add documentation for DT binding of Goldfish FB driver. The compatible string used by OS for binding the driver is "google,goldfish-fb". Signed-off-by: Miodrag Dinic Signed-off-by: Goran Ferenc Signed-off-by: Aleks

Re: [PATCH 1/2] v4l: vsp1: Add support for colorkey alpha blending

2017-05-04 Thread Sergei Shtylyov
On 05/04/2017 01:53 PM, agheorghe wrote: The vsp2 hw supports changing of the alpha of pixels that match a color key, this patch adds support for this feature in order to be used by the rcar-du driver. The colorkey is interpreted different depending of the pixel format: * RGB - all col

Re: [PATCH v3 3/3] drm: rcar-du: Register a completion callback with VSP1

2017-03-05 Thread Sergei Shtylyov
Hello! On 03/05/2017 07:00 PM, Kieran Bingham wrote: Currently we process page flip events on every display interrupt, however this does not take into consideration the processing time needed by the VSP1 utilised in the pipeline. Register a callback with the VSP driver to obtain completion eve

[PATCH v3 3/3] drm: rcar-du: Add VSP1 live source support

2017-01-25 Thread Sergei Shtylyov
From: Laurent Pinchart Register live sources for VSPD0 and VSPD1 and configure the plane source at plane setup time to source frames from memory or from the VSP1. [Sergei: ported to the modern kernel.] Signed-off-by: Laurent Pinchart Signed-off-by: Sergei Shtylyov --- Changes in version 3

[PATCH v3 0/3] Enable R8A7790/1 DU VSPD compositor

2017-01-25 Thread Sergei Shtylyov
Hello. Here's the set of 3 patches against the 'drm-next' branch of David Airlie's 'linux.git' repo. This is a port of Laurent's DRM/DU live source patches to the recent kernel, see [1] for the version 2 of the patchset (including a Laurent's big blurb :-)). For the patch #3 to work one absolut

[PATCH v3 2/3] drm: Connect live source to framebuffers

2017-01-25 Thread Sergei Shtylyov
: ported to the modern kernel.] Signed-off-by: Laurent Pinchart Signed-off-by: Sergei Shtylyov --- Changes in version 3: - ported the patch to the modern kernel; - added my signoff. drivers/gpu/drm/drm_framebuffer.c | 134 ++ include/uapi/drm/drm_mode.h

[PATCH v3 1/3] drm: Add live source object

2017-01-25 Thread Sergei Shtylyov
: Laurent Pinchart Signed-off-by: Sergei Shtylyov --- Changes in version 3: - moved drm_live_source_{init|cleanup}() from drm_crtc.c to drm_plane.c and their prototypes from to (along with *struct* drm_live_source[_funcs]); - moved drm_mode_getsource[_res]() prototypes from to

[PATCH 2/2] drm: rcar-du: enable VSPD on R8A7794

2016-12-29 Thread Sergei Shtylyov
We're going to use R8A7794 VSPD to control DU, so set the corresponding flag and the newly added field, 'num_vspds'... Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_du_drv.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: linux/drivers/

[PATCH 1/2] drm: rcar-du: support less VSPs than CRTCs

2016-12-29 Thread Sergei Shtylyov
27; needs a new field which we'll have to set for the SoCs where we've already used the VSPD compositor... Signed-off-by: Sergei Shtylyov --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 17 ++- drivers/gpu/drm/rcar-du/rcar_du_drv.c |2 drivers/gpu/drm/rcar-du/rcar_du_drv.h

[PATCH 0/2] Enable R8A7794 DU VSPD compositor

2016-12-29 Thread Sergei Shtylyov
Hello. Here's the set of 2 patches against the 'drm-next' branch of David Airlie's 'linux.git' repo. We're switching to the DU compositor for the DU driver on the Renesas R8A7794 SoC. [1/2] drm: rcar-du: support less VSPs than CRTCs [2/2] drm: rcar-du: enable VSPD on R8A7794 MBR, Sergei

[PATCH] drm: rcar-du: enable VSPDs on R8A7791

2016-12-26 Thread Sergei Shtylyov
On 12/19/2016 11:24 PM, Laurent Pinchart wrote: >>>> We're going to use R8A7791 VSPDs to control DU, so set the corresponding >>>> flag. >>>> >>>> Signed-off-by: Sergei Shtylyov >>> >>> For the same reason I nacked the corr

  1   2   >