2015-01-12 0:13 GMT+01:00 Ben Skeggs :
> On Sun, Jan 11, 2015 at 11:53 PM, Rickard Strandqvist
> wrote:
>
> Hey Rickard,
>
>> Remove the function nvif_device_new() that is not used anywhere.
> It's used, just not by the kernel. All the code under core/ and nvif/
>
Remove the function radeon_best_encoder() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/radeon_i2c.c |5 -
drivers/gpu/drm/radeon/radeon_mode.h |2 --
2
Remove the function radeon_fbdev_total_size() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/radeon_fb.c | 10 --
drivers/gpu/drm/radeon/radeon_mode.h |1
Remove the function rv515_ring_start() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/radeon_asic.h |1 -
drivers/gpu/drm/radeon/rv515.c | 68
Removes some functions that are not used anywhere:
sumo_convert_vid7_to_vid2() sumo_dpm_reset_asic()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/sumo_dpm.c | 26
Removes some functions that are not used anywhere:
rv770_read_smc_soft_register() rv770_dpm_reset_asic()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/rv770_dpm.c | 23
Remove the function nvif_notify_ref() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/nouveau/nvif/notify.c |9 -
drivers/gpu/drm/nouveau/nvif/notify.h |1 -
2
Removes some functions that are not used anywhere:
nv04_display_late_takedown() nv04_display_early_init()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/nouveau/dispnv04/disp.c | 18
Remove the function nouveau_bo_rd16() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 12
drivers/gpu/drm/nouveau/nouveau_bo.h |1 -
2
Remove the function kv_dpm_reset_asic() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/kv_dpm.c | 21 -
1 file changed, 21 deletions(-)
diff --git
gt;
>
> On 01/11/2015 07:12 PM, Rickard Strandqvist wrote:
>>
>> Remove the function nouveau_perfsig_wrap() that is not used anywhere.
>>
>> This was partially found by using a static code analysis program called
>> cppcheck.
>>
>> Signed-off-by: Rickard
Remove the function nouveau_perfsig_wrap() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/nouveau/core/engine/perfmon/base.c | 20
drivers/gpu/drm
Remove the function mid_pipe_vsync() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/gma500/psb_irq.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers
Remove the function si_dpm_reset_asic() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/si_dpm.c |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu
Remove the function cypress_dpm_reset_asic() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/cypress_dpm.c |6 --
1 file changed, 6 deletions(-)
diff --git a
Remove the function trinity_dpm_reset_asic() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/trinity_dpm.c | 16
1 file changed, 16 deletions(-)
diff
Remove the function ni_dpm_reset_asic() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/ni_dpm.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu
Removes some functions that are not used anywhere:
ci_dpm_reset_asic() ci_dpm_power_control_set_level()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/ci_dpm.c | 10 --
1 file changed
Remove the function domain_to_ttm() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 -
1 file changed, 13 deletions(-)
diff --git a
Remove the function btc_dpm_reset_asic() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/btc_dpm.c |8
1 file changed, 8 deletions(-)
diff --git a/drivers
Remove the function nvif_device_new() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/nouveau/nvif/device.c | 18 --
drivers/gpu/drm/nouveau/nvif/device.h
Remove the function radeon_bo_fbdev_mmap() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/radeon_object.c |6 --
drivers/gpu/drm/radeon/radeon_object.h |2
Remove the function ci_wait_for_smc_inactive() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/ci_dpm.h |1 -
drivers/gpu/drm/radeon/ci_smc.c | 18
Remove the function armada_drm_vbl_event_remove_unlocked() that is not used
anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/armada/armada_drm.h |2 --
drivers/gpu/drm/armada/armada_drv.c
Removes some functions that are not used anywhere:
armada_drm_encoder_mode_fixup() armada_drm_encoder_commit()
armada_drm_encoder_prepare()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/armada
Removes some functions that are not used anywhere:
qxl_fbdev_qobj_is_fb() qxl_get_handle_for_primary_fb()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/qxl/qxl_drv.h |4
drivers/gpu/drm/qxl
Removes some functions that are not used anywhere:
qxl_io_flush_surfaces() qxl_io_flush_release()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/qxl/qxl_cmd.c | 10 --
drivers/gpu/drm/qxl
Remove the function psb_get_default_pd_addr() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/gma500/mmu.c |9 -
1 file changed, 9 deletions(-)
diff --git a/drivers
Removes some functions that are not used anywhere:
qxl_gem_fini() qxl_gem_init()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/qxl/qxl_drv.h |2 --
drivers/gpu/drm/qxl/qxl_gem.c | 11
Remove the function radeon_doorbell_free() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/radeon.h|1 -
drivers/gpu/drm/radeon/radeon_device.c | 14
2014-12-21 3:46 GMT+01:00 Ben Skeggs :
> - Original Message -
>> From: "Rickard Strandqvist"
>> To: "David Airlie" , "Ben Skeggs" > redhat.com>
>> Cc: "Rickard Strandqvist" ,
>> "Alexandre Courbot
Remove the function ast_load_dp501_microcode() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/ast/ast_dp501.c | 12
drivers/gpu/drm/ast/ast_drv.h |1 -
2
Remove the function sti_drm_crtc_is_main() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/sti/sti_drm_crtc.c | 10 --
drivers/gpu/drm/sti/sti_drm_crtc.h |1 -
2
Remove the function nouveau_clock_astate() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/nouveau/core/include/subdev/clock.h |1 -
drivers/gpu/drm/nouveau/core/subdev
Remove the function ast_bo_unpin() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/ast/ast_drv.h |1 -
drivers/gpu/drm/ast/ast_ttm.c | 20
2 files
Remove the function radeon_atom_update_memory_dll() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/radeon.h |2 --
drivers/gpu/drm/radeon/radeon_atombios.c
Remove the function dsi_rr_formula() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/i915/intel_dsi_pll.c | 83 +-
1 file changed, 1 insertion
Remove the function dsi_hs_mode_enable() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/i915/intel_dsi_cmd.c | 21 -
drivers/gpu/drm/i915/intel_dsi_cmd.h
Remove the function intel_dp_set_drrs_state() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/i915/intel_dp.c | 89 --
drivers/gpu/drm
Remove the function intel_output_name() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/i915/intel_display.c | 22 --
drivers/gpu/drm/i915/intel_drv.h
Removes some functions that are not used anywhere:
vlv_flisdsi_read() vlv_gps_core_write() vlv_gps_core_read()
vlv_ccu_write() vlv_ccu_read() vlv_gpio_nc_read()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu
Remove the function tc35876x_exit() that is not used anywhere.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c | 10 --
drivers/gpu/drm/gma500/tc35876x-dsi-lvds.h
Fixed wrong usage of strncat, switched to strlcpy.
While sending the string size to function to reduce
the potential for misuse in future.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/drm_dp_mst_topology.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff
I have now eliminate the need to use the temporary string,
and therefore also the use of strncat.
And I think this code is clearer and more effective.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/drm_dp_mst_topology.c | 15 ---
1 file changed, 8 insertions(+), 7
Hi
Thanks for your response!
No, it does not sound like it's worth changing anything.
Although in the worst case with this patch you probably have a more
consistent error :)
Best regards
Rickard Strandqvist
2014-06-02 9:48 GMT+02:00 Christian K?nig :
> Am 01.06.2014 01:10, schrieb
There is a risk that the variable will be used without being initialized.
This was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/gpu/drm/radeon/r600_cp.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
46 matches
Mail list logo