Re: linux-next: Tree for Jun 25 (drivers/gpu/drm/{i915,xe}/intel_pcode.o)

2025-06-25 Thread Randy Dunlap
On 6/25/25 12:22 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20250624: > on i386, when both CONFIG_DRM_XE=y and CONFIG_DRM_I915=y: ld: drivers/gpu/drm/xe/xe_pcode.o: in function `intel_pcode_read': xe_pcode.c:(.text+0x7d0): multiple definition of `intel_pcode_read'; drivers/gpu/

[PATCH] drm/msm/dp: add linux/io.h header to fix build errors

2025-06-17 Thread Randy Dunlap
43 | writel(data, panel->link_base + offset); Fixes: d7e3bee925bd ("drm/msm/dp: drop the msm_dp_catalog module") Signed-off-by: Randy Dunlap Cc: Stephen Boyd Cc: Dmitry Baryshkov Cc: Dmitry Baryshkov Cc: Dmitry Baryshkov Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: f

Re: [PATCH v2] Documentation: dma-buf: heaps: Add naming guidelines

2025-06-16 Thread Randy Dunlap
On 6/16/25 8:21 AM, Maxime Ripard wrote: > We've discussed a number of times of how some heap names are bad, but > not really what makes a good heap name. > > Let's document what we expect the heap names to look like. > > Reviewed-by: Bagas Sanjaya > Signed-off-by: Maxime Ripard > --- > Chan

Re: [PATCH] docs: nouveau: remove invalid kernel-doc reference to r535.c

2025-06-15 Thread Randy Dunlap
Hi, On 6/15/25 7:17 PM, HyeonSu Jeon wrote: > The file drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c does not exist > in the tree, but is referenced in gsp.rst via a kernel-doc directive. > This causes an error during the documentation build > > Removing this refernce resolves the error > > Sig

[PATCH] fbdev: nvidiafb: add depends on HAS_IOPORT

2025-06-15 Thread Randy Dunlap
in ARCH=um allmodconfig builds) drivers/video/fbdev/nvidia/nv_accel.c: In function ‘NVDmaWait’: include/asm-generic/io.h:596:15: error: call to ‘_outb’ declared with attribute error: outb() requires CONFIG_HAS_IOPORT 596 | #define _outb _outb Signed-off-by: Randy Dunlap Cc: Arnd Bergmann Cc: Niklas Sc

Re: linux-next: Tree for Jun 13 (drivers/gpu/drm/i915/display/intel_backlight.c)

2025-06-13 Thread Randy Dunlap
On 6/12/25 10:42 PM, Stephen Rothwell wrote: > Hi all, > on i386, when: # CONFIG_ACPI is not set CONFIG_DRM_I915=y CONFIG_BACKLIGHT_CLASS_DEVICE=m drivers/gpu/drm/i915/display/intel_backlight.c:973:(.text+0x2613): undefined reference to `backlight_device_get_by_name' ld: drivers/gpu/drm/i915/

Re: [PATCH v2] Documentation: nouveau: Update GSP message queue kernel-doc reference

2025-06-10 Thread Randy Dunlap
; ./drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c > > Update the reference. > > Fixes: c472d828348c ("drm/nouveau/gsp: move subdev/engine impls to > subdev/gsp/rm/r535/") > Fixes: 8a8b1ec5261f ("drm/nouveau/gsp: split rpc handling out on its own") &

Re: [PATCH] Documentation: nouveau: Update GSP message queue kernel-doc reference

2025-06-10 Thread Randy Dunlap
On 6/9/25 11:52 PM, Bagas Sanjaya wrote: > Commit c472d828348caf ("drm/nouveau/gsp: move subdev/engine impls to > subdev/gsp/rm/r535/") moves GSP-RM message queue implementation in > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c to versioned path in > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/

Re: linux-next: Tree for Apr 29 (drivers/gpu/drm/xe/xe_devcoredump.c)

2025-04-29 Thread Randy Dunlap
On 4/29/25 2:02 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20250428: > on i386: ERROR: modpost: "__moddi3" [drivers/gpu/drm/xe/xe.ko] undefined! due to + memcpy(buffer, ss->read.buffer + + (offset % XE_DEVCOREDUMP_CHUNK_MAX), byte_copied); in commit c4a2e5f8

Re: linux-next: Tree for Apr 16 (drivers/gpu/drm/xe/xe_vsec.o)

2025-04-16 Thread Randy Dunlap
On 4/15/25 11:25 PM, Stephen Rothwell wrote: > Hi all, > > News: there will be no linux-next releases this coming Friday or Monday > or next Friday. > > Changes since 20250415: > on x86_64: ld: drivers/gpu/drm/xe/xe_vsec.o: in function `xe_vsec_init': xe_vsec.c:(.text+0x21a): undefined refe

Re: linux-next: Tree for Apr 16 [drivers/gpu/drm/ttm/ttm.ko]

2025-04-16 Thread Randy Dunlap
On 4/15/25 11:25 PM, Stephen Rothwell wrote: > Hi all, > > News: there will be no linux-next releases this coming Friday or Monday > or next Friday. > > Changes since 20250415: on x86_64: # CONFIG_SHMEM is not set CONFIG_DRM_TTM=m ERROR: modpost: "shmem_writeout" [drivers/gpu/drm/ttm/ttm.ko

Re: [PATCH] backlight: ktd2801: depend on GPIOLIB

2025-04-11 Thread Randy Dunlap
g warnings. Fix this by adding > the dependency. > > Link: > https://lore.kernel.org/all/5cf231e1-0bba-4595-9441-46acc5255...@infradead.org s/Link:/Closes:/ > Signed-off-by: Duje Mihanović o Reported-by: Randy Dunlap Tested-by: Randy Dunlap Acked-by: Randy Dunlap Thanks. >

Re: linux-next: Tree for Apr 10 (backlight: ktd2801)

2025-04-10 Thread Randy Dunlap
On 4/9/25 10:11 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20250409: > on x86_64, when CONFIG_GPIOLIB is not set: WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE Depends on [n]: GPIOLIB [=n] || NEW_LEDS [=y] && GPIOLIB [=n] Selected by [m]: - BACKLIGHT_KTD

Re: linux-next: Tree for Mar 24 (drm/xe/xe_migrate)

2025-03-24 Thread Randy Dunlap
On 3/24/25 5:01 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20250321: > on i386: linux-next-20250324/X32/drivers/gpu/drm/xe/xe_migrate.c:1561:(.text+0x3074): undefined reference to `__udivdi3' -- ~Randy

Re: [PATCH] Documentation: gpu: Fixed typos

2025-02-06 Thread Randy Dunlap
On 2/6/25 7:46 PM, Eric Salem wrote: > Fixed a few misspellings. > > Signed-off-by: Eric Salem Acked-by: Randy Dunlap Thanks. > --- > Documentation/gpu/todo.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/gpu/todo

[PATCH] drm/panthor: fix all mmu kernel-doc comments

2025-01-10 Thread Randy Dunlap
Use the correct format for all kernel-doc comments. Use structname.membername for named structs. Don't precede function names in kernel-doc with '@' sign. Use the correct function parameter names in kernel-doc comments. This fixes around 80 kernel-doc warnings. Signed-off-by: R

Re: [PATCH v5 04/10] drm/bridge: add documentation of refcounted bridges

2024-12-31 Thread Randy Dunlap
Hi-- On 12/31/24 2:39 AM, Luca Ceresoli wrote: > Document in detail the new refcounted bridges as well as the "legacy" way. > > Signed-off-by: Luca Ceresoli > > --- > > This patch was added in v5. > --- > Documentation/gpu/drm-kms-helpers.rst | 6 ++ > drivers/gpu/drm/drm_bridge.c

[PATCH] drm/xe/vm_doc: fix more doc typos

2024-11-27 Thread Randy Dunlap
Fix all typos in xe_vm_doc.h as reported by codespell. Signed-off-by: Randy Dunlap Cc: Lucas De Marchi Cc: Thomas Hellström Cc: Rodrigo Vivi Cc: intel...@lists.freedesktop.org Cc: David Airlie Cc: Simona Vetter Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/xe/xe_vm_doc.h | 22

[PATCH] drm/amdgpu: device: fix spellos and punctuation

2024-11-27 Thread Randy Dunlap
Make spelling and punctuation changes to ease reading of the comments. Signed-off-by: Randy Dunlap Cc: Alex Deucher Cc: Christian König Cc: Xinhui Pan Cc: amd-...@lists.freedesktop.org Cc: David Airlie Cc: Simona Vetter --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 30

[PATCH v2] drm/fbdev-dma: remove obsolete kernel-doc references

2024-10-16 Thread Randy Dunlap
/drm_fbdev_ttm.c:1: warning: no structured comments found Fixes: 731fddf4302e ("drm/fbdev-dma: Remove obsolete setup function") Signed-off-by: Randy Dunlap Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/all/20241002142250.07e1c...@canb.auug.org.au/ Cc: David Airlie Cc: Simona

Re: [PATCH] >>>>>>>>>>>>>>>>>>>>>>> FIXME <<<<<<<<<<<<<<<<<<<<<

2024-10-16 Thread Randy Dunlap
Whoops, I reverted the subject line change. Will resend it. On 10/16/24 7:43 PM, Randy Dunlap wrote: > > drivers/gpu/drm/drm_fbdev_dma.c:1: warning: no structured comments found > drivers/gpu/drm/drm_fbdev_shmem.c:1: warning: no structured comments found > drivers/gpu/drm/drm_f

[PATCH] >>>>>>>>>>>>>>>>>>>>>>> FIXME <<<<<<<<<<<<<<<<<<<<<

2024-10-16 Thread Randy Dunlap
ction") Signed-off-by: Randy Dunlap Reported-by: Stephen Rothwell Cc: David Airlie Cc: Simona Vetter Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- Documentation/gpu/drm-kms-helpers.rst |9 - 1 file changed, 9 deletions(-) --- linux-next-20241016.orig/Documentation/g

Re: [PATCH v11 06/15] drm/vkms: Avoid computing blending limits inside pre_mul_alpha_blend

2024-10-02 Thread Randy Dunlap
On 10/2/24 9:11 AM, Louis Chauvet wrote: > On 02/10/24 - 08:49, Randy Dunlap wrote: >> Hi Louis, >> >> On 10/2/24 1:57 AM, Louis Chauvet wrote: >>> On 01/10/24 - 20:54, Randy Dunlap wrote: >>>> Hi-- >>>> >>>> On 9/30/24 8:31 AM,

Re: [PATCH v11 10/15] drm/vkms: Add YUV support

2024-10-02 Thread Randy Dunlap
On 9/30/24 8:31 AM, Louis Chauvet wrote: > From: Arthur Grillo > > Add support to the YUV formats bellow: > > - NV12/NV16/NV24 > - NV21/NV61/NV42 > - YUV420/YUV422/YUV444 > - YVU420/YVU422/YVU444 > > The conversion from yuv to rgb is done with fixed-point arithmetic, using > 32.32 fixed-poin

Re: [PATCH v11 06/15] drm/vkms: Avoid computing blending limits inside pre_mul_alpha_blend

2024-10-02 Thread Randy Dunlap
Hi Louis, On 10/2/24 1:57 AM, Louis Chauvet wrote: > On 01/10/24 - 20:54, Randy Dunlap wrote: >> Hi-- >> >> On 9/30/24 8:31 AM, Louis Chauvet wrote: >>> The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing >>> different concepts (coor

Re: [PATCH v11 08/15] drm/vkms: Re-introduce line-per-line composition algorithm

2024-10-01 Thread Randy Dunlap
On 9/30/24 8:31 AM, Louis Chauvet wrote: > Re-introduce a line-by-line composition algorithm for each pixel format. > This allows more performance by not requiring an indirection per pixel > read. This patch is focused on readability of the code. > > Line-by-line composition was introduced by [

Re: [PATCH v11 06/15] drm/vkms: Avoid computing blending limits inside pre_mul_alpha_blend

2024-10-01 Thread Randy Dunlap
Hi-- On 9/30/24 8:31 AM, Louis Chauvet wrote: > The pre_mul_alpha_blend is dedicated to blending, so to avoid mixing > different concepts (coordinate calculation and color management), extract > the x_limit and x_dst computation outside of this helper. > It also increases the maintainability by gr

Re: [PATCH v11 03/15] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

2024-10-01 Thread Randy Dunlap
Hi, On 9/30/24 8:31 AM, Louis Chauvet wrote: > Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the > compiler to check if the passed functions take the correct arguments. > Such typedefs will help ensuring consistency across the code base in > case of update of these prototypes.

Re: [PATCH v13 09/13] Documentation: core-api: Add math.h macros and functions

2024-06-26 Thread Randy Dunlap
On 6/7/24 6:31 AM, Devarsh Thakkar wrote: > Add documentation for rounding, scaling, absolute value and 32-bit division > related macros and functions exported by math.h header file. > > Signed-off-by: Devarsh Thakkar > Reviewed-by: Andy Shevchenko Reviewed-by: Randy Du

Re: [PATCH v10 6/6] Documentation: iio: Document high-speed DMABUF based API

2024-06-08 Thread Randy Dunlap
Hi Paul. On 6/7/24 12:44 AM, Paul Cercueil wrote: > Hi Randy, > > Le jeudi 06 juin 2024 à 10:32 -0700, Randy Dunlap a écrit : >> Hi, >> >> On 6/5/24 4:08 AM, Paul Cercueil wrote: >>> Document the new DMABUF based API. >>> >>> Si

Re: [PATCH v10 6/6] Documentation: iio: Document high-speed DMABUF based API

2024-06-06 Thread Randy Dunlap
Hi, On 6/5/24 4:08 AM, Paul Cercueil wrote: > Document the new DMABUF based API. > > Signed-off-by: Paul Cercueil > Signed-off-by: Nuno Sa > > --- > v2: - Explicitly state that the new interface is optional and is > not implemented by all drivers. > - The IOCTLs can now only be calle

Re: [PATCH v11 07/11] Documentation: core-api: Add math.h macros and functions

2024-05-31 Thread Randy Dunlap
Hi, On 5/31/24 10:12 AM, Devarsh Thakkar wrote: > Add documentation for rounding, scaling, absolute value and difference, > 32-bit division related macros and functions exported by math.h header > file. > I don't see any kernel-doc for division functions in this header file. Do some division fu

Re: [PATCH][next] drm/amd/display: Fix a handful of spelling mistakes

2024-05-31 Thread Randy Dunlap
On 5/31/24 2:32 AM, Colin Ian King wrote: > There are a few spelling mistakes in dml2_printf messages. Fix them. > > Signed-off-by: Colin Ian King Reviewed-by: Randy Dunlap Thanks. > --- > .../dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 6 +++--- > .

Re: [PATCH v10 07/11] Documentation: core-api: Add math.h macros and functions

2024-05-30 Thread Randy Dunlap
On 5/30/24 10:17 AM, Devarsh Thakkar wrote: > Add documentation for rounding, scaling, absolute value and difference, > 32-bit division related macros and functions exported by math.h header > file. > > Signed-off-by: Devarsh Thakkar > --- > V1->V9 (No change) > V10: Patch introduced > --- >

Re: [PATCH] drm/display/dp: fix all kernel-doc warnings

2024-05-22 Thread Randy Dunlap
On 5/22/24 2:37 AM, Dmitry Baryshkov wrote: > On Tue, May 21, 2024 at 08:59:06PM -0700, Randy Dunlap wrote: >> Hi Dmitry, >> >> On 5/20/24 3:37 AM, Dmitry Baryshkov wrote: >>> On Wed, May 15, 2024 at 05:26:42PM -0700, Randy Dunlap wrote: >>>> Fix a s

Re: [PATCH] drm/mode: fix all kernel-doc warnings

2024-05-21 Thread Randy Dunlap
Hi, On 5/20/24 3:39 AM, Dmitry Baryshkov wrote: > On Wed, May 15, 2024 at 05:26:52PM -0700, Randy Dunlap wrote: >> Add @width and @height descriptions for &struct drm_plane_size_hint >> along with a reference to more info. >> >> Add a short description for &stru

Re: [PATCH] drm/display/dp: fix all kernel-doc warnings

2024-05-21 Thread Randy Dunlap
Hi Dmitry, On 5/20/24 3:37 AM, Dmitry Baryshkov wrote: > On Wed, May 15, 2024 at 05:26:42PM -0700, Randy Dunlap wrote: >> Fix a struct member name in &struct drm_dp_as_sdp. >> Add Returns: kernel-doc syntax for 4 functions. >> In the Returns: sections, spell "%t

[PATCH] drm/mode: fix all kernel-doc warnings

2024-05-15 Thread Randy Dunlap
* DRM_MODE_ATOMIC_FLAGS drm_mode.h:1358: warning: missing initial short description on line: * struct drm_mode_closefb Signed-off-by: Randy Dunlap --- Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas

[PATCH] drm/display/dp: fix all kernel-doc warnings

2024-05-15 Thread Randy Dunlap
27; drm_dp_helper.h:539: warning: No description found for return value of 'drm_dp_dpcd_readb' drm_dp_helper.h:554: warning: No description found for return value of 'drm_dp_dpcd_writeb' drm_dp_helper.h:721: warning: No description found for return value of 'drm_dp_has_quirk' S

Re: [PATCH] drm: Fix no_vblank field references in documentation

2024-04-23 Thread Randy Dunlap
On 4/16/24 2:02 PM, Randy Dunlap wrote: > > > On 4/16/24 2:00 PM, Marijn Suijten wrote: >> Hi Randy, >> >> [..] >> >>> Do you see differences in the generated html for these changes? >> >> I have not yet generated the HTML locally to

Re: [PATCH] drm: Fix no_vblank field references in documentation

2024-04-16 Thread Randy Dunlap
On 4/16/24 2:00 PM, Marijn Suijten wrote: > Hi Randy, > > [..] > >> Do you see differences in the generated html for these changes? > > I have not yet generated the HTML locally to test this patch, but will surely > do > if that's a requirement. > >> "&struct somestruct" and "&somestruct" s

Re: [PATCH] drm: Fix no_vblank field references in documentation

2024-04-16 Thread Randy Dunlap
Hi, On 4/16/24 12:29 PM, Marijn Suijten wrote: > Browsing the DRM documentation shows that drm_crtc_state.no_vblank > is not turned into a reference to the no_vblank field, but rather a > reference to `struct drm_crtc_state`. The only difference with other > field references is that the struct na

Re: [PATCH] treewide: Fix common grammar mistake "the the"

2024-04-11 Thread Randy Dunlap
+- > scripts/coccinelle/misc/badty.cocci | 2 +- > tools/perf/Documentation/perf-diff.txt| 2 +- > 30 files changed, 32 insertions(+), 32 deletions(-) > Reviewed-by: Randy Dunlap Thanks. -- #Randy

Re: [PATCH] fbdev/sh7760fb: allow modular build

2024-04-09 Thread Randy Dunlap
Hi, Will someone be merging this patch? thanks. On 2/10/24 1:31 AM, John Paul Adrian Glaubitz wrote: > On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote: >> There is no reason to prohibit sh7760fb from being built as a >> loadable module as suggested by Geert, so change th

Re: [RFC PATCH net-next v7 13/14] net: add devmem TCP documentation

2024-03-26 Thread Randy Dunlap
Hi, On 3/26/24 15:50, Mina Almasry wrote: > Add documentation outlining the usage and details of devmem TCP. > > Signed-off-by: Mina Almasry > > --- > > v7: > - Applied docs suggestions (Jakub). > > v2: > > - Missing spdx (simon) > - add to index.rst (simon) > > --- > Documentation/network

Re: [PATCH v2 1/8] drm: xlnx: Fix kerneldoc

2024-03-19 Thread Randy Dunlap
On 3/19/24 22:42, Tomi Valkeinen wrote: > On 20/03/2024 00:51, Sean Anderson wrote: >> Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed >> members. >> >> Signed-off-by: Sean Anderson >> --- >> >> Changes in v2: >> - New >> >>   drivers/gpu/drm/xlnx/zynqmp_disp.c  | 6 +++

Re: [PATCH v5 11/16] drm/vkms: Add YUV support

2024-03-13 Thread Randy Dunlap
Hi, On 3/13/24 10:45, Louis Chauvet wrote: > From: Arthur Grillo > > > Signed-off-by: Arthur Grillo > [Louis Chauvet: > - Adapted Arthur's work > - Implemented the read_line_t callbacks for yuv > - add struct conversion_matrix > - remove struct pixel_yuv_u8 > - update the commit message > - M

Re: [PATCH v5 05/16] drm/vkms: Add dummy pixel_read/pixel_write callbacks to avoid NULL pointers

2024-03-13 Thread Randy Dunlap
On 3/13/24 10:44, Louis Chauvet wrote: > Introduce two callbacks which does nothing. They are used in replacement > of NULL and it avoid kernel OOPS if this NULL is called. > > If those callback are used, it means that there is a mismatch between > what formats are announced by atomic_check and

Re: [PATCH v5 03/16] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-03-13 Thread Randy Dunlap
Hi, On 3/13/24 10:44, Louis Chauvet wrote: > Add some documentation on pixel conversion functions. > Update of outdated comments for pixel_write functions. > > Signed-off-by: Louis Chauvet > --- > drivers/gpu/drm/vkms/vkms_composer.c | 7 > drivers/gpu/drm/vkms/vkms_drv.h | 13 ++

Re: [PATCH] Removed vcpi field description to fix kernel doc warning

2024-03-07 Thread Randy Dunlap
On 3/7/24 18:51, R SUNDAR wrote: > For linux-next repo > > /include/drm/display/drm_dp_mst_helper.h:156: warning: Excess struct member > 'vcpi' description in 'drm_dp_mst_port' > > Signed-off-by: R SUNDAR or https://lore.kernel.org/lkml/20240106032321.28596-1-rdun...@infradead.org/ but I w

Re: [PATCH] Removed funcs field description for kernel doc warning.

2024-03-04 Thread Randy Dunlap
or https://lore.kernel.org/lkml/20240106032957.1195-1-rdun...@infradead.org/ but in any case I would like to see any one of these patches merged. Thanks. Reviewed-by: Randy Dunlap > --- > include/drm/drm_gem_vram_helper.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-02 Thread Randy Dunlap
On 3/2/24 14:10, Guenter Roeck wrote: > On Thu, Feb 29, 2024 at 12:21 PM Linus Torvalds > wrote: >> >> On Thu, 29 Feb 2024 at 01:23, Nikolai Kondrashov wrote: >>> >>> However, I think a better approach would be *not* to add the .gitlab-ci.yaml >>> file in the root of the source tree, but inste

Re: linux-next: Tree for Feb 26 (drivers/gpu/drm/xe)

2024-02-26 Thread Randy Dunlap
On 2/25/24 22:55, Stephen Rothwell wrote: > Hi all, > > Changes since 20240223: > on powerpc32 or i386: ../drivers/gpu/drm/xe/xe_ggtt.c: In function 'xe_ggtt_set_pte': ../drivers/gpu/drm/xe/xe_ggtt.c:78:9: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=imp

Re: [PATCH] drm/tests/drm_buddy: avoid 64-bit calculation

2024-02-16 Thread Randy Dunlap
nction has another possible flaw in that is mixes > what it calls pages with 4KB units. This is a big confusing at best, > or possibly broken when built on machines with larger pages. > > Fixes: a64056bb5a32 ("drm/tests/drm_buddy: add alloc_contiguous test") > Signed

Re: linux-next: Tree for Feb 15 (drivers/gpu/drm/tests/drm_buddy_test.o)

2024-02-15 Thread Randy Dunlap
On 2/14/24 19:52, Stephen Rothwell wrote: > Hi all, > > Changes since 20240214: > on i386: ld: drivers/gpu/drm/tests/drm_buddy_test.o: in function `drm_test_buddy_alloc_contiguous': /work/lnx/next/linux-next-20240215/X32/../drivers/gpu/drm/tests/drm_buddy_test.c:48:(.text+0x94): undefined r

[PATCH v2] iosys-map: fix typo

2024-02-13 Thread Randy Dunlap
Correct a spello/typo in comments. Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- v2: don't change "set up" to "setup" (Thomas) include/linux/iosys-map.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/in

[PATCH v3] drm: drm_crtc: correct some comments

2024-02-12 Thread Randy Dunlap
Fix some typos and punctuation. Signed-off-by: Randy Dunlap Cc: Alex Deucher Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- v2: s/instances/instance/ (Alex) v3: rebase and resend; add more Cc:s

Re: [PATCH RESEND] iosys-map: fix typos

2024-02-12 Thread Randy Dunlap
On 2/11/24 23:13, Thomas Zimmermann wrote: > Hi > > Am 12.02.24 um 05:28 schrieb Randy Dunlap: >> Correct spellos/typos in comments. >> >> Signed-off-by: Randy Dunlap >> Cc: Thomas Zimmermann >> Cc: dri-devel@lists.freedesktop.org >> --- >>

[PATCH RESEND] iosys-map: fix typos

2024-02-11 Thread Randy Dunlap
Correct spellos/typos in comments. Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- include/linux/iosys-map.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/include/linux/iosys-map.h b/include/linux/iosys-map.h --- a/include

Re: [PATCH] gpu: drm: display: indent fix in comment

2024-02-10 Thread Randy Dunlap
On 2/8/24 07:20, Kousik Sanagavarapu wrote: > On Thu, Jan 25, 2024 at 12:05:56AM +0530, Kousik Sanagavarapu wrote: >> The comments explaining the function "drm_dp_mst_atom_check_mgr()" had >> uneven indentation which made "make htmldocs" complain: >> >> Documentation/gpu/drm-kms-helpers:296

[PATCH] fbdev/sh7760fb: allow modular build

2024-02-09 Thread Randy Dunlap
tterhoeven Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: John Paul Adrian Glaubitz Cc: Sam Ravnborg Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/fbdev/Kconfig |4 ++-- 1 file changed, 2 insert

[PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

2024-02-07 Thread Randy Dunlap
sts.freedesktop.org Signed-off-by: Randy Dunlap --- v2: add Geoff's Ack; add second Fixes: tag and more Cc:s (Thomas) arch/powerpc/platforms/ps3/Kconfig |1 + 1 file changed, 1 insertion(+) diff -- a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig --- a/arch/

Re: linux-next: Tree for Feb 6 (gpu/drm/amd/display/ kernel-doc warnings)

2024-02-05 Thread Randy Dunlap
On 2/5/24 20:43, Stephen Rothwell wrote: > Hi all, > > Changes since 20240205: > Hi Rodrigo, Are you aware of these kernel-doc warnings? I think they are due to commit b8c1c3a82e75 Author: Rodrigo Siqueira Date: Mon Jan 22 14:24:57 2024 -0700 Documentation/gpu: Add kernel doc entry f

[PATCH v2] drm/panel: re-alphabetize the menu list

2024-02-04 Thread Randy Dunlap
A few of the DRM_PANEL entries have become out of alphabetical order, so move them around a bit to restore alpha order. Signed-off-by: Randy Dunlap Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc

[PATCH v2] drm/rect: fix kernel-doc typos

2024-02-04 Thread Randy Dunlap
Correct typos of "translated". Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Reviewed-by: Simon Ser Signed-off-by: Randy Dunlap --- v2: add Reviewed-by, rebase include/drm/drm_rect.h |

Re: linux-next: Tree for Jan 29 (drm/xe/ and FB_IOMEM_HELPERS)

2024-01-29 Thread Randy Dunlap
On 1/28/24 19:30, Stephen Rothwell wrote: > Hi all, > > Changes since 20240125: > > New trees: i2c-host-fixes, i2c-host > on riscv 64-bit or powerpc 64-bit: WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]:

Re: linux-next: Tree for Jan 23 (drm/xe/)

2024-01-24 Thread Randy Dunlap
On 1/24/24 01:17, Jani Nikula wrote: > On Tue, 23 Jan 2024, Randy Dunlap wrote: >> On 1/22/24 18:29, Stephen Rothwell wrote: >>> Hi all, >>> >>> News: there will be no linux-next release on Friday >>> >>> Changes since 20240122: >&

Re: linux-next: Tree for Jan 23 (drm/xe/)

2024-01-23 Thread Randy Dunlap
On 1/22/24 18:29, Stephen Rothwell wrote: > Hi all, > > News: there will be no linux-next release on Friday > > Changes since 20240122: > on ARM64, when DRM_I915 is not set DRM_XE=m DEBUG_FS is not set ../drivers/gpu/drm/i915/display/intel_display_debugfs.c:1091:6: error: redefinition of 'i

Re: [PATCH 2/2] scripts/kernel-doc: Do not process backslash lines in comments

2024-01-22 Thread Randy Dunlap
ly for lines which are no > comments, e.g. do not start with ' *'. > > Suggested-by: Matthew Wilcox > Signed-off-by: Anna-Maria Behnsen I compared several hundred html files before and after this patch and they were all the same, so I will say: Tested-by: Randy Dunlap Thanks.

Re: [PATCH] drm/display: fix typo

2024-01-19 Thread Randy Dunlap
On 1/19/24 02:22, Oleksandr Natalenko wrote: > While studying the code I've bumped into a small typo within the > kernel-doc for two functions, apparently, due to copy-paste. > > This commit fixes "sizo" word to be "size". > > Signed-off-by: O

Re: [PATCH] drm/imagination: fix ARRAY_SIZE build error

2024-01-18 Thread Randy Dunlap
Hi Matt, On 1/18/24 01:38, Matt Coster wrote: > On 10/01/2024 00:23, Randy Dunlap wrote: >> Fix a build error when using GCC 13.2.0 from kernel.org crosstools >> by changing ARRAY_SIZE() to the macro PVR_MIPS_PT_PAGE_COUNT: > > I assume you're referring to the x86_64

[PATCH] drm/amd/display: remove kernel-doc misuses in dmub_replay.c

2024-01-14 Thread Randy Dunlap
imization flags and coasting vtotal. dmub_replay.c:284: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * send Replay general cmd to DMUB. Signed-off-by: Randy Dunlap Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira

[PATCH] drm/doc: internals: remove section on PCI legacy support

2024-01-11 Thread Randy Dunlap
structured comments found Fixes: 2504c7ec728b ("drm: Remove source code for non-KMS drivers") Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentati

[PATCH] dma-buf/dma-resv: fix spelling

2024-01-10 Thread Randy Dunlap
Fix spelling mistakes as reported by codespell. Signed-off-by: Randy Dunlap Cc: Sumit Semwal Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Christian König Cc: linaro-mm-...@lists.linaro.org --- drivers/dma-buf/dma-resv.c |4 ++-- 1 file changed, 2 insertions

[PATCH] dma-buf/dma-fence: fix spelling

2024-01-10 Thread Randy Dunlap
Fix spelling mistakes as reported by codespell. Signed-off-by: Randy Dunlap Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Christian König Cc: linaro-mm-...@lists.linaro.org --- drivers/dma-buf/dma-fence.c |8 1 file

[PATCH] drm/imagination: fix ARRAY_SIZE build error

2024-01-09 Thread Randy Dunlap
4: note: in expansion of macro 'ARRAY_SIZE' 105 | for (page_nr = ARRAY_SIZE(mips_data->pt_pages) - 1; page_nr >= 0; page_nr--) { |^~ Fixes: 927f3e0253c1 ("drm/imagination: Implement MIPS firmware processor and MMU support")

Re: [PATCH v2] drm/vram-helper: fix kernel-doc warnings

2024-01-09 Thread Randy Dunlap
On 1/9/24 07:25, Daniel Vetter wrote: > On Tue, 9 Jan 2024 at 16:23, Randy Dunlap wrote: >> >> >> >> On 1/9/24 05:42, Daniel Vetter wrote: >>> On Tue, 9 Jan 2024 at 13:59, Daniel Vetter wrote: >>>> >>>> On Mon, Jan 08, 2

Re: [PATCH v2] drm/vram-helper: fix kernel-doc warnings

2024-01-09 Thread Randy Dunlap
On 1/9/24 05:42, Daniel Vetter wrote: > On Tue, 9 Jan 2024 at 13:59, Daniel Vetter wrote: >> >> On Mon, Jan 08, 2024 at 01:10:12PM -0800, Randy Dunlap wrote: >>> Hi Thomas, >>> >>> On 1/8/24 00:57, Thomas Zimmermann wrote: >>>> Hi, >&g

Re: [PATCH v2] drm/vram-helper: fix kernel-doc warnings

2024-01-08 Thread Randy Dunlap
Hi Thomas, On 1/8/24 00:57, Thomas Zimmermann wrote: > Hi, > > thanks for the fix. > > Am 06.01.24 um 04:29 schrieb Randy Dunlap: >> Remove the @funcs entry from struct drm_vram_mm to quieten the kernel-doc >> warning. >> >> Use the "define" kern

[PATCH] driver core: component: fix spellos

2024-01-06 Thread Randy Dunlap
Correct spelling mistakes reported by codespell. Signed-off-by: Randy Dunlap Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: dri-devel@lists.freedesktop.org --- drivers/base/component.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/drivers/base/com

[PATCH v2] drm/vram-helper: fix kernel-doc warnings

2024-01-05 Thread Randy Dunlap
M_PLANE_HELPER_FUNCS - drm_gem_vram_helper.h:185: warning: Excess struct member 'funcs' description in 'drm_vram_mm' Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zi

[PATCH] drm/display/dp_mst: remove Excess struct member kernel-doc

2024-01-05 Thread Randy Dunlap
Quieten an "Excess struct member" kernel-doc warning by removing the extraneous line. drm_dp_mst_helper.h:156: warning: Excess struct member 'vcpi' description in 'drm_dp_mst_port' Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lis

[PATCH] drm/vram-helper: fix kernel-doc warnings

2024-01-05 Thread Randy Dunlap
drm_gem_vram_helper.h:129: warning: missing initial short description on line: * DRM_GEM_VRAM_PLANE_HELPER_FUNCS - drm_gem_vram_helper.h:185: warning: Excess struct member 'funcs' description in 'drm_vram_mm' Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel V

Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2024-01-04 Thread Randy Dunlap
On 1/2/24 19:10, Randy Dunlap wrote: > Hi Vegard, > > On 12/25/23 09:08, Randy Dunlap wrote: >> >> >> On 12/25/23 00:30, Vegard Nossum wrote: >>> >>> On 25/12/2023 08:40, Randy Dunlap wrote: >>>> I do see one thing that I don't l

Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2024-01-02 Thread Randy Dunlap
Hi Vegard, On 12/25/23 09:08, Randy Dunlap wrote: > > > On 12/25/23 00:30, Vegard Nossum wrote: >> >> On 25/12/2023 08:40, Randy Dunlap wrote: >>> I do see one thing that I don't like in the generated html output. >>> It's no

[PATCH] drm/amd/display: dcn35_hwseq: use common comment to prevent kernel-doc warnings

2023-12-31 Thread Randy Dunlap
ng: missing initial short description on line: * power up sequence Signed-off-by: Randy Dunlap Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Alex Deucher Cc: Christian König Cc: "Pan, Xinhui" Cc: amd-...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard

[PATCH 4/4] drm/nouveau/volt/gk20a: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
doc.rst * cvb_t_mv = gk20a.c:62: warning: missing initial short description on line: * cvb_t_mv = Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- drivers/gpu/d

[PATCH 2/4] drm/nouveau: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
7; nouveau_ioc32.c:52: warning: expecting prototype for Called whenever a 32-bit process running under a 64(). Prototype was for nouveau_compat_ioctl() instead Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Cc: Maarten L

[PATCH 3/4] drm/nouveau/gr/gf100: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
dered idle if it is disabled by the gf100.c:1044: warning: missing initial short description on line: * Wait until GR goes idle. GR is considered idle if it is disabled by the Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.or

[PATCH 1/4] drm/nouveau/disp: don't misuse kernel-doc comments

2023-12-31 Thread Randy Dunlap
up registers for the given mode/adjusted_mode pair. crtc.c:629: warning: missing initial short description on line: * Sets up registers for the given mode/adjusted_mode pair. Signed-off-by: Randy Dunlap Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Cc

[PATCH] drm/msm/dpu: fix kernel-doc warnings

2023-12-30 Thread Randy Dunlap
dpu_encoder_virt' dpu_encoder.c:212: warning: Excess struct member 'debugfs_root' description in 'dpu_encoder_virt' dpu_rm.c:35: warning: Excess struct member 'hw_res' description in 'dpu_rm_requirements' dpu_rm.c:208: warning: No description found for return

[PATCH] drm/imagination: pvr_device.h: fix all kernel-doc warnings

2023-12-30 Thread Randy Dunlap
; pvr_device.h:292: warning: Excess struct member 'slot_count' description in 'pvr_device' pvr_device.h:292: warning: Excess struct member 'reserved_count' description in 'pvr_device' pvr_device.h:292: warning: Excess struct member 'waiters' d

[PATCH] drm/gpuvm: fix all kernel-doc warnings in include/drm/drm_gpuvm.h

2023-12-30 Thread Randy Dunlap
ption on line: * drm_gpuvm_bo_gem_evict() drm_gpuvm.h:740: warning: missing initial short description on line: * drm_gpuvm_bo_gem_evict() drm_gpuvm.h:698: warning: Excess struct member 'evict' description in 'drm_gpuvm_bo' drm_gpuvm.h:844: warning: Excess struct member '

[PATCH v2.1 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_gsc.h:34: warning: Excess struct member 'gem_obj' description in 'intel_gsc' Also add missing field member descriptions. Signed-off-by: Randy Dunlap Cc: Jan

Re: [PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Hi Andi, On 12/28/23 08:25, Andi Shyti wrote: > Hi Randy, > > ... > >> /** >> * struct intel_gsc - graphics security controller >> * >> - * @gem_obj: scratch memory GSC operations >> - * @intf : gsc interface >> + * @intf : gsc interface >> + * @intf.adev : MEI aux. device for this @in

Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Hi Andi, On 12/28/23 08:40, Andi Shyti wrote: > Hi Randy, > > [...] > >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h >> @@ -105,61 +105,67 @@ struct intel_guc { >> */ > > > struct { } interrupts is missing here. > >> struct { >>

[PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
member 'lock' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'gt_stamp' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'ping_delay' description in 'intel_guc' intel_guc.h:305: warning:

[PATCH v2 4/4] drm/i915/perf: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
cription in 'i915_perf_stream' i915_perf_types.h:341: warning: Excess struct member 'tail' description in 'i915_perf_stream' 3 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-

[PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_gsc.h:34: warning: Excess struct member 'gem_obj' description in 'intel_gsc' Also add missing field member descriptions. Signed-off-by: Randy Dunlap Cc: Jan

[PATCH v2 1/4] drm/i915/gem: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. i915_gem_context_types.h:420: warning: Excess struct member 'lock' description in 'i915_gem_context' Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen

  1   2   3   4   5   6   7   8   9   >