On 7/22/24 10:38, Yanjun Yang wrote:
On Fri, Jun 28, 2024 at 8:47 PM Philippe CORNU
wrote:
On 1/29/24 11:41, Raphael Gallais-Pou wrote:
This patch series aims to add several features of the dw-mipi-dsi phy
driver that are missing or need to be updated.
First patch update a PM macro
On 7/1/24 08:23, Jiapeng Chong wrote:
Remove .owner field if calls are used which set it automatically.
./drivers/gpu/drm/stm/lvds.c:1213:3-8: No need to set .owner here. The core
will do it.
Reported-by: Abaci Robot
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9457
Signed-off-by
On 6/21/24 16:55, Yannick FERTRE wrote:
Hi Raphaël,
Thanks for your patch, it will not merged due to a new clock management.
Philippe,
this patch will be replaced by another which manages all clocks that the
display controller
will need (pixel clock, bus clock reference clock).
Hi Rap
On 1/29/24 11:41, Raphael Gallais-Pou wrote:
This patch series aims to add several features of the dw-mipi-dsi phy
driver that are missing or need to be updated.
First patch update a PM macro.
Second patch adds runtime PM functionality to the driver.
Third patch adds a clock provider gener
On 4/19/23 08:33, Patrice CHOTARD wrote:
Hi Alain
On 4/16/23 22:27, Alain Volmat wrote:
Update my email address for maintainer of the STi DRM driver.
Signed-off-by: Alain Volmat
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
On 6/13/23 17:26, Raphael Gallais-Pou wrote:
On 6/13/23 16:52, Michael Nazzareno Trimarchi wrote:
Hi
On Tue, Jun 13, 2023 at 4:41 PM Philippe CORNU
wrote:
On 6/9/23 08:20, Dario Binacchi wrote:
Boards that use the STM32F{4,7} series have limited amounts of RAM. The
added parameter
p(ddev, stm_bpp);
return 0;
Acked-by: Philippe Cornu
Many thanks,
Philippe :-)
On 5/19/23 22:05, Alexandru Ardelean wrote:
From: Yannick Fertre
Add documentation for new default-brightness-level property.
Reviewed-by: Philippe CORNU
Hi Alexandru,
same comments as for the 1/2 patch.
Many thanks
Philippe :-)
Signed-off-by: Yannick Fertre
Signed-off-by: Alexandru
On 5/19/23 22:05, Alexandru Ardelean wrote:
From: Yannick Fertre
Add new property to set a brightness by default at probe.
Reviewed-by: Philippe CORNU
Hi Alexandru,
Many thanks for your patch.
You have sent a patch originally pushed on the STMicroelectronics github
as mentioned in
On 5/15/23 14:38, Raphael Gallais-Pou wrote:
In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a
container_of() before the pointer check. This could cause a kernel panic.
Fix this smatch warning:
drivers/gpu/drm/stm/ltdc.c:1124 ltdc_crtc_set_crc_source() warn: variable
derefe
On 4/21/23 10:34, Yang Li wrote:
Convert platform_get_resource(),devm_ioremap_resource() to a single call
to devm_platform_ioremap_resource(), as this is exactly what this function
does.
Signed-off-by: Yang Li
---
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +---
1 file changed, 1 insertion(
el,
and many thanks for your patch.
Acked-by: Philippe Cornu
Philippe :-)
On 5/26/23 11:05, Marek Vasut wrote:
On 5/15/23 18:02, Philippe CORNU wrote:
Hi,
The genmask of regsiter SSCR, BPCR & others were setted accordly to
the chipset stm32f4.
So that means:
F4 -> 2048x2048 framebuffer
H7/MP1 -> 4096x4096 framebuffer
?
Worse
F4 is 2048x2048
F7 is
and fixes this ltdc driver source code vs. the
related reference manual.
imho, it will not be an issue for F4 & F7 series if these bit-fields are
"bigger" as I am pretty sure stm32 MCUs are not really using such high
resolutions.
Yannick already replied with his reviewed-by. I ad
://anongit.freedesktop.org/drm/drm-misc
Hi Alain,
Reviewed-by: Philippe Cornu
Many thanks
Philippe :-)
On 6/3/22 15:44, Yannick Fertre wrote:
Zpos property is immutable for all hardware versions except the last
version (0x40100) which support the blending order feature
(dynamic z-order).
Signed-off-by: Yannick Fertre
---
drivers/gpu/drm/stm/drv.c | 1 +
drivers/gpu/drm/stm/ltdc.c | 23 ++
On 6/3/22 15:46, Yannick Fertre wrote:
The latest hardware version (0x40100) supports a hardware threshold
register (aka FUTR) to trigger a fifo underrun interrupt.
A software threshold has been implemented for other hardware versions.
The threshold is set to 128 by default.
Signed-off-by: Ya
On 6/3/22 15:45, Yannick Fertre wrote:
Support of vertical & horizontal mirroring features thanks to
the plane rotation property.
Signed-off-by: Yannick Fertre
---
drivers/gpu/drm/stm/ltdc.c | 163 -
drivers/gpu/drm/stm/ltdc.h | 1 +
2 files changed,
On 6/3/22 15:43, Yannick Fertre wrote:
Fix issues reported by checkpatch.pl:
- Braces {} should be used on all arms
- Blank lines
Signed-off-by: Yannick Fertre
---
drivers/gpu/drm/stm/ltdc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.
On 6/3/22 15:42, Yannick Fertre wrote:
Remove error message about scaling & replace it by a debug
message to avoid too much error.
Signed-off-by: Yannick Fertre
---
drivers/gpu/drm/stm/ltdc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c
On 6/3/22 15:41, Yannick Fertre wrote:
All plans must be disabled before the CRTC shutdown helping
the crtc to restart from a clean situation (without unwanted
planes already enable).
Signed-off-by: Yannick Fertre
---
drivers/gpu/drm/stm/ltdc.c | 6 ++
1 file changed, 6 insertions(+)
On 10/4/19 10:27, Colin King wrote:
From: Colin Ian King
In other places of the driver the string hdmi_rejection_pll is
used instead of the truncated hdmi_rejec_pll, so use this string
instead to be consistent.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
1 f
On 3/28/22 14:37, Raphael Gallais-Pou wrote:
Hello Xiaomeng
On 3/27/22 07:53, Xiaomeng Tong wrote:
The two bugs are here:
if (encoder) {
if (bridge && bridge->timings)
The list iterator value 'encoder/bridge' will *always* be set and
non-NULL by drm_for_each_encoder()/list_f
On 3/31/22 18:58, Philippe CORNU wrote:
On 3/28/22 16:26, Daniel Vetter wrote:
On Mon, Mar 28, 2022 at 12:21:16PM +0200, Alain Volmat wrote:
Hi Randy,
thanks for the patch.
Acked-by: Alain Volmat
Will Philippe apply this one?
Hi,
yes I will (probably early next week).
Many thanks
On 3/28/22 16:26, Daniel Vetter wrote:
On Mon, Mar 28, 2022 at 12:21:16PM +0200, Alain Volmat wrote:
Hi Randy,
thanks for the patch.
Acked-by: Alain Volmat
Will Philippe apply this one?
Hi,
yes I will (probably early next week).
Many thanks
Philippe
Just trying to make sure this won
On 2/22/22 16:20, Nathan Chancellor wrote:
Clang warns:
drivers/gpu/drm/stm/ltdc.c:625:2: warning: variable 'val' is used
uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~
drivers/gpu/drm/stm/ltdc.c:635:2: note: uninitiali
On 2/11/22 11:46, Raphaël Gallais-Pou wrote:
From: Raphael Gallais-Pou
This patch adds the CRC hashing feature supported by some recent hardware
versions of the LTDC. This is useful for test suite such as IGT-GPU-tools
[1] where a CRTC output frame can be compared to a test reference frame
t
On 2/7/22 8:44 PM, Nick Desaulniers wrote:
On Mon, Feb 7, 2022 at 8:53 AM Nathan Chancellor wrote:
Clang warns:
drivers/gpu/drm/stm/ltdc.c:625:2: warning: variable 'val' is used
uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~
reset().
Hi Maxime,
and many thanks for your patches.
Great you added Alain as he is now the drm/sti maintainer (Maintainers
file should be updated soon)
Minor typo in the commit message as rcar_du_vsp_plane_reset() is not
part of drm/sti
Reviewed-by: Philippe Cornu
Philippe :-)
However
On 1/14/22 1:45 AM, Arnd Bergmann wrote:
On Thu, Jan 13, 2022 at 6:19 PM Philippe Cornu
wrote:
DRM DRIVERS FOR STI
-M: Benjamin Gaignard
L: dri-devel@lists.freedesktop.org
S: Maintained
T: git git://anongit.freedesktop.org/drm/drm-misc
If there is no longer a
On 1/13/22 6:19 PM, Philippe Cornu wrote:
From: Benjamin Gaignard
Update Benjamin Gaignard address and remove it from no more maintained
drivers.
Signed-off-by: Benjamin Gaignard
---
MAINTAINERS | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/MAINTAINERS b
Add Alain as sti maintainer for both drm/sti & cec/sti.
Add Raphaël as stm maintainer for drm/stm.
Signed-off-by: Philippe Cornu
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6bea080d0159..708f8c86e4c9 100644
--- a/MAINTAINERS
+
DRM DRIVERS FOR STM
M: Yannick Fertre
M: Philippe Cornu
-M: Benjamin Gaignard
L: dri-devel@lists.freedesktop.org
S: Maintained
T: git git://anongit.freedesktop.org/drm/drm-misc
@@ -18154,7 +18152,6 @@ F:
Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt
NERS: Update Benjamin Gaignard maintainer status
Philippe Cornu (1):
MAINTAINERS: update drm/stm drm/sti and cec/sti maintainers
MAINTAINERS | 8
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.17.1
On 12/15/21 10:46 PM, Yannick Fertre wrote:
Hello,
List of new feature:
* Replace the legacy register access by regmap API.
* Support of YCbCr 422 output
* Update layer shadow registers per plane.
* Support of YCbCr output (planar, semiplanar & coplanar)
These featues are available only with
On 1/7/22 6:26 PM, José Expósito wrote:
Hi Simon,
On Wed, Jan 05, 2022 at 11:54:43PM +, Simon Ser wrote:
Pushed patches 1 & 2 to drm-misc-next. Thanks for your contribution!
Thanks a lot for the review and for applying the changes, appreciate it.
Is there something that needs to impro
On 12/14/21 11:19 AM, Philippe CORNU wrote:
On 12/3/21 9:56 AM, Yannick Fertre wrote:
Add support of new hardware version 0x40100.
Signed-off-by: Yannick Fertre
---
drivers/gpu/drm/stm/ltdc.c | 172 ++---
drivers/gpu/drm/stm/ltdc.h | 3 +-
2 files
On 12/14/21 11:15 AM, Philippe CORNU wrote:
On 12/6/21 3:23 PM, Thomas Zimmermann wrote:
Hi
Am 06.12.21 um 14:47 schrieb Yannick Fertre:
In case of using simplefb or another conflicting framebuffer,
call drm_aperture_remove_framebuffers() to remove memory allocated.
Signed-off-by
: Andrzej Hajda
To: Neil Armstrong
To: Robert Foss
To: Laurent Pinchart
To: Jonas Karlman
To: Jernej Skrabec
To: Yannick Fertre
To: Philippe Cornu
To: Benjamin Gaignard
To: Maxime Coquelin
To: Alexandre Torgue
To: Philipp Zabel
To: dri-devel@lists.freedesktop.org
To: linux-st...@st-md
Hajda
To: Neil Armstrong
To: Robert Foss
To: Laurent Pinchart
To: Jonas Karlman
To: Jernej Skrabec
To: Yannick Fertre
To: Philippe Cornu
To: Benjamin Gaignard
To: Maxime Coquelin
To: Alexandre Torgue
To: Philipp Zabel
To: dri-devel@lists.freedesktop.org
To: linux-st...@st-md
Airlie
To: Daniel Vetter
To: Andrzej Hajda
To: Neil Armstrong
To: Robert Foss
To: Laurent Pinchart
To: Jonas Karlman
To: Jernej Skrabec
To: Yannick Fertre
To: Philippe Cornu
To: Benjamin Gaignard
To: Maxime Coquelin
To: Alexandre Torgue
To: Philipp Zabel
To: dri-devel@lists.freedesktop.org
-by: Yannick Fertre
---
drivers/gpu/drm/stm/ltdc.c | 251 +++--
drivers/gpu/drm/stm/ltdc.h | 1 +
2 files changed, 245 insertions(+), 7 deletions(-)
Hi Yannick,
many thanks for your patch.
Nice hw features!
Acked-by: Philippe Cornu
Reviewed-by: Philippe
: Yannick Fertre
---
drivers/gpu/drm/stm/ltdc.c | 196 ++---
drivers/gpu/drm/stm/ltdc.h | 5 +-
2 files changed, 145 insertions(+), 56 deletions(-)
Hi Yannick,
many thanks for your patch.
Nice hw feature.
Acked-by: Philippe Cornu
Reviewed-by: Philippe Cornu
+++---
drivers/gpu/drm/stm/ltdc.h | 1 +
2 files changed, 24 insertions(+), 3 deletions(-)
Hi Yannick,
many thanks for your patch.
Acked-by: Philippe Cornu
Reviewed-by: Philippe Cornu
Philippe :-)
, 44 insertions(+), 1 deletion(-)
Hi Yannick,
many thanks for your patch.
Acked-by: Philippe Cornu
Reviewed-by: Philippe Cornu
Philippe :-)
(-)
Hi Yannick,
many thanks for your patch.
Acked-by: Philippe Cornu
Reviewed-by: Philippe Cornu
Philippe :-)
/* bus width (32 or 64 bits) */
const u32 *pix_fmt_hw; /* supported pixel formats */
bool non_alpha_only_l1; /* non-native no-alpha formats on layer 1 */
Hi Yannick,
This looks great, many thanks for your patch.
Acked-by: Philippe Cornu
Philippe :-)
;
+ ret = drm_aperture_remove_framebuffers(false, &drv_driver);
+ if (ret)
+ return ret;
+
Hi Yannick,
and many thanks for your patch.
Acked-by: Philippe Cornu
Philippe :-)
dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
ddev = drm_dev_alloc(&drv_driver, dev);
On 9/7/21 5:15 PM, Raphael Gallais-Pou wrote:
Android Hardware Composer supports alpha values applied to layers.
Enabling non-opaque layers for the STM CRTC could help offload GPU
resources for screen composition.
Signed-off-by: Raphael Gallais-Pou
Acked-by: Yannick Fertre
Reviewed-by: Yann
On 9/7/21 5:13 PM, Raphael Gallais-Pou wrote:
Defines plane ordering by hard-coding an immutable Z position from the
first plane, used as primary layer, to the next ones as overlay in order
of instantiation.
This zpos is only an information as it is not possible to modify it,
blending operati
M64)
Reviewed-by: Philippe Cornu
Many thanks for your patch,
Philippe :-)
COMPILE_TEST is selected.
Signed-off-by: Laurent Pinchart
---
drivers/gpu/drm/sti/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kcon
d+%d+%d+%d != %zu)\n",
Hi Laurent,
Looping Benjamin (new email address) and Alain (future maintainer of
drm/sti).
Reviewed-by: Philippe Cornu
Many thanks for your patch,
Philippe :-)
sizeof(*header), header->rd_size, header->wr_size,
On 7/13/21 6:47 PM, Philippe CORNU wrote:
Hi Antonio,
On 7/13/21 4:49 PM, Antonio Borneo wrote:
The driver uses a conservative set of hardcoded values for the
maximum time delay of the transitions between LP and HS, either
for data and clock lanes.
By using the info in STM32MP157 datasheet
On 7/13/21 6:43 PM, Philippe CORNU wrote:
Hi Jagan,
On 7/4/21 3:59 PM, Jagan Teki wrote:
As dw-mipi-dsi supported all possible ways to find the DSI
devices. It can take multiple iterations for ltdc to find
all components attached to the DSI bridge.
The current ltdc driver failed to find
actual delay from the lane's bps.
Signed-off-by: Antonio Borneo
---
To: Yannick Fertre
To: Philippe Cornu
To: Benjamin Gaignard
To: David Airlie
To: Daniel Vetter
To: Maxime Coquelin
To: Alexandre Torgue
To: Raphael Gallais-Pou
To: dri-devel@lists.freedesktop.org
To: linux-st...@
DEFER)
+ drm_encoder_cleanup(encoder);
Many thanks for your patch.
This means that we are counting on the future success of the deferred
probe because we do not clean the encoder...
However, Yannick gave his "Tested-by" and this patch seems useful so
Acked-by: Philippe Cornu
I will merge it
+++ b/MAINTAINERS
@@ -6165,6 +6165,7 @@ DRM DRIVERS FOR STM
M:Yannick Fertre
M:Philippe Cornu
M:Benjamin Gaignard
+M: Raphael Gallais-Pou
Hi Raphaël,
Warm welcome on board!
Reviewed-by: Philippe Cornu
Note: you may have to wait and resend your patch as Benjamin sent
ul Cercueil
Cc: Pekka Paalanen
Cc: Pengutronix Kernel Team
Cc: Philippe Cornu
Cc: Philipp Zabel
Cc: Qiang Yu
Cc: Rob Clark
Cc: Robert Foss
Cc: Rob Herring
Cc: Rodrigo Siqueira
Cc: Rodrigo Vivi
Cc: Roland Scheidegger
Cc: Russell King
Cc: Sam Ravnborg
Cc: Sandy Huang
Cc: Sascha Hauer
C
, the calculations
required for the LTDC IP are different than what is used in the
drm_display_mode_to_videomode(), so just do the right ones in the LTDC
driver right away.
Signed-off-by: Marek Vasut
Cc: Alexandre Torgue
Cc: Antonio Borneo
Cc: Benjamin Gaignard
Cc: Maxime Coquelin
Cc: Philippe
Hi Marek,
Many thanks for your patch and sorry for the delay regarding this "last
Christmas" patch (Dec. 24, 2020), lost in my inbox :(
Could you please resend it (as I did not succeed to apply it directly)?
patchwork reference
https://patchwork.freedesktop.org/patch/409968/?series=85222
M
-Kuang Hu
Cc: Matthias Brugger
Cc: Neil Armstrong
Cc: Kevin Hilman
Cc: Jerome Brunet
Cc: Martin Blumenstingl
Cc: Marek Vasut
Cc: Stefan Agner
Cc: Sandy Huang
Cc: "Heiko Stübner"
Cc: Yannick Fertre
Cc: Philippe Cornu
For stm
Acked-by: Philippe Cornu
Many thanks
Philippe :-)
Cc
Hi Daniel,
Many thanks for your patch,
Acked-by: Philippe Cornu
Philippe :-)
De : Daniel Vetter
Envoyé : mardi 27 avril 2021 11:20
À : DRI Development
Cc : Intel Graphics Development; Daniel Vetter; Daniel Vetter; Yannick FERTRE -
foss; Philippe CORNU
el GALLAIS-POU - foss; Yannick FERTRE; Philippe CORNU; Benjamin
Gaignard; Vincent ABRIOU; Sam Ravnborg; Joe Perches
Cc : David Airlie; Daniel Vetter; Maxime Coquelin; Alexandre TORGUE;
dri-devel@lists.freedesktop.org; linux-st...@st-md-mailman.stormreply.com;
linux-arm-ker...@lists.infradead.
gan Teki; Yannick FERTRE; Philippe CORNU; Benjamin
Gaignard; Vincent ABRIOU
Cc : dri-devel@lists.freedesktop.org; linux-amar...@amarulasolutions.com;
linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
linux-st...@st-md-mailman.stormreply.com
Objet : Re: [Linux-stm32] [PATCH] drm/s
; Benjamin Gaignard ; Maxime
Coquelin ; Philippe CORNU ;
Sam Ravnborg ; Vincent ABRIOU ;
linux-arm-ker...@lists.infradead.org; linux-st...@st-md-mailman.stormreply.com
Subject: [PATCH V4] drm/stm: Fix bus_flags handling
The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW or
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 -
> drivers/gpu/drm/stm/ltdc.c| 1 -
For the stm part,
Reviewed-by: Philippe Cornu
Thank you
Philippe :-)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
lienne
> Cc: Florian Fainelli
> Cc: Ray Jui
> Cc: Scott Branden
> Cc: bcm-kernel-feedback-l...@broadcom.com
> Cc: Maxime Coquelin
> Cc: Alexandre Torgue
> Cc: "Guido Gúnther"
> Cc: Robert Chiras
> Cc: Philippe Cornu
Hi Rob,
and many thanks for the patch.
dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct
> drm_display_mode *mode,
>
> /* Select the color coding */
> dsi_update_bits(dsi, DSI_WCFGR, WCFGR_COLMUX,
> - dsi_color_from_mipi(format) << 1);
> +
80 + 12 + 5,
> + .vtotal = 1280 + 12 + 5 + 12,
> .flags = 0,
> .width_mm = 68,
> .height_mm = 122,
>
Hi Yannick,
Tested-by: Philippe Cornu
Thank you,
Philippe
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
(*get_timing)(void *priv_data, unsigned int lane_mbps,
> struct dw_mipi_dsi_dphy_timing *timing);
> + int (*get_esc_clk_rate)(void *priv_data, unsigned int *esc_clk_rate);
> };
>
> struct dw_mipi_dsi_host_ops {
>
Hi Neil,
Thank you for the patch
Reviewed-by: Philippe Cornu
Philippe :-)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
VID_MODE_CFG, val);
> }
>
> static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32
> hdr_val)
>
(+ Antonio)
Hi Yannick & Antonio,
Reviewed-by: Philippe Cornu
Tested-by: Philippe Cornu
(Tested with the 3 patches named
drm/bridge/synopsys: dsi: allow LP command
in high speed is enable (PHY_TXREQUESTCLKHS)
> - */
> - dsi_write(dsi, DSI_DPI_LP_CMD_TIM, OUTVACT_LPCMD_TIME(4)
> - | INVACT_LPCMD_TIME(4));
> }
>
> static void dw_mipi_dsi_packet_handler_config(struct dw_mipi_dsi *dsi)
>
(+ Antonio)
Hi Yannick &a
dsi_write(dsi, DSI_MODE_CFG, ENABLE_CMD_MODE);
> }
>
> + val = PHY_TXREQUESTCLKHS;
> + if (dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS)
> + val |= AUTO_CLKLANE_CTRL;
> + dsi_write(dsi, DSI_LPCLK_CTRL, val);
> +
> dsi_write(
On 7/8/20 7:08 PM, Angelo Ribeiro wrote:
> Hi,
>
> Is this patch good to go?
> @dan...@ffwll.ch, @Philippe CORNU
>
> Was already tested by @Yannick FERTRE
> and @Adrian Pop
> on https://lkml.org/lkml/2020/4/6/691 .
>
> Thanks,
> Angelo
>
> From: Yannick
: 35ab6cfbf211 ("drm/stm: support runtime power management")
> Signed-off-by: Marek Vasut
> Cc: Yannick Fertré
> Cc: Philippe Cornu
> Cc: Benjamin Gaignard
> Cc: Vincent Abriou
> Cc: Maxime Coquelin
> Cc: Alexandre Torgue
> To: dri-devel@lists.freedesktop.org
t; - if (ret) {
> - DRM_ERROR("Failed to fixup mode, cannot get sync\n");
> - return false;
> - }
> - }
> -
> DRM_DEBUG_DRIVER("requested clock %dkHz, adjusted clock %dkHz\n",
>mode->clock, adju
not "break" your use case (Qt I think)?
May I ask you please to give it a try?
Note: If you think there is no need to do extra checks, simply tell me
of course
Philippe :-)
>
>>
>>>Best regards
>>>
>>> Yannick Fertré
>>&g
Hi Adrian,
and thank you very much for the patchset.
Thank you also for having tested it on STM32F769 and STM32MP1.
Sorry for the late response, Yannick and I will review it as soon as
possible and we will keep you posted.
Note: Do not hesitate to put us in copy for the next version
(philippe.co.
eate),
> };
>
> static int drv_load(struct drm_device *ddev)
>
Hi Thomas,
Thank you for the patch.
Reviewed-by: Philippe Cornu
Philippe :-)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Dear Yannick,
Thank you for your patch,
Acked-by: Philippe Cornu
(sorry for the email format)
Philippe :-)
-Original Message-
From: Yannick FERTRE
Sent: Friday, February 28, 2020 09:08
To: Yannick FERTRE ; Philippe CORNU
; Benjamin GAIGNARD ; David
Airlie ; Daniel Vetter ; Maxime
Hi Daniel,
On 2/19/20 11:21 AM, Daniel Vetter wrote:
> It's right above the drm_dev_put().
>
> Aside: Another driver with a bit much devm_kzalloc, which should
> probably use drmm_kzalloc instead ...
>
> Signed-off-by: Daniel Vetter
> Cc: Yannick Fertre
> Cc: P
Hi Benjamin,
and many thanks for this serie.
Regarding this patch:
Reviewed-by: Philippe Cornu
Philippe :-)
On 2/6/20 2:33 PM, Benjamin Gaignard wrote:
> From: Sam Ravnborg
>
> To complement panel-simple.yaml, create panel-simple-dsi.yaml.
> panel-simple-dsi-yaml are for all simpl
..6e6ac995c27b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/
AML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/raydium,rm68200.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Raydium Semiconductor Corporation RM68200 5.5" 720p MIPI-DSI TFT LCD
> panel
> +
> +maintainers:
> + - Philippe C
errupts:
>>> + maxItems: 1
>>> +
>>> + clocks:
>>> +items:
>>> + - description: AXI/master interface clock
>>> + - description: GPU core clock
>>> + - description: Shader clock (only required if GPU has feature
&
Dear Thomas,
Thank you for your patch,
For this stm part,
Acked-by: Philippe Cornu
Philippe :-)
On 1/23/20 2:59 PM, Thomas Zimmermann wrote:
> The callback struct drm_driver.get_scanout_position() is deprecated in
> favor of struct drm_crtc_helper_funcs.get_scanout_position(). Conve
Dear Thomas,
Thank you for your patch,
For this stm part,
Acked-by: Philippe Cornu
Philippe :-)
On 1/23/20 2:59 PM, Thomas Zimmermann wrote:
> VBLANK callbacks in struct drm_driver are deprecated in favor of
> their equivalents in struct drm_crtc_funcs. Convert stm over.
>
> S
Dear Yannick,
Thank you for your patch,
Acked-by: Philippe Cornu
Philippe :-)
On 1/21/20 11:13 AM, Yannick Fertre wrote:
> The number of interrupts depends on the ltdc version.
> Don't try to get interrupt which not exist, avoiding
> kernel warning messages.
>
> Signed-of
Dear Yannick,
Thank you for your patch,
Acked-by: Philippe Cornu
Philippe :-)
On 1/20/20 2:46 PM, Yannick Fertre wrote:
> From: Yannick Fertré
>
> When connected to a dsi host, the ltdc display controller
> must send frames only after the end of the dsi panel
> initialization
Dear Yannick,
Thank you for your patch,
Acked-by: Philippe Cornu
Philippe :-)
On 1/21/20 11:14 AM, Yannick Fertre wrote:
> Number of endpoints could exceed the fix value MAX_ENDPOINTS(2).
> Instead of increase simply this value, the number of endpoint
> could be read from device t
Dear Yannick,
Thank you for your patch,
Acked-by: Philippe Cornu
Philippe :-)
On 1/21/20 11:14 AM, Yannick Fertre wrote:
> Following investigations of a hardware bug, the LIE interrupt
> can occur while the display controller is not activated.
> LIE interrupt (vblank) don't hav
Dear Yannick,
Thank you for your patch,
Reviewed-by: Philippe Cornu
Philippe :-)
On 1/21/20 11:24 AM, Yannick Fertre wrote:
> From: Yannick Fertré
>
> Sometime the post_disable function is missing (not registered).
>
> Signed-off-by: Yannick Fertré
> ---
> drivers/gp
Dears Yannick & Etienne,
Thank you for your patch,
Reviewed-by: Philippe Cornu
Philippe :-)
On 1/21/20 11:24 AM, Yannick Fertre wrote:
> From: Etienne Carriere
>
> Change DSI driver to not print an error trace when probe
> is deferred for a clock resource.
>
>
Hi Adrian,
And sorry for this late reply.
Your patches look good and we ("stm guys") understand that v1.01 is very
different to v1.30/31.
We are doing our best to review & test your patches and we will go back
to you asap.
Many thanks,
Philippe :-)
On 12/2/19 8:33 PM, Adrian Ratiu wrote:
> Ha
Dear Yannick,
Thank you for your patch,
Acked-by: Philippe Cornu
Philippe :-)
On 11/27/19 11:23 AM, Yannick Fertre wrote:
> From: Yannick Fertré
>
> The pin control must be set to default as soon as possible to
> establish a good video link between tv & bridge hdmi
> (
_phy_ops *phy_ops = dsi->plat_data->phy_ops;
>
> /* Switch to video mode for panel-bridge enable & panel enable */
> dw_mipi_dsi_set_mode(dsi, MIPI_DSI_MODE_VIDEO);
> if (dsi->slave)
> dw_mipi_dsi_set_mode(dsi->slave, MIPI_DSI_MODE_VIDEO);
&g
Hi Lucas & Ahmad,
Many thanks for your patch,
Tested successfully on stm32mp157-dk2 (weston & drm).
Acked-by: Philippe Cornu
Tested-by: Philippe Cornu
Philippe :-)
On 7/12/19 10:42 AM, Lucas Stach wrote:
> From: Ahmad Fatoum
>
> To properly synchronize with other devic
Hi Daniel,
On 7/10/19 5:27 PM, Daniel Vetter wrote:
> On Fri, Jul 05, 2019 at 12:41:03PM +0000, Philippe CORNU wrote:
>> Hi Olivier,
>> and many thanks for your patch.
>> Good to have the audio graph card support, looks ok.
>> Reviewed-by: Philippe Cornu
>
&g
Hi Olivier,
and many thanks for your patch.
Good to have the audio graph card support, looks ok.
Reviewed-by: Philippe Cornu
Philippe :-)
On 7/3/19 10:04 AM, Olivier Moysan wrote:
> Implement get_dai_id callback of audio HDMI codec
> to support ASoC audio graph card.
> HDMI audio outp
Hi Olivier,
and many thanks for your patch.
Reviewed-by: Philippe Cornu
Philippe :-)
On 7/2/19 5:47 PM, Olivier Moysan wrote:
> The master clock on i2s bus is not mandatory,
> as sii902X internal PLL can be used instead.
> Make use of mclk optional.
>
> Fixes: ff5781634c
1 - 100 of 427 matches
Mail list logo