Hi Richard, see inline comment.
Den fre 8 apr. 2022 21:05Richard Gong skrev:
> Active State Power Management (ASPM) feature is enabled since kernel 5.14.
> There are some AMD GFX cards (such as WX3200 and RX640) that cannot be
> used with Intel AlderLake based systems to enable ASPM. Using these
Hi,
This patch applies cleanly for me on top of the first patch in this series
[1] on top of your drm-next-4.8 tree.
The series was held up to figure out what to do about the unused functions
as patch 1 introduced warnings. I can still respin if you'd like as now
that i know the functions should
Ok, cool. I will probably be able to do that on monday.
Nils
Den 15 juli 2016 11:06 em skrev "Alex Deucher" :
> On Fri, Jul 15, 2016 at 4:09 PM, Nils Wallménius
> wrote:
> > Ping?
>
> We don't seem to be using them. Can you respin? It doesn't seem to
> apply any longer.
>
> Alex
>
>
> >
> >
Ping?
Den 6 juni 2016 21:32 skrev "Nils Wallménius" :
> Hi Alex,
>
> Any response from the powerplay team?
>
> If they are unresponsive, would you prefer to #IF 0 the code instead of
> deleting?
>
> Regards
> Nils
>
> On Mon, Apr 25, 2016 at 10:08 PM, Alex Deucher
> wrote:
>
>> On Sun, Apr 24,
Hi Alex,
Any response from the powerplay team?
If they are unresponsive, would you prefer to #IF 0 the code instead of
deleting?
Regards
Nils
On Mon, Apr 25, 2016 at 10:08 PM, Alex Deucher
wrote:
> On Sun, Apr 24, 2016 at 7:22 AM, Nils Wallménius
> wrote:
> > Signed-off-by: Nils Wallménius
Hi, Chris
See comment below
BR
Nils
On 27 May 2016 7:01 a.m., "Chris Wilson" wrote:
>
> In order to allow drivers to pack their privates and drm_device into one
> struct (e.g. for subclassing), export the initialisation routines for
> struct drm_device.
>
> Signed-off-by: Chris Wilson
> Cc: Dan
Hi Eric,
A little nitpick below.
Regards
Nils
On Fri, May 13, 2016 at 8:48 PM, Alex Deucher wrote:
> From: Eric Huang
>
> Add a new sysfs entry pp_sclk_od to support sclk overdrive(OD)
> overclocking,
> the entry is read/write, the value of input/output is an integer which is
> the
> over per
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 6 ++
drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c | 6 +++---
drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 6 +++---
3 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu
a / (1 << b) is equivalent to a >> b for unsigned values
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 2 +-
drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 7 +--
drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c | 2 +-
drivers/gpu/
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 3 +--
drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 3 +--
drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c | 3 +--
drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 3 +--
4 files changed, 4 insert
Replacing magic numbers in calculation of sleep divider id for fiji
and polaris.
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c | 3 ++-
drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
di
Some more tables with constant data were added with the polaris support
v2: missed a few
Signed-off-by: Nils Wallménius
---
.../gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 32 --
.../gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.h | 2 +-
.../drm/amd/powerplay/hwmgr/po
Some more tables with constant data were added with the polaris support
Signed-off-by: Nils Wallménius
---
.../gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 32 --
.../gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.h | 2 +-
.../drm/amd/powerplay/hwmgr/polaris10_powertune.
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/powerplay/hwmgr/ppevvmath.h | 59 +
1 file changed, 1 insertion(+), 58 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/ppevvmath.h
b/drivers/gpu/drm/amd/powerplay/hwmgr/ppevvmath.h
index a9b40eb..8f50a
This introduces some warnings due to unused functions, that are
deleted in the following commit.
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/powerplay/hwmgr/ppevvmath.h | 128
1 file changed, 64 insertions(+), 64 deletions(-)
diff --git a/drivers/gpu/drm/amd
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/powerplay/hwmgr/cz_clockpowergating.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_clockpowergating.h
b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_clockpowergating.h
index 35e1b36..1954cea 100644
---
These tables were initialized on stack on each call, avoid that
and save a little bit of text size.
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 +-
drivers/gpu/drm/amd/powerplay/hwmgr/ppevvmath.h
Also adjust phm_construct_table to take a const pointer
Signed-off-by: Nils Wallménius
---
.../drm/amd/powerplay/hwmgr/cz_clockpowergating.c| 4 ++--
.../drm/amd/powerplay/hwmgr/cz_clockpowergating.h| 2 +-
drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 20 ++--
As these arrays were of pointer to pointer type, they were
pointer to pointer to const. Make them pointer to const
pointer to const.
Signed-off-by: Nils Wallménius
---
.../drm/amd/powerplay/eventmgr/eventactionchains.c | 34 +++---
.../drm/amd/powerplay/eventmgr/eventmanagement.
All these are compile time constand and the
drm_debugfs_create/remove_files functions take a const
pointer argument.
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_fen
This marks the struct amdgpu_sched_ops const and
adjusts amd_sched_init to take a const pointer
for the ops param. The ops member of
struct amd_gpu_scheduler is also changed to const.
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
drivers/gpu/drm/amd/am
This patch marks some compile-time constant tables 'const'.
The tables marked in this patch are the low hanging fruit
where little other changes were necesary to avoid casting
away constness etc. Also mark some tables that are private
to a file as static.
Signed-off-by: Nils Wallménius
---
driv
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/cik.c | 2 +-
drivers/gpu/drm/amd/amdgpu/vi.c | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/cik.c b/drivers/gpu/drm/amd/amdgpu/cik.c
index 5da14a3..9152e71 100644
--- a/dr
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/radeon/radeon_mode.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_mode.h
b/drivers/gpu/drm/radeon/radeon_mode.h
index bb75201a..b0060f4 100644
--- a/drivers/gpu/drm/radeon/radeon_mode.h
+++ b/drivers/gpu/d
Clean up some set-but-not-read members and one unused member.
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 5 -
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 6 --
2 files changed, 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atom
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 16
drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 26 --
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 26 --
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 26 ---
It is only used locally in amdgpu_get_bios
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 8
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/radeon/radeon.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h
index 007be29..7bb966d 100644
--- a/drivers/gpu/drm/radeon/radeon.h
+++ b/drivers/gpu/drm/radeon/radeon.h
@@ -23
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index c28b23c..00dade8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/a
Clean up leftover from radeon code.
Signed-off-by: Nils Wallménius
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -
drivers/gpu/drm/amd/amdgpu/cik.c| 2 --
drivers/gpu/drm/amd/amdgpu/vi.c | 4
3 files changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/driver
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -
drivers/gpu/drm/amd/amdgpu/cik.c| 2 --
drivers/gpu/drm/amd/amdgpu/vi.c | 4
3 files changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 0c42a85..cfd35b0 100644
--- a/driv
Hi!
First time sending a patch to the list.
This patch deletes a set-but-not-read member from the amdgpu_device
struct but I'm not sure the correct thing is to delete it. Maybe it
should be checked some where?
BR
Nils
Nils Wallménius (1):
drm/amdgpu: delete set-but-not-read member has_uvd f
>@@ -582,11 +588,17 @@ int evergreen_blit_init(struct radeon_device *rdev)
> obj_size = ALIGN(obj_size, 256);
>
> rdev->r600_blit.vs_offset = obj_size;
>- obj_size += evergreen_vs_size * 4;
>+ if (rdev->family < CHIP_CAYMAN)
>+ obj_size += evergreen_vs_size * 4;
>
>@@ -582,11 +588,17 @@ int evergreen_blit_init(struct radeon_device *rdev)
> obj_size = ALIGN(obj_size, 256);
>
> rdev->r600_blit.vs_offset = obj_size;
>- obj_size += evergreen_vs_size * 4;
>+ if (rdev->family < CHIP_CAYMAN)
>+ obj_size += evergreen_vs_size * 4;
>
34 matches
Mail list logo
