Re: [PATCH 3/9] drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw

2025-07-30 Thread Nilawar, Badal
On 26-07-2025 03:08, Lucas De Marchi wrote: On Thu, Jul 10, 2025 at 11:08:34AM -0400, Rodrigo Vivi wrote: From: Badal Nilawar Introducing xe_late_bind_fw to enable firmware loading for the devices, here and in the subject: no gerund, please. Sure. such as the fan controller, during the

Re: [PATCH v6 02/10] mei: late_bind: add late binding component driver

2025-07-04 Thread Nilawar, Badal
On 04-07-2025 17:59, Greg KH wrote: On Fri, Jul 04, 2025 at 12:21:42PM +, Gupta, Anshuman wrote: -Original Message- From: Greg KH Sent: Friday, July 4, 2025 5:31 PM To: Nilawar, Badal Cc: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- ker

Re: [PATCH v6 02/10] mei: late_bind: add late binding component driver

2025-07-04 Thread Nilawar, Badal
On 04-07-2025 16:04, Greg KH wrote: On Fri, Jul 04, 2025 at 03:59:40PM +0530, Nilawar, Badal wrote: On 04-07-2025 10:44, Greg KH wrote: On Fri, Jul 04, 2025 at 01:00:58AM +0530, Badal Nilawar wrote: From: Alexander Usyskin Add late binding component driver. It allows pushing the late

Re: [PATCH v6 02/10] mei: late_bind: add late binding component driver

2025-07-04 Thread Nilawar, Badal
On 04-07-2025 10:44, Greg KH wrote: On Fri, Jul 04, 2025 at 01:00:58AM +0530, Badal Nilawar wrote: From: Alexander Usyskin Add late binding component driver. It allows pushing the late binding configuration from, for example, the Xe graphics driver to the Intel discrete graphics card's CSE d

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-07-01 Thread Nilawar, Badal
On 01-07-2025 18:04, Nilawar, Badal wrote: On 01-07-2025 15:15, Greg KH wrote: On Tue, Jul 01, 2025 at 02:02:15PM +0530, Nilawar, Badal wrote: On 28-06-2025 17:48, Greg KH wrote: + * @payload_size: size of the payload data in bytes + * @payload: data to be sent to the firmware + */ +struct

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-07-01 Thread Nilawar, Badal
On 01-07-2025 15:15, Greg KH wrote: On Tue, Jul 01, 2025 at 02:02:15PM +0530, Nilawar, Badal wrote: On 28-06-2025 17:48, Greg KH wrote: + * @payload_size: size of the payload data in bytes + * @payload: data to be sent to the firmware + */ +struct csc_heci_late_bind_req { + struct

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-07-01 Thread Nilawar, Badal
On 28-06-2025 17:48, Greg KH wrote: On Wed, Jun 25, 2025 at 10:30:07PM +0530, Badal Nilawar wrote: --- /dev/null +++ b/drivers/misc/mei/late_bind/mei_late_bind.c @@ -0,0 +1,281 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2025 Intel Corporation + */ +#include +#include +#inc

RE: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-07-01 Thread Nilawar, Badal
> -Original Message- > From: Greg KH > Sent: 01 July 2025 13:48 > To: Nilawar, Badal > Cc: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > ker...@vger.kernel.org; Gupta, Anshuman ; > Vivi, Rodrigo ; Usyskin, Alexander > ; Ceraolo Spur

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-07-01 Thread Nilawar, Badal
On 28-06-2025 17:49, Greg KH wrote: On Wed, Jun 25, 2025 at 10:30:07PM +0530, Badal Nilawar wrote: +/** + * struct late_bind_component_ops - ops for Late Binding services. + * @owner: Module providing the ops + * @push_config: Sends a config to FW. + */ +struct late_bind_component_ops { +

Re: [PATCH v4 03/10] drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw

2025-06-30 Thread Nilawar, Badal
On 28-06-2025 02:34, Rodrigo Vivi wrote: On Wed, Jun 25, 2025 at 10:30:08PM +0530, Badal Nilawar wrote: Introducing xe_late_bind_fw to enable firmware loading for the devices, such as the fan controller, during the driver probe. Typically, firmware for such devices are part of IFWI flash image

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-06-27 Thread Nilawar, Badal
On 26-06-2025 09:20, Gupta, Anshuman wrote: -Original Message- From: Nilawar, Badal Sent: Wednesday, June 25, 2025 10:30 PM To: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- ker...@vger.kernel.org Cc: Gupta, Anshuman ; Vivi, Rodrigo ; Usyskin, Alexander

Re: [PATCH v4 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware

2025-06-27 Thread Nilawar, Badal
On 27-06-2025 02:36, Daniele Ceraolo Spurio wrote: On 6/25/2025 10:00 AM, Badal Nilawar wrote: Search for late binding firmware binaries and populate the meta data of firmware structures. v2 (Daniele):   - drm_err if firmware size is more than max pay load size   - s/request_firmware/firmwa

Re: [PATCH v4 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw during system resume

2025-06-27 Thread Nilawar, Badal
Hi Daniele, On 25-06-2025 22:30, Badal Nilawar wrote: Reload late binding fw during resume from system suspend v2: - Unconditionally reload late binding fw (Rodrigo) - Flush worker during system suspend Cc: Rodrigo Vivi Signed-off-by: Badal Nilawar --- drivers/gpu/drm/xe/xe_pm.c | 4

Re: [PATCH v3 08/10] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding

2025-06-24 Thread Nilawar, Badal
On 23-06-2025 21:07, Daniele Ceraolo Spurio wrote: On 6/18/2025 11:51 PM, Nilawar, Badal wrote: On 19-06-2025 02:49, Daniele Ceraolo Spurio wrote: On 6/18/2025 12:00 PM, Badal Nilawar wrote: Introduce a debug filesystem node to disable late binding fw reload during the system or

Re: [PATCH v3 06/10] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume

2025-06-23 Thread Nilawar, Badal
On 23-06-2025 20:56, Daniele Ceraolo Spurio wrote: On 6/18/2025 10:52 PM, Nilawar, Badal wrote: On 19-06-2025 02:35, Daniele Ceraolo Spurio wrote: On 6/18/2025 12:00 PM, Badal Nilawar wrote: Reload late binding fw during runtime resume. v2: Flush worker during runtime suspend Signed

Re: [PATCH v3 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw in S2Idle/S3 resume

2025-06-20 Thread Nilawar, Badal
On 20-06-2025 19:19, Rodrigo Vivi wrote: On Thu, Jun 19, 2025 at 12:30:04AM +0530, Badal Nilawar wrote: Reload late binding fw during S2Idle/S3 resume. Signed-off-by: Badal Nilawar --- drivers/gpu/drm/xe/xe_pm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_

Re: [PATCH v3 09/10] drm/xe/xe_late_bind_fw: Extract and print version info

2025-06-19 Thread Nilawar, Badal
On 19-06-2025 03:26, Daniele Ceraolo Spurio wrote: On 6/18/2025 12:00 PM, Badal Nilawar wrote: Extract and print version info of the late binding binary. Signed-off-by: Badal Nilawar ---   drivers/gpu/drm/xe/xe_late_bind_fw.c   | 132 -   drivers/gpu/drm/xe/xe_late_b

Re: [PATCH v3 02/10] mei: late_bind: add late binding component driver

2025-06-19 Thread Nilawar, Badal
On 19-06-2025 13:02, Gupta, Anshuman wrote: -Original Message- From: Nilawar, Badal Sent: Thursday, June 19, 2025 12:30 AM To:intel...@lists.freedesktop.org;dri-devel@lists.freedesktop.org; linux- ker...@vger.kernel.org Cc: Gupta, Anshuman; Vivi, Rodrigo ; Usyskin, Alexander; gre

Re: [PATCH v3 08/10] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding

2025-06-18 Thread Nilawar, Badal
On 19-06-2025 02:49, Daniele Ceraolo Spurio wrote: On 6/18/2025 12:00 PM, Badal Nilawar wrote: Introduce a debug filesystem node to disable late binding fw reload during the system or runtime resume. This is intended for situations where the late binding fw needs to be loaded from user mode.

Re: [PATCH v3 06/10] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume

2025-06-18 Thread Nilawar, Badal
On 19-06-2025 02:35, Daniele Ceraolo Spurio wrote: On 6/18/2025 12:00 PM, Badal Nilawar wrote: Reload late binding fw during runtime resume. v2: Flush worker during runtime suspend Signed-off-by: Badal Nilawar ---   drivers/gpu/drm/xe/xe_late_bind_fw.c | 2 +-   drivers/gpu/drm/xe/xe_late_

Re: [PATCH v3 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-06-18 Thread Nilawar, Badal
On 19-06-2025 02:27, Daniele Ceraolo Spurio wrote: On 6/18/2025 12:00 PM, Badal Nilawar wrote: Load late binding firmware v2:   - s/EAGAIN/EBUSY/   - Flush worker in suspend and driver unload (Daniele) v3:   - Use retry interval of 6s, in steps of 200ms, to allow     other OS components rel

Re: [PATCH v3 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware

2025-06-18 Thread Nilawar, Badal
On 19-06-2025 02:16, Daniele Ceraolo Spurio wrote: On 6/18/2025 12:00 PM, Badal Nilawar wrote: Search for late binding firmware binaries and populate the meta data of firmware structures. v2 (Daniele):   - drm_err if firmware size is more than max pay load size   - s/request_firmware/firmwa

Re: [PATCH v2 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-06-17 Thread Nilawar, Badal
Hi Umesh, On 15-06-2025 23:56, Umesh Nerlige Ramappa wrote: Hi Badal, Just a small query below.. On Fri, Jun 06, 2025 at 11:27:02PM +0530, Badal Nilawar wrote: Load late binding firmware v2: - s/EAGAIN/EBUSY/ - Flush worker in suspend and driver unload (Daniele) Signed-off-by: Badal Nilawar

Re: [PATCH v2 02/10] mei: late_bind: add late binding component driver

2025-06-16 Thread Nilawar, Badal
On 14-06-2025 13:32, Gupta, Anshuman wrote: -Original Message- From: Nilawar, Badal Sent: Friday, June 6, 2025 11:27 PM To:intel...@lists.freedesktop.org;dri-devel@lists.freedesktop.org Cc: Gupta, Anshuman; Vivi, Rodrigo ; Usyskin, Alexander; gre...@linuxfoundation.org; Ceraolo Spurio

Re: [PATCH v2 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware

2025-06-12 Thread Nilawar, Badal
On 12-06-2025 16:05, Nilawar, Badal wrote: +static int late_bind_fw_init(struct xe_late_bind *late_bind, u32 type) +{ +    struct xe_device *xe = late_bind_to_xe(late_bind); +    struct pci_dev *pdev = to_pci_dev(xe->drm.dev); +    struct xe_late_bind_fw *lb_fw; +    const struct firmware

Re: [PATCH v2 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-06-12 Thread Nilawar, Badal
On 11-06-2025 05:47, Daniele Ceraolo Spurio wrote: On 6/6/2025 10:57 AM, Badal Nilawar wrote: Load late binding firmware v2:   - s/EAGAIN/EBUSY/   - Flush worker in suspend and driver unload (Daniele) Signed-off-by: Badal Nilawar ---   drivers/gpu/drm/xe/xe_late_bind_fw.c   | 121

Re: [PATCH v2 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-06-12 Thread Nilawar, Badal
On 12-06-2025 17:24, Usyskin, Alexander wrote: Subject: Re: [PATCH v2 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware On 6/6/2025 10:57 AM, Badal Nilawar wrote: Load late binding firmware v2: - s/EAGAIN/EBUSY/ - Flush worker in suspend and driver unload (Daniele) Signed-of

Re: [PATCH v2 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware

2025-06-12 Thread Nilawar, Badal
On 11-06-2025 05:36, Daniele Ceraolo Spurio wrote: On 6/6/2025 10:57 AM, Badal Nilawar wrote: Search for late binding firmware binaries and populate the meta data of firmware structures. v2:   - drm_err if firmware size is more than max pay load size (Daniele)   - s/request_firmware/firmwar

Re: [RFC 9/9] {fwctl,drm}/xe/pcode: Introduce xe_pcode_fwctl

2025-06-06 Thread Nilawar, Badal
On 08-05-2025 01:19, Rodrigo Vivi wrote: +static int xe_pcode_fwctl_uctx_open(struct fwctl_uctx *uctx) +{ + struct xe_pcode_fwctl_dev *fwctl_dev = + container_of(uctx->fwctl, struct xe_pcode_fwctl_dev, fwctl); + struct xe_device *xe = fwctl_dev->xe; + + xe_pm_runt

Re: [RFC 9/9] {fwctl,drm}/xe/pcode: Introduce xe_pcode_fwctl

2025-06-06 Thread Nilawar, Badal
On 06-05-2025 23:43, Jason Gunthorpe wrote: +/** + * struct fwctl_rpc_xe_pcode - FWCTL Remote Procedure Calls for Xe PCODE + */ +struct fwctl_rpc_xe_pcode { + /** @command: The main Mailbox command */ + __u8 command; + /** @param1: A subcommand or a parameter of the main comman

Re: [RFC 5/9] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-06-03 Thread Nilawar, Badal
On 08-05-2025 05:14, Daniele Ceraolo Spurio wrote: On 4/29/2025 9:09 AM, Badal Nilawar wrote: Load late binding firmware Signed-off-by: Badal Nilawar ---   drivers/gpu/drm/xe/xe_device.c   |  2 +   drivers/gpu/drm/xe/xe_late_bind_fw.c | 91 +++-   drivers/gpu/drm

Re: [RFC 4/9] drm/xe/xe_late_bind_fw: Initialize late binding firmware

2025-06-03 Thread Nilawar, Badal
On 08-05-2025 04:41, Daniele Ceraolo Spurio wrote: On 4/29/2025 9:09 AM, Badal Nilawar wrote: Search for late binding firmware binaries and populate the meta data of firmware structures. Signed-off-by: Badal Nilawar ---   drivers/gpu/drm/xe/xe_device.c   |   2 +   drivers/gpu/drm/xe/xe

Re: [RFC 3/9] drm/xe/late_bind_fw: Introducing late_bind_fw

2025-06-03 Thread Nilawar, Badal
On 08-05-2025 03:08, Daniele Ceraolo Spurio wrote: On 4/29/2025 9:09 AM, Badal Nilawar wrote: Introducing late_bind_fw to enable firmware loading for the devices, such as the fan controller and voltage regulator, during the driver probe. Typically, firmware for these devices are part of IFW

Re: [RFC 2/9] mei: late_bind: add late binding component driver

2025-06-03 Thread Nilawar, Badal
On 08-05-2025 11:11, Usyskin, Alexander wrote: diff --git a/include/drm/intel/xe_late_bind_mei_interface.h b/include/drm/intel/xe_late_bind_mei_interface.h new file mode 100644 index ..4005c4c6184f --- /dev/null +++ b/include/drm/intel/xe_late_bind_mei_interface.h @@ -0,0 +1,49

Re: [PATCH 2/4] drm/xe: Mark GGTT work queue with WQ_MEM_RECLAIM

2024-10-21 Thread Nilawar, Badal
On 21-10-2024 23:27, Matthew Brost wrote: GGTT work queue is used to free memory thus we should allow this work queue to run during reclaim. Mark with GGTT work queue with WQ_MEM_RECLAIM appropriately. Signed-off-by: Matthew Brost --- drivers/gpu/drm/xe/xe_ggtt.c | 2 +- 1 file changed, 1

Re: [PATCH 3/4] drm/xe: Mark G2H work queue with WQ_MEM_RECLAIM

2024-10-21 Thread Nilawar, Badal
On 22-10-2024 10:36, Ghimiray, Himal Prasad wrote: On 21-10-2024 23:27, Matthew Brost wrote: G2H work queue can be used to free memory thus we should allow this work queue to run during reclaim. Mark with G2H work queue with WQ_MEM_RECLAIM appropriately. Signed-off-by: Matthew Brost ---  

Re: [PATCH 4/4] drm/xe: Mark GT work queue with WQ_MEM_RECLAIM

2024-10-21 Thread Nilawar, Badal
On 21-10-2024 23:27, Matthew Brost wrote: GT ordered work queue can be used to free memory via resets and fence signaling thus we should allow this work queue to run during reclaim. Mark with GT ordered work queue with WQ_MEM_RECLAIM appropriately. Signed-off-by: Matthew Brost --- drivers/

Re: [PATCH v7] drm/i915/hwmon: expose fan speed

2024-08-27 Thread Nilawar, Badal
On 23-08-2024 09:15, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1:

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-14 Thread Nilawar, Badal
Hi Andi, On 09-08-2024 15:46, Andi Shyti wrote: Hi Badal, +static int +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) +{ + struct i915_hwmon *hwmon = ddat->hwmon; + struct hwm_fan_info *fi = &ddat->fi; + u32 reg_val, pulses, time, time_now; + intel_wakere

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Nilawar, Badal
On 09-08-2024 11:45, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1:

Re: [PATCH v1] drm/i915/hwmon: expose fan speed

2024-07-24 Thread Nilawar, Badal
On 12-07-2024 17:53, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1:

Re: [PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-24 Thread Nilawar, Badal
On 24-04-2024 08:42, Aravind Iddamsetty wrote: On 23/04/24 20:34, Nilawar, Badal wrote: On 22-04-2024 12:27, Aravind Iddamsetty wrote: PCI subsystem provides callbacks to inform the driver about a request to do function level reset by user, initiated by writing to sysfs entry /sys/bus

Re: [PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-23 Thread Nilawar, Badal
On 22-04-2024 12:27, Aravind Iddamsetty wrote: PCI subsystem provides callbacks to inform the driver about a request to do function level reset by user, initiated by writing to sysfs entry /sys/bus/pci/devices/.../reset. This will allow the driver to handle FLR without the need to do unbind an

Re: [PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160

2024-02-26 Thread Nilawar, Badal
Hi John, On 04-01-2024 23:35, john.c.harri...@intel.com wrote: From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14019159160 itself. Signed-off-by: John Harr

Re: [PATCH] drm/i915/hwmon: Accept writes of value 0 to power1_max_interval

2023-03-01 Thread Nilawar, Badal
On 28-02-2023 10:13, Ashutosh Dixit wrote: The value shown by power1_max_interval in millisec is essentially: ((1.x * power(2,y)) * 1000) >> 10 Where x and y are read from a HW register. On ATSM, x and y are 0 on power-up so the value shown is 0. Writes of 0 to power1_max_interval had

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Apply Wa_14017073508 for MTL SoC Step

2023-02-28 Thread Nilawar, Badal
Hi Matt, On 24-02-2023 02:43, Matt Roper wrote: On Thu, Feb 23, 2023 at 03:20:28PM -0500, Rodrigo Vivi wrote: On Fri, Feb 24, 2023 at 12:11:40AM +0530, Badal Nilawar wrote: Apply Wa_14017073508 for MTL SoC die A step instead of graphics step. To get the SoC die stepping there is no direct inte

Re: [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-18 Thread Nilawar, Badal
On 19-11-2022 00:07, Vivi, Rodrigo wrote: On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: From: Vinay Belgaumkar By defaut idle messaging is disabled for GSC CS so to unblock RC6 entry on media tile idle messaging need to be enabled. v2:  - Fix review comments (Vinay)  - Set GSC

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-17 Thread Nilawar, Badal
On 18-11-2022 03:44, Rodrigo Vivi wrote: On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote: From: Vinay Belgaumkar By defaut idle mesaging is disabled for GSC CS so to unblock RC6 entry on media tile idle messaging need to be enabled. v2: - Fix review comments (Vinay) - Set

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-16 Thread Nilawar, Badal
Hi Rodrigo, On 15-11-2022 20:57, Rodrigo Vivi wrote: On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote: From: Vinay Belgaumkar By defaut idle mesaging is disabled for GSC CS so to unblock RC6 entry on media tile idle messaging need to be enabled. v2: - Fix review comments (Vina

Re: [PATCH] drm/i915/mtl: Add MC6 Wa_14017210380 for SAMedia

2022-11-01 Thread Nilawar, Badal
Hi Matt, On 01-11-2022 20:47, Matt Roper wrote: On Sat, Oct 29, 2022 at 12:59:35AM +0530, Badal Nilawar wrote: This workaround is added for Media Tile of MTL A step. It is to help pcode workaround which handles the hardware bug seen on CXL splitter during package C2/C3 transitins due to MC6 e

Re: [PATCH] drm/i915/mtl: Add MC6 Wa_14017210380 for SAMedia

2022-10-31 Thread Nilawar, Badal
Hi Rodrigo, On 31-10-2022 15:19, Rodrigo Vivi wrote: On Sat, Oct 29, 2022 at 12:59:35AM +0530, Badal Nilawar wrote: This workaround is added for Media Tile of MTL A step. It is to help pcode workaround which handles the hardware bug seen on CXL splitter during package C2/C3 transitins due to MC

Re: [PATCH 0/7] Add HWMON support

2022-09-26 Thread Nilawar, Badal
On 27-09-2022 02:39, Guenter Roeck wrote: On 9/26/22 10:52, Badal Nilawar wrote: This series adds the HWMON support for DGFX Test-with: 20220919144408.251981-1-riana.ta...@intel.com v2:    - Reorganized series. Created first patch as infrastructure patch followed by feature patches. (A

Re: [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-21 Thread Nilawar, Badal
On 21-09-2022 18:14, Andi Shyti wrote: Hi Badal, +struct hwm_reg { +}; + +struct hwm_drvdata { + struct i915_hwmon *hwmon; + struct intel_uncore *uncore; + struct device *hwmon_dev; + char name[12]; +}; + +struct i915_hwmon { + struct hwm_drvdata ddat; + s

Re: [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-21 Thread Nilawar, Badal
On 21-09-2022 17:15, Gupta, Anshuman wrote: On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2:    - Fix review comments (Ashutosh)    - Do not restore power1_max upon module unload/load sequence

Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Modify CAGF functions for MTL

2022-09-19 Thread Nilawar, Badal
On 19-09-2022 22:19, Andi Shyti wrote: Hi Badal, On Mon, Sep 19, 2022 at 05:29:05PM +0530, Badal Nilawar wrote: Updated the CAGF functions to get actual resolved frequency of 3D and SAMedia can you please use the imperative form? "Update" and not "Updated". Ok. Besides I don't really un

Re: [PATCH 0/7] drm/i915: Add HWMON support

2022-09-19 Thread Nilawar, Badal
On 19-09-2022 15:45, Gupta, Anshuman wrote: -Original Message- From: Nilawar, Badal Sent: Friday, September 16, 2022 8:31 PM To: intel-...@lists.freedesktop.org Cc: Dixit, Ashutosh ; Tauro, Riana ; Gupta, Anshuman ; Ewins, Jon ; linux-hw...@vger.kernel.org; dri- de

Re: [PATCH 3/3] drm/i915/guc/slpc: Update boost sysfs hooks for SLPC

2021-10-21 Thread Nilawar, Badal
Please fix code style related warnings and errors from checkpatch result. On 21-10-2021 01:22, Vinay Belgaumkar wrote: Add a helper to sort through the SLPC/RPS cases of get/set methods. Boost frequency will be modified as long as it is within the constraints of RP0 and if it is different from t