On 06-05-2025 23:43, Jason Gunthorpe wrote:
+/** + * struct fwctl_rpc_xe_pcode - FWCTL Remote Procedure Calls for Xe PCODE + */ +struct fwctl_rpc_xe_pcode { + /** @command: The main Mailbox command */ + __u8 command; + /** @param1: A subcommand or a parameter of the main command */ + __u16 param1; + /** @param2: A parameter of a subcommand or a subsubcommand */ + __u16 param2; + /** @data0: The first 32 bits of data. In general data-in as param */ + __u32 data0; + /** @data1: The other 32 bits of data. In general data-out */ + __u32 data1; + /** @pad: Padding the uAPI struct - Must be 0. Not sent to firmware */ + __u8 pad[3]; +};This has implicit padding? Make the padding explicit or use packed..
Thanks for pointing this out, was miss at my end, will go with explicit padding in next version
Regards, Badal
