s to defines in regs folder (Michal W)
>> - Move xe_guc_pagefault_desc to regs folder (Michal W)
>>
>> Bspec: 77412
maybe also mention 59654 here?
>> Signed-off-by: Jonathan Cavitt
>> Reviewed-by: Shuicheng Lin
>> Acked-by: Matthew Brost
>> Cc: Michal
alize names for common header (Matt Brost)
>>>>>
>>>>> v3:
>>>>> - s/Migrate/Move (Michal W)
>>>>> - s/xe_pagefault/xe_gt_pagefault (Michal W)
>>>>> - Create new header file, xe_gt_pagefault_types.h (Michal W)
>>>>&g
Hi Tomasz,
Since we use 'ballooning' concept for GGTT, please include 'GGTT' in the
title to make it more specific
On 31.03.2025 15:21, Tomasz Lis wrote:
> The balloon nodes used to fill areas of GGTT inaccessible for
> a specific VF, were allocaten and inserted into GGTT within
typo
> one func
Hi Tomasz,
This series should be primary sent to the intel-xe as series is xe
specific and it's the only way to get CI results for the xe driver.
Once you dropped the drm_mm patch, the dri-devel is not required.
On 31.03.2025 15:21, Tomasz Lis wrote:
> To support VF Migration, it is necessary to
On 31.03.2025 15:21, Tomasz Lis wrote:
> During post-migration recovery of a VF, it is necessary to update
> GGTT references included in messages which are going to be sent
> to GuC. GuC will start consuming messages after VF KMD will inform
> it about fixups being done; before that, the VF KMD
On 31.03.2025 15:21, Tomasz Lis wrote:
> Some GuC messages are constructed with incrementing dword counter
> rather than referencing specific DWORDs, as described in GuC interface
> specification.
>
> This change introduces the definitions of DWORD numbers for parameters
> which will need to be
please use "drm/xe/vf:" in the subject as this patch is still more VF
oriented, then general SRIOV
On 31.03.2025 15:21, Tomasz Lis wrote:
> We have only one GGTT for all IOV functions, with each VF having assigned
> a range of addresses for its use. After migration, a VF can receive a
> differen
te/Move (Michal W)
>>> - s/xe_pagefault/xe_gt_pagefault (Michal W)
>>> - Create new header file, xe_gt_pagefault_types.h (Michal W)
>>> - Add kernel docs (Michal W)
>>>
>>> v4:
>>> - Fix includes usage (Michal W)
>>> - Reference Bs
te/Move (Michal W)
> - s/xe_pagefault/xe_gt_pagefault (Michal W)
> - Create new header file, xe_gt_pagefault_types.h (Michal W)
> - Add kernel docs (Michal W)
>
> v4:
> - Fix includes usage (Michal W)
> - Reference Bspec (Michal W)
>
> Bspec: 77412
>
keep all tags together
&g
te/Move (Michal W)
> - s/xe_pagefault/xe_gt_pagefault (Michal W)
> - Create new header file, xe_gt_pagefault_types.h (Michal W)
> - Add kernel docs (Michal W)
>
> Signed-off-by: Jonathan Cavitt
> Cc: Michal Wajdeczko
> ---
...
> diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.h
ichal W)
>>> - s/xe_pagefault/xe_gt_pagefault (Michal W)
>>> - Create new header file, xe_gt_pagefault_types.h (Michal W)
>>> - Add kernel docs (Michal W)
>>>
>>> Signed-off-by: Jonathan Cavitt
>>> Cc: Michal Wajdeczko
>>> ---
On 10.03.2025 18:18, Jonathan Cavitt wrote:
> Add additional information to each VM so they can report up to the first
> 50 seen pagefaults. Only failed pagefaults are saved this way, as
> successful pagefaults should recover and not need to be reported to
> userspace.
>
> v2:
> - Free vm afte
On 10.03.2025 18:18, Jonathan Cavitt wrote:
> Migrate the pagefault struct from xe_gt_pagefault.c to the
nit: we use "migrate" verb for different purposes.
maybe here (and in the title) the plain "move" will be better?
> xe_gt_pagefault.h header file, along with the associated enum values.
hm
On 10.03.2025 22:30, Cavitt, Jonathan wrote:
> -Original Message-
> From: Wajdeczko, Michal
> Sent: Monday, March 10, 2025 11:20 AM
> To: Cavitt, Jonathan ;
> intel...@lists.freedesktop.org
> Cc: Gupta, saurabhg ; Zuo, Alex
> ; joonas.lahti...@linux.intel.com; Brost, Matthew
> ; Zha
Hi Maarten,
On 04.02.2025 14:22, Maarten Lankhorst wrote:
> Instead of finding bugs where we may or may not release force_wake, I've
> decided to be inspired by the spinlock guards, and use the same ones to
> do xe_force_wake handling.
You may want to take a look at [1], which was based on [2], t
On 03.02.2025 23:59, Rodrigo Vivi wrote:
> On Tue, Jan 21, 2025 at 09:42:17AM -0500, Rodrigo Vivi wrote:
>> On Sat, Jan 18, 2025 at 06:47:27PM +0100, Michal Wajdeczko wrote:
>>>
>>>
>>> On 17.01.2025 22:57, Vinay Belgaumkar wrote:
>>>> Default SL
On 17.01.2025 22:57, Vinay Belgaumkar wrote:
> Default SLPC power profile is Base(0). Power Saving mode(1)
> has conservative up/down thresholds and is suitable for use with
> apps that typically need to be power efficient.
>
> Selected power profile will be displayed in this format-
>
> $ cat
same as previously, please don't forget to include dri-devel for all drm
level changes
On 23.11.2024 04:13, Tomasz Lis wrote:
> Benefits of drm_mm_for_each_node_safe and drm_mm_for_each_node_in_range
> squished together into one macro.
>
> Signed-off-by: Tomasz Lis
> ---
> include/drm/drm_mm.h
+ dri-devel
On 16.11.2024 03:12, Tomasz Lis wrote:
> Benefits of drm_mm_for_each_node_safe and drm_mm_for_each_node_in_range
> squished together into one macro.
>
> Signed-off-by: Tomasz Lis
> ---
> include/drm/drm_mm.h | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --gi
Hi,
sorry for late comments,
On 30.09.2024 09:38, Raag Jadav wrote:
> Introduce device wedged event, which will notify userspace of wedged
> (hanged/unusable) state of the DRM device through a uevent. This is
> useful especially in cases where the device is no longer operating as
> expected even
On 19.07.2024 17:37, Jocelyn Falempe wrote:
>
>
> On 19/07/2024 17:28, Michal Wajdeczko wrote:
>>
>>
>> On 19.07.2024 14:20, Jocelyn Falempe wrote:
>>> This breaks build if DRM_PANIC is not enabled.
>>> Also add the missing include drm
On 19.07.2024 14:20, Jocelyn Falempe wrote:
> This breaks build if DRM_PANIC is not enabled.
> Also add the missing include drm_crtc_internal.h in drm_panic.c
>
> Fixes: 9f774c42a908 ("drm/panic: Add drm_panic_is_enabled()")
> Signed-off-by: Jocelyn Falempe
> ---
> drivers/gpu/drm/drm_crtc_in
:2 MiB
[drm] , blocks: 1
[drm] order- 0
[drm] free:1 MiB
[drm] , blocks: 1
Fix that by using single drm_printf() per line.
Signed-off-by: Michal Wajdeczko
Cc: Arunpravin Paneer Selvam
---
drivers/gpu/drm/drm_buddy.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions
+ Rodrigo for help
On 03.07.2024 04:36, Stephen Rothwell wrote:
> Hi all,
>
> On Fri, 28 Jun 2024 18:03:39 +0100 Mark Brown wrote:
>>
>> After merging the drm tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> /tmp/next/build/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.
On 28.06.2024 19:03, Mark Brown wrote:
> Hi all,
>
> After merging the drm tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> /tmp/next/build/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c: In function
> 'pf_get_threshold':
> /tmp/next/build/drivers/gpu/drm/xe/xe_gt_srio
On 06.06.2024 19:25, Rodrigo Vivi wrote:
> On Fri, May 24, 2024 at 03:35:18PM +0200, Michal Wajdeczko wrote:
>> There is not need for private release action as there are existing
>> drmm_mm_init() and drmm_mutex_init() helpers that can be used.
>>
>> Signed-off-
On 30.05.2024 20:47, John Harrison wrote:
> On 5/30/2024 00:49, Jani Nikula wrote:
>> On Wed, 29 May 2024, John Harrison wrote:
>>> On 5/28/2024 06:06, Michal Wajdeczko wrote:
>>>> This drm printer wrapper can be used to increase the robustness of
>>>
On 30.05.2024 20:47, John Harrison wrote:
> On 5/30/2024 02:33, Michal Wajdeczko wrote:
>> On 30.05.2024 09:49, Jani Nikula wrote:
>>> On Wed, 29 May 2024, John Harrison wrote:
>>>> On 5/28/2024 06:06, Michal Wajdeczko wrote:
>>>>> This dr
On 30.05.2024 09:49, Jani Nikula wrote:
> On Wed, 29 May 2024, John Harrison wrote:
>> On 5/28/2024 06:06, Michal Wajdeczko wrote:
>>> This drm printer wrapper can be used to increase the robustness of
>>> the captured output generated by any other drm_printer to m
This drm printer wrapper can be used to increase the robustness of
the captured output generated by any other drm_printer to make sure
we didn't lost any intermediate lines of the output by adding line
numbers to each output line. Helpful for capturing some crash data.
Signed-off-by: M
There is not need for private release action as there are existing
drmm_mm_init() and drmm_mutex_init() helpers that can be used.
Signed-off-by: Michal Wajdeczko
Cc: Thomas Hellström
Cc: Rodrigo Vivi
---
drivers/gpu/drm/xe/xe_ggtt.c | 23 +++
1 file changed, 11 insertions
Add drmm_mm_init(), a helper that provides managed allocator cleanup.
The allocator will be cleaned up with the final reference of the DRM
device.
Signed-off-by: Michal Wajdeczko
Cc: Thomas Zimmermann
Cc: Daniel Vetter
---
drivers/gpu/drm/drm_managed.c | 27
Add drmm_mm_init(), a helper that provides managed allocator cleanup,
and start using it in the Xe driver.
Michal Wajdeczko (2):
drm: Add DRM-managed drm_mm_init()
drm/xe: Use drm_device managed mutex/mm init helpers in GGTT
drivers/gpu/drm/drm_managed.c | 27
All drm_device based logging macros, except those related to WARN,
include the [drm] prefix. Fix that.
[ ] :00:00.0: this is a warning
[ ] :00:00.0: drm_WARN_ON(true)
vs
[ ] :00:00.0: [drm] this is a warning
[ ] :00:00.0: [drm] drm_WARN_ON(true)
Signed-off-by: Michal
++
It's already reviewed, but since this touches shared code, extra acks
are still welcomed
On 17.05.2024 18:34, Michal Wajdeczko wrote:
> We already have some drm printk functions that need to duplicate
> a code to get a similar format of the final result, for example:
>
>
With recent introduction of a generic drm dev printk function, we
can now store and use location where drm_dbg_printer was invoked
and output it's symbolic name like we do for all drm debug prints.
Cc: Jani Nikula
Reviewed-by: Jani Nikula
Signed-off-by: Michal Wajdeczko
---
v2: use full
Updated code of drm_dbg_printer() is already printing symbolic
name of the caller like drm_dbg() does.
Reviewed-by: Jani Nikula
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
drivers/gpu/drm/i915/gt/selftest_context.c | 2 +-
2 files changed, 2
it static, keep it simple and use braces (Jani)
Michal Wajdeczko (3):
drm/print: Add generic drm dev printk function
drm/print: Improve drm_dbg_printer
drm/i915: Don't use __func__ as prefix for drm_dbg_printer
drivers/gpu/drm/drm_print.c| 53 --
dr
the
final message like all other existing function do and allows us
to keep the formatting code in one place.
Cc: Jani Nikula
Signed-off-by: Michal Wajdeczko
---
v2: make it static, keep it simple and use braces (Jani)
---
drivers/gpu/drm/drm_print.c | 52 +
1
On 17.05.2024 15:33, Jani Nikula wrote:
> On Fri, 17 May 2024, Michal Wajdeczko wrote:
>> We already have some drm printk functions that need to duplicate
>> a code to get a similar format of the final result, for example:
>>
>> [ ] :00:00.0: [drm:foo] bar
Updated code of drm_dbg_printer() is already printing symbolic
name of the caller like drm_dbg() does.
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
drivers/gpu/drm/i915/gt/selftest_context.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
With recent introduction of a generic drm dev printk function, we
can now store and use location where drm_dbg_printer was invoked
and output it's symbolic name like we do for all drm debug prints.
Signed-off-by: Michal Wajdeczko
Cc: Jani Nikula
---
drivers/gpu/drm/drm_print.c | 3 +--
in
the
final message like all other existing function do and allows us
to keep the formatting code in one place.
Signed-off-by: Michal Wajdeczko
Cc: Jani Nikula
---
drivers/gpu/drm/drm_print.c | 49 -
include/drm/drm_print.h | 3 +++
2 files changed, 30
the
final message like all other existing function do and allows us
to keep the formatting code in one place.
Above also allows to improve drm_dbg_printer() that today lacks
of outputing symbolic name of the caller, like drm_dbg() does.
Cc: Maxime Ripard
Cc: Jani Nikula
Michal Wajdeczko (3
There is no point in maintaining a separate print function, while
there is __drm_dev_dbg() function that can work with a NULL device.
Signed-off-by: Michal Wajdeczko
Cc: Jani Nikula
---
drivers/gpu/drm/drm_print.c | 19 ---
include/drm/drm_print.h | 8 +++-
2 files
On 15.05.2024 11:56, Jani Nikula wrote:
> On Tue, 14 May 2024, Michal Wajdeczko wrote:
>> This drm printer wrapper can be used to increase the robustness of
>> the captured output generated by any other drm_printer to make sure
>> we didn't lost any intermediate lin
On 14.05.2024 22:31, Matthew Brost wrote:
> On Tue, May 14, 2024 at 11:13:14AM -0700, John Harrison wrote:
>> On 5/14/2024 07:58, Michal Wajdeczko wrote:
>>> On 13.05.2024 18:53, John Harrison wrote:
>>>> On 5/12/2024 08:36, Michal Wajdeczko wrote:
>>>&
On 14.05.2024 20:13, John Harrison wrote:
> On 5/14/2024 07:58, Michal Wajdeczko wrote:
>> On 13.05.2024 18:53, John Harrison wrote:
>>> On 5/12/2024 08:36, Michal Wajdeczko wrote:
>>>> We already provide the content of the GuC log in debugsfs, but it
>>&
On 13.05.2024 18:53, John Harrison wrote:
> On 5/12/2024 08:36, Michal Wajdeczko wrote:
>> We already provide the content of the GuC log in debugsfs, but it
>> is in a text format where each log dword is printed as hexadecimal
>> number, which does not scale well with
This drm printer wrapper can be used to increase the robustness of
the captured output generated by any other drm_printer to make sure
we didn't lost any intermediate lines of the output by adding line
numbers to each output line. Helpful for capturing some crash data.
Signed-off-by: M
4 "0x%08x " "\n"'
but this shouldn't be the case as most decoders expect GuC log data
in binary format.
Signed-off-by: Michal Wajdeczko
Cc: Lucas De Marchi
Cc: John Harrison
---
Cc: linux-fsde...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
drive
It is preferable to use the xe_map layer instead of directly
accessing iosys_map, so add a wrapper for the recently added
iosys_map_read_from() function.
Signed-off-by: Michal Wajdeczko
Cc: Lucas De Marchi
---
Cc: linux-fsde...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
drivers
It allows to copy data from iosys_map into the user memory,
regardless whether iosys_map points to memory or I/O memory.
Signed-off-by: Michal Wajdeczko
---
Cc: linux-fsde...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: Lucas De Marchi
---
include/linux/iosys-map.h | 24
It's similar to simple_read_from_buffer() but instead allows to
copy data from the I/O memory in PAGE_SIZE chunks.
Signed-off-by: Michal Wajdeczko
---
Cc: linux-fsde...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: Lucas De Marchi
---
fs/libfs.c
We already provide the content of the GuC log in debugsfs, but it
is in a text format where each log dword is printed as hexadecimal
number, which does not scale well with large GuC log buffers.
Cc: linux-fsde...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Michal Wajdeczko (4):
libfs
On 17.04.2024 10:41, Aravind Iddamsetty wrote:
> PCI subsystem provides callbacks to inform the driver about a request to
> do function level reset by user, initiated by writing to sysfs entry
> /sys/bus/pci/devices/.../reset. This will allow the driver to handle FLR
> without the need to do unb
On 17.04.2024 10:41, Aravind Iddamsetty wrote:
> This would be used in other places outside of gt_reset path.
>
> Cc: Lucas De Marchi
>
> Reviewed-by: Rodrigo Vivi
> Signed-off-by: Aravind Iddamsetty
> ---
> drivers/gpu/drm/xe/xe_gt.c | 31 +--
> drivers/gpu/drm
ned-off-by: Michał Winiarski
Reviewed-by: Michal Wajdeczko
> ---
> drivers/gpu/drm/tests/drm_mm_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_mm_test.c
> b/drivers/gpu/drm/tests/drm_mm_test.c
> index 1eb0c304f9
On 08.01.2024 22:24, Lucas De Marchi wrote:
> On Mon, Jan 08, 2024 at 09:46:47PM +0100, Michal Wajdeczko wrote:
>>
>>
>> On 08.01.2024 15:07, Lucas De Marchi wrote:
>>> On Mon, Jan 08, 2024 at 12:05:57PM +0300, Dan Carpenter wrote:
>>>> The GUC_HXG_
On 08.01.2024 15:07, Lucas De Marchi wrote:
> On Mon, Jan 08, 2024 at 12:05:57PM +0300, Dan Carpenter wrote:
>> The GUC_HXG_MSG_0_ORIGIN definition should be unsigned. Currently it is
>> defined as INT_MIN. This doesn't cause a problem currently but it's
>> still worth cleaning up.
>>
>> Signe
On 15.11.2023 11:00, Tvrtko Ursulin wrote:
>
> On 14/11/2023 16:55, Michal Wajdeczko wrote:
>> On 14.11.2023 13:37, Tvrtko Ursulin wrote:
>>> On 10/11/2023 18:22, Michal Wajdeczko wrote:
>>>> The Single Root I/O Virtualization (SR-IOV) extension to the PCI
On 14.11.2023 14:22, Vivi, Rodrigo wrote:
> On Tue, 2023-11-14 at 12:37 +, Tvrtko Ursulin wrote:
>>
>> On 10/11/2023 18:22, Michal Wajdeczko wrote:
>>> The Single Root I/O Virtualization (SR-IOV) extension to the PCI
>>> Express (PCIe) specification suit
On 14.11.2023 13:37, Tvrtko Ursulin wrote:
>
> On 10/11/2023 18:22, Michal Wajdeczko wrote:
>> The Single Root I/O Virtualization (SR-IOV) extension to the PCI
>> Express (PCIe) specification suite is supported starting from 12th
>> generation of Intel Graphics process
On 14.11.2023 11:08, Francois Dugast wrote:
> On Fri, Nov 10, 2023 at 07:22:31PM +0100, Michal Wajdeczko wrote:
>> The Single Root I/O Virtualization (SR-IOV) extension to the PCI
>> Express (PCIe) specification suite is supported starting from 12th
>> generation of Inte
the sysfs.
Signed-off-by: Michal Wajdeczko
Cc: Oded Gabbay
Cc: Rodrigo Vivi
Cc: Joonas Lahtinen
Cc: Tvrtko Ursulin
Cc: Daniel Vetter
---
Documentation/gpu/rfc/index.rst | 5 +
Documentation/gpu/rfc/sysfs-driver-xe-sriov | 501
Documentation/gpu/rfc
Replace generic log messages with ones dedicated for the GT.
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/xe/xe_gt.c | 29 -
1 file changed, 12 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index
While debugging GT related problems, it's good to know which GT was
reporting problems. Introduce helper macros to allow prefix GT logs
with GT idetifier. We will use them in upcoming patches.
v2: use xe_ prefix (Lucas)
Signed-off-by: Michal Wajdeczko
Cc: Lucas De Marchi
Cc: Jani N
on
> of macro 'FIELD_PREP'
>FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
>^~
>
> Make sure that GUC_KLV_0_KEY is an unsigned value to avoid the warning.
>
> Fixes: 77b6f79df66e ("drm/i915/guc: Update to GuC version 69.0.3")
> Sig
On 07.02.2023 06:07, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Update more print messages to the new scheme.
>
> v2: Also change all errors to %pe rather than %d (MichalW).
> Few other tweaks.
>
> Signed-off-by: John Harrison
LGTM, series is
Revie
ratelimited, _fmt, ##__VA_ARGS__)
>
> +#define guc_notice_ratelimited(_guc, _fmt, ...) \
> + guc_printk((_guc), notice_ratelimited, _fmt, ##__VA_ARGS__)
> +
> #define guc_probe_error(_guc, _fmt, ...) \
> guc_printk((_guc), probe_error, _fmt, ##__VA_ARGS__)
>
Reviewed-by: Michal Wajdeczko
i915_probe_error(i915, "SLPC Reset event returned (%pe)\n",
> - ERR_PTR(ret));
> + guc_probe_error(guc, "SLPC Reset event returned (%pe)\n",
> ERR_PTR(ret));
> return ret;
> }
>
> @@ -743,7 +729,7 @@ int intel_guc
On 03.02.2023 01:11, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Update a bunch more debug prints to use the new GT based scheme.
>
> Signed-off-by: John Harrison
> ---
> drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 35 ++-
> .../drm/i915/gt/uc/selftest_guc
&gsc_lock, "gsc_context");
> if (IS_ERR(ce)) {
> - drm_err(>->i915->drm,
> - "failed to create GSC CS ctx for FW communication\n");
> + gt_err(gt, "failed to create GSC CS ctx for FW
>
Like we did it for GuC, introduce some helper print macros for
HuC to have unified format of messages that also include GT#.
While around improve some messages and use %pe if possible.
v2: update GSC/PXP timeout message
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Cc: Daniele Ceraolo
Like we did it for GuC, introduce some helper print macros for
HuC to have unified format of messages that also include GT#.
While around improve some messages and use %pe if possible.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_huc.c | 44
Just recently we switched over to new GuC oriented log macros but in
the meantime yet another message was added that we missed to update.
While around improve that new message by adding engine name and use
existing helpers to check for context state.
Signed-off-by: Michal Wajdeczko
Cc: John
Use new macros to have common prefix that also include GT#.
v2: drop unused helpers
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff
Use new macros to have common prefix that also include GT#.
v2: improve few existing messages
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 61 ---
1 file changed, 26 insertions(+), 35
Use new macros to have common prefix that also include GT#.
v2: pass gt to print_fw_ver
v3: prefer guc_dbg in suspend/resume logs
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 80 +--
1 file changed, 39 insertions(+), 41
Use new macros to have common prefix that also include GT#.
v2: drop redundant GuC strings, minor improvements
v3: more message improvements
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 38 +++---
1 file changed, 19
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt
Use new macros to have common prefix that also include GT#.
v2: drop now redundant "GuC" word from the message
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 31 +-
1 file c
While we do have GT oriented print macros, add few more GuC
specific to have common look and feel across all messages
related to the GuC and to avoid chasing the gt pointer.
We will use these macros shortly in upcoming patches.
Signed-off-by: Michal Wajdeczko
Cc: Tvrtko Ursulin
Cc: John
rsulin
Cc: John Harrison
Michal Wajdeczko (8):
drm/i915/guc: Add GuC oriented print macros
drm/i915/guc: Update GuC messages in intel_guc.c
drm/i915/guc: Update GuC messages in intel_guc_ads.c
drm/i915/guc: Update GuC messages in intel_guc_ct.c
drm/i915/guc: Update GuC messages in inte
Use new macros to have common prefix that also include GT#.
v2: drop unused helpers
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/i915
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt
While we do have GT oriented print macros, add few more GuC
specific to have common look and feel across all messages
related to the GuC and to avoid chasing the gt pointer.
We will use these macros shortly in upcoming patches.
Signed-off-by: Michal Wajdeczko
Cc: Tvrtko Ursulin
Cc: John
Use new macros to have common prefix that also include GT#.
v2: pass gt to print_fw_ver
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 80 +--
1 file changed, 39 insertions(+), 41 deletions(-)
diff --git a/drivers/gpu/drm
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc
Use new macros to have common prefix that also include GT#.
v2: drop redundant GuC strings, minor improvements
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 37 --
1 file changed, 20 insertions(+), 17 deletions(-)
diff
Use new macros to have common prefix that also include GT#.
v2: drop now redundant "GuC" word from the message
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 31 +-
1 file changed, 15 insertions(+), 16 deletion
Use new macros to have common prefix that also include GT#.
v2: improve few existing messages
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 61 ---
1 file changed, 26 insertions(+), 35 deletions(-)
diff --git a/drivers
This is a follow up series for existing commit 67804e48b494
("drm/i915/gt: Start adding module oriented dmesg output")
that was focusing just on the GT.
Now extend changes to uc/ folder and focus on the GuC.
v2: applying feedback from John
Cc: Tvrtko Ursulin
Cc: John Harrison
On 24.01.2023 00:01, John Harrison wrote:
> On 1/20/2023 08:40, Michal Wajdeczko wrote:
>> Use new macros to have common prefix that also include GT#.
>>
>> Signed-off-by: Michal Wajdeczko
>> Cc: John Harrison
>> ---
>> drivers/
On 24.01.2023 00:27, John Harrison wrote:
> On 1/20/2023 08:40, Michal Wajdeczko wrote:
>> While we do have GT oriented print macros, add few more GuC
>> specific to have common look and feel across all messages
>> related to the GuC and to avoid chasing the gt pointer.
&g
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
b/drivers
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
b/drivers/gpu/drm
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 60 ---
1 file changed, 26 insertions(+), 34 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc
Use new macros to have common prefix that also include GT#.
Signed-off-by: Michal Wajdeczko
Cc: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 35 +++---
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
1 - 100 of 258 matches
Mail list logo
