On 10.03.2025 22:30, Cavitt, Jonathan wrote:
> -----Original Message-----
> From: Wajdeczko, Michal <michal.wajdec...@intel.com>
> Sent: Monday, March 10, 2025 11:20 AM
> To: Cavitt, Jonathan <jonathan.cav...@intel.com>;
> intel...@lists.freedesktop.org
> Cc: Gupta, saurabhg <saurabhg.gu...@intel.com>; Zuo, Alex
> <alex....@intel.com>; joonas.lahti...@linux.intel.com; Brost, Matthew
> <matthew.br...@intel.com>; Zhang, Jianxun <jianxun.zh...@intel.com>; Lin,
> Shuicheng <shuicheng....@intel.com>; dri-devel@lists.freedesktop.org
> Subject: Re: [PATCH v7 2/6] drm/xe/xe_gt_pagefault: Migrate pagefault struct
> to header
>>>
>>> On 10.03.2025 18:18, Jonathan Cavitt wrote:
>>>> Migrate the pagefault struct from xe_gt_pagefault.c to the
>>>
>>> nit: we use "migrate" verb for different purposes.
>>> maybe here (and in the title) the plain "move" will be better?
>>>
>>>> xe_gt_pagefault.h header file, along with the associated enum values.
>>>
>>> hmm, all other components have foo_types.h header file as place for own
>>> types and use foo.h header only for function declarations.
>>>
>>> why are we doing it differently here?
>
> xe_gt_pagefault_types.h does not exist and would have to be created to
> satisfy this
> request. It would also basically only contain the below xe_pagefault struct
> and its
> related enums. Is this amenable?
it's about the idea, it doesn't matter not how many items you will put
there. You can take a look at few other "small" types.h files:
$ ls -S -1 *types.h | tail -5
xe_ring_ops_types.h
xe_huc_types.h
xe_gt_stats_types.h
xe_sa_types.h
xe_bb_types.h
