f the
respective debug messages are enabled. This is similar to the behavior
in rockchip_drm_vop.c.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
b/dr
calculation of the porches and someone at NXP can chime in.
Michael
Signed-off-by: Michael Tretter
---
Changes in v2:
- Specify limits for the PLL input clock in samsung_dsim_driver_data
- Rephrase/clarify commit messages
- Link to v1:
https://lore.kernel.org/r/20230818-samsung-dsim-v1-0-b39716db6
: Inki Dae
Tested-by: Frieder Schrempf # Kontron BL i.MX8MM
+ Waveshare 10.1inch HDMI LCD (E)
Reviewed-by: Marco Felsch
Signed-off-by: Michael Tretter
---
Changes in v2: None
---
drivers/gpu/drm/bridge/samsung-dsim.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a
: Adam Ford #imx8mm-beacon
Tested-by: Adam Ford #imx8mm-beacon
Tested-by: Frieder Schrempf # Kontron BL i.MX8MM
+ Waveshare 10.1inch HDMI LCD (E)
Reviewed-by: Marco Felsch
Signed-off-by: Michael Tretter
---
Changes in v2: None
---
drivers/gpu/drm/bridge/samsung-dsim.c | 10 ++
1 file
MX8MM
+ Waveshare 10.1inch HDMI LCD (E)
Signed-off-by: Michael Tretter
---
Changes in v2:
- Specify limits for the PLL input clock in samsung_dsim_driver_data
---
drivers/gpu/drm/bridge/samsung-dsim.c | 27 +--
include/drm/bridge/samsung-dsim.h | 2 ++
2 files changed, 27 inser
e clock is only read from the clock tree if that device tree
property is not set.
Reviewed-by: Inki Dae
Acked-by: Inki Dae
Tested-by: Frieder Schrempf # Kontron BL i.MX8MM
+ Waveshare 10.1inch HDMI LCD (E)
Reviewed-by: Marco Felsch
Signed-off-by: Michael Tretter
---
Changes in v2:
- Clar
Marco Felsch
Signed-off-by: Michael Tretter
---
Changes in v2:
- Rephrase commit message
---
drivers/gpu/drm/bridge/samsung-dsim.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c
b/drivers/gpu/drm/bridge/samsung-dsim.c
index 16c8326
On Wed, 27 Sep 2023 07:47:53 -0500, Adam Ford wrote:
> On Sun, Sep 3, 2023 at 8:05 PM Inki Dae wrote:
> >
> > 2023년 8월 29일 (화) 오전 7:38, Adam Ford 님이 작성:
> > >
> > > On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter
> > > wrote:
> > > >
>
On Tue, 05 Sep 2023 18:06:06 +0900, 대인기/Tizen Platform Lab(SR)/삼성전자 wrote:
>
>
> > -Original Message-
> > From: dri-devel On Behalf Of
> > Michael Tretter
> > Sent: Monday, September 4, 2023 8:15 PM
> > To: Inki Dae
> > Cc: Neil Armstrong ; Rob
On Mon, 04 Sep 2023 16:28:37 +0200, Maxim Schwalm wrote:
> On 28.08.23 17:59, Michael Tretter wrote:
> > Calculating the byte_clk in kHz is imprecise for a hs_clock of 55687500
> > Hz, which may be used with a pixel clock of 74.25 MHz with mode
> > 1920x1080-30.
> >
Hi Frieder,
On Wed, 06 Sep 2023 11:31:45 +0200, Frieder Schrempf wrote:
> On 04.09.23 16:02, Frieder Schrempf wrote:
> > On 28.08.23 17:59, Michael Tretter wrote:
> >> I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter,
> >> which uses an ADV7535 MI
On Mon, 04 Sep 2023 13:38:33 +0900, Inki Dae wrote:
> 2023년 8월 29일 (화) 오전 12:59, Michael Tretter 님이 작성:
>
> >
> > The PLL reference clock may change at runtime. Thus, reading the clock
> > rate during probe is not sufficient to correctly configure the PLL for
&
On Mon, 04 Sep 2023 14:44:41 +0900, Inki Dae wrote:
> 2023년 8월 29일 (화) 오전 12:59, Michael Tretter 님이 작성:
> >
> > The PLL requires a clock between 2 MHz and 30 MHz after the pre-divider.
> > The reference clock for the PLL may change due to changes to it's parent
> >
On Mon, 28 Aug 2023 18:07:08 -0500, Adam Ford wrote:
> On Mon, Aug 28, 2023 at 11:13 AM Adam Ford wrote:
> >
> > On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter
> > wrote:
> > >
> > > I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter,
On Mon, 28 Aug 2023 17:39:03 -0500, Adam Ford wrote:
> On Mon, Aug 28, 2023 at 1:26 PM Fabio Estevam wrote:
> >
> > Hi Michael,
> >
> > On Mon, Aug 28, 2023 at 12:59 PM Michael Tretter
> > wrote:
> > >
> > > The porches must be rounde
On Mon, 28 Aug 2023 13:17:44 -0500, Adam Ford wrote:
> On Mon, Aug 28, 2023 at 11:42 AM Marco Felsch wrote:
> >
> > On 23-08-28, Michael Tretter wrote:
> > > The PLL requires a clock between 2 MHz and 30 MHz after the pre-divider.
> > > The reference clock for the
: Michael Tretter
---
drivers/gpu/drm/bridge/samsung-dsim.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c
b/drivers/gpu/drm/bridge/samsung-dsim.c
index 459be953be55..eb7aca2b9ab7 100644
--- a/drivers/gpu/drm/bridge/samsung
d set the reference clock close to
30 MHz before recalculating the PLL configuration. Use a divider with a
power of two for the reference clock as this seems to work best in
my tests.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/bridge/samsung-dsim.c | 15 +--
1 file change
The porches must be rounded up to make the samsung-dsim work.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/bridge/samsung-dsim.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c
b/drivers/gpu/drm/bridge/samsung-dsim.c
index
From: Marco Felsch
Since the MIPI configuration can be changed on demand it is very useful
to print more MIPI settings during the MIPI device attach step.
Signed-off-by: Marco Felsch
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/bridge/samsung-dsim.c | 5 -
1 file changed, 4
The PLL reference clock may change at runtime. Thus, reading the clock
rate during probe is not sufficient to correctly configure the PLL for
the expected hs clock.
Read the actual rate of the reference clock before calculating the PLL
configuration parameters.
Signed-off-by: Michael Tretter
calculation of the porches and someone at NXP can chime in.
Michael
Signed-off-by: Michael Tretter
---
Marco Felsch (1):
drm/bridge: samsung-dsim: add more mipi-dsi device debug information
Michael Tretter (4):
drm/bridge: samsung-dsim: reread ref clock before configuring PLL
drm
the framebuffer that has been freed but is still pointed
to by the register. The iommu will catch these read accesses and print
errors.
Explicitly disable the planes when the crtc is disabled to reset the
registers.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
state by checking the
old_pstate only if a state is passed.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
b/drivers/gpu/drm/rockchip
Michael Tretter (2):
drm/rockchip: vop2: fix null pointer in plane_atomic_disable
drm/rockchip: vop2: disable planes when disabling the crtc
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
--
2.30.2
On Thu, 11 Nov 2021 13:21:03 -0800, Tim Harvey wrote:
> On Thu, Nov 11, 2021 at 2:19 AM Jagan Teki wrote:
> > On Wed, Nov 10, 2021 at 11:58 PM Jagan Teki
> > wrote:
> > > On Wed, Nov 10, 2021 at 2:24 AM Tim Harvey wrote:
> > > > On Tue, Nov 9, 2021 at 12:39 PM Marek Vasut wrote:
> > > > > On 1
2021 at 5:28 PM Andrzej Hajda wrote:
> > > > > W dniu 04.02.2021 o 17:05, Daniel Vetter pisze:
> > > > > > On Thu, Feb 04, 2021 at 11:56:32AM +0100, Michael Tretter wrote:
> > > > > > > On Thu, 04 Feb 2021 11:17:49 +0100, Daniel Vetter wrote:
>
On Thu, 04 Feb 2021 11:17:49 +0100, Daniel Vetter wrote:
> On Wed, Feb 3, 2021 at 9:32 PM Michael Tretter
> wrote:
> >
> > On Mon, 01 Feb 2021 17:33:14 +0100, Michael Tretter wrote:
> > > On Tue, 15 Sep 2020 21:40:40 +0200, Andrzej Hajda wrote:
> > > > W
On Mon, 01 Feb 2021 17:33:14 +0100, Michael Tretter wrote:
> On Tue, 15 Sep 2020 21:40:40 +0200, Andrzej Hajda wrote:
> > W dniu 14.09.2020 o 23:19, Andrzej Hajda pisze:
> > > On 14.09.2020 22:01, Michael Tretter wrote:
> > >> On Mon, 14 Sep 2020 14:31:19 +0200, Mare
iMX8MM LCDIF to set
> the correct sync flags. This likely needs to be done in the glue code.
>
> Signed-off-by: Marek Vasut
> Cc: Fabio Estevam
> Cc: Guido Günther
> Cc: Jaehoon Chung
> Cc: Lucas Stach
> Cc: Marek Szyprowski
> Cc: Michael Tretter
> Cc: NXP Linux
On Tue, 15 Sep 2020 21:40:40 +0200, Andrzej Hajda wrote:
> W dniu 14.09.2020 o 23:19, Andrzej Hajda pisze:
> > On 14.09.2020 22:01, Michael Tretter wrote:
> >> On Mon, 14 Sep 2020 14:31:19 +0200, Marek Szyprowski wrote:
> >>> On 14.09.2020 10:29, Marek Szyprowski wro
On Wed, 11 Nov 2020 12:11:15 +0900, Inki Dae wrote:
> 20. 11. 11. 오후 12:04에 Inki Dae 이(가) 쓴 글:
> > 20. 11. 10. 오후 5:13에 Michael Tretter 이(가) 쓴 글:
> >> On Mon, 09 Nov 2020 12:15:39 +0900, Inki Dae wrote:
> >>> 20. 9. 11. 오후 10:53에 Michael Tretter 이(가) 쓴 글:
> >>
On Sat, 07 Nov 2020 09:07:19 -0600, Adam Ford wrote:
> On Fri, Sep 11, 2020 at 8:54 AM Michael Tretter
> wrote:
> >
> > In commit 05193dc38197 ("drm/bridge: Make the bridge chain a
> > double-linked list") the bridge has been removed and replaced by a
>
On Sat, 07 Nov 2020 23:39:30 +0100, Sam Ravnborg wrote:
> On Fri, Sep 11, 2020 at 03:54:03PM +0200, Michael Tretter wrote:
> > The phy timings are already shifted to the field position. If the driver
> > is reused on multiple platforms, this exposes the field positions to the
&g
On Mon, 09 Nov 2020 12:15:39 +0900, Inki Dae wrote:
> 20. 9. 11. 오후 10:53에 Michael Tretter 이(가) 쓴 글:
> > This is v2 of the series to convert the Exynos MIPI DSI driver into a drm
> > bridge and make it usable with other drivers. Although the driver is
> > converted, it still s
On Wed, 16 Sep 2020 09:58:39 +0200, Daniel Vetter wrote:
> On Fri, Sep 11, 2020 at 03:54:13PM +0200, Michael Tretter wrote:
> > As the driver is not platform dependent anymore, move it to the drm
> > bridge driver directory.
> >
> > Signed-off-by: Michael Tretter
>
On Tue, 15 Sep 2020 19:07:59 +0200, Andrzej Hajda wrote:
>
> W dniu 11.09.2020 o 15:54, Michael Tretter pisze:
> > Platform drivers need to be aware if a mipi dsi device attaches or
> > detaches. Add host_ops to the driver_data for attach and detach
> > callbacks and mov
Hi,
On Mon, 14 Sep 2020 14:31:19 +0200, Marek Szyprowski wrote:
> On 14.09.2020 10:29, Marek Szyprowski wrote:
> > On 11.09.2020 15:54, Michael Tretter wrote:
> >> Make the exynos_dsi driver a full drm bridge that can be found and used
> >> from other drivers.
>
The driver uses the encoder to get the mode that shall be configured.
This is not possible, if the driver is used as a bridge, because the
encoder might not be used.
Use the mode_set function to set the display mode.
Signed-off-by: Michael Tretter
---
v2: none
---
drivers/gpu/drm/exynos
Split the driver into the drm bridge driver and the exynos platform
specific driver.
Signed-off-by: Michael Tretter
---
v2: none
---
drivers/gpu/drm/exynos/Makefile | 2 +-
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 372 +-
drivers/gpu/drm/exynos
Platform drivers need to be aware if a mipi dsi device attaches or
detaches. Add host_ops to the driver_data for attach and detach
callbacks and move the i80 mode selection and the hotplug handling into
the callback, because these depend on the drm driver.
Signed-off-by: Michael Tretter
---
v2
-by: Michael Tretter
---
v2: none
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 88 +
1 file changed, 46 insertions(+), 42 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 41000214a5fe..0f2cac7ed944 100644
Use the exynos_dsi as drvdata instead of the encoder to further decouple
the driver from the encoder.
Signed-off-by: Michael Tretter
---
v2: drop removal of encoder_to_dsi
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff
We do not need to keep a reference to the in_bridge_node, but we can
simply drop it, once we found and attached the previous bridge.
Signed-off-by: Michael Tretter
---
v2: none
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions
As the driver shall be usable with drivers that use the component
framework and drivers that don't, split the common probing code into a
separate function that can be called from different locations.
Signed-off-by: Michael Tretter
---
v2:
- move pm_runtime_enable from helper to calling fun
layout shall be used on a platform.
Signed-off-by: Michael Tretter
---
v2: none
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 54 -
1 file changed, 36 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
-off-by: Michael Tretter
---
v2:
- move attach of out_bridge to bridge_attach
- add bridge_detach
- don't cleanup encoder if create_connector failed
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 103 +---
1 file changed, 75 insertions(+), 28 deletions(-)
diff --git a/dr
Once the driver implements a drm_bridge, the bridge will be attached
during bind. The driver has to register the mipi dsi host before making
the driver available at the component framework, because the bridge is
only initialized when a mipi dsi device attaches.
Signed-off-by: Michael Tretter
If other drivers use the exynos_dsi driver as a bridge, they might bring
their own encoder. Enable and disable the MIPI-DSI bridge using the
bridge functions instead of the encoder functions.
Signed-off-by: Michael Tretter
---
v2: none
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 33
chael
Changelog:
v2:
- rebase on linux-next
- verify with exynos_defconfig
- fix crashes reported by Marek Szyprowski Exynos3250-based Rinato
- reorder patches
- add host_ops for platform specific code
- roughly test component framework integration with dummy
Michael Tretter (16):
drm/encoder: r
In commit 05193dc38197 ("drm/bridge: Make the bridge chain a
double-linked list") the bridge has been removed and replaced by a
private field. Remove the leftover documentation of the removed field.
Signed-off-by: Michael Tretter
Reviewed-by: Laurent Pinchart
---
v2: none
---
i
.
Signed-off-by: Michael Tretter
---
v2:
- add removal of encoder_to_dsi
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 988447812333
Add new functions for the probe/remove API, the bind/unbind API and
resume/suspend calls. Move everything exynos drm specific into separate
functions, which can easily be moved to other files.
Also split struct exynos_dsi into a generic and a platform specific
struct.
Signed-off-by: Michael
As the driver is not platform dependent anymore, move it to the drm
bridge driver directory.
Signed-off-by: Michael Tretter
---
v2:
- select DRM_SAMSUNG_DSIM from DRM_EXYNOS_DSI
- add removal of depends on !FB_S3C
---
drivers/gpu/drm/bridge/Kconfig|9 +
drivers/gpu/drm
The tearing effect interrupts are not handled by the MIPI DSI bridge
driver, but the display controller driver.
Allow platforms to register a callback for the tearing effect interrupt.
Signed-off-by: Michael Tretter
---
v2:
- add handler as callback in host_ops
---
drivers/gpu/drm/exynos
Hi Marek,
On Fri, 04 Sep 2020 10:31:12 +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 03.09.2020 22:08, Krzysztof Kozlowski wrote:
> > On Thu, 3 Sep 2020 at 18:57, Michael Tretter
> > wrote:
> >> the Exynos MIPI DSI Phy is also found on the i.MX8M Mini. Ho
es 15 and 16 finally split and move the drm bridge driver out of the
Exynos DRM driver.
Michael
Michael Tretter (16):
drm/encoder: remove obsolete documentation of bridge
drm/exynos: extract helper functions for probe
drm/exynos: remove in_bridge_node from exynos_dsi
drm/exynos: implement
In commit 05193dc38197 ("drm/bridge: Make the bridge chain a
double-linked list") the bridge has been removed and replaced by a
private field. Remove the leftover documentation of the removed field.
Signed-off-by: Michael Tretter
---
include/drm/drm_encoder.h | 1 -
1 file changed,
Use the exynos_dsi as drvdata instead of the encoder to further decouple
the driver from the encoder.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/exynos
The driver uses the encoder to get the mode that shall be configured.
This is not possible, if the driver is used as a bridge, because the
encoder might not be used.
Use the mode_set function to get the display mode.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c
We do not need to keep a reference to the in_bridge_node, but we can
simply drop it, once we found and attached the previous bridge.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a
The probe shall only register the driver at the component framework. The
actual probing happens when the driver is bound.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 27 +
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a
Make the exynos_dsi driver a full drm bridge that can be found and used
from other drivers.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 45 +++--
1 file changed, 42 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos
Display controllers need to know if the MIPI DSI bridge is running in
command or video mode. Allow platform drivers to register a callback for
being notified about the used mode.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 24 ++--
1 file
The tearing effect interrupts are not handled by the MIPI DSI bridge
driver, but the display controller driver.
Allow platforms to register a callback for the tearing effect interrupt.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 19 ---
1 file
The bind/unbind API will be only used with the component framework, but
the mipi dsi host is always required. Therefore, move it to the shared
probe helper function.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 10 +++---
1 file changed, 7 insertions(+), 3
Split the driver into the drm bridge driver and the exynos platform
specific driver.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/Makefile | 2 +-
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 312 ++
drivers/gpu/drm/exynos/exynos_drm_dsi.h
layout shall be used on a platform.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 54 -
1 file changed, 36 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index
As the driver shall be usable with drivers that use the component
framework and drivers that don't, split the common probing code into a
separate function that can be called from different locations.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c
-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 88 +
1 file changed, 46 insertions(+), 42 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 3bf4ae0fe6cc..21db18ae0772 100644
--- a/drivers
If other drivers use the exynos_dsi driver as a bridge, they might bring
their own encoder. Enable and disable the MIPI-DSI bridge using the
bridge functions instead of the encoder functions.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 33
As the driver is not platform dependent anymore, move it to the drm
bridge driver directory.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/bridge/Kconfig|7 +
drivers/gpu/drm/bridge/Makefile |1 +
drivers/gpu/drm/bridge/samsung-dsim.c | 1797
The bridge will not necessarily use the encoder of struct exynos_dsi,
but might use another encoder from another drm driver. Therefore, the
driver has to use the encoder from the bridge instead of the one from
exynos_dsi.
Signed-off-by: Michael Tretter
---
drivers/gpu/drm/exynos
Using plain echo to set the "force" connector attribute fails with
-EINVAL, because echo appends a newline to the output.
Replace strcmp with sysfs_streq to also accept strings that end with a
newline.
v2: use sysfs_streq instead of stripping trailing whitespace
Signed-off-by: Micha
74 matches
Mail list logo
