Hi Stefan,
>
> How did you actually test that? I have a hard time to get anything useable
> with
> this code.
>
> The display looks completely borked (colors are way off, and at random either
> too dark or too bright).
>
> I then also added Gamma 1.0 (and different values) to the Monitor secti
> Subject: Re: [PATCH v5] drm/fsl-dcu: Implement gamma_lut atomic crtc
> properties
>
> On 2016-09-28 01:24, Meng Yi wrote:
> > Gamma correction is optional and can be used to adjust the color
> > output values to match the gamut of a particular TFT LCD panel
> >
>
RGB/LVDS encoder */
> + if (fsl_dev->tcon)
> + fsl_tcon_bypass_enable(fsl_dev->tcon);
> +
> ret = drm_encoder_init(fsl_dev->drm, encoder, &encoder_funcs,
> DRM_MODE_ENCODER_LVDS, NULL);
> if (ret < 0)
> return ret;
>
> - drm_encoder_helper_add(encoder, &encoder_helper_funcs);
> -
> return 0;
> }
>
> --
> 2.10.0
Tested-By: Meng Yi
Tested those 5 patches on LS1021a-twr, and everything is fine.
Meng
Hi Stefan,
> > @@ -6,6 +6,12 @@ Required properties:
> > * "fsl,vf610-dcu".
> >
> > - reg: Address and length of the register set for dcu.
> > + Must contain four address/length tuples:
> > + 1. Register address space
> > +
n.
The registers after the first address space are not accessed yet,
hence new device trees would even work with old kernels. Just new
kernel need the new format so we can access the separate gamma
reg space.
Suggested-by: Stefan Agner
Signed-off-by: Meng Yi
---
Changes since V1:
-created a sec
into "regs", "palette", "gamma" and "cursor".
Create a second regmap for gamma memory space using little endian.
Suggested-by: Stefan Agner
Signed-off-by: Meng Yi
---
Changes since V1:
-created a second regmap for gamma
-updated the DCU DT binding
-removed
> On Wed, Sep 21, 2016 at 11:10:11AM -0700, Stefan Agner wrote:
> > On 2016-09-13 01:49, Meng Yi wrote:
> > >> > diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig
> > >> > b/drivers/gpu/drm/fsl-dcu/Kconfig index 14a72c4..f9c76b1 100644
> > >> >
Hi Maxime,
> +
> +static struct drm_encoder *
> +dumb_vga_best_encoder(struct drm_connector *connector)
> +{
> + struct dumb_vga *vga = drm_connector_to_dumb_vga(connector);
> +
> + return vga->bridge.encoder;
> +}
> +
> +static struct drm_connector_helper_funcs dumb_vga_con_helper_funcs =
> > diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig
> > b/drivers/gpu/drm/fsl-dcu/Kconfig index 14a72c4..f9c76b1 100644
> > --- a/drivers/gpu/drm/fsl-dcu/Kconfig
> > +++ b/drivers/gpu/drm/fsl-dcu/Kconfig
> > @@ -11,3 +11,9 @@ config DRM_FSL_DCU
> > help
> > Choose this option if you have an
> Subject: Re: [PATCH] drm/fsl-dcu: Add gamma set for crtc
>
> On Mon, Sep 05, 2016 at 12:24:32AM -0700, Stefan Agner wrote:
>
> > So, afaik, we deal with 3x 256 32-bit register which happen to be a
> > different endianness on one SoC implementing the DCU IP...
>
> That does sound like a second
>
> > diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt
> > b/Documentation/devicetree/bindings/display/fsl,dcu.txt
> > index 63ec2a6..1b1321a 100644
> > --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt
> > +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt
> >
into "regs", "palette", "gamma" and "cursor".
Create a second regmap for gamma memory space using little endian.
Suggested-by: Stefan Agner
Signed-off-by: Meng Yi
---
Changes in V3:
-created a second regmap for gamma
-updated the DCU DT binding
---
...
Hi Stefan,
Some comments below
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c b/drivers/gpu/drm/fsl-
> dcu/fsl_dcu_drm_crtc.c
> index d30b61e..62eb284 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
> @@ -27,6 +27,9 @@ sta
Hi Stefan,
I had tested the patches on LS1021A-TWR board using drmlib.
Like set three overlays:
root at ls1021atwr:~# ./modetest -P 39:900x100+10+10 at RG24 -P
39:200x200+300+0 at RG24 -P 39:200x200+400+300 at RG24
How did you test the overlays and cursor layer, I mean I see you using x-window
"big-endian" to determine the
> location of DIV_RATIO.
>
> Cc: stable at vger.kernel.org
> Fixes: 2d701449bce1 ("drm/fsl-dcu: use common clock framework for pixel
> clock divider")
> Reported-by: Meng Yi
> Signed-off-by: Stefan Agner
> ---
> drivers/g
Hi Stefan,
> >
> > This is a errta for DCU, Gamma registers are supposed to be big
> > endian, but actually it is little endian, do we
> > Really need to create a second regmap?
>
> Do you have the exact wording of the errata?
Below is the description from hardware team.
Affects: 2D-ACE
Descrip
Hi Stefan,
> > + */
> > +static u32 swap_bytes(u16 var)
>
> We certainly don't want a byte swapping function in the driver. I am sure
> Linux
> has appropriate functions for that already, however, I am not convinced that
> we need that at all.
>
Yeah, sure. Actually I had sent the V2 for this
U_DIV_RATIO,
> > > - 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL);
> > > + !strcmp(fsl_dev->soc->name, "ls1021a")?24:0, 8,
> > > + CLK_DIVIDER_ROUND_CLOSEST, NULL);
> >
> > Tested-by: Meng Yi
>
> pix_clk_in_name);
> > fsl_dev->pix_clk = clk_register_divider(dev, pix_clk_name,
> > pix_clk_in_name, 0, base + DCU_DIV_RATIO,
> > - 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL);
> > + !strcmp(fsl_dev->soc->
>pix_clk = clk_register_divider(dev, pix_clk_name,
> pix_clk_in_name, 0, base + DCU_DIV_RATIO,
> - 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL);
> + !strcmp(fsl_dev->soc->name, "ls1021a")?24:0, 8,
> + CLK_DIVIDER
While clk_register_divider will write register as little endian,
Modified the param "shift" from 0 to 24 since DCU is big endian.
Or reg "DCU_DIV_RATIO" will be seted as a incorrect value which
will cause vblank timing issue etc.
Signed-off-by: Meng Yi
---
Changes in V2:
-c
> >>fsl_dev->pix_clk = clk_register_divider(dev, pix_clk_name,
> >>pix_clk_in_name, 0, base + DCU_DIV_RATIO,
> >> - 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL);
> >> + 24, 8, CLK_DIVIDER_ROUND_CLO
> fsl_dev->pix_clk = clk_register_divider(dev, pix_clk_name,
> pix_clk_in_name, 0, base + DCU_DIV_RATIO,
> - 0, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL);
> + 24, 8, CLK_DIVIDER_ROUND_CLOSEST, NULL);
Tested-by: Meng
Hi Stefan,
What do you think about this patch for gamma correction.
I see many people approach gamma correction this way. Do you have any
comments?
Best Regards,
Meng
> +static void fsl_crtc_gamma_set(struct drm_crtc *crtc, struct drm_color_lut
> *lut,
> +
For DCU support 16 layers(on ls1021a) or 64 layers(on vf610),
add (total_layer - 1) overlay planes.
Signed-off-by: Jianwei Wang
Signed-off-by: Meng Yi
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a
While clk_register_divider will write register as little endian,
Modified the param "shift" from 0 to 24 since DCU is big endian.
Or reg "DCU_DIV_RATIO" will be seted as a incorrect value which
will cause vblank timing issue etc.
Signed-off-by: Meng Yi
---
dri
Gamma correction is optional and can be used to adjust the color
output values to match the gamut of a particular TFT LCD panel
Gamma_R, Gamma_G and Gamma_B registers are little-endian registers
while the rest of the address-space in 2D-ACE is big-endian.
Signed-off-by: Meng Yi
---
Changes in V2
Gamma correction is optional and can be used to adjust the color
output values to match the gamut of a particular TFT LCD panel
Signed-off-by: Meng Yi
---
drivers/gpu/drm/fsl-dcu/Kconfig| 6 +++
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 63 ++
drivers
The current output code only supports connection to drm panels.
Add code to support drm bridge, to support connections to
external connectors.
Signed-off-by: Meng Yi
---
Changes since V1:
-no change
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 16 +---
1 file changed, 13
This patch rework the output code to add of_graph dt binding support
for panel device and also keeps the backward compatibility
Signed-off-by: Meng Yi
---
Changes in V5:
-remove unused variable 'ret'
Changes in V4:
-simplify return value statements
-merge corresponding documentati
The current output code only supports connection to drm panels.
Add code to support drm bridge, to support connections to
external connectors.
Signed-off-by: Meng Yi
---
Changes since V1:
-no change
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 16 +---
1 file changed, 13
This patch rework the output code to add of_graph dt binding support
for panel device and also keeps the backward compatibility
Signed-off-by: Meng Yi
---
Changes in V4:
-simplify return value statements
-merge corresponding documentation to this patch
Changes in V3:
-simplify return value
The current output code only supports connection to drm panels.
Add code to support drm bridge, to support connections to
external connectors.
Signed-off-by: Meng Yi
---
Changes since V1:
-no change
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 13 -
1 file changed, 12 insertions
This patch rework the output code to add of_graph dt binding support
for panel device and also keeps the backward compatibility
Signed-off-by: Meng Yi
---
Changes in V3:
-simplify return value statements
Changes in V2:
-fix some coding style issue
-add fsl_dev->connector.panel check
-use fsl_
Hi Stefan,
Those two patches actually can be merged independently. Do you
have some more comments?
Best Regards,
Meng
> -Original Message-
> From: Meng Yi [mailto:meng.yi at nxp.com]
> Sent: Tuesday, June 28, 2016 5:32 PM
> To: stefan at agner.ch
> Cc: airl
add of_graph dt binding for panel, and "fsl,panel" property
is deprecated
Signed-off-by: Meng Yi
---
Changes in V2:
-dropp the unit address of port
---
arch/arm/boot/dts/ls1021a-twr.dts | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/d
dropped the old "fsl,panel" property, using the of_graph dt
binding syntax
Signed-off-by: Meng Yi
---
Changes in V2:
-drop the unit address of port
---
Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
di
> >> Optional properties:
> >> - fsl,tcon: The phandle to the timing controller node.
> >> @@ -24,6 +24,11 @@ dcu: dcu at 2ce {
> >>clocks = <&platform_clk 0>, <&platform_clk 0>;
> >>clock-names = "dcu", "pix";
> >>big-endian;
> >> - fsl,panel = <&panel>;
> >>f
add of_graph dt binding for panel, and "fsl,panel" property
is deprecated
Signed-off-by: Meng Yi
---
arch/arm/boot/dts/ls1021a-twr.dts | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts
b/arch/arm/boot/dts/ls1021a-twr
dropped the old "fsl,panel" property, using the of_graph dt
binding syntax
Signed-off-by: Meng Yi
---
Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,
The current output code only supports connection to drm panels.
Add code to support drm bridge, to support connections to
external connectors.
Signed-off-by: Meng Yi
---
Changes in V2:
-no change
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 14 ++
1 file changed, 14 insertions
This patch rework the output code to add of_graph dt binding support
for panel device and also keeps the backward compatibility
Signed-off-by: Meng Yi
---
Changes in V2:
-fix some coding style issue
-add fsl_dev->connector.panel check
-use fsl_dev->np and drop fsl_dev->dev->of_node
The current output code only supports connection to drm panels.
Add codes to support drm bridge, to supports connection to
external connectors.
Signed-off-by: Meng Yi
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu
This patch rework the output code to add of_graph dt binding support
for panel device and also keeps the backward compatibility
Signed-off-by: Meng Yi
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c| 2 +-
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_output.h | 3 +-
drivers/gpu/drm/fsl-dcu
t; https://patchwork.kernel.org/patch/7706481/
>
That's more reasonable. Thank much for your information and guidance!
I will working on that and send the patch later.
Best Regards,
Meng Yi
t;destroy(&fsl_dev->crtc);
> fail_connector:
> fsl_dev->encoder.funcs->destroy(&fsl_dev->encoder);
> +fail_encoder:
> + fsl_dev->crtc.funcs->destroy(&fsl_dev->crtc);
> return ret;
> }
> --
> 2.1.0.27.g96db324
Best Regards,
Meng Yi
Signed-off-by: Meng Yi
---
Change in V2:
-add prefix "drm/fsl-dcu" to subject
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c
b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c
ind
Hi Alexander,
Thanks for your comments!
On Tuesday, June 14, 2016 5:54 PM, Alexander wrote:
> > +static struct
> > +device_node *detect_hdmi_connection(struct fsl_dcu_drm_device
> > +*fsl_dev) {
> > + struct device_node *remote_port;
> > + struct of_endpoint *ep;
> > + struct device_node *
Add port node to DCU node using "OF graph" discription.
Signed-off-by: Alison Wang
Signed-off-by: Xiubo Li
Signed-off-by: Jianwei Wang
Signed-off-by: Meng Yi
---
Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +
1 file changed, 9 insertions(+)
diff --git a/Doc
: Alison Wang
Signed-off-by: Xiubo Li
Signed-off-by: Jianwei Wang
Signed-off-by: Meng Yi
---
Changes in V2:
-remove unused headers inclusion
-remove module declarations
-fix error handling coding style
-drop moulde parameters and auto detect HDMI connection relying on deviece tree
-modified comment
The lable fail_connector should placed before fail_encoder since
encoder was initialized before connector. which should also be
called after connector initialization failed.
Signed-off-by: Meng Yi
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c | 4 ++--
1 file changed, 2 insertions(+), 2
Hi Stefan,
Thanks for your comments, and some feedback below:
> > +
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
>
> I think you don't use i2c here anymore, so this include (and probably a lot
> others) are obsolete.
>
Will change that in next versi
Hi Boris,
> Changes in v5:
> - drop the best_encoder() implementation
>
Why best_encoder() droped? It's not needed anymore?
Regards,
Meng
Hi Stefan,
> >> static const struct regmap_config fsl_dcu_regmap_config = {
> >> .reg_bits = 32,
> >> .reg_stride = 4,
> >> .val_bits = 32,
> >> .cache_type = REGCACHE_RBTREE,
> >
> > This needs to be a flat cache. See
> > https://lists.freedesktop.org/archives/dri-devel/2016-Janua
Hi Boris,
Sorry for reply late, I was on PTO. And another PTO on June 9~11, 2016.UTC+8
>
> > > + gpiod_set_value(sii902x->reset_gpio, 1);
> > > +
> > > + msleep(100);
> > Ouch that is some juicy number. Can we get a comment with
> > reasoning/origin of it ?
>
> As already explained
Hi Stefan,
Sorry for reply late, I was on PTO. And another PTO on June 9~11, 2016.UTC+8
> >> static const struct regmap_config fsl_dcu_regmap_config = {
> >> .reg_bits = 32,
> >> .reg_stride = 4,
> >> .val_bits = 32,
> >> .cache_type = REGCACHE_RBTREE,
> >
> > This needs to be a
.volatile_reg = fsl_dcu_drm_is_volatile_reg, };
I expect that regmap write as big endian, and I am seeing is regmap write as
little endian.
Thanks,
Best Regards,
Meng Yi
4,
.val_bits = 32,
.cache_type = REGCACHE_RBTREE,
// .reg_format_endian = REGMAP_ENDIAN_BIG,
// .val_format_endian = REGMAP_ENDIAN_BIG,
.volatile_reg = fsl_dcu_drm_is_volatile_reg,
};
Thanks,
Best Regards,
Meng Yi
find which commit caused that.
Since I am not familiar with regmap, hope you can give me some advice.
Thanks,
Best Regards,
Meng Yi
t works.
But "regmap_update_bits" still have the problem.
I had checked log of regmap, and didn't find which commit caused that.
I am not familiar with regmap, can you give some advices?
Thanks,
Best Regards,
Meng Yi
Hi Alexander,
> From: Alexander Stein [mailto:alexander.stein at systec-electronic.com]
> Sent: Wednesday, May 25, 2016 4:32 PM
> To: Stefan Agner
> Cc: Meng Yi ; dri-devel at lists.freedesktop.org; David
> Airlie
> ; airlied at redhat.com; linux-kernel at
> vger.ker
?
Thanks,
Meng
-----
From: Meng Yi
Sent: Tuesday, May 03, 2016 5:27 PM
To: 'dri-devel at lists.freedesktop.org' ;
David Airlie ; 'Stefan Agner' ;
'airlied at redhat.com'
Subject: fsl-dcu not works on latest "drm-next"
Hi,
Hi Boris,
On Monday, May 16, 2016 8:45 PM
Boris Brezillon wrote:
>
> Hi Meng,
>
> On Sun, 15 May 2016 16:34:44 +0800
> Meng Yi wrote:
>
> > This driver add the basic functions for Encoder, and link the Encoder
> > to appropriate DRM bridge.
> > Thi
Add port node to DCU node using "OF graph" discription.
Signed-off-by: Alison Wang
Signed-off-by: Xiubo Li
Signed-off-by: Jianwei Wang
Signed-off-by: Meng Yi
---
Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +
1 file changed, 9 insertions(+)
diff --git a/Doc
Signed-off-by: Xiubo Li
Signed-off-by: Jianwei Wang
Signed-off-by: Meng Yi
---
drivers/gpu/drm/fsl-dcu/Makefile | 1 +
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_hdmi.c | 194 +++
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c| 29
drivers/gpu/drm/fsl-dcu
Hi Stefan,
> -Original Message-
> From: Stefan Agner [mailto:stefan at agner.ch]
> Sent: Wednesday, May 04, 2016 12:08 AM
> To: Meng Yi
> Cc: dri-devel at lists.freedesktop.org; David Airlie ;
> airlied at redhat.com
> Subject: Re: fsl-dcu not works on latest &q
m [<80800a61>]
(kernel_init_freeable+0xd1/0x168)
[<80800a61>] (kernel_init_freeable) from [<80558d13>] (kernel_init+0x7/0xb4)
[<80558d13>] (kernel_init) from [<80205261>] (ret_from_fork+0x11/0x30)
---[ end trace b7946726c4e290c4 ]---
Console: switching to colour frame
Hi Boris,
> -Original Message-
> From: Boris Brezillon [mailto:boris.brezillon at free-electrons.com]
> +
> +static int sii902x_bridge_attach(struct drm_bridge *bridge) {
> + const struct drm_connector_funcs *funcs = &sii902x_connector_funcs;
> + struct sii902x *sii902x = bridge_t
Hi Boris,
On Wednesday, March 09, 2016 9:22 PM ,Boris Brezillon wrote:
>
> The reason I decided to expose the device as a drm_bridge is because there
> was several discussions about merging drm_bridge and drm_encoder_slave,
> and IIRC, the proposal was to move to the drm_bridge approach.
>
> An
Hi Emil,
On Wednesday, March 09, 2016 7:50 PM, Emil Velikov wrote:
> An alternative approach (making a drm bridge) for the sii902x devices was
> taken by Boris a bit before your initial submission of this driver [1].
> I believe that you guys can coordinate and once a decision is made whether a
>
DCU is the shortcut of 'display controller unit', some HDMI transmitter
attached to DCU, such as sii9022a, and this driver add the relavent
functions to DRM framewrok.
Signed-off-by: Meng Yi
Signed-off-by: Alison Wang
Signed-off-by: Xiubo Li
Signed-off-by: Jianwei Wang
---
Change
This patch adds sii9022a node for ls1021a-twr.
Signed-off-by: Meng Yi
Signed-off-by: Xiubo Li
Signed-off-by: Jianwei Wang
---
Change in v3:
Using of_graph to describe connection to DCU.
---
arch/arm/boot/dts/ls1021a-twr.dts | 18 ++
1 file changed, 18 insertions(+)
diff --git
The SiI9022A is an ultra low-power HDMI transmitter. It supports
resolutions from standard definition 480i/p and 576i/p all the way
to high-definition 720p, 1080i, and 1080p, the highest resolution
supported 4K today. It also supports all PC resolutions up
to UXGA for netbooks
Signed-off-by: Meng
Hi Stefan,
Thanks for pointing out those error, and I will fix them later, as I am the
newcomer of Linux world, hope you don't mind some stupid mistake I made.
Best Regards,
Yi
DCU is the shortcut of 'display controller unit', some HDMI transmitter
attached to DCU, such as sii9022a, and this driver add the relavent
functions to DRM framewrok.
Signed-off-by: Meng Yi
Signed-off-by: Alison Wang
Signed-off-by: Xiubo Li
Signed-off-by: Jianwei Wang
---
Change in
: Meng Yi
Signed-off-by: Xiubo Li
Signed-off-by: Jianwei Wang
---
arch/arm/boot/dts/ls1021a-twr.dts | 29 +
1 file changed, 29 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts
b/arch/arm/boot/dts/ls1021a-twr.dts
index 75ecaed..57107f7 100644
--- a/arch
: Meng Yi
Signed-off-by: Alison Wang
Signed-off-by: Xiubo Li
Signed-off-by: Jianwei Wang
---
drivers/gpu/drm/i2c/Kconfig | 6 +
drivers/gpu/drm/i2c/Makefile | 3 +
drivers/gpu/drm/i2c/sii9022_drv.c | 449 ++
3 files changed, 458 insertions
Hi Stefan,
I will take PTO during Chinese Spring Festival, and I will rebase my
patches according to your tree and send out after 2/16/2016 ^_^
BR
Meng
> On Wednesday, February 03, 2016 5:56 AM, Stefan Agner [stefan at agner.ch]
> wrote:
>
> Hi Meng Yi,
>
> I plan to r
Hi Rob
Thanks for your reply. I will correct those soon, and then send v2 out.
BR
Meng Yi
> On Friday, January 29, 2016 10:52 AM, Rob Herring[robh at kernel.org] wrote:
> > +The SiI9022A is an ultra low-power HDMI transmitter. It supports
> > +resolutions from standard defini
Hi, Stefan
I had tested your patch(https://lkml.org/lkml/2015/11/18/951) in ls1021-twr
board, I think you can merge this patch to your tree if Jianwei don't have any
objections.
> On Tuesday, January 26, 2016 1:45 PM, Stefan Agner
> wrote:
>
> As I wrote earlier
> (http://www.spinics.net/lis
DCU is the shortcut of 'display controller unit', some HDMI transmitter
attached to DCU, such as sii9022a, and this driver add the relavent
functions to DRM framewrok.
Signed-off-by: Meng Yi
---
.../bindings/display/bridge/sil,sii9022a.txt | 40 +++
drivers/gpu/drm/fsl-dc
: Meng Yi
---
drivers/gpu/drm/i2c/Kconfig | 6 +
drivers/gpu/drm/i2c/Makefile | 3 +
drivers/gpu/drm/i2c/sii9022_drv.c | 449 ++
3 files changed, 458 insertions(+)
create mode 100644 drivers/gpu/drm/i2c/sii9022_drv.c
diff --git a/drivers/gpu/drm
: Meng Yi
---
arch/arm/boot/dts/ls1021a-twr.dts | 29 +
1 file changed, 29 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts
b/arch/arm/boot/dts/ls1021a-twr.dts
index fad2e3b..462b6a1 100644
--- a/arch/arm/boot/dts/ls1021a-twr.dts
+++ b/arch/arm/boot/dts
From: Jianwei Wang
Switch update interrupt mask bit with regmap_update_bits, and clear
interrupt status by writing 1 to relevant bit before setting mask in
fsl_dcu_drm_irq_init function.
Signed-off-by: JianWei Wang
Signed-off-by: Meng Yi
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 26
ate will ultimately called, and we'll crash since
plane->state->fb is NULL.
> -----Original Message-
> From: Stefan Agner [mailto:stefan at agner.ch]
> Sent: Thursday, January 14, 2016 1:54 PM
> To: Emil Velikov
> Cc: Meng Yi ; ML dri-devel devel at lists.freedesktop.
For state->fb or state->crtc may be NULL in fsl_dcu_drm_plane_atomic_check
function, if so, return 0.
Signed-off-by: Meng Yi
Signed-off-by: Jianwei Wang
---
change in v2:
-Add state->crtc check
-return 0 when state->fb or state->crtc is NULL, instead of -EINVAL
Adviced
For state->fb may be NULL in fsl_dcu_drm_plane_atomic_check function, if
so, return 0. No need check in fsl_dcu_drm_plane_atomic_update anymore.
Signed-off-by: Meng Yi
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --gi
Hi, Daniel
Thanks for your clarification, and I will fix this error.
--
Meng
-Original Message-
From: Daniel Stone [mailto:dan...@fooishbar.org]
Sent: Friday, January 01, 2016 11:10 PM
To: Meng Yi
Cc: Stefan Agner ; dri-devel at lists.freedesktop.org; Yi
Meng-B56799
Subject
so
sure, and what do you think?
--
Meng Yi
-Original Message-
From: Stefan Agner [mailto:ste...@agner.ch]
Sent: Sunday, December 27, 2015 11:54 AM
To: Meng Yi
Cc: Dongsheng Wang ; airlied at linux.ie;
dri-devel at lists.freedesktop.org; Jianwei Wang ; Yi Meng-B56799
Subject: Re: ç
Tested-by: Meng Yi
-é®ä»¶å件-
å件人: Dongsheng Wang [mailto:Dongsheng.Wang at freescale.com]
åéæ¶é´: Tuesday, December 01, 2015 4:16 PM
æ¶ä»¶äºº: airlied at linux.ie
æé: stefan at agner.ch; dri-devel at lists.freedesktop.org; Jianwei Wang
; Yi Meng-B56799 ; Wang
90 matches
Mail list logo
