Hi,
On 17.06.23 19:42, Krzysztof Kozlowski wrote:
> On 17/06/2023 18:34, Heiko Stübner wrote:
>> Am Samstag, 17. Juni 2023, 12:12:17 CEST schrieb Krzysztof Kozlowski:
>>> On 14/06/2023 21:08, Maximilian Weigand wrote:
>>>> From: Maximilian Weigand
>>>&
From: Maximilian Weigand
The led driver supports changing the switching frequency of the boost
converter by two means: the base switching frequency can be changed from
500 kHz to 1 MHz, and a frequency shift can be activated, leading to
switching frequencies of 560 kHz or 1.12 Mhz, respectively
From: Maximilian Weigand
The PineNote exhibits visible flickering of its backlight for certain
brightness settings. Alleviate this by enabling a frequency shift from
500 kHz to 560 kHz for the boost converter of the led driver.
Signed-off-by: Maximilian Weigand
---
arch/arm64/boot/dts
t_cool/brightness
Signed-off-by: Maximilian Weigand
---
Maximilian Weigand (3):
backlight: lm3630a: add support for changing the boost frequency
dt-bindings: backlight: lm3630a: add entries to control boost frequency
arm64: dts: rockchip: shift boost frequency for rk3566-pinenote bac
From: Maximilian Weigand
Add 'ti,boost_use_1mhz' to switch between 500 kHz and 1 MHz boost
converter switching frequency, and add 'ti,boost_frequency_shift' to
activate a frequency shift to 560 kHz or 1.12 MHz, respectively.
Signed-off-by: Maximilian Weigand
---
.../bin
>> +if (backlight_is_blank(bl) || (bl->props.brightness < 0x4))
> You could replace bl->props.brightness with backlight_get_brightness(bl)
> to avoid direct access to the properties.
Thanks. Changed in v2.
>> +/* turn the string off */
>> ret |= lm3630a_update(pchi
From: Maximilian Weigand
Use backlight_is_blank() to determine if the led strings should be turned
off in the update_status() functions of both strings.
Reviewed-by: Daniel Thompson
Signed-off-by: Maximilian Weigand
---
Changes in v2:
- fix description, replace display_is_black() with
>> Use display_is_blank() to determine if the led strings should be turned
>
> Shouldn't this be backlight_is_blank()?
Yes, indeed. Thanks for pointing this out. Fixed in v2.
From: Maximilian Weigand
Use display_is_blank() to determine if the led strings should be turned
off in the update_status() functions of both strings.
Signed-off-by: Maximilian Weigand
---
drivers/video/backlight/lm3630a_bl.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff
