Re: [PATCH v10 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2025-04-23 Thread Matthias Brugger
On 23/04/2025 11:36, Jianeng Ceng wrote: MT8186 ponyta, known as huaqin custom label, is a MT8186 based laptop. It is based on the "corsola" design. It includes LTE, touchpad combinations. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Jianeng Ceng Reviewed-by: Matthi

Re: [PATCH] drm/v3d: Drop allocation of object without mountpoint

2024-10-29 Thread Matthias Brugger
Hi Maria, On 29/10/2024 01:41, Maíra Canal wrote: Hi Matthias, Thanks for your patch! On 28/10/24 11:27, matthias@kernel.org wrote: From: Matthias Brugger Function drm_gem_shmem_create_with_mnt() creates an object without using the mountpoint if gemfs is NULL. Drop the else branch

Re: [PATCH v2] drm/mediatek: Fix color format MACROs in OVL

2024-10-16 Thread Matthias Brugger
s in these formats MACROs, which cause the return value to be incorrect. Fix the typos to ensure the return value remains unchanged. Fixes: 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in OVL") Signed-off-by: Hsin-Te Yuan Reviewed-by: Matthias Brugger --- Changes in v2

Re: [PATCH v8 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-10-02 Thread Matthias Brugger
On 14/09/2024 08:31, Jianeng Ceng wrote: Ponyta is a custom label Chromebook based on MT8186. It is a self-developed project of Huaqin and has no fixed OEM. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski Signed-off-by: Jianeng Ceng Reviewed-by: Matthias Brugger

Re: [PATCH 4/5] drm/mediatek: dp: constify regmap_config

2024-09-09 Thread Matthias Brugger
On 08/09/2024 16:21, Krzysztof Kozlowski wrote: Mark local static 'struct regmap_config' as const for safer and more obvious code. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk_dp.c | 2 +- 1 file changed, 1 inser

Re: [PATCH v3 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-05 Thread Matthias Brugger
On 04/09/2024 10:14, Jianeng Ceng wrote: This is v3 of the MT8186 Chromebook device tree series. Please send this kind of patches also to the mediatek mailinglist: moderated list:ARM/Mediatek SoC support Thanks Matthias --- Changes in v3: - PATCH 0/2: Add the modify records. - PATCH 1/2:

Re: [PATCH v3 1/1] drm/mediatek: Fix get efuse issue for MT8188 DPTX

2024-09-04 Thread Matthias Brugger
it: no new-line here :) Signed-off-by: Liankun Yang Reviewed-by: Matthias Brugger --- Changes in V3: - Add Fixes tag. - Update the commit title. - Update the commit description. - Update change log position in commit message. Thanks, you could have added my Reviewed-by tag, as the feedback

Re: [PATCH v4 2/3] media: platform: mtk-mdp3: Use cmdq_pkt_create() and cmdq_pkt_destroy()

2024-09-04 Thread Matthias Brugger
On 03/09/2024 11:39, CK Hu (胡俊光) wrote: Hi, Matthias: On Mon, 2024-09-02 at 17:31 +0200, Matthias Brugger wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. On 01/09/2024 16:32, Chun-Kuang Hu wrote: Use

Re: [PATCH v3 26/81] drm/mediatek: Run DRM default client setup

2024-09-02 Thread Matthias Brugger
s the default if no format has been given, leave it out entirely. Signed-off-by: Thomas Zimmermann Cc: Chun-KuaIng Hu Cc: Philipp Zabel Cc: Matthias Brugger Cc: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 +++- 1 file chang

Re: [PATCH v4 3/3] arm64: dts: mediatek: mt8186: Add svs node

2024-09-02 Thread Matthias Brugger
On 30/08/2024 10:45, Rohit Agarwal wrote: Add clock/irq/efuse setting in svs nodes for mt8186 SoC. Signed-off-by: Rohit Agarwal Applied, thanks --- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/mediat

Re: [PATCH v4 2/3] arm64: dts: mediatek: mt8186: Add power domain for DPI

2024-09-02 Thread Matthias Brugger
On 30/08/2024 10:45, Rohit Agarwal wrote: Add power domain phandle to the DPI controller in mediatek mt8186 SoC. Signed-off-by: Rohit Agarwal Applied, thanks --- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/m

Re: [PATCH v4 3/3] soc: mediatek: cmdq: Remove cmdq_pkt_finalize() helper function

2024-09-02 Thread Matthias Brugger
On 01/09/2024 16:32, Chun-Kuang Hu wrote: In order to have fine-grained control, use cmdq_pkt_eoc() and cmdq_pkt_jump_rel() to replace cmdq_pkt_finalize(). Signed-off-by: Chun-Kuang Hu Acked-by: Matthias Brugger --- drivers/soc/mediatek/mtk-cmdq-helper.c | 22

Re: [PATCH v4 2/3] media: platform: mtk-mdp3: Use cmdq_pkt_create() and cmdq_pkt_destroy()

2024-09-02 Thread Matthias Brugger
On 01/09/2024 16:32, Chun-Kuang Hu wrote: Use cmdq_pkt_create() and cmdq_pkt_destroy() common function instead of implementing mdp3 version. Signed-off-by: Chun-Kuang Hu --- .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c| 46 ++- .../platform/mediatek/mdp3/mtk-mdp3-cmdq.h

Re: [PATCH v4 1/3] media: platform: mtk-mdp3: Get fine-grain control of cmdq_pkt_finalize()

2024-09-02 Thread Matthias Brugger
On 01/09/2024 16:32, Chun-Kuang Hu wrote: In order to have fine-grained control, use cmdq_pkt_eoc() and cmdq_pkt_jump_rel() to replace cmdq_pkt_finalize(). Signed-off-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 3

Re: [PATCH v2 1/1] drm/mediatek: Fix get efuse issue for MT8188 DPTX

2024-09-02 Thread Matthias Brugger
-off-by, as we don't want that in the commit message later. Reviewed-by: Matthias Brugger Signed-off-by: Liankun Yang --- drivers/gpu/drm/mediatek/mtk_dp.c | 85 ++- 1 file changed, 84 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mt

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread Matthias Brugger
turn -ENOMEM; + } Reviewed-by: Matthias Brugger out: kfree(sgt); iosys_map_set_vaddr(map, mtk_gem->kvaddr);

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

2023-07-04 Thread Matthias Brugger
dwmac.yaml | 2 +- [...] .../bindings/phy/mediatek,dsi-phy.yaml | 2 +- [...] .../devicetree/bindings/usb/mediatek,mtu3.yaml | 2 +- .../devicetree/bindings/usb/ti,am62-usb.yaml | 2 +- For MediaTek parts: Reviewed-by: Matthias Brugger 15 files changed, 30 inserti

Re: [PATCH v2, 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code

2023-06-19 Thread Matthias Brugger
On 16/06/2023 09:36, Shuijing Li wrote: For mt8188, add dsi cmdq reg control to send long packets to panel initialization. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi Reviewed-by: Matthias Brugger --- Changes in v2: use mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL

Re: [PATCH v8 2/2] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

2023-06-09 Thread Matthias Brugger
: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen Acked-by: Matthias Brugger CK didn't pick up this patch. Since the other patch already got picked up in v6.4-rc1, could you merge this for v6.5? Yes, I gave an acked-by as I thought that CK will take both of them. Anyway applied now. Mat

Re: [RESEND 05/15] drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header

2023-06-09 Thread Matthias Brugger
rning: Function parameter or member 'data' not described in 'mtk_disp_ccorr' Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Matthias Brugger Cc: AngeloGioacchino Del Regno Cc: dri-devel@lists.freedesktop.org Cc: linux-media...@lists.infradead.org Cc:

Re: [PATCH] arm64: dts: mediatek: mt8173-elm: remove panel model number in DT

2023-05-29 Thread Matthias Brugger
On 29/05/2023 10:45, Icenowy Zheng wrote: 在 2023-05-29星期一的 10:02 +0200,AngeloGioacchino Del Regno写道: Il 26/05/23 16:24, Doug Anderson ha scritto: Hi, On Fri, May 26, 2023 at 3:09 AM Icenowy Zheng wrote: Currently a specific panel number is used in the Elm DTSI, which is corresponded to a

Re: [PATCH 03/27] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT6795

2023-05-29 Thread Matthias Brugger
Hi Chun-Kuang Hu, Can you help to merge the missing DT-binding patches in this series? Thanks a lot, Matthias On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using the same parameters as MT8183. Signed-off-by: AngeloGioacch

Re: [PATCH 02/27] dt-bindings: phy: mediatek, dsi-phy: Add compatible for MT6795 Helio X10

2023-05-29 Thread Matthias Brugger
On 14/04/2023 10:22, Krzysztof Kozlowski wrote: On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for MediaTek Helio X10 MT6795: this SoC uses the same DSI PHY as MT8173. Signed-off-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/phy/medi

Re: [PATCH 25/27] arm64: dts: mediatek: mt6795-xperia-m5: Add eMMC, MicroSD slot, SDIO

2023-05-29 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Configure and enable the MMC0/1/2 controllers, used for the eMMC chip, MicroSD card slot and SDIO (WiFi) respectively. Signed-off-by: AngeloGioacchino Del Regno Applied, thanks --- .../dts/mediatek/mt6795-sony-xperia-m5.dts| 9

Re: [PATCH 24/27] arm64: dts: mediatek: mt6795-xperia-m5: Add MT6331 Combo PMIC

2023-05-29 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: This smartphone uses the Helio X10 standard MT6331+MT6332 combo PMICs: include the mt6331 devicetree and add the required interrupt. Note that despite there being two interrupts, one for MT6331 and one for MT6332, in configurations using

Re: [PATCH 23/27] arm64: dts: mediatek: Add MT6331 PMIC devicetree

2023-05-29 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: MT6331 is the primary PMIC for the MediaTek Helio X10 MT6795 smartphone platforms: add a devicetree describing its regulators, Real Time Clock and PMIC-keys. Signed-off-by: AngeloGioacchino Del Regno Applied, thanks --- arch/arm6

Re: [PATCH 21/27] arm64: dts: mediatek: mt6795: Add PMIC Wrapper node

2023-05-29 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add the pwrap node: this is used to communicate with the PMIC(s). Signed-off-by: AngeloGioacchino Del Regno Applied thanks! --- arch/arm64/boot/dts/mediatek/mt6795.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --g

Re: [PATCH 18/27] arm64: dts: mediatek: mt6795: Add support for IOMMU and LARBs

2023-05-29 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add nodes for the multimedia IOMMU and its LARBs: this includes all but the MJC LARB, which cannot currently be used and will be added later. Signed-off-by: AngeloGioacchino Del Regno Applied, thanks --- arch/arm64/boot/dts/mediat

Re: [PATCH 17/27] arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks

2023-05-29 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add the MultiMedia System node, providing clocks for the multimedia hardware blocks and their IOMMU/SMIs. Signed-off-by: AngeloGioacchino Del Regno Applied, thanks --- arch/arm64/boot/dts/mediatek/mt6795.dtsi | 13 +

Re: [PATCH 16/27] arm64: dts: mediatek: mt6795: Add support for the CMDQ/GCE mailbox

2023-05-29 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: In preparation for adding multimedia blocks, add the CMDQ/GCE mailbox. Signed-off-by: AngeloGioacchino Del Regno Applied, thanks --- arch/arm64/boot/dts/mediatek/mt6795.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff

Re: [PATCH 01/27] dt-bindings: pwm: Add compatible for MediaTek MT6795

2023-05-29 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for MediaTek Helio X10 MT6795's display PWM block: this is the same as MT8173. Signed-off-by: AngeloGioacchino Del Regno Applied, thanks! --- Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4

Re: [PATCH v2] phy: mediatek: rework the floating point comparisons to fixed point

2023-05-08 Thread Matthias Brugger
On 02/05/2023 16:50, Tom Rix wrote: gcc on aarch64 reports drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c: In function ‘mtk_hdmi_pll_set_rate’: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:240:52: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 240 | e

Re: [PATCH 29/53] drm/mediatek: Convert to platform remove callback returning void

2023-05-08 Thread Matthias Brugger
void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk_disp_aal.c | 6 ++ drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 6 ++ drivers/gpu/drm/mediatek/mtk_disp_color.c | 6 ++ drivers/gpu/drm/mediatek/mtk_disp_ga

Re: [PATCH 28/53] drm/mediatek: Convert to platform remove callback returning void

2023-05-08 Thread Matthias Brugger
rning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk_cec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_cec.c b/drivers/gpu/drm/mediatek/mtk_cec.c index b640bc0559e7..f47f417d8ba6 1

Re: [PATCH] phy: mediatek: fix returning garbage

2023-05-08 Thread Matthias Brugger
On 08/05/2023 09:48, Vinod Koul wrote: On 05-05-23, 17:37, Matthias Brugger wrote: On 05/05/2023 11:28, Vinod Koul wrote: On 14-04-23, 08:22, Tom Rix wrote: clang reports drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable 'ret' is uninitialized when used her

Re: [PATCH] phy: mediatek: fix returning garbage

2023-05-05 Thread Matthias Brugger
On 05/05/2023 11:28, Vinod Koul wrote: On 14-04-23, 08:22, Tom Rix wrote: clang reports drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized] if (ret) ^~~ ret should have been set by the prece

Re: [PATCH v2 2/2] drm/mediatek: Add DSI support for mt8188 vdosys0

2023-04-27 Thread Matthias Brugger
On 27/04/2023 10:40, Jason-JH.Lin wrote: Add DSI as main display output for mt8188 vdosys0. Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1

Re: [PATCH v2 1/2] drm/mediatek: Add ability to support dynamic connector selection

2023-04-27 Thread Matthias Brugger
On 27/04/2023 10:40, Jason-JH.Lin wrote: 1. Move output drm connector from each ddp_path array to connector array. 2. Add dynamic select available connector flow in crtc create and enable. Signed-off-by: Nancy Lin Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/m

Re: [PATCH] phy: mediatek/mt8195: fx mtk_hdmi_pll_calc() return code

2023-04-18 Thread Matthias Brugger
Hi Arnd, On 14/04/2023 09:58, Arnd Bergmann wrote: From: Arnd Bergmann The newly added function returns an uninitialized variable: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized] Wire it up to the return code

Re: [PATCH 01/27] dt-bindings: pwm: Add compatible for MediaTek MT6795

2023-04-18 Thread Matthias Brugger
On 14/04/2023 07:43, Uwe Kleine-König wrote: Hello, On Wed, Apr 12, 2023 at 01:27:13PM +0200, AngeloGioacchino Del Regno wrote: Add a compatible string for MediaTek Helio X10 MT6795's display PWM block: this is the same as MT8173. Signed-off-by: AngeloGioacchino Del Regno Acked-by: Uwe

Re: [PATCH] dt-bindings: display: mediatek: simplify compatibles syntax

2023-04-14 Thread Matthias Brugger
of further growth of the entire binding. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Matthias Brugger --- Cc: angelogioacchino.delre...@collabora.com --- .../bindings/display/mediatek/mediatek,ccorr.yaml | 7 +++ .../bindings/display/mediatek/mediatek,color.y

Re: [PATCH v2 1/2] phy: mediatek: hdmi: mt8195: fix uninitialized variable usage in pll_calc

2023-04-14 Thread Matthias Brugger
On 14/04/2023 18:07, Guillaume Ranquet wrote: The ret variable in mtk_hdmi_pll_calc() was used unitialized as reported by the kernel test robot. Fix the issue by removing the variable altogether and testing out the return value of mtk_hdmi_pll_set_hw() Fixes: 45810d486bb44 ("phy: mediatek: a

Re: [PATCH] phy: mediatek: fix returning garbage

2023-04-14 Thread Matthias Brugger
On 14/04/2023 17:43, Matthias Brugger wrote: On 14/04/2023 14:22, Tom Rix wrote: clang reports drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable    'ret' is uninitialized when used here [-Werror,-Wuninitialized] if (ret) ^~~ ret should have b

Re: [PATCH] phy: mediatek: fix returning garbage

2023-04-14 Thread Matthias Brugger
pll_set_hw. Fixes: 45810d486bb4 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195") Signed-off-by: Tom Rix Reviewed-by: Matthias Brugger --- drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/phy/mediatek/phy-

Re: [PATCH 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code

2023-04-13 Thread Matthias Brugger
On 13/04/2023 08:09, xinlei@mediatek.com wrote: From: Xinlei Lee For mt8188, add dsi cmdq reg control to send long packets to panel initialization. Signed-off-by: Xinlei Lee Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 12 1 file changed, 12 inser

Re: [PATCH 2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c

2023-04-13 Thread Matthias Brugger
On 13/04/2023 08:09, xinlei@mediatek.com wrote: From: Xinlei Lee Add the compatible because there are different definitions for cmdq register bit control in mt8188. Signed-off-by: Xinlei Lee Signed-off-by: Jitao Shi Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek

Re: [PATCH 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188

2023-04-13 Thread Matthias Brugger
On 13/04/2023 08:09, xinlei@mediatek.com wrote: From: Xinlei Lee Add dt-binding documentation of dsi for MediaTek MT8188 SoC. Signed-off-by: Xinlei Lee Signed-off-by: Jitao Shi Reviewed-by: Matthias Brugger --- .../devicetree/bindings/display/mediatek/mediatek,dsi.yaml

Re: [PATCH 02/27] dt-bindings: phy: mediatek, dsi-phy: Add compatible for MT6795 Helio X10

2023-04-13 Thread Matthias Brugger
On 12/04/2023 15:17, AngeloGioacchino Del Regno wrote: Il 12/04/23 15:12, Alexandre Mergnat ha scritto: On 12/04/2023 15:03, AngeloGioacchino Del Regno wrote: Il 12/04/23 14:59, Alexandre Mergnat ha scritto: On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for

Re: [PATCH 01/27] dt-bindings: pwm: Add compatible for MediaTek MT6795

2023-04-13 Thread Matthias Brugger
On 12/04/2023 23:03, Rob Herring wrote: On Wed, 12 Apr 2023 13:27:13 +0200, AngeloGioacchino Del Regno wrote: Add a compatible string for MediaTek Helio X10 MT6795's display PWM block: this is the same as MT8173. Signed-off-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bin

Re: [PATCH 27/27] arm64: dts: mediatek: mt6795-xperia-m5: Add Bosch BMM050 Magnetometer

2023-04-12 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: This smartphone features a Bosch BMM050 Magnetometer on I2C3: enable it with the BMM150 binding, as that driver supports BMM050 as well. For this sensor, there is no interrupt pin; readings were validated in sysfs. Signed-off-by: AngeloGi

Re: [PATCH 26/27] arm64: dts: mediatek: mt6795-xperia-m5: Add Bosch BMA255 Accelerometer

2023-04-12 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add the BMA255 Accelerometer on I2C3 and its pin definitions. Signed-off-by: AngeloGioacchino Del Regno Applied, thanks --- .../boot/dts/mediatek/mt6795-sony-xperia-m5.dts | 15 +++ 1 file changed, 15 insertions(+)

Re: [PATCH 20/27] arm64: dts: mediatek: mt6795: Add tertiary PWM node

2023-04-12 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: The PWM at 0x11006000 is the tertiary PWM; unlike PWM0, PWM1, this is not display specific and can be used as a generic PWM controller. This node is left disabled as usage is board-specific. Signed-off-by: AngeloGioacchino Del Regno

Re: [PATCH 22/27] arm64: dts: mediatek: mt6795: Copyright header additions

2023-04-12 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: I have added more than 800 lines to this devicetree: adding myself to the copyright header. Signed-off-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt6795.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a

Re: [PATCH 15/27] dt-bindings: mailbox: mediatek,gce-mailbox: Add support for MT6795

2023-04-12 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for the MT6795 Helio X10 SoC using MT8173 binding and add a header for the MT6795's GCE mailbox. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Krzysztof Kozlowski Reviewed-by: Matthias Br

Re: [PATCH 14/27] dt-bindings: display: mediatek: od: Add compatible for MediaTek MT6795

2023-04-12 Thread Matthias Brugger
t8173-disp-od Reviewed-by: Matthias Brugger reg: maxItems: 1

Re: [PATCH 13/27] dt-bindings: display: mediatek: ufoe: Add compatible for MediaTek MT6795

2023-04-12 Thread Matthias Brugger
ed-by: Matthias Brugger reg: maxItems: 1

Re: [PATCH 12/27] dt-bindings: display: mediatek: split: Add compatible for MediaTek MT6795

2023-04-12 Thread Matthias Brugger
ed-by: Matthias Brugger reg: maxItems: 1

Re: [PATCH 11/27] dt-bindings: display: mediatek: merge: Add compatible for MediaTek MT6795

2023-04-12 Thread Matthias Brugger
const: mediatek,mt8173-disp-merge Reviewed-by: Matthias Brugger reg: maxItems: 1

Re: [PATCH 09/27] dt-bindings: display: mediatek: color: Add compatible for MediaTek MT6795

2023-04-12 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for MediaTek Helio X10 MT6795's COLOR block: this is the same as MT8173. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger --- .../devicetree/bindings/display/mediatek/med

Re: [PATCH 08/27] dt-bindings: display: mediatek: wdma: Add compatible for MediaTek MT6795

2023-04-12 Thread Matthias Brugger
ed-by: Matthias Brugger reg: maxItems: 1

Re: [PATCH 05/27] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT6795

2023-04-12 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for MediaTek Helio X10 MT6795, using the same DSI block as MT8173. Signed-off-by: AngeloGioacchino Del Regno --- .../display/mediatek/mediatek,dsi.yaml| 19 --- 1 file changed, 12 inser

Re: [PATCH 04/27] dt-bindings: display: mediatek: aal: Add compatible for MediaTek MT6795

2023-04-12 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for MediaTek Helio X10 MT6795: similarly to MT8173, this SoC has the gamma LUT registers in DISP_AAL. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger --- .../devicetree/bindings

Re: [PATCH 03/27] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT6795

2023-04-12 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using the same parameters as MT8183. Signed-off-by: AngeloGioacchino Del Regno --- .../display/mediatek/mediatek,dpi.yaml| 23 +++ 1 file changed,

Re: [PATCH 02/27] dt-bindings: phy: mediatek, dsi-phy: Add compatible for MT6795 Helio X10

2023-04-12 Thread Matthias Brugger
expect more SoCs to share the same fallback in the future, apart from keeping in sync with other comaptibles described here, so: Reviewed-by: Matthias Brugger - items: - enum: - mediatek,mt8365-mipi-tx

Re: [PATCH 01/27] dt-bindings: pwm: Add compatible for MediaTek MT6795

2023-04-12 Thread Matthias Brugger
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for MediaTek Helio X10 MT6795's display PWM block: this is the same as MT8173. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger --- Documentation/devicetree/bindings/pwm/med

Re: [PATCH -next 3/3] drm/mediatek: Use devm_platform_ioremap_resource()

2023-04-12 Thread Matthias Brugger
On 12/04/2023 08:46, Yang Li wrote: Remove variable 'res' and convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li Reviewed-by: Matthias Brugger ---

Re: [PATCH -next 2/3] drm/mediatek: Use devm_platform_ioremap_resource()

2023-04-12 Thread Matthias Brugger
On 12/04/2023 08:46, Yang Li wrote: Remove variable 'res' and convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li Reviewed-by: Matthias Brugger ---

Re: [PATCH -next 1/3] drm/mediatek: Use devm_platform_ioremap_resource()

2023-04-12 Thread Matthias Brugger
On 12/04/2023 08:46, Yang Li wrote: Remove variable 'res' and convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li Reviewed-by: Matthias Brugger ---

Re: [PATCH v3 1/9] drm/mediatek: dp: Cache EDID for eDP panel

2023-04-12 Thread Matthias Brugger
On 12/04/2023 10:06, AngeloGioacchino Del Regno wrote: Il 12/04/23 09:08, Matthias Brugger ha scritto: On 04/04/2023 12:47, AngeloGioacchino Del Regno wrote: Since eDP panels are not removable it is safe to cache the EDID: this will avoid a relatively long read transaction at every PM

Re: [PATCH v3 1/9] drm/mediatek: dp: Cache EDID for eDP panel

2023-04-12 Thread Matthias Brugger
On 04/04/2023 12:47, AngeloGioacchino Del Regno wrote: Since eDP panels are not removable it is safe to cache the EDID: this will avoid a relatively long read transaction at every PM resume that is unnecessary only in the "special" case of eDP, hence speeding it up a little, as from now on, as

Re: [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC

2023-03-31 Thread Matthias Brugger
On 09/03/2023 15:23, Alexandre Mergnat wrote: Add compatible for the MT8365 SoC. Signed-off-by: Alexandre Mergnat Applied, thanks! --- Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindin

Re: [PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC

2023-03-31 Thread Matthias Brugger
Hi Chun-Kuang Hu, On 13/03/2023 16:02, Chun-Kuang Hu wrote: Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: Display Adaptive Ambient Light for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Reviewed-by: Chun-Kuang Hu I'm a bit puzzled

Re: [PATCH 14/21] dt-bindings: soc: mediatek: specify which compatible requires clocks property

2023-03-31 Thread Matthias Brugger
On 09/03/2023 15:23, Alexandre Mergnat wrote: According to the mtk-mutex.c driver and the SoC DTS, the clock isn't required to work properly for some of MTK SoC. Improve the clock requirement by adding a condition which is function to the compatible. Signed-off-by: Alexandre Mergnat Applie

Re: [PATCH v2] dt-bindings: display: mediatek: Fix the duplicated fallback

2023-03-17 Thread Matthias Brugger
nal error fixed here :) Signed-off-by: Alexandre Mergnat --- Fix MTK color correction binding The fallback compatible has been duplicated in the 137272ef1b0f commit. To: Chun-Kuang Hu To: Philipp Zabel To: David Airlie To: Daniel Vetter To: Rob Herring To: Krzysztof Kozlowski To:

Re: [PATCH 1/3] drm/mediatek: Refactor pixel format logic

2023-02-02 Thread Matthias Brugger
On 02/02/2023 21:41, Justin Green wrote: Yes, I had a comment on the naming in that patch. Never the less, I think if we don't need to "overwrite" the value, we should use just one struct for the values instead of copying them to the different .c files and give them SoC specific names. I don'

Re: [PATCH 1/3] drm/mediatek: Refactor pixel format logic

2023-02-02 Thread Matthias Brugger
On 02/02/2023 19:59, Justin Green wrote: Hi Matthias, mt8173_formats are the same as the old struct formats. Maybe we should use that and only overwrite where we actually use a different array. I think this was sort of how the original patch worked, but we wanted to add some flexibility to

Re: [PATCH 3/3] drm/mediatek: Enable AR30 and BA30 overlays on MT8195

2023-02-02 Thread Matthias Brugger
On 01/02/2023 18:02, Justin Green wrote: Tested using "modetest -P" on an MT8195 device. Signed-off-by: Justin Green --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl

Re: [PATCH 1/3] drm/mediatek: Refactor pixel format logic

2023-02-02 Thread Matthias Brugger
On 01/02/2023 18:02, Justin Green wrote: Add an DDP component interface for querying pixel format support and move list of supported pixel formats into DDP components instead of mtk_drm_plane.c Tested by running Chrome on an MT8195. Signed-off-by: Justin Green --- drivers/gpu/drm/mediatek

Re: [PATCH v2] drm/mediatek: dp: Only trigger DRM HPD events if bridge is attached

2023-02-02 Thread Matthias Brugger
Reviewed-by: Guillaume Ranquet Reviewed-by: Matthias Brugger --- Changes since v1 - Dropped prerequisite-patch-ids - Added Guillaume's Reviewed-by This applies on top of mediatek-drm-next. drivers/gpu/drm/mediatek/mtk_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-

Re: [PATCH v2 7/9] arm64: dts: mediatek: mt8186: Add DPI node

2023-01-19 Thread Matthias Brugger
On 18/01/2023 10:18, Allen-KH Cheng wrote: Add DPI node for MT8186 SoC. Signed-off-by: Allen-KH Cheng Tested-by: Chen-Yu Tsai Applied, thanks! --- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/media

Re: [PATCH v2 6/9] arm64: dts: mediatek: mt8186: Add audio controller node

2023-01-19 Thread Matthias Brugger
On 18/01/2023 10:18, Allen-KH Cheng wrote: Add audio controller node for MT8186 SoC. Signed-off-by: Allen-KH Cheng Applied, thanks! --- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 62 1 file changed, 62 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/m

Re: [PATCH v2 4/9] arm64: dts: mediatek: mt8186: Add ADSP mailbox nodes

2023-01-19 Thread Matthias Brugger
On 18/01/2023 10:18, Allen-KH Cheng wrote: Add ADSP mailbox node for MT8186 SoC. Signed-off-by: Allen-KH Cheng Applied, thanks! --- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/

Re: [PATCH v2 8/9] dt-bindings: display: mediatek: Fix the fallback for mediatek,mt8186-disp-ccorr

2023-01-19 Thread Matthias Brugger
ot;dt-bindings: display: mediatek: add MT8186 SoC binding") Signed-off-by: Allen-KH Cheng Reviewed-by: Rob Herring Reviewed-by: Matthias Brugger --- .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc

Re: [PATCH v2 2/9] dt-bindings: spmi: spmi-mtk-pmif: Document mediatek,mt8195-spmi as fallback of mediatek,mt8186-spmi

2023-01-19 Thread Matthias Brugger
On 18/01/2023 10:18, Allen-KH Cheng wrote: The mt8186-spmi is used as compatible with mt8195-spmi on the MT8186, document this situation. Signed-off-by: Allen-KH Cheng Reviewed-by: Rob Herring Reviewed-by: Matthias Brugger --- .../devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml

Re: [PATCH v4 0/6] Add first version mt8188 vdosys0 driver

2022-12-16 Thread Matthias Brugger
Applied patches 2,3,4,5 The rest will go through the DRM driver tree. Thanks! On 06/12/2022 03:00, nathan.lu wrote: From: Nathan Lu This patch is to add first version mt8188 vdosys0 driver Modify and add new files include: 1. bindings documents 2. mtk mmsys 3. mtk mutex 4. mtk drm driver Cha

Re: [PATCH v4 6/6] drm/mediatek: add mediatek-drm of vdosys0 support for mt8188

2022-12-16 Thread Matthias Brugger
On 06/12/2022 03:00, nathan.lu wrote: From: Nathan Lu add driver data of mt8188 vdosys0 to mediatek-drm and the sub driver. Signed-off-by: amy zhang Signed-off-by: Nathan Lu Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek

Re: [PATCH v4 1/6] dt-bindings: mediatek: modify VDOSYS0 display device tree Documentations for MT8188

2022-12-16 Thread Matthias Brugger
On 06/12/2022 03:00, nathan.lu wrote: From: Nathan Lu modify VDOSYS0 display device tree Documentations for MT8188. Signed-off-by: Nathan Lu Reviewed-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger --- .../devicetree/bindings/display

Re: [PATCH v28 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195

2022-11-22 Thread Matthias Brugger
On 22/11/2022 11:51, Nancy Lin (林欣螢) wrote: Dear Matthias, Thanks for the review. On Thu, 2022-11-10 at 14:10 +0100, Matthias Brugger wrote: On 09/11/2022 06:10, Jason-JH Lin (林睿祥) wrote: > On Tue, 2022-11-08 at 18:46 +0100, Matthias Brugger wrote: > > > > On 07/11/2022 0

Re: [PATCH v13,2/3] drm: mediatek: Set dpi format in mmsys

2022-11-21 Thread Matthias Brugger
On 24/10/2022 04:04, xinlei@mediatek.com wrote: From: Xinlei Lee Dpi output needs to adjust the output format to dual edge for MT8186. Co-developed-by: Jitao Shi Signed-off-by: Jitao Shi Signed-off-by: Xinlei Lee Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Reviewed-

Re: [PATCH v5 5/6] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195

2022-11-11 Thread Matthias Brugger
On 27/09/2022 17:27, Jason-JH.Lin wrote: Add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver. Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 28 2 files changed, 34

Re: [PATCH v28 05/11] soc: mediatek: refine code to use mtk_mmsys_update_bits API

2022-11-10 Thread Matthias Brugger
On 08/11/2022 20:43, Nícolas F. R. A. Prado wrote: On Tue, Nov 08, 2022 at 06:37:19PM +0100, Matthias Brugger wrote: On 07/11/2022 08:22, Nancy.Lin wrote: Simplify code for update mmsys reg. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Tested

Re: [PATCH v28 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195

2022-11-10 Thread Matthias Brugger
On 09/11/2022 06:10, Jason-JH Lin (林睿祥) wrote: On Tue, 2022-11-08 at 18:46 +0100, Matthias Brugger wrote: On 07/11/2022 08:22, Nancy.Lin wrote: > Add vdosys1 mmsys compatible for MT8195 platform. > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding > to &

Re: [PATCH v5 3/6] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2022-11-09 Thread Matthias Brugger
On 05/10/2022 09:08, Jason-JH.Lin wrote: Hi Matthias, Do you have any comment for this binding? Can you help us review the soc/mediatek related patches? Patches 1-3 applied now. Sorry for the late answer. Matthias Regards, Jason-JH.Lin On Wed, 2022-09-28 at 10:14 +0200, AngeloGioacchi

Re: [PATCH v5 6/6] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

2022-11-09 Thread Matthias Brugger
On 27/09/2022 17:27, Jason-JH.Lin wrote: After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, mmsys header can remove the useless DDP_COMPONENT_DITHER enum. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen Acked-by: Matthias Brugger

Re: [PATCH v28 04/11] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1

2022-11-09 Thread Matthias Brugger
On 08/11/2022 20:10, Nícolas F. R. A. Prado wrote: On Tue, Nov 08, 2022 at 06:46:54PM +0100, Matthias Brugger wrote: On 07/11/2022 08:22, Nancy.Lin wrote: [..] --- a/drivers/soc/mediatek/mtk-mmsys.c +++ b/drivers/soc/mediatek/mtk-mmsys.c @@ -80,6 +80,12 @@ static const struct

Re: [PATCH v13,0/3] Add dpi output format control for MT8186

2022-11-09 Thread Matthias Brugger
Hi Xinlei, On 09/11/2022 03:40, Xinlei Lee (李昕磊) wrote: On Tue, 2022-11-08 at 19:27 +0100, Matthias Brugger wrote: Hi Xinlei, Somehow b4 broke with your thread but I was able to apply patch 1 and 2 by hand. Thanks Matthias On 24/10/2022 04:04, xinlei@mediatek.com wrote: > From: Xin

Re: [PATCH v13,0/3] Add dpi output format control for MT8186

2022-11-08 Thread Matthias Brugger
Hi Xinlei, Somehow b4 broke with your thread but I was able to apply patch 1 and 2 by hand. Thanks Matthias On 24/10/2022 04:04, xinlei@mediatek.com wrote: From: Xinlei Lee Base on the branch of linus/master v6.1 rc1. Change since v12: 1. Add MT8186_ prefix to variables added in mt8186-

Re: [PATCH v13,1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func

2022-11-08 Thread Matthias Brugger
On 08/11/2022 19:11, Matthias Brugger wrote: Hi Xinlei, Can you please fix the threading of this patches. I can see that this 1/3 but I'm not able to find 3/3 in the series. The first two look good, the third, I don't know. Nevermind this message, the problem was on my side

Re: [PATCH v13,1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func

2022-11-08 Thread Matthias Brugger
Hi Xinlei, Can you please fix the threading of this patches. I can see that this 1/3 but I'm not able to find 3/3 in the series. The first two look good, the third, I don't know. Regards, Matthias On 24/10/2022 04:04, xinlei@mediatek.com wrote: From: Xinlei Lee The difference between

Re: [PATCH v28 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195

2022-11-08 Thread Matthias Brugger
On 07/11/2022 08:22, Nancy.Lin wrote: Add vdosys1 mmsys compatible for MT8195 platform. For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to 2 different power domains, different clock drivers and different mediatek-drm drivers. Signed-off-by: Nancy.Lin Reviewed-by: Nícolas

  1   2   3   4   >