Re: [PATCH v3 26/81] drm/mediatek: Run DRM default client setup

[Matthias Brugger]

On 30/08/2024 10:40, Thomas Zimmermann wrote:

Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.

The mediatek driver specifies a preferred color mode of 32. As this
is the default if no format has been given, leave it out entirely.

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: Chun-KuaIng Hu <chunkuang...@kernel.org>
Cc: Philipp Zabel <p.za...@pengutronix.de>
Cc: Matthias Brugger <matthias....@gmail.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delre...@collabora.com>

Reviewed-by: Matthias Brugger <matthias....@gmail.com>

---
  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c 
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 77b50c56c124..b1309a70fdcd 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -14,6 +14,7 @@

#include <drm/drm_atomic.h>

  #include <drm/drm_atomic_helper.h>
+#include <drm/drm_client_setup.h>
  #include <drm/drm_drv.h>
  #include <drm/drm_fbdev_dma.h>
  #include <drm/drm_fourcc.h>
@@ -610,6 +611,7 @@ static const struct drm_driver mtk_drm_driver = {
        .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,

.dumb_create = mtk_gem_dumb_create,

+       DRM_FBDEV_DMA_DRIVER_OPS,

.gem_prime_import = mtk_gem_prime_import,

        .gem_prime_import_sg_table = mtk_gem_prime_import_sg_table,
@@ -666,7 +668,7 @@ static int mtk_drm_bind(struct device *dev)
        if (ret < 0)
                goto err_deinit;

- drm_fbdev_dma_setup(drm, 32);

+       drm_client_setup(drm, NULL);

return 0;