Make use of dev_err_probe() to easily spot issues via the debugfs or
kernel log. No functional changes.
Signed-off-by: Marco Felsch
Reviewed-by: Laurent Pinchart
Reviewed-by: Alexander Stein
---
Changelog:
v2:
- add Laurent's r-b
- add Alexander's r-b
drivers/gpu/drm/bridge/fsl-
Make use of __free(device_node) to simplify the of_node_put() error
handling paths. No functional changes.
Signed-off-by: Marco Felsch
---
Changelog:
v2:
- drop __free() from panel_node
drivers/gpu/drm/bridge/fsl-ldb.c | 22 --
1 file changed, 8 insertions(+), 14 deletions
Hi,
just a small series to cleanup the fsl-ldb lvds bridge driver a bit.
Regards,
Marco
Marco Felsch (2):
drm/bridge: fsl-ldb: make use of dev_err_probe
drm/bridge: fsl-ldb: simplify device_node error handling
drivers/gpu/drm/bridge/fsl-ldb.c | 41 ++--
1 file
Hi Laurent,
On 25-05-15, Laurent Pinchart wrote:
> Hi Marco,
>
> On Thu, May 15, 2025 at 12:24:53AM +0200, Marco Felsch wrote:
> > Make use of __free(device_node) to simplify the of_node_put() error
> > handling paths. No functional changes.
> >
>
Hi Laurent,
On 25-05-15, Laurent Pinchart wrote:
> Hi Marco,
>
> Thank you for the patch.
>
> On Thu, May 15, 2025 at 12:24:51AM +0200, Marco Felsch wrote:
> > Make use of the drm_bridge::driver_private data instead of
> > container_of() wrapper.
>
> I supp
Make use of __free(device_node) to simplify the of_node_put() error
handling paths. No functional changes.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/bridge/fsl-ldb.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/bridge/fsl
Hi,
just a small series to cleanup the fsl-ldb lvds bridge driver a bit.
Regards,
Marco
Marco Felsch (3):
drm/bridge: fsl-ldb: make use of driver_private
drm/bridge: fsl-ldb: make use of dev_err_probe
drm/bridge: fsl-ldb: simplify device_node error handling
drivers/gpu/drm/bridge/fsl
Make use of the drm_bridge::driver_private data instead of
container_of() wrapper.
No functional changes.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/bridge/fsl-ldb.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b
Make use of dev_err_probe() to easily spot issues via the debugfs or
kernel log. No functional changes.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/bridge/fsl-ldb.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b
On 25-04-29, Alexander Stein wrote:
> Use dev_err_probe() to add a reason for deferred probe. This can
> especially happen on lcdif3 which uses hdmi_tx_phy for 'pix' clock
>
> Signed-off-by: Alexander Stein
Reviewed-by: Marco Felsch
On 25-02-27, Marek Vasut wrote:
> On 2/27/25 9:17 PM, Marco Felsch wrote:
>
> [...]
>
> > > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c
> > > b/drivers/gpu/drm/panthor/panthor_drv.c
> > > index 06fe46e320738..2504a456d45c4 100644
> >
Hi Marek,
On 25-02-27, Marek Vasut wrote:
> The instance of the GPU populated in Freescale i.MX95 is the
> Mali G310, add support for this variant.
>
> Signed-off-by: Marek Vasut
> ---
> Cc: Boris Brezillon
> Cc: Conor Dooley
> Cc: David Airlie
> Cc: Fabio Estevam
> Cc: Krzysztof Kozlowski
Add compatible to panel-simple for Jiangsu Smartwin Electronics
SMMT043480272A-A19 4.3" 480x272 LCD-TFT panel.
Acked-by: Conor Dooley
Signed-off-by: Marco Felsch
---
Changelog:
v2:
- rebased ontop of drm-misc-next
- added Conor's acked-by
.../devicetree/bindings/display/p
From: Rouven Czerwinski
Add support for the Jiangsu Smartwin SMMT043480272A-A19 4.3" 480x272
TFT-LCD panel. The timings are based on the ILI6485 controller IC
datasheet.
Signed-off-by: Rouven Czerwinski
Reviewed-by: Neil Armstrong
Signed-off-by: Marco Felsch
---
Changelog:
v2:
- re
Add compatible to panel-simple for Jiangsu Smartwin Electronics
SMMT043480272A-A19 4.3" 480x272 LCD-TFT panel.
Signed-off-by: Marco Felsch
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bin
From: Rouven Czerwinski
Add support for the Jiangsu Smartwin SMMT043480272A-A19 4.3" 480x272
TFT-LCD panel. The timings are based on the ILI6485 controller IC
datasheet.
Signed-off-by: Rouven Czerwinski
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/panel/panel-simple.c
On 24-02-04, Dmitry Baryshkov wrote:
> On Sat, 3 Feb 2024 at 17:53, Adam Ford wrote:
> >
> > From: Lucas Stach
> >
> > This adds the driver for the Samsung HDMI PHY found on the
> > i.MX8MP SoC.
> >
> > Signed-off-by: Lucas Stach
> > Signed-off-by: Adam Ford
> > Tested-by: Alexander Stein
> >
+Cc: stable
The commit misses the Fixes tag.
On Mon, Jul 31, 2023 at 02:47:47PM +0200, Neil Armstrong wrote:
> On 27/07/2023 19:24, Dmitry Baryshkov wrote:
> > Specify bpc value for the powertip_ph800480t013_idf02 panel to stop drm
> > code from complaining about unexpected bpc value (0).
> >
>
On 23-09-20, Lucas Stach wrote:
> The comment regarding AXI bust size configuration is a bit hard
> to read. Improve the wording somewhat.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Marco Felsch
gt; seems to be off.
>
> Unfortunately, a few more modes are still not working at all. The NXP
> downstream kernel has some quirks to handle some of the modes especially
> wrt. to the porches, but I cannot figure out, what the driver should
> actually do in these cases. Maybe there is stil
clk_get_rate(clk_get_parent(dsi->pll_clk));
> + while (fin > 30 * MHZ)
> + fin = fin / 2;
Really just a cosmetic nit: fin /= 2;
Reviewed-by: Marco Felsch
> + clk_set_rate(dsi->pll_clk, fin);
> +
> fin = clk_get_r
On 22-11-01, Marek Vasut wrote:
> On 11/1/22 17:51, Marco Felsch wrote:
> > On 22-11-01, Marek Vasut wrote:
> > > On 11/1/22 17:06, Marco Felsch wrote:
> > >
> > > Hi,
> > >
> > > > > > Also I understood the thresholds in such
On 22-11-01, Marek Vasut wrote:
> On 11/1/22 17:06, Marco Felsch wrote:
>
> Hi,
>
> > > > Also I understood the thresholds in such a way, that the FIFO watermark
> > > > must be higher but there is no place left when it is set to 3/3. In such
> > >
If a axi bus master with a higher priority do a lot of memory access
FIFO underruns can be inspected. Increase the burst size to 256B to
avoid such underruns and to improve the memory access efficiency.
Fixes: 9db35bb349a0 ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Signed-off
On 22-11-01, Marek Vasut wrote:
> On 11/1/22 15:04, Marco Felsch wrote:
> > Hi Marek, Liu,
>
> Hi,
>
> [...]
>
> > > > > Also IMHO the threshold should be taken wisely to not enter panic
> > > > > mode
> > > > > to early to n
Hi Marek, Liu,
On 22-10-28, Liu Ying wrote:
> On Fri, 2022-10-28 at 02:03 +0200, Marek Vasut wrote:
> > On 10/27/22 19:47, Marco Felsch wrote:
> > > On 22-10-27, Liu Ying wrote:
> > > > On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote:
> > >
On 22-10-27, Liu Ying wrote:
> On Thu, 2022-10-27 at 12:03 +0200, Marek Vasut wrote:
> > On 10/27/22 07:45, Liu Ying wrote:
> >
> > Hi,
> >
> > [...]
> >
> > > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > > > b/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > > > index a5302006c02cd..aee7babb5fa5c
On 22-10-27, Marek Vasut wrote:
> On 10/27/22 10:13, Marco Felsch wrote:
>
> Hi,
>
> [...]
>
> > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > > b/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > > index a5302006c02cd..aee7babb5fa5c 100644
> > &g
On 22-10-27, Marek Vasut wrote:
> On 10/27/22 10:04, Marco Felsch wrote:
> > Hi Marek,
>
> Hi,
>
> > On 22-10-26, Marek Vasut wrote:
> > > On 7/26/22 11:43, Marco Felsch wrote:
> > > > FIFO underruns are seen if a AXI bus master with a higher priorit
t;)
> Signed-off-by: Marek Vasut
> ---
> Cc: Kieran Bingham
> Cc: Laurent Pinchart
> Cc: Liu Ying
> Cc: Lucas Stach
> Cc: Marco Felsch
> Cc: Martyn Welch
> Cc: Peng Fan
> Cc: Sam Ravnborg
> ---
> drivers/gpu/drm/mxsfb/lcdif_kms.c | 15 ++
Hi Marek,
On 22-10-26, Marek Vasut wrote:
> On 7/26/22 11:43, Marco Felsch wrote:
> > FIFO underruns are seen if a AXI bus master with a higher priority do a
> > lot of memory access. Increase the burst size to 256B to avoid such
> > underruns and to improve the mem
Hi Robert,
On 22-08-29, Robert Foss wrote:
> Hey Marco,
>
> Sorry about the slow reply.
>
> This series no longer applies on drm-misc-next. Can you rebase this
> series and send it out a v2?
I can but I would rather prefer to get some feedback first. Right now I
just got a minor documentation i
3:44 AM Biju Das
> > > > wrote:
> > > > >
> > > > > Hi Adam and all,
> > > > >
> > > > > > Subject: Re: imx8mm lcdif->dsi->adv7535 no video, no errors
> > > > > >
> > > > >
Hi Adam,
On 22-08-04, Adam Ford wrote:
> On Thu, Aug 4, 2022 at 7:52 AM Marco Felsch wrote:
> >
> > Hi Dave,
> >
> > On 22-08-04, Dave Stevenson wrote:
> > > Hi Marco
> > >
> > > On Thu, 4 Aug 2022 at 10:38, Marco Felsch wrote:
> >
Hi Dave,
On 22-08-04, Dave Stevenson wrote:
> Hi Marco
>
> On Thu, 4 Aug 2022 at 11:28, Marco Felsch wrote:
> >
> > On 22-08-03, Dave Stevenson wrote:
> > > On Wed, 3 Aug 2022 at 13:31, Adam Ford wrote:
> >
> > ...
> >
> > > > Mi
Hi Dave,
On 22-08-04, Dave Stevenson wrote:
> Hi Marco
>
> On Thu, 4 Aug 2022 at 10:38, Marco Felsch wrote:
> >
> > Hi Dave, Adam,
> >
> > On 22-08-03, Dave Stevenson wrote:
> > > Hi Adam
> > >
> > > On Wed, 3 Aug 2022 at 12:03, Ad
On 22-08-03, Dave Stevenson wrote:
> On Wed, 3 Aug 2022 at 13:31, Adam Ford wrote:
...
> > Mine also states the DSI source needs to provide correct video timing
> > with start and stop sync packets.
> >
> > If I remember correctly, it seemed like Marek V wanted the hard coded
> > samsung,burst-c
On 22-08-03, Adam Ford wrote:
> On Wed, Aug 3, 2022 at 7:17 AM Dave Stevenson
...
> > Not meaning to butt in, but I have datasheets for ADV7533 and 7535
> > from previously looking at these chips.
>
> Thanks for the feedback.
>
> > Mine fairly plainly states:
> > "The DSI receiver input support
Hi Dave, Adam,
On 22-08-03, Dave Stevenson wrote:
> Hi Adam
>
> On Wed, 3 Aug 2022 at 12:03, Adam Ford wrote:
...
> > > Did managed to get access to the ADV7535 programming guide? This is the
> > > black box here. Let me check if I can provide you a link with our repo
> > > so you can test our
On 22-08-03, Adam Ford wrote:
> On Wed, Aug 3, 2022 at 1:20 AM Marco Felsch wrote:
> >
> > On 22-08-02, Adam Ford wrote:
> >
> > ...
> >
> > > > I did some reading about the internal timing generator. It appears
> > > > that it
On 22-08-02, Adam Ford wrote:
...
> > I did some reading about the internal timing generator. It appears
> > that it's required when video formats use fractional bytes, and it's
> > preconfigured to run at 720p by default, but registers 28h through 37h
> > configure it for other video modes.
>
>
Hi Adam,
sorry for the delay.
On 22-08-02, Adam Ford wrote:
...
> > > I think that the most important one is the blanking calc. Can you try to
> > > revert "drm/bridge: adv7511: Repair bus_flags and bus_format" and check
> > > if you can get a output still? Also something to try would be to dis
Hi Adam, Fabio,
On 22-08-01, Adam Ford wrote:
> On Mon, Aug 1, 2022 at 8:53 PM Fabio Estevam wrote:
> >
> > On Mon, Aug 1, 2022 at 10:39 PM Adam Ford wrote:
> >
> > > I managed to get my HDMI output working. I had the lanes set to 2
> > > instead of 4. Once I switched to 4-lanes, the monitor ca
Hi Fabio, Adam,
+Cc Marek, Robert, Laurentiu
On 22-08-01, Fabio Estevam wrote:
> Hi Adam,
>
> On Sat, Jul 30, 2022 at 12:16 PM Adam Ford wrote:
> >
> > Hey all,
> >
> > I am trying to test Jagan's patch series [1] to add support for the
> > samsung dsim bridge which is used on the imx8mm to out
On 22-07-28, Marco Felsch wrote:
> On 22-07-28, Liu Ying wrote:
> > On Wed, 2022-07-27 at 05:56 +0200, Marco Felsch wrote:
> > > Hi Marek, Liu,
> > >
> > > On 22-07-26, Liu Ying wrote:
> > > > On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote
On 22-07-28, Liu Ying wrote:
> On Wed, 2022-07-27 at 05:56 +0200, Marco Felsch wrote:
> > Hi Marek, Liu,
> >
> > On 22-07-26, Liu Ying wrote:
> > > On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote:
> > > > On 7/26/22 11:43, Marco Felsch wrote:
>
Hi Marek, Liu,
On 22-07-26, Liu Ying wrote:
> On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote:
> > On 7/26/22 11:43, Marco Felsch wrote:
> > > FIFO underruns are seen if a AXI bus master with a higher priority
> > > do a
> > > lot of memory access. Incr
FIFO underruns are seen if a AXI bus master with a higher priority do a
lot of memory access. Increase the burst size to 256B to avoid such
underruns and to improve the memory access efficiency.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/mxsfb/lcdif_kms.c | 16 ++--
drivers
Hi all,
gentle ping on this series since I didn't received much feedback for the
code.
Regards,
Marco
On 22-05-30, Marco Felsch wrote:
> Hi,
>
> the purpose of this small series is to enable the support for the reverse
> lane feature and to add support for reset controller
On 22-07-06, Lucas Stach wrote:
> There is no need to enforce a specific sync signal polarity on the
> DPI interface, as we can simply tell the TC358767 which polarities
> it should expect on the input interface.
>
> Signed-off-by: Lucas Stach
Reviewed-by: Marco Felsch
Hi Alexander,
On 22-05-31, Alexander Stein wrote:
> Hi Marco,
>
> Am Montag, 30. Mai 2022, 17:05:48 CEST schrieb Marco Felsch:
> > The bridge device can now also be enabled/disabled by an external reset
> > controller. So the device now supports either enable/disable by sim
Use the new helper to improve the debug capabilities.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index baf94b2b78a1
.
Therefore we need either the reset controller or a gpio to be present
and valid. The behaviour is changed in that way that a gpio or a reset
controller have to be successfully requested else the driver probe
fails, like the current behaviour.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm
The bridge device can now also be enabled/disabled by an external reset
controller. So the device now supports either enable/disable by simple
GPIO or by an Reset-Controller.
Signed-off-by: Marco Felsch
---
.../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml| 6 ++
1 file changed
No functional change. Just reuse the already existing val variable to
setup the register. This is in preparation for adding the new feature to
reverse the CHA/CHB lane orders. Without this change this call gets very
unreadable.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/bridge/ti-sn65dsi83
Hi,
the purpose of this small series is to enable the support for the reverse
lane feature and to add support for reset controllers which can drive
the enable pin.
Regards,
Marco
Marco Felsch (6):
drm/bridge: ti-sn65dsi83: make lvds lane register setup more readable
dt-bindings: drm
The chip can swap the LVDS channel A/B data lanes e.g. to improve the
layout characteristic. This commit adds the feature so the system
integrator can specify it within the device-tree.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 64 +++
1
The TI converter chip can swap the LVDS data lanes in a pre-defined
manner. This can be useful to improve the layout characteristic.
Signed-off-by: Marco Felsch
---
.../bindings/display/bridge/ti,sn65dsi83.yaml | 58 ++-
1 file changed, 56 insertions(+), 2 deletions(-)
diff
Add support for the 1024x600 LVDS panel.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/panel/panel-simple.c | 29
1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/panel-simple.c
index 4a2e580a2f7b
Add binding for the Emerging Display Technology ETML0700Y5DHA panel.
It is a 7" WSVGA (1024x600) TFT LCD panel with:
- LVDS data interface,
- backlight and
- capacitive touch.
Signed-off-by: Marco Felsch
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1
On 21-02-04 19:15, Oliver Graute wrote:
> On 02/02/21, Marco Felsch wrote:
> > Hi Oliver,
> >
> > On 21-02-02 18:35, Oliver Graute wrote:
> > > Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD
> > > to panel-simple.
> > >
>
Signed-off-by: Oliver Graute
> Cc: Marco Felsch
> Cc: Fabio Estevam
> ---
>
> v3:
>
> - added flags
> - added delay
Thanks, did you test the changes?
I just picked it from the datasheet.
Regards,
Marco
___
dri-devel maili
CAP-GLD-RGB.pdf
>
> Signed-off-by: Oliver Graute
> Cc: Marco Felsch
> Cc: Fabio Estevam
> ---
>
> v2:
>
> - changed bpc to 6
> - set max value of pixelclock
> - increased hfront_porch and hback_porch
> - dropped connector-type
>
> adding of bus_f
Add missing regulator_disable() as devm_action to avoid dedicated
unbind() callback and fix the missing error handling.
Fixes: fcbc51e54d2a ("staging: drm/imx: Add support for Television Encoder
(TVEv2)")
Signed-off-by: Marco Felsch
---
Note: This patch depends on: 14422f14da81 (
b5143 ("imx-drm: convert to componentised device support")
Signed-off-by: Philipp Zabel
[m.felsch@pengutronix: fix imx_tve_probe()]
[m.felsch@pengutronix: resort component_unbind_all())
[m.felsch@pengutronix: adapt commit message]
Signed-off-by: Marco Felsch
---
Hi,
I've tested th
Hi Liu,
pls check [1], I already send patches for it. Those stuck because we
need to verify Philipp's proposal.
[1] https://www.spinics.net/lists/arm-kernel/msg789309.html
Regards,
Marco
On 20-05-28 10:55, Liu Ying wrote:
> Gentle ping...
>
> On Tue, 2020-05-12 at 15:21 +0800, Liu Ying wrote
Hi Liu
On 20-05-28 10:58, Liu Ying wrote:
> Gentle ping...
Please check my "spring cleanup series" [1] which do the split:
[1] https://www.spinics.net/lists/arm-kernel/msg789309.html
Regards,
Marco
> On Tue, 2020-05-12 at 15:31 +0800, Liu Ying wrote:
> > Both of the two LVDS channels should
On 20-03-09 15:18, Ville Syrjälä wrote:
> On Fri, Mar 06, 2020 at 09:02:57AM +0100, Marco Felsch wrote:
> > On 20-03-03 16:52, Ville Syrjälä wrote:
> > > On Tue, Mar 03, 2020 at 08:33:20AM +0100, Marco Felsch wrote:
> > > > Hi Ville,
> > > >
>
On 20-03-03 16:52, Ville Syrjälä wrote:
> On Tue, Mar 03, 2020 at 08:33:20AM +0100, Marco Felsch wrote:
> > Hi Ville,
> >
> > On 20-03-02 22:34, Ville Syrjala wrote:
> > > From: Ville Syrjälä
> > >
> > > The currently listed dotclock disagre
correct?
Pls, check the datasheet which is linked within the comment. We hit the
vrefresh exactly if we are in SYNC MODE.
Regards,
Marco
> Cc: Andreas Pretzsch
> Cc: Marco Felsch
> Cc: Thierry Reding
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/panel/pan
Hi Daniel,
On 20-02-27 19:14, Daniel Vetter wrote:
> On Thu, Feb 27, 2020 at 6:44 PM Lucas Stach wrote:
> >
> > Hi Daniel,
> >
> > On Do, 2020-02-27 at 18:29 +0100, Daniel Vetter wrote:
> > > On Thu, Feb 27, 2020 at 05:21:25PM +0100, Marco Felsch wrot
This helper only added an additional layer without adding
simplifications. All former users of this API are converted to call
drm_encoder_cleanup() directly.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/imx/imx-drm-core.c | 6 --
drivers/gpu/drm/imx/imx-drm.h | 1 -
2 files changed
Since commit 5e501ed7253b ("drm/imx: imx-ldb: allow to determine bus
format from the connected panel") the enum isn't used anymore. Drop it
to cleanup the code a bit.
Signed-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/gpu/drm/imx/imx-ldb.c | 5 -
1 file chang
Split the maybe failing attach function from imx_pd_register() so we
can construct simple error paths later on.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/imx/parallel-display.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/parallel
The edid memory is only freed if the component.unbind() is called. This
is okay if the parallel-display was binded but if the bind() fails we
leek the memory.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/imx/parallel-display.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff
To avoid a dedicated unbind() callback we can use the new devm_action
mechanism. This allows us to drop the error check because the callback
will only be executed if the regulator was registered.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/imx/imx-tve.c | 20 ++--
1 file
There is no reason why the resoruces should be freed manually within the
component.unbind() call instead it is easier to use the drm-core destroy
helper. The destroy helper gets called for each registered encoder
during a drm_mode_config_cleanup() call.
Signed-off-by: Marco Felsch
---
drivers
ig_cleanup() call and the ->destroy() callbacks. For this
purpose we need to split off the drm_connector structure.
[1] https://www.spinics.net/lists/dri-devel/msg189388.html
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/imx/parallel-display.c | 84 --
1 fil
ter are welcome =)
Regards,
Marco
[1] https://www.spinics.net/lists/dri-devel/msg189388.html
[2] https://lkml.org/lkml/2018/10/16/1148
[3] https://lkml.org/lkml/2019/4/2/612
Marco Felsch (17):
drm/imx: drop useless best_encoder callback
drm/imx: parallel-display: fix edid memory leak
drm/imx: p
The best_encoder() callback is used by the drm-core to find an encoder
if the connector is connected to multiple encoders but the parallel, tve
and ldb uses always the 1-encoder : 1-connector setup. Such a simple
setup can be handled by the drm-core.
Signed-off-by: Marco Felsch
Reviewed-by
There is no reason why this should be done within the
component.unbind() call so let the drm-core do the cleanup during a
drm_mode_config_cleanup() call.
Signed-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/gpu/drm/imx/parallel-display.c | 23 ++-
1 file
We do some string parsing and string comparison in front of
drm_of_find_panel_or_bridge(). All this work is useless if the call
fails. Move drm_of_find_panel_or_bridge() infront of the parsing work to
fail early.
Signed-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/gpu/drm/imx
Refactor the function to easaly construct error paths later on. The
error handling gets dirty if we don't refactor the code yet. While on it
I fixed a missing i2c_put_adapter() if the bind() fails.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/imx/imx-ldb.c
There where several places where this bit operation is made. Add a
simple helper so we don't need to remember the bit each time.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/imx/imx-ldb.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gp
ources are allocated during
probe.
While on it I dropped the imx_drm_encoder_destroy() API and call
drm_encoder_cleanup() directly.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/imx/imx-tve.c | 145 +++---
1 file changed, 101 insertions(+), 44 deletions(-)
diff --git
The edid memory is only freed if the component.unbind() is called. This
is okay if the imx-ldb was bound but if the bind() fails we leek the
memory.
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/imx/imx-ldb.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers
igned-off-by: Marco Felsch
---
drivers/gpu/drm/imx/dw_hdmi-imx.c | 28 -
drivers/gpu/drm/imx/imx-drm-core.c | 3 ++-
drivers/gpu/drm/imx/imx-ldb.c | 34 +-
drivers/gpu/drm/imx/imx-tve.c | 15 +---
drivers/gpu/drm/imx/
of channels
are allocated. The difference is that now the 'struct imx_ldb_channel'
memory is allocated within the bind/unbind devres context.
So now the 'struct imx_ldb' driver state is still available after a
component.unbind() call.
[1] https://www.spinics.net/lists/dri
es. So all acquired memory resoruces are freed by a
drm_mode_config_cleanup() call and the ->destroy() callbacks. For this
purpose we need to slit the drm_encoder and the drm_connector state.
[1] https://www.spinics.net/lists/dri-devel/msg189388.html
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/
Hi Navid,
On 19-11-21 12:31, Navid Emamdoost wrote:
> On Fri, Oct 4, 2019 at 2:09 PM Navid Emamdoost
> wrote:
> >
> > In imx_pd_bind, the duplicated memory for imxpd->edid via kmemdup should
> > be released in drm_of_find_panel_or_bridge or imx_pd_register fail.
> >
> > Fixes: ebc944613567 ("drm:
case V4L2_PIX_FMT_XBGR32:
> - case V4L2_PIX_FMT_RGB32:
> - case V4L2_PIX_FMT_BGR32:
> - case V4L2_PIX_FMT_RGB24:
> - case V4L2_PIX_FMT_BGR24:
> case V4L2_PIX_FMT_RGB565:
> + case V4L2_PIX_FMT_BGR24:
Nitpick:
Should we add '/* fall t
On 19-05-16 21:38, Rob Herring wrote:
> On Tue, Apr 23, 2019 at 7:26 AM Thierry Reding
> wrote:
> >
> > On Tue, Apr 16, 2019 at 12:06:43PM +0200, Marco Felsch wrote:
> > > Evervision Electronics is a panel manufacturer from Taipei.
> > > http://www
Evervision Electronics is a panel manufacturer from Taipei.
http://www.evervisionlcd.com/index.php?lang=en
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree
Hi,
This small series adds the support for the Evervision VGG804821 panels.
The patches are rebased ontop of the current drm_misc/drm-misc-next.
Marco Felsch (3):
dt-bindings: add vendor prefix for Evervision Electronics
dt-bindings: drm/panel: simple: add Evervision VGG804821
drm/panel
Add support for the Evervision VG804821 800x480 5.0" LCD TFT parallel
panel to DRM simple panel driver.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
.../bindings/display/panel/evervision,vgg804821.txt | 12
1 file changed, 12 insertions(+)
create mode 1
Add support the Evervision VGG804821 800x480 5.0" WVGA TFT panel.
Signed-off-by: Marco Felsch
---
v2:
- pixel data should be driven on neg. edge since the panel applies
the data on positiv edge.
drivers/gpu/drm/panel/panel-simple.c | 30
1 file change
tzsch
[m.fel...@pengutronix.de: adapt commit message]
[m.fel...@pengutronix.de: rm unecessary comments]
[m.fel...@pengutronix.de: correct data_enable polarity]
Signed-off-by: Marco Felsch
---
drivers/gpu/drm/panel/panel-simple.c | 29
1 file changed, 29 insertions(+)
diff
Add support for the ET035012DM6 3.5" QVGA TFT LCD panel. The datasheet
can be retrieved online:
https://www.glynshop.com/erp/owweb/Daten/DSS/EDT/Products/ \
Specifications/Active%20Displays/ET035012DM6.pdf
Signed-off-by: Marco Felsch
---
.../devicetree/bindings/display/panel/edt,et-serie
Hi Sam,
thanks for your fast response =)
On 19-04-15 18:10, Sam Ravnborg wrote:
> Hi Marco
>
> On Mon, Apr 15, 2019 at 05:46:48PM +0200, Marco Felsch wrote:
> > Hi Thierry,
> >
> > gentle ping.
> >
> > On 19-01-14 11:28, Marco Felsch wrote:
> >
Hi Thierry,
gentle ping.
On 19-01-14 11:28, Marco Felsch wrote:
> Hi Sam,
>
> On 19-01-04 17:40, Sam Ravnborg wrote:
> > Hi Marco.
> >
> > In $subject pannel => panel
>
> Thanks for covering that, Thierry can you fix this inline?
Is that doable for you?
1 - 100 of 128 matches
Mail list logo
