Re: drm/udl: Implementation of atomic cursor drm_plane

2024-07-02 Thread Lukasz Spintzyk
On 6/24/2024 12:05 PM, Daniel Vetter wrote: CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe. On Mon, Jun 24, 2024 at 09:28:29AM +0200, Thomas Zimmermann wrote: Hi Am 24.06.24 um 09:10 schrieb lukasz.spi

Re: drm/udl: Implementation of atomic cursor drm_plane

2024-07-02 Thread Lukasz Spintzyk
On 7/2/2024 2:02 PM, Lukasz Spintzyk wrote: On 6/24/2024 12:05 PM, Daniel Vetter wrote: CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe. On Mon, Jun 24, 2024 at 09:28:29AM +0200, Thomas Zimmermann wrote

[PATCH 1/4] drm/udl: Port CrOS cursor blending on primary plane in usb transfer

2024-06-24 Thread lukasz . spintzyk
From: Douglas Anderson Port applicable parts of CrOS udl cursor implementation from 5.4 CrOS kernel fork. - removed legacy non-atomic udl_cursor_move, udl_cursor_set ioctl's implementation - modified udl_cursor_download to copy cursor content to the buffer from iosys_map - removed unnecessa

drm/udl: Implementation of atomic cursor drm_plane

2024-06-24 Thread lukasz . spintzyk
This brings cursor on DisplayLink USB2.0 device on ChromeOS compositor that requires either crtc'c cursor_set callback or cursor drm_plane. Patch was tested on ChromeOS and Ubuntu 22.04 with Gnome/Wayland

[PATCH 4/4] drm/udl: Shutdown all CRTCs on usb disconnect

2024-06-24 Thread lukasz . spintzyk
From: Łukasz Spintzyk This is fixing some kernel panics on device unplug, that started to be more visible after implementing cursor plane support. Signed-off-by: Łukasz Spintzyk --- drivers/gpu/drm/udl/udl_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/udl/udl_drv

[PATCH 3/4] drm/udl: Allow smaller plane sizes to allow cursor plane

2024-06-24 Thread lukasz . spintzyk
From: Łukasz Spintzyk Signed-off-by: Łukasz Spintzyk --- drivers/gpu/drm/udl/udl_modeset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c index 0bd4e2f02dcf..28b7c269e913 100644 --- a/drivers/gpu/drm

[PATCH 2/4] drm/udl: Add cursor drm_plane support

2024-06-24 Thread lukasz . spintzyk
From: Łukasz Spintzyk Atomic support for cursor plane was inspired by evdi drm driver that is maintained on github.com/displaylink/evdi. Also added ARGB plane format as it is used by cursor plane. Signed-off-by: Łukasz Spintzyk --- drivers/gpu/drm/udl/udl_cursor.c | 32 +++- drivers

Re: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane

2018-04-10 Thread Lukasz Spintzyk
On 05/04/2018 01:49, Deepak Rawat wrote: From: Lukasz Spintzyk Optional plane property to mark damaged regions on the plane in framebuffer coordinates of the framebuffer attached to the plane. The layout of blob data is simply an array of drm_mode_rect with maximum array size limited by

Re: [RFC 0/3] drm: page-flip with damage

2018-04-10 Thread Lukasz Spintzyk
notion. On other hand existing legacy dirtyfb callback in drm_framebuffer_funcs is also using 'clip_rects' :). Thanks Łukasz Spintzyk On 05/04/2018 01:49, Deepak Rawat wrote: Hi All, This is extension to Lukasz Spintzyk earlier draft of damage interface for drm. Bascially a new plan

Re: [PATCH 1/1] drm: Add dirty_rects atomic blob property for drm_plane

2018-01-04 Thread Lukasz Spintzyk
we reuse dirtyfb ioctl for this purpose? It would be called before page_flip ioctl? /Thomas On 12/21/2017 12:10 PM, Lukasz Spintzyk wrote: Change-Id: I63dce004f8d3c5dc6a7c71070f1fab0707286ea5 Signed-off-by: Lukasz Spintzyk ---   drivers/gpu/drm/drm_atomic.c  | 10 ++   dri

Re: [PATCH 1/1] drm: Add dirty_rects atomic blob property for drm_plane

2017-12-22 Thread Lukasz Spintzyk
Thanks Ville and Daniel for for your response. I will try to come back with something later. thanks Lukasz On 21/12/2017 14:10, Daniel Vetter wrote: On Thu, Dec 21, 2017 at 02:46:55PM +0200, Ville Syrjälä wrote: > On Thu, Dec 21, 2017 at 12:10:08PM +0100, Lukasz Spintzyk wrote: > >

[PATCH 0/1] Damage rectangles interface for DRM

2017-12-21 Thread Lukasz Spintzyk
ectangles for planes seems to be more straightforward. This is draft with minimal functionality. I would like to hear what is your opinion on it. I am happy to hear what are the requirements of other driver vendors. Thanks Lukasz Spintzyk Lukasz Spintzyk (1): drm: Add dirty_rects atom

[PATCH 1/1] drm: Add dirty_rects atomic blob property for drm_plane

2017-12-21 Thread Lukasz Spintzyk
Change-Id: I63dce004f8d3c5dc6a7c71070f1fab0707286ea5 Signed-off-by: Lukasz Spintzyk --- drivers/gpu/drm/drm_atomic.c | 10 ++ drivers/gpu/drm/drm_mode_config.c | 6 ++ drivers/gpu/drm/drm_plane.c | 1 + include/drm/drm_mode_config.h | 5 + include/drm