ny requested cache flushes are completed instead of dropped.
>
> Signed-off-by: Karunika Choo
> Co-developed-by: Dennis Tsiang
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_gpu.c | 7 +++
> 1 file changed, 7 insertions(+)
>
>
On Thu, Jul 24, 2025 at 01:42:10PM +0100, Karunika Choo wrote:
> This patch adds firmware binary and GPU model naming support for
> Mali-Gx20 and Mali-Gx25 GPUs.
>
> Signed-off-by: Karunika Choo
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor
On Tue, Jul 22, 2025 at 10:29:21AM +0200, Erik Faye-Lund wrote:
> On Mon, 2025-07-21 at 12:13 +0100, Karunika Choo wrote:
> > This patch adds GPU model name and FW binary support for Mali-G710,
> > Mali-G510, and Mali-G310.
> >
> > Signed-off-by: Karunika Choo
> > ---
> > drivers/gpu/drm/panthor
; +#define GPU_COHERENCY_FEATURE_SHAREABLE_CACHE_SUPPORT BIT(5)
>
> #define GPU_COHERENCY_PROTOCOL 0x304
> #define GPU_COHERENCY_ACE_LITE 0
> #define GPU_COHERENCY_ACE
LUSH_MEM and FLUSH_PT commands.
>
> Mali-Gx10 and Mali-Gx15 GPUs also has support for the FLUSH_CACHES
> command and will also use this by default going forward.
>
> Signed-off-by: Karunika Choo
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/g
MP_OFFSET 0x88
> #define GPU_CYCLE_COUNT 0x90
> #define GPU_TIMESTAMP0x98
> @@ -81,6 +85,8 @@
>
> #define GPU_TEXTURE_FEATURES(n)
On Mon, Jul 21, 2025 at 12:13:41PM +0100, Karunika Choo wrote:
> This patch adds GPU model name and FW binary support for Mali-G710,
> Mali-G510, and Mali-G310.
>
> Signed-off-by: Karunika Choo
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/pantho
lows extending of the function to
> accommodate naming differences based on supported GPU features.
>
> Signed-off-by: Karunika Choo
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_hw.c | 61
> 1 file
> Signed-off-by: Karunika Choo
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/Makefile | 1 +
> drivers/gpu/drm/panthor/panthor_device.c | 5 +
> drivers/gpu/drm/panthor/panthor_gpu.c| 95 ---
>
-
> drivers/gpu/drm/imx/dcss/dcss-crtc.c| 1 -
> drivers/gpu/drm/lima/lima_sched.c | 1 -
> drivers/gpu/drm/panel/panel-edp.c | 3 ---
> .../gpu/drm/panel/panel-samsung-atna33xc20.c| 2 --
> drivers/gpu/drm/panel/panel-simple.c |
On Fri, Jul 11, 2025 at 04:45:53PM +0100, Adrián Larumbe wrote:
> Commit ec62d37d2c0d("drm/panthor: Fix the fast-reset logic") did away
> with the only reference to panthor_vm_flush_all(), so let's get rid
> of the orphaned definition.
>
> Signed-off-by: Adrián Laru
de list of DRM GEM objects
> over DebugFS")
> Cc: Adrián Larumbe
> Cc: Boris Brezillon
> Cc: Steven Price
> Cc: Liviu Dudau
> Signed-off-by: Simona Vetter
> Signed-off-by: Simona Vetter
> ---
> drivers/gpu/drm/panthor/panthor_gem.c | 34 ++---
On Sat, Jul 05, 2025 at 01:12:09PM -0700, Daniel Mentz wrote:
> With the removal of arm_lpae_split_blk_unmap, I believe the following
> macros are now unused. Is there any interest in removing those as
> well? If so, I can draft a patch.
>
> #define ARM_LPAE_PTE_ATTR_LO_MASK (((arm_lpae_iopte)0x3f
struct drm_framebuffer *fb,
> +const struct drm_format_info *info,
> const struct drm_mode_fb_cmd2 *mode_cmd);
>
> @@
> expression dev, fb, mode_cmd;
> @@
> drm_helper_mode_fill_fb_struct(dev, fb
>
On Tue, Jul 01, 2025 at 12:07:17PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Plumb the format info from .fb_create() all the way to
> drm_helper_mode_fill_fb_struct() to avoid the redundant
> lookup.
>
> Cc: Liviu Dudau
> Reviewed-by: Thomas Zimmermann
On Tue, Jul 01, 2025 at 12:07:09PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Plumb the format info from .fb_create() all the way to
> malidp_verify_afbc_framebuffer_size() to avoid the
> redundant lookup.
>
> Cc: Liviu Dudau
> Reviewed-by: Thomas Zimmermann
, mode_cmd;
> @@
> struct drm_mode_config_funcs {
> ...
> struct drm_framebuffer *(*fb_create)(struct drm_device *dev,
> struct drm_file *file_priv,
> + const struct drm_format_info *info,
>
de_cmd;
> @@
> - drm_get_format_info(dev, mode_cmd)
> + drm_get_format_info(dev, mode_cmd->pixel_format, mode_cmd->modifier[0])
>
> v2: Fix kernel docs (Laurent)
> Drop drm_mode_fb_cmd2 forward declaration (Thomas)
>
> Cc: Liviu Dudau
> Cc: Russell King
&
to using the pwrtrans_reg register instead. Fix the function
> to use the correct register.
Good catch!
>
> Fixes: 4d230aa209ed ("drm/panthor: Add 64-bit and poll register accessors")
> Signed-off-by: Steven Price
Reviewed-by: Liviu Dudau
Best regards,
Liviu
On Mon, Jun 23, 2025 at 08:21:22AM +0200, Boris Brezillon wrote:
> On Fri, 20 Jun 2025 16:50:51 -0700
> Chia-I Wu wrote:
>
> > We would like to access panthor_file from panthor_group on gpu errors.
> > Because panthour_group can outlive drm_file, add refcount to
> > panthor_file to ensure its lif
3824 ("drm/panthor: Add the scheduler logical block")
> ---
Don't know why you have the dashes in line above in the patch, it will make git
to skip your S-o-b.
> Signed-off-by: Ashley Smith
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/dr
; Signed-off-by: Alexander Stein
Sorry for the delay in replying, I was on holiday when you've sent the patch and
I've only found it today.
Patch looks sensible, so Reviewed-by: Liviu Dudau
I will push the patch today into drm-misc-next.
Best regards,
Liviu
> ---
> Every time glma
iu)
> - keep original sorting of formats (Javier)
> - use anonymous type for supported_formats
>
> Signed-off-by: Thomas Zimmermann
> Reviewed-by: Javier Martinez Canillas
Reviewed-by: Liviu Dudau
Are you happy to merge this yourself?
Best regards,
Liviu
> ---
> dri
On Tue, May 27, 2025 at 11:42:57AM +0200, Thomas Zimmermann wrote:
> Map DRM FourCC codes to pixel descriptions with internal type struct
> hdlcd_format. Reorder formats by preference. Avoid simplefb's struct
> simplefb_format, which is for parsing "simple-framebuffer" DT nodes.
>
> The HDLCD driv
cs_slot_reset_locked(ptdev,
> csg_id, i);
> + }
> + }
> slot_mask &= ~BIT(csg_id);
> }
> }
> --
> 2.43.0
>
Reviewed-by: Liviu Dudau
Best regards,
Liviu
--
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---
¯\_(ツ)_/¯
ups that are not terminated correctly.
>
> Signed-off-by: Ashley Smith
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> Changes in v2:
> - Fixed syntax error
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 d
debugfs_set_usage_flags() into panthor_gem.c and
> declare it static.
>
> Fixes: a3707f53eb3f ("drm/panthor: show device-wide list of DRM GEM objects
> over DebugFS")
> Reported-by: Arnd Bergmann
> Closes:
> https://lore.kernel.org/dri-devel/20250424142419.47b9d..
es, because
> + * userspace is in control of the offset, and can change the
> + * value behind out back, potentially leading to erronous
s/out/our/, s/erronous/erroneous/
> + * branching happening in kernel space.
Is "potentially" here still v
On Thu, Apr 17, 2025 at 02:16:11PM +0200, Boris Brezillon wrote:
> On Thu, 17 Apr 2025 12:33:01 +0100
> Liviu Dudau wrote:
>
> > On Thu, Apr 17, 2025 at 11:41:18AM +0100, Steven Price wrote:
> > > On 17/04/2025 11:05, Boris Brezillon wrote:
> > > > Current
estruction time, but allocating it is the responsibility
> of callers.
>
> Signed-off-by: Adrián Larumbe
> Reviewed-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_gem.c | 46 +++
> d
t guaranteed to zero it out.
The direction is the other way around, it's provided by kernel. I would loosen
the restriction
on repurposing, maybe when 32bit x86 is no longer such a hot market we can
reuse it for some
other chicken bits.
With the comment updated,
Acked-by: Liviu Dudau
On Thu, Apr 17, 2025 at 11:41:18AM +0100, Steven Price wrote:
> On 17/04/2025 11:05, Boris Brezillon wrote:
> > Currently, we pick the MMIO offset based on the size of the pgoff_t
> > type seen by the process that manipulates the FD, such that a 32-bit
> > process can always map the user MMIO range
lags & DRM_PANTHOR_BO_NO_MMAP)
> + return -EPERM;
> +
As Matthew already noticed, we need to set `ret` to -EPERM and goto out.
With that change,
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ret = drm_gem_create_mmap_offset(obj);
> if (ret)
>
22f5b5 ("drm/panthor: Call panthor_gpu_coherency_init() after PM
> resume()")
> Reported-by: Dan Carpenter
> Closes:
> https://lore.kernel.org/dri-devel/4da470aa-4f84-460e-aff8-dabc8cc4da15@stanley.mountain/T/#t
> Signed-off-by: Boris Brezillon
Good catch!
R
On Mon, Apr 14, 2025 at 01:22:06PM +0200, Boris Brezillon wrote:
> Hi Sima,
>
> On Fri, 11 Apr 2025 14:01:16 +0200
> Simona Vetter wrote:
>
> > On Thu, Apr 10, 2025 at 08:41:55PM +0200, Boris Brezillon wrote:
> > > On Thu, 10 Apr 2025 14:01:03 -0400
> > > Alyssa Rosenzweig wrote:
> > >
> > >
Reviewed-by: Boris Brezillon
> > Signed-off-by: Karunika Choo
With the changes that Steven suggested:
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> > ---
> > drivers/gpu/drm/panthor/panthor_device.h | 71
> > drivers
ct *bo;
> > struct drm_gem_object *obj;
> > int ret;
> >
> > @@ -950,6 +951,10 @@ static int panthor_ioctl_bo_mmap_offset(struct
> > drm_device *ddev, void *data,
> > if (!obj)
> > return -ENOENT;
> >
> > + bo = to_panthor_bo
definitions.
>
> Reviewed-by: Boris Brezillon
> Suggested-by: Boris Brezillon
> Signed-off-by: Karunika Choo
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_gpu.c | 12 ++--
> drivers/gpu/drm/panthor/panthor_gpu.h | 10 +--
> d
vm_map_flags, va, "FW
> section");
Nit: we could add the section->name if available and if we want a more detailed
label, but
it is not critical.
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> if (IS_ERR(s
estruction time, but allocating it is the responsibility
> of callers.
>
> Signed-off-by: Adrián Larumbe
> Reviewed-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_gem.c | 39 +++
> d
a kernel BO and/or mapped onto the FW's address space.
>
> Signed-off-by: Adrián Larumbe
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_device.c | 5 +
> drivers/gpu/drm/panthor/panthor_device.h | 11 ++
> drivers/gpu/
7,7 @@ static void panthor_debugfs_init(struct drm_minor
> *minor)
> * - 1.2 - adds DEV_QUERY_GROUP_PRIORITIES_INFO query
> * - adds PANTHOR_GROUP_PRIORITY_REALTIME priority
> * - 1.3 - adds DRM_PANTHOR_GROUP_STATE_INNOCENT flag
> + * - 1.4 - adds DRM_IOCTL
On Fri, Apr 04, 2025 at 10:09:29AM +0200, Boris Brezillon wrote:
> GPU_COHERENCY_ACE and GPU_COHERENCY_ACE_LITE definitions have been
> swapped.
>
> Changes in v2:
> - New patch
>
> Changes in v3:
> - Add Steve's R-b
>
> Reported-by: Liviu Dudau
> Fixe
by: Rob Herring (Arm)
> Reviewed-by: Frank Li
> Signed-off-by: Marek Vasut
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> Cc: Boris Brezillon
> Cc: Conor Dooley
> Cc: David Airlie
> Cc: Fabio Estevam
> Cc: Krzysztof Kozlowski
> Cc: Liviu Dudau
> Cc:
-off-by: Shao Mingyin
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 9 +
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c
> b/drivers/gpu/drm/arm/malidp_drv.c
> index e083021
-off-by: Shao Mingyin
Reviewed-by: Liviu Dudau
Best regards,
Liviu Dudau
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index c3179d74f3f5..
is too early.
Reviewed-by: Liviu Dudau
Best regards,
Liviu
>
> Changes in v2:
> - New patch
>
> Signed-off-by: Boris Brezillon
> ---
> drivers/gpu/drm/panthor/panthor_mmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panthor/
chance
> to process the IRQ.
>
> Since clearing the clearing is just one line, let's make it explicit
> instead of doing it in the generic code path.
>
> Changes in v2:
> - Move the MMU_INT_CLEAR around
>
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Du
h looks good to me.
Reviewed-by: Liviu Dudau
Best regards,
Liviu
>
> Fixes: dd7db8d911a1 ("drm/panthor: Explicitly set the coherency mode")
> Signed-off-by: Boris Brezillon
> ---
> drivers/gpu/drm/panthor/panthor_device.c | 8
> 1 file changed, 4 insertions(+)
;drm/panthor: Add the MMU/VM logical block")
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_mmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c
&
On Thu, Mar 20, 2025 at 11:17:41AM +, Karunika Choo wrote:
> This patch adds GPU model name and FW binary support for Mali-G710,
> Mali-G510, and Mali-G310.
>
> Signed-off-by: Karunika Choo
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 2 ++
> drivers/gpu/drm/panthor/panthor_hw.c | 6 ++
> to make import_attach optional.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Boris Brezillon
> Cc: Steven Price
> Cc: Liviu Dudau
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_gem.c | 2 +-
> drivers/gpu/drm/panthor/panthor_mmu.c |
On Thu, Mar 13, 2025 at 04:29:07PM +0800, Chen Ni wrote:
> clk_prepare_enable() already checked NULL clock parameter.
> Remove unneeded NULL check for clk here.
You're not saving anything here. If mdev->aclk is NULL you still end up
calling clk_prepare() and clk_enable() even if they return zero i
On Mon, Mar 10, 2025 at 03:23:57PM +0800, WangYuli wrote:
> Manifestly, the "ARM devices" menu is appropriate only for the ARM
> architecture.
>
> Inasmuch as every single item in this menu is predicated on
> (ARM || ARM64 || COMPILE_TEST), it is therefore illogical for the
> "ARM devices" menu it
: Daniel Stone
> Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
> Signed-off-by: Ashley Smith
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 233 +---
> 1 file changed, 167 insertions
8d91816ee ("drm/panthor: Add the FW logical block")
> Signed-off-by: Ashley Smith
Reviewed-by: Liviu Dudau
You could also add Steven's r-b, as per his email if you send another version,
otherwise it will need to be edited by whomever merges it.
Best regards,
Liviu
> --
On Fri, Feb 28, 2025 at 06:43:53PM +0100, Marek Vasut wrote:
> On 2/28/25 11:36 AM, Alexander Stein wrote:
> > Hi Marek,
>
> Hi,
>
> > > diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx95.dtsi
> > > index 3af13173de4bd..36bad211e5558 100644
> > > --
On Fri, Feb 28, 2025 at 06:05:36PM +0100, Marek Vasut wrote:
> On 2/28/25 12:06 PM, Liviu Dudau wrote:
> > Hi Marek,
>
> Hi,
>
> > On Thu, Feb 27, 2025 at 05:58:06PM +0100, Marek Vasut wrote:
> > > This seems necessary on Freescale i.MX95 Mali G310 to reli
: David Airlie
> Cc: Fabio Estevam
> Cc: Krzysztof Kozlowski
> Cc: Liviu Dudau
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> Cc: Pengutronix Kernel Team
> Cc: Philipp Zabel
> Cc: Rob Herring
> Cc: Sascha Hauer
> Cc: Sebastian Reichel
> Cc: Shawn Guo
&g
ht, I stand corrected.
Acked-by: Liviu Dudau
Best regards,
Liviu
>
>
> Thanks and Regards,
> Shixiong Ou.
>
>
> 在 2025/2/25 18:28, Liviu Dudau 写道:
> > Hello,
> >
> > Replying from my personal email as the corporate system seems to have
> > blackh
Hello,
Replying from my personal email as the corporate system seems to have
blackholed your emails
while I was on holiday.
Can you tell me more why you think that if sysfs_create_group() fails we should
not call
sysfs_remove_group()? After all, we don't know how far sysfs_create_group() has
p
On Mon, Feb 10, 2025 at 02:18:07PM +0100, Boris Brezillon wrote:
> On Mon, 10 Feb 2025 12:42:00 +
> Adrián Larumbe wrote:
>
> > A previous commit dealt with a similar situation, whereby upon enabling
> > some mutex debug features, a warning about sleep muteces being used in a
>
>
f the kernel's mutex-debugging
> features:
>
> CONFIG_DEBUG_RT_MUTEXES=y
> CONFIG_DEBUG_MUTEXES=y
>
> Replace Panthor's group fdinfo data mutex with a guarded spinlock.
>
> Signed-off-by: Adrián Larumbe
> Fixes: e16635d88fa0 ("drm/panthor: add DRM fd
On Mon, Feb 03, 2025 at 10:21:53AM +0100, Boris Brezillon wrote:
> +Akash with whom we've been discussing adding a 'REPEAT' mode to
> drm_gpuvm/panthor.
>
> On Sun, 2 Feb 2025 19:53:47 +0100
> Danilo Krummrich wrote:
>
> > Hi Lina,
> >
> > On Sun, Feb 02, 2025 at 10:34:49PM +0900, Asahi Lina wr
issnaming in:
>
> commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in
> nouveau_sched_init()").
>
> Introduce a new struct for the scheduler init parameters and port all
> users.
>
> Signed-off-by: Philipp Stanner
[Mostly for drm/panthor, but I had a quick
of komeda_get_layer_fourcc_list()
> to catch the potential exception.
>
> Fixes: 5d51f6c0da1b ("drm/komeda: Add writeback support")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Haoxiang Li
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/displa
select DRM_BRIDGE # for TDA998x
> help
> Choose this option if you have an ARM High Definition Colour LCD
> controller.
For the above change:
Acked-by: Liviu Dudau
Best regards,
Liviu
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfi
pecific key:value pairs
> with the definitions of the new drm-*-internal ones.
>
> Signed-off-by: Adrián Larumbe
> Reviewed-by: Mihail Atanassov
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> Documentation/gpu/panthor.rst | 14 ++
> 1 file changed, 14 inser
On Tue, Dec 17, 2024 at 12:06:59PM +0100, Boris Brezillon wrote:
> On Tue, 17 Dec 2024 10:56:14 +
> Liviu Dudau wrote:
>
> > On Tue, Dec 17, 2024 at 10:24:57AM +0100, Boris Brezillon wrote:
> > > If a reset is scheduled when the suspend happens, we drop the
> &g
On Tue, Dec 17, 2024 at 10:24:57AM +0100, Boris Brezillon wrote:
> If a reset is scheduled when the suspend happens, we drop the
> reset-pending info on the floor assuming the resume will fix things,
> but the resume logic might try a fast reset. If we're lucky, the
> fast reset fails and we fallba
s, as these aren't bound to a
> specific open file and remain active through the whole life of the driver.
>
> Signed-off-by: Adrián Larumbe
With the issue that Boris pointed fixed,
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_d
On Wed, Dec 11, 2024 at 04:34:32PM +, Adrián Larumbe wrote:
> A previous commit enabled display of driver-internal kernel BO sizes
> through the device file's fdinfo interface.
>
> Expand the description of the relevant driver-specific key:value pairs
> with the definitions of the new drm-*-in
t; + panthor_mmu_suspend(ptdev);
> + panthor_gpu_suspend(ptdev);
> + return ret;
My only comment was a nit here where I prefer the construct:
if (ret) {
panthor_mmu_suspend(ptdev);
panthor_gpu_suspend(ptdev);
}
return re
op all runnable groups in panthor_sched_pre_reset(), but let's
> stop complaining about it.
>
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 2 --
> 1 file changed, 2 deletions
es: 5fe909cae118 ("drm/panthor: Add the device logical block")
> Signed-off-by: Boris Brezillon
> Reviewed-by: Steven Price
> Reviewed-by: Adrian Larumbe
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_device.c | 4 ++--
> 1 file
Hi Christian,
On Mon, Nov 25, 2024 at 11:39:58AM +0100, Christian Göttsche wrote:
> From: Christian Göttsche
>
> capable() calls refer to enabled LSMs whether to permit or deny the
> request. This is relevant in connection with SELinux, where a
> capability check results in a policy decision an
On Wed, Oct 30, 2024 at 10:54:04PM +, Akash Goel wrote:
> This patch series contains 3 cache coherency related fixes for the
> Panthor driver.
> - The first fix, regarding the Inner-shareability, is mandatory to
> ensure things work on all platforms (including Juno FPGA) when
> no_coherency
On Wed, Nov 20, 2024 at 12:41:25PM +0100, Boris Brezillon wrote:
> On Tue, 19 Nov 2024 16:44:55 +
> Liviu Dudau wrote:
>
> > Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path") forgot
> > to copy the definition of glb_iface when it move one line
On Tue, Nov 19, 2024 at 03:25:25PM +0100, Boris Brezillon wrote:
> On Tue, 19 Nov 2024 13:50:29 +
> Karunika Choo wrote:
>
> > Stop checking the FW halt_status as MCU_STATUS should be sufficient.
> > This should make the check for successful FW halt and subsequently
> > setting fast_reset to
Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path") forgot
to copy the definition of glb_iface when it move one line of code.
Fixes: Commit 498893bd596e ("drm/panthor: Simplify FW fast reset path")
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/panthor/pantho
On Mon, Nov 18, 2024 at 08:08:16AM -0700, Nathan Chancellor wrote:
> On Thu, Oct 31, 2024 at 02:41:38PM +0100, Maarten Lankhorst wrote:
> > Cristian Ciocaltea (3):
> > drm/rockchip: Add basic RK3588 HDMI output support
>
> Can someone please apply [1] to resolve a link time failure seen with
B_HALT bit only on post-reset prior
> to starting the FW.
>
> Signed-off-by: Karunika Choo
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/dr
dm.c| 2 +-
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h| 2 +-
> drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 2 +-
> drivers/gpu/drm/arm/malidp_mw.c | 2 +-
For the Arm display drivers:
Reviewed-by: Liviu Dudau
Best re
On Wed, Nov 13, 2024 at 04:42:54PM +0100, Boris Brezillon wrote:
> The runtime PM resume operation is not guaranteed to succeed, but if it
> fails, the device should be in a suspended state. Make sure we're robust
> to resume failures in the unplug path.
>
> Signed-off-by: Boris Brezillon
> ---
>
On Thu, Nov 14, 2024 at 12:27:55PM +0100, Boris Brezillon wrote:
> On Thu, 14 Nov 2024 11:13:29 +
> Liviu Dudau wrote:
>
> > On Wed, Nov 13, 2024 at 04:42:54PM +0100, Boris Brezillon wrote:
> > > The runtime PM resume operation is not guaranteed to succeed, but if it
On Wed, Nov 13, 2024 at 05:02:57PM +0100, Boris Brezillon wrote:
> Drop the _RD_ in the flag names.
>
> Signed-off-by: Boris Brezillon
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 62 ++--
> 1 file chan
tation while error cases jump forward to cleanup.
>
> Cc: sta...@vger.kernel.org
> Fixes: 5f7762042f8a ("drm/panthor: Restrict high priorities on group_create")
> Signed-off-by: Jann Horn
Reviewed-by: Liviu Dudau
> ---
> testcase:
> ```
> #include
> #include
is clear
that it applies to the next iteration of the loop.
Regardsless of the changes you're going to make,
Reviewed-by: Liviu Dudau
Best regards,
Liviu
>
> --
> 2.25.1
>
--
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---
¯\_(ツ)_/¯
On Wed, Nov 06, 2024 at 02:21:33PM +0100, Boris Brezillon wrote:
> On Wed, 6 Nov 2024 13:10:37 +
> Liviu Dudau wrote:
>
> > panthor_heap_pool_release() does not take the panthor_heap_pool::lock, so
> > the protection
> > is not really there. I could fix panthor_h
at operation is protected by
the @pool->lock.
Fixes: 647810ec2476 ("drm/panthor: Add the MMU/VM logical block")
Reported-by: Jann Horn
Cc: Boris Brezillon
Cc: Steven Price
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/panthor/panthor_mmu.c | 2 ++
1 file changed, 2 insertions(
Similar to cac075706f29 ("drm/panthor: Fix race when converting
group handle to group object") we need to use the XArray's internal
locking when retrieving a pointer from there for heap and vm.
Reported-by: Jann Horn
Cc: Boris Brezillon
Cc: Steven Price
Signed-off-by: Liviu Duda
On Wed, Nov 06, 2024 at 01:16:41PM +0100, Boris Brezillon wrote:
> On Wed, 6 Nov 2024 12:07:48 +
> Liviu Dudau wrote:
>
> > Similar to cac075706f29 ("drm/panthor: Fix race when converting
> > group handle to group object") we need to use the XArray's in
t; I don't
> have a working kernel build setup for the test machine yet. Please test it
> before applying it.
>
> Cc: sta...@vger.kernel.org
> Fixes: 5fe909cae118 ("drm/panthor: Add the device logical block")
> Signed-off-by: Jann Horn
> ---
> First testcase (can writ
2_LPAE_S1, ARM_32_LPAE_S2, ARM_64_LPAE_S1, ARM_64_LPAE_S2, and
> ARM_MALI_LPAE formats.
>
> Cc: Boris Brezillon
> Cc: Steven Price
> Cc: Liviu Dudau
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Jason Gunthorpe
>
t; + * unmapping stopped.
I guess 'res' is the return value here. Not my default name for the variable,
worth replacing it with "return value" ?
Regardless of the acceptance of this nit:
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> + */
> size_t iommu_unmap(struct iomm
On Tue, Oct 29, 2024 at 05:19:33PM +0100, Boris Brezillon wrote:
> On Tue, 29 Oct 2024 16:29:12 +0100
> Boris Brezillon wrote:
>
> > Groups can be killed during a reset even though they did nothing wrong.
> > That usually happens when the FW is put in a bad state by other groups,
> > resulting in
Add the scheduler logical block")
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 15 +++
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/dr
- DRM_FORMAT_RX142
> - DRM_FORMAT_GXRX142142
> - DRM_FORMAT_AXBXGXRX142142142142
>
> They are useful for communicating Bayer data between ISPs and GPU by
> emulating GL_R16UI and GL_RG16UI formats
>
> Signed-off-by: Yulia Garbovich
Reviewed-by: Liviu Dudau
Best regards,
Liviu
&
On Tue, Oct 29, 2024 at 10:46:29AM +0100, Erik Faye-Lund wrote:
> Enums are always signed, and assigning 1u << 31 to it invokes
> implementation defined behavior. It's not a great idea to depend on this
> in the UAPI, and it turns out no other UAPI does either.
>
> So let's do what other UAPI does
uot;drm/panthor: Add the scheduler logical block")
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/panthor/p
1 - 100 of 1096 matches
Mail list logo
