Hi Haoxiang, For reasons that I have not uncovered yet, the work email servers never delivered your message, I have discovered it today accidentally while looking in a backup I have at home.
On Thu, Dec 19, 2024 at 05:02:56PM +0800, Haoxiang Li wrote: > Add check for the return value of komeda_get_layer_fourcc_list() > to catch the potential exception. > > Fixes: 5d51f6c0da1b ("drm/komeda: Add writeback support") > Cc: sta...@vger.kernel.org > Signed-off-by: Haoxiang Li <haoxiang_li2...@163.com> Acked-by: Liviu Dudau <liviu.du...@arm.com> Best regards, Liviu > --- > drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c > b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c > index ebccb74306a7..f30b3d5eeca5 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c > @@ -160,6 +160,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev > *kms, > formats = komeda_get_layer_fourcc_list(&mdev->fmt_tbl, > kwb_conn->wb_layer->layer_type, > &n_formats); > + if (!formats) { > + kfree(kwb_conn); > + return -ENOMEM; > + } > > err = drm_writeback_connector_init(&kms->base, wb_conn, > &komeda_wb_connector_funcs, > -- > 2.25.1 > -- Everyone who uses computers frequently has had, from time to time, a mad desire to attack the precocious abacus with an axe. -- John D. Clark, Ignition!