Re: [PATCH RESEND 10/22] pinctrl: sunxi: add missed lvds pins for a100/a133

2025-01-15 Thread Linus Walleij
happy about active maintainers! Yours, Linus Walleij

Re: [PATCH 10/22] pinctrl: sunxi: add missed lvds pins for a100/a133

2025-01-13 Thread Linus Walleij
technically correct so I just applied it to the pin control tree. Yours, Linus Walleij

Re: [PATCH] MAINTAINERS: Assume maintainership of PL111

2024-12-21 Thread Linus Walleij
to it. Is there some example committ of this type of conversion in the tree? Yours, Linus Walleij

Re: [PATCH v3 3/7] dt-bindings: gpio: brcmstb: permit gpio-line-names property

2024-12-20 Thread Linus Walleij
ne an arbitrary maximum number of > items based on current users. > > Signed-off-by: Dave Stevenson Reviewed-by: Linus Walleij Perhaps Bartosz can just apply this one patch separately? Yours, Linus Walleij

[PATCH] MAINTAINERS: Assume maintainership of PL111

2024-12-19 Thread Linus Walleij
Emma Anholt dropped maintainership for PL111 and I didn't notice it at the time. I've written part of it and I'm happy to maintain it, list myself as maintainer and assume active maintainership. Signed-off-by: Linus Walleij --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions

Re: [PATCH v4 5/5] drm/panel: samsung-s6e88a0-ams427ap24: Add flip option

2024-10-28 Thread Linus Walleij
amsung_oled_video_qhd_pt-8930.c#L66-L74 > > Signed-off-by: Jakob Hauser > Reviewed-by: Neil Armstrong Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 4/5] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control

2024-10-28 Thread Linus Walleij
video/msm/mdss/samsung/S6E88A0_AMS427AP24/ss_dsi_panel_S6E88A0_AMS427AP24.c#L666-L678 > > Signed-off-by: Jakob Hauser > Reviewed-by: Neil Armstrong Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 3/5] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver

2024-10-28 Thread Linus Walleij
qhd_octa_video.dtsi > > Signed-off-by: Jakob Hauser Comments instead of #defines? OK then, it's readable too. Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 5/5] drm/panel: samsung-s6e88a0-ams427ap24: Add flip option

2024-10-25 Thread Linus Walleij
that aspect of the driver. (...) > + if (ctx->flip_horizontal) > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xcb, 0x0e); #define S6E88A0_SET_FLIP 0xcb or something like this. Other than that it looks good! Yours, Linus Walleij

Re: [PATCH v3 4/5] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control

2024-10-25 Thread Linus Walleij
, 0x55, 0x00); 0x55 is MIPI_DCS_WRITE_POWER_SAVE in > + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, b6, ARRAY_SIZE(b6)); > + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, ca, ARRAY_SIZE(ca)); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf7, 0x03); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5); Clearly this locks the L2 access again. Yours, Linus Walleij

Re: [PATCH v3 3/5] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver

2024-10-25 Thread Linus Walleij
ite_seq_multi(&dsi_ctx, 0xb2, > +0x40, 0x08, 0x20, 0x00, 0x08); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0x28, 0x0b); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf7, 0x03); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x55, 0x00); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5); > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xfc, 0xa5, 0xa5); Send in the reverse password: disable access. A bit of #defines and comments would make it much more clear what is going on. Yours, Linus Walleij

Re: [PATCH v3 1/5] dt-bindings: display: panel: Move flip properties to panel-common

2024-10-25 Thread Linus Walleij
f Kozlowski I think I even have a legacy panel that needs this, good! Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 2/5] dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24

2024-10-25 Thread Linus Walleij
On Thu, Oct 24, 2024 at 5:18 AM Jakob Hauser wrote: > Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller. > > Signed-off-by: Jakob Hauser > Reviewed-by: Krzysztof Kozlowski Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] drm/panel: himax-hx83102: Adjust power and gamma to optimize brightness

2024-10-11 Thread Linus Walleij
el") > Signed-off-by: Cong Yang Reviewed-by: Linus Walleij If you look in panel-samsung-s6e63m0.c you can see how that driver actually uses a set of gamma+power (ACL) settings to regulate the "backlight", i.e. the brightness of the OLED display. You might want to implement

Re: [PATCH] drm/fbdev-dma: Only cleanup deferred I/O if necessary

2024-10-07 Thread Linus Walleij
8 > [ 22.113868] invoke_syscall+0x78/0x1a8 > [ 22.114703] do_el0_svc+0x124/0x1a0 > [ 22.115498] el0_svc+0x3c/0xe0 > [ 22.116181] el0t_64_sync_handler+0x70/0xc0 > [ 22.117110] el0t_64_sync+0x190/0x198 > [ 22.117931] ---[ end trace ]--- > > Signed-off-by: Janne Grunau > Fixes: 5a498d4d06d6 ("drm/fbdev-dma: Only install deferred I/O if necessary") Good catch! Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v2] drm/panel: nt35510: Make new commands optional

2024-09-22 Thread Linus Walleij
nd should go in as a separate commit. > Other than that LGTM. Ooops residuals from an earlier patch iteration. I fixed it up while applying the patch. Thanks! Linus Walleij

[PATCH v2] drm/panel: nt35510: Make new commands optional

2024-09-08 Thread Linus Walleij
Fixes: 219a1f49094f ("drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK") Acked-by: Jessica Zhang Signed-off-by: Linus Walleij --- Changes in v2: - After Stefan's testing conclude that we only need to make SETVCMOFF optional. - Link to v1: https://lore.kernel.org/r/20240906-f

[PATCH] drm/panel: nt35510: Make new commands optional

2024-09-06 Thread Linus Walleij
: Stefan Hansson Fixes: 219a1f49094f ("drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK") Signed-off-by: Linus Walleij --- Stefan: if this patch works and you have time you can try adding the three flags one at a time to your device and we can see which command is problematic. --- d

Re: [PATCH] drm/fbdev-dma: Only install deferred I/O if necessary

2024-09-04 Thread Linus Walleij
> Closes: https://lore.kernel.org/all/23636953.6Emhk5qWAg@steina-w/ > Reported-by: Linus Walleij > Closes: > https://lore.kernel.org/dri-devel/CACRpkdb+hb9AGavbWpY-=uqq0apy9en_twjiopkf_fabxmp...@mail.gmail.com/ > Tested-by: Alexander Stein > Cc: Thomas Zimmermann > Cc: Jav

Re: [PATCH v3 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

2024-09-03 Thread Linus Walleij
rt for each node Early memory node ranges node 0: [mem 0x8000-0xefff] Initmem setup node 0 [mem 0x8000-0xefff] percpu: Embedded 15 pages/cpu s39052 r0 d22388 u61440 So at the top of the normal zone at 0xef00 as I read it. Yours, Linus Walleij

Re: [PATCH v3 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

2024-09-03 Thread Linus Walleij
"using device-specific reserved memory\n"); priv->use_device_memory = true; } Yours, Linus Walleij

Re: [PATCH -next 3/3] drm/mcde: Enable module autoloading

2024-09-02 Thread Linus Walleij
On Mon, Sep 2, 2024 at 1:41 PM Liao Chen wrote: > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based > on the alias from of_device_id table. > > Signed-off-by: Liao Chen Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 3/9] drm/panel: panel-novatak-nt35510: Use backlight power constants

2024-08-23 Thread Linus Walleij
On Wed, Jul 31, 2024 at 2:23 PM Thomas Zimmermann wrote: > Replace FB_BLANK_ constants with their counterparts from the > backlight subsystem. The values are identical, so there's no > change in functionality or semantics. > > Signed-off-by: Thomas Zimmermann > Cc: Li

Re: [PATCH 25/86] drm/mcde: Run DRM default client setup

2024-08-18 Thread Linus Walleij
red color mode of 32. As this > is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Linus Walleij Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 46/86] drm/tve200: Run DRM default client setup

2024-08-18 Thread Linus Walleij
On Fri, Aug 16, 2024 at 2:54 PM Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-07-16 Thread Linus Walleij
void the > warning on correctly working systems. Also add some comments and > update the TODO items in the hopes that future developers won't be too > confused by what's going on here. > > Suggested-by: Daniel Vetter > Signed-off-by: Douglas Anderson Reviewed-by: Linus Walleij This is the right thing to do. Yours, Linus Walleij

Re: [PATCH v2 3/3] drm/panel: jd9365da: Break some CMDS into helper functions

2024-07-04 Thread Linus Walleij
On Thu, Jul 4, 2024 at 6:50 AM Cong Yang wrote: > These panels have some common cmds (e0h~e3h,80h), let's break > them into helper functions. > > Signed-off-by: Cong Yang This is a good start! :) Reviewed-by: Linus Walleij If you get time one of these days, see if you can

Re: [PATCH v1 2/2] drm/panel: jd9365da: Support for Melfas lmfbx101117480 MIPI-DSI panel

2024-07-03 Thread Linus Walleij
ed-off-by: Cong Yang This is certainly OK Acked-by: Linus Walleij > +static int melfas_lmfbx101117480_init_cmds(struct jadard *jadard) > +{ > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = jadard->dsi }; > + > + mipi_dsi_dc

Re: [PATCH v2 05/17] backlight: gpio-backlight: Use backlight power constants

2024-06-26 Thread Linus Walleij
On Mon, Jun 24, 2024 at 5:20 PM Thomas Zimmermann wrote: > Replace FB_BLANK_ constants with their counterparts from the > backlight subsystem. The values are identical, so there's no > change in functionality. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Linus Wa

Re: [PATCH v2 06/17] backlight: ipaq-micro-backlight: Use backlight power constants

2024-06-26 Thread Linus Walleij
On Mon, Jun 24, 2024 at 5:20 PM Thomas Zimmermann wrote: > Replace FB_BLANK_ constants with their counterparts from the > backlight subsystem. The values are identical, so there's no > change in functionality. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Linus Wa

Re: [PATCH v2] drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-17 Thread Linus Walleij
t; is non-NULL. > > Suggested-by: Maxime Ripard > Reviewed-by: Maxime Ripard > Reviewed-by: Fei Shao > Tested-by: Fei Shao > Signed-off-by: Douglas Anderson Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 3/3] drm/panel: simple: Add PrimeView PM070WL4 support

2024-06-17 Thread Linus Walleij
On Thu, Jun 6, 2024 at 9:28 AM Primoz Fiser wrote: > Add support for PrimeView PM070WL4 7.0" (800x480) TFT-LCD panel. > Datasheet can be found at [1]. > > [1] https://www.beyondinfinite.com/lcd/Library/Pvi/PM070WL4-V1.0.pdf > > Signed-off-by: Primoz Fiser Reviewed-by

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-12 Thread Linus Walleij
gt; Probably need to read dri-devel archives for all the past attempts around > device_link_add. I think involving Saravana Kannan in the discussions around this is the right thing to do, because he knows how to get devicelinks to do the right thing. If we can describe what devicelink needs to do to get this ordering right, I'm pretty sure Saravana can tell us how to do it. Yours, Linus Walleij

Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-10 Thread Linus Walleij
us but long. I think I stayed off it because changing stuff like that all over the place creates churn and churn is bad. Yours, Linus Walleij

Re: [v7 6/7] dt-bindings: display: panel: Add compatible for IVO t109nw41

2024-05-28 Thread Linus Walleij
On Wed, May 15, 2024 at 3:47 AM Cong Yang wrote: > The IVO t109nw41 is a 11.0" WUXGA TFT LCD panel with himax-hx83102 > controller. Hence, we add a new compatible with panel specific config. > > Signed-off-by: Cong Yang > Acked-by: Conor Dooley Reviewed-by: Linus Wa

Re: [v7 4/7] dt-bindings: display: panel: Add compatible for BOE nv110wum-l60

2024-05-28 Thread Linus Walleij
On Wed, May 15, 2024 at 3:47 AM Cong Yang wrote: > The BOE nv110wum-l60 is a 11.0" WUXGA TFT LCD panel with himax-hx83102 > controller. Hence, we add a new compatible with panel specific config. > > Signed-off-by: Cong Yang > Acked-by: Conor Dooley Reviewed-by: Linus Wa

Re: [v7 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings

2024-05-28 Thread Linus Walleij
> Signed-off-by: Cong Yang > Reviewed-by: Conor Dooley Nice work, Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 0/8] drm/panel: Some very minor err handling fixes + more _multi

2024-05-18 Thread Linus Walleij
by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 2/3] dt-bindings: display: panel: constrain 'reg' in SPI panels

2024-05-13 Thread Linus Walleij
lay panels. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v6 7/7] drm/panel: himax-hx83102: Support for IVO t109nw41 MIPI-DSI panel

2024-05-13 Thread Linus Walleij
g Yang Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v6 5/7] drm/panel: himax-hx83102: Support for BOE nv110wum-l60 MIPI-DSI panel

2024-05-13 Thread Linus Walleij
Cong Yang Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v6 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-13 Thread Linus Walleij
d 0x29 cmds invoked at prepare() > function. > > Note:0x11 is mipi_dsi_dcs_exit_sleep_mode > 0x29 is mipi_dsi_dcs_set_display_on > > [1]: > https://lore.kernel.org/all/CACRpkdbzYZAS0=zbqjuc4cb2wj4s1h6n6asazqvdmv95r3z...@mail.gmail.com > > Signed-off-by: Cong Yang With Doug

Re: [PATCH 3/3] dt-bindings: display: panel: constrain 'reg' in DSI panels

2024-05-13 Thread Linus Walleij
ached display > panels, based on DTS sources in Linux kernel (assume all devices take > only one channel number). > > Signed-off-by: Krzysztof Kozlowski Looks right to me. Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 6/9] drm/panel: novatek-nt36672e: Switch to mipi_dsi_dcs_write_seq_multi()

2024-05-13 Thread Linus Walleij
62365248-988 > Total: Before=10651, After=9663, chg -9.28% > > Cc: Ritesh Kumar > Signed-off-by: Douglas Anderson Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [RFT PATCH v2 00/48] drm/panel: Remove most store/double-check of prepared/enabled state

2024-05-05 Thread Linus Walleij
rg This is the right thing to do, thanks for looking into this! As for the behaviour of .remove() I doubt whether in many cases the original driver authors have even tested this themselves. I would say we should just apply the series as soon as it's non-RFC after the next merge window and see what happens. I doubt it will cause much trouble. The series: Acked-by: Linus Walleij Yours, Linus Walleij

Re: [RFT PATCH v2 47/48] drm/panel: sony-acx565akm: Don't call disable at remove

2024-05-05 Thread Linus Walleij
] https://lore.kernel.org/r/20230921192749.1542462-1-diand...@chromium.org > > Cc: Laurent Pinchart > Cc: Sebastian Reichel > Signed-off-by: Douglas Anderson Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [RFT PATCH v2 47/48] drm/panel: sony-acx565akm: Don't call disable at remove

2024-05-05 Thread Linus Walleij
On Fri, May 3, 2024 at 11:38 PM Douglas Anderson wrote: > It's the responsibility of a correctly written DRM modeset driver to > call drm_atomic_helper_shutdown() at shutdown time and that should be > disabling / unpreparing the panel if needed. Panel drivers shouldn't > be calling these function

Re: [RFT PATCH v2 46/48] drm/panel: sony-acx565akm: Don't double-check enabled state in disable

2024-05-05 Thread Linus Walleij
trying to disable. > > Cc: Laurent Pinchart > Cc: Sebastian Reichel > Signed-off-by: Douglas Anderson Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 9/9] drm/panel: innolux-p079zca: Don't use a table for initting panels

2024-05-05 Thread Linus Walleij
tables, let's also convert hex numbers to > lower case as per kernel conventions. > > Signed-off-by: Douglas Anderson With the mentioned bugfix: Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 5/9] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-05-05 Thread Linus Walleij
delta > nt36672e_1080x2408_60hz_init62365248-988 > Total: Before=10651, After=9663, chg -9.28% > > Signed-off-by: Douglas Anderson Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-05-05 Thread Linus Walleij
hen we can perhaps get others to chime in to see which style they > prefer? Let me know what you think. I'm in favor of this design. Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 8/9] drm/panel: ili9882t: Don't use a table for initting panels

2024-05-05 Thread Linus Walleij
> Since we're touching all the tables, let's also convert hex numbers to > lower case as per kernel conventions. > > Signed-off-by: Douglas Anderson Reviewed-by: Linus Walleij Thanks for doing this Doug, everything is starting to look much better after this series, and I hope we can keep Chromium display drivers looking this good going forward. Yours, Linus Walleij

Re: [PATCH v3 7/9] drm/panel: boe-tv101wum-nl6: Don't use a table for initting panels

2024-05-02 Thread Linus Walleij
x numbers to > lower case as per kernel conventions. > > Signed-off-by: Douglas Anderson Wow that's a *VERY* nice patch. Reviewed-by: Linus Walleij The metrics surprisingly reports more compact object code, I wasn't expecting this, but it's nice. Yours, Linus Walleij

Re: [PATCH v3 4/9] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-05-02 Thread Linus Walleij
d to one string in the chatty function and a function call at the invoking site". With some explanation like that +/- added in: Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 3/9] drm/mipi-dsi: mipi_dsi_*_write functions don't need to ratelimit prints

2024-05-02 Thread Linus Walleij
_init 17080 10640 -6440 > nt36672e_1080x2408_60hz_init._rs 10320 - -10320 > Total: Before=31815, After=15055, chg -52.68% > > Signed-off-by: Douglas Anderson OK then! Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 2/9] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_generic_write_seq()

2024-05-02 Thread Linus Walleij
aner to make the types match so let's > fix it. > > Fixes: a9015ce59320 ("drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro") > Signed-off-by: Douglas Anderson Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 1/9] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()

2024-05-02 Thread Linus Walleij
er to make the types match so let's > fix it. > > Fixes: 2a9e9daf7523 ("drm/mipi-dsi: Introduce mipi_dsi_dcs_write_seq macro") > Signed-off-by: Douglas Anderson All right! Nice work. Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v1 2/4] drm/panel: boe-tv101wum-nl6: Support for BOE nv110wum-l60 MIPI-DSI panel

2024-04-19 Thread Linus Walleij
ivo_t109nw41 > together to make a separate driver and break out boe-tv101wum-nl6 , > because they belong to the same controller. Aha OK sorry for my misunderstanding! We are all in agreement. Yours, Linus Walleij

Re: [PATCH] component: Support masters with no subcomponents

2024-04-19 Thread Linus Walleij
se the power supply is quick to be overloaded by the > backlight. Thanks then I bet the prototype 8060 MMCC driver needs similar fixes before it will work as well, so we should work to merge this, then look at 8060 support after that. Yours, Linus Walleij

Re: [PATCH v1 2/4] drm/panel: boe-tv101wum-nl6: Support for BOE nv110wum-l60 MIPI-DSI panel

2024-04-18 Thread Linus Walleij
uot;, .data = &nt35510_frida_frd400b25025, }, { .compatible = "hydis,hva40wv1", .data = &nt35510_hydis_hva40wv1, }, { } }; Take some inspiration from this driver and how we parameterize the different data depending on compatible string. Yours, Linus Walleij

Re: [PATCH] component: Support masters with no subcomponents

2024-04-17 Thread Linus Walleij
. Yours, Linus Walleij

Re: [PATCH v1 2/4] drm/panel: boe-tv101wum-nl6: Support for BOE nv110wum-l60 MIPI-DSI panel

2024-04-11 Thread Linus Walleij
ill call mipi_dsi_dcs_exit_sleep_mode(), delay, send command sequence, delay, call mipi_dsi_dcs_set_display_on() and delay where any delay can be 0. This achieves the same goal without messing up the whole place, but requires some tinkering with how to pass a sequence the right way etc. Are Google & partners interested in the job? ;) Yours, Linus Walleij

Re: [PATCH v2 12/25] gpio: virtio: drop owner assignment

2024-04-04 Thread Linus Walleij
On Sun, Mar 31, 2024 at 10:45 AM Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Acked-by: Bartosz Golaszewski > Acked-by: Viresh Kumar > Signed-off-by: Krzysztof Kozlowski Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-28 Thread Linus Walleij
lly where it got > in the way, using the syntax that is supported by both compilers. > > Fixes: 2cd3271b7a31 ("kbuild: avoid duplicate warning options") > Signed-off-by: Arnd Bergmann Neat! Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] phy: constify of_phandle_args in xlate

2024-02-21 Thread Linus Walleij
sztof Kozlowski (...) > drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 2 +- Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] backlight: ktd2801: depend on GPIOLIB

2024-02-15 Thread Linus Walleij
- BACKLIGHT_KTD2801 [=m] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=m] > > Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support") > Signed-off-by: Duje Mihanović Acked-by: Linus Walleij Technically you can also select GPIOLIB, because it

Re: [drm-drm-misc:drm-misc-next] dt-bindings: nt35510: document 'port' property

2024-01-27 Thread Linus Walleij
om schema $id: > http://devicetree.org/schemas/display/panel/novatek,nt35510.yaml# This is because the checker is applying the patch on something that is not drm-misc-next. I think the patch is fine. Yours, Linus Walleij

Re: [PATCH v3 3/3] backlight: Add Kinetic KTD2801 backlight support

2024-01-21 Thread Linus Walleij
racting out the library and the library has the change I requested so: Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-21 Thread Linus Walleij
uot;extern" since it is default I think even checkpatch complains about it these days? Anyway, no big deal: Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver

2024-01-19 Thread Linus Walleij
lay timer! Can you use usleep_range() instead, at least for this one? > + for (int i = 0; i < 8; i++) { > + u8 next_bit = (brightness & 0x80) >> 7; I would just: #include bool next_bit = !!(brightness & BIT(7)); Yours, Linus Walleij

Re: [PATCH v2 1/2] dt-bindings: backlight: add Kinetic KTD2801 binding

2024-01-19 Thread Linus Walleij
maxItems: 1 First I thought this was inconsistent with ktd253, then I looked at the datasheets and they really did change "en" to "ctrl" so this needs a new name indeed. With commit message added: Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] drm/panel: novatek-nt36672e: Include

2024-01-19 Thread Linus Walleij
; Signed-off-by: Ritesh Kumar Patch applied to drm-misc-next on top of the commit that need fixing. Yours, Linus Walleij

Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for GPD Win Mini

2024-01-19 Thread Linus Walleij
On Fri, Dec 22, 2023 at 4:02 AM Samuel Dionne-Riel wrote: > Signed-off-by: Samuel Dionne-Riel The patch looks OK, it was missing a commit message so I added one and applied the patch to drm-misc-next. Yours, Linus Walleij

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-12 Thread Linus Walleij
ymbols. > So in short this panel is the model 9A-3R063-1102B from DJN, which uses > a Himax HX83112A driver IC. So compatible = "djn,9a-3r063-1102b" since the setup sequences for hx83112a are clearly for this one display? Yours, Linus Walleij

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-11 Thread Linus Walleij
her Himax displays such as HX8394 to be using a Truly controller as well, hence the similarities. In a datasheet for their TFT800480-84-V1-E display controller Truly kept the init sequence name of void LCD_INIT_HX8290(void) for example. Yours, Linus Walleij

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-11 Thread Linus Walleij
main concern is that the next display using the same IC need to find the right file to patch. Yours, Linus Walleij

Re: [PATCH v5 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK

2024-01-09 Thread Linus Walleij
On Tue, Jan 9, 2024 at 1:54 PM Dario Binacchi wrote: > > do you want me to apply patches 5,7,8 to the dri-misc (...) > Yes, I would appreciate that very much. Pushed to drm-misc-next! Please submit the DTS files through the ST SoC tree. Yours, Linus Walleij

Re: [PATCH v5 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK

2024-01-09 Thread Linus Walleij
Hi Dario, do you want me to apply patches 5,7,8 to the dri-misc tree? Yours, Linus Walleij

Re: [DO NOT MERGE v6 12/37] dt-bindings: pci: pci-sh7751: Add SH7751 PCI

2024-01-09 Thread Linus Walleij
tc 7>, > +<0x1000 0 0 2 &julianintc 8>, > +<0x1000 0 0 3 &julianintc 5>, > +<0x1000 0 0 4 &julianintc 6>; This interrupt-map looks very strange, usually the last cell is the polarity flag and here it is omitted? I would expect something like: <0x 0 0 1 &julianintc 5 IRQ_TYPE_LEVEL_LOW>, (...) The interrupt-map schema in dtschema isn't really looking at this so it is easy to get it wrong. Yours, Linus Walleij

Re: [DO NOT MERGE v6 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema

2024-01-09 Thread Linus Walleij
ow from the compatible that this is "renesas,sh7751-intc" and I bet this table will be the same for any sh7751 right? Then just put it in a table in the driver instead and skip this from the device tree and bindings. If more interrupt controllers need to be supported by the driver, you can simply look up the table from the compatible string. Yours, Linus Walleij

Re: [PATCH 0/2] drm/bridge: sii902x: Crash fixes

2024-01-08 Thread Linus Walleij
On Wed, Jan 3, 2024 at 2:31 PM Tomi Valkeinen wrote: > Two small fixes to sii902x for crashes. > > Signed-off-by: Tomi Valkeinen These look good to me! Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK

2024-01-07 Thread Linus Walleij
om the panel device node which is what is also consuming the GPIO, so very logical. So I would certainly remove this .strict setting, but maybe Alexandre et al have a strong opinion about it. > Another option to fix my use case without introducing regressions > could be to add a > new pro

Re: [PATCH v4 8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK

2024-01-05 Thread Linus Walleij
gisters have > been set to their default values according to the specifications found > in the datasheet. > > [1] > https://github.com/STMicroelectronics/STM32CubeF7/blob/master/Drivers/BSP/Components/nt35510/ > Signed-off-by: Dario Binacchi > > --- > > (no changes si

Re: [PATCH v4 7/8] drm/panel: nt35510: move hardwired parameters to configuration

2024-01-05 Thread Linus Walleij
0_DOPCTR_0_EOTP | + NT35510_DOPCTR_0_N565, NT35510_DOPCTR_1_CTB }, + .madctl = NT35510_ROTATE_180_SETTING, Changing this to NT35510_ROTATE_0_SETTING makes it work fine again. With that change: Reviewed-by: Linus Walleij Tested-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK

2024-01-05 Thread Linus Walleij
On Thu, Jan 4, 2024 at 9:42 AM Dario Binacchi wrote: > The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the > Novatek NT35510-based panel family. > > Signed-off-by: Dario Binacchi v4 looks very nice, thanks! Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v2 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK

2024-01-01 Thread Linus Walleij
On Mon, Jan 1, 2024 at 5:16 PM Dario Binacchi wrote: > The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the > Novatek NT35510-based panel family. > > Signed-off-by: Dario Binacchi Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK

2023-12-29 Thread Linus Walleij
t sequences are not OK in this driver, and not in general, it is all the other drivers that are just unaware about what they are doing and this driver actually isn't. Yours, Linus Walleij

Re: [PATCH 7/8] drm/panel: nt35510: refactor panel initialization

2023-12-29 Thread Linus Walleij
tion for sequence encoding with less open coded command issue statements, by adding helpers to the DRM core, so if that is what you want to do, then do that instead? Yours, Linus Walleij

Re: [PATCH 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK

2023-12-29 Thread Linus Walleij
> +- const: hydis,hva40wv1 > +- const: novatek,nt35510 > + items: > +- const: frida,frd400b25025 > +- const: novatek,nt35510 You need a dash in from of each "items:" for that to work. Yours, Linus Walleij

[PATCH] fbdev/clcd: Delete the old CLCD driver

2023-12-12 Thread Linus Walleij
uot;) Signed-off-by: Linus Walleij --- MAINTAINERS | 5 - drivers/video/fbdev/Kconfig | 18 - drivers/video/fbdev/Makefile| 1 - drivers/video/fbdev/amba-clcd.c | 984 include/linux/amba/clcd-regs.h | 87 inclu

Re: [PATCH 3/3] drm/panel: st7701: Add Anbernic RG-ARC Panel Support

2023-12-11 Thread Linus Walleij
On Fri, Dec 8, 2023 at 4:48 PM Chris Morgan wrote: > From: Chris Morgan > > The Powkiddy RG-ARC is a series of 2 handheld devices, each with a 4 > inch 480x640 display. Add support for the display. > > Signed-off-by: Chris Morgan Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 1/3] drm/panel: st7701: Fix AVCL calculation

2023-12-11 Thread Linus Walleij
> is the expected register value. > > Fixes: 83b7a8e7e88e ("drm/panel/panel-sitronix-st7701: Parametrize voltage > and timing") > > Signed-off-by: Chris Morgan Good catch! Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 2/3] dt-bindings: display: st7701: Add Anbernic RG-ARC panel

2023-12-09 Thread Linus Walleij
On Fri, Dec 8, 2023 at 4:48 PM Chris Morgan wrote: > From: Chris Morgan > > The RG-ARC panel is a panel specific to the Anbernic RG-ARC. It is 4 > inches in size (diagonally) with a resolution of 480x640. > > Signed-off-by: Chris Morgan Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] drm: Fix FD ownership check in drm_master_check_perm()

2023-12-07 Thread Linus Walleij
> the FD performs an ioctl. Fix this by checking TGID. > > Fixes: 4230cea89cafb ("drm: Track clients by tgid and not tid") > Signed-off-by: Lingkai Dong Tested-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] drm: Fix FD ownership check in drm_master_check_perm()

2023-12-07 Thread Linus Walleij
it in your mailbox: https://lore.kernel.org/dri-devel/pa6pr08mb107665920be9a96658cda04ce88...@pa6pr08mb10766.eurprd08.prod.outlook.com/ I'm seeing this as well (on Android). Tvrko, Christian: can you look at this? Will you apply it to the AMD tree for fixes if it looks OK or does it go elsewhere? Yours, Linus Walleij

Re: [DO NOT MERGE v5 11/37] pci: pci-sh7751: Add SH7751 PCI driver

2023-12-05 Thread Linus Walleij
ings and drivers that use dma-ranges for help: Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml drivers/pci/controller/pci-ixp4xx.c Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml drivers/pci/controller/pci-ftpci100.c Yours, Linus Walleij

Re: [DO NOT MERGE v5 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema

2023-12-05 Thread Linus Walleij
table always the same for a certain SoC, e.g. compatible "renesas,sh7751-intc"? Then don't keep it in the device tree, just look it up per-soc from a table in the driver. Other than that it looks good to me. Yours, Linus Walleij

Re: [PATCH v2 0/2] drm/bridge: panel: Check device dependency before managing device link

2023-11-29 Thread Linus Walleij
t is ACKed by the respective maintainer for that area of the kernel? > Could you write a patch to do so? Patch dim? Well my bash skills are a bit so-so. But I guess I could learn it. But did you say there is already a prototype? Yours, Linus Walleij

Re: (subset) [PATCH 0/3] Revert panel fixes and original buggy patch

2023-11-28 Thread Linus Walleij
On Tue, Nov 28, 2023 at 11:13 AM Neil Armstrong wrote: > On 28/11/2023 11:12, Neil Armstrong wrote: > > Hi, > > > > On Tue, 28 Nov 2023 00:10:18 +0100, Linus Walleij wrote: > >> This series reverts the attempts to fix the bug that went > >> into v6.7-rc1

Re: [PATCH 0/3] Revert panel fixes and original buggy patch

2023-11-28 Thread Linus Walleij
On Tue, Nov 28, 2023 at 9:30 AM Neil Armstrong wrote: > You can apply them now, or tell me if you want me to apply them. Please apply them Neil (to drm-misc-fixes) order 2, 1, 3 for bisectability. Yours, Linus Walleij

  1   2   3   4   5   6   7   8   9   10   >