Hi Krzysztof,
thanks for your patch!
On Mon, May 5, 2025 at 11:16 AM Krzysztof Kozlowski
<krzysztof.kozlow...@linaro.org> wrote:
> Add driver for the Novatek NT37801 or NT37810 AMOLED DSI 1440x3200
> panel in CMD mode, used on Qualcomm MTP8750 board (SM8750).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
(...)
> +static int novatek_nt37801_on(struct novatek_nt37801 *ctx)
> +{
> + struct mipi_dsi_device *dsi = ctx->dsi;
> + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
> +
> + dsi->mode_flags |= MIPI_DSI_MODE_LPM;
> +
> + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0,
> + 0x55, 0xaa, 0x52, 0x08, 0x01);
The above is obviously some kind of unlocking
sequence to open page 1 of some vendor registers.
We know this because the exact same sequence appear in
panel-innolux-p079zca.c and panel-sony-tulip-truly-nt35521.c
and the last argument is the page, so there we added
a switch page macro making it clear what is going on.
Could you do the same here?
With this addressed:
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Yours,
Linus Walleij
