-
include/linux/fb.h | 12 ++--
include/linux/lcd.h | 21 +-
include/linux/leds.h | 6 ++
11 files changed, 215 insertions(+), 208 deletions(-)
--
Lee Jones [李琼斯]
On Tue, 15 Apr 2025, Mario Limonciello wrote:
> On 4/15/2025 10:53 AM, Lee Jones wrote:
> > On Tue, 08 Apr 2025, Mario Limonciello wrote:
> >
> > > From: Mario Limonciello
> > >
> > > Currently userspace software systemd treats `brightness` and
>
takes into account other factors besides the value programmed
> + for 'brightness' and may not match the value in 'brightness'.
Which factors? Under what circumstances may the values not match?
> Users: HAL
>
> What:/sys/class/backlight//max_brightness
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
On Thu, 10 Apr 2025, Lee Jones wrote:
> On Fri, 21 Mar 2025 10:53:53 +0100, Thomas Zimmermann wrote:
> > This series removes the remaining dependencies on fbdev from the
> > backlight, lcd and led subsystems. Each depends on fbdev events to
> > track display state. M
8409b817
[10/11] leds: backlight trigger: Replace fb events with a dedicated function
call
commit: dc2139c0aa3283e5749109641af1878ed7bf7371
[11/11] fbdev: Remove constants of unused events
commit: d32a0b567a8a8b6e677d35c4f8eb8bd32b7029a0
--
Lee Jones [李琼斯]
comes in, feel free to merge it via the backlight tree. I can also take the
> series into dri-devel.
I plan to take this in via the Backlight tree. Once applied, I'll send
out a pull-request for other maintainers to pull from.
For the record, just so we're clear, this will not make v6.15.
--
Lee Jones [李琼斯]
On Fri, 04 Apr 2025, Lee Jones wrote:
> On Tue, 01 Apr 2025 17:16:47 +0800, Henry Martin wrote:
> > devm_kasprintf() returns NULL when memory allocation fails. Currently,
> > wled_configure() does not check for this case, which results in a NULL
> > pointer dereference.
&g
vent this issue.
>
>
> [...]
Applied, thanks!
[1/1] backlight: pm8941: Add NULL check in wled_configure()
commit: b0fdeb96ead46de57a6226bc3a3ac7f9b50c0ace
--
Lee Jones [李琼斯]
.org/all/Z8z236h4B5A6Ki3D@gallifrey/
>
> Remove it.
>
> [...]
Applied, thanks!
[7/9] backlight: pcf50633-backlight: Remove
commit: dfc034a0494b8fb8ea881aeb41a0c4e2619ff1e4
--
Lee Jones [李琼斯]
On Mon, 10 Mar 2025 12:56:36 +0800, WangYuli wrote:
> The description for CONFIG_LCD_TDO24M has redundant whitespace.
> Trim it to keep the code tidy.
>
>
Applied, thanks!
[1/1] backlight: tdo24m: Eliminate redundant whitespace
commit: c9fe785857fdfc780d49b60b5bb77ca21a51
/9] mfd: pcf50633: Remove irq code
commit: 786ad21f4350601c9d118ddbd19b7b830c04ece6
[9/9] mfd: pcf50633: Remove remains
commit: 44356090d59efd8db152e9eecb8e7f843be319f0
--
Lee Jones [李琼斯]
re/fbmem.c | 82 ++---
> drivers/video/fbdev/core/fbsysfs.c | 8 +-
> include/linux/backlight.h| 22 ++---
> include/linux/fb.h | 12 +--
> include/linux/lcd.h | 21 -
> include/linux/leds.h
On Sat, 08 Mar 2025, Jonathan Cameron wrote:
> On Wed, 5 Mar 2025 16:18:38 +0200
> Svyatoslav Ryhel wrote:
>
> > ср, 5 бер. 2025 р. о 15:45 Jonathan Cameron пише:
> > >
> > > On Fri, 28 Feb 2025 11:30:51 +0200
> > > Svyatoslav Ryhel wrote:
> > &
>dev.parent,
> + bl, &lm3533_bl_ops, &props);
> if (IS_ERR(bd)) {
> dev_err(&pdev->dev, "failed to register backlight device\n");
> return PTR_ERR(bd);
> @@ -320,7 +339,20 @@ static int lm3533_bl_probe(struct platform_device *pdev)
>
> backlight_update_status(bd);
>
> - ret = lm3533_bl_setup(bl, pdata);
> + /* 5000 - 29800 uA (800 uA step) */
> + val = 5000;
> + device_property_read_u32(&pdev->dev, "ti,max-current-microamp", &val);
> + bl->max_current = val;
> +
> + /* 0 - 0x3f */
> + val = 0;
> + device_property_read_u32(&pdev->dev, "ti,pwm-config-mask", &val);
> + bl->pwm = val;
> +
> + bl->linear = device_property_read_bool(&pdev->dev,
> "ti,linear-mapping-mode");
> + bl->hvled = device_property_read_bool(&pdev->dev,
> "ti,hardware-controlled");
> +
> + ret = lm3533_bl_setup(bl);
> if (ret)
> goto err_sysfs_remove;
>
> @@ -381,10 +413,17 @@ static void lm3533_bl_shutdown(struct platform_device
> *pdev)
> lm3533_ctrlbank_disable(&bl->cb);
> }
>
> +static const struct of_device_id lm3533_bl_match_table[] = {
> + { .compatible = "ti,lm3533-backlight" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, lm3533_bl_match_table);
> +
> static struct platform_driver lm3533_bl_driver = {
> .driver = {
> .name = "lm3533-backlight",
> .pm = &lm3533_bl_pm_ops,
> + .of_match_table = lm3533_bl_match_table,
> },
> .probe = lm3533_bl_probe,
> .remove = lm3533_bl_remove,
> diff --git a/include/linux/mfd/lm3533.h b/include/linux/mfd/lm3533.h
> index 69059a7a2ce5..3b28fc0970f6 100644
> --- a/include/linux/mfd/lm3533.h
> +++ b/include/linux/mfd/lm3533.h
> @@ -27,6 +27,9 @@ struct lm3533 {
> struct gpio_desc *hwen;
> int irq;
>
> + u32 boost_ovp;
> + u32 boost_freq;
> +
> unsigned have_als:1;
> unsigned have_backlights:1;
> unsigned have_leds:1;
> @@ -38,25 +41,6 @@ struct lm3533_ctrlbank {
> int id;
> };
>
> -struct lm3533_als_platform_data {
> - unsigned pwm_mode:1;/* PWM input mode (default analog) */
> - u8 r_select;/* 1 - 127 (ignored in PWM-mode) */
> -};
> -
> -struct lm3533_bl_platform_data {
> - char *name;
> - u16 max_current;/* 5000 - 29800 uA (800 uA step) */
> - u8 default_brightness; /* 0 - 255 */
> - u8 pwm; /* 0 - 0x3f */
> -};
> -
> -struct lm3533_led_platform_data {
> - char *name;
> - const char *default_trigger;
> - u16 max_current;/* 5000 - 29800 uA (800 uA step) */
> - u8 pwm; /* 0 - 0x3f */
> -};
> -
> enum lm3533_boost_freq {
> LM3533_BOOST_FREQ_500KHZ,
> LM3533_BOOST_FREQ_1000KHZ,
> @@ -69,19 +53,6 @@ enum lm3533_boost_ovp {
> LM3533_BOOST_OVP_40V,
> };
>
> -struct lm3533_platform_data {
> - enum lm3533_boost_ovp boost_ovp;
> - enum lm3533_boost_freq boost_freq;
> -
> - struct lm3533_als_platform_data *als;
> -
> - struct lm3533_bl_platform_data *backlights;
> - int num_backlights;
> -
> - struct lm3533_led_platform_data *leds;
> - int num_leds;
> -};
> -
> extern int lm3533_ctrlbank_enable(struct lm3533_ctrlbank *cb);
> extern int lm3533_ctrlbank_disable(struct lm3533_ctrlbank *cb);
>
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
Apple DWI backlight driver
commit: ea45d216dd4e5b389af984f8c9effa1312e3cd74
[3/3] MAINTAINERS: Add entries for Apple DWI backlight controller
commit: d1ebaf003a065d5d337b8fa3d69f9b90d7bb759d
--
Lee Jones [李琼斯]
On Thu, 13 Feb 2025, Thomas Zimmermann wrote:
> Hi
>
> Am 11.02.25 um 14:57 schrieb Lee Jones:
> > On Thu, 06 Feb 2025, Thomas Zimmermann wrote:
> >
> > > Remove support for fb events from the led backlight trigger. Provide the
> > > helper ledtrig_backli
backlight: led_bl: Hold led_access lock when calling led_sysfs_disable()
commit: 276822a00db3c1061382b41e72cafc09d6a0ec30
--
Lee Jones [李琼斯]
n = led_get_trigger_data(led);
>
> + mutex_lock(&ledtrig_backlight_list_mutex);
> + list_del(&n->entry);
> + mutex_unlock(&ledtrig_backlight_list_mutex);
> +
> fb_unregister_client(&n->notifier);
> kfree(n);
> }
> --
> 2.48.1
>
--
Lee Jones [李琼斯]
On Thu, 06 Feb 2025, Thomas Zimmermann wrote:
> Remove support for fb events from the led backlight trigger. Provide the
> helper ledtrig_backlight_blank() instead. Call it from fbdev to inform
> the trigger of changes to a display's blank state.
>
> Signed-off-by: Thomas Zimmermann
> ---
> dri
commit: d520ae4707fd6dafcb55649460059f67f54fc743
[15/16] backlight: vgg2432a4: Do not include
commit: d023cc09d9dbd5c6a4a81e0e3866c3b976d70891
[16/16] backlight: wm831x_bl: Do not include
commit: 373dacfeb55e1ac73dccd91b83437183ca0fbd43
--
Lee Jones [李琼斯]
--- a/include/linux/mfd/atmel-hlcdc.h
> +++ b/include/linux/mfd/atmel-hlcdc.h
> @@ -75,6 +75,7 @@
> */
> struct atmel_hlcdc {
> struct regmap *regmap;
> + struct clk *lvds_pll_clk;
> struct clk *periph_clk;
> struct clk *sys_clk;
> struct clk *slow_clk;
> --
> 2.25.1
>
--
Lee Jones [李琼斯]
On Wed, 18 Dec 2024 22:08:27 +0100, A. Sverdlin wrote:
> Add driver for TI LP8864, LP8864S, LP8866 4/6 channel LED-backlight drivers
> with I2C interface.
>
>
Applied, thanks!
[2/2] leds: lp8864: New driver
commit: e14d879292b0f7755c0d51b82a19b30859bb080a
--
Lee Jones [李琼斯]
gmap),
> + "Failed to allocate register map\n");
If you want to shorten this 'regmap' is fine.
> + /* Control brightness by DISPLAY_BRT register */
> + ret = regmap_update_bits(led->regmap, LP8864_USER_CONFIG1,
> + LP8864_BRT_MODE_MASK, LP8864_BRT_MODE_REG);
> + if (ret) {
> + dev_err(&led->client->dev, "Cannot write USER_CONFIG1\n");
Write user friendly messages.
"Failed to set the ..."
> + return ret;
> + }
> +
> + ret = lp8864_fault_check(led);
> + if (ret)
> + return ret;
> +
> + init_data.fwnode = of_fwnode_handle(child_node);
> + init_data.devicename = "lp8864";
> + init_data.default_label = ":display_cluster";
> +
> + ret = devm_led_classdev_register_ext(&client->dev, &led->led_dev,
> + &init_data);
> + if (ret)
> + dev_err(&client->dev, "Failed to register LED device (%pe)\n",
> + ERR_PTR(ret));
> +
> + return ret;
> +}
> +
> +static const struct i2c_device_id lp8864_id[] = {
> + { "lp8864" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(i2c, lp8864_id);
> +
> +static const struct of_device_id of_lp8864_leds_match[] = {
> + { .compatible = "ti,lp8864" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, of_lp8864_leds_match);
> +
> +static struct i2c_driver lp8864_driver = {
> + .driver = {
> + .name = "lp8864",
> + .of_match_table = of_lp8864_leds_match,
> + },
> + .probe = lp8864_probe,
> + .id_table = lp8864_id,
> +};
> +module_i2c_driver(lp8864_driver);
> +
> +MODULE_DESCRIPTION("Texas Instruments LP8864/LP8866 LED driver");
> +MODULE_AUTHOR("Alexander Sverdlin ");
> +MODULE_LICENSE("GPL");
> --
> 2.47.1
>
>
--
Lee Jones [李琼斯]
On Fri, 08 Nov 2024 08:30:44 +, Daniel Thompson wrote:
> Going forward, I'll be using my kernel.org address for upstream work.
>
>
Applied, thanks!
[1/2] MAINTAINERS: Use Daniel Thompson's korg address for backlight work
commit: 3adec6f907b698b32ab62f70da31b41abed
On Mon, 21 Oct 2024, Jiri Kosina wrote:
> On Tue, 1 Oct 2024, Lee Jones wrote:
>
> > Enjoy!
> >
> > The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc:
> >
> > Linux 6.12-rc1 (2024-09-29 15:06:19 -0700)
> >
> > are av
ht: convert zii,rave-sp-backlight.txt to yaml
commit: 0eda30af58809224d80dc3bf3f368fc677fe8c08
--
Lee Jones [李琼斯]
txt to yaml format
commit: f4b00ab2c29960961f9641be8f3e8ba4960fd849
--
Lee Jones [李琼斯]
an Muralidharan
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 8 +++-
> include/linux/mfd/atmel-hlcdc.h | 1 +
Acked-by: Lee Jones
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
;)
>
> With those not being called, it means that the backlight_notifier
> list is always empty.
>
> [...]
Applied, thanks!
[1/1] backlight: Remove notifier
commit: 5461f3fd74a89757f95f351eb0bc26aafc2a2e91
--
Lee Jones [李琼斯]
s, the list itself and the enum used in the
> > notifications.
> >
> > Signed-off-by: Dr. David Alan Gilbert
>
> Reviewed-by: Simona Vetter
>
> I think Lee Jones or Daniel Thompson will pick this up.
I will pick this up with Daniel's review.
--
Lee Jones [李琼斯]
On Mon, 07 Oct 2024, Werner Sembach wrote:
>
> Am 07.10.24 um 14:58 schrieb Lee Jones:
> > On Fri, 04 Oct 2024, Werner Sembach wrote:
> >
> > > Am 03.10.24 um 09:59 schrieb Lee Jones:
> > > > On Wed, 02 Oct 2024, Werner Sembach wrote:
> > > >
On Fri, 04 Oct 2024, Werner Sembach wrote:
>
> Am 03.10.24 um 09:59 schrieb Lee Jones:
> > On Wed, 02 Oct 2024, Werner Sembach wrote:
> >
> > > Hi,
> > >
> > > Am 02.10.24 um 14:52 schrieb Lee Jones:
> > > > On Fri, 27 Sep 2024, Wer
On Wed, 02 Oct 2024, Werner Sembach wrote:
> Hi,
>
> Am 02.10.24 um 14:52 schrieb Lee Jones:
> > On Fri, 27 Sep 2024, Werner Sembach wrote:
> >
> > > Hi,
> > > first revision integrating Armins feedback.
> > >
> > > Stuff I did not ye
nnotate and --compose next time please.
--
Lee Jones [李琼斯]
/fbdev/omap/lcd_ams_delta.c | 8 ++---
include/linux/fb.h | 13 +
include/linux/lcd.h | 29 +-
include/video/platform_lcd.h | 3 --
21 files changed, 181 insertions(+), 158 deletions(-)
--
Lee Jones [李琼斯]
ght: lcd: Do not include in lcd header
commit: 0d580d99749e759b62dc8e28f511310e9235da7a
--
Lee Jones [李琼斯]
d08906be37b8
--
Lee Jones [李琼斯]
commit: 3db60398b4c10425dd32c076280af7f334431064
--
Lee Jones [李琼斯]
On Thu, 12 Sep 2024, Mark Brown wrote:
> On Thu, Sep 12, 2024 at 03:51:00PM +0100, Lee Jones wrote:
> > On Wed, 04 Sep 2024, Mark Brown wrote:
>
> > > [03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC
> > > commit: 761cab667898d86c04867
se engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
--
Lee Jones [李琼斯]
u can do what you like with them since
> > none are major enough to stop me also sharing a:
> > Reviewed-by: Daniel Thompson
>
> Thanks for reviewing. I'll send out an update. Why tree do these patches go
> into? Backlight?
Yes, that's expected.
--
Lee Jones [李琼斯]
roller we wouldn't
> be able to implement that without having some other DT property to
> indicate which output ports are connected to the DP endpoint.
>
> Reviewed-by: Rob Herring (Arm)
> Cc: Krzysztof Kozlowski
> Cc: Conor Dooley
> Acked-by: Lee Jones
> Cc: B
On Wed, 28 Aug 2024 15:10:55 +, Detlev Casanova wrote:
> Document rk3576 compatible for QoS registers.
>
>
Applied, thanks!
[04/11] dt-bindings: mfd: syscon: Add rk3576 QoS register compatible
commit: 2f9709b8541dc742235743d19b8a6e2baa2e81d4
--
Lee Jones [李琼斯]
On Mon, 19 Aug 2024, Stephen Boyd wrote:
> This binding is about USB type-c control. Move the binding to the usb
> directory as it's a better home than chrome.
>
> Cc: Rob Herring
> Cc: Krzysztof Kozlowski
> Cc: Conor Dooley
> Cc: Lee Jones
> Cc: Benson Leu
roller we wouldn't
> be able to implement that without having some other DT property to
> indicate which output ports are connected to the DP endpoint.
>
> Cc: Rob Herring
> Cc: Krzysztof Kozlowski
> Cc: Conor Dooley
> Cc: Lee Jones
> Cc: Benson Leung
> Cc: Guenter
gning your mails like this. It means that some of
us have to physically click a pop-up box as we are parsing our inboxes.
I'm deleting all mails in this thread.
--
Lee Jones [李琼斯]
down.
>
> Also, add the audio power supply property which is dedicated for
> the audio codec sub-device.
>
> [...]
Applied, thanks!
[03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC
commit: 3821149eb101fe2d45a4697659e60930828400d8
--
Lee Jones [李琼斯]
down.
>
> Also, add the audio power supply property which is dedicated for
> the audio codec sub-device.
>
> [...]
Applied, thanks!
[03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC
commit: 3821149eb101fe2d45a4697659e60930828400d8
--
Lee Jones [李琼斯]
575651c593a9
--
Lee Jones [李琼斯]
16/17] backlight: rave-sp-backlight: Use backlight power constants
commit: 22f8a85ef0c563ba7e53d9ece39c1f2dc99f53ed
[17/17] backlight: sky81452-backlight: Use backlight power constants
commit: 1df5aa3754cac2045998ca505edb84d994786c67
--
Lee Jones [李琼斯]
> The scoped version of the macro accounts for such early breaks, fixing
> the early exits without the need for explicit calls to of_node_put().
>
> [...]
Applied, thanks!
[1/1] backlight: lm3509_bl: Fix early returns in for_each_child_of_node()
commit: b337cc3ce47549528fc3ee0b8c7ebd
er, more experienced maintainer's reviews would also be a good
> > use
> > of your time.
>
> I am trying to influence adjustments in desirable directions for a while.
Never stop trying to improve.
These are only my opinions of course. Take the advice or leave it.
There's no need to reply to this.
--
Lee Jones [李琼斯]
iew points, rather than repeating the same
few over and over? Reading other, more experienced maintainer's reviews
would also be a good use of your time.
--
Lee Jones [李琼斯]
On Fri, 21 Jun 2024, Nuno Sá wrote:
> On Fri, 2024-06-21 at 12:39 +0530, Vinod Koul wrote:
> > On 20-06-24, 18:05, Lee Jones wrote:
> > > On Thu, 20 Jun 2024, Vinod Koul wrote:
> > >
> > > > On 20-06-24, 12:45, Markus Elfring wrote:
> > > &g
o initialization or named designators. But it's also a nice
> cleanup on its own.
>
> [...]
Applied, thanks!
[1/1] backlight: Drop explicit initialization of struct
i2c_device_id::driver_data to 0
commit: bfd3587760498227510acc1b18c4299c7922ffe3
--
Lee Jones [李琼斯]
> The one where all emails from Markus go to dev/null
Play nice please.
Documentation/process/code-of-conduct.rst
--
Lee Jones [李琼斯]
natural as you can.
Ex 1: Please place curly brackets around this section to aid with
Ex 2: To save N lines of clean-up, please use scoped_guard()
Ex 3: Moving out this chunk to another function would help with
Etc.
--
Lee Jones [李琼斯]
/video/backlight/rt4831-backlight.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
>
> [...]
Applied, thanks!
[1/1] backlight: add missing MODULE_DESCRIPTION() macros
commit: 7857f5c38d04a38e7a20060a6d370caf0424aa4e
--
Lee Jones [李琼斯]
tion
commit: 90b7f2ead953aab5677ae8235d78841cee8fd13e
--
Lee Jones [李琼斯]
now I leave it to Lee and Johan to decide
> the destiny of the drivers.
Let's not rush into it. Take your time.
--
Lee Jones [李琼斯]
> 11 files changed, 2865 deletions(-)
> delete mode 100644 drivers/iio/light/lm3533-als.c
> delete mode 100644 drivers/leds/leds-lm3533.c
> delete mode 100644 drivers/mfd/lm3533-core.c
> delete mode 100644 drivers/video/backlight/lm3533_bl.c
> delete mode 100644 include/linux/mfd/lm3533.h
>
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
--
Lee Jones [李琼斯]
river
commit: b72755f5b577357cac661cbf9048cad704eb4ad8
--
Lee Jones [李琼斯]
17, 1, "active-low", "active-high"),
> + fld("ii", 16, 1, "normal", "inverted"),
> + fld("pll", 15, 1, "disable", "enable"),
> + fld("gap", 13, 2, "0"),
> + fld("dac", 12, 1, "enable", "disable"),
> + fld("mc", 11, 1, "cpu", "8051"),
> + fld("bl", 10, 8, "1"),
> + fld("usb", 9, 1, "master", "slave"),
> + fld("vr", 4, 1, "0x1e0", "0x3e0"),
> + { .name = NULL },
> +};
I've been avoiding this set for a while now!
I appreciate the amount of work that you've put into this, but this is a
bit of a disaster. It's a hell of lot of over-complex infrastructure
just to pull out some values from DT.
Forgive me if I have this wrong, but it looks like you're defining
various structs then populating static versions with hard-coded offsets
into DT arrays! Then you have a bunch of hoop-jumpy functions to
firstly parse the offset-structs, then conduct look-ups to pull the
final value which in turn gets shifted into an encoded variable ready
for to write out to the registers. Bonkers.
What does 'timing' even mean in this context? Clocks?
What other devices require this kind of handling? Why is this device so
different from all other supported devices to date? Instead of
attempting to shoehorn this into a 20 year old driver, why not reshape
it to bring it into alignment with how we do things today?
E.g. handle all clocking from the clock driver, all display settings
(including timing?) from the display driver, etc.
--
Lee Jones [李琼斯]
/lcd.h | 6 +++---
scripts/const_structs.checkpatch | 1 +
20 files changed, 23 insertions(+), 22 deletions(-)
--
Lee Jones [李琼斯]
On Fri, 03 May 2024, Lee Jones wrote:
> On Fri, 03 May 2024, Lee Jones wrote:
>
> > On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote:
> > > Changes in v2:
> > > - Collect tags, including wrongly places Thomas' tag (which requires me
> > >
On Fri, 03 May 2024, Lee Jones wrote:
> On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote:
> > Changes in v2:
> > - Collect tags, including wrongly places Thomas' tag (which requires me
> > to manually edit 15 other patches to drop it).
> >
ec6108d768f54d31e7cb48b06c0e3814
--
Lee Jones [李琼斯]
On Fri, 03 May 2024, FLAVIO SULIGOI wrote:
> Hi Lee,
>
> ...
>
> > Subject: EXTERNAL: Re: (subset) [PATCH v1 1/1] backlight: mp3309c: fix
> > leds flickering in pwm mode
> >
> > [Use caution with links & attachments]
> >
> >
> >
&
-backlight: Remove unnecessary call to of_node_get
commit: 4da294108e38bf9cd5c62c2caa47611e5dbb7fb1
--
Lee Jones [李琼斯]
On Thu, 02 May 2024, Lee Jones wrote:
> On Wed, 17 Apr 2024 17:31:05 +0200, Flavio Suligoi wrote:
> > The mp3309 has two configuration registers, named according to their
> > address (0x00 and 0x01).
> > In the second register (0x01), the bit DIMS (Dimming Mode Select) must
kering on the LEDs powered by the mp3309c.
>
> [...]
Applied, thanks!
[1/1] backlight: mp3309c: fix leds flickering in pwm mode
commit: ce60cddc2abf61902dfca71d630624db95315124
--
Lee Jones [李琼斯]
edid && len == EDID_LENGTH) {
> + struct fb_monspecs *specs;
> + u8 *edid;
> +
> + edid = kmemdup(p_edid, EDID_LENGTH, GFP_KERNEL);
> + if (edid) {
> + specs = kzalloc(sizeof(*specs), GFP_KERNEL);
> + if (specs) {
> + fb_edid_to_monspecs(edid, specs);
> + def_mode = specs->modedb;
> + }
> + }
> + kfree(edid);
> + }
> +
> + of_property_read_u32(child, "bpp", &bpp);
> +
> + /* If flags property is obtained, fbsub is returned. */
> + flags = read_display_flags(child);
> + if (flags) {
> + fbsub = devm_kzalloc(dev, sizeof(*fbsub), GFP_KERNEL);
> + if (fbsub) {
> + fbsub->def_mode = def_mode;
> + fbsub->def_bpp = bpp;
> + fbsub->flags = flags;
> + }
> + }
> + return fbsub;
> +}
> +
> +/* Build platform_data from OF property */
> +static struct sm501_platdata_fb *pdata_from_dt(struct device *dev, struct
> device_node *np)
> +{
> + enum sm501_fb_routing fb_route = SM501_FB_OWN;
> + struct sm501_platdata_fb *pdata = NULL;
> + struct sm501_platdata_fbsub *fb_crt;
> + struct sm501_platdata_fbsub *fb_pnl;
> + unsigned int flags = 0;
> +
> + if (of_property_read_bool(np, "route-crt-panel"))
> + fb_route = SM501_FB_CRT_PANEL;
> + if (of_property_read_bool(np, "swap-fb-endian"))
> + flags = SM501_FBPD_SWAP_FB_ENDIAN;
> + fb_crt = dt_fbsub(dev, np, "crt");
> + fb_pnl = dt_fbsub(dev, np, "panel");
> + if (fb_crt || fb_pnl) {
> + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> + if (pdata) {
> + pdata->fb_route = fb_route;
> + pdata->flags = flags;
> + pdata->fb_crt = fb_crt;
> + pdata->fb_pnl = fb_pnl;
> + }
> + }
> + return pdata;
> +}
> +#endif
> +
> static int sm501fb_probe(struct platform_device *pdev)
> {
> struct sm501fb_info *info;
> @@ -1974,6 +2074,12 @@ static int sm501fb_probe(struct platform_device *pdev)
> if (info->edid_data)
> found = 1;
> }
> + /* Get platform data compatible configuration */
> + if (!found) {
> + info->pdata = pdata_from_dt(dev, np);
> + if (info->pdata)
> + found = 1;
> + }
> }
> #endif
> if (!found) {
> --
> 2.39.2
>
--
Lee Jones [李琼斯]
On Thu, 02 May 2024, Lee Jones wrote:
> On Thu, 02 May 2024, Shresth Prasad wrote:
>
> > On Thu, May 2, 2024 at 3:06 PM Lee Jones wrote:
> > >
> > > On Thu, 02 May 2024, Shresth Prasad wrote:
> > >
> > > > `dev->of_node` already has a refere
On Thu, 02 May 2024, Shresth Prasad wrote:
> On Thu, May 2, 2024 at 3:06 PM Lee Jones wrote:
> >
> > On Thu, 02 May 2024, Shresth Prasad wrote:
> >
> > > `dev->of_node` already has a reference to the device_node and calling
> > > of_node_get on it
https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22
--
Lee Jones [李琼斯]
deo/fbdev/omap/lcd_ams_delta.c | 2 +-
> include/linux/lcd.h | 6 +++---
> scripts/const_structs.checkpatch | 1 +
> 20 files changed, 23 insertions(+), 22 deletions(-)
> ---
> base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8
> change-id: 20240414-video-backlight-lcd-ops-276d8439ffb8
>
> Best regards,
> --
> Krzysztof Kozlowski
>
--
Lee Jones [李琼斯]
20240414-video-backlight-lcd-ops-v1-0-9b37fcbf5...@kernel.org
>
> Cc: Lee Jones
> Cc: Daniel Thompson
> Cc: Jingoo Han
> Cc: linux-fb...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
> ---
> scripts/const_structs.checkpatch | 1 +
> 1 file changed, 1 insertion(+)
gt; EVERYTHING. You must provide tag under each individual patch.
And for that to not happen now, you have to resubmit the set. :)
--
Lee Jones [李琼斯]
b99886057a85
--
Lee Jones [李琼斯]
LP8788_BL_REGISTER_ONLY.
>
>
Applied, thanks!
[1/1] backlight: lp8788: Drop support for platform data
commit: 150476e60a80ebb93d49aae7b636934eb04b83d2
--
Lee Jones [李琼斯]
LP8788_BL_REGISTER_ONLY.
>
>
Applied, thanks!
[1/1] backlight: lp8788: Drop support for platform data
commit: 150476e60a80ebb93d49aae7b636934eb04b83d2
--
Lee Jones [李琼斯]
On Thu, 28 Mar 2024, Lee Jones wrote:
> On Thu, 28 Mar 2024 12:59:06 +0100, Greg Kroah-Hartman wrote:
> > Since commit 43a7206b0963 ("driver core: class: make class_register() take
> > a const *"), the driver core allows for struct class to be in read-only
> > memo
ke lcd_class constant
commit: d51564f749fe4e4efd570b0591f2d23696c90cc7
--
Lee Jones [李琼斯]
drivers/video/backlight/lcd.c | 23 +--
> 2 files changed, 29 insertions(+), 23 deletions(-)
No longer apply.
Please rebase on top of v6.9-rc1 or for-backlight-next.
--
Lee Jones [李琼斯]
| 1 -
11 files changed, 26 insertions(+), 84 deletions(-)
--
Lee Jones [李琼斯]
+++
include/linux/backlight.h| 16
include/linux/fb.h | 9 +
include/linux/pwm_backlight.h| 1 -
16 files changed, 71 insertions(+), 97 deletions(-)
--
Lee Jones [李琼斯]
that this didn't fail to compile ...
>
> Best regards
> Uwe
>
> drivers/video/backlight/lp8788_bl.c | 151 ++--
> include/linux/mfd/lp8788.h | 36 ---
> 2 files changed, 8 insertions(+), 179 deletions(-)
Does not apply.
Please rebase onto v6.9-rc1 or for-backlight-next.
--
Lee Jones [李琼斯]
On Wed, 27 Mar 2024, Lee Jones wrote:
> On Tue, 19 Mar 2024 10:37:19 +0100, Thomas Zimmermann wrote:
> > The field fb_blank in struct backlight_properties has been marked for
> > removal. Remove it in favor of the power and state fields.
> >
> > Patches 1 to 5 prepar
klight_properties
commit: 95342cdb3f438d378f48e4db188aa217b9b0a66e
--
Lee Jones [李琼斯]
On Thu, 21 Mar 2024, Lee Jones wrote:
> On Thu, 21 Mar 2024, Lee Jones wrote:
>
> > On Tue, 05 Mar 2024 17:22:33 +0100, Thomas Zimmermann wrote:
> > > Backlight drivers implement struct backlight_ops.check_fb, which
> > > uses struct fb_info in its interface.
-cm.c | 7 +--
> .../omapfb/displays/panel-sony-acx565akm.c| 10 +---
> include/linux/backlight.h | 25 +-
> include/linux/platform_data/omap1_bl.h| 1 -
> 11 files changed, 26 insertions(+), 84 deletions(-)
Is everyone okay with this being pushed through Backlight?
I can send out a PR to an immutable branch for others to pull from.
--
Lee Jones [李琼斯]
> sizes. However, it's still worth fixing.
>
>
Applied, thanks!
[1/1] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()
commit: 84a053e072c8aacff8074ac5d6f7a4e7ff745209
--
Lee Jones [李琼斯]
On Thu, 21 Mar 2024, Lee Jones wrote:
> On Tue, 05 Mar 2024 17:22:33 +0100, Thomas Zimmermann wrote:
> > Backlight drivers implement struct backlight_ops.check_fb, which
> > uses struct fb_info in its interface. Replace the callback with one
> > that does not use fb_info.
>
fbdev/ssd1307fb: Remove struct backlight_ops.check_fb
commit: ec5925ef4a2dfd7ee060f4fd2a2e8036f8a94e8e
[10/10] backlight: Add controls_device callback to struct backlight_ops
commit: 2e427743de015c1ac047036ef495c3f004105439
--
Lee Jones [李琼斯]
truct backlight_device *bl_dev;
> > - struct lp8788_backlight_platform_data *pdata;
> > - enum lp8788_bl_ctrl_mode mode;
> > struct pwm_device *pwm;
>
> Actually this pwm_device member should be dropped, too. I wonder why
> this even passes a W=1 build without a warning ...
>
> @Lee: Feel free to fix this up while applying, or tell me if you prefer
> an incremental fixup or a complete v2.
Either of the last 2 options would be fine.
--
Lee Jones [李琼斯]
-
> include/linux/platform_data/omap1_bl.h | 1 -
> 2 files changed, 4 deletions(-)
Just a quick one - I'm sure Daniel will be here soon to conduct a proper
review.
Could you attempt to use the subject line format expected by a given
subsystem please?
`git log --oneline -- ` is your friend.
Thanks.
--
Lee Jones [李琼斯]
ers and remove unnecessary implementations of check_fb. Finally,
> > patch 10 replaces the check_fb hook with controls_device, which
> > uses the framebuffer's Linux device instead of the framebuffer.
>
> I assume the merge plan for this series is via drm-misc in one go?
Backlight in one go. This will be the second attempt at applying it.
--
Lee Jones [李琼斯]
On Tue, 05 Mar 2024, Lee Jones wrote:
> On Mon, 04 Mar 2024, Thomas Zimmermann wrote:
>
> > Backlight drivers implement struct backlight_ops.check_fb, which
> > uses struct fb_info in its interface. Replace the callback with one
> > that does not use fb_info.
> >
--
> include/linux/backlight.h| 16 ++--
> include/linux/fb.h | 9 +++
> include/linux/pwm_backlight.h | 1 -
> 16 files changed, 70 insertions(+), 97 deletions(-)
All applied. Submitted for build testing.
Will follow-up with a PR once that's passed.
--
Lee Jones [李琼斯]
fbdev/ssd1307fb: Remove struct backlight_ops.check_fb
commit: d1b82cc44fd8be4013538992814c45f0e55c02b4
[10/10] backlight: Add controls_device callback to struct backlight_ops
commit: 7e508af663e20e9e40003bb30e06b926c754159b
--
Lee Jones [李琼斯]
1 - 100 of 1521 matches
Mail list logo
