on RK3576 and RK3588 when SCMI_CLK_GPU is used
for devfreq, a separate series will be sent to mitigate these issues.
This series depends on patch 1-4 of the series "rockchip: Add power
controller support for RK3528" [1].
[1] https://lore.kernel.org/r/20250518220707.669515-1-jo...@kwiboo
Enable the Mali-450 MP2 GPU on the Radxa E20C.
Signed-off-by: Jonas Karlman
---
arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
Rockchip RK3528 SoC has a Mali-450 MP2. Add a compatible for it.
Signed-off-by: Jonas Karlman
---
Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
b/Documentation
Add a GPU node and a opp-table for the Mali-450 MP2 in the RK3528 SoC.
Signed-off-by: Jonas Karlman
---
arch/arm64/boot/dts/rockchip/rk3528.dtsi | 58
1 file changed, 58 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3528.dtsi
b/arch/arm64/boot/dts/rockchip
Hi Cristian,
On 2024-11-16 19:22, Cristian Ciocaltea wrote:
> The RK3588 specific implementation is currently quite limited in terms
> of handling the full range of display modes supported by the connected
> screens, e.g. 2560x1440@75Hz, 2048x1152@60Hz, 1024x768@60Hz are just a
> few of them.
>
>
On 2024-10-17 09:06, Andy Yan wrote:
>
>
> Hi Robin,
>
> Thanks for your comment。
>
> At 2024-10-17 01:38:23, "Robin Murphy" wrote:
>> On 2024-09-20 9:20 am, Andy Yan wrote:
>>> From: Andy Yan
>>>
>>> The vop mmu support translate physical address upper 4 GB to iova
>>> below 4 GB. So set dm
Hi Cristian,
On 2024-09-29 00:36, Cristian Ciocaltea wrote:
> The RK3588 SoC family integrates the newer Synopsys DesignWare HDMI 2.1
> Quad-Pixel (QP) TX controller IP and a HDMI/eDP TX Combo PHY based on a
> Samsung IP block.
>
> Add just the basic support for now, i.e. RGB output up to 4K@60Hz
Hi Krzysztof,
On 2024-09-22 10:15, Krzysztof Kozlowski wrote:
> On 22/09/2024 00:20, Jonas Karlman wrote:
>> The Rockchip RK3288 SoC contain two different Visual Output Processor
>> (VOP) blocks, VOP_BIG and VOP_LIT. The VOP blocks support different max
>> output reso
compatible is kept for compatibility with
older device tree.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 27 +++--
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c
b/drivers/gpu/drm/rockchip
compatibility.
Signed-off-by: Jonas Karlman
---
arch/arm/boot/dts/rockchip/rk3288.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/rockchip/rk3288.dtsi
b/arch/arm/boot/dts/rockchip/rk3288.dtsi
index 3f1d640afafa..db4a258551f4 100644
--- a/arch/arm/boot/dts
The Rockchip RK3288 SoC contain two different Visual Output Processor
(VOP) blocks, VOP_BIG and VOP_LIT. The VOP blocks support different max
output resolution, 3840x2160 and 2560x1600.
Add compatible to differentiate between the two VOP blocks.
Signed-off-by: Jonas Karlman
---
.../display
kept for older and newer DTs.
Jonas Karlman (3):
dt-bindings: display: rockchip-vop: Split rk3288-vop into big and lit
ARM: dts: rockchip: Split rk3288-vop into big and lit
drm/rockchip: vop: Split rk3288-vop into big and lit
.../display/rockchip/rockchip-vop.yaml| 36
On 2024-09-20 09:04, neil.armstr...@linaro.org wrote:
> On 19/09/2024 22:34, Jonas Karlman wrote:
>> Hi Neil,
>>
>> On 2024-09-13 10:02, Neil Armstrong wrote:
>>> On 08/09/2024 15:28, Jonas Karlman wrote:
>>>> Update successfully read EDID during hotpl
Hi Neil,
On 2024-09-13 10:02, Neil Armstrong wrote:
> On 08/09/2024 15:28, Jonas Karlman wrote:
>> Update successfully read EDID during hotplug processing to ensure the
>> connector diplay_info is always up-to-date.
>>
>> Signed-off-by: Jonas Karlman
>> ---
>
Hi Neil,
On 2024-09-09 15:16, Neil Armstrong wrote:
> On 08/09/2024 15:28, Jonas Karlman wrote:
>> drm_helper_hpd_irq_event() and drm_bridge_hpd_notify() may incorrectly
>> be called with a connected status when HPD is high and RX sense is
>> changed. This typically happen w
help kernel kms client make use of 4K display
modes for console use on RK3399.
Signed-off-by: Jonas Karlman
---
v2: No change
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 23 +
1 file changed, 23 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
b
Use a maximum TMDS clock rate limit of 594MHz to enable use of HDMI2.0
modes, e.g. 4K@60Hz, on RK3399 and RK3568.
Signed-off-by: Jonas Karlman
Tested-by: Diederik de Haas # Quartz64 Model B
---
v2: Collect t-b tag
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 4 ++--
1 file changed, 2
g in the old
table.
Signed-off-by: Douglas Anderson
Signed-off-by: Yakir Yang
Signed-off-by: Jonas Karlman
---
v2: No change
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 104 ++--
1 file changed, 53 insertions(+), 51 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw
.
Signed-off-by: Douglas Anderson
Signed-off-by: Yakir Yang
Signed-off-by: Jonas Karlman
---
v2: No change
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
b/drivers
From: Nickey Yang
Add phy_config for 594Mhz pixel clock used for HDMI2.0 display modes.
Signed-off-by: Nickey Yang
Signed-off-by: Jonas Karlman
---
v2: No change
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip
ts, we need to
higher clock voltage and lower data voltage, then we can keep RF/EMI
satisfied and single-end & differen test passed.
ck: lvl = 9, term=100, vlo = 2.65, vhi=3.12, vswing = 0.47
tx: lvl = 16, term=100, vlo = 2.75, vhi=3.15, vswing = 0.39
Signed-off-by: Yakir Yang
Signed-off
the max_tmds_clock validation is sufficient.
Signed-off-by: Jonas Karlman
Tested-by: Diederik de Haas # Rock64
---
v2: Collect t-b tag
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 35 ++---
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm
org/series/134727/
[2]
https://github.com/Kwiboo/linux-rockchip/commits/next-20240906-rk-dw-hdmi-v2/
Douglas Anderson (2):
drm/rockchip: dw_hdmi: Set cur_ctr to 0 always
drm/rockchip: dw_hdmi: Use auto-generated tables
Jonas Karlman (3):
drm/rockchip: dw_hdmi: Filter modes based on hdmiphy
Use the passed mode instead of mixing use of passed mode and the stored
previous_mode. The passed mode is currenly always the previous_mode.
Also fix a small typo and add a variable to help shorten a code line.
Signed-off-by: Jonas Karlman
---
v2: Update commit message, s/type/typo
interrupt when HPD
is going high, not on the RX sense interrupt when RX sense is changed.
Fixes: da09daf88108 ("drm: bridge: dw_hdmi: only trigger hotplug event on link
change")
Signed-off-by: Jonas Karlman
---
v2: New patch
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++-
1 fi
hotplug irq handler.
A benefit of this is that drm mode_config mutex is always held at
poweron/off, something that may reduce the need for our own mutex.
Signed-off-by: Jonas Karlman
---
v2: Update commit message
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 33 ++-
1 file
Fold the poweron and setup functions into one function and use the
adjusted_mode directly from the new crtc_state to remove the need of
storing previous_mode.
Signed-off-by: Jonas Karlman
---
v2: No change
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 21 -
1 file changed
struct member and related define.
Reviewed-by: Neil Armstrong
Signed-off-by: Jonas Karlman
---
v2: Collect r-b tag
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 32 ---
1 file changed, 5 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
With CEC phys addr invalidation moved away from the irq handler there is
no longer a need for cec_notifier_mutex, remove it.
Reviewed-by: Neil Armstrong
Signed-off-by: Jonas Karlman
---
v2: Collect r-b tag
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 11 +--
1 file changed, 1
Update successfully read EDID during hotplug processing to ensure the
connector diplay_info is always up-to-date.
Signed-off-by: Jonas Karlman
---
v2: No change
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/bridge
Wait until the connector detect ops is called to invalidate CEC phys
addr instead of doing it directly from the irq handler.
Reviewed-by: Neil Armstrong
Signed-off-by: Jonas Karlman
---
v2: Collect r-b tag
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 18 +++---
1 file changed
With the use of adjusted_mode directly from the crtc_state there is no
longer a need to store a copy in previous_mode, remove it and the now
unneeded mode_set ops.
Signed-off-by: Jonas Karlman
---
v2: No change
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 19 +--
1 file
that only
support HDMI 1.4.
Fix this by disabling the scrambler feature when SCDC is not supported.
Fixes: 264fce6cc2c1 ("drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling
support")
Reported-by: Christopher Obbard
Signed-off-by: Jonas Karlman
---
v2: New patch
---
drivers/gpu/dr
on HPD interrupt
- Update commit messages
- Collect r-b tags
- Rebased on next-20240906
[1] https://lore.kernel.org/r/20240615170417.3134517-1-jo...@kwiboo.se/
Jonas Karlman (10):
drm: bridge: dw_hdmi: Disable scrambler feature when not supported
drm: bridge: dw_hdmi: Only notify connected
On 2024-07-25 11:25, Maxime Ripard wrote:
> On Thu, Jun 27, 2024 at 04:29:49PM GMT, Dmitry Baryshkov wrote:
>> On Thu, Jun 27, 2024 at 11:49:37AM GMT, Maxime Ripard wrote:
>>> On Wed, Jun 26, 2024 at 07:09:34PM GMT, Dmitry Baryshkov wrote:
On Wed, Jun 26, 2024 at 04:05:01PM GMT, Maxime Ripard
Hi Neil,
On 2024-06-24 11:56, neil.armstr...@linaro.org wrote:
> On 24/06/2024 11:41, Jonas Karlman wrote:
>> Hi Neil,
>>
>> On 2024-06-24 11:23, Neil Armstrong wrote:
>>> On 11/06/2024 17:50, Jonas Karlman wrote:
>>>> Change to only call poweron/
Hi Neil,
On 2024-06-24 11:23, Neil Armstrong wrote:
> On 11/06/2024 17:50, Jonas Karlman wrote:
>> Change to only call poweron/poweroff from atomic_enable/atomic_disable
>> ops instead of trying to keep a bridge_is_on state and poweron/off in
>> the hotplug irq handler.
>&
Hi Heiko,
On 2024-06-17 22:30, Heiko Stübner wrote:
> Am Samstag, 15. Juni 2024, 19:03:53 CEST schrieb Jonas Karlman:
>> Similar to DCLK_LCDC on RK3328, the DCLK_VOP on RK3228 is typically
>> parented by the hdmiphy clk and it is expected that the DCLK_VOP and
>> hdmiphy clk
Hi Diederik,
On 2024-06-15 23:53, Diederik de Haas wrote:
> On Saturday, 15 June 2024 19:03:57 CEST Jonas Karlman wrote:
>> The rate limit for RK3288, RK3399 and RK3568 is based on current mpll
>> table. The rate limit for RK3228 and RK3228 is based on the
>> inno-hdmi-phy
ts, we need to
higher clock voltage and lower data voltage, then we can keep RF/EMI
satisfied and single-end & differen test passed.
ck: lvl = 9, term=100, vlo = 2.65, vhi=3.12, vswing = 0.47
tx: lvl = 16, term=100, vlo = 2.75, vhi=3.15, vswing = 0.39
Signed-off-by: Yakir Yang
Signed-off
max_tmds_clock validation is sufficient.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 35 ++---
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
b/drivers/gpu/drm/rockchip/dw_hdmi
From: Nickey Yang
Add phy_config for 594Mhz pixel clock used for HDMI2.0 display modes.
Signed-off-by: Nickey Yang
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
b
kernel kms client make use of 4K display
modes for console use on RK3399.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 23 +
1 file changed, 23 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
b/drivers/gpu/drm
reading EDID to fail in connector get_modes ops.
Call dw_hdmi_rk3328_read_hpd at end of dw_hdmi_rk3328_setup_hpd to
correct io voltage and allow reading EDID after setup_hpd.
Fixes: 1c53ba8f22a1 ("drm/rockchip: dw_hdmi: add dw-hdmi support for the
rk3328")
Signed-off-by: Jonas Karlman
--
Use a maximum TMDS clock rate limit of 594MHz to enable use of HDMI2.0
modes, e.g. 4K@60Hz, on RK3399 and RK3568.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi
.
Fixes: 4c156c21c794 ("drm/rockchip: vop: support plane scale")
Signed-off-by: Alex Bee
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/d
pre-pll table.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
index 5df9c9a0d369..75b5d63ec570 100644
--- a
g in the old
table.
Signed-off-by: Douglas Anderson
Signed-off-by: Yakir Yang
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 104 ++--
1 file changed, 53 insertions(+), 51 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
b/d
Call dw_hdmi_set_high_tmds_clock_ratio in phy init ops to allow support
of High TMDS Bit Rates used by HDMI2.0 display modes.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi
.
Signed-off-by: Douglas Anderson
Signed-off-by: Yakir Yang
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
b/drivers/gpu/drm/rockchip
The VOP on RK3328 needs to run at a higher rate in order to produce a
proper 3840x2160 signal.
Change to use 300MHz for VIO clk and 400MHz for VOP clk, same rates used
by vendor 4.4 kernel.
Fixes: 52e02d377a72 ("arm64: dts: rockchip: add core dtsi file for RK3328 SoCs")
Signed-off
supported display modes.
Fixes: 0a9d4ac08ebc ("clk: rockchip: set the clock ids for RK3228 VOP")
Fixes: 307a2e9ac524 ("clk: rockchip: add clock controller for rk3228")
Signed-off-by: Jonas Karlman
---
drivers/clk/rockchip/clk-rk3228.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
rk-dw-hdmi-v1/
Alex Bee (1):
drm/rockchip: vop: Allow 4096px width scaling
Douglas Anderson (2):
drm/rockchip: dw_hdmi: Set cur_ctr to 0 always
drm/rockchip: dw_hdmi: Use auto-generated tables
Jonas Karlman (8):
arm64: dts: rockchip: Increase VOP clk rate on RK3328
clk: rockchip: Set p
Use the passed mode instead of mixing use of passed mode and the stored
previous_mode. The passed mode is currenly always the previous_mode.
Also fix a small type and add a variable to help shorten a code line.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9
With CEC phys addr invalidation moved away from the irq handler there is
no longer a need for cec_notifier_mutex, remove it.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/gpu/drm
.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 33 ++-
1 file changed, 2 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 9f2bc932c371..34bc6f4754b8 100644
Update successfully read EDID during hotplug processing to ensure the
connector diplay_info is always up-to-date.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw
With the use of adjusted_mode directly from the crtc_state there is no
longer a need to store a copy in previous_mode, remove it and the now
unneeded mode_set ops.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 19 +--
1 file changed, 1 insertion
Wait until the connector detect ops is called to invalidate CEC phys
addr instead of doing it directly from the irq handler.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers
Fold the poweron and setup functions into one function and use the
adjusted_mode directly from the new crtc_state to remove the need of
storing previous_mode.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 21 -
1 file changed, 8 insertions
struct member and related define.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 32 ---
1 file changed, 5 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index
that add HDMI 2.0 4K@60Hz support to RK3228, RK3328,
RK3399 and RK3568.
Rockchip use the dw-hdmi connector so this should also be validated with
a driver that use the bridge connector.
Jonas Karlman (8):
drm: bridge: dw_hdmi: Call poweron/poweroff from atomic enable/disable
drm: bridge
On 2024-04-14 20:41, Johan Jonker wrote:
> On 4/14/24 17:11, Jonas Karlman wrote:
>> The rockchip,dw-hdmi node can be used as a sound dai codec, however,
>> dtbs_check may report the following issue:
>>
>> hdmi@fe0a: Unevaluated properties are not allowed
-hdmi.yaml#
Add a reference to dai-common.yaml and add the #sound-dai-cells prop to
resolve this warning.
Signed-off-by: Jonas Karlman
---
v2: New patch to fix #sound-dai-cells warning
---
.../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 4
1 file changed, 4 insertions(+)
dif
Hi Manuel,
On 2024-01-03 14:40, Manuel Traut wrote:
> Hi Jonas and Ondřej,
>
+&sfc {
+ pinctrl-names = "default";
+ pinctrl-0 = <&fspi_dual_io_pins>;
+ status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ flash@0 {
+ compati
Hi Manuel and Ondřej,
On 2024-01-02 19:07, Ondřej Jirman wrote:
> Hello Manuel,
[...]
>> +
>> +&sfc {
>> +pinctrl-names = "default";
>> +pinctrl-0 = <&fspi_dual_io_pins>;
>> +status = "okay";
>> +#address-cells = <1>;
>> +#size-cells = <0>;
>> +
>> +flash@0 {
>> +
Hi Manuel,
On 2023-12-23 16:20, Manuel Traut wrote:
> From: Alexander Warnecke
>
> This includes support for both the v0.1 units that were sent to developers and
> the v2.0 units from production.
>
> v1.0 is not included as no units are known to exist.
>
> Working/Tested:
> - SDMMC
> - UART
>
On 2023-11-14 12:28, Andy Yan wrote:
> From: Andy Yan
>
> VOP2 on rk3588:
>
> Four video ports:
> VP0 Max 4096x2160
> VP1 Max 4096x2160
> VP2 Max 4096x2160
> VP3 Max 2048x1080
>
> 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support
> 4 4K Esmart windows with line RGB/YUV support
>
Hi Chris,
On 2023-10-26 22:02, Christopher Obbard wrote:
> Hi Jonas,
>
> On Thu, 2023-10-26 at 19:14 +0000, Jonas Karlman wrote:
>> Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328
>> and RK3399 result in wrong colors being displayed.
>>
>>
VOP
full framework (IP version 3.x) compared to VOP little framework (2.x).
Fix colors by applying different rb swap for VOP full framework (3.x)
and VOP little framework (2.x) similar to vendor 4.4 kernel.
Fixes: 85a359f25388 ("drm/rockchip: Add BGR formats to VOP")
Signed-off-by: Jon
://gitlab.freedesktop.org/mesa/drm/-/merge_requests/329
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 5 +
drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 2 ++
2 files changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
b/drivers/gpu
On 2023-10-24 14:41, Andy Yan wrote:
> Hi:
>
> On 10/24/23 16:49, Christopher Obbard wrote:
>> Hi Jonas,
>>
>> On Mon, 2023-10-23 at 21:11 +, Jonas Karlman wrote:
>>> Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328
>>> and
Hi Chris,
On 2023-10-23 19:52, Christopher Obbard wrote:
> Hi Jonas,
>
> On Mon, 2023-10-23 at 17:37 +0000, Jonas Karlman wrote:
>> This series add support for displaying 10-bit 4:2:0 and 4:2:2 formats
>> produced
>> by the Rockchip Video Decoder on RK322X, RK3288
VOP
full (major = 3).
Fix colors by applying rb swap similar to vendor 4.4 kernel.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu
= 4 * 10 bits = 40 bits = 5 bytes
The '20' and '30' suffix refers to the optimum effective bits per pixel
which is achieved when the total number of luminance samples is a multiple
of 4.
V2: Added NV30 format
Signed-off-by: Jonas Karlman
Reviewed-by: Sandy Huang
---
drivers/
available at [1] and libdrm/modetest patch at [2].
[1] https://github.com/Kwiboo/linux-rockchip/commits/v6.6-rc7-vop-nv15
[2] https://github.com/Kwiboo/libdrm/commits/nv15
Jonas Karlman (2):
drm/fourcc: Add NV20 and NV30 YUV formats
drm/rockchip: vop: Add NV15, NV20 and NV30 support
drivers/gpu/drm
RK3328/RK3399 win0/1 data to not affect RK3368
V2: Added NV30 support
Signed-off-by: Jonas Karlman
Reviewed-by: Sandy Huang
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 36 ---
drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 +
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 66
Hi Andy,
On 2023-10-13 14:21, Andy Yan wrote:
> From: Andy Yan
>
> Add the missing 10 bit RGB format for cluster window.
> The cluster windows on rk3568/6 only support afbc format,
> so change the linear yuv format NV12/16/24 to non-Linear
> YUV420_8BIT/YUV420_10BIT/YUYV/Y210.
>
> Add NV15 for
/20230618220122.3911297-1-jo...@kwiboo.se/
Regards,
Jonas
On 2023-06-22 00:33, Jonas Karlman wrote:
> This series fixes a reset of state in duplicate state crtc funcs for VOP
> driver, a possible crash and ensure crtc reset helper is called in VOP2
> driver.
>
> Patch 1 use kme
Add missing call to crtc reset helper to properly vblank reset.
Also move vop2_crtc_reset and call vop2_crtc_destroy_state to simplify
and remove duplicated code.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Jonas Karlman
---
v2:
- Add check for allocati
ere too.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Jonas Karlman
Reviewed-by: Sascha Hauer
---
v2:
- Collect r-b tag
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rockch
) for reset.")
Signed-off-by: Jonas Karlman
---
v2:
- New patch
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 25c873d4ff53..23
onfig")
Signed-off-by: Jonas Karlman
Reviewed-by: Sascha Hauer
---
v2:
- Collect r-b tag
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip/rockchip_drm_v
vop_plane_destroy and vop_crtc_destroy are plain wrappers around
drm_plane_cleanup and drm_crtc_cleanup. Use them directly as plane and
crtc funcs to closer match VOP2 driver.
Signed-off-by: Jonas Karlman
Reviewed-by: Sascha Hauer
---
v2:
- Collect r-b tag
drivers/gpu/drm/rockchip
failure in crtc reset funcs
- Collect r-b tags
This series is also available at [1].
[1]
https://github.com/Kwiboo/linux-rockchip/commits/next-20230621-duplicate-state
Jonas Karlman (5):
drm/rockchip: vop: Fix reset of state in duplicate state crtc funcs
drm/rockchip: vop: Use cleanup helper
On 2023-06-21 10:11, Sascha Hauer wrote:
> On Tue, Jun 20, 2023 at 06:47:39AM +0000, Jonas Karlman wrote:
>> Add missing call to crtc reset helper to properly vblank reset.
>>
>> Also move vop2_crtc_reset and call vop2_crtc_destroy_state to simplify
>> and remove d
Hi Thomas,
On 2023-06-20 14:03, Thomas Zimmermann wrote:
> Remove the dependency on the GEM DMA helper library. Rockchip comes
> with its own implementation of the GEM interface. It only uses the VM
> callbacks in drm_gem_dma_vm_ops from the GEM DMA helpers. These are
> not DMA specific.
>
> Dupl
Add missing call to crtc reset helper to properly vblank reset.
Also move vop2_crtc_reset and call vop2_crtc_destroy_state to simplify
and remove duplicated code.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/rockchip_
vop_plane_destroy and vop_crtc_destroy are plain wrappers around
drm_plane_cleanup and drm_crtc_cleanup. Use them directly as plane and
crtc funcs to closer match VOP2 driver.
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 16 +++-
1 file changed, 3
ere too.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
b/drivers/gpu/drm/rockchip/
onfig")
Signed-off-by: Jonas Karlman
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index a530ecc4d207..60b23636a3fe 100644
--- a/d
-20230619-duplicate-state
Jonas Karlman (4):
drm/rockchip: vop: Fix crtc duplicate state
drm/rockchip: vop: User cleanup helpers directly as destroy ops
drm/rockchip: vop2: Don't crash for invalid duplicate_state
drm/rockchip: vop2: Add missing call to crtc reset helper
drivers/gp
= 4 * 10 bits = 40 bits = 5 bytes
The '20' and '30' suffix refers to the optimum effective bits per pixel
which is achieved when the total number of luminance samples is a multiple
of 4.
V2: Added NV30 format
Signed-off-by: Jonas Karlman
Reviewed-by: Sandy Huang
---
drivers/
Add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by
the Rockchip Video Decoder on RK322X, RK3288, RK3328 and RK3399.
Also add support for 10-bit 4:4:4 format while at it.
V4: Rework RK3328/RK3399 win0/1 data to not affect RK3368
V2: Added NV30 support
Signed-off-by: Jonas
, rebased on next-20230616
- R-B tags was collected
Changes in v2:
- Add NV30 format
- R-B tags was not collected due to NV30 changes
This series is also available at [1].
[1] https://github.com/Kwiboo/linux-rockchip/commits/next-20230616-vop-nv15
Jonas Karlman (2):
drm/fourcc: Add NV20 and
= 4 * 10 bits = 40 bits = 5 bytes
The '20' and '30' suffix refers to the optimum effective bits per pixel
which is achieved when the total number of luminance samples is a multiple
of 4.
V2: Added NV30 format
Signed-off-by: Jonas Karlman
Reviewed-by: Sandy Huang
---
drivers/
Add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by the
Rockchip Video Decoder on RK322X, RK3288, RK3328, RK3368 and RK3399.
Also add support for 10-bit 4:4:4 format while at it.
V2: Added NV30 support
Signed-off-by: Jonas Karlman
Reviewed-by: Sandy Huang
---
drivers/gpu/drm
/commits/next-20230616-vop-nv15
Jonas Karlman (2):
drm/fourcc: Add NV20 and NV30 YUV formats
drm/rockchip: vop: Add NV15, NV20 and NV30 support
drivers/gpu/drm/drm_fourcc.c| 8 ++
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 29 +--
drivers/gpu/drm/rockchip
Hi Sascha,
On 2023-02-07 13:51, Sascha Hauer wrote:
> On Tue, Feb 07, 2023 at 11:01:26AM +0000, Jonas Karlman wrote:
>> Hi Sascha,
>>
>> On 2023-02-07 09:44, Sascha Hauer wrote:
>>> The Rockchip PLL drivers are currently table based and support only
>>> t
Hi Sascha,
On 2023-02-07 09:44, Sascha Hauer wrote:
> The Rockchip PLL drivers are currently table based and support only
> the most common pixelclocks. Discard all modes we cannot achieve
> at all. Normally the desired pixelclocks have an exact match in the
> PLL driver, nevertheless allow for a
1 - 100 of 191 matches
Mail list logo
