Re: [PATCH 1/7] drm/tidss: Fix issue in irq handling causing irq-flood issue

2024-10-21 Thread Jon Cormier
On Mon, Oct 21, 2024 at 10:08 AM Tomi Valkeinen wrote: > > It has been observed that sometimes DSS will trigger an interrupt and > the top level interrupt (DISPC_IRQSTATUS) is not zero, but the VP and > VID level interrupt-statuses are zero. > > As the top level irqstatus is supposed to tell wheth

Re: [PATCH 1/7] drm/tidss: Fix issue in irq handling causing irq-flood issue

2024-10-21 Thread Jon Cormier
On Mon, Oct 21, 2024 at 10:08 AM Tomi Valkeinen < tomi.valkei...@ideasonboard.com> wrote: > It has been observed that sometimes DSS will trigger an interrupt and > the top level interrupt (DISPC_IRQSTATUS) is not zero, but the VP and > VID level interrupt-statuses are zero. > > As the top level ir

Re: [PATCH 6/7] drm/tidss: Fix race condition while handling interrupt registers

2024-10-21 Thread Jon Cormier
On Mon, Oct 21, 2024 at 10:08 AM Tomi Valkeinen wrote: > > From: Devarsh Thakkar > > The driver has a spinlock for protecting the irq_masks field and irq > enable registers. However, the driver misses protecting the irq status > registers which can lead to races. > > Take the spinlock when access

Re: [PATCH 5/7] drm/tidss: Clear the interrupt status for interrupts being disabled

2024-10-21 Thread Jon Cormier
On Mon, Oct 21, 2024 at 10:08 AM Tomi Valkeinen wrote: > > From: Devarsh Thakkar > > The driver does not touch the irqstatus register when it is disabling > interrupts. This might cause an interrupt to trigger for an interrupt > that was just disabled. > > To fix the issue, clear the irqstatus r

Re: [PATCH 1/2] drm/tidss: Clear the interrupt status for interrupts being disabled

2024-10-21 Thread Jon Cormier
Ah okay, go figure. There was an updated patch series emailed between before I finished writing this email. So please ignore... On Mon, Oct 21, 2024 at 10:46 AM Jon Cormier wrote: > > Adding the e2e thread that has instigated this change. > > https://e2e.ti.com/support/proc

Re: [PATCH 1/2] drm/tidss: Clear the interrupt status for interrupts being disabled

2024-10-21 Thread Jon Cormier
Adding the e2e thread that has instigated this change. https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1394222/am625-issue-about-tidss-rcu_preempt-self-detected-stall-on-cpu?pifragment-323307=1#pifragment-323307=2 Summary of original problem: An AM62x device using the TI

Re: [PATCH v3 2/3] drm/bridge: tfp410: Fix logic to configured polled HPD

2023-04-04 Thread Jon Cormier
On Fri, Mar 31, 2023 at 5:00 AM Neil Armstrong wrote: > > Hi, > > On 20/02/2023 23:10, Jonathan Cormier wrote: > > From: Michael Williamson > > > > The logic to configure polling (vs async/irq notification) of hot-plug > > events was not correct. If the connected bridge requires polling, > > the

Re: [PATCH v3 0/3] drm/bridge: tfp410: Add i2c support

2023-03-30 Thread Jon Cormier
Bumping patch submission. On Mon, Feb 20, 2023 at 5:10 PM Jonathan Cormier wrote: > The TFP410 driver does not support I2C. As such, the device remains in > Power Down if the I2C is enabled by the bootstrap pins. > > Add basic support for the I2C interface, and provide support to take > the dev

Re: [PATCH 4/4] DRM: BRIDGE: TFP410: If connected, use I2C for polled HPD status.

2023-01-30 Thread Jon Cormier
On Sat, Jan 28, 2023 at 7:47 PM kernel test robot wrote: > > Hi Jonathan, > > Thank you for the patch! Perhaps something to improve: Good bot. > > [auto build test WARNING on 93f875a8526a291005e7f38478079526c843cbec] > > url: > https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cormier/dt

Re: [PATCH 2/4] DRM: BRIDGE: TFP410: Support basic I2C interface

2023-01-26 Thread Jon Cormier
On Thu, Jan 26, 2023 at 10:41 AM Krzysztof Kozlowski < krzysztof.kozlow...@linaro.org> wrote: > On 25/01/2023 22:09, Jonathan Cormier wrote: > > From: Michael Williamson > > > > The TFP410 driver does not support I2C. As such, the device remains in > > Power Down if the I2C is enabled by the boo

Re: [PATCH 1/4] dt-bindings: display: bridge: tfp410: Add tfp410 i2c example

2023-01-26 Thread Jon Cormier
On Thu, Jan 26, 2023 at 10:40 AM Krzysztof Kozlowski < krzysztof.kozlow...@linaro.org> wrote: > On 25/01/2023 22:09, Jonathan Cormier wrote: > > Add a i2c example with HDMI connector > > Why? It's the same - but more on this below. > The existing example is for the previous setup where it was conf

Re: [PATCH 1/4] dt-bindings: display: bridge: tfp410: Add tfp410 i2c example

2023-01-25 Thread Jon Cormier
On Wed, Jan 25, 2023 at 4:24 PM Laurent Pinchart wrote: > > Hi Jonathan, > > Thank you for the patch. > > On Wed, Jan 25, 2023 at 04:09:09PM -0500, Jonathan Cormier wrote: > > Add a i2c example with HDMI connector > > > > Signed-off-by: Jonathan Cormier > > --- > > .../bindings/display/bridge/ti