Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Jeff Johnson
On 12/10/2024 2:02 PM, Easwar Hariharan wrote: > This is a series that follows up on my previous series to introduce > secs_to_jiffies() and convert a few initial users.[1] In the review for > that series, Anna-Maria requested converting other users with > Coccinelle. [2] This is part 1 that conver

Re: [PATCH v2 15/21] wifi: ath11k: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Jeff Johnson
ies(C) > > Signed-off-by: Easwar Hariharan Acked-by: Jeff Johnson > --- > drivers/net/wireless/ath/ath11k/debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath11k/debugfs.c > b/drivers/net/wireless/ath/ath11k/debu

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-11-15 Thread Jeff Johnson
On 11/15/2024 1:29 PM, Easwar Hariharan wrote: > On 11/15/2024 1:26 PM, Easwar Hariharan wrote: >> This is a series that follows up on my previous series to introduce >> secs_to_jiffies() and convert a few initial users.[1] In the review for >> that series, Anna-Maria requested converting other use

Re: [PATCH 22/22] jiffies: Define secs_to_jiffies()

2024-11-15 Thread Jeff Johnson
On 11/15/2024 1:22 PM, Easwar Hariharan wrote: > secs_to_jiffies() is defined in hci_event.c and cannot be reused by > other call sites. Hoist it into the core code to allow conversion of the > ~1150 usages of msecs_to_jiffies() that either: > > - use a multiplier value of 1000 or equivalently MS

Re: [PATCH 1/5] perf: Add dummy pmu module

2024-10-14 Thread Jeff Johnson
On 10/8/24 11:34, Lucas De Marchi wrote: ... > +module_init(dummy_init); > +module_exit(dummy_exit); > + > +MODULE_AUTHOR("Lucas De Marchi "); > +MODULE_LICENSE("GPL"); Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing"), a module without a MODULE_DESCRIPT

Re: [PATCH v2 3/4] drm/ttm/tests: Fix memory leak in ttm_tt_simple_create()

2024-10-14 Thread Jeff Johnson
On 10/14/2024 5:52 AM, Jinjie Ruan wrote: > modprobe ttm_device_test and then rmmod ttm_device_test, the fllowing nit: s/fllowing/following/ > memory leaks occurs:

Re: [PATCH v6 03/44] drm/vkms: Add kunit tests for VKMS LUT handling

2024-10-08 Thread Jeff Johnson
On 10/3/24 13:00, Harry Wentland wrote: > Debugging LUT math is much easier when we can unit test ... > diff --git a/drivers/gpu/drm/vkms/tests/vkms_color_test.c > b/drivers/gpu/drm/vkms/tests/vkms_color_test.c > new file mode 100644 > index ..efe139978860 > --- /dev/null > +++ b/drive

Re: [PATCH v5 20/44] drm/tests: Add a few tests around drm_fixed.h

2024-08-20 Thread Jeff Johnson
On 8/19/24 13:56, Harry Wentland wrote: > While working on the CTM implementation of VKMS I had to ascertain > myself of a few assumptions. One of those is whether drm_fixed.h > treats its numbers using signed-magnitude or twos-complement. It is > twos-complement. > > In order to make someone else

Re: [PATCH v5 03/44] drm/vkms: Add kunit tests for VKMS LUT handling

2024-08-20 Thread Jeff Johnson
On 8/19/24 13:56, Harry Wentland wrote: > Debugging LUT math is much easier when we can unit test > it. Add kunit functionality to VKMS and add tests for > - get_lut_index > - lerp_u16 > > v5: > - Bring back static for lerp_u16 and get_lut_index (Arthur) > > v4: > - Test the critical points o

Re: [PATCH v9 15/17] drm/vkms: Create KUnit tests for YUV conversions

2024-08-05 Thread Jeff Johnson
On 8/2/24 09:10, Louis Chauvet wrote: From: Arthur Grillo Create KUnit tests to test the conversion between YUV and RGB. Test each conversion and range combination with some common colors. The code used to compute the expected result can be found in comment. [Louis Chauvet: - fix minor format

Re: [PATCH] agp: uninorth: add missing MODULE_DESCRIPTION() macro

2024-07-11 Thread Jeff Johnson
On 6/28/24 20:14, Jeff Johnson wrote: On 6/15/2024 2:01 PM, Jeff Johnson wrote: With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/uninorth-agp.o Add the missing invocation of the MODULE_DESCRIPTION() macro.

Re: [PATCH v2 1/3] drm: Add panel backlight quirks

2024-06-28 Thread Jeff Johnson
On 6/23/24 01:51, Thomas Weißschuh wrote: Panels using a PWM-controlled backlight source without an do not have a standard way to communicate their valid PWM ranges. On x86 the ranges are read from ACPI through driver-specific tables. The built-in ranges are not necessarily correct, or may grow s

Re: [PATCH] agp: uninorth: add missing MODULE_DESCRIPTION() macro

2024-06-28 Thread Jeff Johnson
On 6/15/2024 2:01 PM, Jeff Johnson wrote: > With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/char/agp/uninorth-agp.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > >

[PATCH v2] drm/ttm/tests: add missing MODULE_DESCRIPTION() macros

2024-06-24 Thread Jeff Johnson
tm/tests/ttm_bo_validate_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_mock_manager.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff

Re: [PATCH] drm/ttm/tests: add missing MODULE_DESCRIPTION() macros

2024-06-24 Thread Jeff Johnson
On 6/9/2024 9:34 AM, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/ttm/tests/ttm_device_test.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/ttm/tests/tt

Re: [PATCH] agp: add missing MODULE_DESCRIPTION() macros

2024-06-23 Thread Jeff Johnson
On 6/3/2024 9:55 AM, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/amd64-agp.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/intel-agp.o > WARNING: modpost: missin

[PATCH] tty: vt: add missing MODULE_DESCRIPTION() macros

2024-06-21 Thread Jeff Johnson
although they did not produce a warning with the i386 allmodconfig configuration, may cause this warning with other configurations. Signed-off-by: Jeff Johnson --- drivers/video/console/mdacon.c | 1 + drivers/video/console/newport_con.c | 1 + drivers/video/console/sticon.c | 1 + drive

[PATCH] agp: add remaining missing MODULE_DESCRIPTION() macros

2024-06-21 Thread Jeff Johnson
() macro to all files which have a MODULE_LICENSE(). This includes alpha-agp.c and parisc-agp.c which, although they did not produce a warning with the i386 allmodconfig configuration, may cause this warning with other configurations. Signed-off-by: Jeff Johnson --- drivers/char/agp/ali-agp.c

[PATCH] drm/tests: add drm_hdmi_state_helper_test MODULE_DESCRIPTION()

2024-06-19 Thread Jeff Johnson
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/tests/drm_hdmi_state_helper_test.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Fixes: eb66d34d793e ("drm/tests: Add output bpc tests") Signed-of

Re: [PATCH 2/2] drm/nouveau/nvkm: separate out into nvkm.ko

2024-06-19 Thread Jeff Johnson
On 6/13/24 10:02, Ben Skeggs wrote: Signed-off-by: Ben Skeggs ... + +MODULE_LICENSE("GPL and additional rights"); +module_init(nvkm_init); +module_exit(nvkm_exit); missing MODULE_DESCRIPTION() which will cause a warning with make W=1

[PATCH] fbdev: amifb: add missing MODULE_DESCRIPTION() macro

2024-06-17 Thread Jeff Johnson
With ARCH=m68k, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/amifb.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/video/fbdev/amifb.c | 1 + 1 file changed, 1 i

[PATCH] fbdev: c2p_planar: add missing MODULE_DESCRIPTION() macro

2024-06-17 Thread Jeff Johnson
With ARCH=m68k, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/c2p_planar.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/video/fbdev/c2p_planar.c | 1 + 1 file ch

[PATCH] agp: uninorth: add missing MODULE_DESCRIPTION() macro

2024-06-15 Thread Jeff Johnson
With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/uninorth-agp.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/char/agp/uninorth-agp.c | 1 + 1 file

[PATCH] fbdev: offb: add missing MODULE_DESCRIPTION() macro

2024-06-14 Thread Jeff Johnson
With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/offb.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/video/fbdev/offb.c | 1 + 1 file changed, 1 i

[PATCH] fbdev: vfb: add missing MODULE_DESCRIPTION() macro

2024-06-12 Thread Jeff Johnson
With ARCH=x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/vfb.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/video/fbdev/vfb.c | 1 + 1 file changed, 1 i

[PATCH] video: macmodes: add missing MODULE_DESCRIPTION() macro

2024-06-12 Thread Jeff Johnson
With ARCH=x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/macmodes.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/video/fbdev/macmodes.c | 1 + 1 file ch

[PATCH] fbdev: goldfishfb: add missing MODULE_DESCRIPTION() macro

2024-06-12 Thread Jeff Johnson
With ARCH=arm64, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/goldfishfb.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/video/fbdev/goldfishfb.c | 1 + 1 file

[PATCH] fbdev: kyro: add missing MODULE_DESCRIPTION() macro

2024-06-12 Thread Jeff Johnson
With ARCH=x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/kyro/kyrofb.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/video/fbdev/kyro/fbdev.c | 1 + 1 file ch

[PATCH] fbdev: viafb: add missing MODULE_DESCRIPTION() macro

2024-06-12 Thread Jeff Johnson
With ARCH=x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/via/viafb.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- Description derived from the Kconfig entry ---

[PATCH] fbdev: matroxfb: add missing MODULE_DESCRIPTION() macros

2024-06-12 Thread Jeff Johnson
CRIPTION() in drivers/video/fbdev/matrox/matroxfb_Ti3026.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- Corrections to these descriptions are welcomed. While doing these cleanups treewide, in most cases I've taken these descriptions direc

[PATCH] backlight: add missing MODULE_DESCRIPTION() macros

2024-06-12 Thread Jeff Johnson
CRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/video/backlight/platform_lcd.c | 1 + drivers/video/backlight/rt4831-backlight.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c index 7687

Re: [PATCH v2] drm: add missing MODULE_DESCRIPTION() macros

2024-06-11 Thread Jeff Johnson
On 6/11/2024 6:56 AM, Jeff Johnson wrote: > On x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/gud/gud.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/drm_panel_orientation_quirks.

[PATCH v2] drm: add missing MODULE_DESCRIPTION() macros

2024-06-11 Thread Jeff Johnson
E() even though it isn't built as a separate module -- it is always built as part of drm_kms_helper and drm_kms_helper_common.c already provides a MODULE_DESCRIPTION for that module. Signed-off-by: Jeff Johnson --- This is the last in a set of patches to drivers/gpu/drm. The preceeding patch

Re: [PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-06-11 Thread Jeff Johnson
); #endif +MODULE_DESCRIPTION("MIPI Display Bus Interface (DBI) LCD controller support"); MODULE_LICENSE("GPL"); I'll remove this from my series Reviewed-by: Jeff Johnson

Re: [PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-06-11 Thread Jeff Johnson
On 6/11/2024 6:34 AM, Andy Shevchenko wrote: > On Wed, Jun 05, 2024 at 11:38:31PM +0300, Andy Shevchenko wrote: >> On Thu, Apr 25, 2024 at 03:56:26PM +0300, Andy Shevchenko wrote: >>> The modpost script is not happy >>> >>> WARNING: modpost: missing MODULE_DESCRIPTION() in >>> drivers/gpu/drm/dr

[PATCH] drm: add missing MODULE_DESCRIPTION() macros

2024-06-09 Thread Jeff Johnson
includes drivers/gpu/drm/drm_simple_kms_helper.c since it contains a MODULE_LICENSE() even though it isn't built as a separate module -- it is always built as part of drm_kms_helper and drm_kms_helper_common.c already provides a MODULE_DESCRIPTION for that module. Signed-off-by: Jeff Johnson

[PATCH] drm/tiny: add missing MODULE_DESCRIPTION() macros

2024-06-09 Thread Jeff Johnson
Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/gpu/drm/tiny/bochs.c| 1 + drivers/gpu/drm/tiny/cirrus.c | 1 + drivers/gpu/drm/tiny/gm12u320.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers

[PATCH] drm/bridge: add missing MODULE_DESCRIPTION() macros

2024-06-09 Thread Jeff Johnson
/gpu/drm/bridge/sil-sii8620.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/bridge/sii9234.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/gpu/drm/bridge/lontium-lt9611.c| 1 + drivers/gpu/drm/bridge/lontium-lt9611u

[PATCH] drm/panel: add missing MODULE_DESCRIPTION() macros

2024-06-09 Thread Jeff Johnson
/gpu/drm/panel/panel-orisetech-ota5601a.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 1 + drivers/gpu/drm/panel/panel-auo-a030jtn01.c | 1 + drivers/gpu/drm/panel/panel-innolux-ej030na.

[PATCH] drm/ttm/tests: add missing MODULE_DESCRIPTION() macros

2024-06-09 Thread Jeff Johnson
tm/tests/ttm_kunit_helpers.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 1 + drivers/gpu/drm/ttm/tests/ttm_device_test.c | 1 + drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 1 + drivers/gpu/drm/t

[PATCH] staging: fbtft: add missing MODULE_DESCRIPTION() macro

2024-06-08 Thread Jeff Johnson
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/staging/fbtft/fbtft.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/staging/fbtft/fbtft-core.c | 1 + 1 file changed, 1 i

[PATCH] drm/tests: add missing MODULE_DESCRIPTION() macros

2024-06-06 Thread Jeff Johnson
ION() in drivers/gpu/drm/tests/drm_rect_test.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- Most, but not all, of these descriptions came from header comments at the beginning of the .c files, but some of them I "invented". Let me kn

Re: [PATCH v2 11/22] ath10k: Use iommu_paging_domain_alloc()

2024-06-04 Thread Jeff Johnson
+ath10k list for viibility On 6/3/24 18:51, Lu Baolu wrote: An iommu domain is allocated in ath10k_fw_init() and is attached to ar_snoc->fw.dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/net/wireless/ath/ath10k/snoc.c | 6 ++

Re: [PATCH v2 11/22] ath10k: Use iommu_paging_domain_alloc()

2024-06-04 Thread Jeff Johnson
in git history, subject prefix should now be "wifi: ath10k: " with that addressed, Acked-by: Jeff Johnson

Re: [PATCH v2 12/22] wifi: ath11k: Use iommu_paging_domain_alloc()

2024-06-04 Thread Jeff Johnson
On 6/3/24 18:51, Lu Baolu wrote: An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is attached to ab_ahb->fw.dev in the same function. Use iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu Acked-by: Jeff Johnson --- drivers/net/wireless/

[PATCH] agp: add missing MODULE_DESCRIPTION() macros

2024-06-03 Thread Jeff Johnson
modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/sis-agp.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/via-agp.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson --- drivers/char/agp/amd64-agp.c | 1 + drivers/char/agp/int

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-23 Thread Jeff Johnson
On 2/23/2024 9:56 AM, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.9 and submit it then. Hoping >to keep the conflicts that it will cause to a minimum. >

[PATCH] accel/qaic: Constify aic100_channels

2024-02-22 Thread Jeff Johnson
MHI allows the channel configs to be const, so constify aic100_channels to prevent runtime modification. Signed-off-by: Jeff Johnson --- drivers/accel/qaic/mhi_controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/qaic/mhi_controller.c b/drivers/accel

Re: [V11 3/8] wifi: mac80211: Add support for WBRF features

2023-09-01 Thread Jeff Johnson
On 8/30/2023 11:20 PM, Evan Quan wrote: To support the WBRF mechanism, Wifi adapters utilized in the system must Since this is the first mention of WBRF in the core wireless code IMO you should indicate what this is an acronym for and briefly describe it (or add a lore link). I'm wondering i

Re: [PATCH V8 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-08-10 Thread Jeff Johnson
On 8/10/2023 12:37 AM, Evan Quan wrote: The newly added WBRF feature needs this interface for channel width calculation. Signed-off-by: Evan Quan --- include/net/cfg80211.h | 8 net/wireless/chan.c| 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/n

Re: [PATCH v2 5/7] drm/msm/dp: Implement hpd_notify()

2022-09-16 Thread Jeff Johnson
On 9/16/2022 1:00 PM, Bjorn Andersson wrote: From: Bjorn Andersson The DisplayPort controller's hot-plug mechanism is based on pinmuxing a physical signal no a GPIO pin into the controller. This is not always nit: s/ no / on /? possible, either because there aren't dedicated GPIOs available