mit.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-only
>
> #include
> +#include
> #include
> #include
> #include
Reviewed-by: Janne Grunau
On Wed, Jun 11, 2025 at 07:32:17PM +0200, Sasha Finkelstein via B4 Relay wrote:
> From: Sasha Finkelstein
>
> Add device tree entries for GPUs in M-series SoCs
>
> Signed-off-by: Sasha Finkelstein
> ---
> arch/arm64/boot/dts/apple/t6000.dtsi| 4
> arch/arm64/boot/dts/apple/t6001.
On Wed, Jun 11, 2025 at 09:12:35PM +0200, Sven Peter wrote:
> Hi,
>
> On 11.06.25 19:32, Sasha Finkelstein via B4 Relay wrote:
> > From: Sasha Finkelstein
> >
> > Add device tree entries for GPUs in M-series SoCs
> >
> > Signed-off-by: Sasha Finkelstein
> > ---
> > arch/arm64/boot/dts/apple/
From: Janne Grunau
The lock is used in the interrupt handler so use spin_lock_irqsave to
disable interrupts and avoid deadlocks with the irq handler.
Fixes: 332122eba628 ("drm: adp: Add Apple Display Pipe driver")
Reviewed-by: Alyssa Rosenzweig
Signed-off-by: Janne Grunau
---
drive
From: Janne Grunau
Calling drm_crtc_vblank_on() drm_crtc_helper_funcs' atomic_enable is
expected to enable vblank interrupts. It may have been avoided here to
due to drm_crtc_vblank_get()'s error behavior after
drm_crtc_vblank_reset(). With that fixed in the preceding change the
drive
nel.org/r/20250416-drm_adp_fixes-v1-0-772699f13...@jannau.net
---
Janne Grunau (4):
drm: adp: Use spin_lock_irqsave for drm device event_lock
drm: adp: Handle drm_crtc_vblank_get() errors
drm: adp: Enable vblank interrupts in crtc's .atomic_enable
drm: adp: Remove
From: Janne Grunau
drm_crtc_vblank_get() may fail when it's called before
drm_crtc_vblank_on() on a resetted CRTC. This occurs in
drm_crtc_helper_funcs' atomic_flush() calls after
drm_atomic_helper_crtc_reset() for example directly after probe.
Send the vblank event directly in
From: Janne Grunau
Interrupt handlers run with interrupts disabled so it is not necessary
to protect them against reentrancy.
Reviewed-by: Alyssa Rosenzweig
Signed-off-by: Janne Grunau
---
drivers/gpu/drm/adp/adp_drv.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm
On Wed, Apr 16, 2025 at 04:58:18PM -0400, Alyssa Rosenzweig wrote:
> > - spin_lock_irqsave(&crtc->dev->event_lock, flags);
> > if (crtc->state->event) {
> > - drm_crtc_vblank_get(crtc);
> > - adp->event = crtc->state->event;
> > + spin_lock_irqsave(&crtc->dev->ev
On Wed, Apr 16, 2025 at 04:54:38PM -0400, Alyssa Rosenzweig wrote:
> > This is preferable to driver changes since keeps the device powered on
> > if the adpdrm module is not available during boot.
>
> Struggling to parse this sentence, do you mean to say:
>
> > Driver changes are preferred, since
/asahi/20250416-arm64_dts_apple_touchbar-v1-1-e1c0b53b9...@jannau.net/
---
Janne Grunau (4):
drm: adp: Use spin_lock_irqsave for drm device event_lock
drm: adp: Handle drm_crtc_vblank_get() errors
drm: adp: Enable vblank interrupts in crtc's .atomic_enable
drm: adp: Rem
From: Janne Grunau
drm_crtc_vblank_get() may fail when it's called before
drm_crtc_vblank_on() on a resetted CRTC. This occurs in
drm_crtc_helper_funcs' atomic_flush() calls after
drm_atomic_helper_crtc_reset() for example directly after probe.
Send the vblank event directly in
From: Janne Grunau
The lock is used in the interrupt handler so use spin_lock_irqsave to
disable interrupts and avoid deadlocks with the irq handler.
Fixes: 332122eba628 ("drm: adp: Add Apple Display Pipe driver")
Signed-off-by: Janne Grunau
---
drivers/gpu/drm/adp/adp_drv.c | 5 +++
From: Janne Grunau
Interrupt handlers run with interrupts disabled so it is not necessary
to protect them against reentrancy.
Signed-off-by: Janne Grunau
---
drivers/gpu/drm/adp/adp_drv.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm
From: Janne Grunau
Calling drm_crtc_vblank_on() drm_crtc_helper_funcs' atomic_enable is
expected to enable vblank interrupts. It may have been avoided here to
due to drm_crtc_vblank_get()'s error behavior after
drm_crtc_vblank_reset(). With that fixed in the preceding change the
drive
Hej,
On Tue, Mar 04, 2025 at 08:12:14PM +0100, Janne Grunau via B4 Relay wrote:
> From: Janne Grunau
>
> Using "depends on" and "select" for the same Kconfig symbol is known to
> cause circular dependencies (cmp. "Kconfig recursive dependency
> limi
atch_add(&pdev->dev, &match, compare_dev, port);
> + drm_of_component_match_add(&pdev->dev, &match, component_compare_of,
> port);
> of_node_put(port);
>
> return component_master_add_with_match(&pdev->dev, &adp_master_ops,
> match);
Reviewied-by: Janne Grunau
thanks,
Janne
On Fri, Mar 28, 2025 at 05:07:05PM +0800, shao.ming...@zte.com.cn wrote:
> From: Tang Dongxing
>
> Replace the open-code with device_match_of_node().
>
> Signed-off-by: Tang Dongxing
> Signed-off-by: Shao Mingyin
> ---
> drivers/gpu/drm/adp/adp_drv.c | 2 +-
> 1 file changed, 1 insertion(+),
num_binds == 1, the bind */
> + struct drm_asahi_gem_bind_op b;
> +
> + /**
> + * @bind.userptr: If num_binds > 1, user pointer to an array of
> + * @num_binds structures of type @drm_asahi_gem_bind_op and size
> + * @stride bytes.
> + */
> + __u64 userptr;
> + } bind;
> +};
...
> +/**
> + * struct drm_asahi_submit - Arguments passed to DRM_IOCTL_ASAHI_SUBMIT
> + */
> +struct drm_asahi_submit {
> + /**
> + * @syncs: An optional array of drm_asahi_sync. First @in_sync_count
> + * in-syncs then @out_sync_count out-syncs.
> + */
> + __u64 syncs;
Would it make sense to explictly state that this is a pointer?
Reviewed-by: Janne Grunau
ciao
Janne
From: Janne Grunau
Using "depends on" and "select" for the same Kconfig symbol is known to
cause circular dependencies (cmp. "Kconfig recursive dependency
limitations" in Documentation/kbuild/kconfig-language.rst.
DRM drivers are selecting
Hej,
On Tue, Feb 18, 2025 at 11:15:54AM -0500, Alyssa Rosenzweig wrote:
> Apple supports a few image layouts across the SoC. To begin, add
> modifiers for the "twiddled" and "twiddled + compressed" layouts. These
> are the two "standard" layouts used on the GPU. Mesa requires these
> modifiers to
0_svc+0x3c/0xe0
[ 22.116181] el0t_64_sync_handler+0x70/0xc0
[ 22.117110] el0t_64_sync+0x190/0x198
[ 22.117931] ---[ end trace ]---
Signed-off-by: Janne Grunau
Fixes: 5a498d4d06d6 ("drm/fbdev-dma: Only install deferred I/O if necessary")
---
drivers/gpu/drm/drm_fb
2 +-
> 3 files changed, 5 insertions(+), 8 deletions(-)
Tested for several hours with CONFIG_PREMPT=y and kasan with a similar
workload as in the github issue without reports or oopses.
Feel free to add
Tested-by: Janne Grunau
thanks,
Janne
Hej Arnd,
On Tue, Jan 23, 2024, at 08:34, Arnd Bergmann wrote:
> On Mon, Jan 22, 2024, at 21:50, Janne Grunau wrote:
>> On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote:
>>>
>>> -int parse_sample_rate_bit(struct dcp_parse_ctx *handle, unsigned int
&g
Hej,
On Mon, Jan 22, 2024, at 17:11, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> Since commit d26270061ae6 ("string: Remove strlcpy()"), the strlcpy()
> function causes a build failure.
>
> Since the return value is ignored, changing it to the strscpy()
> causes no change in behavior but fixes
Hej,
On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> With linux-6.8, the kernel warns about functions that have no
> extern declaration, so mark both of these static.
>
> Fixes: 2d782b0d007d ("gpu: drm: apple: Add sound mode parsing")
> Signed-off-by: Arnd Bergmann
From: Janne Grunau
Multiple power domains need to be handled explicitly in each driver. The
driver core can not handle it automatically since it is not aware of
power sequencing requirements the hardware might have. This is not a
problem for simpledrm since everything is expected to be powered
On 2023-09-11 14:26:10 +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 10.09.23 um 18:39 schrieb Janne Grunau via B4 Relay:
> > From: Janne Grunau
> >
> > Multiple power domains need to be handled explicitly in each driver. The
> > driver core can not handle it au
On 2023-09-10 22:16:05 +0200, Christophe JAILLET wrote:
> Le 10/09/2023 à 18:39, Janne Grunau via B4 Relay a écrit :
> > From: Janne Grunau
> >
> > Multiple power domains need to be handled explicitly in each driver. The
> > driver core can not handle it automatical
On 2023-09-10 18:39:39 +0200, Janne Grunau via B4 Relay wrote:
> From: Janne Grunau
>
> Multiple power domains need to be handled explicitly in each driver. The
> driver core can not handle it automatically since it is not aware of
> power sequencing requirements the hardware migh
From: Janne Grunau
Multiple power domains need to be handled explicitly in each driver. The
driver core can not handle it automatically since it is not aware of
power sequencing requirements the hardware might have. This is not a
problem for simpledrm since everything is expected to be powered
On 2023-07-09 23:25:11 +0300, Dmitry Baryshkov wrote:
> Implement the oob_hotplug_event() callback. Translate it to the HPD
> notification sent to the HPD bridge in the chain.
>
> Signed-off-by: Dmitry Baryshkov
Reviewed-by: Janne Grunau
> ---
> drivers/gpu/drm/drm_bridg
dmi.c will do unnecessary work when called
repeatedly with status connected. Not sure if it is worth adressing
since I don't expect multiple calls with connector_status_connected to
occur for this particular bridge.
Reviewed-By: Janne Grunau
> Signed-off-by: Dmitry Ba
On 2023-04-20 23:07:01 +0300, Dmitry Baryshkov wrote:
> On Thu, 20 Apr 2023 at 23:01, Janne Grunau wrote:
> >
> > On 2023-03-28 10:31:29 +0800, Zongmin Zhou wrote:
> > > When drivers call drm_kms_helper_poll_disable from
> > > their device suspend implementati
drm_device *dev)
> if (dev->mode_config.poll_running)
> drm_kms_helper_disable_hpd(dev);
>
> - cancel_delayed_work_sync(&dev->mode_config.output_poll_work);
> + if (dev->mode_config.poll_enabled)
> + cancel_delayed_work_sync(&
Hej,
adding devicet...@vger.kernel.org and as...@lists.linux.dev to cc:, the
former for the obvious devictree/bindings related questions,
asahi for the prospect of supporting high DPI displays during early boot
and in u-boot.
On 2023-01-18 18:48:17 +, Rayyan Ansari wrote:
> Hello,
> The fol
On 2022-03-31 18:25:05 +0200, Thierry Reding wrote:
> On Fri, Feb 11, 2022 at 12:15:44AM +0100, Janne Grunau wrote:
> > On 2022-02-09 17:31:16 +0100, Thierry Reding wrote:
> > > On Sun, Feb 06, 2022 at 11:27:00PM +0100, Janne Grunau wrote:
> > > > On 2021-09-15 17:19:
On 2022-02-09 17:31:16 +0100, Thierry Reding wrote:
> On Sun, Feb 06, 2022 at 11:27:00PM +0100, Janne Grunau wrote:
> > On 2021-09-15 17:19:39 +0200, Thierry Reding wrote:
> > > On Tue, Sep 07, 2021 at 07:44:44PM +0200, Thierry Reding wrote:
> > > > On Tue, Sep 07,
On 2021-09-15 17:19:39 +0200, Thierry Reding wrote:
> On Tue, Sep 07, 2021 at 07:44:44PM +0200, Thierry Reding wrote:
> > On Tue, Sep 07, 2021 at 10:33:24AM -0500, Rob Herring wrote:
> > > On Fri, Sep 3, 2021 at 10:36 AM Thierry Reding
> > > wrote:
> > > >
> > > > On Fri, Sep 03, 2021 at 09:36:33
39 matches
Mail list logo
