On Wed, Apr 16, 2025 at 04:54:38PM -0400, Alyssa Rosenzweig wrote: > > This is preferable to driver changes since keeps the device powered on > > if the adpdrm module is not available during boot. > > Struggling to parse this sentence, do you mean to say: > > > Driver changes are preferred, since that patch keeps the device > > powered on if the adpdrm module is not available during boot.
no. The sentence misses "it" between "since" and "keeps". I meant to say that the linked devicetree change is preferable. A hypothetical adp_drv.c change to keep the power-domain during s2idle only works if the driver is loaded. The changes in this series (especially Patch 1/4) just prevent the soft-locked CPU after resume. The touch bar display won't display anything. Janne
