On Wed, 14 May 2025, Jani Nikula wrote:
> On Wed, 14 May 2025, Ankit Nautiyal wrote:
>> This reverts commit 584cf613c24a4250d9be4819efc841aa2624d5b6.
>>
>> Some eDP panels support HBR3 but not TPS4 and rely on a fixed mode that
>> requires HBR3. After the original co
intel_dp->sink_rates[i] = rate;
> }
> intel_dp->num_sink_rates = i;
> }
> diff --git a/include/drm/display/drm_dp_helper.h
> b/include/drm/display/drm_dp_helper.h
> index 7b19192c7031..8021e9db67f2 100644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -809,6 +809,14 @@ enum drm_dp_quirk {
>* requires enabling DSC.
>*/
> DP_DPCD_QUIRK_HBLANK_EXPANSION_REQUIRES_DSC,
> +
> + /**
> + * @DP_DPCD_QUIRK_HBR3_WITHOUT_TPS4:
> + *
> + * The device supports HBR3 without TPS4 but is unable to produce
> + * stable output.
> + */
> + DP_DPCD_QUIRK_HBR3_WITHOUT_TPS4,
Ditto.
> };
>
> /**
--
Jani Nikula, Intel
*/
> - if (rate >= 81 &&
> !drm_dp_tps4_supported(intel_dp->dpcd)) {
> - drm_dbg_kms(display->drm,
> - "[ENCODER:%d:%s] Rejecting HBR3 due
> to missing TPS4 supp
snowballed from there.
There has to be a middle ground instead of absolutes. Otherwise we'll
just end up in deeper silos. And more arguments.
BR,
Jani.
--
Jani Nikula, Intel
On Wed, 14 May 2025, "feijuan.li" wrote:
> When DP connected to a device with HDR capability,
> the hdr structure was filled.Then connected to another
> sink device without hdr capability, but the hdr info
> still exist.
>
> Signed-off-by: feijuan.li
Reviewed-by: Jan
ollowing the
> intel_panel? Is it the associated
> touchscreen if any or some other device?
Touchscreen, it's stuff under investigation, WIP. Needs a bunch more
stuff, but just trying to ensure drm_panel doesn't become a blocker
right off the bat.
BR,
Jani.
--
Jani Nikula, Intel
@ static void update_display_info(struct drm_connector
> *connector,
> struct drm_display_info *info = &connector->display_info;
> const struct edid *edid;
>
> + drm_reset_hdr_sink_metadata(connector);
> drm_reset_display_info(connector);
> clear_eld(connector);
>
> --
> 2.25.1
>
>
--
Jani Nikula, Intel
On Thu, 08 May 2025, Anusha Srivatsa wrote:
> On Thu, May 8, 2025 at 10:27 AM Jani Nikula
> wrote:
>
>> On Mon, 05 May 2025, Anusha Srivatsa wrote:
>> > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote:
>> >
>> >> Hi Jani,
>> >>
&g
5/gt/intel_rps.c | 14 +++---
2 files changed, 12 insertions(+), 4 deletions(-)
--
Jani Nikula, Intel
On Fri, 09 May 2025, Maxime Ripard wrote:
> On Thu, May 08, 2025 at 05:27:21PM +0300, Jani Nikula wrote:
>> On Mon, 05 May 2025, Anusha Srivatsa wrote:
>> > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote:
>> >
>> >> Hi Jani,
>> >>
>>
On Fri, 09 May 2025, Jani Nikula wrote:
> On Mon, 07 Apr 2025, Arun R Murthy wrote:
>> Arun R Murthy (5):
>> drm/i915/display: Populate list of async supported formats/modifiers
>> drm/i915/display: Add function for format_mod_supported_async
>
> Ack
On Mon, 07 Apr 2025, Arun R Murthy wrote:
> Arun R Murthy (5):
> drm/i915/display: Populate list of async supported formats/modifiers
> drm/i915/display: Add function for format_mod_supported_async
Acked-by: Jani Nikula
for merging these via drm-misc-next.
Maarten, I see
On Mon, 05 May 2025, Anusha Srivatsa wrote:
> On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote:
>
>> Hi Jani,
>>
>> On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrote:
>> > On Tue, 29 Apr 2025, Maxime Ripard wrote:
>> > > Hi Jani,
>
On Thu, 08 May 2025, "Lin, Wayne" wrote:
> [Public]
>
>> -Original Message-
>> From: Jani Nikula
>> Sent: Thursday, May 8, 2025 4:19 PM
>> To: Lin, Wayne ; dri-devel@lists.freedesktop.org
>> Cc: ville.syrj...@linux.intel.com; Limonciell
DRM edid*/
> struct dc_edid_caps edid_caps; /* parse display caps */
> struct dc_container_id *dc_container_id;
> uint32_t dongle_max_pix_clk;
--
Jani Nikula, Intel
*edid);
> int drm_edid_connector_add_modes(struct drm_connector *connector);
> bool drm_edid_is_digital(const struct drm_edid *drm_edid);
> +bool drm_edid_eq(const struct drm_edid *drm_edid_first,
> + const struct drm_edid *drm_edid_second);
Nitpick, parameter names in the declaration differ from the ones in the
definition.
With the above fixed,
Reviewed-by: Jani Nikula
> void drm_edid_get_product_id(const struct drm_edid *drm_edid,
>struct drm_edid_product_id *id);
> void drm_edid_print_product_id(struct drm_printer *p,
--
Jani Nikula, Intel
7 @@ struct dc_sink *link_add_remote_sink(
> if (!dc_sink)
> return NULL;
>
> - memmove(dc_sink->dc_edid.raw_edid, (const uint8_t *) edid, len);
> - dc_sink->dc_edid.length = len;
> + dc_edid_copy_edid_to_dc(dc_sink, edid, len);
>
> if (!link_add_remote_sink_helper(
> link,
--
Jani Nikula, Intel
itor_name(const struct edid *edid, char *name,
> -int buflen);
> +void drm_edid_get_monitor_name(const struct drm_edid *drm_edid,
> + char *name,
> +int bufsize);
Please move this under the section:
/* Interface based on struct drm_edid */
further down.
> +void drm_edid_raw_get_monitor_name(const struct edid *edid, char *name,
> +int bufsize);
> struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev,
> int hsize, int vsize, int fresh,
> bool rb);
--
Jani Nikula, Intel
instead of 0.
> + */
My brain gives me syntax and parse error here. ;)
BR,
Jani.
--
Jani Nikula, Intel
g.c
> +
MAINTAINERS is supposed to be sorted. See commit 80e62bc8487b
("MAINTAINERS: re-sort all entries and fields").
BR,
Jani.
> DRM PRIVACY-SCREEN CLASS
> M: Hans de Goede
> L: dri-devel@lists.freedesktop.org
>
> base-commit: 258aebf100540d36aba910f545d4d5ddf4ecaf0b
--
Jani Nikula, Intel
On Tue, 06 May 2025, Jonathan Gray wrote:
> On Tue, Nov 05, 2024 at 11:23:36AM +0200, Jani Nikula wrote:
>> On Sun, 03 Nov 2024, Jonathan Gray wrote:
>> > intel_pxp_gsccs_is_ready_for_sessions() is gated by CONFIG_DRM_I915_PXP
>> > but called from intel_pxp.c which
On Mon, 05 May 2025, Jeff Layton wrote:
> Now that there is the ability to create a symlink for each tracker, do
> so for the i915 entries.
I haven't tried this, but
Acked-by: Jani Nikula
>
> Signed-off-by: Jeff Layton
> ---
> drivers/gpu/drm/i915/intel_runtime_pm
class, dir);
> + name[sizeof(name) - 1] = '\0';
> +
> + if (ret < sizeof(name))
> + dir->dentry = debugfs_create_file(name, S_IFREG | 0400,
> + ref_tracker_debug_dir, dir,
> + &ref_tracker_debugfs_fops);
> + else
> + dir->dentry = ERR_PTR(-ENAMETOOLONG);
> +
> + if (IS_ERR(dir->dentry))
> + pr_warn("ref_tracker: unable to create debugfs file for %s:
> %pe\n",
> + name, dir->dentry);
> +}
> +EXPORT_SYMBOL(ref_tracker_dir_debugfs);
> +
> +static void ref_tracker_debugfs_remove(struct ref_tracker_dir *dir)
> +{
> + debugfs_remove(dir->dentry);
> +}
> +
> static int __init ref_tracker_debugfs_init(void)
> {
> ref_tracker_debug_dir = debugfs_create_dir("ref_tracker", NULL);
--
Jani Nikula, Intel
44 drivers/gpu/drm/xe/xe_pcode_fwctl.c
> create mode 100644 drivers/gpu/drm/xe/xe_pcode_fwctl.h
> create mode 100644 drivers/misc/mei/late_bind/Kconfig
> create mode 100644 drivers/misc/mei/late_bind/Makefile
> create mode 100644 drivers/misc/mei/late_bind/mei_late_bind.c
> create mode 100644 include/drm/intel/xe_late_bind_mei_interface.h
> create mode 100644 include/uapi/fwctl/xe_pcode.h
--
Jani Nikula, Intel
struct device *dev);
> +#else
> +static inline int drm_connector_hdmi_cec_notifier_register(struct
> drm_connector *connector,
> +const char
> *port_name,
> +struct device *dev)
> +{
> + return 0;
> +}
> +#endif
> +
> +#endif
--
Jani Nikula, Intel
u/drm/i915/pxp/intel_pxp_gsccs.h | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
Jani Nikula, Intel
On Tue, 29 Apr 2025, Maxime Ripard wrote:
> Hi Jani,
>
> On Mon, Apr 28, 2025 at 07:31:50PM +0300, Jani Nikula wrote:
>> On Mon, 31 Mar 2025, Anusha Srivatsa wrote:
>> > Allocate panel via reference counting. Add _get() and _put() helper
>> > functions to ensure
lling
> + * drm_panel_put()) when @dev is removed.
> + *
> * Returns:
> * Pointer to container structure embedding the panel, ERR_PTR on failure.
> */
> @@ -294,6 +310,9 @@ void drm_panel_init(struct drm_panel *panel, struct
> device *dev,
> const struct drm_panel_funcs *funcs,
> int connector_type);
>
> +struct drm_panel *drm_panel_get(struct drm_panel *panel);
> +void drm_panel_put(struct drm_panel *panel);
> +
> void drm_panel_add(struct drm_panel *panel);
> void drm_panel_remove(struct drm_panel *panel);
--
Jani Nikula, Intel
put.
>>>
>>> v5: change to macro from function (Christian Koenig)
>>> add helper functions for lock/unlock (Christian Koenig)
>>>
>>> v6: remove __maybe_unused and make function inline (Jani Nikula)
>>> remove drm_print.h
>>>
>
t; the assignment.
>
> Signed-off-by: Kees Cook
Acked-by: Jani Nikula
for merging via whichever tree you find best; please let us know if you
want us to pick this up via drm-intel.
> ---
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Tvrtko Ursulin
>
test_edid_hdmi_1080p_rgb_max_200mhz,
> -
> ARRAY_SIZE(test_edid_hdmi_1080p_rgb_max_200mhz));
> - KUNIT_ASSERT_GT(test, ret, 0);
> -
> - return priv;
> + return drm_kunit_helper_connector_hdmi_init_with_edid_funcs(test,
> + formats,
> + max_bpc,
> + &dummy_connector_hdmi_funcs,
> + test_edid_hdmi_1080p_rgb_max_200mhz);
> }
>
> /*
--
Jani Nikula, Intel
de/drm/display/drm_dp_helper.h
> index
> d9614e2c89397536f44bb7258e894628ae1dccc9..7b19192c70313d66dce1b7ba40dd59c14f80a182
> 100644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -971,5 +971,7 @@ int drm_dp_bw_channel_coding_efficiency(bool is_uhbr);
> int drm_dp_max_dprx_data_rate(int max_link_rate, int max_lanes);
>
> ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc, struct dp_sdp
> *sdp);
> +int drm_dp_link_symbol_cycles(int lane_count, int pixels, int
> dsc_slice_count,
> + int bpp_x16, int symbol_size, bool is_mst);
>
> #endif /* _DRM_DP_HELPER_H_ */
--
Jani Nikula, Intel
0644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -971,5 +971,7 @@ int drm_dp_bw_channel_coding_efficiency(bool is_uhbr);
> int drm_dp_max_dprx_data_rate(int max_link_rate, int max_lanes);
>
> ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc, struct dp_sdp
> *sdp);
> +int drm_dp_link_symbol_cycles(int lane_count, int pixels, int
> dsc_slice_count,
> + int bpp_x16, int symbol_size, bool is_mst);
>
> #endif /* _DRM_DP_HELPER_H_ */
--
Jani Nikula, Intel
ore magic numbers.
BR,
Jani.
>
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250407-fix_nvidia-a9d72c98a808
>
> Best regards,
--
Jani Nikula, Intel
imit_state_get_miss() function instead of directly accessing
> the ->missed field.
Acked-by: Jani Nikula
For merging via whichever tree is convenient for you. Please let us know
if you want us to pick it up via drm-intel.
>
> Link:
> https://lore.kernel.org/all/fbe93a52-365e-
t; + ret = generic_handle_irq_safe(gt->gsc.intf[intf_id].irq);
> +
> if (ret)
> gt_err_ratelimited(gt, "error handling GSC irq: %d\n", ret);
> }
--
Jani Nikula, Intel
;> ret = generic_handle_irq(gt->gsc.intf[intf_id].irq);
>
> What about generic_handle_irq_safe() instead the whole ifdef show?
Anything without the ifdefs would be welcome.
BR,
Jani.
>
>> +#ifdef CONFIG_PREEMPT_RT
>> +if (!irq_disabled_flag)
>> +local_irq_enable();
>> +#endif
>> +
>> if (ret)
>> gt_err_ratelimited(gt, "error handling GSC irq: %d\n", ret);
>> }
>
> Sebastian
--
Jani Nikula, Intel
On Thu, 17 Apr 2025, "Khatri, Sunil" wrote:
> On 4/16/2025 7:55 PM, Jani Nikula wrote:
>> On Wed, 16 Apr 2025, Sunil Khatri wrote:
>>> Add a drm helper macro which append the process information for
>>> the drm_file over drm_err.
>>>
>>>
On Thu, 17 Apr 2025, Christian König wrote:
> Am 17.04.25 um 13:07 schrieb Jani Nikula:
>> On Thu, 17 Apr 2025, Christian König wrote:
>>> Am 17.04.25 um 11:35 schrieb Jani Nikula:
>>>> On Thu, 17 Apr 2025, Sunil Khatri wrote:
>>>>> Add a drm help
On Thu, 17 Apr 2025, Christian König wrote:
> Am 17.04.25 um 11:35 schrieb Jani Nikula:
>> On Thu, 17 Apr 2025, Sunil Khatri wrote:
>>> Add a drm helper macro which append the process information for
>>> the drm_file over drm_err.
>>>
>>> v5: ch
maybe_unused and make function inline (Jani Nikula)
> remove drm_print.h
I guess I gave all kinds of comments, but in the end my conclusion was:
why does *any* of this have to be static inline or macros? Make
drm_file_err() a regular function and hide the implementation inside
drm_file.c. That
: If set, disable DCN Sub-Viewport feature in
> amdgpu driver.
> - */
> DC_DISABLE_SUBVP = 0x2,
> - /**
> - * @DC_DISABLE_CUSTOM_BRIGHTNESS_CURVE: If set, disable support for
> custom brightness curves
> - */
> DC_DISABLE_CUSTOM_BRIGHTNESS_CURVE = 0x4,
> -
> - /**
> - * @DC_HDCP_LC_FORCE_FW_ENABLE: If set, use HDCP Locality Check FW
> - * path regardless of reported HW capabilities.
> - */
> DC_HDCP_LC_FORCE_FW_ENABLE = 0x8,
> -
> - /**
> - * @DC_HDCP_LC_ENABLE_SW_FALLBACK If set, upon HDCP Locality Check FW
> - * path failure, retry using legacy SW path.
> - */
> DC_HDCP_LC_ENABLE_SW_FALLBACK = 0x10,
> };
--
Jani Nikula, Intel
drm/i915/dp: Check for HAS_DSC_3ENGINES while configuring DSC slices
drivers/gpu/drm/i915/display/intel_display_device.h | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
--
Jani Nikula, Intel
nk this should be cleared in drm_reset_display_info(), and
long-term fields like this should be moved within display info.
BR,
Jani.
> mutex_unlock(&connector->eld_mutex);
>
> connector->latency_present[0] = false;
--
Jani Nikula, Intel
On Tue, 15 Apr 2025, Jani Nikula wrote:
> Resend of Egor's patches [1].
>
> [1] https://lore.kernel.org/r/20250214110643.506740-1-sdore...@sdore.me
>
> Cc: Egor Vorontsov
>
> Egor Vorontsov (2):
> drm/edid: Implement DisplayID Type IX & X timing blocks parsing
hat matter, why is *this* inline? For debugs it makes a little more
sense when it adds the function, but drm_err() doesn't.
Make all of these real functions, no need to include drm_print.h, and
everything is better.
BR,
Jani.
> void drm_file_update_pid(struct drm_file *);
>
> struct drm_minor *drm_minor_acquire(struct xarray *minors_xa, unsigned int
> minor_id);
--
Jani Nikula, Intel
ot match the value in 'brightness'.
>
> Which factors? Under what circumstances may the values not match?
At least for i915, the brightness range in sysfs isn't guaranteed to be
the range in hardware. For example, you might want sysfs to start from
0, but the hardware has a minimum that is non-zero. Or you might just
want to have a fixed range, say, 0-100 in sysfs. Any scaling may
introduce rounding errors in the round-trip.
BR,
Jani.
--
Jani Nikula, Intel
0e33aba..d6d397fbf917 100755
> --- a/scripts/find-unused-docs.sh
> +++ b/scripts/find-unused-docs.sh
> @@ -54,7 +54,7 @@ for file in `find $1 -name '*.c'`; do
> if [[ ${FILES_INCLUDED[$file]+_} ]]; then
> continue;
> fi
> - str=$(scripts/kernel-doc -export "$file" 2>/dev/null)
> + str=$(PYTHONDONTWRITEBYTECODE=1 scripts/kernel-doc -export "$file"
> 2>/dev/null)
> if [[ -n "$str" ]]; then
> echo "$file"
> fi
--
Jani Nikula, Intel
On Wed, 16 Apr 2025, Jani Nikula wrote:
> On Wed, 16 Apr 2025, Mauro Carvalho Chehab wrote:
>> As reported by Andy, kernel-doc.py is creating a __pycache__
>> directory at build time.
>>
>> Disable creation of __pycache__ for the libraries used by
>> kernel-doc
unused-docs.sh b/scripts/find-unused-docs.sh
> index ee6a50e33aba..d6d397fbf917 100755
> --- a/scripts/find-unused-docs.sh
> +++ b/scripts/find-unused-docs.sh
> @@ -54,7 +54,7 @@ for file in `find $1 -name '*.c'`; do
> if [[ ${FILES_INCLUDED[$file]+_} ]]; then
> continue;
> fi
> - str=$(scripts/kernel-doc -export "$file" 2>/dev/null)
> + str=$(PYTHONDONTWRITEBYTECODE=1 scripts/kernel-doc -export "$file"
> 2>/dev/null)
> if [[ -n "$str" ]]; then
> echo "$file"
> fi
--
Jani Nikula, Intel
above statement
being replicated all over the place. It's fundamentally incompatible
with the HF-EEODB EDID extension block.
BR,
Jani.
> + memcpy(sink->dc_edid.raw_edid, (uint8_t *) edid, edid_length);
> + sink->dc_edid.length = edid_length;
> }
>
>
--
Jani Nikula, Intel
Resend of Egor's patches [1].
[1] https://lore.kernel.org/r/20250214110643.506740-1-sdore...@sdore.me
Cc: Egor Vorontsov
Egor Vorontsov (2):
drm/edid: Implement DisplayID Type IX & X timing blocks parsing
drm/edid: Refactor DisplayID timing block structs
drivers/gpu/drm/drm_displayid_inte
order to enable native
support of HRR modes of most such monitors for users without having to rely
on EDID patching/override (or need thereof).
Closes: https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/55
Suggested-by: Maximilian Boße
Signed-off-by: Egor Vorontsov
Reviewed-by: Jani Nikula
S
On Tue, 15 Apr 2025, Chen Linxuan wrote:
> Jani Nikula 于2025年4月15日周二 15:59写道：
>>
>> On Fri, 11 Apr 2025, Chen Linxuan wrote:
>> > On x86_64 with gcc version 13.3.0, I compile kernel with:
>> >
>> > make defconfig
>> > ./scrip
From: Egor Vorontsov
Using le16 instead of u8[2].
Suggested-by: Jani Nikula
Signed-off-by: Egor Vorontsov
Reviewed-by: Jani Nikula
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_displayid_internal.h | 18 +++
drivers/gpu/drm/drm_edid.c | 28
fault, I dropped the ball.
I resent the patches for fresh results [1], and will merge them via
drm-misc-next.
BR,
Jani.
[1] https://lore.kernel.org/r/cover.1744708239.git.jani.nik...@intel.com
--
Jani Nikula, Intel
mall-functions
> -fno-inline-functions-called-once"
The change looks good, but I'm guessing the real explanation is that you
have CONFIG_DRM_I915_PXP=n and that appears to be broken.
Fixes: 99afb7cc8c44 ("drm/i915/pxp: Add ARB session creation and cleanup")
Reviewed-by: Jani
struct drm_edid *edid);
> int drm_edid_connector_add_modes(struct drm_connector *connector);
> bool drm_edid_is_digital(const struct drm_edid *drm_edid);
> +bool drm_edid_is_edid_eq(const struct drm_edid *drm_edid_first,
> + const struct drm_edid *drm_edid_second);
> void drm_edid_get_product_id(const struct drm_edid *drm_edid,
>struct drm_edid_product_id *id);
> void drm_edid_print_product_id(struct drm_printer *p,
--
Jani Nikula, Intel
&connector->eld[DRM_ELD_MONITOR_NAME_STRING],
> +AMDGPU_ELD_DISPLAY_NAME_SIZE_IN_CHARS);
It's not that simple. The monitor name in ELD is not fixed length (see
drm_eld_mnl()) and neither is it guaranteed to be NUL terminated.
BR,
Jani.
>
> edid_caps->edid_hdmi = connector->display_info.is_hdmi;
--
Jani Nikula, Intel
s(struct drm_printer *p, struct drm_file *file);
> void drm_show_fdinfo(struct seq_file *m, struct file *f);
> +void drm_process_info(struct drm_file *file_priv, char *proc_info, size_t
> buff_size);
>
> struct file *mock_drm_getfile(struct drm_minor *minor, unsigned int flags);
--
Jani Nikula, Intel
rm_dp_aux *aux, const struct
> drm_edp_backlight_info *bl,
> - u16 level);
> + u32 level);
> int drm_edp_backlight_enable(struct drm_dp_aux *aux, const struct
> drm_edp_backlight_info *bl,
>u16 level);
> int drm_edp_backlight_disable(struct drm_dp_aux *aux, const struct
> drm_edp_backlight_info *bl);
--
Jani Nikula, Intel
-10&show_html=true
> Fixes: 1afba39f9305 ("Merge drm/drm-next into drm-misc-next")
> Acked-by: Simona Vetter
Acked-by: Jani Nikula
> ---
> drivers/gpu/drm/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/
r build
coverage.
BR,
Jani.
--
Jani Nikula, Intel
live selftest
Jani Nikula (1):
drm/i915/gvt: fix unterminated-string-initialization warning
Janusz Krzysztofik (1):
drm/i915/huc: Fix fence not released on early probe errors
Ville Syrjälä (2):
drm/i915: Fix scanline_offset for LNL+ and BMG+
drm/i915/dp: Reject HBR3 whe
ttps://gitlab.freedesktop.org/drm/xe/ci/-/raw/main/kernel/kconfig
There's
CONFIG_DRM_PANEL=y
# CONFIG_OF is not set
but __devm_drm_panel_alloc is inside #ifdef CONFIG_OF. I don't know that
it should be.
There are some stubs in drm_panel.h for !CONFIG_OF but not this one.
Finally, DRM_PANEL_AUO_A030JTN01 does not depend on OF.
That's the issue, but I don't know what the correct fix would be.
BR,
Jani.
--
Jani Nikula, Intel
On Tue, 08 Apr 2025, Jason Gunthorpe wrote:
> On Tue, Apr 08, 2025 at 11:27:58AM +0300, Jani Nikula wrote:
>> On Mon, 07 Apr 2025, Jason Gunthorpe wrote:
>> > On Mon, Apr 07, 2025 at 10:17:40AM +0300, Jani Nikula wrote:
>> >
>> >> Even with Jason's i
tries to maintain.
>
> Signed-off-by: Lucas De Marchi
Thanks for doing this!
Reviewed-by: Jani Nikula
Tested-by: Jani Nikula
> ---
> nightly.conf | 25 -
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/nightly.conf b/nightly.co
On Mon, 07 Apr 2025, Jason Gunthorpe wrote:
> On Mon, Apr 07, 2025 at 10:17:40AM +0300, Jani Nikula wrote:
>
>> Even with Jason's idea [1], you *still* have to start small and opt-in
>> (i.e. the patch series at hand). You can't just start off by testing
>> ever
On Fri, 04 Apr 2025, Masahiro Yamada wrote:
> On Wed, Apr 2, 2025 at 9:47 PM Jani Nikula wrote:
>>
>> Another go at hiding the turds.
>>
>> In v1 [1] I hid the build artifacts under .hdrtest subdirectories, one in
>> each
>> $(obj) directory, but the feed
On Tue, 25 Mar 2025, Maxime Ripard wrote:
> On Tue, Mar 25, 2025 at 12:47:49PM +0200, Jani Nikula wrote:
>> On Tue, 25 Mar 2025, Maxime Ripard wrote:
>> > On Tue, Mar 25, 2025 at 11:16:47AM +0200, Jani Nikula wrote:
>> >> On Sat, 22 Mar 2025, devbrones wrote:
>&
requires CONFIG_HEADER_CHECK_KERNEL_DOC.
Cc: Linus Torvalds
Cc: Masahiro Yamada
Cc: David Airlie
Cc: Simona Vetter
Signed-off-by: Jani Nikula
---
Cc: linux-kbu...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel...@lists.freedesktop.org
Cc: intel-...@lists.freedesktop.org
Closes:
https://lore.kernel.org/r/CAHk-=wjMrqzuUmH-mFbR_46EWEFS=bB=j7h9abmvy56vi81...@mail.gmail.com
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: Masahiro Yamada
Cc: David Airlie
Cc: Simona Vetter
Signed-off-by: Jani Nikula
---
Cc: linux-kbu...@vger.ker
; drm_connector_list_iter_end(&iter);
>
> - if (need_hotplug)
> - drm_kms_helper_hotplug_event(ddev);
> -
> amdgpu_dm_irq_resume_late(adev);
>
> amdgpu_dm_smu_write_watermarks_table(adev);
>
> + drm_kms_helper_hotplug_event(ddev);
> +
> return 0;
> }
--
Jani Nikula, Intel
on't think more (duplicated) information should be
> added here.
Agreed. I think the direction should be to reduce stuff from
i915_display_info and put it into per-crtc and per-connector debugfs
instead.
BR,
Jani.
>
> One issue with the i915_dsc_fec_support entry is that it do
On Wed, 02 Apr 2025, Jason Gunthorpe wrote:
> On Wed, Apr 02, 2025 at 03:56:37PM +0300, Jani Nikula wrote:
>> On Tue, 01 Apr 2025, Jason Gunthorpe wrote:
>> > On Tue, Apr 01, 2025 at 10:42:35PM +0300, Jani Nikula wrote:
>> >> On Tue, 01 Apr 2025, Jason Gunthorpe wr
...@mail.gmail.com
Fixes: c6d4a099a240 ("drm/i915: reimplement header test feature")
Cc: Masahiro Yamada
Cc: David Airlie
Cc: Simona Vetter
Signed-off-by: Jani Nikula
---
Cc: linux-kbu...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel...@lists.freedesktop.org
On Tue, 01 Apr 2025, Jason Gunthorpe wrote:
> On Tue, Apr 01, 2025 at 10:42:35PM +0300, Jani Nikula wrote:
>> On Tue, 01 Apr 2025, Jason Gunthorpe wrote:
>> > So, I'd suggest a better way to run this is first build the kernel,
>> > then mine the gcc -MD output (ie
=j7h9abmvy56vi81...@mail.gmail.com
Fixes: 62ae45687e43 ("drm: ensure drm headers are self-contained and pass
kernel-doc")
Cc: Masahiro Yamada
Cc: David Airlie
Cc: Simona Vetter
Signed-off-by: Jani Nikula
---
Cc: linux-kbu...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
ro Yamada
Cc: David Airlie
Cc: Simona Vetter
Cc: linux-kbu...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel...@lists.freedesktop.org
Cc: intel-...@lists.freedesktop.org
Jani Nikula (4):
kbuild: add generic header check facility
drm: switch to generic header check facility
liminates all the kconfig problems. Opt out any
> special headers that really have a good reason not to be stand alone.
I think we'd want the drm headers pass the checks independent of configs
(apart from CONFIG_DRM). One size doesn't fit all.
BR,
Jani.
--
Jani Nikula, Intel
On Wed, 02 Apr 2025, Masahiro Yamada wrote:
> On Wed, Apr 2, 2025 at 1:12 AM Linus Torvalds
> wrote:
>>
>> On Tue, 1 Apr 2025 at 05:21, Jani Nikula wrote:
>> >
>> > The header checks have existed for uapi headers before, including the,
>> > uh, turds
access
> helpers")
> Cc: Dmitry Baryshkov
> Cc: Lyude Paul
> Signed-off-by: Imre Deak
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_m
drm_plane_helper_funcs intel_plane_helper_funcs = {
> .prepare_fb = intel_prepare_plane_fb,
> .cleanup_fb = intel_cleanup_plane_fb,
> };
>
> +static const struct drm_plane_helper_funcs intel_primary_plane_helper_funcs
> = {
> + .prepare_fb = intel_prepare_plane_fb,
> + .cleanup_fb = intel_cleanup_plane_fb,
> + .get_scanout_buffer = intel_get_scanout_buffer,
> + .panic_flush = intel_panic_flush,
> +};
> +
> void intel_plane_helper_add(struct intel_plane *plane)
> {
> - drm_plane_helper_add(&plane->base, &intel_plane_helper_funcs);
> + if (plane->base.type == DRM_PLANE_TYPE_PRIMARY)
> + drm_plane_helper_add(&plane->base,
> &intel_primary_plane_helper_funcs);
> + else
> + drm_plane_helper_add(&plane->base, &intel_plane_helper_funcs);
> }
>
> void intel_plane_init_cursor_vblank_work(struct intel_plane_state
> *old_plane_state,
--
Jani Nikula, Intel
ada
Cc: David Airlie
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
Cc: linux-kbu...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel...@lists.freedesktop.org
Cc: intel-...@lists.freedesktop.org
---
usr/include/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On Mon, 31 Mar 2025, Linus Torvalds wrote:
> On Mon, 31 Mar 2025 at 03:17, Jani Nikula wrote:
>>
>> I suggest a Kconfig knob to truly make this opt-in, only for developers
>> who actually want it.
>
> So honestly, the thing I *really* hated was the horrendous naming.
keep checking the headers are in fact
included first, and nagging about it in reviews, is not without cost.
BR,
Jani.
--
Jani Nikula, Intel
("drm: ensure drm headers are self-contained and pass
kernel-doc")
Cc: Masahiro Yamada
Cc: David Airlie
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
Cc: linux-kbu...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel...@lists.freedesktop.org
Cc: intel-...@lists.freed
mH-mFbR_46EWEFS=bB=j7h9abmvy56vi81...@mail.gmail.com
Fixes: c6d4a099a240 ("drm/i915: reimplement header test feature")
Cc: Masahiro Yamada
Cc: David Airlie
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
Cc: linux-kbu...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel...@lis
mH-mFbR_46EWEFS=bB=j7h9abmvy56vi81...@mail.gmail.com
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: Lucas De Marchi
Cc: Masahiro Yamada
Cc: David Airlie
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
Cc: linux-kbu...@vger.kernel.org
Cc: dri-devel@lis
mH-mFbR_46EWEFS=bB=j7h9abmvy56vi81...@mail.gmail.com
Fixes: 62ae45687e43 ("drm: ensure drm headers are self-contained and pass
kernel-doc")
Cc: Masahiro Yamada
Cc: David Airlie
Cc: Daniel Vetter
Signed-off-by: Jani Nikula
---
Cc: linux-kbu...@vger.kernel.org
Cc: dri-devel@lis
: Masahiro Yamada
Cc: David Airlie
Cc: Daniel Vetter
Cc: Lucas De Marchi
Jani Nikula (5):
drm: place header test files in .hdrtest subdirectories
drm/xe: place header test files in .hdrtest subdirectories
drm/i915: place header test files in .hdrtest subdirectories
kbuild: hdrtest: place
On Sun, 30 Mar 2025, Zhenyu Wang wrote:
> On Thu, Feb 27, 2025 at 11:38:05AM +0200, Jani Nikula wrote:
>> Update GVT-g MAINTAINERS entry to reflect the current status of
>> maintenance and repositories.
>>
>> Cc: Dave Airlie
>> Cc: Joonas Lahtinen
>>
guess it would be nice to have this patch
> mainlined rather sooner that later to avoid more people running into this.
Thanks for testing, though I've merged [1] instead.
BR,
Jani.
[1] https://lore.kernel.org/r/20250327124739.2609656-1-jani.nik...@intel.com
--
Jani Nikula, Intel
l-doc issues
pre-merge instead of doing extra rounds of fixes afterwards.
BR,
Jani.
>From 8c709510caab4b4ad6aa73cbcd972f32b58cad8d Mon Sep 17 00:00:00 2001
From: Jani Nikula
Date: Mon, 31 Mar 2025 12:25:45 +0300
Subject: [PATCH] drm: add config option for extra build-time checks
Organization: Intel Finlan
know something fishy is going on
when you have a negative resolution. Nobody blinks an eye when you ask
for 4294963K telly, but it's still just as bonkers as that negative 4K.
I think the change at hand is fine, but please let's not pretend using
unsigned somehow protects us from negati
On Thu, 27 Feb 2025, Jani Nikula wrote:
> Update GVT-g MAINTAINERS entry to reflect the current status of
> maintenance and repositories.
>
> Cc: Dave Airlie
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Simona Vetter
> Cc: Tvrtko Ursulin
> Cc: Zhenyu Wang
&
On Fri, 28 Mar 2025, Andi Shyti wrote:
> Replace multi-line SPDX license headers with single-line
> equivalents (// SPDX-License-Identifier: MIT or /* ... */ for
> headers), as preferred by current kernel coding style.
>
> Signed-off-by: Andi Shyti
Acked-by: Jani Nikula
On Fri, 28 Mar 2025, Yongbang Shi wrote:
>> On Thu, 27 Mar 2025, Yongbang Shi wrote:
>>> 在 2025/3/26 17:32, Jani Nikula 写道:
>>>> On Tue, 25 Mar 2025, Yongbang Shi wrote:
>>>>>> On Mon, 24 Mar 2025, Yongbang Shi wrote:
>>>>>>>>
ENGINE_INSTANCES_MASK(gt, CCS0, I915_MAX_CCS)
>
> +#define FIRST_CCS(e__) \
> + (CCS_MASK(e__->gt) && (__ffs(CCS_MASK(e__->gt)) == e__->instance))
> +
Could I persuade you to find a more specific header file for this, along
with the CCS_MASK etc.?
BR,
Jani.
this patch be merged into 6.14?
>>
>> Huacai
>>
>> On Mon, Nov 25, 2024 at 2:00 PM Huacai Chen wrote:
>> >
>> > On Mon, Nov 11, 2024 at 10:41 PM Jani Nikula
>> > wrote:
>> > >
>> > > On Mon, 11 Nov 2024, H
1 - 100 of 2324 matches
Mail list logo
