[GIT PULL] fbdev last fixes for v6.17-rc1

2025-08-07 Thread Helge Deller
7:33 +0200) fbdev fixes for 6.17-rc1: - Revert a patch which broke VGA console. - Fix an out-of-bounds access bug which may happen during console resizing when a console is mapped to a frame buffer. -------- Helge Deller (1): Revert &q

Re: [PATCH] fbdev: Fix vmalloc out-of-bounds write in fast_imageblit

2025-08-02 Thread Helge Deller
On 7/31/25 22:36, Sravan Kumar Gundu wrote: This issue triggers when a userspace program does an ioctl FBIOPUT_CON2FBMAP by passing console number and frame buffer number. Ideally this maps console to frame buffer and updates the screen if console is visible. As part of mapping it has to do resi

[GIT PULL] fbdev fixes and updates for v6.17-rc1

2025-08-02 Thread Helge Deller
Hi Linus, please pull the fbdev fixes and updates for 6.17-rc1: One potential buffer overflow fix in the framebuffer registration function, some fixes for the imxfb, nvidiafb and simplefb drivers, and a bunch of cleanups for fbcon, kyrofb and svgalib. Thanks, Helge -

Re: [PATCH 2/2] fbdev: remove metronomefb

2025-07-27 Thread Helge Deller
On 6/25/25 15:12, Arnd Bergmann wrote: From: Arnd Bergmann This driver has not worked correctly for many years, and the only in-tree reference to it is going away as well, so remove the driver now. Signed-off-by: Arnd Bergmann --- Documentation/fb/index.rst| 1 - Documentation/fb

Re: [PATCH] fbdev: pm3fb: Fix potential divide by zero

2025-07-27 Thread Helge Deller
Hi Alex, On 6/12/25 11:29, Geert Uytterhoeven wrote: On Wed, 11 Jun 2025 at 18:12, Alex Guo wrote: On Sat, 7 Jun 2025 at 22:14, Alex Guo wrote: variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in pm3fb_check_var. Similar crashes have happened

Re: [PATCH] fbdev: Fix typo in Kconfig text for FB_DEVICE

2025-07-27 Thread Helge Deller
On 7/25/25 07:30, Daniel Palmer via B4 Relay wrote: From: Daniel Palmer Seems like someone hit 'c' when they meant to hit 'd'. Signed-off-by: Daniel Palmer --- drivers/video/fbdev/core/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied. Thanks! Helge

Re: [PATCH] fbdev: Check fb_add_videomode to prevent null-ptr-deref

2025-07-27 Thread Helge Deller
On 7/24/25 05:25, Chenyuan Yang wrote: fb_add_videomode() can fail with -ENOMEM when its internal kmalloc() cannot allocate a struct fb_modelist. If that happens, the modelist stays empty but the driver continues to register. Add a check for its return value to prevent poteintial null-ptr-deref,

Re: [PATCH] fbdev: svgalib: Clean up coding style

2025-07-27 Thread Helge Deller
On 7/21/25 14:56, Darshan R. wrote: This patch addresses various coding style issues in `svgalib.c` to improve readability and better align the code with the Linux kernel's formatting standards. The changes primarily consist of: - Adjusting whitespace around operators and after keywords. - Sta

Re: [PATCH v3 0/3] fbdev: kyro: Convert to managed device resources

2025-07-27 Thread Helge Deller
On 7/9/25 11:53, Giovanni Di Santi wrote: This series aims to address the TODO item "Request memory regions in all fbdev drivers" from Documentation/gpu/todo.rst. Additionally, it also converts the kyro framebuffer driver to use managed device functions. In summary, it converts the driver to use

Re: [PATCH] fbdev: simplefb: Use of_reserved_mem_region_to_resource() for "memory-region"

2025-07-27 Thread Helge Deller
On 7/3/25 20:35, Rob Herring (Arm) wrote: Use the newly added of_reserved_mem_region_to_resource() function to handle "memory-region" properties. The error handling is a bit different. "memory-region" is optional, so failed lookup is not an error. But then an error in of_address_to_resource() is

Re: [PATCH] fbdev: nvidiafb: add depends on HAS_IOPORT

2025-07-27 Thread Helge Deller
Dunlap Cc: Arnd Bergmann Cc: Niklas Schnelle Cc: Antonino Daplas Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/fbdev/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied. Thanks! Helge --- lnx-616-rc1.orig/dri

Re: [PATCH 1/2] fbdev: remove fb_notify support

2025-06-25 Thread Helge Deller
Hi Arnd, On 6/25/25 17:20, Sam Ravnborg wrote: Hi Arnd. I remember I stared at this code before, good to see it gone. There is a bit more tidiying up you can do. Also, I suggest to split it in two patches, it itches me to see the driver specific part mixed up with the fb_notify removal. I as

Re: [PATCH v2 14/14] fbdev/viafb: Do not include

2025-06-12 Thread Helge Deller
(-) Reviewed-by: Helge Deller

Re: [PATCH v2 10/14] fbdev/mb862xx: Do not include

2025-06-12 Thread Helge Deller
deletion(-) Reviewed-by: Helge Deller

Re: [PATCH v2 13/14] fbdev/viafb: Include

2025-06-12 Thread Helge Deller
Zimmermann --- drivers/video/fbdev/via/via-core.c | 1 + drivers/video/fbdev/via/via_i2c.c | 1 + 2 files changed, 2 insertions(+) Reviewed-by: Helge Deller

Re: [PATCH v2 12/14] fbdev/sisfb: Unexport symbols

2025-06-12 Thread Helge Deller
| 6 -- 3 files changed, 33 deletions(-) Reviewed-by: Helge Deller

Re: [PATCH v2 11/14] fbdev/pxafb: Unexport symbol

2025-06-12 Thread Helge Deller
: Thomas Zimmermann --- drivers/video/fbdev/pxafb.c | 17 ++--- include/linux/platform_data/video-pxafb.h | 1 - 2 files changed, 2 insertions(+), 16 deletions(-) Reviewed-by: Helge Deller

Re: [PATCH v2 04/14] fbdev/cyber2000fb: Unexport symbols

2025-06-12 Thread Helge Deller
-off-by: Thomas Zimmermann --- drivers/video/fbdev/cyber2000fb.c | 36 --- drivers/video/fbdev/cyber2000fb.h | 2 -- 2 files changed, 38 deletions(-) Reviewed-by: Helge Deller

Re: [PATCH v2 09/14] fbdev/omap2: Do not include

2025-06-12 Thread Helge Deller
/omapfb/omapfb-ioctl.c | 1 - 3 files changed, 3 deletions(-) Reviewed-by: Helge Deller

Re: [PATCH v2 08/14] fbdev/omap2: Include

2025-06-12 Thread Helge Deller
| 1 + drivers/video/fbdev/omap2/omapfb/dss/overlay.c | 1 + drivers/video/fbdev/omap2/omapfb/dss/venc.c | 1 + drivers/video/fbdev/omap2/omapfb/vrfb.c | 1 + 11 files changed, 11 insertions(+) Reviewed-by: Helge Deller

Re: [PATCH 07/14] fbdev/omap: Include

2025-06-10 Thread Helge Deller
(+) Reviewed-by: Helge Deller

Re: [PATCH 06/14] fbdev/matroxfb: Include

2025-06-10 Thread Helge Deller
++ drivers/video/fbdev/matrox/matroxfb_misc.c| 1 + 7 files changed, 10 insertions(+) Reviewed-by: Helge Deller

Re: [PATCH 05/14] fbdev/matroxfb: Remove trailing whitespaces

2025-06-10 Thread Helge Deller
+-- drivers/video/fbdev/matrox/matroxfb_misc.c| 20 +++ 4 files changed, 75 insertions(+), 75 deletions(-) Reviewed-by: Helge Deller

Re: [PATCH 04/14] fbdev/cyber2000fb: Unexport symbols

2025-06-10 Thread Helge Deller
On 6/10/25 12:56, Thomas Zimmermann wrote: Fix the compile-time warning drivers/video/fbdev/cyber2000fb.c: warning: EXPORT_SYMBOL() is used, but #include is missing The affected symbols are not used outside of their module. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/cyber

Re: [PATCH 01/14] fbdev: Remove trailing whitespaces

2025-06-10 Thread Helge Deller
On 6/10/25 12:56, Thomas Zimmermann wrote: Fix coding style. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/macmodes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Helge Deller

Re: [PATCH 03/14] fbdev/c2p: Include

2025-06-10 Thread Helge Deller
Zimmermann --- drivers/video/fbdev/c2p_iplan2.c | 1 + drivers/video/fbdev/c2p_planar.c | 1 + 2 files changed, 2 insertions(+) Reviewed-by: Helge Deller

Re: [PATCH 02/14] fbdev: Include

2025-06-10 Thread Helge Deller
/sbuslib.c | 1 + drivers/video/fbdev/wmt_ge_rops.c | 1 + 18 files changed, 26 insertions(+) Reviewed-by: Helge Deller I wonder why this shows up for you but not for me... Helge

Re: [PATCH 11/14] fbdev/pxafb: Unexport symbol

2025-06-10 Thread Helge Deller
On 6/10/25 12:56, Thomas Zimmermann wrote: Fix the compile-time warning drivers/video/fbdev/pxafb.c: warning: EXPORT_SYMBOL() is used, but #include is missing The affected symbol is not used outside of its module. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/pxafb.c | 1 -

Re: [PATCH] fbdev: pm3fb: Fix potential divide by zero

2025-06-08 Thread Helge Deller
On 6/7/25 21:49, Alex Guo wrote: variable var->pixclock can be set by user. In case it equals to zero, divide by zero would occur in pm3fb_check_var. Similar crashes have happened in other fbdev drivers. There is no check and modification on var->pixclock along the call chain to pm3fb_check_var

Re: [PATCH] nvidiafb: fix build on 32-bit ARCH=um

2025-06-06 Thread Helge Deller
On 6/6/25 11:02, Johannes Berg wrote: From: Johannes Berg Now that ARCH=um no longer has IO port accesses, this driver can no longer build as-is. Make the IO port calls not just conditional on i386 but also !UML. Reported-by: Arnd Bergmann Signed-off-by: Johannes Berg --- drivers/video/fbd

Re: [PATCH 2/2] video: Make global edid_info depend on CONFIG_FIRMWARE_EDID

2025-06-03 Thread Helge Deller
On 6/3/25 18:18, Thomas Zimmermann wrote: Hi Am 03.06.25 um 18:08 schrieb Helge Deller: On 6/2/25 09:51, Thomas Zimmermann wrote: Protect global edid_info behind CONFIG_FIRMWARE_EDID and remove the config tests for CONFIG_X86. Makes edid_info available iff its option has been enabled. Signed

Re: [PATCH 1/2] video: Make CONFIG_FIRMWARE_EDID generally available

2025-06-03 Thread Helge Deller
. Signed-off-by: Thomas Zimmermann --- drivers/video/Kconfig| 18 +- drivers/video/fbdev/core/Kconfig | 15 --- drivers/video/fbdev/core/fbmon.c | 3 +-- 3 files changed, 18 insertions(+), 18 deletions(-) Reviewed-by: Helge Deller

Re: [PATCH 2/2] video: Make global edid_info depend on CONFIG_FIRMWARE_EDID

2025-06-03 Thread Helge Deller
/drm/sysfb/efidrm.c | 2 +- drivers/gpu/drm/sysfb/vesadrm.c | 2 +- include/video/edid.h| 3 ++- 4 files changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Helge Deller

[GIT PULL] fbdev updates for v6.16-rc1

2025-05-31 Thread Helge Deller
Hi Linus, please pull the fbdev fixes and updates for 6.16-rc1: Many small but important fixes for special cases in the fbdev, fbcon and vgacon code, some smaller code cleanups in the nvidiafb, arkfb, atyfb and viafb drivers and two spelling fixes. Thanks! Helge PS: All patches have been sittin

Re: [PATCH 0/2] fbdev: Prevent null-ptr-deref in fb_videomode_to_var

2025-05-29 Thread Helge Deller
On 4/28/25 17:34, Murad Masimov wrote: These patches fix the bug that leads to a null-ptr-deref if fb_videomode_to_var() fails to allocate memory. This bug is present in do_register_framebuffer() and fb_ser_var(). Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Murad Masim

Re: [PATCH] Documentation : fb : sstfb.rst : Fixed spelling mistake.

2025-05-27 Thread Helge Deller
On 5/19/25 16:38, rujra wrote: fixed document with spelling mistake changes made : 1. "tweeks" to "tweaks" Signed-off-by: Rujra Bhatt applied to fbdev tree with small changes... Thanks! Helge Documentation/fb/sstfb.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH] fbdev: core: fbcvt: avoid division by 0 in fb_cvt_hperiod()

2025-05-15 Thread Helge Deller
On 5/14/25 22:35, Sergey Shtylyov wrote: In fb_find_mode_cvt(), iff mode->refresh somehow happens to be 0x8000, cvt.f_refresh will become 0 when multiplying it by 2 due to overflow. It's then passed to fb_cvt_hperiod(), where it's used as a divider -- division by 0 will result in kernel oops.

Re: [PATCH] fbdev: fbcon: Make sure modelist not set on unregistered console

2025-05-12 Thread Helge Deller
On 5/9/25 22:06, Kees Cook wrote: It looks like attempting to write to the "store_modes" sysfs node will run afoul of unregistered consoles: UBSAN: array-index-out-of-bounds in drivers/video/fbdev/core/fbcon.c:122:28 index -1 is out of range for type 'fb_info *[32]' ... fbcon_info_from_console

Re: [PATCH] video: fbdev: arkfb: Cast ics5342_init() allocation type

2025-04-29 Thread Helge Deller
On 4/28/25 08:36, Geert Uytterhoeven wrote: Hi Kees, On Sat, 26 Apr 2025 at 13:33, Helge Deller wrote: On 4/26/25 08:23, Kees Cook wrote: In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of

Re: [PATCH] video: fbdev: arkfb: Cast ics5342_init() allocation type

2025-04-26 Thread Helge Deller
kzalloc(sizeof(struct ics5342_info), GFP_KERNEL); + struct ics5342_info *ics_info = kzalloc(sizeof(struct ics5342_info), GFP_KERNEL); + struct dac_info *info = &ics_info->dac; if (! info) Helge --- Cc: Helge Deller Cc: Javier Martinez Canillas Cc: Thomas Zimmerm

Re: [PATCH] fbdev/nvidiafb: Correct const string length in nvidiafb_setup()

2025-04-24 Thread Helge Deller
On 4/7/25 13:55, Zijun Hu wrote: From: Zijun Hu The actual length of const string "noaccel" is 7, but the strncmp() branch in nvidiafb_setup() wrongly hard codes it as 6. Fix by using actual length 7 as argument of the strncmp(). Signed-off-by: Zijun Hu --- drivers/video/fbdev/nvidia/nvidi

Re: [PATCH][next] fbdev/carminefb: Fix spelling mistake of CARMINE_TOTAL_DIPLAY_MEM

2025-04-24 Thread Helge Deller
On 4/18/25 14:51, Colin Ian King wrote: There is a spelling mistake in macro CARMINE_TOTAL_DIPLAY_MEM. Fix it. Signed-off-by: Colin Ian King --- drivers/video/fbdev/carminefb.c | 8 drivers/video/fbdev/carminefb.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) applied.

Re: [PATCH v1 1/1] atyfb: Remove unused PCI vendor ID

2025-04-24 Thread Helge Deller
On 4/24/25 13:56, Andy Shevchenko wrote: The custom definition of PCI vendor ID in video/mach64.h is unused. Remove it. Note, that the proper one is available in pci_ids.h. Signed-off-by: Andy Shevchenko --- include/video/mach64.h | 3 --- 1 file changed, 3 deletions(-) applied. Thanks! H

Re: [PATCH] fbdev: via: use new GPIO line value setter callbacks

2025-04-24 Thread Helge Deller
On 4/24/25 10:52, Linus Walleij wrote: On Tue, Apr 8, 2025 at 9:43 AM Bartosz Golaszewski wrote: From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Barto

Re: [PATCH 1/1] fbdev: atyfb: Fix buffer overflow

2025-04-01 Thread Helge Deller
On 4/1/25 10:40, Denis Arefev wrote: One small question. This chip (3D RAGE LT (Mach64 LG)) is very old it is 25 or maybe 30 years old, why is it not removed from the core? It's old, but still runs in some configurations and people still (although probably not on daily bases) use it. Also don't

[GIT PULL] fbdev updates for v6.15-rc1

2025-03-27 Thread Helge Deller
Hi Linus, please pull some updates regarding fbdev for 6.15-rc1: The fbcon packed pixel drawing routines have been refactored to bring the implementations for system and I/O memory in sync. The other patches add some parameter checks, static attribute groups for sysfs entries and console fixes.

Re: [PATCH v2] fbcon: Use static attribute groups for sysfs entries

2025-03-19 Thread Helge Deller
On 3/14/25 09:16, Thomas Zimmermann wrote: Am 14.03.25 um 07:09 schrieb oushixiong1...@163.com: From: Shixiong Ou Using device_create_with_groups() to simplify creation and removal. Same as commit 1083a7be4504 ("tty: Use static attribute groups for sysfs entries"). Signed-off-by: Shixiong Ou

Re: [PATCH] video: fbdev: sm501fb: Add some geometry checks.

2025-03-19 Thread Helge Deller
On 3/19/25 02:30, Danila Chernetsov wrote: Added checks for xoffset, yoffset settings. Incorrect settings of these parameters can lead to errors in sm501fb_pan_ functions. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 5fc404e47bdf ("[PATCH] fb: SM501 framebuffer drive

Re: [PATCH RESEND 0/2] Refactoring the fbcon packed pixel drawing routines

2025-03-19 Thread Helge Deller
On 3/9/25 19:47, Zsolt Kajtar wrote: This is the same patch as before just updated to latest fbdev master and with better description. And hopefully sent intact this time. Zsolt Kajtar (2): Refactoring the fbcon packed pixel drawing routines Adding contact info for packed pixel drawing T

Re: [PATCH 0/1] Refactoring of framebuffer drawing routines

2025-03-11 Thread Helge Deller
On 2/24/25 21:59, Zsolt Kajtar wrote: Proper refactoring of the framebuffer drawing routines. This time it's not only the merging of duplicated code. It isn't half finished either so the various combinations of foreign endianness, pixel reversing, bits per pixel, cpu word sizes and byte order sho

Re: [PATCH] Remove fb_draw.h includes

2025-03-10 Thread Helge Deller
On 3/10/25 07:57, Zsolt Kajtar wrote: This is related to the fbcon packed pixel drawing refactoring. There I missed that fb_draw.h was included from two unexpected places. That shouldn't be like that. This patch removes the dependency. Signed-off-by: Zsolt Kajtar splitted up into 2 patches an

Re: [PATCH v2] fbdev: fsl-diu-fb: add missing device_remove_file()

2025-03-09 Thread Helge Deller
On 3/9/25 09:16, Shixiong Ou wrote: From: Shixiong Ou Call device_remove_file() when driver remove. Signed-off-by: Shixiong Ou --- v1->v2: add has_sysfs_attrs flag. drivers/video/fbdev/fsl-diu-fb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/video/fbdev/fsl-d

Re: [PATCH 1/1] fbdev: hyperv_fb: Fix hang in kdump kernel when on Hyper-V Gen 2 VMs

2025-03-09 Thread Helge Deller
On 3/9/25 05:10, Michael Kelley wrote: From: Helge Deller Sent: Saturday, March 8, 2025 6:59 PM On 2/19/25 00:01, mhkelle...@gmail.com wrote: From: Michael Kelley [snip] Reported-by: Thomas Tai Fixes: c25a19afb81c ("fbdev/hyperv_fb: Do not clear global screen_info") Sig

Re: [PATCH 0/1] Refactoring of framebuffer drawing routines

2025-03-08 Thread Helge Deller
On 2/24/25 21:59, Zsolt Kajtar wrote: Proper refactoring of the framebuffer drawing routines. This time it's not only the merging of duplicated code. It isn't half finished either so the various combinations of foreign endianness, pixel reversing, bits per pixel, cpu word sizes and byte order sho

Re: [PATCH 1/1] fbdev: hyperv_fb: Fix hang in kdump kernel when on Hyper-V Gen 2 VMs

2025-03-08 Thread Helge Deller
On 2/19/25 00:01, mhkelle...@gmail.com wrote: From: Michael Kelley Gen 2 Hyper-V VMs boot via EFI and have a standard EFI framebuffer device. When the kdump kernel runs in such a VM, loading the efifb driver may hang because of accessing the framebuffer at the wrong memory address. The scenari

Re: [PATCH] fbdev: fsl-diu-fb: add missing device_remove_file()

2025-03-08 Thread Helge Deller
On 2/8/25 11:23, oushixiong1...@163.com wrote: From: Shixiong Ou Call device_remove_file() when driver remove. Signed-off-by: Shixiong Ou --- drivers/video/fbdev/fsl-diu-fb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-

Re: [PATCH] fbdev: lcdcfb: Register sysfs groups through driver core

2025-03-08 Thread Helge Deller
On 2/19/25 09:44, oushixiong1...@163.com wrote: From: Shixiong Ou [WHY] 1. The driver forgot to call device_remove_file() in sh_mobile_lcdc_overlay_fb_unregister(), and there was no error handling when calling device_create_file() failed. 2. This should probably use device_add_

Re: [PATCH 1/3] dummycon: only build module if there are users

2025-03-08 Thread Helge Deller
On 2/25/25 17:44, Arnd Bergmann wrote: From: Arnd Bergmann Dummycon is used as a fallback conswitchp for vgacon and fbcon in the VT code, and there are no references to it if all three are disabled, so just leave it out of the kernel image for configurations without those. Signed-off-by: Arnd

Re: [PATCH RESEND] video: au1100fb: Move a variable assignment behind a null pointer check in au1100fb_setmode()

2025-03-08 Thread Helge Deller
On 3/3/25 10:19, Uwe Kleine-König wrote: Hello, On Sun, Mar 02, 2025 at 07:02:12PM +0100, Markus Elfring wrote: From: Markus Elfring Date: Thu, 13 Apr 2023 21:35:36 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of t

Re: video: au1100fb: Move a variable assignment behind a null pointer check in au1100fb_setmode()

2025-03-05 Thread Helge Deller
On 3/5/25 13:14, Markus Elfring wrote: Anyway, none of that applies here, because this is just pointer math. Which data processing do you expect to be generally supported at the discussed source code place (according to the rules of the programming language “C”)? https://en.cppreference.com/w/c/

Re: [PATCH 1/3] dummycon: only build module if there are users

2025-02-26 Thread Helge Deller
On 2/26/25 12:46, Arnd Bergmann wrote: On Wed, Feb 26, 2025, at 09:16, Thomas Zimmermann wrote: Am 26.02.25 um 08:55 schrieb Arnd Bergmann: Here's another general question. vgacon and fbcon only seem usable with CONFIG_VT=y. Wouldn't it make sense to have them depend on CONFIG_VT=y? dummycon cou

Re: [PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2025-02-14 Thread Helge Deller
On 2/14/25 18:41, Ville Syrjälä wrote: On Thu, Feb 13, 2025 at 11:47:42PM +0100, Helge Deller wrote: On 2/13/25 15:42, Ville Syrjälä wrote: On Thu, Sep 26, 2024 at 12:13:04PM +0200, Helge Deller wrote: On 9/26/24 11:57, Ville Syrjälä wrote: On Thu, Sep 26, 2024 at 08:08:07AM +0200, Helge

Re: [PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2025-02-13 Thread Helge Deller
On 2/13/25 15:42, Ville Syrjälä wrote: On Thu, Sep 26, 2024 at 12:13:04PM +0200, Helge Deller wrote: On 9/26/24 11:57, Ville Syrjälä wrote: On Thu, Sep 26, 2024 at 08:08:07AM +0200, Helge Deller wrote: Hi Ville, On 9/23/24 17:57, Ville Syrjala wrote: Currently setting cursor_blink attribute

Re: [PATCH RESEND 00/13] fbdev: core: Deduplicate cfb/sys drawing fbops

2025-02-06 Thread Helge Deller
On 2/7/25 05:18, Zsolt Kajtar wrote: In 68648ed1f58d98b8e8d994022e5e25331fbfe42a the drawing routines were duplicated to have separate I/O and system memory versions. Later the pixel reversing in 779121e9f17525769c04a00475fd85600c8c04eb was only added to the I/O version and not to system. That'

Re: [RFC PATCH 00/12] Deduplicate cfb/sys drawing fbops

2025-02-03 Thread Helge Deller
CC'ed: driv-devel On 2/2/25 13:39, Kajtár Zsolt wrote: A series on de-duplicating the common cfb and sys drawing routines will follow. Some background: It happens that I need to use both cfb and sys drawing routines. For which driver do you need this? At low resolution where the aperture i

Re: [PATCH] Use correct erase colour for clearing in fbcon

2025-02-03 Thread Helge Deller
On 2/2/25 21:33, Kajtár Zsolt wrote: The erase colour calculation for fbcon clearing should use get_color instead of attr_col_ec, like everything else. The latter is similar but is not correct. For example it's missing the depth dependent remapping and doesn't care about blanking. The problem ca

Re: [PATCH] fbdev: core: tileblit: Implement missing margin clearing for tileblit

2025-02-03 Thread Helge Deller
On 2/1/25 09:18, Soci/Singular wrote: I was wondering why there's garbage at the bottom of the screen when tile blitting is used with an odd mode like 1080, 600 or 200. Sure there's only space for half a tile but the same area is clean when the buffer is bitmap. Then later I found that it's supp

[GIT PULL] fbdev fixes and cleanups for v6.14-rc1

2025-01-23 Thread Helge Deller
Hi Linus, please pull three fixes and 9 cleanup patches for fbdev for this merge window. This series prevents a possible crash and one memory leak in omapfb and fixes possible misbehaviour in vga16fb. Thanks, Helge The following c

Re: [PATCH] fbdev/sh_mobile_lcdcfb: Use backlight helper

2025-01-21 Thread Helge Deller
On 1/21/25 07:42, oushixiong1...@163.com wrote: From: Shixiong Ou Signed-off-by: Shixiong Ou --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) That patch did not apply any longer to git head. I fixed it up manually and applied it to fbde

Re: [PATCH 1/2] fbdev: omapfb: Use of_property_present() to test existence of DT property

2025-01-12 Thread Helge Deller
On 1/12/25 14:46, Krzysztof Kozlowski wrote: of_property_read_bool() should be used only on boolean properties. Cc: Rob Herring Signed-off-by: Krzysztof Kozlowski --- drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) series applied to fbdev

Re: [PATCH] fbdev: efifb: Change the return value type to void

2025-01-08 Thread Helge Deller
On 1/3/25 04:26, oushixiong1...@163.com wrote: From: Shixiong Ou efifb_setup() doesn't need to return a value. Signed-off-by: Shixiong Ou applied. Thanks! Helge

Re: [PATCH v3 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-22 Thread Helge Deller
On 12/22/24 21:50, Arnd Bergmann wrote: On Sun, Dec 22, 2024, at 21:15, Helge Deller wrote: On 12/22/24 17:09, Thomas Zimmermann wrote: +    depends on BACKLIGHT_CLASS_DEVICE=y || BACKLIGHT_CLASS_DEVICE=FB_NVIDIA Seems wrong. BACKLIGHT_CLASS_DEVICE is of type tristate. There are more of

Re: [PATCH v3 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-22 Thread Helge Deller
On 12/22/24 17:09, Thomas Zimmermann wrote: Hi Am 22.12.24 um 07:31 schrieb Helge Deller: On 12/16/24 08:42, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev

Re: [PATCH v3 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-21 Thread Helge Deller
On 12/16/24 08:42, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-21 Thread Helge Deller
On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about

Re: [PATCH] fbdev: omapfb: Remove unused hdmi5_core_handle_irqs

2024-12-21 Thread Helge Deller
On 12/18/24 02:59, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" hdmi5_core_handle_irqs() has been unused since commit f5bab2229190 ("OMAPDSS: HDMI: Add OMAP5 HDMI support") Remove it. Signed-off-by: Dr. David Alan Gilbert --- .../video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 17

Re: [PATCH] video: hdmi: Remove unused hdmi_infoframe_check

2024-12-21 Thread Helge Deller
On 12/17/24 02:38, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" hdmi_infoframe_check() has been unused since it was added in commit c5e69ab35c0d ("video/hdmi: Constify infoframe passed to the pack functions") Remove it. Note that the individual check functions for each type are act

Re: [PATCH] fbdev/udlfb: Use const 'struct bin_attribute' callback

2024-12-21 Thread Helge Deller
On 12/15/24 15:55, Thomas Weißschuh wrote: The sysfs core now provides callback variants that explicitly take a const pointer. Make use of it to match the attribute definition. Signed-off-by: Thomas Weißschuh --- drivers/video/fbdev/udlfb.c | 8 1 file changed, 4 insertions(+), 4 de

Re: [PATCH] fbdev/radeon: Use const 'struct bin_attribute' callbacks

2024-12-21 Thread Helge Deller
On 12/15/24 15:58, Thomas Weißschuh wrote: The sysfs core now provides callback variants that explicitly take a const pointer. Make use of it to match the attribute definitions. Signed-off-by: Thomas Weißschuh --- drivers/video/fbdev/aty/radeon_base.c | 8 1 file changed, 4 insertio

Re: [PATCH] fbdev/udlfb: Remove world-writability from EDID attribute

2024-12-15 Thread Helge Deller
On 12/15/24 16:15, Thomas Weißschuh wrote: It should not be possible for every user to override the EDID. Limit it to the system administrator. Fixes: 8ef8cc4fca4a ("staging: udlfb: support for writing backup EDID to sysfs file") Cc: sta...@vger.kernel.org Signed-off-by: Thomas Weißschuh --- T

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Helge Deller
On 12/13/24 00:24, Jani Nikula wrote: On Thu, 12 Dec 2024, "Arnd Bergmann" wrote: On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support wi

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Helge Deller
On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about

Re: [PATCH 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-10 Thread Helge Deller
On 12/11/24 00:53, Helge Deller wrote: On 12/11/24 00:37, Helge Deller wrote: On 12/10/24 16:41, Thomas Zimmermann wrote: Hi Am 10.12.24 um 15:34 schrieb Helge Deller: On 12/10/24 15:29, Helge Deller wrote: On 12/10/24 15:09, Thomas Zimmermann wrote: diff --git a/drivers/staging/fbtft

Re: [PATCH 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-10 Thread Helge Deller
On 12/11/24 00:37, Helge Deller wrote: On 12/10/24 16:41, Thomas Zimmermann wrote: Hi Am 10.12.24 um 15:34 schrieb Helge Deller: On 12/10/24 15:29, Helge Deller wrote: On 12/10/24 15:09, Thomas Zimmermann wrote: diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging/fbtft/Kconfig

Re: [PATCH 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-10 Thread Helge Deller
On 12/10/24 16:41, Thomas Zimmermann wrote: Hi Am 10.12.24 um 15:34 schrieb Helge Deller: On 12/10/24 15:29, Helge Deller wrote: On 12/10/24 15:09, Thomas Zimmermann wrote: diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging/fbtft/Kconfig index 77ab44362f16..577e91ff7bf6 100644

Re: [PATCH 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-10 Thread Helge Deller
On 12/10/24 15:29, Helge Deller wrote: On 12/10/24 15:09, Thomas Zimmermann wrote: diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging/fbtft/Kconfig index 77ab44362f16..577e91ff7bf6 100644 --- a/drivers/staging/fbtft/Kconfig +++ b/drivers/staging/fbtft/Kconfig @@ -3,6 +3,7

Re: [PATCH 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-10 Thread Helge Deller
On 12/10/24 15:09, Thomas Zimmermann wrote: diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging/fbtft/Kconfig index 77ab44362f16..577e91ff7bf6 100644 --- a/drivers/staging/fbtft/Kconfig +++ b/drivers/staging/fbtft/Kconfig @@ -3,6 +3,7 @@ menuconfig FB_TFT tristate "Support for sm

[GIT PULL] fbdev fixes and cleanups for v6.13-rc1

2024-11-24 Thread Helge Deller
Hi Linus, please pull two patches for fbdev for this merge window: One removes a memory leak in an error path, the other drops unused code. Thanks, Helge The following changes since commit 2d5404caa8c7bb5c4e0435f94b28834ae5456623:

Re: [PATCH] video: fbdev: metronomefb: Fix buffer overflow in load_waveform()

2024-11-14 Thread Helge Deller
On 11/12/24 21:28, Suraj Sonawane wrote: Fix an error detected by the Smatch tool: drivers/video/fbdev/metronomefb.c:220 load_waveform() error: buffer overflow 'wfm_hdr->stuff2a' 2 <= 4 drivers/video/fbdev/metronomefb.c:220 load_waveform() error: buffer overflow 'wfm_hdr->stuff2a' 2 <= 4 The ac

Re: [PATCH] fbdev: omapfb: Remove some deadcode

2024-11-14 Thread Helge Deller
On 10/27/24 00:01, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" commit f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") took a copy of the omapdrm code into omapfb, however at that point a couple of functions were already unused at that point. Remove dispc_mgr_get_clock_d

Re: [PATCH] video: sh7760fb: Fix a possible memory leak in sh7760fb_alloc_mem()

2024-11-14 Thread Helge Deller
On 10/28/24 11:41, Dmitry Baryshkov wrote: On Sat, Oct 26, 2024 at 11:56:34AM +0800, Zhen Lei wrote: When information such as info->screen_base is not ready, calling sh7760fb_free_mem() does not release memory correctly. Call dma_free_coherent() instead. Fixes: 4a25e41831ee ("video: sh7760fb: S

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-11-02 Thread Helge Deller
On 11/1/24 09:19, Thomas Zimmermann wrote: Am 30.10.24 um 10:30 schrieb Helge Deller: I'm happy to get rid of the fbdev drivers, but for that DRM really needs to allow some sort of native fillrect, copyarea and imageblt operations so that we can get performance back on the old cards

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-30 Thread Helge Deller
On 10/30/24 09:33, Thomas Zimmermann wrote: Hi Am 29.10.24 um 21:42 schrieb Helge Deller: Hi Thomas, On 10/28/24 09:41, Thomas Zimmermann wrote: Am 25.10.24 um 17:37 schrieb Helge Deller: On 10/25/24 11:25, Gonzalo Silvalde Blanco wrote: The fb_udl driver currently depends on

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-29 Thread Helge Deller
Hi Thomas, On 10/28/24 09:41, Thomas Zimmermann wrote: Am 25.10.24 um 17:37 schrieb Helge Deller: On 10/25/24 11:25, Gonzalo Silvalde Blanco wrote: The fb_udl driver currently depends on CONFIG_FB_DEVICE to create sysfs entries and access framebuffer device information. This patch wraps the

Re: [GIT PULL] fbdev late fixes for v6.12-rc5

2024-10-25 Thread Helge Deller
Hi Linus, On 10/25/24 20:31, Linus Torvalds wrote: On Fri, 25 Oct 2024 at 09:04, Helge Deller wrote: It's mostly about build warning fixes with cornercase CONFIG settings and one big patch which removes the now unused da8xx fbdev driver. So I pulled this, but only later noticed that

[GIT PULL] fbdev late fixes for v6.12-rc5

2024-10-25 Thread Helge Deller
Hi Linus, would you please pull a few late fbdev fixes ? It's mostly about build warning fixes with cornercase CONFIG settings and one big patch which removes the now unused da8xx fbdev driver. Those patches have been in for-next for the last 10 days without issues (Arnd's patch shows a later dat

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-25 Thread Helge Deller
On 10/25/24 11:25, Gonzalo Silvalde Blanco wrote: The fb_udl driver currently depends on CONFIG_FB_DEVICE to create sysfs entries and access framebuffer device information. This patch wraps the relevant code blocks with #ifdef CONFIG_FB_DEVICE, allowing the driver to be built and used even if CON

Re: [PATCH] fbdev/wm8505fb: select CONFIG_FB_IOMEM_FOPS

2024-10-18 Thread Helge Deller
On 10/18/24 17:12, Arnd Bergmann wrote: From: Arnd Bergmann The fb_io_mmap() function is used in the file operations but not enabled in all configurations unless FB_IOMEM_FOPS gets selected: ld.lld-20: error: undefined symbol: fb_io_mmap referenced by wm8505fb.c drivers/video/f

Re: [PATCH v7 0/9] of: property: add of_graph_get_next_port/port_endpoint()

2024-10-15 Thread Helge Deller
On 10/15/24 17:49, Rob Herring wrote: On Wed, Oct 09, 2024 at 01:44:30AM +, Kuninori Morimoto wrote: Hi Rob, Saravana, Tomi, Laurent, Sakari, Mark This is v7 patch-set Current Of-graph has "endpoint base" for loop, but doesn't have "port base" loop. "endpoint base" loop only is not enough

Re: [PATCH v7 7/9] gpu: drm: omapdrm: use new of_graph functions

2024-10-15 Thread Helge Deller
On 10/9/24 03:45, Kuninori Morimoto wrote: Now we can use new port related functions for port parsing. Use it. Signed-off-by: Kuninori Morimoto Reviewed-by: Tomi Valkeinen Acked-by: Helge Deller --- drivers/gpu/drm/omapdrm/dss/dpi.c | 3 ++- drivers/gpu/drm/omapdrm/dss/sdi.c | 3

  1   2   3   4   5   6   7   >