On 7/9/25 11:53, Giovanni Di Santi wrote:
This series aims to address the TODO item "Request memory regions in all
fbdev drivers" from Documentation/gpu/todo.rst.
Additionally, it also converts the kyro framebuffer driver to use managed device
functions.
In summary, it converts the driver to use:
1. Managed PCI device enable and region request functions
2. Managed ioremap for MMIO registers
3. Managed ioremap_wc for screen memory
This simplifies error handling and removes the need for manual cleanup
in the remove function.
Changes in v3:
- Split into a patch series as suggested by Thomas Zimmermann [1]
- Convert ioremap calls to devm_ variants
Changes in v2:
- Use pcim_enable_device() instead of pci_enable_device()
- Use pcim_request_all_regions() instead of pci_request_regions()
- Removed manual cleanup code as it's now automatic
[1] https://lore.kernel.org/lkml/fd6403d7-93f4-4fa4-ad0d-3ab91cba8...@suse.de/
Giovanni Di Santi (3):
fbdev: kyro: Add missing PCI memory region request
fbdev: kyro: Use devm_ioremap() for mmio registers
fbdev: kyro: Use devm_ioremap_wc() for screen mem
drivers/video/fbdev/kyro/fbdev.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
series applied to fbdev git tree.
Thanks!
Helge
