Re: [PATCH 1/1] Mark xe driver as BROKEN if kernel page size is not 4kB

2025-07-26 Thread Greg KH
On Sun, Jul 27, 2025 at 01:27:36PM +0900, Simon Richter wrote: > This driver, for the time being, assumes that the kernel page size is 4kB, > so it fails on loong64 and aarch64 with 16kB pages, and ppc64el with 64kB > pages. > --- > drivers/gpu/drm/xe/Kconfig | 2 +- > 1 file changed, 1 insertion(

Re: [PATCH 6.1.y-cip 2/5] [PARTIAL BACKPORT]drm: Add an HPD poll helper to reschedule the poll work

2025-07-23 Thread Greg KH
On Wed, Jul 23, 2025 at 03:54:24PM +0300, Nicusor Huhulea wrote: > From: Imre Deak > > Add a helper to reschedule drm_mode_config::output_poll_work after > polling has been enabled for a connector (and needing a reschedule, > since previously polling was disabled for all connectors and hence > ou

Re: [PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"

2025-07-22 Thread Greg KH
On Tue, Jul 22, 2025 at 03:22:18PM +0800, WangYuli wrote: > Hi greg k-h, > > On 2025/7/16 16:08, Greg KH wrote: > > > Signed-off-by: WangYuli > > Is your name all one word like that, or should there be a " " between > > them? > > If I were to follo

Re: [PATCH 2/9] mei: late_bind: add late binding component driver

2025-07-16 Thread Greg KH
On Wed, Jul 16, 2025 at 02:26:26PM +, Usyskin, Alexander wrote: > > > > > + if (bytes < sizeof(rsp)) { > > > > > + dev_err(dev, "bad response from the firmware: size %zd < > > > > %zu\n", > > > > > + bytes, sizeof(rsp)); > > > > > + ret = -EPROTO;

Re: [PATCH 2/9] mei: late_bind: add late binding component driver

2025-07-16 Thread Greg KH
On Wed, Jul 16, 2025 at 11:58:19AM +, Usyskin, Alexander wrote: > > Subject: Re: [PATCH 2/9] mei: late_bind: add late binding component driver > > > > On Thu, Jul 10, 2025 at 11:08:33AM -0400, Rodrigo Vivi wrote: > > > From: Alexander Usyskin > > > > > > Introduce a new MEI client driver to s

Re: [PATCH 2/9] mei: late_bind: add late binding component driver

2025-07-16 Thread Greg KH
On Thu, Jul 10, 2025 at 11:08:33AM -0400, Rodrigo Vivi wrote: > From: Alexander Usyskin > > Introduce a new MEI client driver to support Late Binding firmware > upload/update for Intel discrete graphics platforms. > > Late Binding is a runtime firmware upload/update mechanism that allows > paylo

Re: [PATCH v2 6/8] serial: 8250_dw: Fix typo "notifer"

2025-07-16 Thread Greg KH
On Tue, Jul 15, 2025 at 09:44:05PM +0800, WangYuli wrote: > There is a spelling mistake of 'notifer' in the comment which > should be 'notifier'. > > Link: > https://lore.kernel.org/all/b3c019b63c93846f+20250715071245.398846-1-wangy...@uniontech.com/ > Signed-off-by: WangYuli Is your name all o

Re: [PATCH] treewide: Fix typo "notifer"

2025-07-15 Thread Greg KH
On Tue, Jul 15, 2025 at 03:12:45PM +0800, WangYuli wrote: > There are some spelling mistakes of 'notifer' in comments which > should be 'notifier'. > > Fix them and add it to scripts/spelling.txt. > > Signed-off-by: WangYuli > --- > arch/x86/kvm/i8254.c|

Re: [PATCH v7 0/9] Introducing firmware late binding

2025-07-07 Thread Greg KH
On Tue, Jul 08, 2025 at 12:42:28AM +0530, Badal Nilawar wrote: > v7: > xe_kmd: > - resolved kernel doc warnings > mei: > - Address v6 review comments (greg kh) I don't know what comments you addressed, please be specific, as in the past other ones have not been addres

Re: [PATCH v7 2/9] mei: late_bind: add late binding component driver

2025-07-07 Thread Greg KH
On Tue, Jul 08, 2025 at 12:42:30AM +0530, Badal Nilawar wrote: > From: Alexander Usyskin > > Add late binding component driver. That says what this does, but not why, or even what "late binding" means. > It allows pushing the late binding configuration from, for example, > the Xe graphics drive

Re: [PATCH v7 1/9] mei: bus: add mei_cldev_mtu interface

2025-07-07 Thread Greg KH
On Tue, Jul 08, 2025 at 12:42:29AM +0530, Badal Nilawar wrote: > From: Alexander Usyskin > > Allow to bus client to obtain client mtu. I'm sorry, but this does not make sense. Please work on a better changelog text here after reading the kernel documentation that gives you a lot of information

Re: [PATCH v6 02/10] mei: late_bind: add late binding component driver

2025-07-04 Thread Greg KH
On Fri, Jul 04, 2025 at 12:21:42PM +, Gupta, Anshuman wrote: > > > > -Original Message- > > From: Greg KH > > Sent: Friday, July 4, 2025 5:31 PM > > To: Nilawar, Badal > > Cc: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linu

Re: [PATCH v6 02/10] mei: late_bind: add late binding component driver

2025-07-04 Thread Greg KH
On Fri, Jul 04, 2025 at 05:18:46PM +0530, Nilawar, Badal wrote: > > On 04-07-2025 16:04, Greg KH wrote: > > On Fri, Jul 04, 2025 at 03:59:40PM +0530, Nilawar, Badal wrote: > > > On 04-07-2025 10:44, Greg KH wrote: > > > > On Fri, Jul 04, 2025 at 01:0

Re: [PATCH v6 02/10] mei: late_bind: add late binding component driver

2025-07-04 Thread Greg KH
On Fri, Jul 04, 2025 at 03:59:40PM +0530, Nilawar, Badal wrote: > > On 04-07-2025 10:44, Greg KH wrote: > > On Fri, Jul 04, 2025 at 01:00:58AM +0530, Badal Nilawar wrote: > > > From: Alexander Usyskin > > > > > > Add late binding component driver. &

Re: [PATCH v1] misc: fastrpc: Add support for userspace allocated buffers

2025-07-04 Thread Greg KH
On Fri, Jul 04, 2025 at 02:07:26PM +0530, Ekansh Gupta wrote: > Support mapping userspace allocated buffers. If userspace allocates a > buffer using rpcmem or DMABUF and sends it via a map request, fastrpc > will map it to SMMU and DSP. Add support for both map and unmap > requests. > > Signed-off

Re: [PATCH v6 02/10] mei: late_bind: add late binding component driver

2025-07-03 Thread Greg KH
On Fri, Jul 04, 2025 at 01:00:58AM +0530, Badal Nilawar wrote: > From: Alexander Usyskin > > Add late binding component driver. > It allows pushing the late binding configuration from, for example, > the Xe graphics driver to the Intel discrete graphics card's CSE device. > > Signed-off-by: Alex

Re: [PATCH v4 1/2] Revert "staging: fbtft: fix potential memory leak in fbtft_framebuffer_alloc()"

2025-07-01 Thread Greg KH
On Tue, Jul 01, 2025 at 05:16:07PM +0300, Dan Carpenter wrote: > On Tue, Jul 01, 2025 at 04:48:45PM +0300, Andy Shevchenko wrote: > > On Tue, Jul 01, 2025 at 03:10:22PM +0530, Abdun Nihaal wrote: > > > This reverts commit eb2cb7dab60f ("staging: fbtft: fix potential memory > > > leak in fbtft_frame

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-07-01 Thread Greg KH
On Tue, Jul 01, 2025 at 02:02:15PM +0530, Nilawar, Badal wrote: > On 28-06-2025 17:48, Greg KH wrote: > > > + * @payload_size: size of the payload data in bytes > > > + * @payload: data to be sent to the firmware > > > + */ > > > +struct csc_heci_late_bind_r

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-07-01 Thread Greg KH
On Tue, Jul 01, 2025 at 01:37:36PM +0530, Nilawar, Badal wrote: > > On 28-06-2025 17:49, Greg KH wrote: > > On Wed, Jun 25, 2025 at 10:30:07PM +0530, Badal Nilawar wrote: > > > +/** > > > + * struct late_bind_component_ops - ops for Late Binding services. > >

Re: [PATCH v3 2/2] staging: fbtft: cleanup error handling in fbtft_framebuffer_alloc()

2025-06-30 Thread Greg KH
On Tue, Jul 01, 2025 at 12:47:22AM +0530, Abdun Nihaal wrote: > Hello Greg, > > On Mon, Jun 30, 2025 at 07:16:38PM +0200, Greg KH wrote: > > This patch does not apply to my tree, can you rebase and resend? > > I think you have added both the V1 patch and this current V3 pa

Re: [PATCH v3 2/2] staging: fbtft: cleanup error handling in fbtft_framebuffer_alloc()

2025-06-30 Thread Greg KH
On Sun, Jun 29, 2025 at 08:10:11PM +0530, Abdun Nihaal wrote: > The error handling in fbtft_framebuffer_alloc() mixes managed allocation > and plain allocation, and performs error handling in an order different > from the order in fbtft_framebuffer_release(). > > Fix them by moving vmem allocation

Re: [PATCH] drm/bridge: it6505: replace scnprintf with sysfs_emit_at in debugfs show

2025-06-29 Thread Greg KH
On Sun, Jun 29, 2025 at 08:35:09PM -0300, Marcelo Moreira wrote: > Update the receive_timing_debugfs_show() function to utilize > sysfs_emit_at() for formatting output to the debugfs buffer. > This change adheres to the recommendation outlined > in Documentation/filesystems/sysfs.rst. > > This mod

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-06-28 Thread Greg KH
On Wed, Jun 25, 2025 at 10:30:07PM +0530, Badal Nilawar wrote: > +/** > + * struct late_bind_component_ops - ops for Late Binding services. > + * @owner: Module providing the ops > + * @push_config: Sends a config to FW. > + */ > +struct late_bind_component_ops { > + struct module *owner; I do

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-06-28 Thread Greg KH
On Wed, Jun 25, 2025 at 10:30:07PM +0530, Badal Nilawar wrote: > --- /dev/null > +++ b/drivers/misc/mei/late_bind/mei_late_bind.c > @@ -0,0 +1,281 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2025 Intel Corporation > + */ > +#include > +#include > +#include > +#include >

Re: [PATCH] drm/vkms: Fix race-condition between the hrtimer and the atomic commit

2025-06-26 Thread Greg KH
On Thu, Jun 26, 2025 at 07:52:43PM +0530, Pranav Tyagi wrote: > From: Maíra Canal > > [ Upstream commit a0e6a017ab56936c0405fe914a793b241ed25ee0 ] > > Currently, it is possible for the composer to be set as enabled and then > as disabled without a proper call for the vkms_vblank_simulate(). This

Re: [PATCH v2] misc: fastrpc: Fix channel resource access in device_open

2025-06-25 Thread Greg KH
On Wed, Jun 25, 2025 at 02:45:27AM +0300, Dmitry Baryshkov wrote: > On Tue, Jun 24, 2025 at 04:38:25PM +0100, Greg KH wrote: > > On Tue, Jun 24, 2025 at 04:36:35PM +0100, Greg KH wrote: > > > On Tue, Jun 24, 2025 at 04:27:21PM +0300, Dmitry Baryshkov wrote: > > > >

Re: [PATCH v2] misc: fastrpc: Fix channel resource access in device_open

2025-06-24 Thread Greg KH
On Tue, Jun 24, 2025 at 04:27:21PM +0300, Dmitry Baryshkov wrote: > On Thu, Jun 19, 2025 at 10:40:26AM +0530, Ekansh Gupta wrote: > > During rpmsg_probe, fastrpc device nodes are created first, then > > channel specific resources are initialized, followed by > > of_platform_populate, which triggers

Re: [PATCH v2] misc: fastrpc: Fix channel resource access in device_open

2025-06-24 Thread Greg KH
On Tue, Jun 24, 2025 at 04:36:35PM +0100, Greg KH wrote: > On Tue, Jun 24, 2025 at 04:27:21PM +0300, Dmitry Baryshkov wrote: > > On Thu, Jun 19, 2025 at 10:40:26AM +0530, Ekansh Gupta wrote: > > > During rpmsg_probe, fastrpc device nodes are created first, then > > > cha

Re: [PATCH v12 3/6] rust: enable `clippy::as_ptr_cast_mut` lint

2025-06-18 Thread Greg KH
On Wed, Jun 18, 2025 at 07:29:25PM +0200, Miguel Ojeda wrote: > On Sun, Jun 15, 2025 at 10:55 PM Tamir Duberstein wrote: > > > > rust/kernel/devres.rs | 2 +- > > Danilo, Greg: for completeness: if you don't want this, please shout. Thanks! Acked-by: Greg Kroah-Hartman

Re: [PATCH v12 4/6] rust: enable `clippy::as_underscore` lint

2025-06-18 Thread Greg KH
On Wed, Jun 18, 2025 at 07:04:11PM +0200, Miguel Ojeda wrote: > On Wed, Jun 18, 2025 at 3:51 PM Tamir Duberstein wrote: > > > > @Danilo Krummrich could you please have a look for nova? > > Alice, Christian, Danilo, Greg, Tejun: it would also be nice to get > Acked-by's for your (other) bits. Ack

Re: [PATCH] rust: module: remove deprecated author key

2025-06-10 Thread Greg KH
On Mon, Jun 09, 2025 at 07:47:55PM +0200, Danilo Krummrich wrote: > On 09.06.2025 19:39, Miguel Ojeda wrote: > > On Mon, Jun 9, 2025 at 2:22 PM Guilherme Giacomo Simoes > > wrote: > >> > >> Now that all in-tree modules have migrated to `authors`, remove: > > > > Nit: I would have said "most modul

Re: [PATCH] Revert "drm/amd/display: more liberal vmin/vmax update for freesync"

2025-06-04 Thread Greg KH
On Wed, Jun 04, 2025 at 09:15:14AM -0400, Alex Deucher wrote: > On Wed, Jun 4, 2025 at 5:40 AM Uwe Kleine-König > wrote: > > > > Hello Alex, > > > > On Fri, May 30, 2025 at 04:14:09PM -0400, Alex Deucher wrote: > > > On Fri, May 30, 2025 at 4:09 PM Aurabindo Pillai > > > wrote: > > > > > > > > Th

Re: [PATCH 6.1.y v2 1/2] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions

2025-05-20 Thread Greg KH
On Wed, May 21, 2025 at 09:21:09AM +0800, jianqi.ren...@windriver.com wrote: > From: Vinod Polimera > > [ Upstream commit c0cd12a5d29fa36a8e2ebac7b8bec50c1a41fb57 ] > > Use atomic variants for encoder callback functions such that > certain states like self-refresh can be accessed as part of > en

Re: [PATCH 6.1.y 1/2] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions

2025-05-20 Thread Greg KH
On Mon, May 12, 2025 at 11:31:16AM +0800, jianqi.ren...@windriver.com wrote: > From: Vinod Polimera > > [ Upstream commit c0cd12a5d29fa36a8e2ebac7b8bec50c1a41fb57 ] > > Use atomic variants for encoder callback functions such that > certain states like self-refresh can be accessed as part of > en

Re: [PATCH 1/3] samples: rust: select AUXILIARY_BUS instead of depending on it

2025-05-15 Thread Greg KH
On Thu, May 15, 2025 at 03:26:13PM +0900, Alexandre Courbot wrote: > CONFIG_AUXILIARY_BUS cannot be enabled explicitly, and unless we select > it we have no way to include it (and thus to enable the auxiliary driver > sample) unless a driver happens to do it for us. > > Signed-off-by: Alexandre Co

Re: [PATCH v1 4/4] misc: fastrpc: Add debugfs support for fastrpc

2025-04-21 Thread Greg KH
On Mon, Apr 21, 2025 at 01:51:09PM +0530, Deepika Singh wrote: > > > On 4/15/2025 6:47 PM, Greg KH wrote: > > On Mon, Apr 14, 2025 at 12:41:47PM +0530, Deepika Singh wrote: > > > > > > > > > On 4/11/2025 1:55 PM, Ekansh Gupta wrote: > > &g

Re: [PATCH v1 4/4] misc: fastrpc: Add debugfs support for fastrpc

2025-04-15 Thread Greg KH
> > > > > > > > > > On 12/2/2024 6:18 PM, Dmitry Baryshkov wrote: > > > > > On Mon, Dec 02, 2024 at 03:27:43PM +0530, Ekansh Gupta wrote: > > > > > > On 11/22/2024 12:23 AM, Dmitry Baryshkov wrote: > > > > > > > On Th

Re: [PATCH v4 9/9] drm/vkms: convert to use faux_device

2025-03-11 Thread Greg KH
On Tue, Mar 11, 2025 at 06:20:53PM +0100, José Expósito wrote: > Hi everyone, > > > On Tue, Feb 25, 2025 at 02:51:40PM +0100, Louis Chauvet wrote: > > > > > > > > > Le 25/02/2025 à 12:41, Thomas Zimmermann a écrit : > > > > Hi > > > > > > > > Am 10.02.25 um 15:37 schrieb Louis Chauvet: > > > >

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-07 Thread Greg KH
On Fri, Mar 07, 2025 at 10:46:29AM -0400, Jason Gunthorpe wrote: > On Fri, Mar 07, 2025 at 03:00:09PM +0100, Greg KH wrote: > > On Fri, Mar 07, 2025 at 08:32:55AM -0400, Jason Gunthorpe wrote: > > > On Fri, Mar 07, 2025 at 11:28:37AM +0100, Simona Vetter wrote: > > >

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-07 Thread Greg KH
On Fri, Mar 07, 2025 at 08:32:55AM -0400, Jason Gunthorpe wrote: > On Fri, Mar 07, 2025 at 11:28:37AM +0100, Simona Vetter wrote: > > > > I wouldn't say it is wrong. It is still the correct thing to do, and > > > following down the normal cleanup paths is a good way to ensure the > > > special cas

Re: [PATCH v5 0/5] Initial Nova Core series

2025-03-05 Thread Greg KH
On Wed, Mar 05, 2025 at 08:56:42PM +0100, Danilo Krummrich wrote: > On Tue, Mar 04, 2025 at 06:34:47PM +0100, Danilo Krummrich wrote: > > Danilo Krummrich (5): > > rust: module: add type `LocalModule` > > rust: firmware: introduce `firmware::ModInfoBuilder` > > rust: firmware: add `module_fir

Re: [PATCH 6.1.y] drm/amd/display: fixed integer types and null check locations

2025-03-05 Thread Greg KH
On Thu, Feb 27, 2025 at 11:26:33AM +0800, jianqi.ren...@windriver.com wrote: > From: Sohaib Nadeem > > [ Upstream commit 0484e05d048b66d01d1f3c1d2306010bb57d8738 ] > > [why]: > issues fixed: > - comparison with wider integer type in loop condition which can cause > infinite loops > - pointer der

Re: [PATCH 1/2] drivers: base: component: add function to query the bound status

2025-02-27 Thread Greg KH
On Thu, Feb 27, 2025 at 09:44:23AM +0100, Heiko Stübner wrote: > Hi Greg, > > Am Freitag, 21. Februar 2025, 07:14:07 MEZ schrieb Greg KH: > > On Fri, Feb 21, 2025 at 12:41:40AM +0100, Heiko Stuebner wrote: > > > The component helpers already expose the bound status in deb

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-26 Thread Greg KH
On Wed, Feb 26, 2025 at 07:47:30PM -0400, Jason Gunthorpe wrote: > The way misc device works you can't unload the module until all the > FDs are closed and the misc code directly handles races with opening > new FDs while modules are unloading. It is quite a different scheme > than discussed in thi

Re: [PATCH 1/2] drivers: base: component: add function to query the bound status

2025-02-20 Thread Greg KH
On Fri, Feb 21, 2025 at 12:41:40AM +0100, Heiko Stuebner wrote: > The component helpers already expose the bound status in debugfs, but at > times it might be necessary to also check that state in the kernel and > act differently depending on the result. > > For example the shutdown handler of a d

Re: [PATCH v2 2/2] drm/draw: include bug.h

2025-02-20 Thread Greg KH
On Fri, Feb 21, 2025 at 10:38:04AM +0530, Raag Jadav wrote: > Directly include bug.h for WARN() helpers instead of relying on > intermediate headers. > > Signed-off-by: Raag Jadav > --- > drivers/gpu/drm/drm_draw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_dra

Re: [PATCH 00/63] Fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y

2025-02-20 Thread Greg KH
On Fri, Jan 24, 2025 at 11:45:14PM -0700, Jim Cromie wrote: > This series fixes dynamic-debug's support for DRM debug-categories. > Classmaps-v1 evaded full review, and got committed in 2 chunks: > > b7b4eebdba7b..6ea3bf466ac6 # core dyndbg changes > 0406faf25fb1..ee7d633f2dfb # drm adoption

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-18 Thread Greg KH
On Mon, Feb 17, 2025 at 04:48:13PM +0100, Simona Vetter wrote: > On Mon, Feb 17, 2025 at 11:04:45PM +0900, Alexandre Courbot wrote: > > Hi everyone, > > > > This short RFC is based on top of Danilo's initial driver stub series > > [1] and has for goal to initiate discussions and hopefully some des

Re: [PATCH v3 1/2] gpu: nova-core: add initial driver stub

2025-02-09 Thread Greg KH
On Sun, Feb 09, 2025 at 06:30:24PM +0100, Danilo Krummrich wrote: > +config NOVA_CORE > + tristate "Nova Core GPU driver" > + depends on PCI > + depends on RUST > + depends on RUST_FW_LOADER_ABSTRACTIONS > + default n Tiny nit, if you happen to respin this, "default n" is alway

Re: On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-07 Thread Greg KH
On Fri, Feb 07, 2025 at 07:20:03PM +0900, Hector Martin wrote: > And I do believe the fact that essentially all high-level Linux kernel > maintainers and contributors are paid by corporations to do it is a > major factor that has caused this community to become wildly out of > touch with what it me

Re: [PATCH 1/2] gpu: nova-core: add initial driver stub

2025-02-01 Thread Greg KH
On Sat, Feb 01, 2025 at 01:12:35PM +0100, Danilo Krummrich wrote: > On Sat, Feb 01, 2025 at 09:33:28AM +0100, Greg KH wrote: > > On Fri, Jan 31, 2025 at 11:04:24PM +0100, Danilo Krummrich wrote: > > > +impl Gpu { > > > +pub(crate) fn new(pdev: &pci::Device

Re: [PATCH 1/2] gpu: nova-core: add initial driver stub

2025-02-01 Thread Greg KH
On Fri, Jan 31, 2025 at 11:04:24PM +0100, Danilo Krummrich wrote: > +impl Gpu { > +pub(crate) fn new(pdev: &pci::Device, bar: Devres) -> Result PinInit> { > +let spec = GpuSpec::new(&bar)?; > +let fw = Firmware::new(pdev.as_ref(), &spec, "535.113.01")?; > + > +dev_info!(

Re: [PATCH] drm/amd/display: Increase sanitizer frame larger than limit when compile testing with clang

2025-01-29 Thread Greg KH
On Thu, Jan 30, 2025 at 07:47:59AM +0100, Greg KH wrote: > On Mon, Jan 06, 2025 at 12:29:32PM -0500, Alex Deucher wrote: > > Applied. Thanks! > > Thanks, but I am still getting this error on Linus's current tree right > now, with this commit applied: > > CC [M

Re: [PATCH] drm/amd/display: Increase sanitizer frame larger than limit when compile testing with clang

2025-01-29 Thread Greg KH
On Mon, Jan 06, 2025 at 12:29:32PM -0500, Alex Deucher wrote: > Applied. Thanks! Thanks, but I am still getting this error on Linus's current tree right now, with this commit applied: CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.o drivers/gpu/drm/amd/amdgpu/../displa

Re: Patch "drm/radeon: Delay Connector detecting when HPD singals is unstable" has been added to the 6.6-stable tree

2025-01-17 Thread Greg KH
On Fri, Jan 17, 2025 at 04:11:31PM +0100, Simona Vetter wrote: > On Wed, Jan 08, 2025 at 12:02:03AM +, Deucher, Alexander wrote: > > [Public] > > > > > -Original Message- > > > From: Sasha Levin > > > Sent: Thursday, January 2, 2025 7:42 PM > > > To: stable-comm...@vger.kernel.org; ou

Re: AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-17 Thread Greg KH
On Fri, Jan 17, 2025 at 12:01:01PM +0100, Uwe Kleine-König wrote: > On Sun, Jan 12, 2025 at 10:06:42PM +0100, Greg KH wrote: > > That's fine, the issue is that you are the only ones with "duplicate" > > commits in the tree that are both tagged for stable, every rel

Re: AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-16 Thread Greg KH
gt; On Wed, Jan 15, 2025 at 10:38:34AM +0100, Greg KH wrote: > > > > So my understanding is that you got confused by this: > > > > > > > > > commit 55039832f98c7e05f1cf9e0d8c12b2490abd0f16 upstream > > > > > > > > $ git log --grep=&qu

Re: AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-15 Thread Greg KH
On Wed, Jan 15, 2025 at 10:07:47AM +0100, Simona Vetter wrote: > On Tue, Jan 14, 2025 at 06:31:26PM +0100, Simona Vetter wrote: > > On Tue, Jan 14, 2025 at 10:51:54AM -0500, Sasha Levin wrote: > > > On Tue, Jan 14, 2025 at 04:03:09PM +0100, Simona Vetter wrote: > > > > On Tue, Jan 14, 2025 at 11:01

Re: AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-15 Thread Greg KH
On Tue, Jan 14, 2025 at 11:11:42AM -0500, Alex Deucher wrote: > On Tue, Jan 14, 2025 at 11:02 AM Sasha Levin wrote: > > > > On Tue, Jan 14, 2025 at 04:03:09PM +0100, Simona Vetter wrote: > > >On Tue, Jan 14, 2025 at 11:01:34AM +1000, Dave Airlie wrote: > > >> > > > We create a "web" when we backpo

Re: AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-15 Thread Greg KH
On Tue, Jan 14, 2025 at 11:22:26AM +0200, Jani Nikula wrote: > On Tue, 14 Jan 2025, Dave Airlie wrote: > > On Sun, 12 Jan 2025 at 22:19, Greg KH wrote: > >> > >> On Fri, Jan 10, 2025 at 12:53:41PM -0800, Umesh Nerlige Ramappa wrote: > >> > commit 55039832f9

Re: AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-13 Thread Greg KH
On Mon, Jan 13, 2025 at 10:44:41AM +1000, Dave Airlie wrote: > On Mon, 13 Jan 2025 at 07:09, Greg KH wrote: > > > > On Mon, Jan 13, 2025 at 06:01:51AM +1000, Dave Airlie wrote: > > > On Mon, 13 Jan 2025 at 05:51, Dave Airlie wrote: > > > > > >

Re: AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-12 Thread Greg KH
On Mon, Jan 13, 2025 at 06:01:51AM +1000, Dave Airlie wrote: > On Mon, 13 Jan 2025 at 05:51, Dave Airlie wrote: > > > > On Sun, 12 Jan 2025 at 22:19, Greg KH wrote: > > > > > > On Fri, Jan 10, 2025 at 12:53:41PM -0800, Umesh Nerl

Re: AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-12 Thread Greg KH
On Mon, Jan 13, 2025 at 05:51:30AM +1000, Dave Airlie wrote: > On Sun, 12 Jan 2025 at 22:19, Greg KH wrote: > > > > On Fri, Jan 10, 2025 at 12:53:41PM -0800, Umesh Nerlige Ramappa wrote: > > > commit 55039832f98c7e05f1cf9e0d8c12b2490abd0f16 upstream > > > > &g

AAARRRGGGHHH!!!! (was Re: [PATCH 6.12.y] xe/oa: Fix query mode of operation for OAR/OAC)

2025-01-12 Thread Greg KH
On Fri, Jan 10, 2025 at 12:53:41PM -0800, Umesh Nerlige Ramappa wrote: > commit 55039832f98c7e05f1cf9e0d8c12b2490abd0f16 upstream > Fixes: 8135f1c09dd2 ("drm/xe/oa: Don't reset OAC_CONTEXT_ENABLE on OA stream > close") > Signed-off-by: Umesh Nerlige Ramappa > Reviewed-by: Matthew Brost # comm

Re: [PATCH] misc: fastrpc: Fix race condition in MUNMAP

2025-01-07 Thread Greg KH
On Wed, Jan 08, 2025 at 10:18:02AM +0530, Ling Xu wrote: > fastrpc_req_munmap involves two steps to unmap memory, first to locates > a matching fastrpc buf in the list and second is to send request to DSP > to unmap. There is a potential race condition between two operations > which can lead to use

Re: [PATCH v2 1/2] misc: fastrpc: Deregister device nodes properly in error scenarios

2024-12-23 Thread Greg KH
On Mon, Dec 23, 2024 at 03:31:00PM +0530, Anandu Krishnan E wrote: > During fastrpc_rpmsg_probe, if secure device node registration > succeeds but non-secure device node registration fails, the secure > device node deregister is not called during error cleanup. Add proper > exit paths to ensure pro

Re: [PATCH] drm/i915: Update license on selftest lists to MIT

2024-12-13 Thread Greg KH
On Thu, Dec 12, 2024 at 10:10:54AM -0500, Ed Maste wrote: > On Wed, 11 Dec 2024 at 02:25, Greg KH wrote: > > > > On Tue, Dec 10, 2024 at 06:19:00PM -0500, Rodrigo Vivi wrote: > > > On Sun, Dec 08, 2024 at 03:17:27PM +, Ed Maste wrote: > > > > Th

Re: [PATCH 6.1.y] drm/amd/display: Don't refer to dc_sink in is_dsc_need_re_compute

2024-12-12 Thread Greg KH
On Wed, Dec 11, 2024 at 06:15:44PM +0800, jianqi.ren...@windriver.com wrote: > From: Wayne Lin > > [ Upstream commit fcf6a49d79923a234844b8efe830a61f3f0584e4 ] > > [Why] > When unplug one of monitors connected after mst hub, encounter null pointer > dereference. > > It's due to dc_sink get rel

Re: [PATCH] drm/i915: Update license on selftest lists to MIT

2024-12-10 Thread Greg KH
t commit here that these files are a trivial part of an otherwise > > MIT-licensed patch to a MIT-licensed component, and should have an MIT > > license. No, that is not clear, by default, anything without a license gets the GPL2 license as that is the license of the entire body of cod

Re: [PATCH] staging: fbtft: Remove unnecessary parentheses

2024-12-10 Thread Greg KH
On Tue, Dec 10, 2024 at 02:18:48PM +, Antonio Riccio wrote: > Adhere to Linux kernel coding style. > > Reported by checkpatch: > > CHECK: Unnecessary parentheses around 'devcode != 0x' > CHECK: Unnecessary parentheses around 'devcode != 0x9320' > > Signed-off-by: Antonio Riccio > --- >

Re: [PATCH v1 4/4] misc: fastrpc: Add debugfs support for fastrpc

2024-11-21 Thread Greg KH
On Thu, Nov 21, 2024 at 12:12:17PM +0530, Ekansh Gupta wrote: > On 11/18/2024 7:32 PM, Greg KH wrote: > > On Mon, Nov 18, 2024 at 02:10:46PM +0530, Ekansh Gupta wrote: > >> + /* > >> + * Use HLOS process name, HLOS PID, fastrpc user TGID, > >>

Re: [PATCH v1 4/4] misc: fastrpc: Add debugfs support for fastrpc

2024-11-18 Thread Greg KH
On Mon, Nov 18, 2024 at 02:10:46PM +0530, Ekansh Gupta wrote: > Add changes to support debugfs. The fastrpc directory will be > created which will carry debugfs files for all fastrpc processes. > The information of fastrpc user and channel contexts are getting > captured as part of this change. >

Re: [PATCH v1 3/4] misc: fastrpc: Introduce fastrpc_shared.h header

2024-11-18 Thread Greg KH
On Mon, Nov 18, 2024 at 02:10:45PM +0530, Ekansh Gupta wrote: > Move fastrpc structures and MACRO definitions to a new header file. > These definitions are consumed by other upcoming features like > debugfs, PDR support etc. > > Signed-off-by: Ekansh Gupta > --- > drivers/misc/fastrpc/fastrpc_ma

Re: [PATCH v1 2/4] misc: fastrpc: Rename fastrpc.c to fastrpc_main.c

2024-11-18 Thread Greg KH
On Mon, Nov 18, 2024 at 02:10:44PM +0530, Ekansh Gupta wrote: > Rename the main fastrpc source file to accomodate new files to be > compiled in the same kernel object. > > Signed-off-by: Ekansh Gupta > --- > drivers/misc/fastrpc/Makefile | 1 + > drivers/misc/fastrpc/{fastrp

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-05 Thread Greg KH
On Thu, Oct 24, 2024 at 09:19:41PM +0800, Yu Kuai wrote: > From: Yu Kuai > > Fix patch is patch 27, relied patches are from: > > - patches from set [1] to add helpers to maple_tree, the last patch to > improve fork() performance is not backported; So things slowed down? > - patches from set

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-21 Thread Greg KH
On Mon, Oct 21, 2024 at 08:58:30AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Mon, Oct 21, 2024 at 8:39 AM Greg KH wrote: > > On Sun, Oct 20, 2024 at 05:36:29PM +0300, Laurent Pinchart wrote: > > > On Fri, Oct 18, 2024 at 04:31:21PM +0200, Greg KH wrote: > &g

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-20 Thread Greg KH
On Sun, Oct 20, 2024 at 05:36:29PM +0300, Laurent Pinchart wrote: > On Fri, Oct 18, 2024 at 04:31:21PM +0200, Greg KH wrote: > > On Fri, Oct 18, 2024 at 05:25:22PM +0300, Laurent Pinchart wrote: > > > On Fri, Oct 18, 2024 at 04:09:26PM +0200, Greg KH wrote: > > > >

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-18 Thread Greg KH
On Fri, Oct 18, 2024 at 05:25:22PM +0300, Laurent Pinchart wrote: > Hi Greg, > > On Fri, Oct 18, 2024 at 04:09:26PM +0200, Greg KH wrote: > > On Fri, Oct 18, 2024 at 03:36:48PM +0200, Geert Uytterhoeven wrote: > > > On Fri, Oct 18, 2024 at 3:10 PM Laurent Pinchart wrote

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-18 Thread Greg KH
On Fri, Oct 18, 2024 at 03:36:48PM +0200, Geert Uytterhoeven wrote: > Hi Laurent, > > CC GregKH > > On Fri, Oct 18, 2024 at 3:10 PM Laurent Pinchart > wrote: > > On Fri, Oct 18, 2024 at 09:45:52AM +0200, Geert Uytterhoeven wrote: > > > Each bridge instance creates up to four auxiliary devices wi

Re: [PATCH 6.1.y 5.15.y] drm/shmem-helper: Fix BUG_ON() on mmap(PROT_WRITE, MAP_PRIVATE)

2024-10-18 Thread Greg KH
On Thu, Oct 17, 2024 at 10:18:29AM -0700, Sherry Yang wrote: > From: "Wachowski, Karol" > > commit 39bc27bd688066a63e56f7f64ad34fae03fbe3b8 upstream. Now queued up, thanks. greg k-h

Re: Patch "drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job" has been added to the 6.10-stable tree

2024-10-08 Thread Greg KH
On Mon, Oct 07, 2024 at 08:23:54PM +0200, Christian König wrote: > Am 07.10.24 um 19:59 schrieb Greg KH: > > On Mon, Oct 07, 2024 at 07:53:26PM +0200, Christian König wrote: > > > Hi Greg, > > > > > > please drop this patch from all backports. It turned out to

Re: [PATCH 6.6.y] Revert "drm/amd/display: Skip Recompute DSC Params if no Stream on Link"

2024-10-08 Thread Greg KH
On Mon, Oct 07, 2024 at 02:57:11PM +1100, Jonathan Gray wrote: > This reverts commit a53841b074cc196c3caaa37e1f15d6bc90943b97. > > duplicated a change made in 6.6.46 > 718d83f66fb07b2cab89a1fc984613a00e3db18f > > Cc: sta...@vger.kernel.org # 6.6 > Signed-off-by: Jonathan Gray > --- > drivers/gp

Re: Patch "drm/sched: Always wake up correct scheduler in drm_sched_entity_push_job" has been added to the 6.10-stable tree

2024-10-07 Thread Greg KH
On Mon, Oct 07, 2024 at 07:53:26PM +0200, Christian König wrote: > Hi Greg, > > please drop this patch from all backports. It turned out to be broken and > the old handling has been restored by a revert. > > Sorry for the noise. The revert should show up in Linus tree by the end of > the week. W

Re: [PATCH v9 0/2] Add driver for Sharp Memory LCD

2024-10-07 Thread Greg KH
On Mon, Oct 07, 2024 at 11:34:13AM +0200, Markus Elfring wrote: > > This patch series add support for the monochrome Sharp Memory LCD panels. > … > > --- > > Changes in v9: > … > > Would you like to benefit from the application of scope-based resource > management > (also for this software compon

Re: [PATCH v1 2/4] misc: fastrpc: Capture kernel and DSP performance counters

2024-10-07 Thread Greg KH
On Mon, Oct 07, 2024 at 02:15:16PM +0530, Ekansh Gupta wrote: > Add support to capture kernel performance counters for different > kernel level operations. These counters collects the information > for remote call and copies the information to a buffer shared > by user. > > Collection of DSP perfo

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread Greg KH
On Mon, Oct 07, 2024 at 02:15:15PM +0530, Ekansh Gupta wrote: > +struct fastrpc_invoke_v2 { > + struct fastrpc_invoke inv; > + __u64 crc; > + __u32 reserved[16]; I'm sure we have been over this before, but if you have a reserved field, you HAVE to check that it is zero if you ever want

Re: [PATCH v8 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-10-02 Thread Greg KH
On Wed, Oct 02, 2024 at 10:56:42AM +0200, Markus Elfring wrote: > … > > +++ b/drivers/gpu/drm/tiny/sharp-memory.c > > @@ -0,0 +1,681 @@ > … > > +static int sharp_memory_maintain_display(struct sharp_memory_device *smd) > > +{ > … > > + u8 *tx_buffer = smd->tx_buffer; > > + > > + mutex_lock(&smd

Re: [PATCH 5.10] drm/vmwgfx: Remove rcu locks from user resources

2024-09-27 Thread Greg KH
On Sat, Sep 21, 2024 at 02:48:04PM +0800, Huang Xiaojia wrote: > [ Upstream commit a309c7194e8a2f8bd4539b9449917913f6c2cd50 ] We can't take this until you submit backports for newer kernels also. Please send for all affected kernels, thanks. greg k-h

Re: [RESEND PATCH v4] devres: Refactor using guards

2024-09-11 Thread Greg KH
Converting working code for no real reason other than "let's change this!" isn't always a good idea. For new code going forward, or if you are touching the same area, sure, that makes sense, but be careful about stuff like this. > Signed-off-by: Andrea Calabrese > >

Re: [PATCH] fbdev/xen-fbfront: Assign fb_info->device

2024-09-10 Thread Greg KH
On Tue, Sep 10, 2024 at 02:18:35PM +0200, Arthur Borsboom wrote: > On Tue, 10 Sept 2024 at 10:33, Greg KH wrote: > > > > On Tue, Sep 10, 2024 at 10:13:01AM +0200, Roger Pau Monné wrote: > > > On Tue, Sep 10, 2024 at 09:29:30AM +0200, Thomas Zimmermann wrote: > > >

Re: [PATCH] fbdev/xen-fbfront: Assign fb_info->device

2024-09-10 Thread Greg KH
On Tue, Sep 10, 2024 at 10:13:01AM +0200, Roger Pau Monné wrote: > On Tue, Sep 10, 2024 at 09:29:30AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 10.09.24 um 09:22 schrieb Roger Pau Monné: > > > On Mon, Sep 09, 2024 at 10:09:16PM -0400, Jason Andryuk wrote: > > > > From: Jason Andryuk > > >

Re: [PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-09-08 Thread Greg KH
On Fri, Sep 06, 2024 at 11:02:32AM -0400, Alex Deucher wrote: > On Fri, Sep 6, 2024 at 4:50 AM Mukul Sikka wrote: > > > > On Fri, Sep 6, 2024 at 12:05 AM Alex Deucher wrote: > > > > > > On Tue, Sep 3, 2024 at 5:53 AM sikkamukul > > > wrote: > > > > > > > > From: Bob Zhou > > > > > > > > [ Upst

Re: [PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-09-05 Thread Greg KH
On Tue, Sep 03, 2024 at 04:58:09AM +, sikkamukul wrote: > From: Bob Zhou > > [ Upstream commit 50151b7f1c79a09117837eb95b76c2de76841dab ] > > Check return value and conduct null pointer handling to avoid null pointer > dereference. > > Signed-off-by: Bob Zhou > Reviewed-by: Tim Huang > S

Re: [PATCH v2] drm/imx/ipuv3: ipuv3-plane: Round up plane width for IPUV3_CHANNEL_MEM_DC_SYNC

2024-09-04 Thread Greg KH
On Wed, Sep 04, 2024 at 04:48:51PM +0800, Liu Ying wrote: > On 09/04/2024, Paul Pu wrote: > > Cc: sta...@vger.kernel.org # 5.15+ > > Why 5.15+ ? Because the commit referenced in Fixes: was backported there. If you want to be picky, just drop the "# 5.15+" and our tools will rely on the Fixes: ta

Re: [PATCH] drm: imx: ipuv3-plane: fix HDMI cannot work for odd screen resolutions

2024-09-03 Thread Greg KH
On Wed, Sep 04, 2024 at 05:43:15AM +0300, Paul Pu wrote: > This changes the judgement of if needing to round up the width or not, > from using the `dp_flow` to the plane's type. > > The `dp_flow` can be -22(-EINVAL) even the plane is a PRIMARY one. > See `client_reg[]` in `ipu-common.c`. > > [

Re: [PATCH v4.19-v6.1] drm/amdgpu: Using uninitialized value *size when calling

2024-08-29 Thread Greg KH
On Wed, Aug 28, 2024 at 10:15:56AM -0500, Vamsi Krishna Brahmajosyula wrote: > From: Jesse Zhang > > [ Upstream commit 88a9a467c548d0b3c7761b4fd54a68e70f9c0944 ] > > Initialize the size before calling amdgpu_vce_cs_reloc, such as case > 0x0301. > V2: To really improve the handling we would

Re: [PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()

2024-08-17 Thread Greg KH
On Sat, Aug 17, 2024 at 10:30:41PM +0200, Kevin Holm wrote: > > > On 17.08.24 10:42, Greg KH wrote: > > On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote: > > > From: Wayne Lin > > > > > > [ Upstream commit fa57924c76d995e87c

Re: [PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()

2024-08-17 Thread Greg KH
On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote: > From: Wayne Lin > > [ Upstream commit fa57924c76d995e87ca3533ec60d1d5e55769a27 ] > > [Why] > dm_dp_mst_is_port_support_mode() is a bit not following the original design > rule and cause > light up issue with multiple 4k monitors afte

Re: [PATCH v1] misc: fastrpc: Trigger a panic using BUG_ON in device release

2024-08-13 Thread Greg KH
On Mon, Aug 05, 2024 at 04:36:28PM +0530, Abhishek Singh wrote: > > On 7/30/2024 12:46 PM, Greg KH wrote: > > On Tue, Jul 30, 2024 at 12:39:45PM +0530, Abhishek Singh wrote: > >> The user process on ARM closes the device node while closing the > >> session, triggers

Re: [PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()

2024-08-11 Thread Greg KH
On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote: > From: Wayne Lin > > [ Upstream commit fa57924c76d995e87ca3533ec60d1d5e55769a27 ] > > [Why] > dm_dp_mst_is_port_support_mode() is a bit not following the original design > rule and cause > light up issue with multiple 4k monitors afte

  1   2   3   4   5   6   7   8   9   >