Re: [PATCH] dt-bindings: gpu: mali-bifrost: Add compatible for RZ/V2N SoC

2025-05-05 Thread Geert Uytterhoeven
nd the existing schema > validation accordingly. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with tech

Re: `u64` by `u64` div/mod in DRM QR for arm32

2025-05-05 Thread Geert Uytterhoeven
tlin.com/linux/v6.14.5/source/include/linux/math64.h#L60 But you better think twice before using it, especially in performance-critical code. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m6

Re: [PATCH] video: fbdev: arkfb: Cast ics5342_init() allocation type

2025-05-02 Thread Geert Uytterhoeven
Hi Helge, On Tue, 29 Apr 2025 at 22:17, Helge Deller wrote: > On 4/28/25 08:36, Geert Uytterhoeven wrote: > > On Sat, 26 Apr 2025 at 13:33, Helge Deller wrote: > >> On 4/26/25 08:23, Kees Cook wrote: > >>> In preparation for making the kmalloc family of allocator

Re: [PATCH v6 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-28 Thread Geert Uytterhoeven
Hi Marcus, On Tue, 29 Apr 2025 at 08:15, Marcus Folkesson wrote: > On Thu, Apr 24, 2025 at 10:38:33AM +0200, Geert Uytterhoeven wrote: > > [...] > > > > + /* > > > +* As the display supports grayscale, all pixels >

Re: [PATCH] vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering

2025-04-28 Thread Geert Uytterhoeven
oid the confusion by replacing the "n" modifier with "hR", aka > reverse host ordering. It is inspired by the existing %p[mM]R printf > format. > > Reported-by: Geert Uytterhoeven > Closes: > https://lore.kernel.org/r/CAMuHMdV9tX=TG7E_CrSF=2py206txf+_y

Re: [PATCH] video: fbdev: arkfb: Cast ics5342_init() allocation type

2025-04-27 Thread Geert Uytterhoeven
struct dac_info * ics5342_init(dac_read_regs_t drr, > > dac_write_regs_t dwr, void *data) > > { > > - struct dac_info *info = kzalloc(sizeof(struct ics5342_info), > > GFP_KERNEL); > > + struct dac_info *info = (struct dac_info *)kzalloc(sizeof(struct &g

Re: [PATCH v6 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-24 Thread Geert Uytterhoeven
*/ So the driver actually supports D1 and D2, and XRGB should be inverted while converting to monochrome (and grayscale, which is not yet implemented). > +* > +* For monochrome formats, write the same value twice > to get > +* either a black or white pixel

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-23 Thread Geert Uytterhoeven
Hi Andy, On Wed, 23 Apr 2025 at 18:30, Andy Shevchenko wrote: > On Wed, Apr 23, 2025 at 04:50:02PM +0200, Geert Uytterhoeven wrote: > > On Wed, 23 Apr 2025 at 15:39, Petr Mladek wrote: > > > On Tue 2025-04-22 10:43:59, Geert Uytterhoeven wrote: > > ... > > > &

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-23 Thread Geert Uytterhoeven
Hi Petr, On Wed, 23 Apr 2025 at 15:39, Petr Mladek wrote: > On Tue 2025-04-22 10:43:59, Geert Uytterhoeven wrote: > > On Tue, 22 Apr 2025 at 10:30, Aditya Garg wrote: > > > On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote: > > > > On Tue, 8 Apr 2025 at 08:48, Adi

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Geert Uytterhoeven
Hi Andy, On Tue, 22 Apr 2025 at 12:16, Andy Shevchenko wrote: > On Tue, Apr 22, 2025 at 10:43:59AM +0200, Geert Uytterhoeven wrote: > > On Tue, 22 Apr 2025 at 10:30, Aditya Garg wrote: > > > On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote: > > > > On Tue, 8

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Geert Uytterhoeven
Hi Andy, On Tue, 22 Apr 2025 at 12:12, Andy Shevchenko wrote: > On Tue, Apr 22, 2025 at 10:07:33AM +0200, Geert Uytterhoeven wrote: > > On Tue, 8 Apr 2025 at 08:48, Aditya Garg wrote: > > ... > > > > +Generic FourCC code > > > +--- >

Re: [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-04-22 Thread Geert Uytterhoeven
Hi Pekka, On Tue, 22 Apr 2025 at 12:01, Pekka Paalanen wrote: > On Tue, 22 Apr 2025 11:41:29 +0200 > Geert Uytterhoeven wrote: > > On Tue, 22 Apr 2025 at 11:11, Pekka Paalanen > > wrote: > > > On Mon, 21 Apr 2025 17:50:39 +0300 > > > Laurent Pinchart wrote

Re: [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-04-22 Thread Geert Uytterhoeven
; > On 01/04/2025 16:27, Pekka Paalanen wrote: > > > > > On Mon, 31 Mar 2025 13:53:37 +0300 Pekka Paalanen wrote: > > > > >> On Mon, 31 Mar 2025 11:21:35 +0300 Laurent Pinchart wrote: > > > > >>> On Mon, Mar 31, 2025 at 10:54:46AM +0300, Pekka P

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Geert Uytterhoeven
Hi Aditya, CC netdev On Tue, 22 Apr 2025 at 10:30, Aditya Garg wrote: > On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote: > > On Tue, 8 Apr 2025 at 08:48, Aditya Garg wrote: > >> From: Hector Martin > >> > >> %p4cc is designed for DRM/V4L2 FourCCs with

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Geert Uytterhoeven
05067) > + > +Examples for a big-endian machine, given &(u32)0x67503030:: > + > + %p4ch gP00 (0x67503030) > + %p4cn 00Pg (0x30305067) This doesn't look right to me, as network byte order is big endian? Note that I didn't check the code. > + %p4

Re: [PATCH v3 10/15] drm: renesas: rz-du: mipi_dsi: Use mHz for D-PHY frequency calculations

2025-04-22 Thread Geert Uytterhoeven
he last factor unsigned long long. "vclk_rate * bpp" is still unsigned long, causing overflow on 32-bit. As there is no rounding variant of mul_u64_u32_div(), you probably want to use mul_u32_u32() instead. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There&

Re: [PATCH 2/4] dt-bindings: gpu: mali-bifrost: Add compatible for RZ/G3E SoC

2025-04-16 Thread Geert Uytterhoeven
a validation accordingly. > > Signed-off-by: Tommaso Merciai Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call my

Re: [PATCH v2 15/15] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

2025-04-16 Thread Geert Uytterhoeven
LL_DSI_LIMITS(), i.e. why can't you use the latter? > > static inline struct rzg2l_mipi_dsi * Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I

Re: [PATCH v2 01/15] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-04-16 Thread Geert Uytterhoeven
2, .max = 32 }, \ > + .fvco = { .min = 1600 * MEGA, .max = 3200 * MEGA } \ > + } \ > + > +/** > + * rzv2h_dsi_get_pll_parameters_values - Finds the best combination of PLL > parameters &g

Re: [PATCH v2 01/15] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-04-15 Thread Geert Uytterhoeven
= 1, .max = 4 },\ > + .s = { .min = 0, .max = 6 },\ > + .k = { .min = -32768, .max = 32767 }, \ > + .csdiv = { .min = 2, .max = 32 }, \ > +

Re: [PATCH v2 02/15] clk: renesas: r9a09g057: Add clock and reset entries for DSI and LCDC

2025-04-15 Thread Geert Uytterhoeven
be inverted? > +#define CSDIV1_DIVCTL2 DDIV_PACK(CPG_CSDIV1, 8, 4, CSDIV_NO_MON) > > #define SSEL0_SELCTL2 SMUX_PACK(CPG_SSEL0, 8, 1) > #define SSEL0_SELCTL3 SMUX_PACK(CPG_SSEL0, 12, 1) Gr{oetje,eeting}s, Geert -- Geert Uytterho

Re: [PATCH v3 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-10 Thread Geert Uytterhoeven
ever did it but Geert has some patches for this. [1] needs an update, and still more rework to make them acceptable. > > Please compare > > https://www.marcusfolkesson.se/xrgb.png > > and > > https://www.marcusfolkesson.se/c1.png Yep, the latter is using the correct lo

Re: [PATCH 04/19] drm: Pass the format info to .fb_create()

2025-04-10 Thread Geert Uytterhoeven
ä > drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c | 3 ++- Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I

Re: [PATCH v2 10/15] drm: renesas: rz-du: mipi_dsi: Use mHz for D-PHY frequency calculations

2025-04-09 Thread Geert Uytterhoeven
capitalization of the "hz" part, it is not clear that the "m" stands for "milli" instead of "mega". Perhaps hsfreq_mHz or hsfreq_millihz? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

Re: [RFC] PCI: add CONFIG_MMU dependency

2025-04-08 Thread Geert Uytterhoeven
people from disabling MMU support on a system that has both a PCI bus and an MMU. But other people may not agree, or care? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with te

Re: [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-03-27 Thread Geert Uytterhoeven
Hi Pekka, On Thu, 27 Mar 2025 at 16:59, Pekka Paalanen wrote: > On Thu, 27 Mar 2025 16:21:16 +0200 > Tomi Valkeinen wrote: > > On 27/03/2025 11:20, Pekka Paalanen wrote: > > > On Wed, 26 Mar 2025 15:55:18 +0200 > > > Tomi Valkeinen wrote: > > >> On

Re: [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-03-26 Thread Geert Uytterhoeven
#x27;4') /* > non-subsampled Cr (1) and Cb (2) planes */ > > +/* Greyscale formats */ > + > +#define DRM_FORMAT_Y8 fourcc_code('G', 'R', 'E', 'Y') /* 8-bit > Y-only */ This format differs from e.g. DRM_FORMAT_R8, which encodes the number of bi

[PATCH] pinctrl: PINCTRL_AMDISP should depend on DRM_AMD_ISP

2025-03-18 Thread Geert Uytterhoeven
not support the AMD ISP. Fixes: e97435ab09f3ad7b ("pinctrl: amd: isp411: Add amdisp GPIO pinctrl") Signed-off-by: Geert Uytterhoeven --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index cbb81f

Re: [PATCH 2/3] arm64: dts: renesas: r9a09g057: Add Mali-G31 GPU node

2025-03-06 Thread Geert Uytterhoeven
On Tue, 18 Feb 2025 at 12:59, Prabhakar wrote: > > From: Lad Prabhakar > > Add Mali-G31 GPU node to SoC DTSI. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v6.15. Gr{oetje,eeting}s, Geert --

Re: [PATCH 2/2] dt-bindings: display: mitsubishi,aa104xd12: Adjust allowed and required properties

2025-03-06 Thread Geert Uytterhoeven
> Signed-off-by: Rob Herring (Arm) Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But w

Re: [PATCH 1/2] dt-bindings: display: mitsubishi,aa104xd12: Allow jeida-18 for data-mapping

2025-03-06 Thread Geert Uytterhoeven
(Arm) Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say

Re: [PATCH 3/3] arm64: dts: renesas: r9a09g057h44-rzv2h-evk: Enable Mali-G31

2025-03-06 Thread Geert Uytterhoeven
On Tue, 18 Feb 2025 at 12:59, Prabhakar wrote: > From: Lad Prabhakar > > Enable Mali-G31 (GPU) node on EVK board. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v6.15. Gr{oetje,eeting}s, G

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-02-21 Thread Geert Uytterhoeven
pp, but that is using bitplanes. There is already some sort of consensus to not expose bitplanes to userspace in DRM, so limiting to 1, 2, 4, and 8 bpp (which can be converted from C[1248]) is fine. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-02-18 Thread Geert Uytterhoeven
--+++ > + * | 2 | * DRM_FORMAT_C2 | * DRM_FORMAT_R2 | > + * ++++ > + * | 1 | * DRM_FORMAT_C1 | * DRM_FORMAT_R1 | > + * +-

Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-05 Thread Geert Uytterhoeven
gt; On Tue, Feb 04, 2025 at 09:07:05AM +, Biju Das wrote: > > > > > > -Original Message- > > > > > > From: dri-devel On > > > > > > Behalf Of Geert Uytterhoeven > > > > > > Sent: 03 February 2025 11:06 > > >

Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-03 Thread Geert Uytterhoeven
vailable(np)) > + if (!np) > return -ENODEV; ... fixes the reference count in case of an unavailable node... > > rgb = devm_kzalloc(dc->dev, sizeof(*rgb), GFP_KERNEL); ... but as np is stored below, it must not be freed when it goes out of context? Gr{o

Re: [PATCH RFT 2/2] drm/bridge: ti-sn65dsi86: Use per-client debugfs entry

2025-01-28 Thread Geert Uytterhoeven
tible = "ti,sn65dsi86"; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking

Re: [PATCH RFT 2/2] drm/bridge: ti-sn65dsi86: Use per-client debugfs entry

2025-01-27 Thread Geert Uytterhoeven
= 0x0001 [0xf5] = 0x [0xf6] = 0x0002 [0xf7] = 0x [0xf8] = 0x0001 Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversatio

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-21 Thread Geert Uytterhoeven
Hi Dmitry, CC sfr On Tue, Jan 21, 2025 at 11:44 AM Dmitry Baryshkov wrote: > On Tue, 21 Jan 2025 at 11:13, Geert Uytterhoeven wrote: > > On Tue, Jan 7, 2025 at 12:31 PM Dmitry Baryshkov > > wrote: > > > On Sat, 14 Dec 2024 15:37:04 +0200, Dmitry Baryshkov wrote: >

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-21 Thread Geert Uytterhoeven
misc/drm-misc-next' into drm-tip"). What am I missing? Thanks! P.S. Sima: noticed while resolving a merge conflict using drm-tip. Thx! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In p

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Geert Uytterhoeven
gt; for a very long time on those platforms. > > I tried to look around, but I did not find any mentions that CREATE_DUMB > should only be used for RGB buffers. Is anyone outside the core > developers even aware of it? > > If we don't use dumb buffers there, where do w

[PATCH next] cgroup/rdma: Drop bogus PAGE_COUNTER select

2025-01-16 Thread Geert Uytterhoeven
e. Remove it. Fixes: b168ed458ddecc17 ("kernel/cgroup: Add "dmem" memory accounting cgroup") Closes: https://lore.kernel.org/camuhmdumpfahsnzwx2ib5yfh8rjjw25lncnyujnbgckotux...@mail.gmail.com Signed-off-by: Geert Uytterhoeven --- Broken commit is in drm/drm-next Partial fix is in dr

Re: [PATCH v2 04/10] drm/fourcc: Add DRM_FORMAT_Y10_LE32

2025-01-15 Thread Geert Uytterhoeven
Hi Tomi, On Wed, Jan 15, 2025 at 3:34 PM Tomi Valkeinen wrote: > On 15/01/2025 16:08, Geert Uytterhoeven wrote: > > On Wed, Jan 15, 2025 at 2:46 PM Tomi Valkeinen > > wrote: > >> On 15/01/2025 14:52, Geert Uytterhoeven wrote: > >>> On Wed, Jan 15, 2025 at

Re: [PATCH v2 04/10] drm/fourcc: Add DRM_FORMAT_Y10_LE32

2025-01-15 Thread Geert Uytterhoeven
Hi Tomi, On Wed, Jan 15, 2025 at 2:46 PM Tomi Valkeinen wrote: > On 15/01/2025 14:52, Geert Uytterhoeven wrote: > > On Wed, Jan 15, 2025 at 1:42 PM Tomi Valkeinen > > wrote: > >> On 15/01/2025 14:33, Geert Uytterhoeven wrote: > >>> On Wed, Jan 15, 2025 at

Re: [PATCH v2 04/10] drm/fourcc: Add DRM_FORMAT_Y10_LE32

2025-01-15 Thread Geert Uytterhoeven
Hi Tomi, On Wed, Jan 15, 2025 at 1:42 PM Tomi Valkeinen wrote: > On 15/01/2025 14:33, Geert Uytterhoeven wrote: > > On Wed, Jan 15, 2025 at 12:11 PM Tomi Valkeinen > > wrote: > >> On 15/01/2025 12:33, Geert Uytterhoeven wrote: > >>> On Wed, Jan 15, 2025 at

Re: [PATCH v2 04/10] drm/fourcc: Add DRM_FORMAT_Y10_LE32

2025-01-15 Thread Geert Uytterhoeven
Hi Tomi, On Wed, Jan 15, 2025 at 12:11 PM Tomi Valkeinen wrote: > On 15/01/2025 12:33, Geert Uytterhoeven wrote: > > On Wed, Jan 15, 2025 at 10:04 AM Tomi Valkeinen > > wrote: > >> Add Y10_LE32, a 10 bit greyscale format, with 3 pixels packed into > >> 32-bit c

Re: [PATCH v2 04/10] drm/fourcc: Add DRM_FORMAT_Y10_LE32

2025-01-15 Thread Geert Uytterhoeven
;P', 'A', '4') /* [31:0] > x:Y2:Y1:Y0 2:10:10:10 little endian */ R10_LE32? Or R10_PA4? Does LE32 have a meaning? My first guess just reading the subject was wrong ("little endian 32-bit" ;-) Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH v2 03/10] drm/fourcc: Add DRM_FORMAT_Y8

2025-01-15 Thread Geert Uytterhoeven
el value and brightness) */ #define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */ See also commit 8aba4d30520ed656 ("drm/fourcc: Clarify the meaning of single-channel "red""). Gr{oetje,eeting}s,

Re: [PATCH v2.1 1/1] kernel/cgroup: Add "dmem" memory accounting cgroup

2025-01-14 Thread Geert Uytterhoeven
device > + memory usage based on the cgroup hierarchy. > + > + As an example, it allows you to restrict VRAM usage for applications > + in the DRM subsystem. > + Do you envision other users than DRM? Perhaps this should depend on DRM for now? Gr{oetje,eeting}s

Re: [PATCH] m68k: Fix VGA I/O defines

2025-01-08 Thread Geert Uytterhoeven
not generally > available. > > Signed-off-by: Thomas Zimmermann > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202501071629.dneswlm8-...@intel.com/ > Fixes: 5c3f968712ce ("m68k/video: Create ") > Cc: Geert Uytterhoeven > Cc: linux-f

Re: [PATCH] dt-bindings: display: Correct indentation and style in DTS example

2025-01-08 Thread Geert Uytterhoeven
fit on a single line. > +reg = <0xfea4 0x1000>; > +power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + clocks = <&cpg CPG_MOD 711>; > +resets = <&cpg 711>; > }; Reviewed-by: Geert Uytterhoeven # renesa

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Fix multiple instances

2025-01-07 Thread Geert Uytterhoeven
Hi Doug, On Tue, Jan 7, 2025 at 6:27 PM Doug Anderson wrote: > On Wed, Dec 11, 2024 at 12:27 AM Geert Uytterhoeven > wrote: > > On Tue, Dec 10, 2024 at 6:09 PM Doug Anderson wrote: > > > On Tue, Dec 10, 2024 at 6:19 AM Geert Uytterhoeven > > > wrote: > > &g

Re: [PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-18 Thread Geert Uytterhoeven
Hi Jocelyn, On Wed, Dec 18, 2024 at 3:58 PM Jocelyn Falempe wrote: > On 18/12/2024 15:18, Petr Mladek wrote: > > On Wed 2024-12-18 12:41:39, Jocelyn Falempe wrote: > >> On 18/12/2024 12:00, Geert Uytterhoeven wrote: > >>> On Wed, Dec 18, 2024 at 11:14 AM

Re: [PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-18 Thread Geert Uytterhoeven
Hi Petr, On Wed, Dec 18, 2024 at 3:18 PM Petr Mladek wrote: > On Wed 2024-12-18 12:41:39, Jocelyn Falempe wrote: > > On 18/12/2024 12:00, Geert Uytterhoeven wrote: > > > On Wed, Dec 18, 2024 at 11:14 AM Jocelyn Falempe > > > wrote: > > > > On 17/

Re: [PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-18 Thread Geert Uytterhoeven
Hi Jocelyn, On Wed, Dec 18, 2024 at 11:14 AM Jocelyn Falempe wrote: > On 17/12/2024 15:54, Geert Uytterhoeven wrote: > > On Tue, Dec 17, 2024 at 3:46 PM Jocelyn Falempe wrote: > >> On 17/12/2024 15:19, Geert Uytterhoeven wrote: > >>> On Wed, Dec 4, 2024 at 6:41 PM

Re: [PATCH] drm/mediatek: stop selecting foreign drivers

2024-12-18 Thread Geert Uytterhoeven
P_AUX_BUS > @@ -39,6 +35,5 @@ config DRM_MEDIATEK_HDMI > tristate "DRM HDMI Support for Mediatek SoCs" > depends on DRM_MEDIATEK > select SND_SOC_HDMI_CODEC if SND_SOC > - select PHY_MTK_HDMI > help > DRM/KMS HDMI driver for Med

Re: [PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-17 Thread Geert Uytterhoeven
Hi Jocelyn. On Tue, Dec 17, 2024 at 3:46 PM Jocelyn Falempe wrote: > On 17/12/2024 15:19, Geert Uytterhoeven wrote: > > On Wed, Dec 4, 2024 at 6:41 PM Jocelyn Falempe wrote: > >> drm_log is a simple logger that uses the drm_client API to print the kmsg > >> boot log

Re: [PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-17 Thread Geert Uytterhoeven
display, as before: CONFIG_DRM_CLIENT_DEFAULT_FBDEV=y # CONFIG_DRM_CLIENT_DEFAULT_LOG is not set CONFIG_DRM_CLIENT_DEFAULT="fbdev" Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@lin

Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

2024-12-17 Thread Geert Uytterhoeven
CC Saravana On Tue, Dec 17, 2024 at 2:29 PM Geert Uytterhoeven wrote: > On Mon, Dec 16, 2024 at 2:33 PM Geert Uytterhoeven > wrote: > > On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen > > wrote: > > > From: Tomi Valkeinen > > > > > > Add support

Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

2024-12-17 Thread Geert Uytterhoeven
On Mon, Dec 16, 2024 at 2:33 PM Geert Uytterhoeven wrote: > On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen > wrote: > > From: Tomi Valkeinen > > > > Add support for the mini DP output on the Gray Hawk board. > > > > Signed-off-by: Tomi Valkeinen > > Re

Re: [PATCH v5 3/7] dt-bindings: display: renesas, du: Add missing constraints

2024-12-17 Thread Geert Uytterhoeven
maxItems: 4 > > renesas,vsps: >minItems: 4 > + maxItems: 4 AFAIK these two additions are not needed, as they already match the values defined at the top level. The rest LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

2024-12-16 Thread Geert Uytterhoeven
Hi Tomi, On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Add support for the mini DP output on the Gray Hawk board. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Thanks for your patch

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-12-11 Thread Geert Uytterhoeven
Hi Doug, On Tue, Dec 10, 2024 at 6:09 PM Doug Anderson wrote: > On Tue, Dec 10, 2024 at 6:19 AM Geert Uytterhoeven > wrote: > > Each bridge instance creates up to four auxiliary devices with different > > names. However, their IDs are always zero, causing duplicate filename

Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

2024-12-11 Thread Geert Uytterhoeven
Hi Tomi, On Tue, Dec 10, 2024 at 7:10 PM Tomi Valkeinen wrote: > On 10/12/2024 18:34, Geert Uytterhoeven wrote: > > On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen > > wrote: > >> From: Tomi Valkeinen > >> > >> Add support for the mini DP output on th

Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

2024-12-10 Thread Geert Uytterhoeven
Hi Tomi, On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Add support for the mini DP output on the Gray Hawk board. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Thanks for your patch

Re: [PATCH v3 09/10] arm64: dts: renesas: r8a779h0: Add display support

2024-12-10 Thread Geert Uytterhoeven
On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Add the device nodes for supporting DU and DSI. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Reviewed-by: Geert Uytterhoeven i.e. will q

Re: [PATCH v3 08/10] arm64: dts: renesas: gray-hawk-single: Fix indentation

2024-12-10 Thread Geert Uytterhoeven
On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Fix the indent on the two regulators. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Reviewed-by: Geert Uytterhoeven i.e. will queue in re

[PATCH v2] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-12-10 Thread Geert Uytterhoeven
vers") Signed-off-by: Geert Uytterhoeven --- On the White Hawk development board: /sys/bus/auxiliary/devices/ |-- ti_sn65dsi86.aux.1068 |-- ti_sn65dsi86.aux.4140 |-- ti_sn65dsi86.bridge.1068 |-- ti_sn65dsi86.bridge.4140 |-- ti_sn65dsi86.gpio.1068 |-- ti_sn65dsi86.gpio.

Re: [PATCH v3 05/10] clk: renesas: r8a779h0: Add display clocks

2024-12-08 Thread Geert Uytterhoeven
Hi Tomi, On Mon, Dec 9, 2024 at 6:26 AM Tomi Valkeinen wrote: > On 06/12/2024 15:43, Geert Uytterhoeven wrote: > > On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen > > wrote: > >> From: Tomi Valkeinen > >> > >> Add display related clocks for DU, DSI

Re: [PATCH v3 05/10] clk: renesas: r8a779h0: Add display clocks

2024-12-06 Thread Geert Uytterhoeven
Hi Tomi, On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Add display related clocks for DU, DSI, FCPVD, and VSPD. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Reviewed-by: Geert Uy

Re: [PATCH v2 02/10] drm/rcar-du: Write DPTSR only if there are more than one crtc

2024-12-05 Thread Geert Uytterhoeven
DPTSR2. And apparently we had this discussion before... https://lore.kernel.org/all/camuhmdxxf4oepnylvp84ohsa+wdehcnjbxnhjyo7-1vxpbj...@mail.gmail.com Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH 8/9] arm64: dts: renesas: r8a779h0: Add display support

2024-12-04 Thread Geert Uytterhoeven
nirq: Setting trigger mode 8 for irq 91 failed > vsp1 fea2.vsp: failed to request IRQ > > I didn't dig further yet. Yeah, I don't think the GIC supports anything but IRQ_TYPE_LEVEL_HIGH. Which brings us to the two ISP nodes on R-Car V4H and V4M, both using IRQ_TYPE_LEVEL_LOW. Ni

Re: [PATCH 0/9] drm: Add DSI/DP support for Renesas r8a779h0 V4M and grey-hawk board

2024-12-04 Thread Geert Uytterhoeven
st identical to Renesas > r8a779g0 and white-hawk board. Thanks for your series! > Signed-off-by: Tomi Valkeinen Woot, SoB tags for cover letters ;-) Works fine up to 2560x1440 (I don't have a 4K display). Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Gee

Re: [PATCH 2/9] dt-bindings: display: renesas,du: Add r8a779h0

2024-12-03 Thread Geert Uytterhoeven
o add h0 to the g0 block in the conditional properties > below. With that, Which is not sufficient, as the DU on R-Car V4M has only a single channel, unlike on R-Car V3U and V4H. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-25 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Nov 22, 2024 at 10:15 AM Maxime Ripard wrote: > On Fri, Nov 22, 2024 at 09:36:16AM +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 4, 2024 at 6:30 PM Nathan Chancellor wrote: > > > On Fri, Oct 18, 2024 at 03:10:10PM +, Arnd Bergmann wrote: > >

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-22 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Nov 22, 2024 at 10:15 AM Maxime Ripard wrote: > On Fri, Nov 22, 2024 at 09:36:16AM +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 4, 2024 at 6:30 PM Nathan Chancellor wrote: > > > On Fri, Oct 18, 2024 at 03:10:10PM +, Arnd Bergmann wrote: > >

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-22 Thread Geert Uytterhoeven
org/drm/kernel 28eb75e178d389d325f1666e422bc139804c Compiler: m68k-linux-gcc (GCC) 8.1.0 / GNU ld (GNU Binutils) 2.30 ERROR: modpost: "__udivdi3" [drivers/gpu/drm/rockchip/rockchipdrm.ko] undefined! Applying this patch fixes it, so Acked-by: Geert Uytterhoe

Re: [PATCH v3 2/3] dt-bindings: display: adi,adv7533: Drop single lane support

2024-11-06 Thread Geert Uytterhoeven
rtunately https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7533.pdf agrees ;-) > Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") > Cc: sta...@vger.kernel.org > Signed-off-by: Biju Das With the description updated: Reviewed-by: Geer

Re: [PATCH v3 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-06 Thread Geert Uytterhoeven
33_parse_dt(struct device_node *np, struct > adv7511 *adv) > if (!adv->host_node) > return -ENODEV; > > - of_node_put(adv->host_node); > - > adv->use_timing_gen = !of_property_read_bool(np, >

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-30 Thread Geert Uytterhoeven
Hi Dmitry, On Mon, Oct 28, 2024 at 2:34 PM Dmitry Baryshkov wrote: > On Tue, Oct 22, 2024 at 07:37:01AM -0700, Doug Anderson wrote: > > On Tue, Oct 22, 2024 at 12:12 AM Geert Uytterhoeven > > wrote: > > > > > > > > However, using i2c_client->adapter->

[PATCH drm-next] drm/xe/xe2: Remove duplicate XE2LPM_* register definitions

2024-10-29 Thread Geert Uytterhoeven
ntical copies of the XE2LPM_L3SQCREG2, XE2LPM_L3SQCREG3, and XE2LPM_SCRATCH3_LBCF register definitions. Fixes: 26bb2dc102783fef ("Merge tag 'drm-xe-next-2024-10-10' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-next") Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-22 Thread Geert Uytterhoeven
Hi Doug, On Tue, Oct 22, 2024 at 2:28 AM Doug Anderson wrote: > On Mon, Oct 21, 2024 at 1:48 AM Geert Uytterhoeven > wrote: > > On Mon, Oct 21, 2024 at 10:23 AM Geert Uytterhoeven > > wrote: > > > On Mon, Oct 21, 2024 at 9:27 AM Greg KH > > > wrote: &

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-21 Thread Geert Uytterhoeven
Hi Greg, On Mon, Oct 21, 2024 at 10:23 AM Geert Uytterhoeven wrote: > On Mon, Oct 21, 2024 at 9:27 AM Greg KH wrote: > > On Mon, Oct 21, 2024 at 08:58:30AM +0200, Geert Uytterhoeven wrote: > > > On Mon, Oct 21, 2024 at 8:39 AM Greg KH > > > wrote: > > >

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-21 Thread Geert Uytterhoeven
Hi Greg, On Mon, Oct 21, 2024 at 9:27 AM Greg KH wrote: > On Mon, Oct 21, 2024 at 08:58:30AM +0200, Geert Uytterhoeven wrote: > > On Mon, Oct 21, 2024 at 8:39 AM Greg KH wrote: > > > On Sun, Oct 20, 2024 at 05:36:29PM +0300, Laurent Pinchart wrote: > > > > On F

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-20 Thread Geert Uytterhoeven
On Fri, Oct 18, 2024 at 04:09:26PM +0200, Greg KH wrote: > > > > > On Fri, Oct 18, 2024 at 03:36:48PM +0200, Geert Uytterhoeven wrote: > > > > > > On Fri, Oct 18, 2024 at 3:10 PM Laurent Pinchart wrote: > > > > > > > On Fri, Oct 18, 2024 at 09

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-18 Thread Geert Uytterhoeven
Hi Laurent, CC GregKH On Fri, Oct 18, 2024 at 3:10 PM Laurent Pinchart wrote: > On Fri, Oct 18, 2024 at 09:45:52AM +0200, Geert Uytterhoeven wrote: > > Each bridge instance creates up to four auxiliary devices with different > > names. However, their IDs are always zero, ca

[PATCH] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-10-18 Thread Geert Uytterhoeven
by using a unique instance ID per bridge instance. Fixes: bf73537f411b0d4f ("drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers") Signed-off-by: Geert Uytterhoeven --- /sys/bus/auxiliary/devices ├── ti_sn65dsi86.gpio.0 ├── ti_sn65dsi86.pwm.0 ├── ti_sn65dsi86.au

Re: [PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-13 Thread Geert Uytterhoeven
g > > Similar for me too. My only change to this driver I think was to add DRM > panic support in commit b2cb6011bcaf ("drm/tidss: Add drm_panic support"). > > But I'm also OK with the change, so: > > Acked-by: Javier Martinez Canillas Similar for me, just a forg

Re: [PATCH 2/8] drm: renesas: rcar-du: annotate rcar_cmm_read() with __maybe_unused

2024-09-10 Thread Geert Uytterhoeven
ine int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg) > +static inline __maybe_unused int rcar_cmm_read(struct rcar_cmm *rcmm, u32 > reg) > { > return ioread32(rcmm->base + reg); > } This function was never used. Why not remove it instead? Gr{oetje,eeting}s,

Re: [PATCH v3 04/81] drm: Add client-agnostic setup helper

2024-08-30 Thread Geert Uytterhoeven
d int color_mode) +{ + u32 fourcc = drm_driver_color_mode_format(dev, color_mode); + + drm_client_setup_with_fourcc(dev, fourcc); +} +EXPORT_SYMBOL(drm_client_setup_with_color_mode); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There'

Re: [PATCH v3 36/81] drm/renesas/shmobile: Run DRM default client setup

2024-08-30 Thread Geert Uytterhoeven
lient_setup_with_fourcc() > > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeve

Re: [PATCH v3 40/81] drm/stm: Run DRM default client setup

2024-08-30 Thread Geert Uytterhoeven
homas Zimmermann Cc: Yannick Fertre Cc: Raphael Gallais-Pou Cc: Philippe Cornu Cc: Maxime Coquelin Cc: Alexandre Torgue Acked-by: Raphael Gallais-Pou Acked-by: Raphael Gallais-Pou WARNING: Duplicate signature Gr{oetje,eeting}s, Geert --

Re: [PATCH v1] drivers:smumgr:Variable names should be consistent with other modules

2024-08-30 Thread Geert Uytterhoeven
_data->smc_state_table.GraphicsLevel[i].pcieDpmLevel = > highest_pcie_level_enabled; > + smu_data->smc_state_table.GraphicsLevel[i].pcieDpmLevel = > + hightest_pcie_level_enabled; > } > > /* set pcieDpmLevel to lowest_pcie_level_enabled*/ Gr{oetje,eeting}s,

Re: [PATCH] drm: renesas: shmobile: Add drm_panic support

2024-08-29 Thread Geert Uytterhoeven
Dmitry Baryshkov wrote: > > >>>>>> On Wed, May 29, 2024 at 04:03:20AM +0300, Laurent Pinchart wrote: > > >>>>>>> On Mon, May 27, 2024 at 03:34:48PM +0200, Geert Uytterhoeven wrote: > > >>>>>>>> Add support

Re: drm: renesas: shmobile: Add drm_panic support

2024-08-29 Thread Geert Uytterhoeven
Hi Sui, On Wed, May 29, 2024 at 1:31 PM Sui Jingfeng wrote: > On 5/27/24 21:34, Geert Uytterhoeven wrote: > > Add support for the drm_panic module, which displays a message on > > the screen when a kernel panic occurs. > > > > Signed-off-by: Geert Uytterhoeven >

Re: [PATCH v3 2/4] drm: renesas: rz-du: Add RZ/G2UL DU Support

2024-08-22 Thread Geert Uytterhoeven
Notwithstanding Laurent's comment, the above replacement is equivalent to the original "output = i;", so there is no need to change this line. > break; > } > } Gr{oetje,eeting}s,

Re: Build regressions/improvements in v6.11-rc4

2024-08-19 Thread Geert Uytterhoeven
On Mon, 19 Aug 2024, Geert Uytterhoeven wrote: JFYI, when comparing v6.11-rc4[1] to v6.11-rc3[3], the summaries are: - build errors: +6/-4 + /kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c: error: no previous prototype for '__vdso_clock_gettime' [-Werror=missing-prototypes

Re: Build regressions/improvements in v6.11-rc2

2024-08-05 Thread Geert Uytterhoeven
On Mon, 5 Aug 2024, Geert Uytterhoeven wrote: JFYI, when comparing v6.11-rc2[1] to v6.11-rc1[3], the summaries are: - build errors: +9/-4 + /kisskb/src/fs/bcachefs/data_update.c: error: the frame size of 1032 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]: => 338:1 m

[PATCH] drm/radeon/r100: Handle unknown family in r100_cp_init_microcode()

2024-07-30 Thread Geert Uytterhoeven
mware \"%s\"\n", fw_name); | ^~ Fix this by converting the if/else if/... construct into a proper switch() statement with a default to handle the error case. As a bonus, the generated code is ca. 100 bytes smaller (with gcc 11.4.0 targeting arm32).

[PATCH] drm/xe/oa/uapi: Make bit masks unsigned

2024-07-29 Thread Geert Uytterhoeven
FIELD_GET(DRM_XE_OA_FORMAT_MASK_BC_REPORT, fmt); ^ Fixes: b6fd51c6211910b1 ("drm/xe/oa/uapi: Define and parse OA stream properties") Signed-off-by: Geert Uytterhoeven --- Compile-tested only. --- include/uapi/drm/xe_drm.h | 8 1 file changed, 4 insertions(+),

  1   2   3   4   5   6   7   8   9   10   >