Re: [PATCH 5/8] drm/msm/dpu: use drmm_writeback_connector_init()

2025-08-01 Thread Geert Uytterhoeven
s@msm/dpu@renesas/r-car@ in the Subject. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists

[PATCH] gpu/trace: TRACE_GPU_MEM should depend on DRM

2025-07-31 Thread Geert Uytterhoeven
GPU memory usage tracepoints are only used by DRM GPU drivers. Hence add a dependency on DRM, to prevent asking the user about this functionality when configuring a kernel without DRM GPU support. Fixes: 5d95cbf21a4a550f ("gpu/trace: make TRACE_GPU_MEM configurable") Signed-off

[PATCH] drm: renesas: rz-du: mipi_dsi: Convert to RUNTIME_PM_OPS()

2025-07-09 Thread Geert Uytterhoeven
Convert the Renesas RZ/G2L MIPI DSI Encoder driver from SET_RUNTIME_PM_OPS() to RUNTIME_PM_OPS() and pm_ptr(). This lets us drop the __maybe_unused annotations from its runtime suspend and resume callbacks, and reduces kernel size in case CONFIG_PM is disabled. Signed-off-by: Geert Uytterhoeven

Re: [PATCH] drm/panel: ilitek-ili9881c: Use u8 for lane count

2025-06-30 Thread Geert Uytterhoeven
>> > >>>>> $ i686-linux-gnu-gcc -o test test.c && ./test > >>>>> 24 20 > >>>>> > >>>>> Maybe there is some improvement ? > >>>> > >>>> Try again with code size included, and othe

Re: [PATCH] dt-bindings: display: renesas,rzg2l-du: Add support for RZ/V2N SoC

2025-06-12 Thread Geert Uytterhoeven
as,r9a09g057-du` compatible > will be used as a fallback for the RZ/V2N SoC. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal

Re: [PATCH] fbdev: pm3fb: Fix potential divide by zero

2025-06-12 Thread Geert Uytterhoeven
y: if (var->pixclock <= KHZ2PICOS(PM3_MAX_PIXCLOCK)) var->pixclock = KHZ2PICOS(PM3_MAX_PIXCLOCK) + 1; The "+ 1" is needed because of rounding. > Actually, I have found a few similar issues in other functions as well. I > would like to make sure I am addressing them in the correct way. That would be great. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH 2/3] drm/panel: ilitek-ili9881c: Allow configuration of the number of lanes

2025-06-11 Thread Geert Uytterhoeven
into the existing hole on 32-bit systems. > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to jo

Re: [PATCH] fbdev: pm3fb: Fix potential divide by zero

2025-06-10 Thread Geert Uytterhoeven
ead, if possible. > + > if (PICOS2KHZ(var->pixclock) > PM3_MAX_PIXCLOCK) { > DPRINTK("pixclock too high (%ldKHz)\n", > PICOS2KHZ(var->pixclock)); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

Re: [PATCH v2 01/46] panel/orisetech-otm8009a: Use refcounted allocation in place of devm_kzalloc()

2025-06-03 Thread Geert Uytterhoeven
ional(dev, "reset", > GPIOD_OUT_LOW); > if (IS_ERR(ctx->reset_gpio)) { Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call

Re: [PATCH/RFC 0/3] Atari DRM driver

2025-05-30 Thread Geert Uytterhoeven
Hi Eero, On Thu, 29 May 2025 at 02:06, Eero Tamminen wrote: > On 28.5.2025 11.57, Geert Uytterhoeven wrote: > > On Wed, 28 May 2025 at 00:47, Eero Tamminen wrote: > >> I did boot testing on Hatari emulator with a minimal kernel config > >> having atari_drm enabled

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-05-30 Thread Geert Uytterhoeven
@@ -1322,7 +1349,8 @@ static int ti_sn_bridge_probe(struct auxiliary_device > > *adev, > > ? DRM_MODE_CONNECTOR_DisplayPort : > > DRM_MODE_CONNECTOR_eDP; > > > > if (pdata->bridge.type == DRM_MODE_CONNECTOR_DisplayPort) > > - pdata

Re: [PATCH v5 4/4] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

2025-05-28 Thread Geert Uytterhoeven
Hi Prabhakar, On Wed, 28 May 2025 at 11:48, Lad, Prabhakar wrote: > On Fri, May 23, 2025 at 4:19 PM Geert Uytterhoeven > wrote: > > On Mon, 12 May 2025 at 20:43, Prabhakar wrote: > > > From: Lad Prabhakar > > > > > > Add DSI support for Renesas RZ/

Re: [PATCH/RFC 0/3] Atari DRM driver

2025-05-28 Thread Geert Uytterhoeven
Hi Eero, On Wed, 28 May 2025 at 00:47, Eero Tamminen wrote: > On 25.5.2025 15.05, Geert Uytterhoeven wrote: > > On Thu, 22 May 2025 at 00:56, Eero Tamminen wrote: > >> On 21.5.2025 10.06, Geert Uytterhoeven wrote: > >>> I do keep it up-to-date locally, so I could p

Re: [PATCH v5 1/4] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-05-28 Thread Geert Uytterhoeven
Hi Prabhakar, On Tue, 27 May 2025 at 23:51, Lad, Prabhakar wrote: > On Fri, May 23, 2025 at 3:45 PM Geert Uytterhoeven > wrote: > > On Mon, 12 May 2025 at 20:43, Prabhakar wrote: > > > From: Lad Prabhakar > > > > > > Add support for PLLDSI and PLLDSI di

Re: [PATCH] drm/bridge: adv7511: Do not merge adv7511_mode_set() with atomic_enable()

2025-05-26 Thread Geert Uytterhoeven
ou mean: Fixes: ae01d3183d2763ed ("drm/bridge: adv7511: switch to the HDMI connector helpers") Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I

Re: [PATCH/RFC 0/3] Atari DRM driver

2025-05-25 Thread Geert Uytterhoeven
Hi Eero, On Thu, 22 May 2025 at 00:56, Eero Tamminen wrote: > On 21.5.2025 10.06, Geert Uytterhoeven wrote: > > On Wed, 21 May 2025 at 01:59, Eero Tamminen wrote: > >> I tried your "atari-drm-wip-v1" branch commits on top of 6.14. > > > > Thanks for te

Re: [PATCH v5 4/4] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

2025-05-23 Thread Geert Uytterhoeven
L(x) ((x) << 16) > +#define PHYTCLKSETR_TCLKPRPRCTL(x) ((x) << 24) > + > +#define PHYTHSSETR 0x024 > +#define PHYTHSSETR_THSEXITCTL(x) ((x) << 0) > +#define PHYTHSSETR_THSTRAILCTL(x) ((x) << 8) > +#define PHYTHSSETR_THSZEROCTL(x)

Re: [PATCH v5 3/4] dt-bindings: display: bridge: renesas,dsi: Add support for RZ/V2H(P) SoC

2025-05-23 Thread Geert Uytterhoeven
- renesas,r9a07g044-mipi-dsi # RZ/G2{L,LC} > + - renesas,r9a07g054-mipi-dsi # RZ/V2L > + - const: renesas,rzg2l-mipi-dsi > >reg: > maxItems: 1 The rest LGTM, so Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH v5 2/4] clk: renesas: r9a09g057: Add clock and reset entries for DSI and LCDC

2025-05-23 Thread Geert Uytterhoeven
CSDIV0_DIVCTL2, dtable_16_128), > + > + DEF_PLLDSI_DIV(".plldsi_sdiv2", CLK_PLLDSI_SDIV2, CLK_PLLDSI, ".plldsi_gear", CLK_PLLDSI_GEAR ... > + CSDIV1_DIVCTL2, dtable_2_32), > > DEF_DDIV(".pllgpu_gear", CLK_PLLGPU_GEAR, CLK_PLLGPU, CDDIV3_

Re: [PATCH v5 1/4] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-05-23 Thread Geert Uytterhoeven
/* PLL_M component of (output * 65536 > * PLL_P) */ > + output = p.m * 65536ULL * > OSC_CLK_IN_MEGA; mul_u32(p.m * 65536, OSC_CLK_IN_MEGA) > + /* PLL_K component of (output * 65536 > * PLL_P

Re: [PATCH/RFC 0/3] Atari DRM driver

2025-05-21 Thread Geert Uytterhoeven
Hi Eero, On Wed, 21 May 2025 at 01:59, Eero Tamminen wrote: > On 23.1.2023 17.10, Geert Uytterhoeven wrote: > > On Mon, Jan 23, 2023 at 4:09 PM John Paul Adrian Glaubitz > > wrote: > >> On 11/25/22 21:31, Geert Uytterhoeven wrote: > >>> This RFC patch serie

Re: [PATCH v5 05/12] drm: renesas: rz-du: mipi_dsi: Use VCLK for HSFREQ calculation

2025-05-20 Thread Geert Uytterhoeven
k * 1000); > + vclk_rate = clk_get_rate(dsi->vclk); > + if (vclk_rate != mode->clock * MILLI) > + dev_info(dsi->dev, "Requested vclk rate %lu, actual %lu > mismatch\n", > + mode->clock * MILLI, vclk_rate); Lik

[PATCH v2] drm/sitronix: Remove broken backwards-compatibility layer

2025-05-20 Thread Geert Uytterhoeven
selected by another symbol (which they are not), they can never be enabled, and no backwards compatibility is provided. Drop the broken mechanism and the old symbols. Fixes: 9b8f32002cddf792 ("drm/sitronix: move tiny Sitronix drivers to their own subdir") Signed-off-by: Geert Uytterhoev

Re: [PATCH] drm/sitronix: Fix broken backwards-compatibility layer

2025-05-20 Thread Geert Uytterhoeven
Hi Thomas, On Tue, 20 May 2025 at 15:04, Thomas Zimmermann wrote: > Am 20.05.25 um 14:40 schrieb Geert Uytterhoeven: > > When moving the Sitronix DRM drivers and renaming their Kconfig symbols, > > the old symbols were kept, aiming to provide a seamless migration path > &g

[PATCH] drm/sitronix: Fix broken backwards-compatibility layer

2025-05-20 Thread Geert Uytterhoeven
("drm/sitronix: move tiny Sitronix drivers to their own subdir") Signed-off-by: Geert Uytterhoeven --- arch/arm/configs/davinci_all_defconfig must be updated after this has hit upstream. --- drivers/gpu/drm/sitronix/Kconfig | 14 -- 1 file changed, 8 insertions(+), 6 deletion

Re: [PATCH] dt-bindings: gpu: mali-bifrost: Add compatible for RZ/V2N SoC

2025-05-05 Thread Geert Uytterhoeven
nd the existing schema > validation accordingly. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with tech

Re: `u64` by `u64` div/mod in DRM QR for arm32

2025-05-05 Thread Geert Uytterhoeven
tlin.com/linux/v6.14.5/source/include/linux/math64.h#L60 But you better think twice before using it, especially in performance-critical code. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m6

Re: [PATCH] video: fbdev: arkfb: Cast ics5342_init() allocation type

2025-05-02 Thread Geert Uytterhoeven
Hi Helge, On Tue, 29 Apr 2025 at 22:17, Helge Deller wrote: > On 4/28/25 08:36, Geert Uytterhoeven wrote: > > On Sat, 26 Apr 2025 at 13:33, Helge Deller wrote: > >> On 4/26/25 08:23, Kees Cook wrote: > >>> In preparation for making the kmalloc family of allocator

Re: [PATCH v6 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-28 Thread Geert Uytterhoeven
Hi Marcus, On Tue, 29 Apr 2025 at 08:15, Marcus Folkesson wrote: > On Thu, Apr 24, 2025 at 10:38:33AM +0200, Geert Uytterhoeven wrote: > > [...] > > > > + /* > > > +* As the display supports grayscale, all pixels >

Re: [PATCH] vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering

2025-04-28 Thread Geert Uytterhoeven
oid the confusion by replacing the "n" modifier with "hR", aka > reverse host ordering. It is inspired by the existing %p[mM]R printf > format. > > Reported-by: Geert Uytterhoeven > Closes: > https://lore.kernel.org/r/CAMuHMdV9tX=TG7E_CrSF=2py206txf+_y

Re: [PATCH] video: fbdev: arkfb: Cast ics5342_init() allocation type

2025-04-27 Thread Geert Uytterhoeven
struct dac_info * ics5342_init(dac_read_regs_t drr, > > dac_write_regs_t dwr, void *data) > > { > > - struct dac_info *info = kzalloc(sizeof(struct ics5342_info), > > GFP_KERNEL); > > + struct dac_info *info = (struct dac_info *)kzalloc(sizeof(struct &g

Re: [PATCH v6 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-24 Thread Geert Uytterhoeven
*/ So the driver actually supports D1 and D2, and XRGB should be inverted while converting to monochrome (and grayscale, which is not yet implemented). > +* > +* For monochrome formats, write the same value twice > to get > +* either a black or white pixel

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-23 Thread Geert Uytterhoeven
Hi Andy, On Wed, 23 Apr 2025 at 18:30, Andy Shevchenko wrote: > On Wed, Apr 23, 2025 at 04:50:02PM +0200, Geert Uytterhoeven wrote: > > On Wed, 23 Apr 2025 at 15:39, Petr Mladek wrote: > > > On Tue 2025-04-22 10:43:59, Geert Uytterhoeven wrote: > > ... > > > &

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-23 Thread Geert Uytterhoeven
Hi Petr, On Wed, 23 Apr 2025 at 15:39, Petr Mladek wrote: > On Tue 2025-04-22 10:43:59, Geert Uytterhoeven wrote: > > On Tue, 22 Apr 2025 at 10:30, Aditya Garg wrote: > > > On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote: > > > > On Tue, 8 Apr 2025 at 08:48, Adi

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Geert Uytterhoeven
Hi Andy, On Tue, 22 Apr 2025 at 12:16, Andy Shevchenko wrote: > On Tue, Apr 22, 2025 at 10:43:59AM +0200, Geert Uytterhoeven wrote: > > On Tue, 22 Apr 2025 at 10:30, Aditya Garg wrote: > > > On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote: > > > > On Tue, 8

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Geert Uytterhoeven
Hi Andy, On Tue, 22 Apr 2025 at 12:12, Andy Shevchenko wrote: > On Tue, Apr 22, 2025 at 10:07:33AM +0200, Geert Uytterhoeven wrote: > > On Tue, 8 Apr 2025 at 08:48, Aditya Garg wrote: > > ... > > > > +Generic FourCC code > > > +--- >

Re: [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-04-22 Thread Geert Uytterhoeven
Hi Pekka, On Tue, 22 Apr 2025 at 12:01, Pekka Paalanen wrote: > On Tue, 22 Apr 2025 11:41:29 +0200 > Geert Uytterhoeven wrote: > > On Tue, 22 Apr 2025 at 11:11, Pekka Paalanen > > wrote: > > > On Mon, 21 Apr 2025 17:50:39 +0300 > > > Laurent Pinchart wrote

Re: [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-04-22 Thread Geert Uytterhoeven
; > On 01/04/2025 16:27, Pekka Paalanen wrote: > > > > > On Mon, 31 Mar 2025 13:53:37 +0300 Pekka Paalanen wrote: > > > > >> On Mon, 31 Mar 2025 11:21:35 +0300 Laurent Pinchart wrote: > > > > >>> On Mon, Mar 31, 2025 at 10:54:46AM +0300, Pekka P

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Geert Uytterhoeven
Hi Aditya, CC netdev On Tue, 22 Apr 2025 at 10:30, Aditya Garg wrote: > On 22-04-2025 01:37 pm, Geert Uytterhoeven wrote: > > On Tue, 8 Apr 2025 at 08:48, Aditya Garg wrote: > >> From: Hector Martin > >> > >> %p4cc is designed for DRM/V4L2 FourCCs with

Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

2025-04-22 Thread Geert Uytterhoeven
05067) > + > +Examples for a big-endian machine, given &(u32)0x67503030:: > + > + %p4ch gP00 (0x67503030) > + %p4cn 00Pg (0x30305067) This doesn't look right to me, as network byte order is big endian? Note that I didn't check the code. > + %p4

Re: [PATCH v3 10/15] drm: renesas: rz-du: mipi_dsi: Use mHz for D-PHY frequency calculations

2025-04-22 Thread Geert Uytterhoeven
he last factor unsigned long long. "vclk_rate * bpp" is still unsigned long, causing overflow on 32-bit. As there is no rounding variant of mul_u64_u32_div(), you probably want to use mul_u32_u32() instead. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There&

Re: [PATCH 2/4] dt-bindings: gpu: mali-bifrost: Add compatible for RZ/G3E SoC

2025-04-16 Thread Geert Uytterhoeven
a validation accordingly. > > Signed-off-by: Tommaso Merciai Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call my

Re: [PATCH v2 15/15] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

2025-04-16 Thread Geert Uytterhoeven
LL_DSI_LIMITS(), i.e. why can't you use the latter? > > static inline struct rzg2l_mipi_dsi * Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I

Re: [PATCH v2 01/15] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-04-16 Thread Geert Uytterhoeven
2, .max = 32 }, \ > + .fvco = { .min = 1600 * MEGA, .max = 3200 * MEGA } \ > + } \ > + > +/** > + * rzv2h_dsi_get_pll_parameters_values - Finds the best combination of PLL > parameters &g

Re: [PATCH v2 01/15] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-04-15 Thread Geert Uytterhoeven
= 1, .max = 4 },\ > + .s = { .min = 0, .max = 6 },\ > + .k = { .min = -32768, .max = 32767 }, \ > + .csdiv = { .min = 2, .max = 32 }, \ > +

Re: [PATCH v2 02/15] clk: renesas: r9a09g057: Add clock and reset entries for DSI and LCDC

2025-04-15 Thread Geert Uytterhoeven
be inverted? > +#define CSDIV1_DIVCTL2 DDIV_PACK(CPG_CSDIV1, 8, 4, CSDIV_NO_MON) > > #define SSEL0_SELCTL2 SMUX_PACK(CPG_SSEL0, 8, 1) > #define SSEL0_SELCTL3 SMUX_PACK(CPG_SSEL0, 12, 1) Gr{oetje,eeting}s, Geert -- Geert Uytterho

Re: [PATCH v3 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-10 Thread Geert Uytterhoeven
ever did it but Geert has some patches for this. [1] needs an update, and still more rework to make them acceptable. > > Please compare > > https://www.marcusfolkesson.se/xrgb.png > > and > > https://www.marcusfolkesson.se/c1.png Yep, the latter is using the correct lo

Re: [PATCH 04/19] drm: Pass the format info to .fb_create()

2025-04-10 Thread Geert Uytterhoeven
ä > drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c | 3 ++- Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I

Re: [PATCH v2 10/15] drm: renesas: rz-du: mipi_dsi: Use mHz for D-PHY frequency calculations

2025-04-09 Thread Geert Uytterhoeven
capitalization of the "hz" part, it is not clear that the "m" stands for "milli" instead of "mega". Perhaps hsfreq_mHz or hsfreq_millihz? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

Re: [RFC] PCI: add CONFIG_MMU dependency

2025-04-08 Thread Geert Uytterhoeven
people from disabling MMU support on a system that has both a PCI bus and an MMU. But other people may not agree, or care? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with te

Re: [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-03-27 Thread Geert Uytterhoeven
Hi Pekka, On Thu, 27 Mar 2025 at 16:59, Pekka Paalanen wrote: > On Thu, 27 Mar 2025 16:21:16 +0200 > Tomi Valkeinen wrote: > > On 27/03/2025 11:20, Pekka Paalanen wrote: > > > On Wed, 26 Mar 2025 15:55:18 +0200 > > > Tomi Valkeinen wrote: > > >> On

Re: [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-03-26 Thread Geert Uytterhoeven
#x27;4') /* > non-subsampled Cr (1) and Cb (2) planes */ > > +/* Greyscale formats */ > + > +#define DRM_FORMAT_Y8 fourcc_code('G', 'R', 'E', 'Y') /* 8-bit > Y-only */ This format differs from e.g. DRM_FORMAT_R8, which encodes the number of bi

[PATCH] pinctrl: PINCTRL_AMDISP should depend on DRM_AMD_ISP

2025-03-18 Thread Geert Uytterhoeven
not support the AMD ISP. Fixes: e97435ab09f3ad7b ("pinctrl: amd: isp411: Add amdisp GPIO pinctrl") Signed-off-by: Geert Uytterhoeven --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index cbb81f

Re: [PATCH 2/3] arm64: dts: renesas: r9a09g057: Add Mali-G31 GPU node

2025-03-06 Thread Geert Uytterhoeven
On Tue, 18 Feb 2025 at 12:59, Prabhakar wrote: > > From: Lad Prabhakar > > Add Mali-G31 GPU node to SoC DTSI. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v6.15. Gr{oetje,eeting}s, Geert --

Re: [PATCH 2/2] dt-bindings: display: mitsubishi,aa104xd12: Adjust allowed and required properties

2025-03-06 Thread Geert Uytterhoeven
> Signed-off-by: Rob Herring (Arm) Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But w

Re: [PATCH 1/2] dt-bindings: display: mitsubishi,aa104xd12: Allow jeida-18 for data-mapping

2025-03-06 Thread Geert Uytterhoeven
(Arm) Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say

Re: [PATCH 3/3] arm64: dts: renesas: r9a09g057h44-rzv2h-evk: Enable Mali-G31

2025-03-06 Thread Geert Uytterhoeven
On Tue, 18 Feb 2025 at 12:59, Prabhakar wrote: > From: Lad Prabhakar > > Enable Mali-G31 (GPU) node on EVK board. > > Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-devel for v6.15. Gr{oetje,eeting}s, G

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-02-21 Thread Geert Uytterhoeven
pp, but that is using bitplanes. There is already some sort of consensus to not expose bitplanes to userspace in DRM, so limiting to 1, 2, 4, and 8 bpp (which can be converted from C[1248]) is fine. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-02-18 Thread Geert Uytterhoeven
--+++ > + * | 2 | * DRM_FORMAT_C2 | * DRM_FORMAT_R2 | > + * ++++ > + * | 1 | * DRM_FORMAT_C1 | * DRM_FORMAT_R1 | > + * +-

Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-05 Thread Geert Uytterhoeven
gt; On Tue, Feb 04, 2025 at 09:07:05AM +, Biju Das wrote: > > > > > > -Original Message- > > > > > > From: dri-devel On > > > > > > Behalf Of Geert Uytterhoeven > > > > > > Sent: 03 February 2025 11:06 > > >

Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-03 Thread Geert Uytterhoeven
vailable(np)) > + if (!np) > return -ENODEV; ... fixes the reference count in case of an unavailable node... > > rgb = devm_kzalloc(dc->dev, sizeof(*rgb), GFP_KERNEL); ... but as np is stored below, it must not be freed when it goes out of context? Gr{o

Re: [PATCH RFT 2/2] drm/bridge: ti-sn65dsi86: Use per-client debugfs entry

2025-01-28 Thread Geert Uytterhoeven
tible = "ti,sn65dsi86"; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking

Re: [PATCH RFT 2/2] drm/bridge: ti-sn65dsi86: Use per-client debugfs entry

2025-01-27 Thread Geert Uytterhoeven
= 0x0001 [0xf5] = 0x [0xf6] = 0x0002 [0xf7] = 0x [0xf8] = 0x0001 Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversatio

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-21 Thread Geert Uytterhoeven
Hi Dmitry, CC sfr On Tue, Jan 21, 2025 at 11:44 AM Dmitry Baryshkov wrote: > On Tue, 21 Jan 2025 at 11:13, Geert Uytterhoeven wrote: > > On Tue, Jan 7, 2025 at 12:31 PM Dmitry Baryshkov > > wrote: > > > On Sat, 14 Dec 2024 15:37:04 +0200, Dmitry Baryshkov wrote: >

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2025-01-21 Thread Geert Uytterhoeven
misc/drm-misc-next' into drm-tip"). What am I missing? Thanks! P.S. Sima: noticed while resolving a merge conflict using drm-tip. Thx! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In p

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-16 Thread Geert Uytterhoeven
gt; for a very long time on those platforms. > > I tried to look around, but I did not find any mentions that CREATE_DUMB > should only be used for RGB buffers. Is anyone outside the core > developers even aware of it? > > If we don't use dumb buffers there, where do w

[PATCH next] cgroup/rdma: Drop bogus PAGE_COUNTER select

2025-01-16 Thread Geert Uytterhoeven
e. Remove it. Fixes: b168ed458ddecc17 ("kernel/cgroup: Add "dmem" memory accounting cgroup") Closes: https://lore.kernel.org/camuhmdumpfahsnzwx2ib5yfh8rjjw25lncnyujnbgckotux...@mail.gmail.com Signed-off-by: Geert Uytterhoeven --- Broken commit is in drm/drm-next Partial fix is in dr

Re: [PATCH v2 04/10] drm/fourcc: Add DRM_FORMAT_Y10_LE32

2025-01-15 Thread Geert Uytterhoeven
Hi Tomi, On Wed, Jan 15, 2025 at 3:34 PM Tomi Valkeinen wrote: > On 15/01/2025 16:08, Geert Uytterhoeven wrote: > > On Wed, Jan 15, 2025 at 2:46 PM Tomi Valkeinen > > wrote: > >> On 15/01/2025 14:52, Geert Uytterhoeven wrote: > >>> On Wed, Jan 15, 2025 at

Re: [PATCH v2 04/10] drm/fourcc: Add DRM_FORMAT_Y10_LE32

2025-01-15 Thread Geert Uytterhoeven
Hi Tomi, On Wed, Jan 15, 2025 at 2:46 PM Tomi Valkeinen wrote: > On 15/01/2025 14:52, Geert Uytterhoeven wrote: > > On Wed, Jan 15, 2025 at 1:42 PM Tomi Valkeinen > > wrote: > >> On 15/01/2025 14:33, Geert Uytterhoeven wrote: > >>> On Wed, Jan 15, 2025 at

Re: [PATCH v2 04/10] drm/fourcc: Add DRM_FORMAT_Y10_LE32

2025-01-15 Thread Geert Uytterhoeven
Hi Tomi, On Wed, Jan 15, 2025 at 1:42 PM Tomi Valkeinen wrote: > On 15/01/2025 14:33, Geert Uytterhoeven wrote: > > On Wed, Jan 15, 2025 at 12:11 PM Tomi Valkeinen > > wrote: > >> On 15/01/2025 12:33, Geert Uytterhoeven wrote: > >>> On Wed, Jan 15, 2025 at

Re: [PATCH v2 04/10] drm/fourcc: Add DRM_FORMAT_Y10_LE32

2025-01-15 Thread Geert Uytterhoeven
Hi Tomi, On Wed, Jan 15, 2025 at 12:11 PM Tomi Valkeinen wrote: > On 15/01/2025 12:33, Geert Uytterhoeven wrote: > > On Wed, Jan 15, 2025 at 10:04 AM Tomi Valkeinen > > wrote: > >> Add Y10_LE32, a 10 bit greyscale format, with 3 pixels packed into > >> 32-bit c

Re: [PATCH v2 04/10] drm/fourcc: Add DRM_FORMAT_Y10_LE32

2025-01-15 Thread Geert Uytterhoeven
;P', 'A', '4') /* [31:0] > x:Y2:Y1:Y0 2:10:10:10 little endian */ R10_LE32? Or R10_PA4? Does LE32 have a meaning? My first guess just reading the subject was wrong ("little endian 32-bit" ;-) Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH v2 03/10] drm/fourcc: Add DRM_FORMAT_Y8

2025-01-15 Thread Geert Uytterhoeven
el value and brightness) */ #define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */ See also commit 8aba4d30520ed656 ("drm/fourcc: Clarify the meaning of single-channel "red""). Gr{oetje,eeting}s,

Re: [PATCH v2.1 1/1] kernel/cgroup: Add "dmem" memory accounting cgroup

2025-01-14 Thread Geert Uytterhoeven
device > + memory usage based on the cgroup hierarchy. > + > + As an example, it allows you to restrict VRAM usage for applications > + in the DRM subsystem. > + Do you envision other users than DRM? Perhaps this should depend on DRM for now? Gr{oetje,eeting}s

Re: [PATCH] m68k: Fix VGA I/O defines

2025-01-08 Thread Geert Uytterhoeven
not generally > available. > > Signed-off-by: Thomas Zimmermann > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202501071629.dneswlm8-...@intel.com/ > Fixes: 5c3f968712ce ("m68k/video: Create ") > Cc: Geert Uytterhoeven > Cc: linux-f

Re: [PATCH] dt-bindings: display: Correct indentation and style in DTS example

2025-01-08 Thread Geert Uytterhoeven
fit on a single line. > +reg = <0xfea4 0x1000>; > +power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + clocks = <&cpg CPG_MOD 711>; > +resets = <&cpg 711>; > }; Reviewed-by: Geert Uytterhoeven # renesa

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Fix multiple instances

2025-01-07 Thread Geert Uytterhoeven
Hi Doug, On Tue, Jan 7, 2025 at 6:27 PM Doug Anderson wrote: > On Wed, Dec 11, 2024 at 12:27 AM Geert Uytterhoeven > wrote: > > On Tue, Dec 10, 2024 at 6:09 PM Doug Anderson wrote: > > > On Tue, Dec 10, 2024 at 6:19 AM Geert Uytterhoeven > > > wrote: > > &g

Re: [PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-18 Thread Geert Uytterhoeven
Hi Jocelyn, On Wed, Dec 18, 2024 at 3:58 PM Jocelyn Falempe wrote: > On 18/12/2024 15:18, Petr Mladek wrote: > > On Wed 2024-12-18 12:41:39, Jocelyn Falempe wrote: > >> On 18/12/2024 12:00, Geert Uytterhoeven wrote: > >>> On Wed, Dec 18, 2024 at 11:14 AM

Re: [PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-18 Thread Geert Uytterhoeven
Hi Petr, On Wed, Dec 18, 2024 at 3:18 PM Petr Mladek wrote: > On Wed 2024-12-18 12:41:39, Jocelyn Falempe wrote: > > On 18/12/2024 12:00, Geert Uytterhoeven wrote: > > > On Wed, Dec 18, 2024 at 11:14 AM Jocelyn Falempe > > > wrote: > > > > On 17/

Re: [PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-18 Thread Geert Uytterhoeven
Hi Jocelyn, On Wed, Dec 18, 2024 at 11:14 AM Jocelyn Falempe wrote: > On 17/12/2024 15:54, Geert Uytterhoeven wrote: > > On Tue, Dec 17, 2024 at 3:46 PM Jocelyn Falempe wrote: > >> On 17/12/2024 15:19, Geert Uytterhoeven wrote: > >>> On Wed, Dec 4, 2024 at 6:41 PM

Re: [PATCH] drm/mediatek: stop selecting foreign drivers

2024-12-18 Thread Geert Uytterhoeven
P_AUX_BUS > @@ -39,6 +35,5 @@ config DRM_MEDIATEK_HDMI > tristate "DRM HDMI Support for Mediatek SoCs" > depends on DRM_MEDIATEK > select SND_SOC_HDMI_CODEC if SND_SOC > - select PHY_MTK_HDMI > help > DRM/KMS HDMI driver for Med

Re: [PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-17 Thread Geert Uytterhoeven
Hi Jocelyn. On Tue, Dec 17, 2024 at 3:46 PM Jocelyn Falempe wrote: > On 17/12/2024 15:19, Geert Uytterhoeven wrote: > > On Wed, Dec 4, 2024 at 6:41 PM Jocelyn Falempe wrote: > >> drm_log is a simple logger that uses the drm_client API to print the kmsg > >> boot log

Re: [PATCH v9 0/6] drm/log: Introduce a new boot logger to draw the kmsg on the screen

2024-12-17 Thread Geert Uytterhoeven
display, as before: CONFIG_DRM_CLIENT_DEFAULT_FBDEV=y # CONFIG_DRM_CLIENT_DEFAULT_LOG is not set CONFIG_DRM_CLIENT_DEFAULT="fbdev" Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@lin

Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

2024-12-17 Thread Geert Uytterhoeven
CC Saravana On Tue, Dec 17, 2024 at 2:29 PM Geert Uytterhoeven wrote: > On Mon, Dec 16, 2024 at 2:33 PM Geert Uytterhoeven > wrote: > > On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen > > wrote: > > > From: Tomi Valkeinen > > > > > > Add support

Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

2024-12-17 Thread Geert Uytterhoeven
On Mon, Dec 16, 2024 at 2:33 PM Geert Uytterhoeven wrote: > On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen > wrote: > > From: Tomi Valkeinen > > > > Add support for the mini DP output on the Gray Hawk board. > > > > Signed-off-by: Tomi Valkeinen > > Re

Re: [PATCH v5 3/7] dt-bindings: display: renesas, du: Add missing constraints

2024-12-17 Thread Geert Uytterhoeven
maxItems: 4 > > renesas,vsps: >minItems: 4 > + maxItems: 4 AFAIK these two additions are not needed, as they already match the values defined at the top level. The rest LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

2024-12-16 Thread Geert Uytterhoeven
Hi Tomi, On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Add support for the mini DP output on the Gray Hawk board. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Thanks for your patch

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-12-11 Thread Geert Uytterhoeven
Hi Doug, On Tue, Dec 10, 2024 at 6:09 PM Doug Anderson wrote: > On Tue, Dec 10, 2024 at 6:19 AM Geert Uytterhoeven > wrote: > > Each bridge instance creates up to four auxiliary devices with different > > names. However, their IDs are always zero, causing duplicate filename

Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

2024-12-11 Thread Geert Uytterhoeven
Hi Tomi, On Tue, Dec 10, 2024 at 7:10 PM Tomi Valkeinen wrote: > On 10/12/2024 18:34, Geert Uytterhoeven wrote: > > On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen > > wrote: > >> From: Tomi Valkeinen > >> > >> Add support for the mini DP output on th

Re: [PATCH v3 10/10] arm64: dts: renesas: gray-hawk-single: Add DisplayPort support

2024-12-10 Thread Geert Uytterhoeven
Hi Tomi, On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Add support for the mini DP output on the Gray Hawk board. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Thanks for your patch

Re: [PATCH v3 09/10] arm64: dts: renesas: r8a779h0: Add display support

2024-12-10 Thread Geert Uytterhoeven
On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Add the device nodes for supporting DU and DSI. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Reviewed-by: Geert Uytterhoeven i.e. will q

Re: [PATCH v3 08/10] arm64: dts: renesas: gray-hawk-single: Fix indentation

2024-12-10 Thread Geert Uytterhoeven
On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Fix the indent on the two regulators. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Reviewed-by: Geert Uytterhoeven i.e. will queue in re

[PATCH v2] drm/bridge: ti-sn65dsi86: Fix multiple instances

2024-12-10 Thread Geert Uytterhoeven
vers") Signed-off-by: Geert Uytterhoeven --- On the White Hawk development board: /sys/bus/auxiliary/devices/ |-- ti_sn65dsi86.aux.1068 |-- ti_sn65dsi86.aux.4140 |-- ti_sn65dsi86.bridge.1068 |-- ti_sn65dsi86.bridge.4140 |-- ti_sn65dsi86.gpio.1068 |-- ti_sn65dsi86.gpio.

Re: [PATCH v3 05/10] clk: renesas: r8a779h0: Add display clocks

2024-12-08 Thread Geert Uytterhoeven
Hi Tomi, On Mon, Dec 9, 2024 at 6:26 AM Tomi Valkeinen wrote: > On 06/12/2024 15:43, Geert Uytterhoeven wrote: > > On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen > > wrote: > >> From: Tomi Valkeinen > >> > >> Add display related clocks for DU, DSI

Re: [PATCH v3 05/10] clk: renesas: r8a779h0: Add display clocks

2024-12-06 Thread Geert Uytterhoeven
Hi Tomi, On Fri, Dec 6, 2024 at 10:33 AM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Add display related clocks for DU, DSI, FCPVD, and VSPD. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > Tested-by: Geert Uytterhoeven Reviewed-by: Geert Uy

Re: [PATCH v2 02/10] drm/rcar-du: Write DPTSR only if there are more than one crtc

2024-12-05 Thread Geert Uytterhoeven
DPTSR2. And apparently we had this discussion before... https://lore.kernel.org/all/camuhmdxxf4oepnylvp84ohsa+wdehcnjbxnhjyo7-1vxpbj...@mail.gmail.com Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH 8/9] arm64: dts: renesas: r8a779h0: Add display support

2024-12-04 Thread Geert Uytterhoeven
nirq: Setting trigger mode 8 for irq 91 failed > vsp1 fea2.vsp: failed to request IRQ > > I didn't dig further yet. Yeah, I don't think the GIC supports anything but IRQ_TYPE_LEVEL_HIGH. Which brings us to the two ISP nodes on R-Car V4H and V4M, both using IRQ_TYPE_LEVEL_LOW. Ni

Re: [PATCH 0/9] drm: Add DSI/DP support for Renesas r8a779h0 V4M and grey-hawk board

2024-12-04 Thread Geert Uytterhoeven
st identical to Renesas > r8a779g0 and white-hawk board. Thanks for your series! > Signed-off-by: Tomi Valkeinen Woot, SoB tags for cover letters ;-) Works fine up to 2560x1440 (I don't have a 4K display). Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Gee

Re: [PATCH 2/9] dt-bindings: display: renesas,du: Add r8a779h0

2024-12-03 Thread Geert Uytterhoeven
o add h0 to the g0 block in the conditional properties > below. With that, Which is not sufficient, as the DU on R-Car V4M has only a single channel, unlike on R-Car V3U and V4H. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-25 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Nov 22, 2024 at 10:15 AM Maxime Ripard wrote: > On Fri, Nov 22, 2024 at 09:36:16AM +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 4, 2024 at 6:30 PM Nathan Chancellor wrote: > > > On Fri, Oct 18, 2024 at 03:10:10PM +, Arnd Bergmann wrote: > >

  1   2   3   4   5   6   7   8   9   10   >