Hi Anusha,
On Fri, 30 May 2025 at 20:28, Anusha Srivatsa <asriv...@redhat.com> wrote:
> Move to using the new API devm_drm_panel_alloc() to allocate the
> panel.
>
> Reviewed-by: Neil Armstrong <neil.armstr...@linaro.org>
> Signed-off-by: Anusha Srivatsa <asriv...@redhat.com>
Thanks for your patch!
I have a generic comment that applies to all patches in the series.
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -424,9 +424,11 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
> struct otm8009a *ctx;
> int ret;
>
> - ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
The old code used sizeof(*ctx) instead of an explicit type, for
increased type-safety.
> - if (!ctx)
> - return -ENOMEM;
> + ctx = devm_drm_panel_alloc(dev, struct otm8009a, panel,
Can't you use __typeof(*ctx) instead of the explicit type here, too?
> + &otm8009a_drm_funcs,
> + DRM_MODE_CONNECTOR_DSI);
> + if (IS_ERR(ctx))
> + return PTR_ERR(ctx);
>
> ctx->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> GPIOD_OUT_LOW);
> if (IS_ERR(ctx->reset_gpio)) {
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
