On Wed, 2025-02-05 at 11:53 +0100, Erik Faye-Lund wrote:
> On Tue, 2025-02-04 at 17:28 -0600, Rob Herring (Arm) wrote:
> > Use an enum instead of #defines for panthor IOCTLs. This allows the
> > header to be used with Rust code as bindgen can't handle
On Tue, 2025-02-04 at 17:28 -0600, Rob Herring (Arm) wrote:
> Use an enum instead of #defines for panthor IOCTLs. This allows the
> header to be used with Rust code as bindgen can't handle complex
> defines.
>
Unfortunately, this goes in the opposite direction than what I was
asked to do here:
On Thu, 2025-01-09 at 13:14 +, Daniel Stone wrote:
> Hi Eric,
>
> On Thu, 19 Dec 2024 at 17:49, wrote:
> > MediaTek (MTK) uses some unique tiled memory formats
> > for video decoding. Add these to the uapi drm_fourcc.h
> > so that we can use them in Mesa, GStreamer, and other
> > tools/librar
On Tue, 2024-10-29 at 10:15 +, Liviu Dudau wrote:
> On Tue, Oct 29, 2024 at 10:46:29AM +0100, Erik Faye-Lund wrote:
> > Enums are always signed, and assigning 1u << 31 to it invokes
> > implementation defined behavior. It's not a great idea to depend on
> > th
Enums are always signed, and assigning 1u << 31 to it invokes
implementation defined behavior. It's not a great idea to depend on this
in the UAPI, and it turns out no other UAPI does either.
So let's do what other UAPI does, and use defines instead. This way we
won't get unexpected issues if comp
On Thu, 2024-10-17 at 12:08 +0200, Boris Brezillon wrote:
> On Thu, 17 Oct 2024 10:51:32 +0200
> Erik Faye-Lund wrote:
>
> > On Wed, 2024-10-16 at 16:18 +0200, Boris Brezillon wrote:
> > > On Wed, 16 Oct 2024 16:05:55 +0200
> > > Erik Faye-Lund wrote:
> >
On Wed, 2024-10-16 at 16:18 +0200, Boris Brezillon wrote:
> On Wed, 16 Oct 2024 16:05:55 +0200
> Erik Faye-Lund wrote:
>
> > On Wed, 2024-10-16 at 15:02 +0100, Robin Murphy wrote:
> > > On 2024-10-16 2:50 pm, Erik Faye-Lund wrote:
> > > > On Wed, 2024-10-16
On Wed, 2024-10-16 at 15:02 +0100, Robin Murphy wrote:
> On 2024-10-16 2:50 pm, Erik Faye-Lund wrote:
> > On Wed, 2024-10-16 at 15:16 +0200, Erik Faye-Lund wrote:
> > > On Thu, 2024-02-29 at 17:22 +0100, Boris Brezillon wrote:
> > > > +/**
> > &g
On Wed, 2024-10-16 at 15:47 +0200, Boris Brezillon wrote:
> On Wed, 16 Oct 2024 15:16:22 +0200
> Erik Faye-Lund wrote:
>
> > On Thu, 2024-02-29 at 17:22 +0100, Boris Brezillon wrote:
> > > +/**
> > > + * enum drm_panthor_sync_op_flags - Sync
On Wed, 2024-10-16 at 15:16 +0200, Erik Faye-Lund wrote:
> On Thu, 2024-02-29 at 17:22 +0100, Boris Brezillon wrote:
> > +/**
> > + * enum drm_panthor_sync_op_flags - Synchronization operation
> > flags.
> > + */
> >
On Thu, 2024-02-29 at 17:22 +0100, Boris Brezillon wrote:
> +/**
> + * enum drm_panthor_sync_op_flags - Synchronization operation flags.
> + */
> +enum drm_panthor_sync_op_flags {
> + /** @DRM_PANTHOR_SYNC_OP_HANDLE_TYPE_MASK: Synchronization
> handle type mask. */
> + DRM_PANTHOR_SYNC_OP_H
On Thu, 2024-04-25 at 12:39 +0200, Boris Brezillon wrote:
> We can use upd_ctx.timedout_mask directly, and the faulty_slots
> update
> in the flush_caches_failed situation is never used.
>
> Suggested-by: Suggested-by: Steven Price
Whoops? :)
> Signed-off-by: Boris Brezillon
> ---
> drivers/g
On Fri, 2020-02-28 at 10:43 +, Daniel Stone wrote:
> On Fri, 28 Feb 2020 at 10:06, Erik Faye-Lund
> wrote:
> > On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote:
> > > Yeah, changes on vulkan drivers or backend compilers should be
> > > fairly
> &g
On Fri, 2020-02-28 at 10:47 +0100, Daniel Vetter wrote:
> On Fri, Feb 28, 2020 at 10:29 AM Erik Faye-Lund
> wrote:
> > On Fri, 2020-02-28 at 13:37 +1000, Dave Airlie wrote:
> > > On Fri, 28 Feb 2020 at 07:27, Daniel Vetter <
> > > daniel.vet...@ffwl
On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote:
> On 28/02/2020 11:28, Erik Faye-Lund wrote:
> > On Fri, 2020-02-28 at 13:37 +1000, Dave Airlie wrote:
> > > On Fri, 28 Feb 2020 at 07:27, Daniel Vetter <
> > > daniel.vet...@ffwll.ch>
> > > w
On Fri, 2020-02-28 at 13:37 +1000, Dave Airlie wrote:
> On Fri, 28 Feb 2020 at 07:27, Daniel Vetter
> wrote:
> > Hi all,
> >
> > You might have read the short take in the X.org board meeting
> > minutes
> > already, here's the long version.
> >
> > The good news: gitlab.fd.o has become very popu
On Wed, Jun 14, 2017 at 10:32 AM, Dmitry Osipenko wrote:
> On 14.06.2017 10:56, Erik Faye-Lund wrote:
>> On Wed, Jun 14, 2017 at 1:16 AM, Dmitry Osipenko wrote:
>>> The blocking gather copy allocation is a major performance downside of the
>>> Host1x firewall, it may
On Wed, Jun 14, 2017 at 1:16 AM, Dmitry Osipenko wrote:
> The blocking gather copy allocation is a major performance downside of the
> Host1x firewall, it may take hundreds milliseconds which is unacceptable
> for the real-time graphics operations. Let's try a non-blocking allocation
> first as a
On Wed, Jun 14, 2017 at 1:15 AM, Dmitry Osipenko wrote:
> Check waits in the firewall in a way it is done for relocations.
>
> Signed-off-by: Dmitry Osipenko
> Reviewed-by: Mikko Perttunen
Reviewed-by: Erik Faye-Lund
___
dri-devel mail
> that doesn't explicitly specify the class effectively bypasses the firewall.
>
> Signed-off-by: Dmitry Osipenko
> Reviewed-by: Mikko Perttunen
Reviewed-by: Erik Faye-Lund
___
dri-devel mailing list
dri-devel@lists.freedesktop.or
On Wed, Jun 14, 2017 at 1:15 AM, Dmitry Osipenko wrote:
> There is no IOMMU on Tegra20, instead a GART would be picked as an IOMMU
> provider.
>
> Signed-off-by: Dmitry Osipenko
> Acked-by: Joerg Roedel
> ---
> drivers/gpu/drm/tegra/drm.c | 3 ++-
> drivers/gpu/host1x/dev.c| 3 ++-
> 2 file
;
> Signed-off-by: Dmitry Osipenko
Looks good as far as I can tell
Reviewed-by: Erik Faye-Lund
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
t; + window.src.y = plane->state->src.y1 >> 16;
> + window.src.w = drm_rect_width(&plane->state->src) >> 16;
> + window.src.h = drm_rect_height(&plane->state->src) >> 16;
> + window.dst.x = plane->state->dst.x1;
> +
own
> reset control, apparently it is not correct.
>
> Fixes: 33a8eb8d40ee ("drm/tegra: dc: Implement runtime PM")
> Signed-off-by: Dmitry Osipenko
Reviewed-by: Erik Faye-Lund
___
dri-devel mailing list
dri-devel@lists.freedesktop.
ter to userspace")
> Signed-off-by: Dmitry Osipenko
> Reviewed-by: Mikko Perttunen
Reviewed-by: Erik Faye-Lund
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
cdma *cdma, struct host1x_job *job);
> --
> 2.13.0
>
Reviewed-by: Erik Faye-Lund
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
- u32 offset;
> - u32 words;
> - u32 pad;
> -};
> -
> struct host1x_job_unpin_data {
> struct host1x_bo *bo;
> struct sg_table *sgt;
> --
> 2.13.0
>
Reviewed-by: Erik Faye-Lund
___
dri-devel ma
goto out;
> break;
> diff --git a/include/linux/host1x.h b/include/linux/host1x.h
> index aa323e43ae4e..561d6bb6580d 100644
> --- a/include/linux/host1x.h
> +++ b/include/linux/host1x.h
> @@ -233,7 +233,10 @@ struct host1x_job
mdbuf,
> if (reloc->cmdbuf.bo != cmdbuf || reloc->cmdbuf.offset != offset)
> return false;
>
> + /* relocation shift value validation isn't implemented yet */
> + if (reloc->shift)
> + return false;
>
host1x_job_unpin(job);
> wmb();
>
> return err;
> --
> 2.13.0
>
One subtle undocumented change here, is that wmb() now gets called in
the copy_gathers()-error case (just like it already does for the other
error-cases). That's seems l
;vaddr + page * PAGE_SIZE;
> else if (obj->gem.import_attach)
> --
> 2.13.0
>
Reviewed-by: Erik Faye-Lund
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
t;> [] (drm_ioctl) from [] (do_vfs_ioctl+0x9c/0x8e4)
>> [] (do_vfs_ioctl) from [] (SyS_ioctl+0x34/0x5c)
>> [] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x3c)
>>
>> Signed-off-by: Dmitry Osipenko
>> Reviewed-by: Erik Faye-Lund
>> ---
>> drivers/gpu/drm/tegra/drm.
try Osipenko
Outch, yeah.
Reviewed-by: Erik Faye-Lund
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
0x6c)
> [] (tegra_submit) from [] (drm_ioctl+0x1e4/0x3ec)
> [] (drm_ioctl) from [] (do_vfs_ioctl+0x9c/0x8e4)
> [] (do_vfs_ioctl) from [] (SyS_ioctl+0x34/0x5c)
> [] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x3c)
>
> Signed-off-by: Dmitry Osipenko
Look
On Fri, May 12, 2017 at 9:02 PM, Dmitry Osipenko wrote:
> If command buffer claims a number of words that is higher than its BO can
> fit and a relocation lays past the BO, a kernel OOPS will be fired on that
> relocation address patching. This was triggered by an opentegra Xorg driver
> that erro
On Mon, Apr 3, 2017 at 6:59 PM, Emil Velikov wrote:
> On 29 March 2017 at 23:24, Erik Faye-Lund wrote:
>> I get a few more symbols in my build tegra-libraries, so let's
>> include these in the whitelist as well.
>>
>> While we're at it, update the comment
I get a few more symbols in my build tegra-libraries, so let's
include these in the whitelist as well.
While we're at it, update the comment at the top.
Signed-off-by: Erik Faye-Lund
---
tegra/tegra-symbol-check | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --g
This makes the test run under the 'make check'-taget.
Signed-off-by: Erik Faye-Lund
---
tests/tegra/Makefile.am | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/tegra/Makefile.am b/tests/tegra/Makefile.am
index 8e625c8f..f8e2a146 100644
--- a/tests/tegra/M
On Tue, Nov 8, 2016 at 8:50 AM, Alexandre Courbot
wrote:
> Add FB modifiers to allow user-space to specify that a surface is in one
> of the two tiling formats supported by Tegra chips, and add support in
> the tegradrm driver to handle them properly. This is necessary for the
> display controlle
On Fri, Jan 30, 2015 at 10:49 AM, Thierry Reding
wrote:
> On Thu, Jan 29, 2015 at 02:18:41PM -0500, Sean Paul wrote:
>> On 64-bit targets, tegra_gem_mmap doesn't return the
>> offset to userspace. As such, subsequent calls to mmap(2)
>> fail. Add a new tegra_gem_mmap2 ioctl to fix this.
>>
>> Sign
On Fri, May 2, 2014 at 5:16 PM, Thierry Reding
wrote:
> On Fri, May 02, 2014 at 04:53:55PM +0200, Erik Faye-Lund wrote:
>> On Fri, May 2, 2014 at 4:06 PM, Thierry Reding
>> wrote:
>> > On Thu, Apr 10, 2014 at 07:13:22PM +0200, Erik Faye-Lund wrote:
>> >> &g
On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
wrote:
> +int drm_open(const char *path)
> +{
> + int fd, err;
> +
> + fd = open(path, O_RDWR);
> + if (fd < 0)
> + return -errno;
> +
> + err = drmSetMaster(fd);
> + if (err < 0) {
> + close(
On Fri, May 2, 2014 at 4:42 PM, Thierry Reding
wrote:
> On Thu, Apr 10, 2014 at 07:33:33PM +0200, Erik Faye-Lund wrote:
>> On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
>> wrote:
>> > From: Thierry Reding
>> >
>> > This library provides helpe
On Fri, May 2, 2014 at 4:25 PM, Thierry Reding
wrote:
> On Thu, Apr 10, 2014 at 07:28:16PM +0200, Erik Faye-Lund wrote:
>> On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
>> wrote:
>> > diff --git a/tests/tegra/gr2d-fill.c b/tests/tegra/gr2d-fill.c
>> >
On Fri, May 2, 2014 at 4:12 PM, Thierry Reding
wrote:
> On Thu, Apr 10, 2014 at 07:15:14PM +0200, Erik Faye-Lund wrote:
>> On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
>> wrote:
>> > diff --git a/libdrm.h b/libdrm.h
>> > new file mode 100644
>
On Fri, May 2, 2014 at 4:06 PM, Thierry Reding
wrote:
> On Thu, Apr 10, 2014 at 07:13:22PM +0200, Erik Faye-Lund wrote:
>>
>> But this raises the question, how is job->cmdbufs (and job->relocs)
>> supposed to get free'd?
>>
>> I'm a bit curious a
On Thu, Apr 10, 2014 at 7:20 PM, Erik Faye-Lund wrote:
> On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
> wrote:
>> From: Thierry Reding
>>
>> This test opens a device, dumps the version information and checks that
>> a Tegra DRM context can be opened on it.
>&
On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
wrote:
> From: Thierry Reding
>
> This library provides helpers for common functionality needed by test
> programs.
>
> Signed-off-by: Thierry Reding
> ---
> Changes in v2:
> - fix a couple of memory leaks and get rid of some unneeded code
>
> tes
On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
wrote:
> From: Thierry Reding
>
> This library provides helpers for common functionality needed by test
> programs.
>
> Signed-off-by: Thierry Reding
> ---
> Changes in v2:
> - fix a couple of memory leaks and get rid of some unneeded code
>
> tes
On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
wrote:
> diff --git a/tests/tegra/gr2d-fill.c b/tests/tegra/gr2d-fill.c
> new file mode 100644
> index ..b6ba35a9d668
> --- /dev/null
> +++ b/tests/tegra/gr2d-fill.c
> @@ -0,0 +1,146 @@
> +/*
> + * Copyright ? 2014 NVIDIA Corporation
> +
On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
wrote:
> From: Thierry Reding
>
> This test opens a device, dumps the version information and checks that
> a Tegra DRM context can be opened on it.
>
> Signed-off-by: Thierry Reding
Looks good!
ms.
>
> Signed-off-by: Thierry Reding
> Signed-off-by: Erik Faye-Lund
> Signed-off-by: Thierry Reding
Looks good to me!
On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
wrote:
> diff --git a/libdrm.h b/libdrm.h
> new file mode 100644
> index ..23926e6f6741
> --- /dev/null
> +++ b/libdrm.h
> @@ -0,0 +1,34 @@
> +/*
> + * Copyright ? 2014 NVIDIA Corporation
> + *
> + * Permission is hereby granted, free of
On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding
wrote:
> diff --git a/tegra/fence.c b/tegra/fence.c
> new file mode 100644
> index ..f58725ca8472
> --- /dev/null
> +++ b/tegra/fence.c
> +drm_public
> +int drm_tegra_fence_wait(struct drm_tegra_fence *fence)
> +{
> + return drm_teg
On Thu, Mar 20, 2014 at 4:23 PM, Erik Faye-Lund wrote:
> On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
> wrote:
>> From: Thierry Reding
>>
>> Hi,
>>
>> This series adds libdrm-tegra with a very lightweight API on top of the
>> kernel interfaces. Mos
On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
wrote:
> From: Thierry Reding
>
> Hi,
>
> This series adds libdrm-tegra with a very lightweight API on top of the
> kernel interfaces. Most of the functions provided here have been in use
> in various driver efforts in different incarnations. This i
On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
wrote:
> From: Thierry Reding
>
> This test opens a device, dumps the version information and checks that
> a Tegra DRM context can be opened on it.
>
> Signed-off-by: Thierry Reding
> ---
> configure.ac| 1 +
> tests/Makefile.am
On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
wrote:
> From: Thierry Reding
>
> Checks whether or not the compiler supports the -fvisibility option. If
> so it sets the VISIBILITY_CFLAGS variable which can be added to the per
> directory AM_CFLAGS where appropriate.
>
> Libraries can use the HA
On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
wrote:
> From: Thierry Reding
>
> This test uses the IOCTLs for job submission and fences to fill a sub-
> region of the screen to a specific color using gr2d.
>
> Signed-off-by: Thierry Reding
> ---
> tests/tegra/Makefile.am | 1 +
> tests/tegr
On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
wrote:
> diff --git a/tests/tegra/drm-test-tegra.h b/tests/tegra/drm-test-tegra.h
> new file mode 100644
> index ..d1cb6b1ee440
> --- /dev/null
> +++ b/tests/tegra/drm-test-tegra.h
> +int drm_open(const char *path)
> +{
> + int fd,
On Wed, Feb 19, 2014 at 9:19 PM, Erik Faye-Lund wrote:
> On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
> wrote:
>> diff --git a/tests/tegra/Makefile.am b/tests/tegra/Makefile.am
>> new file mode 100644
>> index ..7039f09d38aa
>> --- /dev/null
&g
On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
wrote:
> diff --git a/tests/tegra/Makefile.am b/tests/tegra/Makefile.am
> new file mode 100644
> index ..7039f09d38aa
> --- /dev/null
> +++ b/tests/tegra/Makefile.am
> @@ -0,0 +1,20 @@
> +AM_CPPFLAGS = \
> + -I$(top_srcdir)/include/
On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
wrote:
> diff --git a/tegra/Makefile.am b/tegra/Makefile.am
> new file mode 100644
> index ..1b83145b120d
> --- /dev/null
> +++ b/tegra/Makefile.am
> @@ -0,0 +1,20 @@
> +AM_CPPFLAGS = \
> + -I$(top_srcdir) \
> + -I$(top_srcdir
On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
wrote:
> +#ifndef __DRM_TEGRA_PRIVATE_H__
> +#define __DRM_TEGRA_PRIVATE_H__ 1
> +
> +#include
> +#include
> +
> +#include
> +
> +#include "tegra.h"
> +
> +#if defined(HAVE_VISIBILITY)
> +# define drm_private __attribute__((visibility("hidden")))
On Wed, Feb 19, 2014 at 5:04 PM, Thierry Reding
wrote:
> From: Thierry Reding
>
> These functions can be used to open channels to engines, manage job
> submissions, create push buffers to store command streams in and wait
> until jobs have been completed.
>
> Signed-off-by: Thierry Reding
Thank
On Tue, Feb 11, 2014 at 6:12 PM, Dmitry Osipenko wrote:
> Add guard to check whether RGB output is already enabled in the way it's
> done for HDMI output. Fixes possible hang on trying to disable output twice
> (first time during driver probe and second on fb registering).
>
> Signed-off-by: Dmitr
Ping?
On Tue, Jan 7, 2014 at 9:03 PM, Erik Faye-Lund wrote:
> When patching gathers, we don't need to check against
> gathers with lower indices than the current one, as
> they are guaranteed to already have been handled.
>
> Signed-off-by: Erik Faye-Lund
> ---
>
>
When patching gathers, we don't need to check against
gathers with lower indices than the current one, as
they are guaranteed to already have been handled.
Signed-off-by: Erik Faye-Lund
---
Here's a trivial optimization I have been running with for a while.
drivers/gpu/host1x/job.c
On Sun, Dec 8, 2013 at 12:35 AM, Rob Clark wrote:
> diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h
> new file mode 100644
> index 000..e42973c
> --- /dev/null
> +++ b/drivers/gpu/drm/msm/msm_kms.h
> @@ -0,0 +1,57 @@
> +/*
> + * Copyright (C) 2013 Red Hat
> + * Autho
On Tue, Oct 8, 2013 at 7:48 AM, Terje Bergström wrote:
> On 07.10.2013 16:02, Erik Faye-Lund wrote:
>> So the question is really how the hardware treats writes to
>> non-existent registers. My guess would be that they are simply not
>> recorded, and if that's the case it
On Mon, Oct 7, 2013 at 2:52 PM, Terje Bergström wrote:
> On 07.10.2013 15:14, Thierry Reding wrote:
>> * PGP Signed by an unknown key
>>
>> On Mon, Oct 07, 2013 at 01:34:44PM +0200, Erik Faye-Lund wrote:
>>> On Mon, Oct 7, 2013 at 10:34 AM, Thierry Reding
>>>
On Mon, Oct 7, 2013 at 2:53 PM, Erik Faye-Lund wrote:
> On Mon, Oct 7, 2013 at 2:14 PM, Thierry Reding
> wrote:
>> On Mon, Oct 07, 2013 at 01:34:44PM +0200, Erik Faye-Lund wrote:
>>> On Mon, Oct 7, 2013 at 10:34 AM, Thierry Reding
>>> wrote:
>>> > Re
On Mon, Oct 7, 2013 at 2:14 PM, Thierry Reding wrote:
> On Mon, Oct 07, 2013 at 01:34:44PM +0200, Erik Faye-Lund wrote:
>> On Mon, Oct 7, 2013 at 10:34 AM, Thierry Reding
>> wrote:
>> > Rework the address table code for the host1x firewall. The previous
>> > im
On Mon, Oct 7, 2013 at 10:34 AM, Thierry Reding
wrote:
> Rework the address table code for the host1x firewall. The previous
> implementation allocated a bitfield but didn't check for a valid pointer
> so it could potentially crash.
I don't think it could crash. The bitmaps was allocated as a 256
The num_relocs count are passed to the kernel per job, not per gather.
For multi-gather jobs, we would previously fail if there were relocs in
other gathers aside from the first one.
Fix this by simply moving the check until all gathers have been
consumed.
Signed-off-by: Erik Faye-Lund
75 matches
Mail list logo
