On Wed, Apr 9, 2014 at 1:40 PM, Thierry Reding <thierry.reding at gmail.com> wrote: > +int drm_open(const char *path) > +{ > + int fd, err; > + > + fd = open(path, O_RDWR); > + if (fd < 0) > + return -errno; > + > + err = drmSetMaster(fd); > + if (err < 0) { > + close(fd); > + return -errno; > + }
Could we make this opt-in? Otherwise "make check" needs to be run as root to pass, which is a bit iffy IMO as it also invokes the compiler and all tools as root. I'd prefer not having to give my dev-tools (and potentially buggy in-tree scripts) that much privilege...