Hello everyone,
For many years now, we have maintained mirrors of numerous FDo projects
on GitHub, under the following organisations:
https://github.com/freedesktop
https://github.com/mesa3d
https://github.com/wayland-project
A bit over a month ago, a new security feature in git started preventin
On Wednesday, 2020-01-29 09:53:16 +, Eric Engestrom wrote:
> On Friday, 2020-01-10 13:30:41 +0900, Seung-Woo Kim wrote:
> > The header is not required for Linux and GNU libc
> > 2.30 starts to warn about Linux specific header
> > deprecation. Don't detect header
On Thursday, 2020-02-06 17:46:36 +, Li, Juston wrote:
> On Wed, 2020-02-05 at 23:27 +0000, Eric Engestrom wrote:
> > On Wednesday, 2020-02-05 23:10:21 +, Li, Juston wrote:
> > > On Wed, 2020-02-05 at 22:25 +0000, Eric Engestrom wrote:
> > > > On Friday, 2020-0
On Wednesday, 2020-02-05 23:10:21 +, Li, Juston wrote:
> On Wed, 2020-02-05 at 22:25 +0000, Eric Engestrom wrote:
> > On Friday, 2020-01-31 13:41:09 -0800, Juston Li wrote:
> > > From: Daniel Stone
> > >
> > > Add a wrapper around the getfb2 ioctl, whic
t; +{
> + struct drm_mode_fb_cmd2 get;
> + drmModeFB2Ptr ret;
> + int err;
> +
> + memclear(get);
> + get.fb_id = fb_id;
As mentioned on IRC, could you write it like this instead?
struct drm_mode_fb_cmd2 get = {
.fb_id = fb_id,
ok like this:
# From Niclas Zeising:
# FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the
# includes when checking for headers.
foreach header : ['sys/sysctl.h']
config.set10('HAVE_' + header.underscorify().to_upper(),
not ['linux'].contains(host
ret = drmIoctl(bufmgr_gem->fd,
> +DRM_IOCTL_I915_GEM_GET_TILING,
> +&get_tiling);
You're missing `get_tiling.handle = gem_handle;`
Or better yet, just initialise `get_tiling` and get rid of the memclear():
struct drm_i915_gem_get_tiling get_tiling = {
.han
On Monday, 2019-12-16 16:51:28 +, Souza, Jose wrote:
> Hello
>
> I have being contributing to i915 for the past 2 years and part of my
> work is update the PCI ids of Intel devices in libdrm.
> Being able to push my reviewed patches would be really helpful, please
> consider this request.
Thi
On Tuesday, 2019-12-03 06:37:36 -0800, Devarsh Thakkar wrote:
> Add function to derive floating value of vertical
> refresh rate from drm mode using pixel clock,
> horizontal total size and vertical total size.
>
> Use this function to find suitable mode having vrefresh
> value which is matching w
On Thursday, 2019-10-03 16:53:18 +0300, Ville Syrjälä wrote:
> On Thu, Oct 03, 2019 at 09:51:18AM +0200, Andrzej Pietrasiewicz wrote:
> > To human readers
>
> The commit message is always for human readers, no need to point that
> out...
>
> >
> > "array of struct drm_format modifiers" is almost
r conditions (Eric)
>
> Cc: Eric Engestrom
Reviewed-by: Eric Engestrom
> Acked-by: Alex Deucher
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/drm_atomic_uapi.c | 2 +-
> drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++---
> drivers/gpu/drm/drm_edid.c
On Tuesday, 2019-10-01 14:03:55 +0300, Jani Nikula wrote:
> On Thu, 26 Sep 2019, Eric Engestrom wrote:
> > On Tuesday, 2019-09-24 15:58:56 +0300, Jani Nikula wrote:
> >> Hi all, v2 of [1], a little refactoring around drm_debug access to
> >> abstract it better. There
objections to that, we'll need to postpone the last patch until
> everything has been merged and converted in drm-next.
>
> BR,
> Jani.
>
> Cc: Eric Engestrom
> Cc: Alex Deucher
> Cc: Christian König
> Cc: David (ChunMing) Zhou
> Cc: amd-...@lists.freedesktop.or
On Tuesday, 2019-09-24 23:09:08 -0700, John Stultz wrote:
> On Tue, Sep 24, 2019 at 4:30 PM John Stultz wrote:
> > On Tue, Sep 24, 2019 at 3:24 PM Rob Herring wrote:
> > > Trying to maintain something that works across more than 3 releases or
> > > so is painful. I don't think android-x86 folks h
On Monday, 2019-09-16 16:23:13 +0300, Jani Nikula wrote:
> On Mon, 16 Sep 2019, Eric Engestrom wrote:
> > On Monday, 2019-09-16 11:53:24 +0300, Jani Nikula wrote:
> >> On Fri, 13 Sep 2019, Eric Engestrom wrote:
> >> > On Friday, 2019-09-13 14:51:39 +0300, Jani Nikul
t;
> However, now that it is a requirement for newer releases, I'd
> contend that being able to build/test libdrm/master against
> AOSP/master and recent releases is more valuable then soley
> maintaining support for old and unsupported Android releases.
Acked-by: Eric Engestrom
On Monday, 2019-09-16 12:35:41 +0200, Rohan Garg wrote:
> DRM_IOCTL_BO_SET_LABEL lets you label GEM objects, making it
> easier to debug issues in userspace applications.
>
> Signed-off-by: Rohan Garg
> ---
> drivers/gpu/drm/drm_gem.c | 51 ++
> drivers/gpu/d
On Monday, 2019-09-16 11:53:24 +0300, Jani Nikula wrote:
> On Fri, 13 Sep 2019, Eric Engestrom wrote:
> > On Friday, 2019-09-13 14:51:39 +0300, Jani Nikula wrote:
> >> Add helper to check if a drm debug category is enabled. Convert drm core
> >> to use it. No functional
On Friday, 2019-09-13 16:26:55 -0700, Alan Coopersmith wrote:
> On 9/10/19 5:55 AM, Eric Engestrom wrote:
> > On Monday, 2019-09-09 16:51:16 -0700, Alan Coopersmith wrote:
> > > On Solaris, sys/sysmacros.h has long-deprecated copies of major() &
> > > minor()
> &
On Friday, 2019-09-13 14:51:39 +0300, Jani Nikula wrote:
> Add helper to check if a drm debug category is enabled. Convert drm core
> to use it. No functional changes.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/drm_atomic_uapi.c | 2 +-
> drivers/gpu/drm/drm_dp_mst_topology.c | 6
AC_HEADER_MAJOR does.
Reviewed-by: Eric Engestrom
Alternatively, how about this?
---8<---
diff --git a/meson.build b/meson.build
index bc5cfc588d0c621a9725..263f691ab2b9107f5be1 100644
--- a/meson.build
+++ b/meson.build
@@ -183,9 +183,14 @@ foreach header : ['sys/sysctl.h', 'sy
ore OpenBSD had render nodes).
>
> Signed-off-by: Jonathan Gray
I didn't check that OpenBSD is the way you say, but the libdrm code here
matches with that, so this patch is
Acked-by: Eric Engestrom
and pushed :)
> ---
> xf86drm.c | 24 ++--
> 1 file cha
On Monday, 2019-05-13 02:50:49 +1000, Jonathan Gray wrote:
> Unlike Linux the OpenBSD primary "drm" device name is substring of the
> "drmR" render node device name and strncmp() tests resulted in render
> nodes being flagged as primary nodes.
>
> Signed-off-by
On Tuesday, 2019-06-18 16:02:41 +0200, Daniel Vetter wrote:
> I rushed merging this a bit too much, and Noralf pointed out that
> we're a lot better already and have made great progress.
>
> Let's try again.
>
> Fixes: 42dbbb4b54a3 ("drm/todo: Add new debugfs todo")
> Cc: Greg Kroah-Hartman
> Cc
On Monday, 2019-06-17 11:20:43 +0200, Niclas Zeising wrote:
> On 2019-06-17 11:14, Eric Engestrom wrote:
> > On Sunday, 2019-06-16 14:23:43 +0100, Emil Velikov wrote:
> > > From: Niclas Zeising
> > >
> > > FreeBSD requires sys/types.h for sys/sysctl.h, add i
ecks, just add sys/types.h to all header checks.
>
> v2 [Emil]
> - add inline comment
> - drop bash/sh hunk
>
> Signed-off-by: Emil Velikov
Series is:
Reviewed-by: Eric Engestrom
But I agree with Emil, it's a FreeBSD bug for it to not include
a required h
On Thursday, 2019-05-16 09:37:40 -0700, Eric Anholt wrote:
> Eric Anholt writes:
>
> > [ Unknown signature status ]
> > James Clarke writes:
> >
> >> Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t
> >> types, which differs from the BSDs' headers. Thus we should include
>
On Monday, 2019-04-29 18:10:52 +0900, Seung-Woo Kim wrote:
> In drmModeGetPropertyPtr(), from upper error path, it calls free
> but with just next error path, it does not call. Fix the possible
> memory leak.
>
> Signed-off-by: Seung-Woo Kim
Reviewed-by: Eric Engestrom
and
On Wednesday, 2019-04-10 21:49:33 -0400, Rob Clark wrote:
> On Tue, Apr 9, 2019 at 8:27 AM Eric Engestrom
> wrote:
> > > > diff --git a/include/drm/msm_drm.h b/include/drm/msm_drm.h
> > > > index c06d0a5..91a16b3 100644
> > > > --- a/include/drm/msm
On Tuesday, 2019-04-09 12:59:13 +0100, Eric Engestrom wrote:
> On Tuesday, 2019-04-09 11:35:14 +, Ayan Halder wrote:
> > Generated using make headers_install from the drm-next
> > tree - git://anongit.freedesktop.org/drm/drm
> > branch
> drm_i915_gem_context_'
> - Added different modes of per-process Graphics Translation Table
>
> msm:
> - Added various get or set GEM buffer info flags
> - Added some MSM_SUBMIT_BO_ macros
> - Modified 'struct drm_msm_gem_info'
On Monday, 2019-04-08 13:44:17 +, Ayan Halder wrote:
> Generated using make headers_install from the drm-next
> tree - git://anongit.freedesktop.org/drm/drm
> branch - drm-next
> commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf90f3f
>
> The changes were as follows :-
>
> core: (drm.h, drm_fourcc.
On Tuesday, 2019-03-05 21:54:47 +0530, Mamta Shukla wrote:
> Add overlay plane support in vkms aligned with cursor and primary
> plane with module option 'enable_overlay' to enable/disable overlay
> plane while testing.
>
> This currently passes plane-position-covered-pipe-A-plane subtest
> from I
On Monday, 2019-03-04 08:28:25 +0200, Tapani Pälli wrote:
> ping!
Reviewed-by: Eric Engestrom
>
> On 2/21/19 8:56 AM, Tapani Pälli wrote:
> > Add new iris driver, remove deprecated ilo driver.
> >
> > Signed-off-by: Tapani Pälli
> > ---
> > libkms/An
CPPFLAGS instead of CFLAGS from configure.ac.
Thanks!
Reviewed-by: Eric Engestrom
Fixes: 0926f0af54d654b1a958 "meson,configure: include config.h automatically"
I'll push it in moment.
>
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=106561
> Signed-off-by:
On Tuesday, 2019-02-19 11:56:21 +, Emil Velikov wrote:
> On Tue, 19 Feb 2019 at 10:08, Eric Engestrom wrote:
> >
> > On Friday, 2019-02-15 15:08:22 +, Emil Velikov via dri-devel wrote:
> > > On Fri, 15 Feb 2019 at 15:06, Rob Clark via dri-devel
> > > wrot
On Tuesday, 2019-02-19 13:53:25 +0100, Daniel Vetter wrote:
> On Tue, Feb 19, 2019 at 12:57 PM Emil Velikov
> wrote:
> >
> > On Mon, 18 Feb 2019 at 17:42, Eric Engestrom
> > wrote:
> > >
> > > On Thursday, 2018-12-20 11:53:11 -0800, Dylan Baker wrote:
On Friday, 2019-02-15 15:08:22 +, Emil Velikov via dri-devel wrote:
> On Fri, 15 Feb 2019 at 15:06, Rob Clark via dri-devel
> wrote:
> >
> > On Fri, Feb 15, 2019 at 8:42 AM Eric Engestrom
> > wrote:
> > >
> > > On Friday, 2019-02-15 13:36:39 +000
On Thursday, 2018-12-20 11:53:11 -0800, Dylan Baker wrote:
> Quoting Eric Engestrom (2018-12-19 08:23:40)
> > Signed-off-by: Eric Engestrom
> > ---
> > RELEASING | 27 ---
> > 1 file changed, 8 insertions(+), 19 deletions(-)
> >
>
On Wednesday, 2018-12-19 17:08:01 +, Eric Engestrom wrote:
> Adapted from a local patch carried by DragonFlyBSD:
> https://github.com/DragonFlyBSD/DPorts/blob/bc056f88f7e4d468d8c9751f831a47b5ae1326e3/graphics/libdrm/files/patch-xf86drm.h
>
> Patch is sadly uncredited (a bot
On Friday, 2019-02-15 07:11:55 -0500, Rob Clark wrote:
> On Fri, Feb 15, 2019 at 3:55 AM Daniel Drake wrote:
> >
> > Hi,
> >
> > Using libdrm-2.4.97, mesa fails to build on ARM with:
> >
> > [ 456s] In file included from
> > ../../../../../src/gallium/drivers/freedreno/freedreno_util.h:33,
> > [
On Friday, 2019-02-15 13:36:39 +, Eric Engestrom wrote:
> On Friday, 2019-02-15 07:11:55 -0500, Rob Clark wrote:
> > On Fri, Feb 15, 2019 at 3:55 AM Daniel Drake wrote:
> > >
> > > Hi,
> > >
> > > Using libdrm-2.4.97, mesa fails to build on ARM wit
On Friday, 2019-02-08 16:50:44 +, Emil Velikov wrote:
> On Fri, 8 Feb 2019 at 16:51, Daniel Stone wrote:
> >
> > Hi Eric,
> >
> > On Fri, 8 Feb 2019 at 15:03, Eric Engestrom
> > wrote:
> > > Xserver has struct members named `bool`, which means t
: https://bugs.freedesktop.org/show_bug.cgi?id=109587
Fixes: 17dfe3ac93217b43f93b "xf86drm: Add drmIsMaster()"
Cc: Christopher James Halse Rogers
Cc: Emil Velikov
Signed-off-by: Eric Engestrom
---
xf86drm.c | 2 +-
xf86drm.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
di
On Tuesday, 2019-01-29 14:21:53 +0100, Daniel Vetter wrote:
> I'm kinda fed up explaining why the have a confusing name :-)
>
> Cc: Noralf Trønnes
> Cc: Laurent Pinchart
> Signed-off-by: Daniel Vetter
> ---
> Documentation/gpu/todo.rst | 10 ++
> 1 file changed, 10 insertions(+)
>
> d
On Wednesday, 2019-01-23 10:45:18 +, Emil Velikov wrote:
> From: Emil Velikov
>
> The functions are virtually identical, fold them up.
>
> Signed-off-by: Emil Velikov
Assuming patch 1 is OK, and `foo` gets renamed to something better:
Reviewed-by: Eric Engestrom
I don&#
On Wednesday, 2019-01-23 10:45:17 +, Emil Velikov wrote:
> From: Emil Velikov
>
> Some devices can lack OF data or it may not be available in the uevent
> file. Fallback to the MODALIAS data in those cases.
>
> We strip any leading "MODALIAS=.*:" thus the resulting information is
> compatibl
Adapted from a local patch carried by DragonFlyBSD:
https://github.com/DragonFlyBSD/DPorts/blob/bc056f88f7e4d468d8c9751f831a47b5ae1326e3/graphics/libdrm/files/patch-xf86drm.h
Patch is sadly uncredited (a bot authored the commit), so I can't credit
the author here either.
Signed-off-by:
Signed-off-by: Eric Engestrom
---
xf86drm.c | 4 ++--
xf86drm.h | 8
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/xf86drm.c b/xf86drm.c
index 07425b19897d00a19e8a..95854e153ec7e9d264bc 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -317,7 +317,7 @@ static int drmOpenDevice
Signed-off-by: Eric Engestrom
---
xf86drm.c | 86 +++
1 file changed, 23 insertions(+), 63 deletions(-)
diff --git a/xf86drm.c b/xf86drm.c
index 95854e153ec7e9d264bc..f8e4d11b8c6886d6a6b8 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -300,6
Signed-off-by: Eric Engestrom
---
tests/amdgpu/vce_tests.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/amdgpu/vce_tests.c b/tests/amdgpu/vce_tests.c
index b9e15ee97148ee3b38d4..0026826ea58bd9d9dd8b 100644
--- a/tests/amdgpu/vce_tests.c
+++ b/tests/amdgpu
Signed-off-by: Eric Engestrom
---
RELEASING | 27 ---
1 file changed, 8 insertions(+), 19 deletions(-)
diff --git a/RELEASING b/RELEASING
index 7e03e3b9acb1cbfb261a..d1ad8e3b4ad16d4ca14f 100644
--- a/RELEASING
+++ b/RELEASING
@@ -9,25 +9,14 @@ However, this is up to
Saw a couple of typos fixes in the patch DragonFlyBSD carries [1], so
I ran codespell (a spell checker for code) on the whole repo.
[1]
https://github.com/DragonFlyBSD/DPorts/blob/master/graphics/libdrm/files/patch-xf86drm.c
Signed-off-by: Eric Engestrom
---
I discarded the fixes in include
JOR - they will need patching to
> > run :-(
>
> Major/minor numbers were required when device files had to be created on
> regular filesystem like UFS but when a devfs filesystem was implemented
> for DragonFly almost a decade ago, nobody thought it was important anymore.
>
> The
On Thursday, 2018-11-15 21:18:43 -0800, Eric Anholt wrote:
> For ARM systems with tinydrm displays attached to SPI, the bus name is
> /spi but we have platform device info for the rest. Fixes
> eglInitialize() failures on hx8357d since the EGL_EXT_device_drm
> changes.
Acked-by: Er
On Thursday, 2018-11-15 21:18:42 -0800, Eric Anholt wrote:
> Having people count characters is error-prone, when we could just have
> a computer do it.
Reviewed-by: Eric Engestrom
> ---
> xf86drm.c | 31 ---
> 1 file changed, 16 insertions(+
Error message was invalid too, negative values aren't the number of
devices, they're errno error codes.
Signed-off-by: Eric Engestrom
---
This fixes the Gitlab CI; goes from:
https://gitlab.freedesktop.org/mesa/drm/-/jobs/42061
to:
https://gitlab.freedesktop.org/eric/libdrm/-/
Also, move the sentence about "who would use libdrm" into its own paragraph,
as it is something people discovering libdrm will want to know.
Signed-off-by: Eric Engestrom
---
README.rst | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/RE
Thanks to the #error just above, any file including this header can only
see one state for this macro: defined, with the value `1`.
Let's just #undef it once we're done using it in here so that other
files don't misconstrue any meaning to it.
Signed-off-by: Eric Engestrom
---
x
While at it, let's include xf86atomic.h explicitly, instead of relying
on some other file accidentally including it before including this file.
Signed-off-by: Eric Engestrom
---
freedreno/freedreno_ringbuffer.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/free
Signed-off-by: Eric Engestrom
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 49bf2f740fb3627f2948..5ef17fc11fee25f98b3d 100644
--- a/meson.build
+++ b/meson.build
@@ -192,7 +192,7 @@ config.set10('HAVE_OPEN_MEMS
Reported-by: Jan Vesely
Signed-off-by: Eric Engestrom
---
xf86drmHash.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/xf86drmHash.c b/xf86drmHash.c
index 891b732632c36d373ac9..2cf2b80ed9e02310f0ff 100644
--- a/xf86drmHash.c
+++ b/xf86drmHash.c
@@ -105,7 +105,6 @@ static unsigned long
On Wednesday, 2018-10-24 17:53:51 +0100, Eric Engestrom wrote:
> Fixes the tests on ARM, but more importantly this makes it much easier
> to maintain.
BTW I have a wip to replace all of those with a python script that will
be more thorough in its checks, but until that lands this is alr
Signed-off-by: Eric Engestrom
---
.gitlab-ci.yml | 60 ++
1 file changed, 60 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a0edfdff43d24743586d..cbac993dd8227421be50 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -157,3
Fixes the tests on ARM, but more importantly this makes it much easier
to maintain.
Signed-off-by: Eric Engestrom
---
amdgpu/amdgpu-symbol-check | 7 +--
etnaviv/etnaviv-symbol-check | 7 +--
exynos/exynos-symbol-check | 7 +--
freedreno/freedreno-symbol-check
On Tuesday, 2018-10-16 08:24:02 -0700, Lucas De Marchi wrote:
> On 10/16/18 4:26 AM, Eric Engestrom wrote:
> > On Monday, 2018-10-15 16:48:07 -0700, Lucas De Marchi wrote:
> > > This is the directory used by meson/autotools (at least in the
> > > .gitlab-ci configurati
On Monday, 2018-10-15 16:48:07 -0700, Lucas De Marchi wrote:
> This is the directory used by meson/autotools (at least in the
> .gitlab-ci configuration) so ignore the whole dir.
This is extremely specific to this one case; what does this change for
the gitlab ci?
>
> Signed-off-by: Lucas De Mar
On Monday, 2018-10-15 16:48:06 -0700, Lucas De Marchi wrote:
> LANG=C sort -u .gitignore | sponge .gitignore
>
> This way it's easier to keep track of the entries.
>
> Signed-off-by: Lucas De Marchi
Sure, why not:
Acked-by: Eric Engestrom
>
butors of projects that follow X.Org's
> purpose as enacted in its bylaws. Other projects can continue to be
> hosted on fd.o but won't receive X.Org membership for the mere reason
> of
> being hosted on fd.o.
With my member hat on, I think this is the best choice.
Acked
On Thursday, 2018-10-11 19:18:10 -0400, mesa-dev-boun...@lists.freedesktop.org
wrote:
> From: Rob Clark
>
> drmMalloc() is already calloc()
Sounds very much like an implementation detail, but everything relies on
it already, so...
Reviewed-by: Eric Engestrom
>
> Signed-of
On Friday, 2018-10-05 12:07:26 -0400, Harry Wentland wrote:
> On 2018-10-04 04:24 PM, Daniel Vetter wrote:
> > Motivated by review comments from Ville&Sean.
> >
> > Cc: Ville Syrjälä
> > Cc: Sean Paul
> > Signed-off-by: Daniel Vetter
>
> Acked-by: Harry Wentland
>
> Harry
>
> > ---
> > Doc
On Tuesday, 2018-09-25 16:20:14 +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> Trivial typos - s/admgpu/amdgpu/;s/vmwfgx/vmwgfx/
Oops... Thanks :)
Reviewed-by: Eric Engestrom
>
> Fixes: 4a9030dc8b7 ("add gitlab-ci builds of libdrm")
> Cc: Eric Engestrom
>
+if _etnaviv != 'false'
>if not with_atomics
> error('libdrm_etnaviv requires atomics.')
We shouldn't error out in the 'auto' case; please modify the `with_atomic`
if above to add `_etnaviv == 'true' and ...`. With that, the patch is
On Thursday, 2018-09-20 18:21:41 +0100, Eric Engestrom wrote:
> On Thursday, 2018-09-20 18:09:41 +0200, Michel Dänzer wrote:
> > On 2018-09-20 5:58 p.m., Eric Engestrom wrote:
> > > Fixes: 9f45264815eff6ebeba3 "radeon: annotate public functions"
> > > Cc:
On Thursday, 2018-09-20 11:12:49 -0700, Lucas De Marchi wrote:
> On Thu, Sep 20, 2018 at 06:12:59PM +0100, Eric Engestrom wrote:
> > On Thursday, 2018-09-20 09:46:48 -0700, Lucas De Marchi wrote:
> > > On Thu, Sep 20, 2018 at 04:58:32PM +0100, Eric Engestrom wr
On Thursday, 2018-09-20 18:30:54 +0100, Emil Velikov wrote:
> On 20 September 2018 at 16:58, Eric Engestrom
> wrote:
> > Fixes: 36bb0ea47b71d220b31e "intel: annotate public functions"
> > Cc: Lucas De Marchi
> > Cc: Mark Janes
> > Bugzilla: https://bug
Fixes: f3f7266d94e0354bfd97 "omap: annotate public functions"
Cc: Lucas De Marchi
Signed-off-by: Eric Engestrom
---
omap/omap_drm.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/omap/omap_drm.c b/omap/omap_drm.c
index 3136e04e41
On Thursday, 2018-09-20 18:12:59 +0100, Eric Engestrom wrote:
> On Thursday, 2018-09-20 09:46:48 -0700, Lucas De Marchi wrote:
> > On Thu, Sep 20, 2018 at 04:58:32PM +0100, Eric Engestrom wrote:
> > > Fixes: 36bb0ea47b71d220b31e "intel: annotate public functions&quo
On Thursday, 2018-09-20 18:09:41 +0200, Michel Dänzer wrote:
> On 2018-09-20 5:58 p.m., Eric Engestrom wrote:
> > Fixes: 9f45264815eff6ebeba3 "radeon: annotate public functions"
> > Cc: Lucas De Marchi
> > Cc: Mark Janes
> > Bugzilla: https://bugs.f
On Thursday, 2018-09-20 09:46:48 -0700, Lucas De Marchi wrote:
> On Thu, Sep 20, 2018 at 04:58:32PM +0100, Eric Engestrom wrote:
> > Fixes: 36bb0ea47b71d220b31e "intel: annotate public functions"
> > Cc: Lucas De Marchi
> > Cc: Mark Janes
> > Bugzilla: http
Fixes: 9f45264815eff6ebeba3 "radeon: annotate public functions"
Cc: Lucas De Marchi
Cc: Mark Janes
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006
Signed-off-by: Eric Engestrom
---
radeon/radeon_bo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --gi
Fixes: d7320bfcddc596f23fa2 "nouveau: annotate public functions"
Cc: Lucas De Marchi
Cc: Mark Janes
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006
Signed-off-by: Eric Engestrom
---
nouveau/nouveau.c | 2 +-
nouveau/pushbuf.c | 2 +-
2 files changed, 2 insertions(+), 2
Fixes: 36bb0ea47b71d220b31e "intel: annotate public functions"
Cc: Lucas De Marchi
Cc: Mark Janes
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108006
Signed-off-by: Eric Engestrom
---
intel/intel_bufmgr_fake.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
di
On Wednesday, 2018-09-19 23:05:48 -0700, Lucas De Marchi wrote:
> Signed-off-by: Lucas De Marchi
Reviewed-by: Eric Engestrom
But it'd be good to have a confirmation from Rob that it actually works:
Cc: Rob Herring
> ---
> Android.common.mk | 1 +
> 1 file changed, 1 inser
showing project members.
> v3: reprhase paragraph adding link to members page
>
> Signed-off-by: Lucas De Marchi
Looks good to me; thanks!
Reviewed-by: Eric Engestrom
> ---
> CONTRIBUTING | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/
$ sed -i s/I915_FORMAT_MOD_/DRM_FORMAT_MOD_INTEL_/g $(git grep -l
I915_FORMAT_MOD_)
$ git checkout include/uapi/drm/drm_fourcc.h
Signed-off-by: Eric Engestrom
---
drivers/gpu/drm/i915/intel_atomic_plane.c | 12 +-
drivers/gpu/drm/i915/intel_display.c | 128 +++---
drivers
All the other vendors use the format
DRM_FORMAT_MOD_{SAMSUNG,QCOM,VIVANTE,NVIDIA,BROADCOM,ARM}_* for their
modifiers, except Intel.
Suggested-by: Gerd Hoffmann
Signed-off-by: Eric Engestrom
---
include/uapi/drm/drm_fourcc.h | 15 ++-
1 file changed, 10 insertions(+), 5 deletions
Signed-off-by: Eric Engestrom
---
include/drm/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/README b/include/drm/README
index 521630db8b4c52749188..ea2320cc9e7728a9c08b 100644
--- a/include/drm/README
+++ b/include/drm/README
@@ -71,7 +71,7 @@ Note: One
On Wednesday, 2018-09-12 20:33:32 -0500, David Lechner wrote:
> On 09/11/2018 07:43 AM, Noralf Trønnes wrote:
> > This adds a library for shmem backed GEM objects with the necessary
> > drm_driver callbacks.
> >
> > Signed-off-by: Noralf Trønnes
> > ---
> >
>
> ...
>
> > +static int drm_gem_sh
On Thursday, 2018-09-13 16:57:11 -0700, Lucas De Marchi wrote:
> Rely on -fvisibility=hidden to hide the symbols. Previous version of
> this series applying only to drm_intel.so is
>
> Reviewed-by: Eric Engestrom
>
> but it's not included here since I changed the
On Thursday, 2018-09-13 21:11:18 +0100, Eric Engestrom wrote:
> On Thursday, 2018-09-13 12:43:53 -0700, Lucas De Marchi wrote:
> > On 9/13/18 1:03 AM, Eric Engestrom wrote:
> > > On Wednesday, 2018-09-12 14:05:34 -0700, Lucas De Marchi wrote:
> > > > Rely on -fvisibil
On Thursday, 2018-09-13 12:43:53 -0700, Lucas De Marchi wrote:
> On 9/13/18 1:03 AM, Eric Engestrom wrote:
> > On Wednesday, 2018-09-12 14:05:34 -0700, Lucas De Marchi wrote:
> > > Rely on -fvisibility=hidden to hide the symbols. This only applies to
> > > drm_intel.
On Thursday, 2018-09-13 10:43:04 -0700, Rodrigo Vivi wrote:
> On Thu, Sep 13, 2018 at 09:45:47AM +0100, Eric Engestrom wrote:
> > On Thursday, 2018-09-13 15:19:00 +0800, Chih-Wei Huang wrote:
> > > Note this patch breaks drm_gralloc:
> > >
> > > FAILED:
>
.
> Unless you are going to privatize all IS_GEN{n} macros.
> (are you?)
>
>
> 2018-09-13 0:03 GMT+08:00 Rodrigo Vivi :
> > On Wed, Sep 12, 2018 at 08:50:54AM -0700, Rodrigo Vivi wrote:
> >> From: Emil Velikov
> >>
> >> They're used intern
t;
> drm_private can also be removed from other symbols. If this passes a
> smoke test I'll add a patch on v2 doing so.
Series is
Reviewed-by: Eric Engestrom
but yeah, without that 3rd patch to remove drm_private it isn't all that
useful :P
Do you plan on converting the rest of
On Tuesday, 2018-09-11 14:22:24 -0700, Rodrigo Vivi wrote:
> From: Emil Velikov
>
> They're used internally and never meant to be part of the API.
> Add the drm_private notation, which should resolve that.
>
> v2: (Rodrigo) Add missing include.
>
> Cc: Eric Eng
On Thursday, 2018-09-06 15:53:33 +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> Set/export the NM variable since it may not be set already.
>
> Fixes: 4f08bfe96da ("*-symbol-check: Don't hard-code nm executable")
> Cc: Heiko Becker
> Cc: Eric Enge
On Thursday, 2018-09-06 16:01:15 +0100, Emil Velikov wrote:
> On 6 September 2018 at 14:40, Eric Engestrom wrote:
> > Signed-off-by: Eric Engestrom
> > ---
> > .gitlab-ci.yml | 129 ++---
> > 1 file changed, 47
And add them to the list of exported function to fix the tests.
Fixes: 4e81d4f9c9b7fd6510cf "intel: add generic functions to check PCI ID"
Cc: Lucas De Marchi
Cc: Rodrigo Vivi
Signed-off-by: Eric Engestrom
---
Lucas, I'm assuming you meant to export those functions (and macros,
Signed-off-by: Eric Engestrom
---
.gitlab-ci.yml | 129 ++---
1 file changed, 47 insertions(+), 82 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index eee6abfcdd7de2839660..1dc434a5d359b3b077e7 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab
1 - 100 of 422 matches
Mail list logo
