Re: [PATCH v3 4/8] drm/msm/dpu: use drmm_writeback_connector_init()

2025-09-17 Thread Christophe JAILLET
Le 19/08/2025 à 22:32, Dmitry Baryshkov a écrit : Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Reviewed-by: Jessica Zhang Signed-off-b

Re: [PATCH v3 4/8] drm/msm/dpu: use drmm_writeback_connector_init()

2025-09-09 Thread Christophe JAILLET
Le 10/09/2025 à 05:47, Dmitry Baryshkov a écrit : On Mon, Sep 08, 2025 at 11:38:44PM +0200, Christophe JAILLET wrote: Le 08/09/2025 à 23:26, Dmitry Baryshkov a écrit : On Mon, Sep 08, 2025 at 11:09:07PM +0200, Christophe JAILLET wrote: Le 19/08/2025 à 22:32, Dmitry Baryshkov a écrit : Use

Re: [PATCH v3 4/8] drm/msm/dpu: use drmm_writeback_connector_init()

2025-09-08 Thread Christophe JAILLET
Le 08/09/2025 à 23:26, Dmitry Baryshkov a écrit : On Mon, Sep 08, 2025 at 11:09:07PM +0200, Christophe JAILLET wrote: Le 19/08/2025 à 22:32, Dmitry Baryshkov a écrit : Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback

[PATCH] drm/xe/hwmon: Use devm_mutex_init()

2025-09-07 Thread Christophe JAILLET
data bss dec hex filename 36651 10224 64 46939b75b drivers/gpu/drm/xe/xe_hwmon.o Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/xe/xe_hwmon.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers

[PATCH] drm/armada: Constify struct drm_info_list

2025-08-09 Thread Christophe JAILLET
xtdata bss dec hex filename 1411 320 01731 6c3 drivers/gpu/drm/armada/armada_debugfs.o After: = textdata bss dec hex filename 1683 48 01731 6c3 drivers/gpu/drm/armada/armada_debugfs.o Signed-off-by: Christophe JAILLET -

[PATCH] drm/armada: Use the correct prototype for a struct file_operations .write function

2025-08-09 Thread Christophe JAILLET
.write functions from struct file_operations return a ssize_t not an int. This is maybe not an issue for architectures that use this driver, but it is nicer to explicitly use the correct return type. Fixes: 96f60e37dc66 ("DRM: Armada: Add Armada DRM driver") Signed-off-by: Christop

[PATCH] drm/amdgpu: Fix missing unlocking in an error path in amdgpu_userq_create()

2025-07-09 Thread Christophe JAILLET
If kasprintf() fails, some mutex still need to be released to avoid locking issue, as already done in all other error handling path. Fixes: c03ea34cbf88 ("drm/amdgpu: add support of debugfs for mqd information") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/amd/amdgpu/amdgpu_u

[PATCH] drm/msm/mdp4: Consistently use the "mdp4_" namespace

2025-06-27 Thread Christophe JAILLET
Functions and other stuff all start with "mdp4_", except a few ones that start with "mpd4_" (d and p switched) Make things consistent and use "mdp4_" everywhere. Signed-off-by: Christophe JAILLET --- The change has been done with: sed -i s/mpd4/mdp4/g * an

[PATCH] drm/amd/display: Constify struct timing_generator_funcs

2025-05-24 Thread Christophe JAILLET
'struct timing_generator_funcs' are not modified in these drivers. Constifying these structures moves some data to a read-only section, so increases overall security, especially when the structure holds some function pointers. Signed-off-by: Christophe JAILLET --- This is NOT comp

Re: [PATCH v5 2/2] drm: bridge: Add support for Solomon SSD2825 RGB/DSI bridge

2025-05-06 Thread Christophe JAILLET
Le 06/05/2025 à 11:33, Svyatoslav Ryhel a écrit : SSD2825 is a cost-effective MIPI Bridge Chip solution targeting mainly smartphones. It can convert 24bit RGB interface into 4-lane MIPI-DSI interface to drive display modules of up to 800 x 1366, while supporting AMOLED, a-si LCD or LTPS panel tec

Re: [PATCH] drm/meson: Cast mode->clock to unsigned long long

2025-04-29 Thread Christophe JAILLET
Le 29/04/2025 à 21:07, I Hsin Cheng a écrit : Coverity scan reported the usage of "mode->clock * 1000" may lead to integer overflow. Cast the type of "mode->clock" to "unsigned long long" when utilizing it to avoid potential integer overflow issue. Link: https://scan5.scan.coverity.com/#/projec

[PATCH v2] drm/bridge: lt9611uxc: Fix an error handling path in lt9611uxc_probe()

2025-04-17 Thread Christophe JAILLET
If lt9611uxc_audio_init() fails, some resources still need to be released before returning the error code. Use the existing error handling path. Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") Signed-off-by: Christophe JAILLET Reviewed-by: Dmitry

Re: [PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-04-17 Thread Christophe JAILLET
Le 18/04/2025 à 02:21, li...@treblig.org a écrit : From: "Dr. David Alan Gilbert" radeon_doorbell_free() was added in 2013 by commit 75efdee11b5d ("drm/radeon: implement simple doorbell page allocator") but never used. Hi, I think than instead of being removed, it should be used in the error

Re: [PATCH] drm/xe/svm: fix dereferencing error pointer in drm_gpusvm_range_alloc()

2025-03-23 Thread Christophe JAILLET
xe/xe_svm.c @@ -80,7 +80,7 @@ xe_svm_range_alloc(struct drm_gpusvm *gpusvm) range = kzalloc(sizeof(*range), GFP_KERNEL); if (!range) - return ERR_PTR(-ENOMEM); + return NULL; INIT_LIST_HEAD(&range->garbage_collector_link); xe_vm_get(gpusvm_to_vm(gp

Re: [PATCH v3 06/16] rbd: convert timeouts to secs_to_jiffies()

2025-02-26 Thread Christophe JAILLET
Le 26/02/2025 à 08:28, Daniel Vacek a écrit : On Tue, 25 Feb 2025 at 22:10, Christophe JAILLET wrote: Le 25/02/2025 à 21:17, Easwar Hariharan a écrit : Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of

Re: [PATCH v3 07/16] libceph: convert timeouts to secs_to_jiffies()

2025-02-25 Thread Christophe JAILLET
Le 25/02/2025 à 21:17, Easwar Hariharan a écrit : Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies() to avoid the multiplication This is converted using scripts/cocc

Re: [PATCH v3 06/16] rbd: convert timeouts to secs_to_jiffies()

2025-02-25 Thread Christophe JAILLET
Le 25/02/2025 à 21:17, Easwar Hariharan a écrit : Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies() to avoid the multiplication This is converted using scripts/cocc

Re: [PATCH v1 2/2] drm: panel: Add driver for Himax HX8279 and Startek KD070FHFID078

2025-02-11 Thread Christophe JAILLET
Le 11/02/2025 à 12:44, AngeloGioacchino Del Regno a écrit : Add a driver for the Himax HX8279-D MIPI-DSI DriverIC with support for the Startek KX070FHFID078 7.0" 1200x1920 IPS panel, found on various MediaTek Genio Evaluation Kit boards. ... + if (!hx->skip_goa_config) { +

Re: [PATCH v4 03/11] mtd: intel-dg: implement region enumeration

2025-01-02 Thread Christophe JAILLET
Le 01/01/2025 à 16:39, Alexander Usyskin a écrit : In intel-dg, there is no access to the spi controller, the information is extracted from the descriptor region. CC: Lucas De Marchi Reviewed-by: Rodrigo Vivi Acked-by: Miquel Raynal Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler

Re: [PATCH v4 02/11] mtd: add driver for intel graphics non-volatile memory device

2025-01-02 Thread Christophe JAILLET
Le 01/01/2025 à 16:39, Alexander Usyskin a écrit : Add auxiliary driver for intel discrete graphics non-volatile memory device. CC: Lucas De Marchi Reviewed-by: Rodrigo Vivi Acked-by: Miquel Raynal Co-developed-by: Tomas Winkler Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin

Re: [PATCH v6 2/3] drm/bridge: ti-sn65dsi83: Add ti,lvds-vod-swing optional properties

2024-12-12 Thread Christophe JAILLET
Le 12/12/2024 à 13:17, Andrej Picej a écrit : Add a optional properties to change LVDS output voltage. This should not be static as this depends mainly on the connected display voltage requirement. We have three properties: - "ti,lvds-termination-ohms", which sets near end termination, - "ti,lvds

[PATCH] drm/amdgpu: Fix an error handling path in amdgpu_device_xgmi_reset_func()

2024-11-19 Thread Christophe JAILLET
In case of error after a amdgpu_gfx_rlc_enter_safe_mode() call, it is not balanced by a corresponding amdgpu_gfx_rlc_exit_safe_mode() call. Add the missing call. Fixes: c6a6e2db9945 ("drm/amdgpu: Redo XGMI reset synchronization.") Signed-off-by: Christophe JAILLET --- Compile tested o

[PATCH] drm/amd/pm: Fix an error handling path in vega10_enable_se_edc_force_stall_config()

2024-11-19 Thread Christophe JAILLET
In case of error after a amdgpu_gfx_rlc_enter_safe_mode() call, it is not balanced by a corresponding amdgpu_gfx_rlc_exit_safe_mode() call. Add the missing call. Fixes: 9b7b8154cdb8 ("drm/amd/powerplay: added didt support for vega10") Signed-off-by: Christophe JAILLET --- *Not* ev

Re: [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script

2024-11-15 Thread Christophe JAILLET
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > Suggested-by: Anna-Maria Behnsen > Signed-off-by: Easwar Hariharan > --- > scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/scripts/coccinelle/misc/secs_to_jiffies.

[PATCH] drm/radeon: Constify struct pci_device_id

2024-11-15 Thread Christophe JAILLET
fc drivers/gpu/drm/radeon/radeon_drv.o After: = textdata bss dec hex filename 4 664 44 407089f04 drivers/gpu/drm/radeon/radeon_drv.o Signed-off-by: Christophe JAILLET --- Compile tested-only. --- drivers/gpu/drm/radeon/radeon_drv.c | 3 +-- 1 file

[PATCH v2] drm/i2c: tda9950: Constify struct i2c_device_id

2024-11-15 Thread Christophe JAILLET
9e drivers/gpu/drm/i2c/tda9950.o After: = textdata bss dec hex filename 12200 758 0 12958329e drivers/gpu/drm/i2c/tda9950.o Signed-off-by: Christophe JAILLET --- Compile tested-only. v2: fix missing const :( --- drivers/gpu/drm/i2c/tda9950.c | 2 +- 1 fi

[PATCH] drm/i2c: tda9950: Constify struct i2c_device_id

2024-11-15 Thread Christophe JAILLET
9e drivers/gpu/drm/i2c/tda9950.o After: = textdata bss dec hex filename 12200 758 0 12958329e drivers/gpu/drm/i2c/tda9950.o Signed-off-by: Christophe JAILLET --- Compile tested-only. --- drivers/gpu/drm/i2c/tda9950.c | 2 +- 1 file changed, 1 inser

Re: [PATCH] drm/bridge: Constify struct i2c_device_id

2024-11-13 Thread Christophe JAILLET
Le 12/11/2024 à 23:43, Laurent Pinchart a écrit : Hi Christophe, Thank you for the patch. On Tue, Nov 12, 2024 at 10:12:25PM +0100, Christophe JAILLET wrote: 'struct i2c_device_id' is not modified in these drivers. Constifying this structure moves some data to a read-only s

[PATCH] drm/bridge: Constify struct i2c_device_id

2024-11-12 Thread Christophe JAILLET
32 1658540c9 drivers/gpu/drm/bridge/chipone-icn6211.o After: = textdata bss dec hex filename 15630 923 32 1658540c9 drivers/gpu/drm/bridge/chipone-icn6211.o Signed-off-by: Christophe JAILLET --- Compile tested-only. --- drivers/gpu/drm/bridge/chipone

Re: [PATCH] drm/mgag200: Apply upper limit for clock variable

2024-11-11 Thread Christophe JAILLET
Le 11/11/2024 à 14:46, Murad Masimov a écrit : If the value of the clock variable is higher than 80, the value of the variable m, which is used as a divisor, will remain zero, because (clock * testp) will be higher than vcomax in every loop iteration, which leads to skipping every iteration a

Re: [PATCH v2] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-29 Thread Christophe JAILLET
Le 29/10/2024 à 11:18, Li Huafei a écrit : Fix the potential NULL pointer dereference on mem_ranges in amdgpu_discovery_get_nps_info(). Additionally, assign the output parameters nps_type and range_cnt after the kvzalloc() call to prevent modifying the output parameters in case of an error return

[PATCH] drm/tiny: Fix some error handling paths in sharp_memory_probe()

2024-10-25 Thread Christophe JAILLET
Add driver for Sharp Memory LCD") Signed-off-by: Christophe JAILLET --- Compile tested only --- drivers/gpu/drm/tiny/sharp-memory.c | 66 ++--- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/tiny/sharp-memory.c b/drivers/gpu/drm/tiny/

[PATCH] fbdev: Constify struct sbus_mmap_map

2024-10-13 Thread Christophe JAILLET
ss dec hex filename 2452 536 163004 bbc drivers/video/fbdev/bw2.o After: = textdata bss dec hex filename 2500 483 162999 bb7 drivers/video/fbdev/bw2.o Signed-off-by: Christophe JAILLET --- Compile tested only with a cross compiler

Re: [PATCH] drm/i915/display: Remove kstrdup_const() and kfree_const() usage

2024-10-04 Thread Christophe JAILLET
Le 04/10/2024 à 11:35, Jani Nikula a écrit : On Thu, 03 Oct 2024, Christophe JAILLET wrote: kstrdup_const() and kfree_const() can be confusing in code built as a module. In such a case, it does not do what one could expect from the name of the functions. The code is not wrong by itself, but

[PATCH] drm/i915/display: Remove kstrdup_const() and kfree_const() usage

2024-10-03 Thread Christophe JAILLET
straightforward. This reverts commit 379b63e7e682 ("drm/i915/display: Save a few bytes of memory in intel_backlight_device_register()") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/i915/display/intel_backlight.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d

Re: [PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-10-02 Thread Christophe JAILLET
Le 02/10/2024 à 13:51, Jani Nikula a écrit : On Tue, 01 Oct 2024, Christophe JAILLET wrote: Le 30/09/2024 à 09:48, Jani Nikula a écrit : On Sat, 28 Sep 2024, Christophe JAILLET wrote: "name" is allocated and freed in intel_backlight_device_register(). The initial allocation just

Re: [PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-10-01 Thread Christophe JAILLET
Le 30/09/2024 à 09:48, Jani Nikula a écrit : On Sat, 28 Sep 2024, Christophe JAILLET wrote: "name" is allocated and freed in intel_backlight_device_register(). The initial allocation just duplicates "intel_backlight". Later, if a device with this name has already been

[PATCH] drm/i915/backlight: Remove a useless kstrdup_const()

2024-09-28 Thread Christophe JAILLET
plain kstrdup() and kfree(). Slightly change the logic and introduce a new variable to hold the address returned by kasprintf() should it be used. This saves a memory allocation/free and avoids these _const functions, which names can be confusing when used with code built as module. Signed-o

Re: [PATCH v3] drm/qxl: Add drm_panic support

2024-09-20 Thread Christophe JAILLET
Le 21/09/2024 à 06:33, Ryosuke Yasuoka a écrit : QXL supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka --- Hi, a few comments/nitpicks below, if of interest. diff --git a/drivers/gpu/drm/qxl/qxl_cmd.c b/drivers/

[PATCH] drm/ipuv3/parallel: Fix an error handling path in imx_pd_probe()

2024-09-06 Thread Christophe JAILLET
If component_add() fails, we need to undo a potential previous drm_edid_alloc() call. Add an error handling path and the missing drm_edid_free(), as already done in the reomve function. Fixes: 42e08287a318 ("drm/ipuv3/parallel: convert to struct drm_edid") Signed-off-by: Christop

Re: [PATCH -next] drm/imagination: Use memdup_user() helper

2024-08-31 Thread Christophe JAILLET
Le 31/08/2024 à 12:30, Jinjie Ruan a écrit : Switching to memdup_user(), which combines kmalloc() and copy_from_user(), and it can simplfy code. Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/imagination/pvr_context.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions

Re: [PATCH -next 2/5] drm/mediatek: Fix missing of_node_put() for mtk_drm_get_all_drm_priv()

2024-08-24 Thread Marion & Christophe JAILLET
Le 23/08/2024 à 12:46, Christophe JAILLET a écrit : @@ -933,10 +931,8 @@ static int mtk_drm_probe(struct platform_device *pdev)   }   ret = mtk_ddp_comp_init(node, &private->ddp_comp[comp_id], comp_id); -    if (ret) { -    of_node_put(node); +   

Re: [PATCH -next 2/5] drm/mediatek: Fix missing of_node_put() for mtk_drm_get_all_drm_priv()

2024-08-23 Thread Christophe JAILLET
Le 23/08/2024 à 11:20, Jinjie Ruan a écrit : In mtk_drm_get_all_drm_priv(), break in for_each_child_of_node() should call of_node_put() to avoid child node resource leak, use for_each_child_of_node_scoped() to fix it. And avoid the need for manual cleanup of_node_put() in early exits from the lo

Re: [RESEND PATCH v4 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-08-19 Thread Christophe JAILLET
Le 19/08/2024 à 23:49, Alex Lanzano a écrit : Add support for the monochrome Sharp Memory LCDs. Hi, a few nitpick below, should thre be a v5. ... +struct sharp_memory_device { + struct drm_device drm; + struct spi_device *spi; + + const struct drm_display_mode *mode; + +

Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-09 Thread Christophe JAILLET
Le 09/08/2024 à 16:42, Dan Carpenter a écrit : On Thu, Aug 08, 2024 at 11:46:11AM +0200, Christophe JAILLET wrote: Use sysfs_emit_at() instead of snprintf() + custom logic. Using sysfs_emit_at() is much more simple. Also, sysfs_emit() is already used in this function, so using sysfs_emit_at

[PATCH] fbdev: omapfb: Use sysfs_emit_at() to simplify code

2024-08-08 Thread Christophe JAILLET
ly simplifies the code and makes it more readable. Signed-off-by: Christophe JAILLET --- Compile tested only. 2 spaces are added before color_caps[i].name and color_caps[i].name, but not ctrl_caps[i].name. I wonder if it is done on purpose or if it could be removed as well. --- drivers/vid

[PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify show_cabc_available_modes()

2024-08-08 Thread Christophe JAILLET
'\n' Finally it is easy to see that, given the size of cabc_modes, PAGE_SIZE can not be reached. So better keep everything simple (and correct). Signed-off-by: Christophe JAILLET --- .../omap2/omapfb/displays/panel-sony-acx565akm.c | 15 --- 1 file changed, 8 insert

[PATCH 2/2] drm/dp_mst: Slightly optimize drm_dp_mst_i2c_write() (2/2)

2024-08-06 Thread Christophe JAILLET
'msg' is only used with drm_dp_encode_sideband_req() which takes a "const struct drm_dp_sideband_msg_req_body *". So some initializations can be done only once outside of the for loop. Signed-off-by: Christophe JAILLET --- In case of interest, on x86_64, with allmodconfig,

[PATCH 1/2] drm/dp_mst: Slightly optimize drm_dp_mst_i2c_write() (1/2)

2024-08-06 Thread Christophe JAILLET
'txmsg' is memset()'ed in the for loop below, before usage. So we can save another initialization txmsg when it is allocated. Signed-off-by: Christophe JAILLET --- In case of interest, on x86_64, with allmodconfig, sizeof(*txmsg) is 768 bytes. --- drivers/gpu/drm/display/drm_dp

[PATCH v2] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-08-01 Thread Christophe JAILLET
If an error occurs after request_mem_region(), a corresponding release_mem_region() should be called, as already done in the remove function. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Christophe JAILLET --- *Not* even compile tested only. It is provided as-is Cha

Re: [PATCH v3] udmabuf: use kmem_cache to alloc udmabuf folio

2024-07-31 Thread Christophe JAILLET
Le 31/07/2024 à 09:37, Huan Yang a écrit : The current udmabuf_folio contains a list_head and the corresponding folio pointer, with a size of 24 bytes. udmabuf_folio uses kmalloc to allocate memory. However, kmalloc is a public pool, starting from 8,16,32 bytes. Additionally, if the size is not

Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-29 Thread Christophe JAILLET
Le 29/07/2024 à 22:09, Helge Deller a écrit : On 7/29/24 17:59, Dan Carpenter wrote: On Mon, Jul 29, 2024 at 10:13:17AM +0200, Helge Deller wrote: On 7/28/24 20:29, Christophe JAILLET wrote: If an error occurs after request_mem_region(), a corresponding release_mem_region() should be called

[PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-28 Thread Christophe JAILLET
If an error occurs after request_mem_region(), a corresponding release_mem_region() should be called, as already done in the remove function. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Christophe JAILLET --- *Not* even compile tested only. I don't know on what archite

Re: [PATCH v2 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-26 Thread Christophe JAILLET
Le 26/07/2024 à 21:44, Alex Lanzano a écrit : Add support for the monochrome Sharp Memory LCDs. Signed-off-by: Alex Lanzano Co-developed-by: Mehdi Djait Signed-off-by: Mehdi Djait --- MAINTAINERS | 7 + drivers/gpu/drm/tiny/Kconfig| 20 + drivers/gpu/d

Re: [PATCH 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-24 Thread Christophe JAILLET
Le 25/07/2024 à 02:47, Alex Lanzano a écrit : Add support for the monochrome Sharp Memory LCDs. Signed-off-by: Alex Lanzano --- MAINTAINERS | 8 + drivers/gpu/drm/tiny/Kconfig| 20 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/sharp

Re: [PATCH] drm/nouveau/debugfs: Simplify character output in nouveau_debugfs_vbios_image()

2024-07-23 Thread Christophe JAILLET
was transformed by using the Coccinelle software. Suggested-by: Christophe Jaillet Signed-off-by: Markus Elfring --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau

[PATCH] accel/habanalabs/gaudi2: Constify several structures

2024-07-22 Thread Christophe JAILLET
drivers/accel/habanalabs/gaudi2/gaudi2.o After: = textdata bss dec hex filename 198862 126532 456 325850 4f8da drivers/accel/habanalabs/gaudi2/gaudi2.o Signed-off-by: Christophe JAILLET --- Compile tested-only. A much bigger step, would be to constify

[PATCH] drm/exynos: Constify struct exynos_drm_ipp_funcs

2024-07-14 Thread Christophe JAILLET
46 16 2220856c0 drivers/gpu/drm/exynos/exynos_drm_fimc.o After: = textdata bss dec hex filename 204461714 16 2217656a0 drivers/gpu/drm/exynos/exynos_drm_fimc.o Signed-off-by: Christophe JAILLET --- Compile tested-only. --- drivers/gpu/

[PATCH] drm/rockchip: Constify struct drm_encoder_helper_funcs

2024-07-13 Thread Christophe JAILLET
080101f4a drivers/gpu/drm/rockchip/analogix_dp-rockchip.o After: = textdata bss dec hex filename 7578 424 080021f42 drivers/gpu/drm/rockchip/analogix_dp-rockchip.o Signed-off-by: Christophe JAILLET --- Compile tested-only. --- drivers/gpu/dr

[PATCH] fbdev: mmp: Constify struct mmp_overlay_ops

2024-06-24 Thread Christophe JAILLET
16 123693051 drivers/video/fbdev/mmp/hw/mmp_ctrl.o After: = textdata bss dec hex filename 11834 507 16 123573045 drivers/video/fbdev/mmp/hw/mmp_ctrl.o Signed-off-by: Christophe JAILLET --- Compile tested-only --- drivers/video/fbdev/mmp/hw/mmp_

Re: [PATCH 2/2] drm/panel-xinpeng-xpp055c272: add check for mipi_dsi_dcs_enter_sleep_mode

2024-06-20 Thread Christophe JAILLET
dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret); return ret; Reviewed-by: Christophe JAILLET See: https://lore.kernel.org/all/6e3a8cb3956fe94f1259c13053fddb378e7d0d82.1619878508.git.christophe.jail...@wanadoo.fr/ which never got any feedback. CJ

Re: [PATCH 1/2] drm/panel: ltk050h3146w: add check for mipi_dsi_dcs_enter_sleep_mode

2024-06-20 Thread Christophe JAILLET
%d\n", ret); return ret; Reviewed-by: Christophe JAILLET See: https://lore.kernel.org/all/588e8b4519487f6d33419c4b0fa7f8ea1b26cb58.1619869792.git.christophe.jail...@wanadoo.fr/ which never got any feedback. CJ

[PATCH] drm/nouveau: Constify struct nouveau_job_ops

2024-06-14 Thread Christophe JAILLET
166e drivers/gpu/drm/nouveau/nouveau_exec.o Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/nouveau/nouveau_exec.c | 2 +- drivers/gpu/drm/nouveau/nouveau_sched.h | 4 ++-- drivers/gpu/drm/nouveau/nouveau_uvmm.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

[PATCH v2] dma-buf/fence-array: Add flex array to struct dma_fence_array

2024-05-25 Thread Christophe JAILLET
nts [1] Link: https://github.com/KSPP/linux/issues/160 [2] Signed-off-by: Christophe JAILLET Reviewed-by: Kees Cook --- Compile tested only. Changes in v2: - Name the new field 'callbacks' instead of 'cb' [Christian König] v1: https://lore.kernel.org/all/d3204a5b477

[PATCH] drm/panel: lg-sw43408: Fix an error handling path in sw43408_probe()

2024-05-20 Thread Christophe JAILLET
If mipi_dsi_attach() fails, we must undo the drm_panel_add() call hidden in sw43408_add(), as already done in the remove function. Fixes: 069a6c0e94f9 ("drm: panel: Add LG sw43408 panel driver") Signed-off-by: Christophe JAILLET --- Compile tested only --- drivers/gpu/drm/panel/panel-

[PATCH] drm: zynqmp_dpsub: Fix an error handling path in zynqmp_dpsub_probe()

2024-05-20 Thread Christophe JAILLET
If zynqmp_dpsub_drm_init() fails, we must undo the previous drm_bridge_add() call. Fixes: be3f3042391d ("drm: zynqmp_dpsub: Always register bridge") Signed-off-by: Christophe JAILLET --- Compile tested only --- drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 1 + 1 file changed, 1 insertio

[PATCH] dma-buf/fence-array: Add flex array to struct dma_fence_array

2024-05-18 Thread Christophe JAILLET
nts [1] Link: https://github.com/KSPP/linux/issues/160 [2] Signed-off-by: Christophe JAILLET --- Compile tested only. Also, I don't think that 'cb' is a great name and the associated kernel-doc description could certainly be improved. Any proposal welcomed :) --- dri

Re: [PATCH] drm/nouveau/nvif: Avoid build error due to potential integer overflows

2024-05-18 Thread Christophe JAILLET
(adding linux-harden...@vger.kernel.org) Le 18/05/2024 à 16:37, Guenter Roeck a écrit : Trying to build parisc:allmodconfig with gcc 12.x or later results in the following build error. drivers/gpu/drm/nouveau/nvif/object.c: In function 'nvif_object_mthd': drivers/gpu/drm/nouveau/nvif/object.c:

Re: [PATCH v3 2/2] drm/panel: Add driver for EDO RM69380 OLED panel

2024-04-16 Thread Christophe JAILLET
Le 16/04/2024 à 20:30, David Wronek a écrit : Add support for the 2560x1600@90Hz OLED panel by EDO bundled with a Raydium RM69380 controller, as found on the Lenovo Xiaoxin Pad Pro 2021. Signed-off-by: David Wronek --- drivers/gpu/drm/panel/Kconfig | 14 + drivers/gpu/drm/pa

Re: [PATCH v2 2/2] drm/panel: Add driver for EDO RM69380 OLED panel

2024-04-15 Thread Christophe JAILLET
Le 15/04/2024 à 18:10, David Wronek a écrit : Add support for the 2560x1600@90Hz OLED panel by EDO bundled with a Raydium RM69380 controller, as found on the Lenovo Xiaoxin Pad Pro 2021. Signed-off-by: David Wronek --- drivers/gpu/drm/panel/Kconfig | 14 + drivers/gpu/drm/pa

Re: [PATCH 2/2] drm/panel: Add driver for EDO RM69380 OLED panel

2024-04-14 Thread Christophe JAILLET
Le 15/04/2024 à 07:37, david-vu3dztd92roxwddmvfq...@public.gmane.org a écrit : W dniu 2024-04-14 22:22, Christophe JAILLET napisał(a): Le 14/04/2024 à 17:22, David Wronek a écrit : Add support for the 2560x1600@90Hz OLED panel by EDO bundled with a Raydium RM69380 controller, as found on the

Re: [PATCH 2/2] drm/panel: Add driver for EDO RM69380 OLED panel

2024-04-14 Thread Christophe JAILLET
Le 14/04/2024 à 17:22, David Wronek a écrit : Add support for the 2560x1600@90Hz OLED panel by EDO bundled with a Raydium RM69380 controller, as found on the Lenovo Xiaoxin Pad Pro 2021. Signed-off-by: David Wronek --- drivers/gpu/drm/panel/Kconfig | 14 + drivers/gpu/drm/pa

Re: [PATCH] drm/i915/guc: Remove usage of the deprecated ida_simple_xx() API

2024-04-14 Thread Christophe JAILLET
Le 25/01/2024 à 01:04, Matthew Brost a écrit : On Sun, Jan 14, 2024 at 04:15:34PM +0100, Christophe JAILLET wrote: ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one

Re: [PATCH v2] treewide: Fix common grammar mistake "the the"

2024-04-11 Thread Christophe JAILLET
Le 11/04/2024 à 19:11, Thorsten Blum a écrit : Use `find . -type f -exec sed -i 's/\/the/g' {} +` to find all occurrences of "the the" and replace them with a single "the". In arch/arm/include/asm/unwind.h replace "the the" with "to the". Changes only comments and documentation - no code change

Re: [PATCH v5 08/11] devm-helpers: Add resource managed version of debugfs directory create function

2024-03-24 Thread Christophe JAILLET
Le 23/03/2024 à 22:25, Marek Behún a écrit : On Sat, 23 Mar 2024 22:10:40 +0100 Christophe JAILLET wrote: ... static int pvt_ts_dbgfs_create(struct pvt_device *pvt, struct device *dev) { - pvt->dbgfs_dir = debugfs_create_dir(dev_name(dev), NULL); + pvt->dbg

Re: [PATCH v5 08/11] devm-helpers: Add resource managed version of debugfs directory create function

2024-03-23 Thread Christophe JAILLET
Le 23/03/2024 à 17:43, Marek Behún a écrit : A few drivers register a devm action to remove a debugfs directory, implementing a one-liner function that calls debufs_remove_recursive(). Help drivers avoid this repeated implementations by adding managed version of debugfs directory create function.

[PATCH] drm/bridge: lt9611uxc: Fix an error handling path in lt9611uxc_probe()

2024-03-16 Thread Christophe JAILLET
If lt9611uxc_audio_init() fails, some resources still need to be released before returning the error code. Use the existing error handling path. Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") Signed-off-by: Christophe JAILLET --- Compile tested only. --

[PATCH] drm/i915/display: Save a few bytes of memory in intel_backlight_device_register()

2024-02-23 Thread Christophe JAILLET
'name' may still be "intel_backlight" when backlight_device_register() is called. In such a case, using kstrdup_const() saves a memory duplication when dev_set_name() is called in backlight_device_register(). Use kfree_const() accordingly. Signed-off-by: Christophe JAILLET

Re: [PATCH] drm/xe/guc: Remove usage of the deprecated ida_simple_xx() API

2024-02-20 Thread Christophe JAILLET
Le 14/01/2024 à 16:09, Christophe JAILLET a écrit : ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one of ida_alloc_max() is inclusive. So a -1 has been added when

Re: [PATCH v2] udmabuf: Fix a potential (and unlikely) access to unallocated memory

2024-02-19 Thread Christophe JAILLET
Le 19/02/2024 à 09:37, Dan Carpenter a écrit : On Sun, Feb 18, 2024 at 06:46:44PM +0100, Christophe JAILLET wrote: If 'list_limit' is set to a very high value, 'lsize' computation could overflow if 'head.count' is big enough. The "list_limit" is set

[PATCH v2] udmabuf: Fix a potential (and unlikely) access to unallocated memory

2024-02-18 Thread Christophe JAILLET
Fixes: fbb0de795078 ("Add udmabuf misc device") Signed-off-by: Christophe JAILLET --- v2: - Use memdup_array_user() [Kees Cook] - Use sizeof(*list) [Gustavo A. R. Silva] - Add include v1: https://lore.kernel.org/all/3e37f05c7593f1016f0a46de188b3357cbbd0c0b.1695060389

Re: [PATCH V8 02/12] phy: freescale: add Samsung HDMI PHY

2024-02-03 Thread Christophe JAILLET
Le 03/02/2024 à 17:52, Adam Ford a écrit : From: Lucas Stach This adds the driver for the Samsung HDMI PHY found on the i.MX8MP SoC. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford Tested-by: Alexander Stein --- ... +static int fsl_samsung_hdmi_phy_probe(struct platform_device *pde

Re: [PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver

2024-01-19 Thread Christophe JAILLET
Le 18/01/2024 à 18:32, Duje Mihanović a écrit : Add driver for the Kinetic KTD2801 backlight driver. Signed-off-by: Duje Mihanović --- ... + ktd2801->gpiod = devm_gpiod_get(dev, "ctrl", GPIOD_OUT_HIGH); + if (IS_ERR(ktd2801->gpiod)) + return dev_err_probe(dev, PTR

[PATCH] drm/i915/guc: Remove usage of the deprecated ida_simple_xx() API

2024-01-14 Thread Christophe JAILLET
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one of ida_alloc_range() is inclusive. So a -1 has been added when needed. Signed-off-by: Christophe JAILLET

[PATCH] drm/amdgpu: Remove usage of the deprecated ida_simple_xx() API

2024-01-14 Thread Christophe JAILLET
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one of ida_alloc_range() is inclusive. So a -1 has been added when needed. Signed-off-by: Christophe JAILLET

[PATCH] drm/xe/guc: Remove usage of the deprecated ida_simple_xx() API

2024-01-14 Thread Christophe JAILLET
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). Note that the upper limit of ida_simple_get() is exclusive, but the one of ida_alloc_max() is inclusive. So a -1 has been added when needed. Signed-off-by: Christophe JAILLET --- drivers

[PATCH] drm/amd/display: Fix a switch statement in populate_dml_output_cfg_from_stream_state()

2024-01-13 Thread Christophe JAILLET
It is likely that the statement related to 'dml_edp' is misplaced. So move it in the correct "case SIGNAL_TYPE_EDP". Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_h

[PATCH] drm/stm: Fix an error handling path in stm_drm_platform_probe()

2024-01-06 Thread Christophe JAILLET
If drm_dev_register() fails, a call to drv_load() must be undone, as already done in the remove function. Fixes: b759012c5fa7 ("drm/stm: Add STM32 LTDC driver") Signed-off-by: Christophe JAILLET --- This was already sent a few years ago in [1] but it got no response. Since, there has

Re: [PATCH 1/2] drm/panel: ltk050h3146w: only print message when GPIO getting is not EPROBE_DEFER

2024-01-04 Thread Christophe JAILLET
reset GPIO is printed even though later on the device actually manages to get probed. Use dev_err_probe instead so that the message is only printed when it truly matters. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Christophe JAILLET --- drivers/gpu/drm/panel/panel-le

Re: [PATCH 2/2] drm/panel: ltk050h3146w: use dev_err_probe wherever possible

2024-01-04 Thread Christophe JAILLET
s not EPROBE_DEFER, but this is seen as an improvement. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Christophe JAILLET --- drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/

Re: [PATCH linux-next] drm/amd/display: replace kzalloc and memcpy with kmemdup

2023-12-08 Thread Christophe JAILLET
Le 08/12/2023 à 03:44, yang.gua...@zte.com.cn a écrit : From: Yang Guang Convert kzalloc/memcpy operations to memdup makes for cleaner code and avoids memcpy() failures Hi, usually, function's names are written with () in commit description. (i.e. kzalloc()/memcpy()). memdup should be kme

[PATCH] fbdev/offb: Simplify offb_init_fb()

2023-10-20 Thread Christophe JAILLET
Turn a strcpy()+strncat()+'\0' into an equivalent snprintf(). Signed-off-by: Christophe JAILLET --- This patch is *not* even compile tested because cross-compiling leads to some errors like on my machine: cc1: error: cannot load plugin ./scripts/gcc-plugins/randomize_layout

[PATCH] drm/amd: Fix the size of a buffer in amdgpu_vcn_idle_work_handler()

2023-09-22 Thread Christophe JAILLET
quot;, ucode_prefix); | ^ Fixes: 69939009bde7 ("drm/amd: Load VCN microcode during early_init") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c

Re: [PATCH] udmabuf: Fix a potential (and unlikely) access to unallocated memory

2023-09-18 Thread Christophe JAILLET
Le 18/09/2023 à 05:10, Gustavo A. R. Silva a écrit : On 9/18/23 12:46, Christophe JAILLET wrote: If 'list_limit' is set to a very high value, 'lsize' computation could overflow if 'head.count' is big enough. In such a case, udmabuf_create() will access to memor

[PATCH] udmabuf: Fix a potential (and unlikely) access to unallocated memory

2023-09-18 Thread Christophe JAILLET
: fbb0de795078 ("Add udmabuf misc device") Signed-off-by: Christophe JAILLET --- drivers/dma-buf/udmabuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index c40645999648..fb4c4b5b3332 100644 --- a/drivers

Re: [PATCH] drm/simpledrm: Add support for multiple "power-domains"

2023-09-10 Thread Christophe JAILLET
Le 10/09/2023 à 18:39, Janne Grunau via B4 Relay a écrit : From: Janne Grunau Multiple power domains need to be handled explicitly in each driver. The driver core can not handle it automatically since it is not aware of power sequencing requirements the hardware might have. This is not a proble

[PATCH] accel/habanalabs/gaudi2: Fix incorrect string length computation in gaudi2_psoc_razwi_get_engines()

2023-09-04 Thread Christophe JAILLET
instead of snprintf(). Fixes: c0e6df916050 ("accel/habanalabs: fix address decode RAZWI handling") Signed-off-by: Christophe JAILLET --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/habanalabs/gaudi2/gau

[PATCH] drm/rockchip: cdn-dp: Fix some error handling paths in cdn_dp_probe()

2023-09-02 Thread Christophe JAILLET
) Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index a29fbafce393..3793863c210e 100644 --- a/drivers/g

[PATCH 6/6] drm/tegra: output: Fix missing i2c_put_adapter() in the error handling paths of tegra_output_probe()

2023-09-02 Thread Christophe JAILLET
If an error occurs after a successful of_get_i2c_adapter_by_node() call, it should be undone by a corresponding i2c_put_adapter(). Add the missing i2c_put_adapter() call. Fixes: 9be7d864cf07 ("drm/tegra: Implement panel support") Signed-off-by: Christophe JAILLET --- drivers/gpu

[PATCH 5/6] drm/tegra: rgb: Fix missing clk_put() in the error handling paths of tegra_dc_rgb_probe()

2023-09-02 Thread Christophe JAILLET
If clk_get_sys(..., "pll_d2_out0") fails, the clk_get_sys() call must be undone. Add the missing clk_put and a new 'put_pll_d_out0' label in the error handling path, and use it. Fixes: 0c921b6d4ba0 ("drm/tegra: dc: rgb: Allow changing PLLD rate on Tegra30+") Sig

  1   2   3   4   >