[PATCH v3] pci: use security_capable() when checking capablities during config space read

2011-02-14 Thread Chris Wright
Signed-off-by: Chris Wright --- v2: added Reported-by Eric v3: fix logic screw up drivers/pci/pci-sysfs.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 8ecaac9..ea25e5b 100644 --- a/drivers/pci/pci-sysfs.c ++

[PATCH v3] pci: use security_capable() when checking capablities during config space read

2011-02-14 Thread Chris Wright
Signed-off-by: Chris Wright --- v2: added Reported-by Eric v3: fix logic screw up drivers/pci/pci-sysfs.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 8ecaac9..ea25e5b 100644 --- a/drivers/pci/pci-sysfs.c ++

Re: Regression - Xorg start failed

2011-02-14 Thread Chris Wright
* Sedat Dilek (sedat.di...@googlemail.com) wrote: > On Mon, Feb 14, 2011 at 5:20 PM, Chris Wright wrote: > > * Sedat Dilek (sedat.di...@googlemail.com) wrote: > >> [ As I am not subscribed to both MLs and lazy to pick up all involved > >> people ] > >> > &g

Re: Regression - Xorg start failed

2011-02-14 Thread Chris Wright
* Dave Young (hidave.darks...@gmail.com) wrote: > On Sun, Feb 13, 2011 at 04:35:31PM -0800, Chris Wright wrote: > > Commit 47970b1 ("pci: use security_capable() when checking capablities > > during config space read") is just plain broken. The normal capable() >

Re: Regression - Xorg start failed

2011-02-14 Thread Chris Wright
* Sedat Dilek (sedat.di...@googlemail.com) wrote: > [ As I am not subscribed to both MLs and lazy to pick up all involved people ] > > Hi Chris, > > The original patch had also this part (see the revert in [1]): > ... > +#include > ... > > Your new patch in [2] is missing it or is it not requir

Regression - Xorg start failed

2011-02-14 Thread Chris Wright
* Sedat Dilek (sedat.dilek at googlemail.com) wrote: > On Mon, Feb 14, 2011 at 5:20 PM, Chris Wright wrote: > > * Sedat Dilek (sedat.dilek at googlemail.com) wrote: > >> [ As I am not subscribed to both MLs and lazy to pick up all involved > >> people ] > >> &

Regression - Xorg start failed

2011-02-14 Thread Chris Wright
* Dave Young (hidave.darkstar at gmail.com) wrote: > On Sun, Feb 13, 2011 at 04:35:31PM -0800, Chris Wright wrote: > > Commit 47970b1 ("pci: use security_capable() when checking capablities > > during config space read") is just plain broken. The normal capable() >

Regression - Xorg start failed

2011-02-14 Thread Chris Wright
* Sedat Dilek (sedat.dilek at googlemail.com) wrote: > [ As I am not subscribed to both MLs and lazy to pick up all involved people ] > > Hi Chris, > > The original patch had also this part (see the revert in [1]): > ... > +#include > ... > > Your new patch in [2] is missing it or is it not req

Re: Regression - Xorg start failed

2011-02-14 Thread Chris Wright
space read Commit 47970b1 ("pci: use security_capable() when checking capablities during config space read") is just plain broken. The normal capable() interface returns true on success, but the LSM interface returns 0 on success. Signed-off-by: Chris Wright --- I've tested thi

Re: Regression - Xorg start failed

2011-02-14 Thread Chris Wright
* Dave Airlie (airl...@gmail.com) wrote: > On Sun, Feb 13, 2011 at 4:22 PM, Dave Young wrote: > > With kernel built from current linus's tree, I can not start xorg, > > it failed with: > > Me too!, > > Thanks for bisceting this, I just tried -rc4 on my Fedora 13 laptop > and wasn't looking forwa

Re: Regression - Xorg start failed

2011-02-14 Thread Chris Wright
* Dave Airlie (airl...@gmail.com) wrote: > Yes most likely, I'm not at the machine now but I'll see if I can the > AVC off it later. Great, thanks. > On Fedora 13? > > F14/rawhide seem fine. I'm on F14. ___ dri-devel mailing list dri-devel@lists.freed

Regression - Xorg start failed

2011-02-13 Thread Chris Wright
ly during config space read Commit 47970b1 ("pci: use security_capable() when checking capablities during config space read") is just plain broken. The normal capable() interface returns true on success, but the LSM interface returns 0 on success. Signed-off-by: Chris Wright --- I've tested

Regression - Xorg start failed

2011-02-13 Thread Chris Wright
* Dave Airlie (airlied at gmail.com) wrote: > Yes most likely, I'm not at the machine now but I'll see if I can the > AVC off it later. Great, thanks. > On Fedora 13? > > F14/rawhide seem fine. I'm on F14.

Regression - Xorg start failed

2011-02-13 Thread Chris Wright
* Dave Airlie (airlied at gmail.com) wrote: > On Sun, Feb 13, 2011 at 4:22 PM, Dave Young > wrote: > > With kernel built from current linus's tree, I can not start xorg, > > it failed with: > > Me too!, > > Thanks for bisceting this, I just tried -rc4 on my Fedora 13 laptop > and wasn't looking