-Original Message-
From: Vivi, Rodrigo
Sent: Wednesday, May 7, 2025 12:24 PM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew
; Zhang, Jianxun ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org
-Original Message-
From: Wajdeczko, Michal
Sent: Wednesday, May 7, 2025 9:34 AM
To: Hirschfeld, Dafna ; Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew
; Zhang, Jianxun ; Lin,
Shuicheng ; dri-devel
Ignore this one: I misspelt the name of a recipient
-Jonathan Cavitt
-Original Message-
From: Cavitt, Jonathan
Sent: Wednesday, May 7, 2025 8:57 AM
To: intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
Cavitt, Jonathan ; joonas.lahti...@linux.intel.com;
Brost, Matthew
I think this patch series is still blocked on these requests. Do you want me
to implement these
suggested changes, or should they be dropped?
@Brost, Matthew and @Wajdeczko, Michal
-Jonathan Cavitt
-Original Message-
From: Cavitt, Jonathan
Sent: Wednesday, April 30, 2025 11:42 AM
To
-Original Message-
From: Hirschfeld, Dafna
Sent: Wednesday, April 30, 2025 12:07 AM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew
; Zhang, Jianxun ; Lin,
Shuicheng ; dri-devel
-Original Message-
From: Hirschfeld, Dafna
Sent: Sunday, April 27, 2025 4:57 AM
To: Cavitt, Jonathan
Cc: intel-xe@listxe_uc_fw_types.hs.freedesktop.org; Gupta, saurabhg
; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel
-Original Message-
From: Lin, Shuicheng
Sent: Wednesday, April 23, 2025 8:49 PM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; dri-devel@lists.freedesktop.org;
Wajdeczko, Michal
-Original Message-
From: Auld, Matthew
Sent: Tuesday, April 15, 2025 4:20 AM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel@lists.freedesktop.org
ng the kvmalloc limit
> of 2G. Simple algorithm reads 1.5G at time in xe_devcoredump_read
> callback as needed.
>
> Signed-off-by: Matthew Brost
I have no issues with this patch, though you should maybe get a second opinion.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
ump in VM printer output if full. Helps speedup
> large coredumps which need to walked multiple times in
> xe_devcoredump_read.
>
> Signed-off-by: Matthew Brost
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/xe_vm.c | 3 +++
> 1 file changed
-Original Message-
From: Intel-xe On Behalf Of Matthew
Brost
Sent: Thursday, April 3, 2025 1:27 PM
To: intel...@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH v2 2/4] drm/xe: Update xe_ttm_access_memory to use GPU for
non-visible access
>
> Add migrate layer f
ot;remain" to refer to the "remaining
output the iterator needs to print", rather than the "remaining space in
the output buffer of the iterator".
But that's just an aside. Nothing worth blocking on.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> include/
-Original Message-
From: Briano, Ivan
Sent: Thursday, April 3, 2025 9:46 AM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew
; Zhang, Jianxun ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org
-Original Message-
From: Briano, Ivan
Sent: Wednesday, April 2, 2025 4:22 PM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew
; Zhang, Jianxun ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org
-Original Message-
From: Landwerlin, Lionel G
Sent: Monday, March 31, 2025 1:18 AM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel
-Original Message-
> From: Jadav, Raag
> Sent: Tuesday, March 25, 2025 4:45 PM
> To: Cavitt, Jonathan
> Cc: intel...@lists.freedesktop.org; Gupta, saurabhg
> ; Zuo, Alex ;
> joonas.lahti...@linux.intel.com; Brost, Matthew ;
> Zhang, Jianxun ; Lin, Shu
-Original Message-
From: Jadav, Raag
Sent: Tuesday, March 25, 2025 12:40 AM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew
; Zhang, Jianxun ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org
-Original Message-
From: Jadav, Raag
Sent: Tuesday, March 25, 2025 12:19 AM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew
; Zhang, Jianxun ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org
-Original Message-
From: Jadav, Raag
Sent: Monday, March 24, 2025 2:26 PM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew
; Zhang, Jianxun ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org
-Original Message-
From: Jadav, Raag
Sent: Friday, March 21, 2025 4:37 PM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew
; Zhang, Jianxun ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org
-Original Message-
From: Zhang, Jianxun
Sent: Wednesday, March 19, 2025 4:58 PM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org;
Wajdeczko, Michal
-Original Message-
From: Zhang, Jianxun
Sent: Wednesday, March 19, 2025 2:02 PM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org;
Wajdeczko, Michal
-Original Message-
From: Zhang, Jianxun
Sent: Wednesday, March 19, 2025 12:59 PM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org;
Wajdeczko
-Original Message-
From: Wajdeczko, Michal
Sent: Tuesday, March 18, 2025 3:02 PM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel@lists.freedesktop.org
-Original Message-
From: Wajdeczko, Michal
Sent: Tuesday, March 18, 2025 11:38 AM
To: Cavitt, Jonathan ;
intel...@lists.freedesktop.org; Roper, Matthew D
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel
-Original Message-
From: Zhang, Jianxun
Sent: Tuesday, March 18, 2025 10:48 AM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org;
Wajdeczko, Michal
-Original Message-
From: Wajdeczko, Michal
Sent: Saturday, March 15, 2025 7:45 AM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel@lists.freedesktop.org
-Original Message-
From: Wajdeczko, Michal
Sent: Friday, March 14, 2025 10:02 AM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel@lists.freedesktop.org
-Original Message-
From: Zhang, Jianxun
Sent: Wednesday, March 12, 2025 9:28 AM
To: Cavitt, Jonathan ; Brost, Matthew
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Lin, Shuicheng
; dri-devel@lists.freedesktop.org
Subject: Re
-Original Message-
From: Brost, Matthew
Sent: Monday, March 10, 2025 9:51 PM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ;
Zuo, Alex ; joonas.lahti...@linux.intel.com; Zhang, Jianxun
; Lin, Shuicheng ;
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH
-Original Message-
From: Lin, Shuicheng
Sent: Friday, March 7, 2025 3:26 PM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; dri-devel@lists.freedesktop.org
Subject: RE: [PATCH v6
-Original Message-
From: Wajdeczko, Michal
Sent: Monday, March 10, 2025 11:20 AM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel@lists.freedesktop.org
-Original Message-
From: Mun, Gwan-gyeong
Sent: Friday, March 7, 2025 4:40 AM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel@lists.freedesktop.org
-Original Message-
From: Mun, Gwan-gyeong
Sent: Friday, March 7, 2025 2:35 AM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
Zhang, Jianxun ; Lin, Shuicheng
; dri-devel@lists.freedesktop.org
it's also debatable if the currently returned data
from the
xe_vm_get_property_ioctl is even a "property" of the vm itself.
Any input welcome. Thank you for your time.
-Jonathan Cavitt
-Original Message-----
From: Cavitt, Jonathan
Sent: Tuesday, March 4, 2025 9:09 AM
To: intel...
From: Zhang, Jianxun
Sent: Tuesday, March 4, 2025 12:38 PM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ; Lin,
Shuicheng ; dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v5 6/6] drm/xe/xe_vm
From: Zhang, Jianxun
Sent: Monday, March 3, 2025 12:23 PM
To: Cavitt, Jonathan ; intel...@lists.freedesktop.org
Cc: Gupta, saurabhg ; Zuo, Alex ;
joonas.lahti...@linux.intel.com; Brost, Matthew ;
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 6/6] drm/xe/xe_vm: Implement
Some responses below. If I skip over anything, just assume that I'm taking the
request
into consideration and that it will be fixed for version 2 of this patch series.
-Original Message-
From: Brost, Matthew
Sent: Thursday, February 27, 2025 12:25 AM
To: Cavitt, Jonathan
Cc:
-Original Message-
From: Tvrtko Ursulin
Sent: Tuesday, February 18, 2025 10:39 AM
To: Simona Vetter ; Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Gupta,
saurabhg ; Zuo, Alex ; Lahtinen,
Joonas ; De Marchi, Lucas
; Brost, Matthew
Subject: Re
-Original Message-
From: Simona Vetter
Sent: Monday, February 17, 2025 9:01 AM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Gupta,
saurabhg ; Zuo, Alex ; Lahtinen,
Joonas ; De Marchi, Lucas
; Brost, Matthew ;
tvrtko.ursu...@igalia.com
te PXP execution resources")
> Signed-off-by: Dheeraj Reddy Jonnalagadda
Fair enough.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/xe_vm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/d
sg_free_table() to use a
> folio_batch")
> Signed-off-by: Brian Geffon
> Suggested-by: Tomasz Figa
Seems good to me.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 +-
> 1 file changed, 1 insertion(+
kernel options in drm_fb_helper.o, so leave this
> file in the KMS-helper module for now.
>
> v3:
> - fix commit changelog
> v2:
> - keep client code in core
> - protect lib with DRM_CLIENT_LIB
> - remove duplicate line from Makefile (Jocelyn)
>
> Signed-off-by: Thomas
ient_debugfs_init() if DRM_CLIENT=n (kernel
> test robot)
>
> Signed-off-by: Thomas Zimmermann
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: Xinhui Pan
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/Kconfig
iew this
patch before deciding to push.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/radeon/radeon_device.c | 19 ++-
> drivers/gpu/drm/radeon/radeon_fbdev.c | 6 --
> drivers/gpu/drm/radeon/radeon_mode.h | 3 ---
> 3 files change
is is okay.
I'd wait for an expert on nouveau to respond first before
jumping to push.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/nouveau/nouveau_display.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers
t my place to say this is okay.
I'd wait for an expert on the amdgpu to respond first before
jumping to push.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 22 +++---
> 1 file changed, 11 insertions(+), 1
-Original Message-
From: Intel-xe On Behalf Of Thomas
Zimmermann
Sent: Tuesday, October 8, 2024 4:59 AM
To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com
Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org;
intel-...@lists.freedesktop.org; int
> - rename new files to drm_client_event.{c,h}
>
> Signed-off-by: Thomas Zimmermann
> Cc: Jani Nikula
> Cc: Rodrigo Vivi
> Cc: Joonas Lahtinen
> Cc: Tvrtko Ursulin
> Cc: Karol Herbst
> Cc: Lyude Paul
> Cc: Danilo Krummrich
LGTM.
Reviewed-by: Jonathan Cavitt
-Jona
Thomas Zimmermann
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/drm_fb_helper.c | 31 --
> drivers/gpu/drm/drm_internal.h | 7 +
> drivers/gpu/drm/drm_kms_helper_common.c | 35 +
> 3 files
gt; core DRM module.
>
> Signed-off-by: Thomas Zimmermann
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> ind
gned-off-by: Thomas Zimmermann
> Reported-by: kernel test robot
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202410050241.mox9qrjp-...@intel.com/
> Fixes: 808a40b69468 ("drm/fbdev-dma: Implement damage handling and deferred
> I/O")
> Cc: Thomas Zimmermann
> Cc
; Signed-off-by: Thomas Zimmermann
> Cc: Lucas De Marchi
> Cc: "Thomas Hellström"
> Cc: Rodrigo Vivi
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/xe/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/dr
from i915.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Tvrtko Ursulin
LGTM.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> d
-Original Message-
From: Intel-xe On Behalf Of Matthew
Brost
Sent: Wednesday, September 4, 2024 10:05 AM
To: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Cc: simona.vet...@ffwll.ch; boris.brezil...@collabora.com; Landwerlin, Lionel G
; Graunke, Kenneth W
Subject: [PA
na Vetter
> Signed-off-by: Matthew Brost
LGTM, though there may be an argument to be made that this should
be squashed with the next patch in this series. I won't be making that
argument, however.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> include/uapi/drm/xe_drm.h
-Original Message-
From: Andi Shyti
Sent: Wednesday, August 7, 2024 2:10 AM
To: intel-gfx ; dri-devel
Cc: Chris Wilson ; Das, Nirmoy
; Cavitt, Jonathan ; Andi
Shyti
Subject: [PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable
>
> From: Chris Wilson
>
&
-Original Message-
From: Andi Shyti
Sent: Wednesday, August 7, 2024 3:46 AM
To: intel-gfx ; dri-devel
Cc: Niemiec, Krzysztof ; Andi Shyti
; Cavitt, Jonathan
Subject: [PATCH] drm/i915/gem: Improve pfn calculation readability in
vm_fault_gtt()
>
> By moving the pfn calculation
drm/i915/kernel/-/issues/11255
> Signed-off-by: David Gow
Thank you for the thorough write-up of this issue.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
&g
.
>
> Thanks to Justin Brewer for bisecting the issue.
>
> Fixes: a78a8da51b36 ("drm/ttm: replace busy placement with flags v6")
> Fixes: 4a0e7b3c3753 ("drm/i915: fix applying placement flag")
> Link: https://gitlab.freedesktop.org/drm/i915/kernel/-
it might be best to invert the conditional check
like such:
oa_freq_hz = oa_period > NSEC_PER_SEC ? 0 :
div_u64(NSEC_PER_SEC, (u32)oa_period);
I think this is just a matter of preference, though. The explicit if-else
block is definitely clearer.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
>
> --
> 2.45.2
>
>
>
> trace_i915_gem_object_fault(obj, page_offset, true, write);
>
> @@ -402,12 +441,14 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)
> if (ret)
> goto err_unpin;
>
> + set_address_limits(area, vma, obj_offset, &start, &end);
is ensures that the VMA
> offset is correctly aligned with the corresponding offset within
> the GGTT aperture.
>
> Increment vm_pgoff by the start of the vma_node with the offset=
> provided by the user.
>
> Suggested-by: Chris Wilson
> Signed-off-by: Andi Shyt
-Original Message-
From: Brost, Matthew
Sent: Thursday, August 1, 2024 7:30 AM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
maarten.lankho...@linux.intel.com; Vivi, Rodrigo
Subject: Re: [PATCH v4 2/3] drm/printer: Allow NULL data in
-Original Message-
From: Brost, Matthew
Sent: Wednesday, July 31, 2024 5:03 PM
To: Cavitt, Jonathan
Cc: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
maarten.lankho...@linux.intel.com; Vivi, Rodrigo
Subject: Re: [PATCH v4 2/3] drm/printer: Allow NULL data in
> return devm_add_action_or_reset(xe->drm.dev,
> xe_driver_devcoredump_fini, &xe->drm);
> }
> +
> #endif
> diff --git a/drivers/gpu/drm/xe/xe_devcoredump_types.h
> b/drivers/gpu/drm/xe/xe_devcoredump_types.h
> index 923cdf72a816..0298037edae4 100644
> --- a/drivers/gpu/drm/xe/xe_devcoredump_types.h
> +++ b/drivers/gpu/drm/xe/xe_devcoredump_types.h
> @@ -46,6 +46,10 @@ struct xe_devcoredump_snapshot {
> struct xe_sched_job_snapshot *job;
> /** @vm: Snapshot of VM state */
> struct xe_vm_snapshot *vm;
> + /** @read_data_size: size of read data */
> + ssize_t read_data_size;
> + /** @read_data: Read data */
> + void *read_data;
Perhaps the data size and read data can be stapled together under the same
struct?
struct {
ssize_t size;
void *data;
} read_data;
It's not that big of a deal if this is untouched, just something to consider.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> };
>
> /**
> --
> 2.34.1
>
>
t; - Drop VM in xe_lrc_snapshot_free
>
> 47058633d9c5 ("drm/xe: Move lrc snapshot capturing to xe_lrc.c")
> Cc: Cc: Maarten Lankhorst
> Signed-off-by: Matthew Brost
s/need to the VM/need to get the VM
Otherwise:
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drive
rtain if it could ever be
uninitialized at this
point, but I recognize it as good practice to check just in case regardless.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> ---
> drivers/gpu/drm/drm_print.c | 13 -
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> di
ccurately built,
so fixing it here makes the most sense to me, especially if it's causing
problems.
Reviewed-by: Jonathan Cavitt
-Jonathan Cavitt
> So, add a fix to not consider preemption
> during dequeuing for gen8 platforms.
>
> v2: Simplify can_preempt() function (Tvrtko Ursu
-Original Message-
From: Andi Shyti
Sent: Monday, June 17, 2024 11:43 AM
To: intel-gfx ; dri-devel
Cc: Andi Shyti ; Cavitt, Jonathan
; De Marchi, Lucas
Subject: [PATCH v2 0/2] Sparse errors on the i915_gem_stolen
>
> Hi Jonathan,
>
> Commit 05da7d9f717b ("drm/i9
>
> -Original Message-
From: Vivi, Rodrigo
Sent: Friday, June 14, 2024 12:46 PM
To: Cavitt, Jonathan
Cc: Andi Shyti ; intel-gfx
; dri-devel ;
Harrison, John C
Subject: Re: [PATCH] drm/i915/gt/uc: Fix typo in comment
>
> On Fri, Jun 14, 2024 at 03:23:54PM +0000, Cavi
-Original Message-
From: Andi Shyti
Sent: Friday, June 14, 2024 8:22 AM
To: Andi Shyti
Cc: intel-gfx ; dri-devel
; Harrison, John C
; Cavitt, Jonathan
Subject: Re: [PATCH] drm/i915/gt/uc: Fix typo in comment
>
> I guess sparse and potential CI errors won't minimally relat
-Original Message-
From: Janusz Krzysztofik
Sent: Wednesday, May 29, 2024 4:37 AM
To: intel-...@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org; Jani Nikula ;
Joonas Lahtinen ; Vivi, Rodrigo
; Tvrtko Ursulin ; Andi Shyti
; Cavitt, Jonathan ;
Janusz Krzysztofik
Subject
-Original Message-
From: Das, Nirmoy
Sent: Thursday, May 16, 2024 8:14 AM
To: intel-...@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org; Das, Nirmoy ; Andi
Shyti ; Janusz Krzysztofik
; Cavitt, Jonathan
Subject: [PATCH] drm/i915/selftests: Set always_coherent to false when
-Original Message-
From: Intel-xe On Behalf Of Lucas De
Marchi
Sent: Wednesday, May 15, 2024 2:43 PM
To: intel...@lists.freedesktop.org
Cc: Tvrtko Ursulin ; Nerlige Ramappa, Umesh
; dri-devel@lists.freedesktop.org; De Marchi,
Lucas
Subject: [PATCH v4 6/8] drm/xe: Cache data about user-
-Original Message-
From: Das, Nirmoy
Sent: Tuesday, March 12, 2024 4:18 AM
To: intel-...@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org; Das, Nirmoy ; Andi
Shyti ; Janusz Krzysztofik
; Cavitt, Jonathan
Subject: [PATCH] drm/i915/selftests: Pick correct caching mode
76 matches
Mail list logo
