-----Original Message-----
From: Intel-gfx <intel-gfx-boun...@lists.freedesktop.org> On Behalf Of Andi
Shyti
Sent: Friday, August 2, 2024 1:39 AM
To: intel-gfx <intel-...@lists.freedesktop.org>; dri-devel
<dri-devel@lists.freedesktop.org>
Cc: Jann Horn <ja...@chromium.org>; Jani Nikula <jani.nik...@linux.intel.com>;
Joonas Lahtinen <joonas.lahti...@linux.intel.com>; Vivi, Rodrigo
<rodrigo.v...@intel.com>; Tvrtko Ursulin <tursu...@ursulin.net>; Jann Horn
<ja...@google.com>; Chris Wilson <chris.p.wil...@linux.intel.com>; Niemiec,
Krzysztof <krzysztof.niem...@intel.com>; Andi Shyti <andi.sh...@kernel.org>;
Auld, Matthew <matthew.a...@intel.com>; Andi Shyti <andi.sh...@linux.intel.com>
Subject: [PATCH 1/2] drm/i915/gem: Adjust vma offset for framebuffer mmap offset
>
> When mapping a framebuffer object, the virtual memory area (VMA)
> offset ('vm_pgoff') should be adjusted by the start of the
> 'vma_node' associated with the object. This ensures that the VMA
> offset is correctly aligned with the corresponding offset within
> the GGTT aperture.
>
> Increment vm_pgoff by the start of the vma_node with the offset=
> provided by the user.
>
> Suggested-by: Chris Wilson <chris.p.wil...@linux.intel.com>
> Signed-off-by: Andi Shyti <andi.sh...@linux.intel.com>
LGTM.
Reviewed-by: Jonathan Cavitt <jonathan.cav...@intel.com>
-Jonathan Cavitt
> ---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> index a2195e28b625..ce10dd259812 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> @@ -1084,6 +1084,8 @@ int i915_gem_fb_mmap(struct drm_i915_gem_object *obj,
> struct vm_area_struct *vma
> mmo = mmap_offset_attach(obj, mmap_type, NULL);
> if (IS_ERR(mmo))
> return PTR_ERR(mmo);
> +
> + vma->vm_pgoff += drm_vma_node_start(&mmo->vma_node);
> }
>
> /*
> --
> 2.45.2
>
>
