On Sun Aug 24, 2025 at 11:50 PM MDT, Dan Carpenter wrote:
> On Sun, Aug 24, 2025 at 12:54:41PM -0600, Brigham Campbell wrote:
>> Good catch, Dan! Thank you for the patch. I'll try to be mindful of this
>> kind of logic error in the future. Please let me know if you have
d of logic error in the future. Please let me know if you have other
suggestions.
Reviewed-by: Brigham Campbell
Regards,
Brigham
On Wed Aug 13, 2025 at 11:56 AM MDT, Markus Elfring wrote:
>> Replace usages of kfree() with kvfree() for pointers which were
>> allocated using kvmalloc(), as required by the kernel memory management
>> API.
>
> How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
> https://
0250813-rocket-free-fix-3ca6a759a290
Thanks!
Brigham Campbell
On Tue Aug 5, 2025 at 5:53 AM MDT, Giant Sand Fans wrote:
> On Tue, 5 Aug 2025 at 12:49, Dmitry Baryshkov
> wrote:
>> Fixes tag?
>Sorry, what do you mean?
Dmitry is looking for a tag in the body of your patch (much like your
"Signed-off-by" tag) which describes the commit which introduced the
On Sun Aug 3, 2025 at 9:33 AM MDT, Tomeu Vizoso wrote:
> thanks for the fixes. Will pick them up. Hope you don't mind if I
> change the subject of the first patch to something a bit more
> specific, such as:
>
> accel/rocket: Adapt to changes in drm/sched API
No, I don't mind at all. Go ahead and
e drm client_id in drm_sched_fence")
Signed-off-by: Brigham Campbell
---
drivers/accel/rocket/rocket_job.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/accel/rocket/rocket_job.c
b/drivers/accel/rocket/rocket_job.c
index
e731da15ebffca12e740
Fix sparse warning regarding an undeclared const rocket_pm_ops, which is
used in rocket_drv.c.
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202508030021.uwdr4p08-...@intel.com/
Signed-off-by: Brigham Campbell
---
drivers/accel/rocket/rocket_drv.h | 2 ++
1 file
: Brigham Campbell
---
Brigham Campbell (2):
accel/rocket: Fix Rockchip NPU compilation
accel/rocket: Fix undeclared const rocket_pm_ops
drivers/accel/rocket/rocket_drv.h | 2 ++
drivers/accel/rocket/rocket_job.c | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
---
base-commit
ned that this driver supports the Novatek NT35560 panel
controller.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-novatek-nt35560.c | 198 ++
1 file changed, 60 insertions(+), 138 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-
display controllers.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/drm_mipi_dsi.c | 37 ++
include/drm/drm_mipi_dsi.h | 35
2 files changed, 72 insertions(+)
diff --git a/drivers/gpu/drm
: 8152c2bfd780 ("drm/panel: Add driver for Sony ACX424AKP panel")
Reviewed-by: Douglas Anderson
Reviewed-by: Neil Armstrong
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-novatek-nt35560.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu
I write macros for sending
non-static MIPI messages.
- Minor formatting improvements.
Brigham Campbell (3):
drm/panel: novatek-nt35560: Fix invalid return value
drm: Add MIPI read_multi func and two write macros
drm/panel: novatek-nt35560: Clean up driver
drivers/gpu/drm/drm_mipi_dsi
On Wed Jul 30, 2025 at 9:56 AM MDT, Doug Anderson wrote:
>> +/**
>> + * mipi_dsi_dcs_write_var_seq_multi - transmit a DCS command with non-static
>> + * payload
>
> I should have been explicit, but the above "non-static" should also be
> "non-constant". ;-)
>
> I could probably fix that when applyi
ned that this driver supports the Novatek NT35560 panel
controller.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-novatek-nt35560.c | 198 ++
1 file changed, 60 insertions(+), 138 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-
controllers.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
---
Doug, you had suggested a slightly different shortlog for this patch. I
adjusted your suggestion to fit within the canonical recommended
shortlog length of 50 characters. I understand that the 50 character
limit
: 8152c2bfd780 ("drm/panel: Add driver for Sony ACX424AKP panel")
Reviewed-by: Douglas Anderson
Reviewed-by: Neil Armstrong
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-novatek-nt35560.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu
ct Fixes tag. The bug was introduced by an earlier commit.
- Minor formatting improvements.
Changes to v2:
- Separate bug fix into its own commit for backporting.
- Add var_seq_multi() variants of MIPI write macros for sending
non-static MIPI messages.
- Minor formatting improvements.
Brigham
On Tue Jul 29, 2025 at 3:34 PM MDT, Doug Anderson wrote:
>> +/**
>> + * mipi_dsi_generic_write_var_seq_multi - transmit non-static data using a
>> + * generic write packet
>
> nit: "non-constant", not "non-static"
>
> From the caller's point of view the difference is that the data is
> compile-time
On Tue Jul 29, 2025 at 3:33 PM MDT, Doug Anderson wrote:
>>
>> Fixes: 7835ed6a9e86 ("drm/panel-sony-acx424akp: Modernize backlight
>> handling")
>
> I think your Fixes tag is wrong, actually. I think it needs to be:
>
> Fixes: 8152c2bfd780 ("drm/panel: Add driver for Sony ACX424AKP panel")
Oh, go
Oops! My apologies for forgetting to add the following changelog to the
cover letter.
Changes to v2:
- Separate bug fix into its own commit for backporting
- Add var_seq_multi() variants of MIPI write macros for sending
non-static MIPI messages.
- Minor formatting improvements.
ned that this driver supports the Novatek NT35560 panel
controller.
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-novatek-nt35560.c | 198 ++
1 file changed, 60 insertions(+), 138 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35560.c
b/drivers
controllers.
Signed-off-by: Brigham Campbell
---
I looked into using __builtin_constant_p() to extend
mipi_dsi_{generic,dcs}_write_seq_multi() to accept both static and
non-static sequences of bytes and store them accordingly, it looked
promising at first, but I found no such solution ultimately
: 7835ed6a9e86 ("drm/panel-sony-acx424akp: Modernize backlight handling")
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-novatek-nt35560.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35560.c
b/drivers/gpu/drm/p
pi_dsi.h to allow
drivers to more conveniently construct MIPI payloads at runtime.
Clean up novatek-nt35560 driver to use "multi" variants of MIPI
functions which promote cleaner code.
Brigham Campbell (3):
drm/panel: novatek-nt35560: Fix invalid return value
drm: Add MIPI supp
On Fri Jul 25, 2025 at 3:17 PM MDT, Doug Anderson wrote:
> Hi,
>
> On Thu, Jul 24, 2025 at 1:23 PM Brigham Campbell
> wrote:
>>
>> Fix bug in nt35560_set_brightness() which causes the function to
>> erroneously report an error. mipi_dsi_dcs_write() returns eith
On Fri Jul 25, 2025 at 3:16 PM MDT, Doug Anderson wrote:
>> + dev_err(dev, "transferring dcs message %xh failed: %d\n",
>> cmd,
>
> Format code "%xh" is probably not exactly what you want. If the error
> code is 0x10 it will print 10h, which is not very standard. You
> probably copie
driver to use the "multi" variants of MIPI functions which
facilitate improved error handling and cleaner driver code.
Fixes: 7835ed6a9e86 ("drm/panel-sony-acx424akp: Modernize backlight handling")
Signed-off-by: Brigham Campbell
---
The usage of the u8 arr
Create mipi_dsi_dcs_read_multi(), which accepts a mipi_dsi_multi_context
struct for improved error handling and cleaner panel driver code.
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/drm_mipi_dsi.c | 37 ++
include/drm/drm_mipi_dsi.h | 2 ++
2 files
"failed to disable display backlight".
- Clean up novatek-nt35560 driver to use "multi" variants of MIPI
functions which promote cleaner code.
If there's a reason that mipi_dsi_dcs_read_multi doesn't exist, I'm
happy to drop it.
Brigham Campbell (2):
drm: Cre
On Tue Jul 22, 2025 at 10:20 AM MDT, Doug Anderson wrote:
> On Mon, Jul 21, 2025 at 6:53 PM Brigham Campbell
> wrote:
> add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-8754 (-8754)
> Function old new delta
> elish_csot_init_sequence.d
Update TODO item from drm documentation to contain more applicable
information regarding the removal of deprecated MIPI DSI functions and
no longer reference functions which have already been removed from the
kernel.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
Remove the deprecated mipi_dsi_generic_write_seq() and
mipi_dsi_generic_write_chatty() functions now that they are no longer
used.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/drm_mipi_dsi.c | 34 +++---
include/drm
eprecated MIPI functions.
Use the new mipi_dsi_dual macro to reduce code duplication.
Reviewed-by: Douglas Anderson
Reviewed-by: Diogo Ivo
Tested-by: Diogo Ivo
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 196 ++
1 file changed, 59 inserti
definition from
panel-novatek-nt36523.c to avoid the duplicate definition. Make novatek
driver pass mipi_dsi_context struct as a pointer.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/drm_mipi_dsi.c| 48 ++
drivers/gpu/drm/panel/panel-novatek-nt36523
hanges to v2:
- Remove all usages of deprecated MIPI functions from jdi-lpm102a188a
driver instead of just mipi_dsi_generic_write_seq().
- Update TODO item in drm documentation instead of removing it
entirely.
Brigham Campbell (4):
drm: Create mipi_dsi_dual* macros
drm/panel: jdi-lpm102a1
On Mon Jul 21, 2025 at 10:30 AM MDT, Doug Anderson wrote:
>> +void mpi_dsi_dual_generic_write_multi(struct mipi_dsi_device *dsi1,
>
> BUG: above should be "mipi", not "mpi"
>
>> + struct mipi_dsi_device *dsi2,
>> + struct mipi_
On Sat Jul 19, 2025 at 11:10 AM MDT, Diogo Ivo wrote:
>> nit: can just be this:
>>
>> struct mipi_dsi_multi_context dsi_ctx = {};
>
> I am not an expert here but I was under the impression that this is only
> valid with C23 while the kernel is written in C11. Is there something I
> am missing?
>
>
eprecated MIPI functions.
Use the new mipi_dsi_dual macro to reduce code duplication.
Reviewed-by: Douglas Anderson
Reviewed-by: Diogo Ivo
Tested-by: Diogo Ivo
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 196 ++
1 file changed, 59 inserti
Update TODO item from drm documentation to contain more applicable
information regarding the removal of deprecated MIPI DSI functions and
no longer reference functions which have already been removed from the
kernel.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
Remove the deprecated mipi_dsi_generic_write_seq() and
mipi_dsi_generic_write_chatty() functions now that they are no longer
used.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/drm_mipi_dsi.c | 34 +++---
include/drm
rom jdi-lpm102a188a
driver instead of just mipi_dsi_generic_write_seq().
- Update TODO item in drm documentation instead of removing it
entirely.
Brigham Campbell (4):
drm: Create mipi_dsi_dual* macros
drm/panel: jdi-lpm102a188a: Fix bug and clean up driver
drm: Remove unused MIPI write seq and chatt
Create mipi_dsi_dual, mipi_dsi_dual_dcs_write_seq_multi, and
mipi_dsi_dual_generic_write_seq_multi macros for panels which are driven
by two parallel serial interfaces. This allows for the reduction of code
duplication in drivers for these panels.
Signed-off-by: Brigham Campbell
On Fri Jul 18, 2025 at 10:10 AM MDT, Doug Anderson wrote:
>> +#define mipi_dsi_dual(_func, _dsi1, _dsi2, _ctx, ...) \
>> + _mipi_dsi_dual(_func, _dsi1, _dsi2, _ctx, ##__VA_ARGS__)
>> +
>> +#define _mipi_dsi_dual(_func, _dsi1, _dsi2, _ctx, ...) \
>> + do {
Woops. When I copied over the subject from the previous cover letter, I
accidentally overwrote v4 with v3. I'll issue a v5 if that's a problem.
My bad,
Brigham
Update TODO item from drm documentation to contain more applicable
information regarding the removal of deprecated MIPI DSI functions and
no longer reference functions which have already been removed from the
kernel.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
eprecated MIPI functions.
Use the new mipi_dsi_dual macro to reduce code duplication.
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 197 ++
1 file changed, 60 insertions(+), 137 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-jdi-lpm102a1
Remove the deprecated mipi_dsi_generic_write_seq() and
mipi_dsi_generic_write_chatty() functions now that they are no longer
used.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/drm_mipi_dsi.c | 34 +++---
include/drm
Create mipi_dsi_dual macro for panels which are driven by two parallel
serial interfaces. This allows for the reduction of code duplication in
drivers for these panels.
Signed-off-by: Brigham Campbell
---
include/drm/drm_mipi_dsi.h | 24
1 file changed, 24 insertions
generic_write_seq().
- Update TODO item in drm documentation instead of removing it
entirely.
Brigham Campbell (4):
drm: Create mipi_dsi_dual macro
drm/panel: jdi-lpm102a188a: Fix bug and clean up driver
drm: Remove unused MIPI write seq and chatty functions
drm: docs: Update task fro
Update TODO item from drm documentation to contain more applicable
information regarding the removal of deprecated MIPI DSI functions and
no longer reference functions which have already been removed from the
kernel.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
Remove the deprecated mipi_dsi_generic_write_seq() and
mipi_dsi_generic_write_chatty() functions now that they are no longer
used.
Reviewed-by: Douglas Anderson
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/drm_mipi_dsi.c | 34 +++---
include/drm
emove all usages of deprecated MIPI functions from jdi-lpm102a188a
driver instead of just mipi_dsi_generic_write_seq().
- Update TODO item in drm documentation instead of removing it
entirely.
Brigham Campbell (4):
drm: Create mipi_dsi_dual macro
drm/panel: jdi-lpm102a188a: Fix bug and c
eprecated MIPI functions.
Use the new mipi_dsi_dual macro to reduce code duplication.
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 187 ++
1 file changed, 55 insertions(+), 132 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-jdi-lpm102a1
Create mipi_dsi_dual macro for panels which are driven by two parallel
serial interfaces. This allows for the reduction of code duplication in
drivers for these panels.
Signed-off-by: Brigham Campbell
---
In case it's not obvious, the indirection between mipi_dsi_dual and
_mipi_dsi_du
On Mon Jul 14, 2025 at 3:46 PM MDT, Doug Anderson wrote:
> Hi,
>
> On Tue, Jul 8, 2025 at 12:39 AM Brigham Campbell
> wrote:
>>
>> Update jdi-lpm102a188a panel driver to use the "multi" variant of MIPI
>> functions in order to facilitate improved
Fix typo in Documentation/gpu/introduction.rst
Link:
https://lore.kernel.org/all/20250620180258.132160-1...@brighamcampbell.com/
Signed-off-by: Brigham Campbell
---
This patch has received no response as of June 20th. If it's
unacceptable for whatever reason, please let me know and I&#x
Update TODO item from drm documentation to contain more applicable
information regarding the removal of deprecated MIPI DSI functions and
no longer reference functions which have already been removed from the
kernel.
Signed-off-by: Brigham Campbell
---
Documentation/gpu/todo.rst | 22
Remove the deprecated mipi_dsi_generic_write_seq() and
mipi_dsi_generic_write_chatty() functions now that they are no longer
used.
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/drm_mipi_dsi.c | 34 +++---
include/drm/drm_mipi_dsi.h | 23
y, the struct wasn't designed to cater to the needs
of panels with multiple MIPI DSI interfaces. This panel is an oddity
which requires swapping the dsi pointer between MIPI function calls in
order to preserve the exact behavior implemented using the non-multi
variant of the macro.
Signed
.
Brigham Campbell (3):
drm/panel: jdi-lpm102a188a: Update deprecated MIPI function calls
Remove unused MIPI write seq and chatty functions
drm: docs: Update task from drm TODO list
Documentation/gpu/todo.rst| 26 +--
drivers/gpu/drm/drm_mipi_dsi.c| 34
Remove the deprecated mipi_dsi_generic_write_seq() macro and
mipi_dsi_generic_write_chatty() function now that they are no longer
used.
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/drm_mipi_dsi.c | 34 +++---
include/drm/drm_mipi_dsi.h | 23
This panel is an oddity
which requires swapping the dsi pointer between calls to
mipi_dsi_generic_write_seq_multi() in order to preserve the exact
behavior implemented using the non-multi variant of the macro.
Signed-off-by: Brigham Campbell
---
drivers/gpu/drm/panel/panel-jdi-lpm102a1
Remove TODO item from drm documentation to transition away from using
mipi_dsi_*_write_seq() macros now that the work is complete.
Signed-off-by: Brigham Campbell
---
Documentation/gpu/todo.rst | 18 --
1 file changed, 18 deletions(-)
diff --git a/Documentation/gpu/todo.rst b
arate MIPI DSI interfaces at once requires special treatment. Any
behavioral modification to the jdi lpm102a188a panel driver by this
series is unintentional.
Brigham Campbell (3):
Replace usage of deprecated MIPI function
Remove unused MIPI write seq and chatty functions
Remove completed tas
Replace scnprintf() with sysfs_emit_at() in drivers/gpu/drm/drm_sysfs.c.
Per kernel documentation, show() should only use sysfs_emit() or
sysfs_emit_at() when formatting the value to be returned to user space.
Signed-off-by: Brigham Campbell
---
I tested this patch with a device that outputs
Fix typo in Documentation/gpu/introduction.rst
Signed-off-by: Brigham Campbell
---
Documentation/gpu/introduction.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/gpu/introduction.rst
b/Documentation/gpu/introduction.rst
index 3cd0c8860b94..39b4c943fa00
67 matches
Mail list logo
