On Fri Jul 25, 2025 at 3:16 PM MDT, Doug Anderson wrote: >> + dev_err(dev, "transferring dcs message %xh failed: %d\n", >> cmd, > > Format code "%xh" is probably not exactly what you want. If the error > code is 0x10 it will print 10h, which is not very standard. You > probably copied it from the write routine which uses "%*ph". There the > "h" means something. See Documentation/core-api/printk-formats.rst. > Probably you want "%#x".
Ah yes, I had based this change off the "%*ph" format specifier and I had mistakenly assumed that the 'h' was a literal 'h'. I'll fix that in v2. > I'd probably also say "dcs read with cmd" rather than "transferring > dcs message". Yes, this sounds more accurate. I'll include this in v2 as well. Thanks for the review, Brigham
