Hi all,
On Mon, Aug 11, 2025 at 06:56:04AM -0400, Brian Masney wrote:
> The round_rate() clk ops is deprecated in the clk framework in favor
> of the determine_rate() clk ops, so let's go ahead and convert the
> drivers in the drm subsystem using the Coccinelle semantic patch
>
Hi Vinod,
On Wed, Aug 20, 2025 at 01:27:35PM -0400, Brian Masney wrote:
> On Wed, Aug 20, 2025 at 09:59:25PM +0530, Vinod Koul wrote:
> > On 10-08-25, 18:45, Brian Masney wrote:
> > > The round_rate() clk ops is deprecated, so migrate this driver from
> > > round_rate(
Hi Vinod,
On Wed, Aug 20, 2025 at 09:59:25PM +0530, Vinod Koul wrote:
> On 10-08-25, 18:45, Brian Masney wrote:
> > The round_rate() clk ops is deprecated, so migrate this driver from
> > round_rate() to determine_rate() using the Coccinelle semantic patch
> > on the cover
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Acked-by: Maxime Ripard
Signed-off-by: Brian Masney
---
drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c | 18
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Acked-by: Maxime Ripard
Signed-off-by: Brian Masney
---
drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c | 12 +++-
1
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Acked-by: Dmitry Baryshkov
Reviewed-by: Konrad Dybcio
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/hdmi
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Reviewed-by: Linus Walleij
Signed-off-by: Brian Masney
---
drivers/gpu/drm/mcde/mcde_clk_div.c | 13 -
1 file
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Acked-by: Raphael Gallais-Pou
Signed-off-by: Brian Masney
---
drivers/gpu/drm/stm/lvds.c | 12 +++-
1 file
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/imx/ipuv3/imx-tve.c | 17 ++---
1 file changed, 10 insertions
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Acked-by: Raphael Gallais-Pou
Signed-off-by: Brian Masney
---
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 14
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Reviewed-by: Linus Walleij
Signed-off-by: Brian Masney
---
drivers/gpu/drm/pl111/pl111_display.c | 13 -
1
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Acked-by: Dmitry Baryshkov
Reviewed-by: Konrad Dybcio
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/disp/mdp4
hat I used coccinelle 1.2 instead of 1.3 since the newer version
adds unnecessary braces as described in this post.
https://lore.kernel.org/cocci/67642477-5f3e-4b2a-914d-579a54f48...@intel.com/
Signed-off-by: Brian Masney
---
Brian Masney (9):
drm/imx/ipuv3/imx-tve: convert from round_rate()
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series. The change to use clamp_t() was
done manually.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series. The change to use clamp_t() was
done manually.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series. The change to use clamp_t() was
done manually.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series. The change to use clamp_t() was
done manually.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series. The change to use clamp_t() was
done manually.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series. The change to use clamp_t() was
done manually.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series. The change to use clamp_t() was
done manually.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/dsi/phy
elle 1.2 instead of 1.3 since the newer version
adds unnecessary braces as described in this post.
https://lore.kernel.org/cocci/67642477-5f3e-4b2a-914d-579a54f48...@intel.com/
Signed-off-by: Brian Masney
---
Brian Masney (7):
drm/msm/dsi_phy_10nm: convert from round_rate() to determine_rate()
drm/
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/ti/phy-j721e-wiz.c | 11 +++
1 file changed, 7 insertions(+), 4
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 14 --
1 file changed, 8
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 30 ++-
1 file
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c | 10 ++
1 file changed, 6
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c | 10 ++
1 file changed, 6
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 10 +-
1 file changed, 5 insertions
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/mediatek/phy-mtk-hdmi-mt8173.c | 16
1 file changed, 8
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/mediatek/phy-mtk-hdmi-mt2701.c | 8
1 file changed, 4 insertions
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 13 -
1 file changed, 8
used coccinelle 1.2 instead of 1.3 since the newer version
adds unnecessary braces as described in this post.
https://lore.kernel.org/cocci/67642477-5f3e-4b2a-914d-579a54f48...@intel.com/
Signed-off-by: Brian Masney
---
Brian Masney (9):
phy: freescale: phy-fsl-samsung-hdmi: convert from
On Fri, Jul 11, 2025 at 3:05 AM Maxime Ripard wrote:
> On Thu, Jul 10, 2025 at 01:43:10PM -0400, Brian Masney wrote:
> > -static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate,
> > - unsigned long *parent_rate)
On Thu, Jul 17, 2025 at 10:59 AM Alex Deucher wrote:
>
> On Wed, Jul 16, 2025 at 8:13 PM Brian Geffon wrote:
> >
> > On Wed, Jul 16, 2025 at 5:03 PM Alex Deucher wrote:
> > >
> > > On Wed, Jul 16, 2025 at 12:40 PM Brian Geffon wrote:
> > > &g
On Wed, Jul 16, 2025 at 5:03 PM Alex Deucher wrote:
>
> On Wed, Jul 16, 2025 at 12:40 PM Brian Geffon wrote:
> >
> > On Wed, Jul 16, 2025 at 12:33 PM Alex Deucher wrote:
> > >
> > > On Wed, Jul 16, 2025 at 12:18 PM Brian Geffon wrote:
> > > >
On Wed, Jul 16, 2025 at 12:33 PM Alex Deucher wrote:
>
> On Wed, Jul 16, 2025 at 12:18 PM Brian Geffon wrote:
> >
> > Commit 81d0bcf99009 ("drm/amdgpu: make display pinning more flexible (v2)")
> > allowed for newer ASICs to mix GTT and VRAM, this change als
lex Deucher
Cc: sta...@vger.kernel.org # 6.1+
Tested-by: Thadeu Lima de Souza Cascardo
Signed-off-by: Brian Geffon
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
b/driver
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c | 18 ++
1 file changed, 10
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/sun4i/sun4i_hdmi_ddc_clk.c | 12 +++-
1 file changed, 7 insertions
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/stm/lvds.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c | 12 +++-
1 file changed, 7 insertions
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 14 --
1 file changed, 8 insertions
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/pl111/pl111_display.c | 13 -
1 file changed, 8 insertions
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/disp/mdp4/mdp4_lvds_pll.c | 13 -
1 file changed, 8
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/mcde/mcde_clk_div.c | 13 -
1 file changed, 8 insertions(+), 5
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/imx/ipuv3/imx-tve.c | 17 ++---
1 file changed, 10 insertions
this post.
https://lore.kernel.org/cocci/67642477-5f3e-4b2a-914d-579a54f48...@intel.com/
Signed-off-by: Brian Masney
---
Brian Masney (9):
drm/imx/ipuv3/imx-tve: convert from round_rate() to determine_rate()
drm/mcde/mcde_clk_div: convert from round_rate() to determine_ra
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 19 +--
1 file changed, 9
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 19 +--
1 file changed, 9
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 18 +-
1 file changed, 9
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 22 +++---
1 file changed, 11
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 34 +
1 file
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 36 --
1 file
as described in this post.
https://lore.kernel.org/cocci/67642477-5f3e-4b2a-914d-579a54f48...@intel.com/
Signed-off-by: Brian Masney
---
Brian Masney (7):
drm/msm/dsi_phy_10nm: convert from round_rate() to determine_rate()
drm/msm/dsi_phy_14nm: convert from round_rate() to deter
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 18 +-
1 file changed, 9
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/mediatek/phy-mtk-hdmi-mt8173.c | 16
1 file changed, 8
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 30 ++-
1 file
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/mediatek/phy-mtk-hdmi-mt2701.c | 8
1 file changed, 4 insertions
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/ti/phy-j721e-wiz.c | 11 +++
1 file changed, 7 insertions(+), 4
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 21 +
1 file
this post.
https://lore.kernel.org/cocci/67642477-5f3e-4b2a-914d-579a54f48...@intel.com/
Signed-off-by: Brian Masney
---
Brian Masney (9):
phy: freescale: phy-fsl-samsung-hdmi: convert from round_rate() to
determine_rate()
phy: mediatek: phy-mtk-hdmi-mt2701: convert from
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c | 10 ++
1 file changed, 6
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 10 +-
1 file changed, 5 insertions
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c | 10 ++
1 file changed, 6
The round_rate() clk ops is deprecated, so migrate this driver from
round_rate() to determine_rate() using the Coccinelle semantic patch
on the cover letter of this series.
Signed-off-by: Brian Masney
---
drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 13 -
1 file changed, 8
t shmem_sg_free_table() to use a folio_batch")
Signed-off-by: Brian Geffon
Suggested-by: Tomasz Figa
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
b/drivers/gpu/drm/i915/
On Mon, Jan 27, 2025 at 1:47 PM Ville Syrjälä
wrote:
>
> On Thu, Jan 16, 2025 at 10:53:40AM -0500, Brian Geffon wrote:
> > When converting to folios the cleanup path of shmem_get_pages() was
> > missed. When a DMA remap fails and the max segment size is greater than
> > P
On Wed, Jan 22, 2025 at 10:07 PM Srinivas, Vidya
wrote:
>
> Hello Brian, Many thanks for the fix. I am adding my tested-by.
> Tested-by: Vidya Srinivas
Thanks for testing Vidya.
Can we get a maintainer to take a look?
>
>
> > -Original Message-
> > From:
rnel.org/lkml/20250116135636.410164-1-bgef...@google.com/
Fixes: 0b62af28f249 ("i915: convert shmem_sg_free_table() to use a folio_batch")
Signed-off-by: Brian Geffon
Suggested-by: Tomasz Figa
---
drivers/gpu/drm/i915/gem/i915_gem_object.h | 3 +--
drivers/gpu/drm/i915/gem
On Thu, Jan 16, 2025 at 9:38 AM Ville Syrjälä
wrote:
>
> On Thu, Jan 16, 2025 at 04:24:26PM +0200, Ville Syrjälä wrote:
> > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote:
> > > When converting to folios the cleanup path of shmem_get_pages() was
> > >
On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä
wrote:
>
> On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote:
> > When converting to folios the cleanup path of shmem_get_pages() was
> > missed. When a DMA remap fails and the max segment size is greater than
> > P
On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä
wrote:
>
> On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote:
> > When converting to folios the cleanup path of shmem_get_pages() was
> > missed. When a DMA remap fails and the max segment size is greater than
> > P
isn't handling compound pages correctly.
Link: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13487
Fixes: 0b62af28f249 ("i915: convert shmem_sg_free_table() to use a folio_batch")
Signed-off-by: Brian Geffon
Suggested-by: Tomasz Figa
---
drivers/gpu/drm/i915/gem/i
el raised. That
needs addressing.
On Thu, Dec 19, 2024 at 07:33:07PM +, Marek Olšák wrote:
> On Thu, Dec 19, 2024 at 5:32 AM Brian Starkey wrote:
>
> > On Wed, Dec 18, 2024 at 09:53:56PM +, Marek Olšák wrote:
>
> The pitch doesn't always describe the layout. In prac
On Wed, Dec 18, 2024 at 09:53:56PM +, Marek Olšák wrote:
> On Wed, Dec 18, 2024 at 5:32 AM Brian Starkey wrote:
>
> > On Wed, Dec 18, 2024 at 11:24:58AM +, Simona Vetter wrote:
> > >
> > > For that reason I think linear modifiers with explicit pitch/size
&g
t is a "special"
constraint (in that it's really a description of the buffer layout),
and that constraints in-general shouldn't be exposed via modifiers?
Cheers,
-Brian
On Tue, Dec 17, 2024 at 11:13:05AM +, Michel Dänzer wrote:
> On 2024-12-17 10:14, Brian Starkey wrote:
> > On Sun, Dec 15, 2024 at 03:53:14PM +, Marek Olšák wrote:
> >> The comment explains the problem with DRM_FORMAT_MOD_LINEAR.
> >>
> >> Signed-off-by:
y - it's a device
constraint. It feels out of place to overload modifiers with it.
I'm not saying we don't need a way to describe constraints to
allocators, but I question if modifiers the right mechanism to
communicate them?
Cheers,
-Brian
o prevent the issue, make the framebuffer_core driver to not register a
> platform device if the global struct screen_info data has been filled.
>
> Reported-by: Brian Norris
> Link:
> https://lore.kernel.org/all/ZuCG-DggNThuF4pj@b20ea791c01f/T/#ma7fb65acbc1a56042258adac910992bb225a2
rs should be switched to use PLATFORM_DEVID_AUTO? Or at least one
of them. Or they should use different base names.
I'm not really sure what the best option is (does anyone rely on or care
about the device naming?), and I don't actually use this driver. But
here's an untested dif
ngle frames for static-screen and testing purposes, and there wasn't
a consensus on how to make a streaming API, so we didn't do it.
> Note, in my humble opinion, it should be perfectly possible to setup
> writeback as a clone to the existing connector (if a clone mode is
> su
ew writeback every frame. It
drains out the last of the data during vblank, before starting on the
next frame. That doesn't help the "general case" though.
>
>If we already have devices where you can use writeback together with real
>outputs, then I guess that counts as an oopsie :-/
Well "works fine" fits into the "undefined behaviour" bucket, just as
well as "corrupts your fb" does :-)
-Brian
>
>Cheers, Sima
>--
>Daniel Vetter
>Software Engineer, Intel Corporation
>http://blog.ffwll.ch
Vishwanathapura
Cc: Matthew Brost
Cc: Thomas Hellström
Cc: Brian Welty
---
drivers/gpu/drm/xe/xe_gt_pagefault.c | 7 ++
drivers/gpu/drm/xe/xe_svm.c | 116 +++
drivers/gpu/drm/xe/xe_svm.h | 6 ++
drivers/gpu/drm/xe/xe_svm_range.c| 43 ++
4
When the power domains cannot be parsed, the message is incorrectly
logged as an info message. Let's change this to an error since an error
is returned.
Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains")
Signed-off-by: Brian Masney
---
drivers/video/f
-0700, Welty, Brian wrote:
Hi Christian / Thomas,
Wanted to ask if you have explored or thought about adding support in
TTM
such that a ttm_bo could have more than one underlying backing store
segment
(that is, to have a tree of ttm_resources)?
We already use something similar on amdgpu where
BO
Or is the thinking that workloads should use SVM/HMM instead of
GEM_CREATE if they want above benefits?
Is this something you are open to seeing an RFC series that starts
perhaps with just extending ttm_bo_validate() to see how this might
shape up?
-Brian
/a650_zap.mdt");
> +MODULE_FIRMWARE("qcom/a660_gmu.bin");
> +MODULE_FIRMWARE("qcom/a660_sqe.fw");
> +MODULE_FIRMWARE("qcom/a660_zap.mdt");
> +MODULE_FIRMWARE("qcom/leia_pfp_470.fw");
> +MODULE_FIRMWARE("qcom/leia_pm4_470.fw");
> +MODULE_FIRMWARE("qcom/yamato_pfp.fw");
> +MODULE_FIRMWARE("qcom/yamato_pm4.fw");
You should rebase this on top of the latest -next since the a690 needs
to be added as well.
Brian
PSR enabled state.
> + */
> + if (status == DP_PSR_SINK_ACTIVE_RFB) {
> + if ((reg == DP_PSR_SINK_ACTIVE_RFB) &&
> + ((store == DP_PSR_SINK_ACTIVE_SINK_SYNCED) ||
> + (store == DP_PSR_SINK_AC
> clk_prepare_enable(dp->clock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> - dp->reg_base = devm_ioremap_resource(&pdev->dev, res);
> + dp->reg_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
Rather than a NULL 3rd
f course.
v3:
* no update
v2:
* skip unnecessary lock/unlock
Fixes: 6c836d965bad ("drm/rockchip: Use the helpers for PSR")
Cc:
Link: https://lore.kernel.org/dri-devel/y5itf0+yniqa6...@sirena.org.uk/
Reported-by: "kernelci.org bot"
Signed-off-by: Brian Norris
---
drivers/gpu/
lf-refresh
* describe failing test case and relation to drm/rockchip patch better
Cc: # dependency for "drm/rockchip: vop: Leave
# vblank enabled in self-refresh"
Signed-off-by: Brian Norris
---
drivers/gpu/drm/drm_atomic_helper.c | 11 ++-
1 file chang
On Fri, Jan 6, 2023 at 5:23 PM Brian Norris wrote:
> v2:
> * add 'ret != 0' warning case for self-refresh
> * describe failing test case and relation to drm/rockchip patch better
Ugh, there's always something you remember right after you hit send: I
forgot to better sum
"drm/rockchip: Use the helpers for PSR")
Cc:
Link: https://lore.kernel.org/dri-devel/y5itf0+yniqa6...@sirena.org.uk/
Reported-by: "kernelci.org bot"
Signed-off-by: Brian Norris
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 8
1 file changed, 4 insertions
add 'ret != 0' warning case for self-refresh
* describe failing test case and relation to drm/rockchip patch better
Cc: # dependency for "drm/rockchip: vop: Leave
# vblank enabled in self-refresh"
Signed-off-by: Brian Norris
---
drivers/gpu/drm/dr
On Fri, Jan 06, 2023 at 12:42:54PM +0100, Michel Dänzer wrote:
> On 1/6/23 02:40, Brian Norris wrote:
> > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> > @@ -719,11 +719,11 @@ static void vop_crtc_atomic_disable(struc
On Fri, Jan 06, 2023 at 09:30:56PM +0100, Daniel Vetter wrote:
> On Fri, Jan 06, 2023 at 11:33:06AM -0800, Brian Norris wrote:
> > On Fri, Jan 06, 2023 at 07:17:53PM +0100, Daniel Vetter wrote:
> > > - check that drivers which use self_ref
y notice that this is "broken". I suppose
it would only be IGT tests that notice.
5. I fixed up various upstream PSR bugs are part of #3 [0],
along the way I unborked PSR enough that KernelCI finally caught the
bug. See my explanation in [1] for why the vblank bug was masked, and
On Fri, Jan 06, 2023 at 07:20:40PM +0100, Daniel Vetter wrote:
> On Fri, Jan 06, 2023 at 10:08:53AM -0800, Brian Norris wrote:
> > OK! Then that sounds like it at least ACKs my general idea for this
> > series. (Michel and I poked at a few ideas in the thread at [1] and
> > l
Hi Daniel,
On Fri, Jan 06, 2023 at 06:53:49PM +0100, Daniel Vetter wrote:
> On Thu, Jan 05, 2023 at 05:40:17PM -0800, Brian Norris wrote:
> > The self-refresh helper framework overloads "disable" to sometimes mean
> > "go into self-refresh mode," and this mo
On Thu, Jan 05, 2023 at 04:59:55PM -0800, Brian Norris wrote:
> On Wed, Jan 04, 2023 at 10:11:46AM +0100, Michel Dänzer wrote:
> > On 1/4/23 03:11, Brian Norris wrote:
> > > On Tue, Jan 03, 2023 at 07:04:00PM +0100, Michel Dänzer wrote:
> > >> On 12/21/22 23:02,
p on self refresh") as well.
We also need the previous patch ("drm/atomic: Allow vblank-enabled +
self-refresh "disable""), of course.
Fixes: 6c836d965bad ("drm/rockchip: Use the helpers for PSR")
Cc:
Link: https://lore.kernel.org/dri-devel/y5itf0+yniqa6...@sire
1 - 100 of 1006 matches
Mail list logo
