Re: (subset) [PATCH 00/10] drm/msm: add support for SAR2130P

2025-05-19 Thread Bjorn Andersson
; controller. > > Note, due to the technical limitations DP controller wasn't completely > evaluated. > > [...] Applied, thanks! [10/10] arm64: dts: qcom: sar2130p: add display nodes commit: 541d0b2f4dcd9514265b3a3f7f797525caabc1db Best regards, -- Bjorn Andersson

Re: (subset) [PATCH v4 00/16] drm/msm/hdmi: rework and fix the HPD even generation

2025-05-19 Thread Bjorn Andersson
> > [...] Applied, thanks! [16/16] ARM: dts: qcom: apq8064-ifc6410: drop HDMI HPD GPIO commit: b2c547cffe2f67e18a3a276905649cc95aa7f293 Best regards, -- Bjorn Andersson

Re: (subset) [PATCH v4 0/7] drm/msm/mdp4: rework LVDS/LCDC panel support

2025-05-14 Thread Bjorn Andersson
link LVDS clocks commit: d8dc4889afc92bd8757fcab607b734c684fce167 Best regards, -- Bjorn Andersson

Re: (subset) [PATCH v2 0/2] Add interconnect nodes and paths for MSM8953 SoC

2025-05-11 Thread Bjorn Andersson
ects commit: 6aeda4f2042711f99d63c5b7bf846c2bba711696 Best regards, -- Bjorn Andersson

Re: [PATCH RFT 01/14] soc: qcom: Add UBWC config provider

2025-05-11 Thread Bjorn Andersson
On Thu, May 08, 2025 at 08:12:33PM +0200, Konrad Dybcio wrote: > From: Konrad Dybcio > I'd prefer this to contain some of the problem description from the cover letter. Regards, Bjorn > Add a file that will serve as a single source of truth for UBWC > configuration data for various multimedia

Re: (subset) [PATCH 17/33] dt-bindings: nvmem: qfprom: Add the SM7150 compatible

2025-05-09 Thread Bjorn Andersson
On Wed, 23 Apr 2025 00:31:21 +0300, Danila Tikhonov wrote: > Document QFPROM compatible for SM7150. > > Applied, thanks! [31/33] dt-bindings: arm: qcom: Add SM7150 Google Pixel 4a commit: bd4718d97d308fdc20ddcd471444b3e398ce877d Best regards, -- Bjorn Andersson

Re: [PATCH 1/4] soc: qcom: Expose DDR data from SMEM

2025-04-09 Thread Bjorn Andersson
bdcb156c2b05f48dc5963203 > v5: > https://git.codelinaro.org/clo/la/abl/tianocore/edk2/-/blob/uefi.lnx.4.0.r31-rel/QcomModulePkg/Include/Protocol/DDRDetails.h?ref_type=heads > > Signed-off-by: Konrad Dybcio Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/soc/qcom

Re: (subset) [PATCH v2 0/4] Add and enable the panel

2025-03-16 Thread Bjorn Andersson
s-per-component (bpc) values of 10 and 12, since the Visionox > RM692E5 panel operates at 10 bpc. > > [...] Applied, thanks! [4/4] arm64: dts: qcom: sm7325-nothing-spacewar: Enable panel and GPU commit: 27b85be287f96180de2499b981eec83850df0da9 Best regards, -- Bjorn Andersson

Re: (subset) [PATCH 00/11] Various dt-bindings fixes

2025-03-14 Thread Bjorn Andersson
commit: 57aac7bd091cd7a1f43c852ce3703ce6c2433b21 [11/11] arm64: dts: qcom: x1e001de-devkit: Drop clock-names from PS8830 commit: 8cd4b0f6bc71b2bf4f5c3fb8ec2857192182cb23 Best regards, -- Bjorn Andersson

Re: [PATCH 03/11] dt-bindings: power: qcom,kpss-acc-v2: Add MSM8916 compatible

2025-03-13 Thread Bjorn Andersson
On Wed, Mar 12, 2025 at 04:12:14PM +0100, Krzysztof Kozlowski wrote: > On 06/03/2025 19:11, Konrad Dybcio wrote: > > From: Konrad Dybcio > > > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > > whom this binding document was created). Add a new compatible for it. > > > >

Re: [PATCH] MAINTAINERS: Update my email address

2025-02-20 Thread Bjorn Andersson
On Wed, Feb 19, 2025 at 02:41:12PM -0700, Jeff Hugo wrote: > Qualcomm is migrating away from quicinc.com email addresses towards ones > with *.qualcomm.com. > > Signed-off-by: Jeff Hugo Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > .mailmap| 3 ++- > MAINTAIN

Re: [PATCH RESEND v2 3/4] arm64: dts: qcom: qcs615: Add gpu and gmu nodes

2025-01-08 Thread Bjorn Andersson
On Fri, Dec 13, 2024 at 05:01:05PM +0530, Akhil P Oommen wrote: > From: Jie Zhang > > Add gpu and gmu nodes for qcs615 chipset. > Please resubmit this in a series together with the gpucc patch. Regards, Bjorn > Signed-off-by: Jie Zhang > Signed-off-by: Akhil P Oommen > Reviewed-by: Dmitry B

Re: [PATCH v4 4/4] drm/msm/dp: Add support for LTTPR handling

2025-01-08 Thread Bjorn Andersson
On Wed, Jan 08, 2025 at 04:31:46PM +0200, Abel Vesa wrote: > Link Training Tunable PHY Repeaters (LTTPRs) are defined in DisplayPort > 1.4a specification. As the name suggests, these PHY repeaters are > capable of adjusting their output for link training purposes. > > According to the DisplayPort

Re: [PATCH v4 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2025-01-08 Thread Bjorn Andersson
On Wed, Jan 08, 2025 at 04:31:43PM +0200, Abel Vesa wrote: > According to the DisplayPort standard, LTTPRs have two operating > modes: > - non-transparent - it replies to DPCD LTTPR field specific AUX >requests, while passes through all other AUX requests > - transparent - it passes through a

Re: [PATCH 00/45] drm/msm/dp: Add MST support for MSM chipsets

2025-01-06 Thread Bjorn Andersson
ark > To: Dmitry Baryshkov > To: Sean Paul > To: Marijn Suijten > To: David Airlie > To: Simona Vetter > To: Stephen Boyd > To: Chandan Uddaraju > To: Guenter Roeck > To: Kuogee Hsieh > To: Bjorn Andersson > To: Konrad Dybcio > To: Rob Herring > To: Kr

Re: [PATCH 03/45] drm/msm/dp: fix the intf_type of MST interfaces

2025-01-06 Thread Bjorn Andersson
On Thu, Dec 05, 2024 at 08:31:34PM -0800, Abhinav Kumar wrote: > Interface type of MST interfaces is currently INTF_NONE. > Fix this to INTF_DP. > Wouldn't it make sense to introduce this later in the series, once the implementation would actually handle this case? Or could/should we have left th

Re: [PATCH 44/45] arm64: dts: qcom: add mst support for pixel stream clk for DP0

2025-01-06 Thread Bjorn Andersson
On Thu, Dec 05, 2024 at 08:32:15PM -0800, Abhinav Kumar wrote: > From: Yongxing Mou > I'd expect "sa8775p" in the subject prefix. > Populate the pixel clock for stream 1 for DP0 for sa8775p DP controller. Please write your commit messages in the style expressed in https://docs.kernel.org/proce

Re: (subset) [PATCH v2 0/4] drm/msm/adreno: Add A615 GPU for SDM670 and Pixel 3a

2024-12-26 Thread Bjorn Andersson
MU by default (3/4) > > [...] Applied, thanks! [3/4] arm64: dts: qcom: sdm670: add gpu commit: cd89483a1327c0317a655cca1daf9521c7ec7529 [4/4] arm64: dts: qcom: sdm670-google-sargo: enable gpu commit: fbf7cfa3ea986e5bf426748aa8afa386df61456f Best regards, -- Bjorn Andersson

Re: (subset) [PATCH v6 0/7] drm/msm: adreno: add support for DDR bandwidth scaling via GMU

2024-12-26 Thread Bjorn Andersson
319d [7/7] arm64: qcom: dts: sm8650: add interconnect and opp-peak-kBps for GPU commit: 63c21d61b46197b6295e12dbf29adff29c18ae2c Best regards, -- Bjorn Andersson

Re: [PATCH v4 0/9] Add display support for QCS615 platform

2024-12-25 Thread Bjorn Andersson
On Tue, Dec 10, 2024 at 02:53:51PM +0800, Fange Zhang wrote: > This series aims to enable display on the QCS615 platform > > 1.Add MDSS & DPU support for QCS615 > 2.Add DSI support for QCS615 > > QCS615 platform supports DisplayPort, and this feature will be added in a > future patch > > Only d

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Bjorn Andersson
On Tue, Dec 10, 2024 at 02:22:27AM +0530, Akhil P Oommen wrote: > On 12/10/2024 1:24 AM, Rob Clark wrote: > > On Mon, Dec 9, 2024 at 12:20 AM Akhil P Oommen > > wrote: > >> > >> When kernel is booted in EL2, SECVID registers are accessible to the > >> KMD. So we can use that to switch GPU's secur

Re: [PATCH v2 2/2] drm/msm/adreno: Setup SMMU aparture for per-process page table

2024-11-19 Thread Bjorn Andersson
On Tue, Nov 12, 2024 at 3:15 PM Akhil P Oommen wrote: > > On 11/11/2024 8:38 PM, Rob Clark wrote: > > On Sun, Nov 10, 2024 at 9:31 AM Bjorn Andersson > > wrote: > >> > >> Support for per-process page tables requires the SMMU aparture to be > >> setu

Re: [PATCH v2 RESEND 1/3] dmaengine: qcom: gpi: Add GPI Block event interrupt support

2024-11-11 Thread Bjorn Andersson
On Mon, Nov 11, 2024 at 07:32:42PM +0530, Jyothi Kumar Seerapu wrote: > GSI hardware generates an interrupt for each transfer completion. > For multiple messages within a single transfer, this results > in receiving N interrupts for N messages, which can introduce > significant software interrupt l

Re: [PATCH v2 RESEND 3/3] i2c: i2c-qcom-geni: Add Block event interrupt support

2024-11-11 Thread Bjorn Andersson
On Mon, Nov 11, 2024 at 07:32:44PM +0530, Jyothi Kumar Seerapu wrote: > The I2C driver gets an interrupt upon transfer completion. > For multiple messages in a single transfer, N interrupts will be > received for N messages, leading to significant software interrupt > latency. To mitigate this late

Re: [PATCH v2 RESEND 2/3] i2c: qcom_geni: Update compile dependenices for qcom geni

2024-11-11 Thread Bjorn Andersson
On Mon, Nov 11, 2024 at 07:32:43PM +0530, Jyothi Kumar Seerapu wrote: > I2C_QCOM_GENI is having compile dependencies on QCOM_GPI_DMA and > so update I2C_QCOM_GENI to depends on QCOM_GPI_DMA. > Given that this is a separate patch, your wording can only be interpreted as this being an existing prob

Re: [PATCH v2 0/2] drm/msm/adreno: Setup SMMU aparture

2024-11-11 Thread Bjorn Andersson
On Sun, 10 Nov 2024 09:33:39 -0800, Bjorn Andersson wrote: > Support for per-page tables requires the SMMU aparture to be setup, on > some targets this is done statically in firmware, on others it's > expected to be requested in runtime by the driver, through a SCM call. > >

[PATCH v2 1/2] firmware: qcom: scm: Introduce CP_SMMU_APERTURE_ID

2024-11-10 Thread Bjorn Andersson
er to avoid "CP | AHB bus error"-errors from the GPU. Introduce a function to allow the msm driver to invoke this call. Signed-off-by: Bjorn Andersson --- drivers/firmware/qcom/qcom_scm.c | 26 ++ drivers/firmware/qcom/qcom_scm.h | 1 + include/linu

[PATCH v2 0/2] drm/msm/adreno: Setup SMMU aparture

2024-11-10 Thread Bjorn Andersson
forms, but only with Qualcomm presence in EL2. I did receive Tested-by from Konrad and Jessica, not picking these up, as I change the firmware call pattern in this version by introducing a "is_available" check. Signed-off-by: Bjorn Andersson --- Changes in v2: - Added a check to see if

[PATCH v2 2/2] drm/msm/adreno: Setup SMMU aparture for per-process page table

2024-11-10 Thread Bjorn Andersson
on is expected to be done dynamically is the QCS6490 rb3gen2. The downstream driver does this unconditioanlly on any A6xx and newer, so follow suite and make the call. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 11 +++ 1 file changed, 11 insertions(+)

Re: [PATCH v2] accel/qaic: Add crashdump to Sahara

2024-10-21 Thread Bjorn Andersson
les for different parts of the dump. > Structure these into a single buffer that userspace can parse and > extract the original files from. > > Reviewed-by: Carl Vanderlip > Signed-off-by: Jeffrey Hugo Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH v1 2/5] arm64: dts: qcom: Add support for configuring channel TRE size

2024-10-16 Thread Bjorn Andersson
On Tue, Oct 15, 2024 at 03:33:00PM GMT, Krzysztof Kozlowski wrote: > On 15/10/2024 14:07, Jyothi Kumar Seerapu wrote: > > When high performance with multiple i2c messages in a single transfer > > is required, employ Block Event Interrupt (BEI) to trigger interrupts > > after specific messages trans

Re: [PATCH] accel/qaic: Add crashdump to Sahara

2024-10-15 Thread Bjorn Andersson
On Tue, Oct 15, 2024 at 12:34:29PM -0600, Jeffrey Hugo wrote: > On 10/14/2024 3:52 PM, Bjorn Andersson wrote: > > On Wed, Sep 18, 2024 at 09:52:54AM -0600, Jeffrey Hugo wrote: [..] > > > struct sahara_context { > > > struct sahara_packet

Re: [PATCH] accel/qaic: Add crashdump to Sahara

2024-10-14 Thread Bjorn Andersson
On Wed, Sep 18, 2024 at 09:52:54AM -0600, Jeffrey Hugo wrote: > The Sahara protocol has a crashdump functionality. In the hello > exchange, the device can advertise it has a memory dump available for > the host to collect. Instead of the device making requests of the host, > the host requests data

Re: (subset) [PATCH v7 0/6] HDMI TX support in msm8998

2024-10-05 Thread Bjorn Andersson
es for msm8998 commit: 2150c87db80cf7eed3939f32cbb18393055c58ce Best regards, -- Bjorn Andersson

Re: (subset) [PATCH 00/35] Reorganize kerneldoc parameter names

2024-10-05 Thread Bjorn Andersson
> @@ > > [...] Applied, thanks! [24/35] soc: qcom: qmi: Reorganize kerneldoc parameter names commit: eea73fa08e69fec9cdc915592022bec6a9ac8ad7 Best regards, -- Bjorn Andersson

[PATCH RFT 2/2] drm/msm/adreno: Setup SMMU aparture for per-process page table

2024-10-03 Thread Bjorn Andersson
on is expected to be done dynamically is the QCS6490 rb3gen2. The downstream driver does this unconditioanlly on any A6xx and newer, so follow suite and make the call. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 ++ 1 file changed, 10 insertions(+)

[PATCH RFT 1/2] firmware: qcom: scm: Introduce CP_SMMU_APERTURE_ID

2024-10-03 Thread Bjorn Andersson
er to avoid "CP | AHB bus error"-errors from the GPU. Introduce a function to allow the msm driver to invoke this call. Signed-off-by: Bjorn Andersson --- drivers/firmware/qcom/qcom_scm.c | 19 +++ drivers/firmware/qcom/qcom_scm.h | 1 + include/linu

[PATCH RFT 0/2] drm/msm/adreno: Setup SMMU aparture

2024-10-03 Thread Bjorn Andersson
forms, but only with Qualcomm presence in EL2. Signed-off-by: Bjorn Andersson --- Bjorn Andersson (2): firmware: qcom: scm: Introduce CP_SMMU_APERTURE_ID drm/msm/adreno: Setup SMMU aparture for per-process page table drivers/firmware/qcom/qcom_scm.c| 19 +++ dr

Re: [PATCH v2 1/5] dt-bindings: display/msm: Document MDSS on SA8775P

2024-09-26 Thread Bjorn Andersson
On Thu, Sep 26, 2024 at 04:31:33PM +0530, Mahadevan wrote: > Document the MDSS hardware found on the Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan > --- > > [v2] > - Use fake DISPCC nodes to avoid clock dependencies in dt-bindings. [Dmitry] > - Update bindings by fixing dt_binding_chec

Re: [PATCH v2 0/5] Display enablement changes for Qualcomm SA8775P platform

2024-09-26 Thread Bjorn Andersson
On Thu, Sep 26, 2024 at 04:55:02PM GMT, Mahadevan P wrote: > Sorry, Please ignore this thread/coverletter > go/upstream and adopt b4, please.

Re: [PATCH 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-13 Thread Bjorn Andersson
On Thu, Sep 12, 2024 at 03:34:05PM +0530, Soutrik Mukhopadhyay wrote: > > On 9/12/2024 1:32 AM, Bjorn Andersson wrote: > > On Wed, Sep 11, 2024 at 03:38:13PM +0530, Soutrik Mukhopadhyay wrote: > > > The Qualcomm SA8775P platform comes with a DisplayPort controller > &

Re: [PATCH 2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings

2024-09-11 Thread Bjorn Andersson
On Wed, Sep 11, 2024 at 03:38:10PM +0530, Soutrik Mukhopadhyay wrote: > In order to support different HW versions, introduce aux_cfg array > to move v4 specific aux configuration settings. > > Signed-off-by: Soutrik Mukhopadhyay > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 34 +-

Re: [PATCH 5/5] drm/msm/dp: Add DisplayPort controller for SA8775P

2024-09-11 Thread Bjorn Andersson
On Wed, Sep 11, 2024 at 03:38:13PM +0530, Soutrik Mukhopadhyay wrote: > The Qualcomm SA8775P platform comes with a DisplayPort controller > with a different base offset than the previous SoCs, > add support for this in the DisplayPort driver. > > Signed-off-by: Soutrik Mukhopadhyay > --- > drive

Re: (subset) [PATCH 1/2] dt-bindings: misc: qcom, fastrpc: document new domain ID

2024-08-20 Thread Bjorn Andersson
astrpc label commit: b45af698d5114f9b666c7d8b58a9111d0526d7f7 Best regards, -- Bjorn Andersson

Re: (subset) [PATCH 00/11] arm64: qcom: set of fixes for SM8350 platform

2024-08-15 Thread Bjorn Andersson
dts: qcom: sm8350: add refgen regulator commit: 08822cf3de00f1b9edb01b995d926595e48a54eb Best regards, -- Bjorn Andersson

Re: (subset) [PATCH 00/11] arm64: qcom: set of fixes for SM8350 platform

2024-08-15 Thread Bjorn Andersson
t regards, -- Bjorn Andersson

Re: (subset) [PATCH v4 0/6] arm64: qcom: sa8775p: enable remoteprocs - ADSP, CDSP and GPDSP

2024-08-15 Thread Bjorn Andersson
On Mon, 05 Aug 2024 19:08:01 +0200, Bartosz Golaszewski wrote: > Add DT bindings, relevant DT defines, DTS nodes and driver changes > required to enable the remoteprocs on sa8775p. > > To: Bjorn Andersson > To: Mathieu Poirier > To: Rob Herring > To: Krzysztof Kozlowsk

Re: (subset) [PATCH v4 0/6] arm64: qcom: sa8775p: enable remoteprocs - ADSP, CDSP and GPDSP

2024-08-15 Thread Bjorn Andersson
On Mon, 05 Aug 2024 19:08:01 +0200, Bartosz Golaszewski wrote: > Add DT bindings, relevant DT defines, DTS nodes and driver changes > required to enable the remoteprocs on sa8775p. > > To: Bjorn Andersson > To: Mathieu Poirier > To: Rob Herring > To: Krzysztof Kozlowsk

Re: (subset) [PATCH 0/3] Update Konrad Dybcio's email addresses

2024-07-31 Thread Bjorn Andersson
Dybcio's email address commit: fce6a1eefb2a1db706fa17ca21e3e7107811d2e8 Best regards, -- Bjorn Andersson

Re: [PATCH v2] drm/msm/dp: enable widebus on all relevant chipsets

2024-07-30 Thread Bjorn Andersson
On Tue, Jul 30, 2024 at 11:58:19PM +0300, Dmitry Baryshkov wrote: > Hi Abhinav, > > On Tue, 30 Jul 2024 at 22:50, Abhinav Kumar wrote: > > > > Hardware document indicates that widebus is recommended on DP on all > > MDSS chipsets starting version 5.x.x and above. > > > > Follow the guideline and

Re: (subset) [PATCH v2 0/4] drm/panel: atna33xc20: Fix the Samsung ATNA45AF01 panel

2024-07-28 Thread Bjorn Andersson
_ATNA33XC20 commit: 10f98bb9d98137b544b00abb4f9df45e9be7878d Best regards, -- Bjorn Andersson

Re: [PATCH 1/2] drivers: drm/msm/a6xx_catalog: Add A642L speedbin (0x81)

2024-07-28 Thread Bjorn Andersson
On Mon, Jul 22, 2024 at 09:43:13PM GMT, Danila Tikhonov wrote: > From: Eugene Lepshy > Please make sure the subject prefix matches other changes in the same driver/files. Regards, Bjorn > According to downstream, A642L's speedbin is 129 and uses 4 as index > > Signed-off-by: Eugene Lepshy >

Re: (subset) [PATCH v2 0/5] Support for Adreno X1-85 GPU

2024-07-02 Thread Bjorn Andersson
emories and double the number of data channels to improve > bandwidth to DDR. > > [...] Applied, thanks! [5/5] arm64: dts: qcom: x1e80100: Add gpu support commit: 721e38301b79a6ee8375cb0ebd586699a7f353e3 Best regards, -- Bjorn Andersson

Re: [PATCH v3] misc: fastrpc: Increase max user PD initmem size

2024-07-01 Thread Bjorn Andersson
On Mon, Jul 01, 2024 at 05:22:37PM +0530, Ekansh Gupta wrote: > For user PD initialization, initmem is allocated and sent to DSP for > initial memory requirements like shell loading. This size is passed > by user space and is checked against a max size. Why does fastrpc_init_create_process() alloc

Re: [PATCH 7/7] arm64: dts: qcom: add OnePlus 8T (kebab)

2024-06-25 Thread Bjorn Andersson
On Mon, Jun 24, 2024 at 03:30:31AM GMT, Caleb Connolly wrote: > Initial support for USB, UFS, touchscreen, panel, wifi, and bluetooth. > Nice. > diff --git a/arch/arm64/boot/dts/qcom/sm8250-oneplus-common.dtsi > b/arch/arm64/boot/dts/qcom/sm8250-oneplus-common.dtsi [..] > + vph_pwr: vph-pwr

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Bjorn Andersson
On Sun, Jun 23, 2024 at 08:46:30PM GMT, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 02:53:17PM +0200, Krzysztof Kozlowski wrote: > > On 23/06/2024 14:28, Akhil P Oommen wrote: > > > On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: > > >> On 23/06/2024 13:06, Akhil P Oommen w

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-23 Thread Bjorn Andersson
On Fri, Jun 21, 2024 at 05:52:32PM GMT, Daniel Vetter wrote: > On Fri, Jun 21, 2024 at 09:40:09AM -0600, Jeffrey Hugo wrote: > > On 6/21/2024 5:19 AM, Dmitry Baryshkov wrote: > > > On Fri, 21 Jun 2024 at 09:19, Bjorn Andersson > > > wrote: > > > > > &g

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-20 Thread Bjorn Andersson
On Wed, Jun 12, 2024 at 09:28:39PM GMT, Dmitry Baryshkov wrote: > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: > > Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > > to be added for PD notifications and other missing features. Adding > > and maintaining new fil

Re: (subset) [PATCH v2 0/7] Add SMEM-based speedbin matching

2024-06-20 Thread Bjorn Andersson
a83 [2/7] soc: qcom: smem: Add a feature code getter commit: 81bbb2b891174da9301fc0d4fe9622bd4cb6a995 Best regards, -- Bjorn Andersson

Re: [PATCH v2 2/7] soc: qcom: smem: Add a feature code getter

2024-05-28 Thread Bjorn Andersson
On Wed, Apr 17, 2024 at 10:02:54PM GMT, Konrad Dybcio wrote: [..] > diff --git a/include/linux/soc/qcom/socinfo.h > b/include/linux/soc/qcom/socinfo.h > index 10e0a4c287f4..52439f48428f 100644 > --- a/include/linux/soc/qcom/socinfo.h > +++ b/include/linux/soc/qcom/socinfo.h > @@ -3,6 +3,8 @@ > #i

Re: (subset) [PATCH 0/4] Various fixes for the lm3630a backlight driver

2024-05-27 Thread Bjorn Andersson
> (kernel v6.5). > > backlight: lm3630a: Turn off both led strings when display is blank > > [...] Applied, thanks! [4/4] ARM: dts: qcom: msm8974-hammerhead: Hook up backlight commit: e23dfb4ee30a120a947abb94a718ccc1eb5f87ff Best regards, -- Bjorn Andersson

Re: (subset) [PATCH 0/8] MSM8976 MDSS/GPU/WCNSS support

2024-05-27 Thread Bjorn Andersson
: qcom: msm8976: Declare and wire SDC pins > arm64: dts: qcom: msm8976: Add WCNSS node > > [...] Applied, thanks! [1/8] arm64: dts: qcom: msm8976: Add IOMMU nodes commit: 418c2ffd7df9bfc25c21172bd881b78d7569fb4d Best regards, -- Bjorn Andersson

Re: [PATCH] drm/msm/adreno: Check for zap node availability

2024-05-19 Thread Bjorn Andersson
(!of_device_is_available(np)) { would cover both cases and be slightly cleaner imho... But this looks reasonable either way. Reviewed-by: Bjorn Andersson Regards, Bjorn > zap_available = false; > return -ENODEV; > } > -- > 2.45.1 >

Re: (subset) [PATCH v2 0/3] DisplayPort support for SM6350/SM7225

2024-04-21 Thread Bjorn Andersson
series (mostly just wiring up TCPM and the SBU > mux). > > [...] Applied, thanks! [3/3] arm64: dts: qcom: sm6350: Add DisplayPort controller commit: 62f87a3cac4e70fa916914a359d3f045a5ad8b9b Best regards, -- Bjorn Andersson

Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-11 Thread Bjorn Andersson
On Thu, Apr 11, 2024 at 04:31:41AM +0300, Dmitry Baryshkov wrote: > On Wed, Apr 10, 2024 at 11:52:52PM +0200, Konrad Dybcio wrote: [..] > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > index e4275d3ad581..5a5dc3faa971 100644 > > --- a/drivers/g

Re: [PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

2024-04-09 Thread Bjorn Andersson
On Mon, Apr 08, 2024 at 02:31:45PM -0700, Abhinav Kumar wrote: > On 3/28/2024 7:40 AM, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > The dp_audio read and write operations uses members in struct dp_catalog > > for passing arguments and return va

Re: [PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters

2024-04-09 Thread Bjorn Andersson
On Fri, Apr 05, 2024 at 10:41:30AM +0200, Konrad Dybcio wrote: > Introduce getters for SoC product and feature codes and export them. > Thought I commented on this already, but I don't see my reply... Can you please elaborate on what this stuff is, such that we have a track record in the history

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Bjorn Andersson
On Tue, Apr 09, 2024 at 01:07:57AM +0300, Dmitry Baryshkov wrote: > On Tue, 9 Apr 2024 at 00:23, Abhinav Kumar wrote: > > On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote: > > > On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar > > > wrote: > > >> On 4/7/2024 11:48 AM

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Bjorn Andersson
On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote: > > > On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > > On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: > > > From: Kuogee Hsieh > > [..] > > > diff --git a/drivers/gpu/drm/msm/d

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-07 Thread Bjorn Andersson
On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: > From: Kuogee Hsieh [..] > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index d80f89581760..bfb6dfff27e8 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/

[PATCH v2] drm/msm/dp: Remove now unused connector_type from desc

2024-04-05 Thread Bjorn Andersson
Now that the connector_type is dynamically determined, the connector_type of the struct msm_dp_desc is unused. Clean it up. Remaining duplicate entries are squashed. Signed-off-by: Bjorn Andersson --- This cleans up after, and hence depends on, https://lore.kernel.org/all/20240324-x1e80100

Re: (subset) [PATCH v3 0/4] arm64: dts: fix several display-related schema warnings

2024-04-04 Thread Bjorn Andersson
ls commit: 7fb5680b589d5eae64ada1d917b6ff2dab82f5ae [3/4] arm64: dts: qcom: sc8180x: Drop flags for mdss irqs commit: 580701ec27f61e0996dd5fcd23b091b6bf6933e3 [4/4] arm64: dts: qcom: sc8180x: add dp_p1 register blocks to DP nodes commit: 1106ea2266d11ebd97c3493a0c36a45272bfb67a Best reg

Re: [PATCH] drm/msm/dp: Remove now unused connector_type from desc

2024-03-29 Thread Bjorn Andersson
On Fri, Mar 29, 2024 at 07:23:07AM +0200, Dmitry Baryshkov wrote: > On Fri, 29 Mar 2024 at 06:02, Bjorn Andersson > wrote: > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > > b/drivers/gpu/drm/msm/dp/dp_display.c [..] > > static const struct msm_dp_desc sc8280xp_e

[PATCH] drm/msm/dp: Remove now unused connector_type from desc

2024-03-28 Thread Bjorn Andersson
Now that the connector_type is dynamically determined, the connector_type of the struct msm_dp_desc is unused. Clean it up. Signed-off-by: Bjorn Andersson --- This cleans up after, and hence depends on, https://lore.kernel.org/all/20240324-x1e80100-display-refactor-connector-v4-1-e0ebaea66

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Bjorn Andersson
On Thu, Mar 28, 2024 at 02:21:14PM -0700, Abhinav Kumar wrote: > > > On 3/28/2024 1:58 PM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2024-03-28 13:24:34) > > > + Johan and Bjorn for FYI > > > > > > On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: > > > > For internal HPD case, hpd_event_thread is

[PATCH v2 3/6] drm/msm/dp: Remove unused defines and members

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson Throughout the Qualcomm Displayport driver a number of defines and struct members has become unused, but lingers in the code. Remove these. Reviewed-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_audio.c | 5 - drivers/gpu/drm

[PATCH v2 2/6] drm/msm/dp: Removed fixed nvid "support"

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The "desc" member of struct dp_panel is zero-initialized during allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid() never returning true. This returned boolean value is passed around but never acted upon. Perform constant propagation and remove

[PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The dp_audio read and write operations uses members in struct dp_catalog for passing arguments and return values. This adds unnecessary complexity to the implementation, as it turns out after detangling the logic that no state is actually held in these variables. Clean

[PATCH v2 4/6] drm/msm/dp: Use function arguments for aux writes

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The dp_aux write operations takes the data to be operated on through a member of struct dp_catalog, rather than as an argument to the function. No state is maintained other than across the calling of the functions, so replace this member with a function argument. Reviewed

[PATCH v2 5/6] drm/msm/dp: Use function arguments for timing configuration

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from the calling function through members of struct dp_catalog. No state is maintained other than across this call, so switch to function arguments to clean up the code. Reviewed-by: Dmitry Baryshkov

[PATCH v2 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The members of struct dp_debug are no longer used, so the only purpose of this struct is as a type of the return value of dp_debug_get(), to signal success/error. Drop the struct in favor of signalling the result of initialization using an int, then merge dp_debug_get

[PATCH v2 0/6] drm/msm/dp: Spring cleaning

2024-03-28 Thread Bjorn Andersson
Spring is in the air, clean out some dust that has accumulated in the Qualcomm DP driver. Signed-off-by: Bjorn Andersson --- Changes in v2: - Merge dp_debug_get() and dp_debug_init() - Link to v1: https://lore.kernel.org/r/20240326-msm-dp-cleanup-v1-0-e775556ec...@quicinc.com --- Bjorn

Re: [PATCH v4 2/2] drm/msm/dp: Add support for the X1E80100

2024-03-26 Thread Bjorn Andersson
mitry Baryshkov > Signed-off-by: Abel Vesa Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/msm/dp/dp_display.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c >

Re: [PATCH v4 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-26 Thread Bjorn Andersson
l described in DT, therefore, assume it's eDP if panel node > is present. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Abel Vesa > --- > drivers/gpu/drm/msm/dp/dp_display.c | 29 - > 1 file changed, 28 insertions(+), 1 deletion(-)

[PATCH 2/6] drm/msm/dp: Removed fixed nvid "support"

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The "desc" member of struct dp_panel is zero-initialized during allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid() never returning true. This returned boolean value is passed around but never acted upon. Perform constant propagation and remove

[PATCH 6/6] drm/msm/dp: Use function arguments for audio operations

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The dp_audio read and write operations uses members in struct dp_catalog for passing arguments and return values. This adds unnecessary complexity to the implementation, as it turns out after detangling the logic that no state is actually held in these variables. Clean

[PATCH 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The members of struct dp_debug are no longer used, so the only purpose of this struct is as a type of the return value of dp_debug_get(), to signal success/error. Drop the struct in favor of signalling the result of initialization using an int. Signed-off-by: Bjorn

[PATCH 3/6] drm/msm/dp: Remove unused defines and members

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson Throughout the Qualcomm Displayport driver a number of defines and struct members has become unused, but lingers in the code. Remove these. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_audio.c | 5 - drivers/gpu/drm/msm/dp/dp_catalog.c | 1

[PATCH 4/6] drm/msm/dp: Use function arguments for aux writes

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson The dp_aux write operations takes the data to be operated on through a member of struct dp_catalog, rather than as an argument to the function. No state is maintained other than across the calling of the functions, so replace this member with a function argument. Signed

[PATCH 5/6] drm/msm/dp: Use function arguments for timing configuration

2024-03-26 Thread Bjorn Andersson
From: Bjorn Andersson dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from the calling function through members of struct dp_catalog. No state is maintained other than across this call, so switch to function arguments to clean up the code. Signed-off-by: Bjorn Andersson

[PATCH 0/6] drm/msm/dp: Spring cleaning

2024-03-26 Thread Bjorn Andersson
Spring is in the air, clean out some dust that has accumulated in the Qualcomm DP driver. Signed-off-by: Bjorn Andersson --- Bjorn Andersson (6): drm/msm/dp: Drop unused dp_debug struct drm/msm/dp: Removed fixed nvid "support" drm/msm/dp: Remove unused defines a

Re: [PATCH] accel/qaic: Add Sahara implementation for firmware loading

2024-03-22 Thread Bjorn Andersson
he device when an image is not available. The device will > evaluate if the image is required or not, and take the appropriate > action. > > Signed-off-by: Jeffrey Hugo > Reviewed-by: Carl Vanderlip > Reviewed-by: Pranjal Ramajor Asha Kanojiya Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the eDP/DP mode from DT

2024-03-22 Thread Bjorn Andersson
On Fri, Mar 22, 2024 at 03:22:22PM +0200, Abel Vesa wrote: > Instead of relying on different compatibles for eDP and DP, lookup > the panel node in devicetree to figure out the connector type and > then pass on that information to the PHY. External DP is not described > in DT, therefore, assume it'

Re: (subset) [PATCH 0/3] drm/panel: Pixel 3a Panel

2024-03-18 Thread Bjorn Andersson
s559nk06 compat > drm/panel: add samsung s6e3fa7 panel driver > arm64: dts: qcom: sdm670-google-sargo: add panel > > [...] Applied, thanks! [3/3] arm64: dts: qcom: sdm670-google-sargo: add panel commit: 232490b925272d54dd91847a183bdbc2deec904b Best regards, -- Bjorn Andersson

Re: [PATCH v2 2/3] drm/msm/dp: Add support for setting the eDP mode from devicetree

2024-02-27 Thread Bjorn Andersson
-off-by: Abel Vesa Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c| 11 +++ > drivers/gpu/drm/msm/dp/dp_ctrl.h| 1 + > drivers/gpu/drm/msm/dp/dp_display.c | 17 ++--- > 3 files changed, 26 insertions(+), 3 delet

Re: [PATCH 3/9] arm64: dts: qcom: sc7280: Enable MDP turbo mode

2024-02-22 Thread Bjorn Andersson
t; >> > > >> > > >> > > >> On 2/22/24 00:41, Dmitry Baryshkov wrote: > > >>> On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > > >>> wrote: > > >>>> > > >>>> The max frequency listed in the DPU

Re: [PATCH 6/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB role switching

2024-02-21 Thread Bjorn Andersson
On Thu, Feb 22, 2024 at 01:50:12AM +0200, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > wrote: > > > > With the ADSP remoteproc loaded pmic_glink can be introduced and wired > > up to provide role and orientation switching signals. >

Re: [PATCH 1/9] drm/msm/dp: Add DP support to combo instance in SC7280

2024-02-21 Thread Bjorn Andersson
On Thu, Feb 22, 2024 at 01:38:45AM +0200, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > wrote: > > > > When upstreamed the SC7280 DP controllers where described as one being > > DP and one eDP, but they can infact both be DP or eDP. >

Re: [PATCH RFC 3/3] drm/msm/dp: Add support for the X1E80100

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:33AM +0200, Abel Vesa wrote: > Add the X1E80100 DP descs and compatible. This platform will be using > a single compatible for both eDP and DP mode. The actual mode will > be set in devicetree via is-edp flag. > > Signed-off-by: Abel Vesa > --- > drivers/gpu/drm/msm

Re: [PATCH RFC 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:31AM +0200, Abel Vesa wrote: > Add the X1E80100 to the list of compatibles and docoment the is-edp s/docoment/document/ > flag. This new flag will be used from now on to dictate the mode from s/from now on// Perhaps cleaner to spell out that the controllers are exp

  1   2   3   4   5   6   7   8   9   >